Re: [HACKERS] Getting the red out (of the buildfarm)

* Tom Lane wrote: wombat, eukaryote, chinchilla: these are all failing with ... I wonder how up-to-date their scripts are. chinchilla's was ancient, until five minutes ago. Thanks for the prodding. I'm running a --test HEAD now. -- Christian Ullrich -- Sent via pgsql-hackers mailing

Re: [HACKERS] ecpglib use PQconnectdbParams

, plus the terminator. -- Christian Ullrich -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] leakproof

or PURE. Of all the suggestions I have seen in this thread, I think LEAKPROOF is actually the best fit for the purpose. My favorite alternative, just to suggest one, would be NONDISCLOSING/NOT DISCLOSING, but I prefer LEAKPROOF even over that, not just because it's shorter. -- Christian

Re: [HACKERS] Command Triggers, v16

varying (7 Zeilen) I think these are all specially handled in the parser. -- Christian Ullrich -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] SSPI client authentication in non-Windows builds

Hello all, this patch adds support for connecting to servers running on Windows and requesting SSPI authentication. It does this by treating AUTH_REQ_SSPI the same as AUTH_REQ_GSS if no native SSPI support is available. In addition to being generally useful, this is a workaround to a problem

Re: [HACKERS] SSPI client authentication in non-Windows builds

will automatically do the right thing on all platforms. -- Christian Ullrich -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Bug in pg_dump

* Joel Jacobson wrote: The example from Tom Lane below results in a database which is not possible to correctly dump using pg_dump. The view v1 strangely becomes a table in the dump output?! This is no bug, it's a feature (tm). pg_dump is clever enough to detect the circular dependency and

Re: [HACKERS] SSPI client authentication in non-Windows builds

Magnus Hagander wrote: On Mon, Jan 3, 2011 at 14:11, Christian Ullrichch...@chrullrich.net wrote: Hello all, this patch adds support for connecting to servers running on Windows and requesting SSPI authentication. It does this by treating AUTH_REQ_SSPI the same as AUTH_REQ_GSS if no native

Re: [HACKERS] SSPI client authentication in non-Windows builds

* Christian Ullrich wrote: Magnus Hagander wrote: On Mon, Jan 3, 2011 at 14:11, Christian Ullrichch...@chrullrich.net wrote: This change has been tested and works correctly on FreeBSD 8.1, using the Kerberos and GSSAPI libraries from Heimdal 1.4. The server is running PostgreSQL 9.0.2

Re: [HACKERS] SSPI client authentication in non-Windows builds

* Magnus Hagander wrote: However, i think the code path down around the error message is simply incorrect. That #ifdef spaghetti is pretty hard to parse, but it gives the wrong error message (we should say it's sspi that's not available when we have none of the two options) and/or a duplicate

Re: [HACKERS] Authentication Enhancement Proposal

* Christopher Hotchkiss wrote: I would like to propose (and volunteer to do if its considered to be a decent idea) to extend the mapping of users to roles in the pg_ident.conf to incorporate groups. This would allow any user who belonged to a particular group in certain authentication systems

Re: [HACKERS] Authentication Enhancement Proposal

* Christopher Hotchkiss wrote: On Tue, Feb 1, 2011 at 2:49 PM, Christian Ullrichch...@chrullrich.net wrote: * Christopher Hotchkiss wrote: I would like to propose (and volunteer to do if its considered to be a decent idea) to extend the mapping of users to roles in the pg_ident.conf to

[HACKERS] Bug in buildfarm client

Hello all, the extension modules (TestUpgrade etc.) in the buildfarm client do not use the make command override defined in the config file, instead hardcoding command lines using make. This fails where make is not GNU make. Patch attached, which fixes the problem on jaguarundi. --

Re: [HACKERS] Bug in buildfarm client

* Andrew Dunstan wrote: On 12/04/2012 02:40 AM, Christian Ullrich wrote: the extension modules (TestUpgrade etc.) in the buildfarm client do not use the make command override defined in the config file, Patch attached, which fixes the problem on jaguarundi. Thanks, I will fix

Re: [HACKERS] strange isolation test buildfarm failure on guaibasaurus

* Tom Lane wrote: We really need to scare up another buildfarm member to run with -DCLOBBER_CACHE_ALWAYS, now that jaguar has stopped doing so. I would be happy to do that on jaguarundi, in exchange for dialing down the build frequency from hourly to something a bit less ambitious. That

Re: [HACKERS] PL/perl should fail on configure, not make

* Christoph Berg wrote: Re: Tom Lane 2013-01-09 9802.1357702...@sss.pgh.pa.us and Python.h. However, adding one won't fix your problem on Debian-based distros, because for some wacko reason they put the headers and the shlib .so symlink in different packages, cf

[HACKERS] Bug in pg_env.bat from one-click installer

Hello all, the EDB one-click installer has a slightly annoying bug in its pg_env.bat script: @SET PATH=C:\Program Files\PostgreSQL\9.1\bin;%PATH% PATH entries should not be quoted. As it is, every time a program is started from this path, I get a message along the lines of could

[HACKERS] Small 9.1 documentation fix (SSPI auth)

When Magnus fixed and applied my SSPI-via-GSS patch in January, we forgot to fix to the documentation. Suggested patch attached; should I also put that four-liner into any CFs? -- Christian diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.sgml new file mode 100644 index

Re: [HACKERS] Small 9.1 documentation fix (SSPI auth)

* Robert Haas wrote: On Fri, Jun 24, 2011 at 6:07 PM, Christian Ullrichch...@chrullrich.net wrote: When Magnus fixed and applied my SSPI-via-GSS patch in January, we forgot to fix to the documentation. Suggested patch attached; should I also put that four-liner into any CFs? I have

Re: [HACKERS] isolation tests are not being run in buildfarm

* Alvaro Herrera wrote: [ ... looks some more ... ] Oh, it seems inconsistent. Several hosts do not run it at all; chinchilla and anchovy are running the wrong make target; but at least chough seems to be doing it right. Crake is good too. chinchilla and jaguarundi are now running the

Re: [HACKERS] Removal of useless include references

* Bruce Momjian wrote: The attached patch removes unneeded include references, and marks some includes as needing to be skipped by pgrminclude. There are several unrelated changes to pg_upgrade in that patch, too. -- Christian -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [GENERAL] Text search parser's treatment of URLs and emails

* Bruce Momjian wrote: Thom Brown wrote: Also: SELECT alias, description, token FROM ts_debug('myname+prior...@gmail.com'); Yields: alias | description | token ---+-+ asciiword | Word, all ASCII | myname blank | Space

[HACKERS] Unexpected collation error in 9.1.1

I tried adding a not-null column in one step and got a collation error for a different column. Adding the column in several steps works: itd= alter table livedata add column pricechanged timestamp not null default current_timestamp; ERROR: no collation was derived for column whois_b with

Re: [HACKERS] Unexpected collation error in 9.1.1

* Tom Lane wrote: Christian Ullrichch...@chrullrich.net writes: I tried adding a not-null column in one step and got a collation error for a different column. itd= alter table livedata add column pricechanged timestamp not null default current_timestamp; ERROR: no collation was

Re: [HACKERS] superusers are members of all roles?

* Andrew Dunstan wrote: On 04/07/2011 03:48 AM, Alastair Turner wrote: Is the solution possibly to assign positive entries on the basis of the superuser being a member of all groups but require negative entries to explicitly specify that they apply to superuser? I think that's just about

Re: [HACKERS] Hard limit on WAL space used (because PANIC sucks)

* Heikki Linnakangas wrote: The current situation is that if you run out of disk space while writing WAL, you get a PANIC, and the server shuts down. That's awful. We can So we need to somehow stop new WAL insertions from happening, before it's too late. A naive idea is to check if

Re: [HACKERS] Bad error message on valuntil

* Tom Lane wrote: it supposes that rolvaliduntil represents an expiration date for the user, but really it's only an expiration date for the password.) Does anyone think the docs for CREATE ROLE/VALID UNTIL should mention this more clearly? Currently, it is described as The VALID

[HACKERS] Current CLOBBER_CACHE_ALWAYS failures

The CLOBBER_CACHE_ALWAYS animals (friarbird and jaguarundi) have been failing persistently for about 36 hours now. The error is in a test added by Tom's recent commit a4424c5: Expected: -- Check row comparisons with IN select * from int8_tbl i8 where i8 in (row(123,456)); -- fail, type

Re: [HACKERS] Bison 3.0 updates

* Andrew Dunstan wrote: I'm toying with the idea of a check_upgrade mode for the buildfarm client where it wouldn't do a git pull, but would report changes if the build result was different from the previous result. You'd run this immediately after pulling new changes into your OS. Other,

[HACKERS] Re: [GENERAL] postgresql-9.3.1-1-windows-x64.exe does not install correctly for me

* Dann Corbit wrote: The PostgreSQL installer for Windows 64 appears to be broken for Microsoft Windows Server 2012 Standard. Even after uninstalling, removing the entire postgresql directory structure, and running the installer as administrator, I get this error: fixing permissions on

[HACKERS] Re: PostgreSQL Service on Windows does not start. ~ is not a valid Win32 application

* Tom Lane wrote: I looked at this patch a bit. I agree that we need to fix pgwin32_CommandLine to double-quote the executable name, but it needs a great deal more work than that :-(. Whoever wrote this code was One additional issue is that the path to the service executable should use

[HACKERS] PostgreSQL in Windows console and Ctrl-C

Hello all, when pg_ctl start is used to run PostgreSQL in a console window on Windows, it runs in the background (it is terminated by closing the window, but that is probably inevitable). There is one problem, however: The first Ctrl-C in that window, no matter in which situation, will cause

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

* From: Amit Kapila Another thing to decide about this fix is that whether it is okay to fix it for CTRL+C and leave the problem open for CTRL+BREAK? (The current option used (CREATE_NEW_PROCESS_GROUP) will handle only CTRL+C). I can think of three situations in which a postgres process can

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

* From: Amit Kapila On Sat, Apr 12, 2014 at 12:36 PM, Christian Ullrich ch...@chrullrich.net wrote: * From: Amit Kapila Another thing to decide about this fix is that whether it is okay to fix it for CTRL+C and leave the problem open for CTRL+BREAK? (The current option used

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

* From: Amit Kapila On Sun, Apr 13, 2014 at 5:59 PM, Christian Ullrich ch...@chrullrich.net wrote: There are some possible solutions: - pg_ctl could set an environment variable (unless it has to be compatible with postmasters from different versions, and it does not, does

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

* From: Robert Haas On Mon, Apr 14, 2014 at 2:16 AM, Christian Ullrich ch...@chrullrich.net wrote: I meant creating a new one, yes. If, say, PGSQL_BACKGROUND_JOB was set, the postmaster etc. would ignore the events. Why not just pass a command-line switch? Because, as I wrote

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

* From: Bruce Momjian On Mon, Apr 14, 2014 at 09:34:14AM +0530, Amit Kapila wrote: The problem can be solved this way, but the only question here is whether it is acceptable for users to have a new console window for server. Can others also please share their opinion if this fix (start

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

* From: Amit Kapila On Mon, Apr 14, 2014 at 11:46 AM, Christian Ullrich ch...@chrullrich.net wrote: * From: Amit Kapila Do you mean to say use some existing environment variable? Introducing an environment variable to solve this issue or infact using some existing environ variable

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

OK, here is the first draft against current master. It builds on Windows with VS 2012 and on FreeBSD 10 with clang 3.3. I ran the regression tests on Windows, they all pass. The changed behavior is limited to Windows, where it now silently ignores Ctrl-C and Ctrl-Break when started via pg_ctl

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

* From: MauMau [mailto:maumau...@gmail.com] From: Christian Ullrich ch...@chrullrich.net OK, here is the first draft against current master. It builds on Windows with VS 2012 and on FreeBSD 10 with clang 3.3. I ran the regression tests on Windows, they all pass. The changed behavior

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

* From: Noah Misch [mailto:n...@leadboat.com] I liked the proposal here; was there a problem with it? http://www.postgresql.org/message- id/ca+tgmoz3ake4enctmqmzsykc_0pjl_u4c_x47ge48uy1upb...@mail.gmail.com You're referring to the suggestion of accepting and ignoring the option on

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

* From: Noah Misch [mailto:n...@leadboat.com] On Mon, Jun 30, 2014 at 07:28:03PM +, Christian Ullrich wrote: * From: Noah Misch [mailto:n...@leadboat.com] I liked the proposal here; was there a problem with it? http://www.postgresql.org/message- id/ca

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

* Alvaro Herrera wrote: Michael Paquier wrote: Btw, perhaps this diff should be pushed as a different patch as this is a rather different thing: - if (heapRelation-rd_rel-relpersistence == RELPERSISTENCE_UNLOGGED + if (indexRelation-rd_rel-relpersistence ==

Re: [HACKERS] New Python vs. old PG on raccoon and jaguarundi

* From: Noah Misch [mailto:n...@leadboat.com] Buildfarm member jaguarundi, which has Python 3.4, activated --with- python for REL9_1_STABLE as of its 2014-12-15 run. Please remove -- with-python or test against an older Python. It already omits --with- python for REL9_0_STABLE. Done; sorry

Re: [HACKERS] [committers] pgsql: RLS fixes, new hooks, and new test module

* Stephen Frost wrote: RLS fixes, new hooks, and new test module The buildfarm says that with -DCLOBBER_CACHE_ALWAYS, the RLS violations get blamed on the wrong tables. Mostly, they are catalogs (I have seen pg_opclass, pg_am, and pg_amproc), but some also come up with binary garbage

Re: [HACKERS] transforms vs. CLOBBER_CACHE_ALWAYS

* Andrew Dunstan: friarbird is a FreeBSD buildfarm animal running with -DCLOBBER_CACHE_ALWAYS. It usually completes a run in about 6.5 hours. However, it's been stuck since Monday running the plpython regression tests. The only relevant commit seems to be the transforms feature. Here's what

Re: [HACKERS] transforms vs. CLOBBER_CACHE_ALWAYS

* Peter Eisentraut wrote: On 4/30/15 2:49 PM, Andrew Dunstan wrote: friarbird is a FreeBSD buildfarm animal running with -DCLOBBER_CACHE_ALWAYS. It usually completes a run in about 6.5 hours. However, it's been stuck since Monday running the plpython regression tests. The only relevant

Re: [HACKERS] transforms vs. CLOBBER_CACHE_ALWAYS

* Tom Lane wrote: Christian Ullrich ch...@chrullrich.net writes: * Peter Eisentraut wrote: On 4/30/15 2:49 PM, Andrew Dunstan wrote: friarbird is a FreeBSD buildfarm animal running with -DCLOBBER_CACHE_ALWAYS. It usually completes a run in about 6.5 hours. However, it's been stuck since

Re: [HACKERS] libxml2 2.9.3 breaks xml test output

* Michael Paquier wrote: On Sat, Dec 5, 2015 at 4:38 PM, Christian Ullrich <ch...@chrullrich.net> wrote: I have zero experience with libxml2, so no idea if the previous context level can be turned on again. IMHO, the libxml2 change is a bug in itself; PostgreSQL's error messages ar

[HACKERS] libxml2 2.9.3 breaks xml test output

Hello, I just noticed that last night all built branches failed on my buildfarm animal, jaguarundi. They all failed on the "xml" test, and the output is essentially the same everywhere: *** *** 9,16 LINE 1: INSERT INTO xmltest VALUES (3, '

[HACKERS] Close handle leak in SSPI auth

Hello, here's a one-line patch to close a handle leak in pg_SSPI_recvauth(). According to the docs, the token retrieved with QuerySecurityContextToken() must be closed. -- Christian diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c new file mode 100644 index 0131bfd..57c2f48

Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used

* Christian Ullrich wrote: * Christian Ullrich wrote: * Christian Ullrich wrote: > According to the release notes, the default for the "include_realm" > option in SSPI authentication was changed from off to on in 9.5 for > > improved security. However, the a

Re: [HACKERS] pl/pgSQL, get diagnostics and big data

Ah, so it turns out I should have used the commitfest tool. My apologies; I will send the whole thing through that again. Please disregard the earlier message. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] Crash with old Windows on new CPU

Hello, I just found a compatibility issue when I was migrating an elderly VM to a new host. The VM is running Windows Server 2008 SP2, and it has the EDB build of PostgreSQL 9.4.5 on it. (9.4.6 behaves the same.) It is also not dependent on running in a VM; it would fail on the hardware as

Re: [HACKERS] pl/pgSQL, get diagnostics and big data

* Andreas 'ads' Scherbaum wrote: one of our customers approached us and complained, that GET DIAGNOSTICS row_count returns invalid results if the number of rows is > 2^31. It's Attached patch expands the row_count to 64 bit. diagnostics=# select testfunc_pg((2^32 + 5)::bigint);

Re: [HACKERS] pl/pgSQL, get diagnostics and big data

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: tested, failed Spec compliant: not tested Documentation:not tested * Andreas 'ads' Scherbaum wrote: > one of our customers approached us

Re: [HACKERS] Crash with old Windows on new CPU

On February 13, 2016 4:10:34 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > Christian Ullrich <ch...@chrullrich.net> writes: >> * Robert Haas wrote: >>> Thanks for the report and patch. Regrettably I haven't the Windows >>> knowledge to have any idea whe

Re: [HACKERS] Crash with old Windows on new CPU

* Robert Haas wrote: On Fri, Feb 12, 2016 at 7:26 PM, Christian Ullrich <ch...@chrullrich.net> wrote: startup_hacks(), I think. Proposed patch attached. Thanks for the report and patch. Regrettably I haven't the Windows knowledge to have any idea whether it's right or wrong, but hop

Re: [HACKERS] Crash with old Windows on new CPU

* From: Christian Ullrich > On February 13, 2016 4:10:34 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > > > Christian Ullrich <ch...@chrullrich.net> writes: > > Lastly, I'd like to see some discussion of what side effects > > "_set_FMA3_enable(0);" has .

Re: [HACKERS] pl/pgSQL, get diagnostics and big data

* Andreas 'ads' Scherbaum wrote: Attached is a new version of the patch, with %lu replaced by %zu. I re-ran all the tests, especially the long test with 2^32+x rows, and it produces the same result as before. To paraphrase Twain: "Sire, the Board finds this patch perfect in all the

Re: [HACKERS] Crash with old Windows on new CPU

* Christian Ullrich wrote: Backends (and possibly other processes) crash at the slightest provocation, such as "SELECT * FROM pg_stat_activity;" or VACUUM. The log says either "exception 0xC005" (segfault) or "exception 0xC01D" (illegal instruction). T

Re: [HACKERS] Crash with old Windows on new CPU

* Magnus Hagander wrote: On Wed, Mar 9, 2016 at 4:36 PM, Christian Ullrich <ch...@chrullrich.net> wrote: * Magnus Hagander wrote: How does this work wrt mingw, though? Do we have the same problem there? AIUI this code can never run on mingw, correct? Not unless mingw defines _M

Re: [HACKERS] Crash with old Windows on new CPU

* Magnus Hagander wrote: I did notice the #ifdef's are actually different in the header and body section of the patch, which seems wrong. I used the one from the actual implementation (_M_AMD64) for the header includes as, and also merged the #ifdef's together to a single #if in each section.

[HACKERS] New Windows animal, mostly ecpg trouble (was: Crash with old Windows on new CPU)

* Alvaro Herrera wrote: Magnus Hagander wrote: On Wed, Mar 9, 2016 at 4:36 PM, Christian Ullrich <ch...@chrullrich.net> wrote: And apparently not a single one with VS 2013. OK, I'll see what I can do about setting some up soonish, at least with (server) 2008 and (client) 7. FWIW,

Re: [HACKERS] Crash with old Windows on new CPU

* Peter Eisentraut wrote: On 2/12/16 11:24 AM, Christian Ullrich wrote: Otherwise, it may be time to update the manual (15.6 Supported Platforms) where it says PostgreSQL "can be expected to work on these operating systems: [...] Windows (Win2000 SP4 and later), [...]". Perhaps we

Re: [HACKERS] Crash with old Windows on new CPU

* Magnus Hagander wrote: On Sat, Feb 13, 2016 at 4:45 PM, Christian Ullrich <ch...@chrullrich.net> wrote: On February 13, 2016 4:10:34 PM Tom Lane <t...@sss.pgh.pa.us> wrote: I'm also suspicious of the "#if _MSC_VER == 1800" tests, that is, the code compiles on *exa

Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used

* From: Magnus Hagander [mailto:mag...@hagander.net] > I took a quick look at this one, and have some initial thoughts. > > I don't like the name "real_realm" as a parameter name. I'm wondering if > it might be better to reverse the meaning, and call it sspi_netbios_realm > (and then change the

Re: [HACKERS] VS 2015 support in src/tools/msvc

* Petr Jelinek wrote: On 07/04/16 00:50, Michael Paquier wrote: On Thu, Apr 7, 2016 at 7:44 AM, Michael Paquier wrote: On Thu, Apr 7, 2016 at 6:11 AM, Petr Jelinek wrote: On 06/04/16 22:50, Andrew Dunstan wrote: * VS2015 appears to

Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used

* Magnus Hagander wrote: On Tue, Mar 29, 2016 at 5:09 PM, David Steele wrote: It seems like this patch should be set "ready for committer". Can one of the reviewers do that if appropriate? I'll pick it up to do that as well as committing it. Magnus, do you intend

[HACKERS] Lower msvc build verbosity level

Hello, could we perhaps lower the verbosity level of the msvc build (in src/tools/msvc/build.pl) from "detailed" to "normal"? In my experiment, this reduces the size of the build log by 96.4 percent (from 12.5 MiB to 438 KiB), or if the log is not redirected, it shortens the build time by 45

Re: [HACKERS] VS 2015 support in src/tools/msvc

* Michael Paquier wrote: > On Fri, Apr 8, 2016 at 9:29 AM, Andrew Dunstan > wrote: Not out of the woods yet. Attached is what I got from VS2015 on a fresh W10 VM, with Michael's patch 0002 and 0004 applied. Interesting, I have no idea what we are doing differently,

Re: [HACKERS] Lower msvc build verbosity level

* Tom Lane wrote: +several. Grepping for compiler warnings, for example, is really painful right now on any MSVC critter. I've resorted to grepping for "warning C", which skips the noise messages, but I'm never sure if I'm missing something. You miss all diagnostics from other tools than

Re: [HACKERS] VS 2015 support in src/tools/msvc

* Andrew Dunstan wrote: On 04/08/2016 11:02 AM, Christian Ullrich wrote: src/port/chklocale.c(233): warning C4133: 'function': incompatible types - from 'const char *' to 'LPCWSTR' [...\postgres.vcxproj] Do you have a fix for the LPCWSTR parameter issue? As long as the locale short

Re: [HACKERS] VS 2015 support in src/tools/msvc

* Michael Paquier wrote: On Fri, Apr 8, 2016 at 10:05 PM, Andrew Dunstan <and...@dunslane.net> wrote: ¥> On 04/08/2016 07:15 AM, Christian Ullrich wrote: Michael, none of your patches change this, so how does it ever build on your system? Luck. I am getting a warning but the cod

Re: [HACKERS] VS 2015 support in src/tools/msvc

> Michael Paquier wrote: > > On Sat, Apr 9, 2016 at 7:41 AM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> On Sat, Apr 9, 2016 at 1:46 AM, Christian Ullrich <ch...@chrullrich.net> >> wrote: >>> * Andrew Dunstan wrote: >>>>>

Re: [HACKERS] Preprocessor condition fix

* Tom Lane wrote: Christian Ullrich <ch...@chrullrich.net> writes: According to git grep, this is the only place where WIN64 is used without the leading underscore. Hm, my grep found another one ... Oh, sorry. I saw that one, but thought it was intentional because _WIN64 is d

[HACKERS] Preprocessor condition fix

. -- Christian From 9bc9e8ed79747f7bf3e727c9f64f4a088de589fb Mon Sep 17 00:00:00 2001 From: Christian Ullrich <ch...@chrullrich.net> Date: Mon, 11 Apr 2016 15:47:20 +0200 Subject: [PATCH] Fixed preprocessor condition (WIN64 -> _WIN64). --- src/test/regress/pg_regress.c | 2 +- 1 file c

Re: [HACKERS] Preprocessor condition fix

* From: Tom Lane [mailto:t...@sss.pgh.pa.us] > Christian Ullrich <ch...@chrullrich.net> writes: > > * Tom Lane wrote: > >> Hm, my grep found another one ... > > > Oh, sorry. I saw that one, but thought it was intentional because _WIN64 > > is defined

Re: [HACKERS] VS 2015 support in src/tools/msvc

* Andrew Dunstan: On 04/09/2016 08:43 AM, Christian Ullrich wrote: Michael Paquier wrote: I don't think that's good to use malloc in those code paths, and I Oh? +#if (_MSC_VER >= 1900) + uint32 cp; + + if (GetLocaleInfoEx(ct

Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used

On 2016-03-24 16:35, Christian Ullrich wrote: * From: Robbie Harwood [mailto:rharw...@redhat.com] Christian Ullrich <ch...@chrullrich.net> writes: pg_SSPI_recvauth(Port *port) { int mtype; + int status; The s

Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used

* From: Christian Ullrich > * From: Robbie Harwood [mailto:rharw...@redhat.com] > > > Christian Ullrich <ch...@chrullrich.net> writes: > > > + /* Replace domainname with realm name. */ > > > + if (upnamerealmsize > domainnamesize) > >

Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used

* From: Robbie Harwood [mailto:rharw...@redhat.com] > Christian Ullrich <ch...@chrullrich.net> writes: > > > Updated patch attached. > > I unfortunately don't have windows machines to test this on, but I > thought it might be helpful to review this anyway since I'm

Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used

* Christian Ullrich wrote: * From: Magnus Hagander [mailto:mag...@hagander.net] I don't like the name "real_realm" as a parameter name. I'm wondering if it might be better to reverse the meaning, and call it sspi_netbios_realm (and then change the default to on, to be backwards

Re: [BUGS] Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used

* From: Alvaro Herrera [mailto:alvhe...@2ndquadrant.com] > Christian Ullrich wrote: > > * Christian Ullrich wrote: > > > > >* From: Magnus Hagander [mailto:mag...@hagander.net] > > > >>Code uses a mix of malloc() and palloc() (through sprintf). Is ther

[HACKERS] Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c.

* Tom Lane wrote: Michael Paquier writes: Buildfarm-not-being-happy-status: woodloose, mastodon, thrips, jacana. http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=woodlouse=2016-03-29%2000%3A42%3A08 The origin of the problem is that, which prevents all the

Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used

* Magnus Hagander wrote: On Tue, Mar 29, 2016 at 5:09 PM, David Steele wrote: It seems like this patch should be set "ready for committer". Can one of the reviewers do that if appropriate? I'll pick it up to do that as well as committing it. Ah, good news! I hope

[HACKERS] Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c.

* Tom Lane wrote: Christian Ullrich <ch...@chrullrich.net> writes: zic aborts somewhere between writing Etc/UTC and UTC. Huh ... I would not have guessed that. Can you track down exactly where it's failing? I'd love to, but with 656ee84 I cannot reproduce on my Windows 10 system.

[HACKERS] Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c.

* Christian Ullrich wrote: * Tom Lane wrote: Christian Ullrich <ch...@chrullrich.net> writes: zic aborts somewhere between writing Etc/UTC and UTC. Huh ... I would not have guessed that. Can you track down exactly where it's failing? I'd love to, but with 656ee84 I cannot rep

[HACKERS] [PATCH] Improve safety of FormatMessage() calls on Windows

There are some instances of calls to FormatMessage() with the FORMAT_MESSAGE_FROM_SYSTEM flag that omit the FORMAT_MESSAGE_IGNORE_INSERTS flag. The effect of that is that if the requested message string contains any insertion markers, the call to FormatMessage() will fail because none of these

[HACKERS] Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c.

* Tom Lane wrote: Christian Ullrich <ch...@chrullrich.net> writes: Anyway, I think Michael's fix is wrong. The bug is that the Win32 version of link() (at the bottom of zic.c) does not set errno if its attempt to copy the file fails, so what dolink() puts into link_errno is bogus.

Re: [HACKERS] VS 2015 support in src/tools/msvc

* Andrew Dunstan wrote: On 04/24/2016 03:16 PM, Christian Ullrich wrote: * Andrew Dunstan wrote: msvcr120.dll seems to be the highest numbered one on my system, and we already cover that. If you like we can add to the comments in that file. There won't be a higher one, with VS 2015, CRT

Re: [HACKERS] VS 2015 support in src/tools/msvc

* Andrew Dunstan wrote: OK, here's my final version of the patch, which I will apply in 24 hours or so unless there is an objection. + Visual Studio 2008 and above. Compilation + is supported down to Windows XP and + Windows Server 2003 when building with + Visual Studio 2005 to + Visual

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

* Magnus Hagander wrote: Add putenv support for msvcrt from Visual Studio 2013 This was missed when VS 2013 support was added. Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9f633b404cb3be6139f8dfdea00538489ffef9ab Just noticed something. This

Re: [HACKERS] VS 2015 support in src/tools/msvc

* Andrew Dunstan wrote: On 04/24/2016 12:14 PM, Tom Lane wrote: Andrew Dunstan writes: OK, here's my final version of the patch, which I will apply in 24 hours or so unless there is an objection. BTW, in view of 9f633b404, shouldn't there be a similar addition to

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

* Magnus Hagander wrote: On Sun, Apr 24, 2016 at 9:56 PM, Christian Ullrich <ch...@chrullrich.net> wrote: * Magnus Hagander wrote: Add putenv support for msvcrt from Visual Studio 2013 http://git.postgresql.org/pg/commitdiff/9f633b404cb3be6139f8dfdea00538489ffef9ab Just noticed som

Re: [HACKERS] VS 2015 support in src/tools/msvc

* Andrew Dunstan wrote: On 04/22/2016 02:46 AM, Michael Paquier wrote: Progress report: 1. My VS 2015 installations (I now have several) all generate solution file with: Microsoft Visual Studio Solution File, Format Version 12.00 so I propose to set that as the solution file version.

Re: [HACKERS] VS 2015 support in src/tools/msvc

* Christian Ullrich wrote: * Andrew Dunstan wrote: On 04/22/2016 02:46 AM, Michael Paquier wrote: Progress report: 1. My VS 2015 installations (I now have several) all generate solution file with: Microsoft Visual Studio Solution File, Format Version 12.00 so I propose to set

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

* Andrew Dunstan wrote: On 04/25/2016 09:27 AM, Christian Ullrich wrote: * Magnus Hagander wrote: On Sun, Apr 24, 2016 at 9:56 PM, Christian Ullrich <ch...@chrullrich.net> wrote: Just noticed something. This DLL detection by name has never worked in debug builds where the DLL nam

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

* Christian Ullrich wrote: * Andrew Dunstan wrote: What if both are present? Is a release build prevented from loading a debug dll and vice versa? Debug and release are simply two separate CRTs. If your process contains a module that needs the one, and another that needs the other, you

Re: [HACKERS] VS 2015 support in src/tools/msvc

* From: Andrew Dunstan [mailto:and...@dunslane.net] > 4. The compiler complains about one of Microsoft's own header files - > essentially it dislikes the=is construct: > > typedef enum { ... }; > > It would be nice to make it shut up about it. I doubt that's possible; the declaration *is*

  1   2   >