On 19/04/15 01:24, Michael Paquier wrote:
On Sat, Apr 18, 2015 at 8:38 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Apr 17, 2015 at 10:54 PM, Petr Jelinek wrote:
On 10/04/15 06:46, Michael Paquier wrote:
13) Some regression tests with pg_tablesample_method would be welcome
On 20/04/15 17:50, Heikki Linnakangas wrote:
On 03/15/2015 09:07 PM, Petr Jelinek wrote:
Slightly updated version of the patch.
Mainly rebased against current master (there were several conflicts) and
fixed some typos, no real functional change.
I also attached initial version of the API sgml
want, but I'm not really seeing the advantage.
I think the only value of having DDL for this would be consistency
(catalog objects are created via DDL) as it looks like something that
will be called only by extensions and not users during normal operation.
--
Petr Jelinek
really suggests to me that it should be index specific by design.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
, it is a sensible use of bytes.
+1 to Andres' very reasonable suggestion. Lets commit this and go home.
+1
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
years, which would need those 2 bytes.
But if we are willing to pay it then we can really go all the way and
just use Oids...
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql
On 10/04/15 21:26, Peter Eisentraut wrote:
On 4/9/15 8:58 PM, Petr Jelinek wrote:
Well, you can have two approaches to this, either allow some specific
set of keywords that can be used to specify limit, or you let sampling
methods interpret parameters, I believe the latter is more flexible
On 10/04/15 22:16, Tomas Vondra wrote:
On 04/10/15 21:57, Petr Jelinek wrote:
On 10/04/15 21:26, Peter Eisentraut wrote:
But this was not really my point, the BERNOULLI just does not work
well with row-limit by definition, it applies probability on each
individual row and while you can get
method is using it).
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 06/04/15 12:33, Amit Kapila wrote:
On Sat, Apr 4, 2015 at 8:25 PM, Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com wrote:
Yes I want extensibility here. And I think the tablesample method
arguments are same thing as function arguments given that in the end
they are arguments
On 06/04/15 15:07, Amit Kapila wrote:
On Mon, Apr 6, 2015 at 5:56 PM, Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com wrote:
On 06/04/15 12:33, Amit Kapila wrote:
But I think the Update on target table with sample scan is
supported via views which doesn't seem
On 06/04/15 11:02, Simon Riggs wrote:
On 2 April 2015 at 17:36, Petr Jelinek p...@2ndquadrant.com wrote:
so here is version 11.
Looks great.
Comment on docs:
The SELECT docs refer only to SYSTEM and BERNOULLI. It doesn't mention
that if other methods are available they could be used also
:
Sample Scan (System) on test_tablesample ...
Good idea.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
On 05/04/15 01:03, Tomas Vondra wrote:
Hi there,
the changes in _hash_splitbucket() made nblkno unused when compiled
without asserts. Attached is a simple fix to get rid of the warnings.
This has been already fixed, see b7e1652d5 .
--
Petr Jelinek http://www
. Hopefully I didn't muff this; please check it.
- Fixed an OID conflict.
- And of course, bumped catversion.
And that's broken the buildfarm. Argh.
That's because of this:
+#ifdef SIZEOF_DATUM == 8
You need just #if there.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL
On 02/04/15 22:22, Robert Haas wrote:
On Thu, Apr 2, 2015 at 4:21 PM, Petr Jelinek p...@2ndquadrant.com wrote:
On 02/04/15 21:21, Robert Haas wrote:
On Thu, Apr 2, 2015 at 2:07 PM, Robert Haas robertmh...@gmail.com wrote:
I think this is really nice work, so I have committed this version. I
it
sends as nbuf to that function via start_nblkno, I think the Assert is
somewhat pointless there anyway.
So best way to solve this seems to be removing the start_nblkno from the
_hash_splitbucket altogether. Attached patch does just that.
--
Petr Jelinek http://www.2ndQuadrant.com
name does not really make sense.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref
On 01/04/15 18:38, Robert Haas wrote:
On Wed, Apr 1, 2015 at 12:15 PM, Petr Jelinek p...@2ndquadrant.com wrote:
REPEATABLE is mandated by standard. I did try for quite some time to make it
unreserved but was not successful (I can only make it unreserved if I make
it mandatory but that's
the node 'foo' which no longer exists.
This can have bad effects for example on conflict detection or debugging
problems with replication.
Maybe another reason to use standard Oids?
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
of that?
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
NumericDigit is ok and the second one
is corrupted (there are only 2 NumericDigits in those numbers). Of
course the conversion to Numeric is done from the end so it looks like
only the last computation/pointer change/something stays ok while the
rest got corrupted.
--
Petr Jelinek
On 22/03/15 13:59, Andreas Karlsson wrote:
On 03/22/2015 11:47 AM, Petr Jelinek wrote:
On 22/03/15 10:35, Andres Freund wrote:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacanadt=2015-03-21%2003%3A01%3A21
That's the stuff looking like random memory that I talk about above
of Numeric
abbreviations patch. So +1 for that.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org
On 16/03/15 00:37, Andreas Karlsson wrote:
On 03/15/2015 09:47 PM, Petr Jelinek wrote:
It's almost the same thing as you wrote but the 128 bit and 64 bit
optimizations are put on the same level of optimized routines.
But this is nitpicking at this point, I am happy with the patch as it
stands
also.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
will be used for SUM and AVG of these data types.
*/
It's almost the same thing as you wrote but the 128 bit and 64 bit
optimizations are put on the same level of optimized routines.
But this is nitpicking at this point, I am happy with the patch as it
stands right now.
--
Petr Jelinek
On 22/02/15 01:59, Petr Jelinek wrote:
On 21/02/15 22:09, Andrew Dunstan wrote:
On 02/16/2015 09:05 PM, Petr Jelinek wrote:
I found one more issue with the 1.2--1.3 upgrade script, the DROP
FUNCTION pg_stat_statements(); should be DROP FUNCTION
pg_stat_statements(bool); since in 1.2
On 13/03/15 15:06, Petr Jelinek wrote:
On 12/03/15 15:53, Andres Freund wrote:
On 2015-03-12 15:52:02 +0100, Andres Freund wrote:
I guess what you actually intended to test was StandbyModeRequested?
Err, EnableHotStandby.
Yeah pause does not work currently. This change was made
was to make it a little safer by
silently changing to shutdown instead of silently changing to promote
which is essentially what was happening before the patch.
But yes the check should have been against EnableHotStandby it seems.
--
Petr Jelinek http://www.2ndQuadrant.com
On 01/03/15 16:49, Andrew Dunstan wrote:
On 03/01/2015 05:03 AM, Petr Jelinek wrote:
On 23/02/15 18:15, Dmitry Dolgov wrote:
Hi, Petr, thanks for the review.
I think it would be better if the ident printing didn't put the
start of array ([) and start of dictionary ({) on separate line
Did
On 10/03/15 10:54, Amit Kapila wrote:
On Tue, Mar 10, 2015 at 3:03 PM, Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com wrote:
Ok now I think I finally understand what you are suggesting - you are
saying let's go over whole page while tsmnexttuple returns something,
and do
On 10/03/15 04:43, Amit Kapila wrote:
On Mon, Mar 9, 2015 at 3:08 PM, Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com wrote:
On 09/03/15 04:51, Amit Kapila wrote:
On Sat, Mar 7, 2015 at 10:37 PM, Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com
Double
.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 09/03/15 13:39, Andreas Karlsson wrote:
On 03/07/2015 07:18 PM, Petr Jelinek wrote:
What I am wondering is if those numeric_int16_* functions that also deal
with either the Int128AggState or NumericAggState should be renamed in
similar fashion.
You mean something like numeric_poly_sum
On 09/03/15 18:39, David Fetter wrote:
On Mon, Mar 09, 2015 at 01:39:04PM +0100, Andreas Karlsson wrote:
On 03/07/2015 07:18 PM, Petr Jelinek wrote:
What I am wondering is if those numeric_int16_* functions that also deal
with either the Int128AggState or NumericAggState should be renamed
On 09/03/15 04:51, Amit Kapila wrote:
On Sat, Mar 7, 2015 at 10:37 PM, Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com wrote:
On 05/03/15 09:21, Amit Kapila wrote:
On Tue, Feb 17, 2015 at 3:29 AM, Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com
mailto:p
, in the attached version of the patch. I
think it looks better after the changes.
I think this made the patch much better indeed.
What I am wondering is if those numeric_int16_* functions that also deal
with either the Int128AggState or NumericAggState should be renamed in
similar fashion.
--
Petr
On 05/03/15 09:21, Amit Kapila wrote:
On Tue, Feb 17, 2015 at 3:29 AM, Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com wrote:
I didn't add the whole page visibility caching as the tuple ids we
get from sampling methods don't map well to the visibility info we get
from
On 22/02/15 12:19, Pavel Stehule wrote:
2015-02-22 3:00 GMT+01:00 Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com:
On 28/01/15 08:15, Pavel Stehule wrote:
2015-01-28 0:01 GMT+01:00 Jim Nasby jim.na...@bluetreble.com
mailto:jim.na...@bluetreble.com
pasted and see what your patch outputs to see what I mean.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
On 22/02/15 09:57, Andres Freund wrote:
On 2015-02-19 00:49:50 +0100, Petr Jelinek wrote:
On 16/02/15 10:46, Andres Freund wrote:
On 2015-02-16 11:34:10 +0200, Heikki Linnakangas wrote:
At a quick glance, this basic design seems workable. I would suggest
expanding the replication IDs
On 23/02/15 03:24, Robert Haas wrote:
On Sat, Feb 21, 2015 at 11:29 PM, Petr Jelinek p...@2ndquadrant.com wrote:
I am wondering a bit about interaction with wal_keep_segments.
One thing is that wal_keep_segments is still specified in number of segments
and not size units, maybe it would
On 21/02/15 22:09, Andrew Dunstan wrote:
On 02/16/2015 09:05 PM, Petr Jelinek wrote:
I found one more issue with the 1.2--1.3 upgrade script, the DROP
FUNCTION pg_stat_statements(); should be DROP FUNCTION
pg_stat_statements(bool); since in 1.2 the function identity has changed.
I think
of the
algorithm in this patch, but user does not really care about that) which
is somewhat weird given the naming.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers
that the documentation does not say what is returned by
array_offset if nothing is found (it's documented in code but not in sgml).
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list
to integrate the RepNodeId and
CommitTSNodeId into single thing.
There are no docs for the new sql interfaces.
The replication_identifier.c might deserve some intro/notes text.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
and works
as expected, there is nothing to be added to it IMHO.
The = operator was deprecated for several years so it should not be
too controversial either.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql
?
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 17/02/15 23:11, Robert Haas wrote:
On Sun, Feb 15, 2015 at 1:40 PM, Petr Jelinek p...@2ndquadrant.com wrote:
sending new version that is updated along the lines of what we discussed at
FOSDEM, which means:
- back to single bytea amdata column (no custom columns)
Well, the main argument
this assertion? The functions is declared to
take text[] */
+ Assert(ARR_ELEMTYPE(path) == TEXTOID);
I wonder about this also, some functions do that, some don't, I am not
really sure what is the rule there myself.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL
On 18/02/15 02:59, Petr Jelinek wrote:
On 17/02/15 23:11, Robert Haas wrote:
On Sun, Feb 15, 2015 at 1:40 PM, Petr Jelinek p...@2ndquadrant.com
wrote:
sending new version that is updated along the lines of what we
discussed at
FOSDEM, which means:
- back to single bytea amdata column
On 17/02/15 16:12, Andres Freund wrote:
On 2015-02-17 15:50:39 +0100, Petr Jelinek wrote:
On 17/02/15 03:07, Petr Jelinek wrote:
On 17/02/15 03:03, Andrew Dunstan wrote:
On 02/16/2015 08:57 PM, Andrew Dunstan wrote:
Average of 3 runs of read-only pgbench on my system all
On 17/02/15 03:07, Petr Jelinek wrote:
On 17/02/15 03:03, Andrew Dunstan wrote:
On 02/16/2015 08:57 PM, Andrew Dunstan wrote:
On 02/16/2015 08:48 PM, Petr Jelinek wrote:
On 17/02/15 01:57, Peter Geoghegan wrote:
On Mon, Feb 16, 2015 at 4:44 PM, Petr Jelinek p...@2ndquadrant.com
wrote:
We
would matter
too much. The problem is that the new function is actually not used
anywhere in the code, I only see use of plain sqrt.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list
On 17/02/15 01:57, Peter Geoghegan wrote:
On Mon, Feb 16, 2015 at 4:44 PM, Petr Jelinek p...@2ndquadrant.com wrote:
We definitely want this feature, I wished to have this info many times.
I would still like to see a benchmark.
Average of 3 runs of read-only pgbench on my system all
On 17/02/15 03:03, Andrew Dunstan wrote:
On 02/16/2015 08:57 PM, Andrew Dunstan wrote:
On 02/16/2015 08:48 PM, Petr Jelinek wrote:
On 17/02/15 01:57, Peter Geoghegan wrote:
On Mon, Feb 16, 2015 at 4:44 PM, Petr Jelinek p...@2ndquadrant.com
wrote:
We definitely want this feature, I wished
On 17/02/15 02:57, Andrew Dunstan wrote:
On 02/16/2015 08:48 PM, Petr Jelinek wrote:
On 17/02/15 01:57, Peter Geoghegan wrote:
On Mon, Feb 16, 2015 at 4:44 PM, Petr Jelinek p...@2ndquadrant.com
wrote:
We definitely want this feature, I wished to have this info many times.
I would still
On 13/02/15 14:04, Petr Jelinek wrote:
On 13/02/15 08:48, Michael Paquier wrote:
Looking at this patch, I don't see what we actually gain much here
except a decoder plugin that speaks a special protocol for a special
background worker that has not been presented yet. What actually is the
value
On 13/02/15 08:48, Michael Paquier wrote:
On Mon, Dec 22, 2014 at 10:26 PM, Robert Haas robertmh...@gmail.com
mailto:robertmh...@gmail.com wrote:
On Fri, Dec 19, 2014 at 8:40 AM, Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com wrote:
What I hope to get from
conservative.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
that would be a good
goal to have. If we could do the same for hot_standby if you had
physical slots, that might also be a good idea?
+many for the logical, physical would be nice but I think it's again in
the category of not so easy and maybe better as next step if at all.
--
Petr Jelinek
On 31/01/15 14:27, Amit Kapila wrote:
On Fri, Jan 23, 2015 at 5:39 AM, Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com wrote:
On 19/01/15 07:08, Amit Kapila wrote:
On Sun, Jan 18, 2015 at 12:46 AM, Petr Jelinek
p...@2ndquadrant.com mailto:p...@2ndquadrant.com
variation in practice as we don't have perfect
random generator but that's independent of the algorithm.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org
enough that we can support it.
The following change seems enough.
Seems about right, thanks.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
On 28/01/15 18:09, Heikki Linnakangas wrote:
On 01/23/2015 02:34 AM, Petr Jelinek wrote:
On 22/01/15 17:02, Petr Jelinek wrote:
The new version (the one that is not submitted yet) of gapless sequence
is way more ugly and probably not best example either but does guarantee
gaplessness
was writing
the array version of width_bucket. It was one of the motivations for
making special float8 version since not having to call it had
significant effect. Sadly I don't remember if it was the function call
itself or the conversion anymore.
--
Petr Jelinek http://www
On 22/01/15 16:50, Heikki Linnakangas wrote:
On 01/12/2015 11:33 PM, Petr Jelinek wrote:
Second patch adds DDL support. I originally wanted to make it
CREATE/DROP SEQUENCE ACCESS METHOD... but that would mean making ACCESS
a reserver keyword so I went for CREATE ACCESS METHOD FOR SEQUENCES
to be confusing
otherwise.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql
On 05/01/15 17:50, Petr Jelinek wrote:
On 05/01/15 16:17, Petr Jelinek wrote:
On 05/01/15 07:28, Fujii Masao wrote:
On Thu, Dec 4, 2014 at 12:08 PM, Fujii Masao masao.fu...@gmail.com
wrote:
On Wed, Dec 3, 2014 at 11:54 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Pushed with some extra
On 17/01/15 13:46, Amit Kapila wrote:
On Sun, Jan 11, 2015 at 1:29 AM, Petr Jelinek p...@2ndquadrant.com
mailto:p...@2ndquadrant.com wrote:
In second patch which implements the TABLESAMPLE itself I changed the
implementation of random generator because when I looked at the code
again I
recovery.conf
settings to go through some other, less-capable mechanism?.
+1
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
On 13/01/15 13:24, Tomas Vondra wrote:
On 12.1.2015 22:33, Petr Jelinek wrote:
On 15/12/14 11:36, Petr Jelinek wrote:
On 10/12/14 03:33, Petr Jelinek wrote:
On 24/11/14 12:16, Heikki Linnakangas wrote:
About the rough edges:
- The AlterSequence is not prettiest code around as we now have
adjustment to apply this bugfix on prior versions.
It seems to me a waste of time for committers.
I tend to agree, especially as there is multiple places in code this
would affect - RelOptInfo and RestrictInfo have same issue, etc.
--
Petr Jelinek http://www.2ndQuadrant.com
PG_RETURN_POINTER(state);
}
}
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref
, it still manages to
confuse me. Nothing this patch can do about that.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
On 07/01/15 00:59, Michael Paquier wrote:
On Wed, Jan 7, 2015 at 4:24 AM, Petr Jelinek p...@2ndquadrant.com wrote:
Hi,
when I was fixing how commit_ts handles the XLOG_PARAMETER_CHANGE I noticed
that for wal_log_hints we assign the value in ControFile to current value
instead of value
On 07/01/15 00:05, Jim Nasby wrote:
On 1/6/15, 8:17 AM, Kouhei Kaigai wrote:
The attached patch is newer revision of custom-/foreign-join
interface.
Shouldn't instances of
scan_relid 0
be
scan_relid != InvalidOid
Ideally, they should be OidIsValid(scan_relid)
--
Petr Jelinek
a bug anyway so here is simple patch to change
that.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 5cc7e47..be67da4 100644
--- a/src
On 05/01/15 16:17, Petr Jelinek wrote:
On 05/01/15 07:28, Fujii Masao wrote:
On Thu, Dec 4, 2014 at 12:08 PM, Fujii Masao masao.fu...@gmail.com
wrote:
On Wed, Dec 3, 2014 at 11:54 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Pushed with some extra cosmetic tweaks.
I got the following
Hi,
Attached is fix for
http://www.postgresql.org/message-id/1420492505.23613.15.ca...@bloodnok.com
It was dumping comment with NULL owner while the function expects
empty string for objects without owner (there is pg_strdup down the
line).
--
Petr Jelinek http://www
On 06/01/15 01:02, Tom Lane wrote:
Petr Jelinek p...@2ndquadrant.com writes:
Attached is fix for
http://www.postgresql.org/message-id/1420492505.23613.15.ca...@bloodnok.com
It was dumping comment with NULL owner while the function expects
empty string for objects without owner
anyway once you are in that code path,
maybe just for the clarity...
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
parameters
to be GUCs.
Well, there is an ongoing effort on that and I think the patch is very
close to the state where committer should take a look IMHO, I have only
couple of gripes with it now and one of them needs opinions of others
anyway.
--
Petr Jelinek http://www
= wal_log_hints;
shouldn't it be
ControlFile-wal_log_hints = xlrec.wal_log_hints;
instead?
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/access/transam/commit_ts.c b/src/backend
it'd
be all that easy to do it fast and flexible.
Right, I would love to have custom SLRUs but I don't see it happening
given those two restrictions, otherwise I would write the CommitTs patch
that way in the first place...
--
Petr Jelinek http://www.2ndQuadrant.com
' inconsistently, and I thought
we were going to spell out timestamp in more places, but maybe I am
remembering incorrectly.
The change was from committs to commit_ts + CommitTs depending on place.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support
long already so I think it's
preferable to not make it worse.
- I wonder if we should rename trigger_file to standby_tigger_file
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql
On 21/12/14 18:38, Tomas Vondra wrote:
Hi,
On 18.12.2014 13:14, Petr Jelinek wrote:
Hi,
v2 version of this patch is attached.
I did a review of this v2 patch today. I plan to do a bit more testing,
but these are my comments/questions so far:
Thanks for looking at it!
(0) There's
On 22/12/14 20:14, Jaime Casanova wrote:
On Thu, Dec 18, 2014 at 7:14 AM, Petr Jelinek p...@2ndquadrant.com wrote:
Hi,
v2 version of this patch is attached.
a few more tests revealed that passing null as the sample size
argument works, and it shouldn't.
Fixed.
in repeatable it gives
On 10/12/14 16:03, Petr Jelinek wrote:
On 10/12/14 04:26, Michael Paquier wrote:
On Thu, Dec 4, 2014 at 9:26 PM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
Yeah, it was raised. I don't think it was really addressed. There was
lengthy discussion on whether to include LSN, node id
On 19/12/14 13:17, Michael Paquier wrote:
On Fri, Dec 19, 2014 at 6:30 PM, Petr Jelinek p...@2ndquadrant.com wrote:
On 10/12/14 16:03, Petr Jelinek wrote:
On 10/12/14 04:26, Michael Paquier wrote:
On Thu, Dec 4, 2014 at 9:26 PM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
Yeah
On 15/12/14 19:42, Robert Haas wrote:
On Mon, Dec 15, 2014 at 12:57 AM, Petr Jelinek p...@2ndquadrant.com wrote:
we've made few helper functions for making logical replication easier, I
bundled it into contrib module as this is mainly for discussion at this time
(I don't expect this to get
Hi,
v2 version of this patch is attached.
On 16/12/14 09:31, Petr Jelinek wrote:
On 16/12/14 08:43, Jaime Casanova wrote:
Sadly when the jsonb functions patch was committed a few oids where
used, so you should update the ones you are using. at least to make
the patch easier for testing
about that.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
though.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 16/12/14 08:43, Jaime Casanova wrote:
On Wed, Dec 10, 2014 at 6:24 PM, Petr Jelinek p...@2ndquadrant.com wrote:
Hello,
Attached is a basic implementation of TABLESAMPLE clause. It's SQL standard
clause and couple of people tried to submit it before so I think I don't
need to explain
On 15/12/14 09:12, Michael Paquier wrote:
On Wed, Dec 10, 2014 at 6:50 PM, Noah Misch n...@leadboat.com wrote:
On Mon, Dec 08, 2014 at 02:23:39AM +0100, Petr Jelinek wrote:
On 08/12/14 00:56, Noah Misch wrote:
The commit_ts test suite gives me the attached diff on a 32-bit MinGW build
running
On 10/12/14 03:33, Petr Jelinek wrote:
On 24/11/14 12:16, Heikki Linnakangas wrote:
About the rough edges:
- The AlterSequence is not prettiest code around as we now have to
create new relation when sequence AM is changed and I don't know how to
do that nicely
- I am not sure if I did
801 - 900 of 1148 matches
Mail list logo
