On 01/31/2017 05:03 PM, Konstantin Knizhnik wrote:
One more assertion failure:
ExceptionalCondition(conditionName = "!(OldPageRqstPtr <=
XLogCtl->InitializedUpTo)", errorType = "FailedAssertion", fileName =
"xlog.c", lineNumber = 1887), line 54 in "assert.c"
(dbx) p OldPageRqstPtr
153551667200
>
>
> I think ParseVariableBool is only likely to change to reject a NULL value
> rather than silently interpreting it as FALSE, which is the way it is in
> HEAD right now. That behavior is a leftover hack, really, and moving the
> treatment of unset values upstream seems a lot cleaner. See my dr
>> Shouldn’t the singular part of the message above be:
>> "%u two-phase state file was written for a long-running prepared transaction"
>>
>> But, then, English is not my native language, so I might be off here :-)
>
> If there's one file per long-running prepared transaction, which I
> think is t
Hello, while looking another bug, I found that standby cannot
shutdown after DROP SUBSCRIPTION.
standby=# CREATE SUBSCRPTION sub1 ...
standby=#
standby=# DROP SUBSCRIPTION sub1;
Ctrl-C to the standby fails to work. ApplyLauncherMain is waiting
LogicalRepLauncherLock forever.
The culprit is
Thank you for reviewing.
At Tue, 31 Jan 2017 11:28:17 +0100, Pavel Stehule
wrote in
> I am doing a review of this set of patches:
>
> 1. There are no problem with patching, compiling - all regress tests passed
Oh! My new check script made from Michael's suggestion finds one
trailing space in
Thank you for creating patches.
I strongly hope that your patch will be merged into the new version.
Since all databases are not yet based on UTF - 8, I think conversion of
character codes is still necessary.
-Original Message-
From: Kyotaro HORIGUCHI [mailto:horiguchi.kyot...@lab.ntt.co.
2017-02-01 9:37 GMT+01:00 Kyotaro HORIGUCHI :
> Thank you for reviewing.
>
> At Tue, 31 Jan 2017 11:28:17 +0100, Pavel Stehule
> wrote in gmail.com>
> > I am doing a review of this set of patches:
> >
> > 1. There are no problem with patching, compiling - all regress tests
> passed
> Oh! My ne
On 01/29/2017 04:07 PM, David Rowley wrote:
> On 27 January 2017 at 03:53, Robert Haas wrote:
>> Sorry, this had slipped through the cracks -- I'm having a very hard
>> time keeping up with the flow of patches and emails. But it looks
>> good to me, except that it seems like CountDBBackends() n
Oh, you were one step ahead of me, I didn't understand it on first read
of your email. Need more coffee..
On 01/31/2017 05:03 PM, Konstantin Knizhnik wrote:
I inspected code of pg_atomic_compare_exchange_u32_impl and didn't sync
in prologue:
(dbx) listi pg_atomic_compare_exchange_u32_impl
> [
Hello Corey,
Some comments about v4:
Patch applies. "git apply" complained about a space or line somewhere, not
sure why. make check ok.
- rebased on post-psql hooks master
Good.
- took nearly every suggestion for change to documentation
Indeed. Looks ok to me.
- \if ERROR will thro
Anyone?
--
View this message in context:
http://postgresql.nabble.com/Deployment-of-an-output-plugin-in-Unix-like-environment-tp5940384p5942038.html
Sent from the PostgreSQL - hackers mailing list archive at Nabble.com.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To
On 01/31/2017 01:51 AM, Peter Geoghegan wrote:
* If you're writing out any old bit pattern, I suggest using 0x7F
bytes rather than nul bytes (I do agree that it does seem worth making
this some particular bit pattern, so as to not have to bother with
Valgrind suppressions and so on). That pattern
Andrew Dunstan wrote:
> On 01/29/2017 04:07 PM, David Rowley wrote:
>> Looks like there's a few other usages of CountDBBackends() which
>> require background workers to be counted too, so I ended up creating
>> CountDBConnections() as I didn't really think adding a bool flag to
>> CountDBBackends w
On Tue, Jan 31, 2017 at 9:53 AM, Higuchi, Daisuke
wrote:
> Hello,
>
> This this is my first posting to the mailing list.
>
> I am interested in multiple hosts of libpq [1], then I found the bug in this
> feature.
> When I set "target_session_attrs" to "any" and call PQsendQuery, my
> application
Please add this to the next commitfest, so that we don't forget it.
On Wed, Feb 1, 2017 at 3:58 PM, Ashutosh Bapat
wrote:
> On Tue, Jan 31, 2017 at 9:53 AM, Higuchi, Daisuke
> wrote:
>> Hello,
>>
>> This this is my first posting to the mailing list.
>>
>> I am interested in multiple hosts of lib
On 31 January 2017 at 10:43, Tom Lane wrote:
> David Rowley writes:
>> I don't think that's possible. The whole point that the current join
>> removal code retries to remove joins which it already tried to remove,
>> after a successful removal is exactly because it is possible for a
>> join to be
Attached please find my patch for XLC/AIX.
The most critical fix is adding __sync to pg_atomic_fetch_add_u32_impl.
The comment in this file says that:
* __fetch_and_add() emits a leading "sync" and trailing "isync",
thereby
* providing sequential consistency. This is undocumented.
On 01/17/2017 11:51 PM, Peter Eisentraut wrote:
On 1/3/17 9:09 AM, Heikki Linnakangas wrote:
Since not everyone agrees with this approach, I split this patch into
two. The first patch refactors things, replacing the isMD5() function
with get_password_type(), without changing the representation o
On 2017-02-01 09:27, Corey Huinker wrote:
0001.if_endif.v4.diff
A few thoughts after a quick try:
I dislike the ease with which one gets stuck inside an \if block, in
interactive mode.
(for instance, in my very first session, I tried '\? \if' to see if
there is more info in that help-s
> Got it, but if other people don't agree then this is going nowhere.
Yes. As I wrote, I don't particularly care about functions like "is
point on line". I can prepare a patch to fix as many problems as
possible around those operators by preserving the current epsilon.
I though we were arguing
> I think this patch is already in a good shape.
I am sorry for introducing this bug. This fix looks good to me as well.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
I am sorry for the delay, here is the latest re-based patch.
my colleague Neha Sharma, reported one regression with the patch, where
explain output for the Sort node under GatherMerge was always showing
cost as zero:
explain analyze select '' AS "xxx" from pgbench_accounts where filler like
'%fo
On 02/01/2017 01:07 PM, Konstantin Knizhnik wrote:
Attached please find my patch for XLC/AIX.
The most critical fix is adding __sync to pg_atomic_fetch_add_u32_impl.
The comment in this file says that:
* __fetch_and_add() emits a leading "sync" and trailing "isync",
thereby
* provi
On 02/01/2017 01:07 PM, Konstantin Knizhnik wrote:
Attached please find my patch for XLC/AIX.
The most critical fix is adding __sync to pg_atomic_fetch_add_u32_impl.
The comment in this file says that:
* __fetch_and_add() emits a leading "sync" and trailing "isync",
thereby
* provi
* Michael Paquier (michael.paqu...@gmail.com) wrote:
> On Wed, Jan 4, 2017 at 7:59 PM, Ashutosh Bapat
> wrote:
> > Here are patches for following
>
> Those patches have received no code-level reviews, so moved to CF 2017-03.
Yeah, I've been rather busy with email and bug fixes, but this is still
On Wed, Feb 1, 2017 at 6:31 AM, Erik Rijkers wrote:
> On 2017-02-01 09:27, Corey Huinker wrote:
>
>> 0001.if_endif.v4.diff
>>
>
> A few thoughts after a quick try:
>
> I dislike the ease with which one gets stuck inside an \if block, in
> interactive mode.
>
> (for instance, in my very first ses
>
> - wrote an intentionally failing TAP test to see if "make check" executes
>> it. it does not. need help.
>>
>
> A failing test expects code 3, not 0 as written in "t/001_if.pl". With
>
> is($retcode,'3','Invalid \if respects ON_ERROR_STOP');
>
> instead, the tests succeeds because psql return
On Wed, Feb 1, 2017 at 3:52 AM, Robert Haas wrote:
> On Tue, Jan 24, 2017 at 4:51 PM, Robert Haas wrote:
>> On Mon, Jan 23, 2017 at 1:03 AM, Amit Kapila wrote:
>>> In spite of being careful, I missed reorganizing the functions in
>>> genam.h which I have done in attached patch.
>>
>> Cool. Comm
Now the simplest way to extract booleans and numbers from json/jsonb is
to cast it
to text and then cast to the appropriate type:
postgres=# select 'true'::jsonb::text::bool;
bool
--
t
postgres=# select '1.0'::jsonb::text::numeric;
numeric
-
1.0
This patch implements direct
On 02/01/2017 06:50 PM, Amit Kapila wrote:
Used large table parallel index scans (both forward and backward
scans). These tests have been done by Tushar and you can find
detailed report up thread [2]. Apart from that, the patch has been
tested with TPC-H queries at various scale factors and it
Corey Huinker writes:
> Right. What I meant was, no matter how I changed that test, I could not get
> it to fail, which made me think it was not executing at all. What do I need
> to do to get TAP tests running? I must be missing something.
configure --enable-tap-tests, perhaps?
Run make check-world (as opposed to just make check )
I'll give that a shot.
You can also run "make check" directly in the "src/bin/psql" directory.
--
Fabien.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.post
On 01.02.2017 15:39, Heikki Linnakangas wrote:
On 02/01/2017 01:07 PM, Konstantin Knizhnik wrote:
Attached please find my patch for XLC/AIX.
The most critical fix is adding __sync to pg_atomic_fetch_add_u32_impl.
The comment in this file says that:
* __fetch_and_add() emits a leading "sy
On 02/01/2017 06:50 PM, Amit Kapila wrote:
Used large table parallel index scans (both forward and backward
scans). These tests have been done by Tushar and you can find
detailed report up thread [2]. Apart from that, the patch has been
tested with TPC-H queries at various scale factors and it
>
>
> Add --enable-tap-tests option on ./configure
>
This much I had already done.
>
> Run make check-world (as opposed to just make check )
I'll give that a shot.
On 2017-02-01 14:18, Corey Huinker wrote:
to do to get TAP tests running? I must be missing something.
Guesswork on my part:
Add --enable-tap-tests option on ./configure
Run make check-world (as opposed to just make check )
Erik Rijkers
--
Sent via pgsql-hackers mailing list (pgsq
Hi,
We are using 13.1.3 version of XLC. All tests are passed.
Please notice that is is synchronization bug which can be reproduced
only under hard load.
Our server has 64 cores and it is necessary to run pgbench with 100
connections during several minutes to reproduce the problem.
So may be yo
Due to recent below commit, patch not getting apply cleanly on
master branch.
commit d002f16c6ec38f76d1ee97367ba6af3000d441d0
Author: Tom Lane
Date: Mon Jan 30 17:15:42 2017 -0500
Add a regression test script dedicated to exercising system views.
Please find attached latest patch.
On W
Good find. I'll have to bulk up the help text.
Yes.
This raises a question: in interactive mode, should we give some feedback
as to the result of an \if or \elif test? (see below)
Obviously \if makes more sense for scripting.
However I would say yes, it should provide some feedback... Thi
Hi,
I'm now working on the port of PostgreSQL on AIX.
(RPMs can be found, as free OpenSource work, at http://http://bullfreeware.com/
.
http://bullfreeware.com/search.php?package=postgresql )
I was not aware of any issue with XLC v12 on AIX for atomic operations.
(XLC v13 generates at least 2 t
On Tue, Jan 31, 2017 at 6:01 AM, Amit Kapila wrote:
> Moved this patch to next CF.
So here is what seems to be the key hunk from this patch:
/*
- * Since we don't have the ability to push subplans down to workers at
- * present, we treat subplan references as parallel-restricted. W
"Daniel Verite" writes:
> That works for me. I tested and read it and did not find anything
> unexpected or worth objecting.
> "\unset var" acting as "\set var off" makes sense considering
> that its opposite "\set var" is now an accepted
> synonym of "\set var on" for the boolean built-ins.
Than
On 01.02.2017 14:21,Anastasia Lubennikova wrote:
Now the simplest way to extract booleans and numbers from json/jsonb is
to cast it to text and then cast to the appropriate type: ...
This patch implements direct casts from jsonb numeric (jbvNumeric) to
numeric, int4 and float8, and from jsonb boo
On Thu, Jan 19, 2017 at 6:37 PM, Kyotaro HORIGUCHI
wrote:
> Hello,
>
> At Wed, 18 Jan 2017 12:34:51 +0900, Michael Paquier
> wrote in
>
>> On Tue, Jan 17, 2017 at 7:36 PM, Kyotaro HORIGUCHI
>> wrote:
>> > I managed to reproduce this. A little tweak as the first patch
>> > lets the standby to
Tom Lane wrote:
> I updated the documentation as well. I think this is committable if
> there are not objections.
That works for me. I tested and read it and did not find anything
unexpected or worth objecting.
"\unset var" acting as "\set var off" makes sense considering
that its opposi
Hi Tony,
On 01.02.2017 18:42, REIX, Tony wrote:
Hi Konstantin
*XLC.*
I'm on AIX 7.1 for now.
I'm using this version of *XL**C v13*:
# xlc -qversion
IBM XL C/C++ for AIX, V13.1.3 (5725-C72, 5765-J07)
Version: 13.01.0003.0003
With this version, I have (at least, since I tested with "check" a
On 01.02.2017 15:39, Heikki Linnakangas wrote:
In summary, I came up with the attached. It's essentially your patch,
with tweaks for the above-mentioned things. I don't have a powerpc
system to test on, so there are probably some silly typos there.
Attached pleased find fixed version of
Hi Konstantin
XLC.
I'm on AIX 7.1 for now.
I'm using this version of XLC v13:
# xlc -qversion
IBM XL C/C++ for AIX, V13.1.3 (5725-C72, 5765-J07)
Version: 13.01.0003.0003
With this version, I have (at least, since I tested with "check" and not
"check-world" at that time) 2 failing tests: creat
On Sun, Jan 22, 2017 at 4:45 PM, Stephen Frost wrote:
> Amit,
>
> * Amit Kapila (amit.kapil...@gmail.com) wrote:
> > On Sun, Jan 22, 2017 at 3:27 AM, Stephen Frost
> wrote:
> > > * Simon Riggs (si...@2ndquadrant.com) wrote:
> > >> On 12 August 2016 at 01:01, Tom Lane wrote:
> > >> > Michael Paq
On Wed, Feb 1, 2017 at 5:36 PM, Kyotaro HORIGUCHI
wrote:
> Hello, while looking another bug, I found that standby cannot
> shutdown after DROP SUBSCRIPTION.
>
> standby=# CREATE SUBSCRPTION sub1 ...
> standby=#
> standby=# DROP SUBSCRIPTION sub1;
>
> Ctrl-C to the standby fails to work. Apply
Hello Corey,
There is a spurious empty line added at the very end of "mainloop.h":
+
#endif /* MAINLOOP_H */
Not in my diff, but that's been coming and going in your diff reviews.
Strange. Maybe this is linked to the warning displayed with "git apply" when
I apply the diff.
I
On Wed, Feb 01, 2017 at 04:25:25PM +, Tom Lane wrote:
> Make psql's \set display variables in alphabetical order.
This is a substantial usability improvement which nevertheless is hard
to imagine changes things that scripts relied on. I think it's worth
back-patching.
Best,
David.
--
David F
On 02/01/2017 04:12 PM, Konstantin Knizhnik wrote:
On 01.02.2017 15:39, Heikki Linnakangas wrote:
On 02/01/2017 01:07 PM, Konstantin Knizhnik wrote:
Attached please find my patch for XLC/AIX.
The most critical fix is adding __sync to pg_atomic_fetch_add_u32_impl.
The comment in this file says t
Hi Konstantin,
Please run: /opt/IBM/xlc/13.1.3/bin/xlc -qversion so that I know your exact
XLC v13 version.
I'm building on Power7 and not giving any architecture flag to XLC.
I'm not using -qalign=natural . Thus, by default, XLC use -qalign=power, which
is close to natural, as explained at:
On Tue, Jan 31, 2017 at 6:05 AM, Dilip Kumar wrote:
>> 0002-hash-support-alloc-free-v14.patch:
>>
>>
>> + if (tb->alloc)
>> + {
>>
>> The memory for tb->alloc is allocated always, is the if check still
>> required?
>
> In parallel case, only first worker will call SH_CREATE, other worker
> will on
Hi hackers,
While playing with prepared statements in psql, I noticed that EXECUTE
tab-completes the list of active prepared statements, but DEALLOCATE
does not.
Attached is a patch to fix this.
Cheers,
Ilmari
--
"I use RMS as a guide in the same way that a boat captain would use
a lighthous
>
> However I would say yes, it should provide some feedback... This means
> probably adding a new prompt substitution "%". In the worst
> case, the prompt should reflect the current stack, or at least the top of
> the task...
>
We could just issue interactive-only warnings when:
- A user types a
David Fetter writes:
> On Wed, Feb 01, 2017 at 04:25:25PM +, Tom Lane wrote:
>> Make psql's \set display variables in alphabetical order.
> This is a substantial usability improvement which nevertheless is hard
> to imagine changes things that scripts relied on. I think it's worth
> back-patc
On Sat, Jan 28, 2017 at 9:09 PM, Ashutosh Sharma wrote:
> okay. Thanks. I have done changes on top of this patch.
+ ptr = (char *) itup + IndexInfoFindDataOffset(itup->t_info);
+ Assert(ptr <= uargs->page + BLCKSZ);
I think this should be promoted to an ereport(); the
On 2017-02-01 12:59:36 -0500, Tom Lane wrote:
> David Fetter writes:
> > On Wed, Feb 01, 2017 at 04:25:25PM +, Tom Lane wrote:
> >> Make psql's \set display variables in alphabetical order.
>
> > This is a substantial usability improvement which nevertheless is hard
> > to imagine changes thi
On Wed, Feb 1, 2017 at 8:53 AM, Corey Huinker
wrote:
>
>> Run make check-world (as opposed to just make check )
>
>
> I'll give that a shot.
>
That was it. Tests don't run if you don't invoke them. Thanks.
>
>
> You can also run "make check" directly in the "src/bin/psql" directory.
Previously, that didn't do anything, but now that I've created a TAP test
it does. It doesn't, however, run the psql regress tests. But at least I
can use the two commands in combination and not have to run *all* TAP te
On Tue, Jan 31, 2017 at 5:07 PM, Jim Nasby wrote:
> On 11/29/16 9:58 AM, Jeff Janes wrote:
>> Considering a single SSD can do 70% of that limit, I would say
>> yes.
>>
>> Next question becomes... should there even be an upper limit?
>>
>>
>> Where the contortions needed to prevent calc
I wrote:
> Attached is a finished version that includes hooks for all the variables
> for which they were clearly sensible. (FETCH_COUNT doesn't seem to really
> need one, and I didn't do anything with HISTSIZE or IGNOREEOF either.
> It might be worth bringing the latter two into the hooks paradig
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> While playing with prepared statements in psql, I noticed that EXECUTE
> tab-completes the list of active prepared statements, but DEALLOCATE
> does not.
> Attached is a patch to fix this.
Good idea, but I think it would be be
On Tue, Jan 31, 2017 at 8:26 PM, Michael Paquier
wrote:
> pq_sendcountedtext() does some encoding conversion, which is why I
> haven't used because we deal only with integers in this patch... Now
> if you wish to switch to that I have really no arguments against.
OK, I see. Well, I guess it's se
On Tue, Jan 31, 2017 at 9:05 PM, Michael Paquier
wrote:
>> Personally I don't think lack of access to the GID justifies blocking 2PC
>> logical decoding. It can be added separately. But it'd be nice to have
>> especially if it's cheap.
>
> I think it should be added reading this thread.
+1. If o
Hi
2017-01-24 18:44 GMT+01:00 Peter Eisentraut <
peter.eisentr...@2ndquadrant.com>:
> On 1/15/17 5:53 AM, Pavel Stehule wrote:
> > the regress test fails
> >
> > Program received signal SIGSEGV, Segmentation fault.
> > 0x007bbc2b in pattern_char_isalpha (locale_is_c=0 '\000',
> > locale=
On Mon, Jan 30, 2017 at 2:30 AM, Masahiko Sawada wrote:
> "txn" can be used for abbreviation of "Transaction", so for example
> pg_fdw_txn_resolver?
> I'm also fine to change the module and function name.
If we're judging the relative clarity of various ways of abbreviating
the word "transaction"
On Fri, Dec 23, 2016 at 12:54 AM, Ashutosh Bapat
wrote:
> Another question: do we want to commit the code for creating
> unflattened hierarchy separately or along with partition-wise join?
Probably separately. I suggest posting a series of two (or perhaps
more) patches on the same thread. 'git
Pavel Stehule writes:
> This patch is not possible to compile on today master
> commands/collationcmds.o: In function `AlterCollation':
> /home/pavel/src/postgresql/src/backend/commands/collationcmds.c:297:
> undefined reference to `CatalogUpdateIndexes'
Evidently collateral damage from 2f5c9d9c9
Robert Haas writes:
> Also, including the GID in the WAL for each COMMIT/ABORT PREPARED
> doesn't seem inordinately expensive to me.
I'm confused ... isn't it there already? If not, how do we handle
reconstructing 2PC state from WAL at all?
regards, tom lane
--
Sent v
On Thu, Feb 2, 2017 at 3:34 AM, Rafia Sabih
wrote:
> 9 | 62928.88 | 59077.909
Thanks Rafia. At first glance this plan is using the Parallel Shared
Hash in one place where it should pay off, that is loading the orders
table, but the numbers are terrible. I noticed that it uses batch
fi
Hello,
We could just issue interactive-only warnings when:
- A user types a branching condition command which sets the branch inactive
- A user types a command or query when the current branch is inactive.
The warnings could be specific about state, something like:
psql session is now in an i
On 02/01/2017 10:32 PM, Tom Lane wrote:
> Robert Haas writes:
>> Also, including the GID in the WAL for each COMMIT/ABORT PREPARED
>> doesn't seem inordinately expensive to me.
> I'm confused ... isn't it there already? If not, how do we handle
> reconstructing 2PC state from WAL at all?
>
>
On 02/01/2017 08:30 PM, REIX, Tony wrote:
>
> Hi Konstantin,
>
> Please run:*/opt/IBM/xlc/13.1.3/bin/xlc -qversion* so that I know your exact
> XLC v13 version.
>
IBM XL C/C++ for AIX, V13.1.3 (5725-C72, 5765-J07)
> I'm building on Power7 and not giving any architecture flag to XLC.
>
> I'm not
On 02/01/2017 08:28 PM, Heikki Linnakangas wrote:
>
> But if there's no pressing reason to change it, let's leave it alone. It's
> not related to the problem at hand, right?
>
Yes, I agree with you: we should better leave it as it is.
--
Konstantin Knizhnik
Postgres Professional: http://www.po
Alvaro Herrera writes:
> Tom Lane wrote:
>> However, the patch misses an
>> important part of such an abstraction layer by not also converting
>> catalog-related simple_heap_delete() calls into some sort of
>> CatalogTupleDelete() operation. It is certainly a peculiarity of
>> PG heaps that delet
On Tue, Jan 31, 2017 at 3:05 AM, Claudio Freire wrote:
> On Mon, Jan 30, 2017 at 5:51 AM, Masahiko Sawada
> wrote:
>>
>> * We are willing to use at most maintenance_work_mem (or perhaps
>> * autovacuum_work_mem) memory space to keep track of dead tuples. We
>> * initially allocate an ar
Hi
2017-01-24 21:33 GMT+01:00 Pavel Stehule :
>
>
>
>>
>>> Perhaps that's as simple as renaming all the existing _ns_* functions to
>>> _block_ and then adding support for pragmas...
>>>
>>> Since you're adding cursor_options to PLpgSQL_expr it should probably be
>>> removed as an option to exec_
On Wed, Feb 1, 2017 at 5:47 PM, Masahiko Sawada wrote:
> Thank you for updating the patch.
>
> Whole patch looks good to me except for the following one comment.
> This is the final comment from me.
>
> /*
> * lazy_tid_reaped() -- is a particular tid deletable?
> *
> * This has the right
On Mon, Jan 2, 2017 at 7:32 AM, Ashutosh Bapat
wrote:
> PFA the patch (pg_dp_join_v6.patch) with some bugs fixed and rebased
> on the latest code.
Maybe not surprisingly given how fast things are moving around here
these days, this needs a rebase.
Apart from that, my overall comment on this patc
On Wed, Feb 1, 2017 at 10:02 PM, Claudio Freire wrote:
> On Wed, Feb 1, 2017 at 5:47 PM, Masahiko Sawada wrote:
>> Thank you for updating the patch.
>>
>> Whole patch looks good to me except for the following one comment.
>> This is the final comment from me.
>>
>> /*
>> * lazy_tid_reaped() --
I wrote:
> Evidently collateral damage from 2f5c9d9c9. But I'd suggest waiting
> to fix it until you can also do s/simple_heap_delete/CatalogTupleDelete/
> as I proposed in
> https://www.postgresql.org/message-id/462.1485902...@sss.pgh.pa.us
> I'll go make that happen right now, now that I realize
Tom Lane wrote:
> The source of both of those problems is that in some places, we
> did CatalogOpenIndexes and then used the CatalogIndexState for
> multiple tuple inserts/updates before doing CatalogCloseIndexes.
> The patch dealt with these either by not touching them, just
> leaving the simple_
On 2 Feb. 2017 08:32, "Tom Lane" wrote:
Robert Haas writes:
> Also, including the GID in the WAL for each COMMIT/ABORT PREPARED
> doesn't seem inordinately expensive to me.
I'm confused ... isn't it there already? If not, how do we handle
reconstructing 2PC state from WAL at all?
Right. Per
On Wed, Feb 1, 2017 at 1:08 PM, Andres Freund wrote:
> On 2017-02-01 12:59:36 -0500, Tom Lane wrote:
>> David Fetter writes:
>> > On Wed, Feb 01, 2017 at 04:25:25PM +, Tom Lane wrote:
>> >> Make psql's \set display variables in alphabetical order.
>>
>> > This is a substantial usability impro
On 1/27/17 4:14 AM, Greg Stark wrote:
On 25 January 2017 at 20:06, Jim Nasby wrote:
GUCs support SET LOCAL, but that's not the same as local scoping because the
setting stays in effect unless the substrans aborts. What I'd like is the
ability to set a GUC in a plpgsql block *and have the settin
On Wed, Feb 01, 2017 at 04:38:59PM -0500, Robert Haas wrote:
> On Wed, Feb 1, 2017 at 1:08 PM, Andres Freund wrote:
> > On 2017-02-01 12:59:36 -0500, Tom Lane wrote:
> >> David Fetter writes:
> >> > On Wed, Feb 01, 2017 at 04:25:25PM +, Tom Lane wrote:
> >> >> Make psql's \set display variabl
On 2/1/17 12:03 PM, Fabien COELHO wrote:
I'm unsure whether it is a good idea, I like terse interfaces, but this
is just an opinion.
I think the issue here is that the original case for this is a user
accidentally getting into an \if and then having no clue what's going
on. That's similar to
On Thu, Feb 2, 2017 at 4:05 AM, Robert Haas wrote:
> On Tue, Jan 31, 2017 at 8:26 PM, Michael Paquier
> wrote:
>> pq_sendcountedtext() does some encoding conversion, which is why I
>> haven't used because we deal only with integers in this patch... Now
>> if you wish to switch to that I have real
On 2/1/17 10:27 AM, Robert Haas wrote:
On Tue, Jan 31, 2017 at 5:07 PM, Jim Nasby wrote:
On 11/29/16 9:58 AM, Jeff Janes wrote:
Considering a single SSD can do 70% of that limit, I would say
yes.
Next question becomes... should there even be an upper limit?
Where the contortions
Alvaro Herrera writes:
> Tom Lane wrote:
>> I think what we ought to do about this is invent additional API
>> functions, say
>>
>> Oid CatalogTupleInsertWithInfo(Relation heapRel, HeapTuple tup,
>> CatalogIndexState indstate);
>> void CatalogTupleUpdateWithInfo(Relation heapRel, ItemPointer otid
On 2/1/17 8:26 AM, Nikita Glukhov wrote:
If you find it useful, I can also add support of json and other types,
such as smallint and bigint.
Yes, I'd like to have support for other types and maybe for json.
There's been previous discussion about something similar, which would be
better suppo
Still looking at 0002.
pg_ndistinct_in disallows input, claiming that pg_node_tree does the
same thing. But pg_node_tree does it for security reasons: you could
crash the backend if you supplied a malicious value. I don't think that
applies to pg_ndistinct_in. Perhaps it will be useful to injec
On Wed, Feb 1, 2017 at 6:13 PM, Masahiko Sawada wrote:
> On Wed, Feb 1, 2017 at 10:02 PM, Claudio Freire
> wrote:
>> On Wed, Feb 1, 2017 at 5:47 PM, Masahiko Sawada
>> wrote:
>>> Thank you for updating the patch.
>>>
>>> Whole patch looks good to me except for the following one comment.
>>> Th
On 02.02.2017 01:07, Jim Nasby wrote:
On 2/1/17 8:26 AM, Nikita Glukhov wrote:
Some comments about the code: I think it would be better to
* add function for extraction of scalars from pseudo-arrays
* iterate until WJB_DONE to pfree iterator
I'm not sure what your intent here is, but if the
Something is broken in HEAD:
drop table if exists t;
create table t(c text);
insert into t (c) values ( 'abc' ) ;
select
regexp_split_to_array(
regexp_split_to_table(
c
, chr(13) || chr(10) )
, '","' )
On Thu, Feb 2, 2017 at 7:01 AM, Jim Nasby wrote:
> On 2/1/17 10:27 AM, Robert Haas wrote:
>> This looks fine to me.
This could go without the comments, they are likely going to be
forgotten if any updates happen in the future.
> If someone wants to proactively commit this, the CF entry is
> http
Hi,
On 2017-02-02 00:09:03 +0100, Erik Rijkers wrote:
> Something is broken in HEAD:
Hm. Indeed.
> drop table if exists t;
> create table t(c text);
> insert into t (c) values ( 'abc' ) ;
>
> select
> regexp_split_to_array(
> regexp_split_to_table(
> c
>
1 - 100 of 147 matches
Mail list logo
