Re: [PATCHES] fix for plpgsql polymorphism

2003-07-02 Thread Alvaro Herrera
On Thu, Jul 03, 2003 at 12:11:36AM -0400, Tom Lane wrote: Joe Conway [EMAIL PROTECTED] writes: Alvaro Herrera wrote: why is this a malloc() and not palloc()? And when/where/how is it freed? It isn't, at least not until the backend exits ;-) This is how plpgsql is done throughout

[PATCHES] updated libpq spanish translation

2003-08-24 Thread Alvaro Herrera
One untranslated message (NOTICE). Please install. $ msgfmt -c -v po/es.po 99 mensajes traducidos, 1 mensaje sin traducir. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Voy a acabar con todos los humanos / con los humanos yo acabaré voy a acabar con todos / con todos los humanos acabaré (Bender

[PATCHES] psql spanish l10n

2003-08-24 Thread Alvaro Herrera
Attached is a (new) spanish PO file for psql: $ LANG= msgfmt -v -c po/es.po 269 translated messages, 2 untranslated messages. Please install. Don't forget to add to nls.mk... Thanks. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Voy a acabar con todos los humanos / con los humanos yo acabaré

[PATCHES] message not following the guidelines

2003-09-11 Thread Alvaro Herrera
This message seems to be breaking the message guidelines. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Porque francamente, si para saber manejarse a uno mismo hubiera que rendir examen... ¿Quién es el machito que tendría carnet? (Mafalda) Index: opclasscmds.c

Re: [PATCHES] NLS changes

2003-09-14 Thread Alvaro Herrera
On Sun, Sep 14, 2003 at 02:14:22AM -0400, Alvaro Herrera wrote: - adds .y files to gettext-files in backend/nls.mk. gram.y contains several translatable messages that are not catched by update-po unless the gram.c file is generated. I don't know if this is desirable but I think it's

Re: [PATCHES] [BUGS] bug in clusterdb script

2003-09-27 Thread Alvaro Herrera
only, because in 7.4 the script got reimplemented. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) The Gord often wonders why people threaten never to come back after they've been told never to return (www.actsofgord.com) ---(end of broadcast)--- TIP 2

[PATCHES] more spanish updates

2003-10-03 Thread Alvaro Herrera
Peter, Attached are psql and libpq spanish PO files, 100% translated. $ LC_MESSAGES=C msgfmt -c -v libpq-es.po 100 translated messages. $ LC_MESSAGES=C msgfmt -c -v psql-es.po 453 translated messages. Please install. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Por suerte hoy explotó el

Re: [PATCHES] more spanish updates

2003-10-04 Thread Alvaro Herrera
On Sat, Oct 04, 2003 at 08:13:23PM +0200, Peter Eisentraut wrote: Alvaro Herrera writes: Attached are psql and libpq spanish PO files, 100% translated. Installed. Thanks. Did you get this one? http://archives.postgresql.org/pgsql-patches/2003-10/msg9.php (backend translation

Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-10-10 Thread Alvaro Herrera
On Fri, Oct 10, 2003 at 12:42:50PM +0800, Christopher Kings-Lynne wrote: OK, for reviewers. Note the index predicate and the check constraint in particular. It seems to have the nice property of allowing output to be copy-n-pasted without further modification. -- Alvaro Herrera (alvherre

[PATCHES] spanish updates, take 2

2003-10-25 Thread Alvaro Herrera
I attach the whole spanish PO catalogs again, correcting some typos. They are at 100% again. I already posted them three days ago, but they got lost probably because the size of the mail. I will post the backend and libpq catalog separately. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Si

[PATCHES] spanish pg_dump catalog

2003-10-27 Thread Alvaro Herrera
One string added and some typos corrected. Please install. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La experiencia nos dice que el hombre peló millones de veces las patatas, pero era forzoso admitir la posibilidad de que en un caso entre millones, las patatas pelarían al hombre (Ijon Tichy

Re: [PATCHES] [HACKERS] BEGIN vs START TRANSACTION

2003-11-10 Thread Alvaro Herrera
it would be useful to point out the difference; for example, users will get confused if they try to start a subtransaction inside a plpgsql function using BEGIN. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) El miedo atento y previsor es la madre de la seguridad (E. Burke

Re: [PATCHES] ALTER TABLE modifications

2003-11-14 Thread Alvaro Herrera
of code. This is expected. Doing otherwise would incur into a much bigger performance hit. Anyway, IMHO no code should use SELECT * in any case, which is the only scenario where one would expect physical column order to matter, isn't it? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La primera ley

Re: [PATCHES] introduce default_use_oids

2003-12-01 Thread Alvaro Herrera
, but this patch takes out the ability to do that -- no one else will accept WITH/WITHOUT OIDS, so the dump will have to be modified. Is a switch provided to stop the emission of those modifiers? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Escucha y olvidarás; ve y recordarás; haz y entenderás

Re: [PATCHES] fork/exec patch

2003-12-14 Thread Alvaro Herrera
can hardly claim that no one had issues with that. I complained about it and I think other people did too. It's a messy, ugly approach; moreover we have no field experience that says it's reliable. Don't the FSM and the system catalog cache use a similar mechanism? -- Alvaro Herrera (alvherre

[PATCHES] trivial typos

2004-01-19 Thread Alvaro Herrera
Attached is a patch that fixes some trivial typos and alignment. Please apply. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Siempre hay que alimentar a los dioses, aunque la tierra esté seca (Orual) diff -cr --exclude=CVS 00orig/src/backend/access/transam/xact.c 01trivial/src/backend/access

[PATCHES] small smgr refactoring

2004-01-19 Thread Alvaro Herrera
I attach a small patch that slightly refactors some code in storage/smgr/smgr.c. Regression test pass. There's no change in functionality, only code reordering. (Well, it changes an ad-hoc linked list into a proper List). Please review and if Ok, apply. -- Alvaro Herrera (alvherre

Re: [PATCHES] small smgr refactoring

2004-01-19 Thread Alvaro Herrera
On Mon, Jan 19, 2004 at 06:20:21PM -0500, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: (Well, it changes an ad-hoc linked list into a proper List). Why? AFAICT that just makes the code bigger, uglier, and slower ... Oh, does it? Hmm. When I originally wrote this, it used

Re: [PATCHES] installdir patch for win32

2004-03-25 Thread Alvaro Herrera
dependencies. Don't forget about the EXEC_BACKEND businness ... is there any chance those could refactored somehow? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Amanece. (Ignacio Reyes) El Cerro San Cristóbal me mira, cínicamente, con ojos de virgen

[PATCHES] Removing cruft in access/transam/xact.c

2004-03-26 Thread Alvaro Herrera
... This passes the full regression test suite. Please review and apply if OK. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) I think my standards have lowered enough that now I think 'good design' is when the page doesn't irritate the living f*ck out of me. (JWZ) Index: src/backend/access/transam

Re: [PATCHES] Removing cruft in access/transam/xact.c

2004-03-27 Thread Alvaro Herrera
On Sat, Mar 27, 2004 at 12:21:07AM -0500, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: This patch removes the unnecesary TRANS_* states that supposedly represented low level transaction state. The state is actually unnecesary because the states can be accurately represented

Re: [PATCHES] Removing cruft in access/transam/xact.c

2004-03-28 Thread Alvaro Herrera
think the TRANS state is unnecesary. I will add checks in the low level routines so they see what TBLOCK state they are called in, which should be enough to keep the current functionality and robustness. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) A wizard is never late, Frodo Baggins, nor is he

Re: [PATCHES] Removing cruft in access/transam/xact.c

2004-03-28 Thread Alvaro Herrera
On Sun, Mar 28, 2004 at 06:16:59PM -0400, Alvaro Herrera wrote: After all this, I still think the TRANS state is unnecesary. I will add checks in the low level routines so they see what TBLOCK state they are called in, which should be enough to keep the current functionality and robustness

[PATCHES] xact.c cleanup -- uncontroversial try

2004-03-30 Thread Alvaro Herrera
review and apply if OK. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) El sabio habla porque tiene algo que decir; el tonto, porque tiene que decir algo (Platon). Index: src/backend/access/transam/xact.c === RCS file: /home/alvherre/cvs

[PATCHES] Basic subtransaction facility

2004-04-13 Thread Alvaro Herrera
ROLLBACK, the parent can be allowed to continue. Please have a look and comment. This file does not move a lot so I don't think it will suffer from a lot of code drift. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) I think my standards have lowered enough that now I think 'good design' is when

Re: [PATCHES] Basic subtransaction facility

2004-04-17 Thread Alvaro Herrera
. --- Alvaro Herrera wrote: Hackers, Here is a very preliminar patch that allows the user to say BEGIN inside a transaction and have the system react accordingly. This is only a modification to xact.c (and slightly

Re: [PATCHES] Basic subtransaction facility

2004-04-19 Thread Alvaro Herrera
On Sun, Apr 18, 2004 at 11:29:05AM -0400, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: If you want. When not #defined, the behavior is the same as the current code, so it shouldn't affect anything. However I posted mainly so people could comment on the modifications, and maybe

Re: [PATCHES] doc improv: backup/restore

2004-04-21 Thread Alvaro Herrera
complaints. I'm not sure, but seems the reference to work_mem is gone? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) El sentido de las cosas no viene de las cosas, sino de las inteligencias que las aplican a sus problemas diarios en busca del progreso. (Ernesto Hernández-Novich

[PATCHES] Remove traces of xfunc

2004-04-24 Thread Alvaro Herrera
RelOptInfo, since it's not used. Tom Lane has said a couple of times that he thinks this maybe can be resurrected; but even if it is, most likely it won't use this code (what code? These are only hooks.) (To the patcher: the file src/backend/lib/lispsort.c can also be removed after this change) -- Alvaro

Re: [PATCHES] Remove traces of xfunc

2004-04-24 Thread Alvaro Herrera
On Sun, Apr 25, 2004 at 12:20:01AM -0400, Neil Conway wrote: On 24-Apr-04, at 5:58 PM, Alvaro Herrera wrote: While playing with the init code I noticed traces of Hellerstein's expensive function optimization. It is completely disabled, uses functions nowhere to be defined, and is out of date

[PATCHES] subtransactions -- storage manager

2004-04-25 Thread Alvaro Herrera
head they are the same thing ... -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Hi! I'm a .signature virus! cp me into your .signature file to help me spread! diff -cr --exclude-from=diff-ignore 08simple/src/backend/access/transam/xact.c 10smgr/src/backend/access/transam/xact.c *** 08simple/src

[PATCHES] nested transactions

2004-05-14 Thread Alvaro Herrera
/access/transam/subtrans.c subtrans.h should go into src/include/access/subtrans.h -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Investigación es lo que hago cuando no sé lo que estoy haciendo (Wernher von Braun) ---(end of broadcast)--- TIP 3

Re: [PATCHES] PITR Phase 1 - Full set of patches

2004-04-29 Thread Alvaro Herrera
, with no conflict. If there is any interest I can post the script too. It's somewhat ugly but it has worked for me. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La virtud es el justo medio entre dos defectos (Aristóteles) ---(end of broadcast

Re: [PATCHES] PITR Phase 1 - Full set of patches

2004-04-29 Thread Alvaro Herrera
On Thu, Apr 29, 2004 at 09:58:49PM -0400, Alvaro Herrera wrote: Note that sometimes I do things incrementally, so I do incremental diffs by commands like cd /home/alvherre/CVS/pgsql/source diff -cr --exclude-from=ignore-diff 01xact 02blahblah ^^^ Note that this should be -Ncr -- I

Re: [PATCHES] subtransactions -- storage manager

2004-04-30 Thread Alvaro Herrera
On Thu, Apr 29, 2004 at 11:38:52PM +0100, Simon Riggs wrote: On Sun, 2004-04-25 at 19:06, Alvaro Herrera wrote: - pg_clog/pg_subtrans. Need a solution. As you're aware, our current work overlaps. pg_clog doesn't seem like the place to record subtransactions, though maybe it is... could we

Re: [PATCHES] new aggregate functions v1

2004-05-01 Thread Alvaro Herrera
. Thus the backend would be free from this stuff, and people who needs it just installs the whole package. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La realidad se compone de muchos sueños, todos ellos diferentes, pero en cierto aspecto, parecidos... (Yo, hablando de sueños eróticos

[PATCHES] smgr cleanup

2004-05-03 Thread Alvaro Herrera
could argue that a hypotethical future storage manager could do something at commit/abort so the hooks are needed, but we haven't had a different storage manager for years. If there are no objections, please apply. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Pensar que el espectro que vemos es

Re: [PATCHES] Basic subtransaction facility

2004-04-29 Thread Alvaro Herrera
(unless we suspect shared state corruption ... is that checked for anywhere? I haven't looked.) -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) No single strategy is always right (Unless the boss says so) (Larry Wall) ---(end of broadcast)--- TIP 3

Re: [PATCHES] Basic subtransaction facility

2004-04-29 Thread Alvaro Herrera
the use-case for abort-all-levels-of-xact-but- don't-exit. Ok, I'm not wedded to the idea of a new elevel. So you think elog(ERROR) should rather be elog(FATAL) ? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Y una voz del caos me habló y me dijo Sonríe y sé feliz, podría ser peor. Y sonreí. Y

Re: [PATCHES] Basic subtransaction facility

2004-04-29 Thread Alvaro Herrera
of that should abort the outer transaction? Theoretically, if you abort the inner transaction, that could free up memory for use by the outer transaction. Yes, this is planned to happen. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La tristeza es un muro entre dos jardines (Khalil Gibran

[PATCHES] Nested xacts, try 5

2004-05-23 Thread Alvaro Herrera
there's a bug. Hopefully not much else. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Tulio: oh, para qué servirá este boton, Juan Carlos? Policarpo: No, aléjense, no toquen la consola! Juan Carlos: Lo apretaré una y otra vez. nested-all-5.patch.gz Description: Binary data /* * subtrans.h

Re: [PATCHES] Cancel/Kill backend functions

2004-05-27 Thread Alvaro Herrera
() test and terminates just before the kill() signal? It should be pretty unlikely but you could signal the wrong process ... shouldn't the SInvalLock be held throughout the whole operation? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) El número de instalaciones de UNIX se ha elevado a 10, y se

Re: [PATCHES] Cancel/Kill backend functions

2004-05-27 Thread Alvaro Herrera
level. I could write it to save the xid's in PGPROC in a first pass, then release the SInvalLock, then look at pg_subtrans. But I think doing it this way has a (is a?) race condition. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Bob [Floyd] used to say that he was planning to get a Ph.D

Re: [PATCHES] fix oid casting inconsistency

2004-06-03 Thread Alvaro Herrera
message string, (a) this particular error message isn't very likely be used for that (b) we have error codes now. This kind of error message consistency enhancement has been applied liberally in the past. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) If you have nothing to say, maybe you need just

Re: [PATCHES] eventlog fix

2004-06-03 Thread Alvaro Herrera
*/ HANDLE g_hModule = NULL; /* hModule of DLL */ We don't use this hungarian notation anywhere ... it certainly looks ugly. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Y eso te lo doy firmado con mis lágrimas (Fiebre del Loco) ---(end

Re: [PATCHES] PITR Archival

2004-06-15 Thread Alvaro Herrera
and Alt -- very handy. Can use CVS as well, or you can use two source trees. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) There is evil in the world. There are dark, awful things. Occasionally, we get a glimpse of them. But there are dark corners; horrors almost impossible to imagine... even in our

Re: [PATCHES] Nested transactions

2004-06-16 Thread Alvaro Herrera
. And there's no way to undo a command in the transaction, short of aborting it completely. I don't know what Oracle or other DBMSs expect in this area. Anyone care to give me a few pointers? If I'm missing something, I want to know as soon as possible. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Before

Re: [PATCHES] Nested transactions

2004-06-16 Thread Alvaro Herrera
(else the function would not be able to terminate correctly), but for levels before that one it'd be OK. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Cuando mañana llegue pelearemos segun lo que mañana exija (Mowgli) ---(end of broadcast)--- TIP 1

Re: [PATCHES] Nested transactions

2004-06-16 Thread Alvaro Herrera
for a first implementation it would be fine if we had only one level. It would, wouldn't it? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Estoy de acuerdo contigo en que la verdad absoluta no existe... El problema es que la mentira sí existe y tu estás mintiendo (G. Lama

[PATCHES] Some index entries

2004-06-16 Thread Alvaro Herrera
The attached patch adds some index entries pointing to the cursor reference pages. Please apply. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Thou shalt study thy libraries and strive not to reinvent them without cause, that thy code may be short and readable and thy days pleasant

Re: [PATCHES] Some index entries

2004-06-17 Thread Alvaro Herrera
bookindex.html anymore, now it shows up as i66180.html. Is this normal? Thanks, -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Amanece. (Ignacio Reyes) El Cerro San Cristóbal me mira, cínicamente, con ojos de virgen ---(end

Re: [PATCHES] nested xacts and phantom Xids

2004-06-21 Thread Alvaro Herrera
On Sun, Jun 20, 2004 at 04:37:16PM -0400, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Here I present the nested transactions patch and the phantom Xids patch that goes with it. I looked at the phantom XIDs stuff a bit. I still have little confidence that the concept

Re: [PATCHES] nested xacts and phantom Xids

2004-06-21 Thread Alvaro Herrera
On Mon, Jun 21, 2004 at 10:28:59PM -0400, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: This is tricky because chunks are prepended to the queue, but it also means we can stop processing as soon as a message belongs to another transaction. AFAIR there isn't any essential

Re: [PATCHES] nested xacts and phantom Xids

2004-06-22 Thread Alvaro Herrera
, but this doesn't actually prove anything. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) ¿Que diferencia tiene para los muertos, los huérfanos, y aquellos que han perdido su hogar, si la loca destrucción ha sido realizada bajo el nombre del totalitarismo o del santo nombre de la libertad y la

Re: [PATCHES] nested xacts and phantom Xids

2004-06-23 Thread Alvaro Herrera
the syntax; I don't think it'd be a big deal. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La conclusión que podemos sacar de esos estudios es que no podemos sacar ninguna conclusión de ellos (Tanenbaum) ---(end of broadcast)--- TIP 1: subscribe

Re: [PATCHES] nested xacts and phantom Xids

2004-06-23 Thread Alvaro Herrera
have a tuple bit set indicating that instead of being a cid, it is an index into an array of cmin/cmax pairs. Yeah, maybe this can work. I'm not going to try however, at least not now. If somebody else wants to try, be my guest. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) El conflicto es el

Re: [PATCHES] nested xacts and phantom Xids

2004-06-24 Thread Alvaro Herrera
. Comments? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) No single strategy is always right (Unless the boss says so) (Larry Wall) Index: guc.c === RCS file: /home/alvherre/cvs/pgsql-server/src/backend/utils/misc/guc.c,v retrieving revision

Re: [PATCHES] nested xacts and phantom Xids

2004-06-26 Thread Alvaro Herrera
routines. If you want to work on that let me know and I'll handle things like the password file, local bufmgr refcount, etc. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) FOO MANE PADME HUM ---(end of broadcast)--- TIP 1: subscribe and unsubscribe

Re: [PATCHES] nested xacts and phantom Xids

2004-06-26 Thread Alvaro Herrera
' feet. Oops, I forgot that I had inadvertently left a kludge in commands/trigger.c. Please use this patch for this file instead. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Jude: I wish humans laid eggs Ringlord: Why would you want humans to lay eggs? Jude: So I can eat them Index: include

Re: [PATCHES] nested xacts and phantom Xids

2004-06-27 Thread Alvaro Herrera
On Sun, Jun 27, 2004 at 12:49:10AM -0400, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: I'll work on adding the Xid-cache to PGPROC and using that in TransactionIdIsInProgress and the tqual routines. If you want to work on that let me know and I'll handle things like

[PATCHES] nested xacts: update password file

2004-06-27 Thread Alvaro Herrera
it was ripped before the 7.3 release. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Some men are heterosexual, and some are bisexual, and some men don't think about sex at all... they become lawyers (Woody Allen) Index: src/backend/commands/user.c

[PATCHES] typo in runtime.sgml

2004-06-27 Thread Alvaro Herrera
Corrects a wrong filename separation. Please apply. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) You liked Linux a lot when he was just the gawky kid from down the block mowing your lawn or shoveling the snow. But now that he wants to date your daughter, you're not so sure he measures up. (Larry

Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Alvaro Herrera
On Tue, Jun 29, 2004 at 03:22:52PM -0400, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: - GUC vars are rolled back on subxact abort This did not work very well, but here is a revised GUC patch that I think does work. It requires xact.c to export a function to report the current

Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Alvaro Herrera
in a local buffer? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) I dream about dreams about dreams, sang the nightingale under the pale moon (Sandman) Index: src/include/storage/bufmgr.h === RCS file: /home/alvherre/cvs/pgsql-server/src

Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Alvaro Herrera
On Tue, Jun 29, 2004 at 06:59:20PM -0400, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: As with the bufmgr.c original patch, I don't really know how to test that this actually works. [...] I forgot to mention to you that that code didn't work at all, btw. Bad news, I guess

Re: [PATCHES] latest plperl

2004-07-01 Thread Alvaro Herrera
-conditional basis -- anyone know? Can't this stuff be tested somehow using Test::Simple, Test::Harness or something like that? I know this is not standard perl stuff but ... -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) I call it GNU/Linux. Except the GNU/ is silent. (Ben Reiter

[PATCHES] [subxacts] Using a different syntax

2004-07-04 Thread Alvaro Herrera
don't have a clue how to handle this. Regression tests pass; I had to change the transaction test to adopt the new syntax. I also added a couple of tests to verify the new functionality. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La experiencia nos dice que el hombre peló millones de veces las

[PATCHES] value.h has no VALUE_H

2004-07-10 Thread Alvaro Herrera
The outer #define was forgotten. Attached patch adds it; please apply. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Sallah, I said NO camels! That's FIVE camels; can't you count? (Indiana Jones) Index: src/include/nodes/value.h

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 12:05:40PM -0400, Bruce Momjian wrote: Alvaro, you call GetParentTransactionId(), but I see not definition for it in the code. Let me include this patch in the next patch I'll submit shortly. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) I suspect most samba

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
manually. /para /note -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La primera ley de las demostraciones en vivo es: no trate de usar el sistema. Escriba un guión que no toque nada para no causar daños. (Jakob Nielsen) ---(end of broadcast

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
pg_hba.conf entry? Can I use multiple files with a single pg_hba.conf entry? What happens if I have a username that has the separator in it? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Los dioses no protegen a los insensatos. Éstos reciben protección de otros insensatos mejor dotados (Luis Wu

Re: [PATCHES] nested xacts: update password file

2004-07-12 Thread Alvaro Herrera
On Mon, Jul 12, 2004 at 03:19:43PM -0400, Bruce Momjian wrote: Alvaro Herrera wrote: On Mon, Jul 12, 2004 at 02:31:37PM -0400, Bruce Momjian wrote: OK, but why would we document the contents of a file that are not to be modified by the user? But how is the file used? Where do I

Re: [PATCHES] initdb authentication

2004-07-15 Thread Alvaro Herrera
connections by default completely, and spit a reject message along the lines of you should have a look at pg_hba.conf. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Uno combate cuando es necesario... ¡no cuando está de humor! El humor es para el ganado, o para hacer el amor, o para tocar el baliset

Re: [PATCHES] [subxacts] Savepoint syntax

2004-07-15 Thread Alvaro Herrera
On Wed, Jul 14, 2004 at 03:03:02PM -0400, Alvaro Herrera wrote: Please test, review and apply. If anyone is able to crash the server using this I'll be most interested. I just noticed that the misc regression test is generated, and so it needs to be patched ... interdiff output attached

[PATCHES] [subxact] Proof-of-concept: report nest level to client

2004-07-16 Thread Alvaro Herrera
... if this is the case I'll submit a better patch tomorrow. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) No hay hombre que no aspire a la plenitud, es decir, la suma de experiencias de que un hombre es capaz diff -u src/backend/access/transam/xact.c src/backend/access/transam/xact.c --- src/backend/access

Re: [PATCHES] [subxacts] Savepoint syntax

2004-07-26 Thread Alvaro Herrera
On Sun, Jul 25, 2004 at 04:58:01PM -0400, Alvaro Herrera wrote: Attached is the savepoints syntax patch, hopefully last try. Essentially the same as the last patch, with the following differences: Brown paper bag patch. Please disregard. I'll post a good patch tomorrow morning. Sorry

[PATCHES] [subxacts] Some docs

2004-07-27 Thread Alvaro Herrera
Hackers, Here is a doc patch that includes pages for savepoint commands. It would be cool if they can be applied as starting points for savepoint documentation. Poeple who can do better, please feel free to improve in any way. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Cómo ponemos nuestros

Re: [PATCHES] [subxacts] Fixing TODO items

2004-07-28 Thread Alvaro Herrera
On Tue, Jul 27, 2004 at 01:32:01PM -0400, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: There are some likely controversial changes; the Xid caches, in the first place. No kidding ;-) Do you have any theoretical or practical evidence for the usefulness of the negxids cache

Re: [PATCHES] [subxacts] Fixing TODO items

2004-07-28 Thread Alvaro Herrera
On Tue, Jul 27, 2004 at 01:32:01PM -0400, Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: There are some likely controversial changes; the Xid caches, in the first place. No kidding ;-) Ok, here is another try. This patch includes both the Xid cache rewrite, source documentation

[PATCHES] String consistency

2004-08-01 Thread Alvaro Herrera
Hackers, This little patch reworks some strings that were already present in 7.4 with a minor difference. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La persona que no quería pecar / estaba obligada a sentarse en duras y empinadas sillas/ desprovistas, por cierto de blandos atenuantes

Re: [PATCHES] [subxacts] Last try before beta

2004-08-01 Thread Alvaro Herrera
be a good idea to move tqual.c to access/transam. I think it's weird in utils/time, and do we really want a directory for just one file that's even badly placed according to the comments on the file itself? -- Alvaro Herrera ([EMAIL PROTECTED]) Y eso te lo doy firmado con mis lágrimas (Fiebre del

Re: [PATCHES] win32 version info - try 2

2004-08-01 Thread Alvaro Herrera
On Sat, Jul 31, 2004 at 05:40:34PM -0700, Gavin M. Roy wrote: I took the ai file, reduced it to the right sizes in photoshop and used an icon editor to make it at various resolutions. Can this be done programatically using, say, ImageMagick? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl

Re: [PATCHES] SGML cleanup

2004-08-22 Thread Alvaro Herrera
/ and !productnameOracle/ allow the literalSAVEPOINT/literal !keyword to be omitted. SQL2003 allows only literalWORK/, not Why are we mentioning Oracle behavior at all? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) El número de instalaciones de UNIX se ha elevado a 10, y se espera que este número

Re: [PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Alvaro Herrera
targets does not help them. At least that's how RPM packages are done. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) I call it GNU/Linux. Except the GNU/ is silent. (Ben Reiter) ---(end of broadcast)--- TIP 9: the planner will ignore your desire

Re: [PATCHES] pgxs default installation + various fixes

2004-09-02 Thread Alvaro Herrera
. AFAIK, actually they don't. What was the argument for having an install-all-headers target in the first place? It creates a lot of unnecessary pain, just to save some disk space. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) I think my standards have lowered enough that now I think 'good design

Re: [PATCHES] pgxs default installation + various fixes

2004-09-03 Thread Alvaro Herrera
doing useful work. Is there an objection to trying to convert it to a simpler, faster alternative? Maybe even one that receives multiple files as arguments, which would reduce the number of times it is called by an order of magnitude. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Schwern It does

[PATCHES] new spanish translations

2004-09-06 Thread Alvaro Herrera
-c -v pg_ctl.es.po 83 translated messages. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Hoy es el primer día del resto de mi vida # Spanish translation of initdb. # This file is put in the public domain. # Álvaro Herrera [EMAIL PROTECTED], 2004. msgid msgstr Project-Id-Version: initdb 8.0\n

[PATCHES] heap_modifytuple

2004-09-08 Thread Alvaro Herrera
(that grep can find, that is). Regression test pass, no new compiler warning generated. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La verdad no siempre es bonita, pero el hambre de ella sí Index: src/backend/access/common/heaptuple.c

[PATCHES] Xid in log_line_prefix

2004-09-10 Thread Alvaro Herrera
to me that the most obvious letter was x. So I used that, and changed the postmaster and friends stop here to q. I also thought of using %t, but that is already taken too. Anyone has a better idea? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Bob [Floyd] used to say that he was planning to get

[PATCHES] oid2name

2004-09-14 Thread Alvaro Herrera
and -t arguments, and it will show all the objects in one go. By default it only shows filenode and relation name, though a -x switch makes it include tablespace name, schema name and OID. Also, the headers are prettier. Please comment, review and/or apply. -- Alvaro Herrera (alvherre

[PATCHES] More spanish translation updates

2004-09-14 Thread Alvaro Herrera
Attached are pg_controldata and pg_resetxlog spanish translation updated. $ LC_ALL=C msgfmt -C -v pg_resetxlog-es.po 58 translated messages. $ LC_ALL=C msgfmt -C -v pg_controldata-es.po 41 translated messages. Please install. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Pido que me den el

Re: [PATCHES] French translation updates for 7.4 and 7.5

2004-09-20 Thread Alvaro Herrera
of me. Working on two computers didn't help me. I totaly re-translated the pg_ctl one. FWIW, there's no need to do that. You can correct the files (or the relevant sections, separating in pieces, recoding and merging) by using iconv or recode. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Cada

Re: [PATCHES] psql: rollback only last query on error

2004-09-21 Thread Alvaro Herrera
8.1 development starts, you can submit a patch to clean up. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Cada quien es cada cual y baja las escaleras como quiere (JMSerrat) ---(end of broadcast)--- TIP 2: you can get off all lists at once

Re: [PATCHES] WIP: CREATE TABLE AS / WITH DATA

2004-09-22 Thread Alvaro Herrera
supporting SELECT INTO as well as both types of CREATE TABLE AS? I remember being annoyed by some limitation of one of the forms ... -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Hoy es el primer día del resto de mi vida ---(end of broadcast)--- TIP 7

[PATCHES] ALTER TABLE .. OWNER TO and sequences

2004-09-22 Thread Alvaro Herrera
manually (the principle of least surprise indicates that the sequence should be altered automatically). Please review. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Now I have my system running, not a byte was off the shelf; It rarely breaks and when it does I fix the code myself. It's stable, clean

Re: [PATCHES] plperl features

2004-09-29 Thread Alvaro Herrera
that be disallowed or something? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Java is clearly an example of a money oriented programming (A. Stepanov) ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org

Re: [PATCHES] additional GCC warning flags

2004-10-19 Thread Alvaro Herrera
is displayed. ifeq ($(KBUILD_VERBOSE),1) quiet = Q = else quiet=quiet_ Q = @ endif A sample target would be %.o: %.c scripts FORCE $(Q)$(MAKE) $(build)=$(@D) $@ -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Endurecerse, pero jamás perder la ternura (E. Guevara

[PATCHES] CVS should die (was: Possible make_oidjoins_check ...)

2004-11-04 Thread Alvaro Herrera
three times you have said that in the recent past. IMHO this really screams of changing the SCM tool. Can this be discussed for 8.1? -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La felicidad no es mañana. La felicidad es ahora ---(end of broadcast

[PATCHES] ON COMMIT and foreign keys

2004-11-05 Thread Alvaro Herrera
is not as intrusive as it looks; there's a lot of whitespace change. -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) Ellos andaban todos desnudos como su madre los parió, y también las mujeres, aunque no vi más que una, harto moza, y todos los que yo vi eran todos mancebos, que ninguno vi de edad de

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-06 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Incidentally (collateral damage), the patch modifies the TRUNCATE command so that it can work on multiple tables. In particular, if foreign key references are all internal to the group that's being truncated, the command

  1   2   3   4   5   6   7   8   >