Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/openssl openssl.c

2007-07-11 Thread Pierre
be in the NEWS file, even if nobody uses it :) (for example, It is useful when one has to patch its php after a release) Thanks, --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src / NEWS /ext/openssl openssl.c

2007-08-06 Thread Pierre
cipher functions . Added access to internal values of DSA, RSA and DH keys Thanks! --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/openssl openssl.c

2007-08-08 Thread Pierre
to be resource, boolean given in /local/qa/5_2/ext/openssl/tests/bug36732.php on line 20 006+ 007+ Warning: openssl_x509_export(): cannot get cert from parameter 1 in /local/qa/5_2/ext/openssl/tests/bug36732.php on line 25 On 06.08.2007 23:50, Pierre-Alain Joye wrote: pajoye

Re: [PHP-CVS] cvs: php-src /ext/standard dir.c

2007-09-20 Thread Pierre
) and to do not break old applications: having glob returning false (error). We can introduce again the warning but it may defeat again the main purpose of this fix. Cheers, --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/exif exif.c

2007-12-17 Thread Pierre
it was not possible (and hope it was not possible :) -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/exif exif.c

2007-12-17 Thread Pierre
an extension (date was one of them even I still think that date should be a core feature of php :) -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/soap php_encoding.c /ext/soap/tests server030.phpt server030.wsdl

2007-12-27 Thread Pierre
that may not be present. Yes, we have asked that many many times. the Standard Php Library belongs to the core part of php. Even if I slightly disagree with its name, some of its parts should even be pushed in zend/, see the archives for a list. -- Pierre http://blog.thepimp.net | http://www.libgd.org

Re: [PHP-CVS] cvs: php-src / README.UPDATING_TO_PHP6

2006-03-22 Thread Pierre
during the discussions, or did not read them, please keep such comments for another place. --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src / README.UPDATING_TO_PHP6

2006-03-22 Thread Pierre
of this little snippet provided it as example and explicitelly said that it needs improvements, enhancements or tests (and I repeat this call in the commit log message). Fixing it is good, commenting it as you do is not. --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit

Re: [PHP-CVS] cvs: php-src / README.UPDATING_TO_PHP6

2006-03-22 Thread Pierre
the whole purpose IMO. I agree too, that's why I was not in favour to even document a way to emulate RG. Please bring this topic back to internals, Andi requested this doc and there was no objection. --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/xmlreader php_xmlreader.c

2006-03-30 Thread Pierre
you think this could cause issues for people .. maybe wait for 5.2? It will as soon as someone uses ==='', I agree that should not be changed in a bug fix release. --Pierre . -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/xmlreader php_xmlreader.c

2006-03-30 Thread Pierre
accessing uninitialized variable triggers E_NOTICE, why not XML attribute? (yeah, massive BC break so no chance in hell I'd recommend implementing it though) That's insane :-) Null is the way to go, the question was only when is the right time to make the change. --Pierre -- PHP CVS Mailing

Re: [PHP-CVS] cvs: php-src(PHP_5_1) / run-tests.php

2006-05-03 Thread Pierre
On 5/3/06, Marcus Boerger [EMAIL PROTECTED] wrote: Hello Pierre-Alain, i don't have /home/pierre on my machine and i will never have that. Please respect the rule to this one file: only authors are allowed to commit to this (check the archieves). The rule is there for a reason

Re: [PHP-CVS] cvs: php-src / NEWS /ext/standard basic_functions.c file.c file.h

2006-05-07 Thread Pierre
or temp? :) But I can live with sys_get_temp_dir() --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src / NEWS /ext/standard basic_functions.c file.c file.h

2006-05-07 Thread Pierre
would choose sys_get_temporary_directory. Or at least respect the CS a bit more and use sys_get_temp_dir(), as decided a while ago :-) --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /main/streams filter.c

2006-05-19 Thread Pierre
, I believe tests won't do any harm anyway. I second that. They will also help to catch problems between 5.1 and other versions. --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/prephp EXPERIMENTAL

2006-05-27 Thread Pierre
not remember any discussion about the name to give to this project. Or did I miss them? Nota bene, this is exactly why discussions should be done before and not after :) --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-27 Thread Pierre
not work anymore. It is still used (sadly), so we have to take care of this problem. -- Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-28 Thread Pierre
On 7/28/06, Dmitry Stogov [EMAIL PROTECTED] wrote: The patch breaks HEAD. I cannot compile PHP. It should be ifdef'ed. HEAD does not have magic quotes support. I will commit the change asap. --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net

Re: [PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-28 Thread Pierre
5.2.x release or CVS (see #38208 for example). Cheers, --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/zip php_zip.c

2006-11-11 Thread Pierre
, which error do you have? --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/zip php_zip.c

2006-11-11 Thread Pierre
Hello, On 11/12/06, Nuno Lopes [EMAIL PROTECTED] wrote: It sounds wrong. _zip_free is a private function and is used in zip_close. Can you do it there instead? itself.oo_delete.phpt works here, which error do you have? --Pierre Yes, I also thought that it was a private function, but I

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip/lib zip_open.c

2006-11-15 Thread Pierre
there? --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/pdo_sqlite pdo_sqlite.c php_pdo_sqlite.h php_pdo_sqlite_int.h sqlite_driver.c sqlite_statement.c

2006-12-15 Thread Pierre
sqlite_statement.c Log: merge php5 pdo_sqlite into head; this source compiles on both php5 and php6. Can you please clarify the compiles on both php5 and php6? The php_pdo_get_exception functions signature differs in versions before 5.2 (needs TSRM argument), or do you target 5.2+ only? --Pierre

Re: [PHP-CVS] cvs: php-src /ext/pdo_sqlite pdo_sqlite.c php_pdo_sqlite.h php_pdo_sqlite_int.h sqlite_driver.c sqlite_statement.c

2006-12-15 Thread Pierre
Hello, On 12/15/06, Wez Furlong [EMAIL PROTECTED] wrote: The version of PDO that this version of PDO_SQLITE requires does not have a tsrm arg there. Ah ok thanks, --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd gd.c php_gd.h

2007-01-08 Thread Pierre
libt1 Is it really needed to clog the source code with those ifdefs? It's not like this is a performance issue here... I agree. There is no issue to fix :) That being said, I'm not sure such changes are welcome during the RC phase. Please try to commit such changes after 5.2.1. --Pierre -- PHP CVS

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd gd.c php_gd.h

2007-01-09 Thread Pierre
was already there. I just moved it around) As I said, I have no real problem with such changes. I just feel like they should not be done in a RC phase. Cleanup or speedup are otherwise welcome :) --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd/libgd gd.c

2007-01-13 Thread Pierre
the pts vector to char to save (much) memory # Pierre: one more to merge ;) Thanks for the catch. I like to merge (and keep the fix) if I know what you are fixing. Can you send me the details please? About removing the dead code, again I do not like to do it during the RC phase. Please do

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd/libgd gd.c

2007-01-13 Thread Pierre
while at it, remove some dead code and change the pts vector to char to save (much) memory # Pierre: one more to merge ;) Thanks for the catch. I like to merge (and keep the fix) if I know what you are fixing. Can you send me the details please? As the commit log says, I fixed a few

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd/libgd gd.c

2007-01-14 Thread Pierre
is released). After that I can look at it (and no, it won't have any BC issues). You'll be the first to read it, don't worry ;) Being the first does not matter, but only before the commit, I hate arguing like we are doing now when the topic of the discussion is already in CVS :) Cheers, --Pierre

Re: [PHP-CVS] cvs: php-src /ext/zip php_zip.c php_zip.h zip_stream.c

2007-03-14 Thread Pierre
On 3/14/07, Ilia Alshanetsky [EMAIL PROTECTED] wrote: Revert? You just changed the code into a macro. It was already a macro, you should have used it. So yes, I revert yours, rename the macro to make its goal clearer and use it. --Pierre -- PHP CVS Mailing List (http://www.php.net

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip php_zip.c

2007-03-14 Thread Pierre
:) --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gd gd.c /ext/gd/libgd gd.c

2007-06-06 Thread Pierre
you be more specific? At least in the NEWS entry, by listing the affected functions.Thanks again for the patch! :) --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/gd gd.c /ext/gd/libgd gd.c

2007-06-06 Thread Pierre
On 6/6/07, Antony Dovgal [EMAIL PROTECTED] wrote: On 06.06.2007 14:00, Pierre wrote: On 6/6/07, Antony Dovgal [EMAIL PROTECTED] wrote: tony2001Wed Jun 6 09:45:43 2007 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS /php-src/ext/gd/libgd

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd/libgd gd.c

2007-06-16 Thread Pierre
On 6/15/07, Stanislav Malyshev [EMAIL PROTECTED] wrote: + pts = (char *) ecalloc(im-sy * im-sx, sizeof(char)); I don't see any overflow checks around, are you sure it's safe? Checks are done in gdImageCreate* --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit

Re: [PHP-CVS] cvs: php-src(PHP_4_4) / NEWS /ext/standard dir.c

2007-06-22 Thread Pierre
-4.4dev/ext/standard/dir.c:387: error: void value not ignored as it ought to be make: *** [ext/standard/dir.lo] Error 1 php 5+'s php_dirname works in place without altering the path. That's not the case in 4.x. Only choice is to duplicate it before calling dirname. http://pecl.php.net/~pierre

Re: [PHP-CVS] cvs: php-src /ext/standard dir.c /ext/standard/tests/file bug41655_1.phpt

2007-06-25 Thread Pierre
); + + php_dirname(basename, pattern_len); Why is it a better fix? In these versions (head and 5.2), we don't need to duplicate the pattern. I applied in 4.4 as dirname modifies the pattern. Cheers, --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/xmlwriter/tests 007.phpt OO_007.phpt

2007-06-26 Thread Pierre
On 6/26/07, Dmitry Stogov [EMAIL PROTECTED] wrote: The behavior with libxml 2.6.29 is wrong, but this is libxml bug and it cannot be simple fixed in PHP. What Tony (afaiu :) meant is to skip the test if the libxml version is younger than 2.6.29. Thanks, --Pierre -- PHP CVS Mailing List

Re: [PHP-CVS] Re: [PHP-QA] Re: Test failure on MacOS X and Failure analysis

2007-06-28 Thread Pierre
are realpath, basename, dirname or pathinfo (for example, pathinfo should/could be portable (someone reported a bug about it). recently). --Pierre -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_API.c zend_API.h php-src/ext/standard type.c

2008-02-01 Thread Pierre Joye
reasons. A fatal error means the engine is getting foo bared and can't do anything sane but leaving. -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build config.w32

2008-03-17 Thread Pierre Joye
and build PHP to actually do it. I think the following should be done: 1. Build should use .c versions without trying to rebuild them each time (somehow doesn't work right now) 2. Configuration should not require re2c installed There is two scenarii -- Pierre http://blog.thepimp.net | http

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build config.w32

2008-03-17 Thread Pierre Joye
a weird compilation error instead of a nice xyz is missing and is required to generate abc. Would it not better to do it this way? Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-20 Thread Pierre Joye
, short tags are evil, what do we need to say to close this pointless debate? Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-20 Thread Pierre Joye
list archive to figure out the (valid) reasons. -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-20 Thread Pierre Joye
must be right and I must be wrong. That being said, promoting non standard PI is a bad thing, no matter the context. -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-20 Thread Pierre Joye
, this is the translation of what I mean behind suddenly, as you did not get it. I strongly suggest to revert this insanity :) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Pierre Joye
to discuss. Where did you post it? I can't remember a proposal and and can't find it either in the internals archive. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2008-03-21 Thread Pierre Joye
Jani's post). You don't consider our explanations as valid, I'm not sure what else can be done. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build confutils.js

2008-03-31 Thread Pierre Joye
) would work in any case and will be generic enough to do not have to worry about such static tests. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build confutils.js

2008-03-31 Thread Pierre Joye
On Mon, Mar 31, 2008 at 1:11 PM, Steph Fox [EMAIL PROTECTED] wrote: Hi Pierre, That's really too hackisch and unclean. I'm very aware of that - it's a temporary measure to avoid the need for new headers in 7 extensions. Using GREP_HEADER (line 738) together with a glob(*.h

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build config.w32

2008-03-31 Thread Pierre Joye
... It's required for source snapshots to work. And even more important, it is required for us to work :) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / acinclude.m4

2008-04-01 Thread Pierre Joye
someone configures to enable it. So we might want to add a note about this. To make a long story short: What prevent you to fire this release? Even as beta? That's all we need. -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/ldap ldap.c

2008-06-02 Thread Pierre Joye
. If you have suggestions or improvements, please post them. # Someone should remove Pierre's karma too.. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/ldap ldap.c

2008-06-02 Thread Pierre Joye
I'm done 4. Don't revert the strdup warning You are a real annoyance right now, stop be counter productive. -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mcrypt mcrypt.c php_mcrypt.h /ext/mcrypt/tests bug35496.phpt bug41252.phpt bug43143.phpt mcrypt_cbc.phpt mcrypt_cbf.phpt mcrypt_decrypt

2008-07-03 Thread Pierre Joye
On Thu, Jul 3, 2008 at 4:23 PM, Derick Rethans [EMAIL PROTECTED] wrote: On Thu, 3 Jul 2008, Pierre-Alain Joye wrote: pajoyeThu Jul 3 13:50:15 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mcrypt mcrypt.c php_mcrypt.h /php-src/ext

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mcrypt mcrypt.c php_mcrypt.h /ext/mcrypt/tests bug35496.phpt bug41252.phpt bug43143.phpt mcrypt_cbc.phpt mcrypt_cbf.phpt mcrypt_decrypt

2008-07-04 Thread Pierre Joye
to do in php-src but pecl. I would like to get more team work and cooperation from you. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] Re: cvs: php-src(PHP_5_3) /ext/hash hash.c

2008-07-05 Thread Pierre Joye
[128]; All tests passed here (win and linux). But your new version is cleaner as shorter and no useless memcpy, thanks :) And it builds (win32 snapshots are back too, I fixed them yesterday, between the compilation error and some script bug). Cheers, -- Pierre http://blog.thepimp.net | http

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c php_mbregex.c /ext/mbstring/tests mb_ereg2.phpt mb_regex_encoding_error1.phpt mb_regex_encoding_variation1.phpt mb_substr_error1.phpt mb_su

2008-07-06 Thread Pierre Joye
api Please merge these changes to HEAD as well (HEAD is an active branch ;) Thanks for your work! Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build config.w32 confutils.js

2008-07-07 Thread Pierre Joye
] = 'VC6'; -VC_VERSIONS[1300] = 'Visual C++ 2002'; -VC_VERSIONS[1310] = 'Visual C++ 2003'; -VC_VERSIONS[1400] = 'Visual C++ 2005'; -VC_VERSIONS[1500] = 'Visual C++ 2008'; Please leave the declaration here, it is in the top of the configure script where other globals are declared. Cheers, -- Pierre

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard info.c

2008-07-07 Thread Pierre Joye
) { php_info_print_table_row(2, Server API, sapi_module.pretty_name ); } -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build config.w32 confutils.js

2008-07-07 Thread Pierre Joye
On Mon, Jul 7, 2008 at 2:33 PM, Steph Fox [EMAIL PROTECTED] wrote: Hi Pierre, - Fix up some bits and pieces. For examples? Log message helps to see what has been changed, please be verbose. Literally 'bits and pieces'. The duplicate function we discussed, ws, moving the MS versioning

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build config.w32 confutils.js

2008-07-07 Thread Pierre Joye
and allows each output to be stored in a file. It will help to improve and automate the QA check as well. Cheers -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build config.w32 confutils.js

2008-07-07 Thread Pierre Joye
commits to both branches). Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build DSP.README block.template.dsw buildconf.js config.w32 confutils.js projectgen.js template.dsp template.dsw

2008-07-09 Thread Pierre Joye
in regards of the DSP but update them until cmake is ready. I'm not sure it is worth the effort to do that now. It would be also nice to ask first and provide some patches too. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/openssl xp_ssl.c /ext/standard file.c http_fopen_wrapper.c streamsfuncs.c /main/streams streams.c userspace.c xp_socket.c

2008-07-11 Thread Pierre Joye
http_fopen_wrapper.c /php-src/main/streams streams.c userspace.c xp_socket.c Log: MFH: manage references of stream context properly -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre http://blog.thepimp.net | http

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring php_mbregex.h

2008-07-16 Thread Pierre Joye
to test/fix :) Or you can use for the cases where only unix is affected: #ifndef PHP_WIN32 do your unix only stuff #endif Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring php_mbregex.h

2008-07-16 Thread Pierre Joye
On Wed, Jul 16, 2008 at 6:21 PM, Moriyoshi Koizumi [EMAIL PROTECTED] wrote: Hi Pierre, Pierre Joye wrote: You can always ask us to test/fix :) Or you can use for the cases where only unix is affected: #ifndef PHP_WIN32 do your unix only stuff #endif Thanks for the tips. I'll try my

Re: [PHP-CVS] Re: cvs: php-src(PHP_5_3) /ext/sqlite3 php_sqlite3.h php_sqlite3_structs.h /ext/sqlite3/tests skipif.inc stream_test.inc

2008-07-28 Thread Pierre Joye
something other than 'X' is used? Depends of the file but generally Unix NL for the src files (.h and .c) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src / Makefile.gcov

2008-07-29 Thread Pierre Joye
are well integrated. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src / Makefile.gcov

2008-07-30 Thread Pierre Joye
hi, On Wed, Jul 30, 2008 at 2:43 AM, Marcus Boerger [EMAIL PROTECTED] wrote: Hello Pierre, but we are not creating tests for any of these, actually all of these have their own testing system which in most case is not even bundeled or executable through PHP. So the only way out is to run

Re: [PHP-CVS] cvs: php-src / Makefile.gcov

2008-07-30 Thread Pierre Joye
it. As I agree that good coverage is a noble cause. I prefer to have a slightly lower visible coverage and get the code actually covered marked as such. Please revert this change for GD. -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring/oniguruma regint.h

2008-07-30 Thread Pierre Joye
On Wed, Jul 30, 2008 at 10:41 AM, Moriyoshi Koizumi [EMAIL PROTECTED] wrote: What about sharing your patch with the author of the library? Where is it hosted? -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring/oniguruma regint.h

2008-07-30 Thread Pierre Joye
unresolved externals When mbstring is built statically. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mbstring/oniguruma regint.h

2008-07-30 Thread Pierre Joye
is updated or not. I may do it in 2-3 weeks. Or feel free to do it if you have the time/need :-) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/file fopen_variation10-win32.phpt fopen_variation11-win32.phpt TSRM tsrm_virtual_cwd.c

2009-01-21 Thread Pierre Joye
:. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/bz2 bz2_filter.c

2009-02-05 Thread Pierre Joye
, you in this case (the amount of work for the commit itself is not relevant, the dots must die! :-) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/curl streams.c

2009-02-23 Thread Pierre Joye
://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/curl streams.c

2009-02-23 Thread Pierre Joye
ah ok, even better then :) On Mon, Feb 23, 2009 at 5:10 PM, Ilia Alshanetsky i...@prohost.org wrote: I am going to back-port this to 5.2 once 5.2.8 is out, so no point in adding it to the 5.3 news file, just to remove it a week later. On 23-Feb-09, at 11:03 AM, Pierre Joye wrote: hi Ilia

Re: [PHP-CVS] cvs: php-src /ext/standard var_unserializer.c var_unserializer.re /ext/standard/tests/serialize bug46882.phpt

2009-03-17 Thread Pierre Joye
/var_unserializer.c:1.98   +--+ -  | PHP Version 6                                                        | +  | PHP Version 5                                                        | That's 6 not 5 :) -- Pierre http://blog.thepimp.net

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/mbstring config.m4 mbstring.dsp /ext/mbstring/libmbfl/filters Makefile.am Makefile.bcc32 mbfilter_cp850.c mbfilter_cp850.h unicode_table_cp850.h /ext/

2009-03-20 Thread Pierre Joye
://www.php.net/unsub.php -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/gd gd.c

2009-03-24 Thread Pierre Joye
2009/3/24 Pierre-Alain Joye paj...@php.net:  - GEPJ.. (thx to Derick for the head!) +up and sigh. -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/openssl openssl.c

2009-03-30 Thread Pierre Joye
List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard exec.c

2009-04-20 Thread Pierre Joye
); +                               }                        } else if (type == 2) {                                /* strip trailing whitespaces */                                l = bufl; -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/imap php_imap.c

2009-04-25 Thread Pierre Joye
Taskinen jani.taski...@sci.fi wrote: Isn't this necessary in PHP_5_2? Sounds like a bug fix to me.. --Jani Pierre-Alain Joye kirjoitti: pajoye          Sat Apr 25 15:02:36 2009 UTC  Modified files:              (Branch: PHP_5_3)    /php-src/ext/imap   php_imap.c  Log:  - MFH:  SEARCHPGM

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/imap php_imap.c

2009-04-25 Thread Pierre Joye
k :) On Sat, Apr 25, 2009 at 6:03 PM, Ilia Alshanetsky i...@prohost.org wrote: I'd prefer to avoid introducing new functionality into 5.2 at this point. Ilia Alshanetsky On 25-Apr-09, at 11:14 AM, Pierre Joye wrote: hi Jani, Yes, I will MFH it as well. I also like to add mail_gc

Re: [PHP-CVS] cvs: php-src /ext/imap config.m4 php_imap.c php_imap.h

2009-05-05 Thread Pierre Joye
On Tue, May 5, 2009 at 6:29 PM, Jani Taskinen jani.taski...@sci.fi wrote: That might work in wonderland when using toy OS like Windows but in the real world and with real OSes you can't force people to start using the bleeding edge stuff. it is 2 years old :) -- Pierre http

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/intl/idn idn.c

2009-05-11 Thread Pierre Joye
it this week, I should have done it beofore already :) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/xmlwriter php_xmlwriter.c

2009-05-11 Thread Pierre Joye
Did you notice the assigned field in the bug report? I had the patch already as well (wrote it on my way back home from the NL test fest, these bugs were found there while writing tests for xmlwriter :) Can you MFB it to 5.2 as well then? Small enough. Cheers, -- Pierre On Mon, May 11, 2009

Re: [PHP-CVS] cvs: php-src /ext/curl interface.c

2009-05-18 Thread Pierre Joye
the 2nd one... but I'm done now anyway. It is already less painful to merge head and 5.3 -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqli mysqli_api.c

2009-05-23 Thread Pierre Joye
. This is not affecting HEAD this type and all other are available in stdint.h and win32/php_stdint.h on windows. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build registersyslog.php

2009-05-27 Thread Pierre Joye
: http://www.php.net/unsub.php -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/bcmath/libbcmath/src bcmath.h

2009-06-03 Thread Pierre Joye
not affect any other platform and revert it if yes (it works on win already, only not in some weird configuration). Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/soap php_http.c

2009-06-04 Thread Pierre Joye
only once /local/qa/head/ext/soap/php_http.c:592: error: for each function it appears in.) -- Wbr, Antony Dovgal --- http://pinba.org - realtime statistics for PHP -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre http

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Pierre Joye
. regards, Lukas Kahwe Smith m...@pooteeweet.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Pierre Joye
hi Andrey, On Thu, Jun 11, 2009 at 7:25 PM, Andrey Hristovandrey.hris...@sun.com wrote:  Hi Pierre, Pierre Joye wrote: hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Pierre Joye
by that allocated variable. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/mysqlnd mysqlnd_wireprotocol.c

2009-06-11 Thread Pierre Joye
see this happening. mysqlnd in 5_3 and HEAD _should_ be in sync - exactly the same code except for the cvs tags. This makes the life easier. My last commits have nothing to do with this warning. However, all branches should indeed be synced :) Cheers, -- Pierre http://blog.thepimp.net | http

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_wireprotocol.c

2009-06-11 Thread Pierre Joye
/unsub.php -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/date/lib timelib_structs.h

2009-06-15 Thread Pierre Joye
hi, On Mon, Jun 15, 2009 at 4:55 PM, Derick Rethansder...@php.net wrote: On Mon, 15 Jun 2009, Pierre-Alain Joye wrote: pajoye                Mon Jun 15 14:39:37 2009 UTC   Modified files:     /php-src/ext/date/lib     timelib_structs.h   Log:   - simplify, use correct type and silent

Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-06-17 Thread Pierre Joye
On Thu, Jun 18, 2009 at 12:51 AM, Jani Taskinenj...@php.net wrote: jani            Wed Jun 17 22:51:06 2009 UTC  Modified files:              (Branch: PHP_5_3)    /php-src    NEWS  Log:  Pierre, this can not be so hard I followed what was in RC3, Felipe fixed and etc. etc. -- Pierre http

  1   2   3   4   5   6   7   8   9   10   >