D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

2018-03-06 Thread Radek Hušek
Pitel added a comment. The patch definitely can wait until you finish the rework. A few thoughts that crossed my mind when reading proposed changes: - I really like the standalone basic items placed by drag and drop. - Is floating really floating or just another layer of occupying?

D10837: bad textarea width for rename file if filename too short

2018-03-06 Thread Painless Roaster
painlessroaster added a comment. Radek Bucek radek.bu...@voipmonitor.org REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma, hein Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D11061: Migration request from IBusConfig to GSettings

2018-03-06 Thread Takao Fujiwara
fujiwara added a comment. In D11061#219841 , @davidedmundson wrote: > FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem I may drop gconf and dconf support in IBus 1.6. It would be nice if Qt API could read GSettings.

D11061: Migration request from IBusConfig to GSettings

2018-03-06 Thread Takao Fujiwara
fujiwara marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

2018-03-06 Thread Takao Fujiwara
fujiwara updated this revision to Diff 28881. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11061?vs=28793=28881 REVISION DETAIL https://phabricator.kde.org/D11061 AFFECTED FILES applets/kimpanel/backend/ibus/ibus15/panel.cpp To: fujiwara,

D11106: Fix app initialization order

2018-03-06 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Patch inlines the code of the constructor and

D11072: [Active Window Control] Show window title when app name is missing

2018-03-06 Thread Martin Kostolný
martinkostolny accepted this revision. martinkostolny added a comment. This revision is now accepted and ready to land. Good idea, thanks! REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11072 To: Pitel, #plasma, martinkostolny Cc:

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

2018-03-06 Thread Martin Kostolný
martinkostolny added a comment. Thanks for taking the time to think about this. The number of settings (and their inconsistencies) are actually a big pain of this project. I'd like to rework it from the ground up. So if I may, I'd like to postpone your patch. When I'm finished with the

D11065: [Active Window Control] Slightly fix vertical alignment of window name

2018-03-06 Thread Martin Kostolný
martinkostolny requested changes to this revision. martinkostolny added a comment. This revision now requires changes to proceed. Firstly, thanks for your effort! I prefer the latter variant. The first proposed one proves Kai's warning because it broke multi-line title wrapping (e.g. if

D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop

2018-03-06 Thread Christoph Roick
This revision was automatically updated to reflect the committed changes. Closed by commit R871:2c0f0449a560: DrKonqi: Enable DBus-Interface for debugging with KDevelop (authored by croick). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10195?vs=26227=28877#toc REPOSITORY R871

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag updated this revision to Diff 28874. zzag added a comment. edit comments REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28868=28874 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES cmake/FindFFTW.cmake

D11101: Minor spelling corrections

2018-03-06 Thread Michail Vourlakos
mvourlakos accepted this revision. This revision is now accepted and ready to land. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D11101 To: scarlettclark, mvourlakos Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D11103: Move "Standard Shortcut" KCM down in the list

2018-03-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Standard Shortcuts (e.g. Ctrl+C for Copy) are the least

D10925: Wrap at end of selector instead of in the middle

2018-03-06 Thread Chris Holland
Zren added a comment. In D10925#219849 , @davidedmundson wrote: > > Didn't test it, just double checked the whitespace. > > Why not? Lazyness mostly. However on KDE Neon, I'd only be able to test GTK 3.18 anyways by modifying

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag updated this revision to Diff 28868. zzag added a comment. bump default shadow strength to 80% REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28863=28868 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7087: Add "Copy Info" button to the About System KCM

2018-03-06 Thread Henrik Fehlauer
rkflx added a comment. In D7087#207286 , @dhaumann wrote: > In fact, I wonder whether there already is a script or similar helper tools that give you this kind of system information. I currently do not remember, though... Anyone else?

D11101: Minor spelling corrections

2018-03-06 Thread Scarlett Clark
scarlettclark updated this revision to Diff 28864. scarlettclark added a comment. Darn editor.. sorry REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11101?vs=28860=28864 REVISION DETAIL https://phabricator.kde.org/D11101 AFFECTED FILES

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Nathaniel Graham
ngraham added a comment. That looks pretty darn nice. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag added a comment. Large shadows with 80% strength F5743746: Screenshot_20180306_215756.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta,

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag added a comment. TODO: - handle HiDPI REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag updated this revision to Diff 28863. zzag added a comment. change box shadow api REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28847=28863 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES

D11101: Minor spelling corrections

2018-03-06 Thread Michail Vourlakos
mvourlakos requested changes to this revision. mvourlakos added a comment. This revision now requires changes to proceed. please remove the unrelated whitespace change REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D11101 To: scarlettclark, mvourlakos Cc:

D11101: Minor spelling corrections

2018-03-06 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > settingsdialog.cpp:1350 > }//end of namespace > - Unrelated whitespace change REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D11101 To: scarlettclark, mvourlakos Cc: ngraham, plasma-devel, ZrenBot, lesliezhai,

D11101: Minor spelling corrections

2018-03-06 Thread Scarlett Clark
scarlettclark created this revision. scarlettclark added a reviewer: mvourlakos. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. scarlettclark requested review of this revision. REVISION SUMMARY Minor typos :) REPOSITORY R878 Latte

D11064: add preview images to fonts kcm

2018-03-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. OK, I won't block on that, but do let a Plasma developer weigh in on the subject. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson, ngraham

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

2018-03-06 Thread Travis Foster
tfoster added a comment. In D8267#156392 , @cfeck wrote: > Not 100% sure, but I think those symlinks were created by a script or template. Could you check if there are other references to those wrong names in the Oxygen cursors source? I

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff added a comment. In D11064#220180 , @ngraham wrote: > Since this is a patch for `plasma-desktop`, perhaps it would be more appropriate to use the Heading from PlasmaComponents rather than the one from Kirigami? We already have

D11064: add preview images to fonts kcm

2018-03-06 Thread Nathaniel Graham
ngraham added a comment. Since this is a patch for `plasma-desktop`, perhaps it would be more appropriate to use the Heading from PlasmaComponents rather than the one from Kirigami? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff,

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff added a comment. Sounds reasonable. F5743624: Screenshot_20180306_190613.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff updated this revision to Diff 28856. progwolff added a comment. - use Kirigami heading instead of QQuickControls2 Label REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28844=28856 BRANCH master REVISION DETAIL

D11082: [WIP] Display all StreamRestore entries in it's own config Tab

2018-03-06 Thread Chris Holland
Zren added a comment. > You forgot to add StreamRestoreTab.qml to review. Oh woops. Sorry, did a `git diff` rather than staging stuff. >> I duplicated BaseMap in map.h to use a QString key focused on the info.name property. Code duplication sucks. :/ > > Can't you just qHash()

D11082: [WIP] Display all StreamRestore entries in it's own config Tab

2018-03-06 Thread Chris Holland
Zren updated this revision to Diff 28854. Zren edited the summary of this revision. Zren added a comment. Forgot to add StreamRestoreTab.qml REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11082?vs=28783=28854 REVISION DETAIL

D11064: add preview images to fonts kcm

2018-03-06 Thread Nathaniel Graham
ngraham added a comment. The difference between 0.8 opacity and 1.0 is so subtle that there really isn't a reason to do it IMHO. At that point you're just slightly impairing readability with no benefit. See also D10899 and D10902

D10753: Provide the source selection as a contextual action

2018-03-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OK then! REPOSITORY R134 Discover Software Store BRANCH sourcesUI REVISION DETAIL https://phabricator.kde.org/D10753 To: apol, ngraham Cc: ngraham, plasma-devel, ZrenBot,

Re: Fwd: Re: kwin display issue on librem5

2018-03-06 Thread Martin Flöser
Am 2018-03-06 06:23, schrieb Bhushan Shah: Hello, On Mon, Mar 05, 2018 at 06:58:08PM -0700, Heather Ellsworth wrote: Since PureOS is based on Debian buster, the versions of kwayland and kwin I was running were: kwayland 5.42.0-2 kwin 5.12.1-1 Using the patches attached to T8067... 1. I built

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff added a comment. In D11064#220134 , @ngraham wrote: > My vote goes to using the standard colors from the active theme without messing with them. At least we should not hardcode colors. So it's either an opacity of about 0.8 to

D11064: add preview images to fonts kcm

2018-03-06 Thread Nathaniel Graham
ngraham added a comment. I thought it was okay before. It's very unusual and unnerving to have a header be de-emphasized compared to its content. My vote goes to using the standard colors from the active theme without messing with them. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. I would use this as a guide https://community.kde.org/KDE_Visual_Design_Group/HIG/Color And I would select Icon Grey for the header and Shade Black for the text below. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff added a comment. In D11064#220131 , @ngraham wrote: > I'm not thrilled with the really light 50% opacity labels, to be honest. What do you propose? I am not much of a designer... REPOSITORY R119 Plasma Desktop REVISION

D11064: add preview images to fonts kcm

2018-03-06 Thread Nathaniel Graham
ngraham added a comment. I'm not thrilled with the really light 50% opacity labels, to be honest. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham, davidedmundson, abetts, broulik,

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff added a comment. In D11064#220120 , @abetts wrote: > In D11064#220118 , @progwolff wrote: > > > Seems like VDG is happy then :D > > Many thanks to both of you! > > > >

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag added a comment. Because shadow strength isn't ignored anymore, kstyle shadows should be updated F5743558: ftw.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc:

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag updated this revision to Diff 28847. zzag added a comment. take shadow strength into account REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28833=28847 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. In D11064#220118 , @progwolff wrote: > Seems like VDG is happy then :D > Many thanks to both of you! > > @davidedmundson Any objections left? I don't have any objections. I would say, however, keep an

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff added a comment. Seems like VDG is happy then :D Many thanks to both of you! @davidedmundson Any objections left? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. In D11064#220102 , @progwolff wrote: > We don't have a font name here. The choices are always "Vendor default", "None", "RGB", "BGR", "vertical RGB", "vertical BGR". > I am not sure what a number would mean here?

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff added a comment. F5743545: Screenshot_20180306_170938.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham, davidedmundson, abetts,

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff updated this revision to Diff 28844. progwolff added a comment. - Merge branch 'master' of git://anongit.kde.org/plasma-desktop - adjust label opacity and size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28817=28844 BRANCH

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff added a comment. We don't have a font name here. The choices are always "Vendor default", "None", "RGB", "BGR", "vertical RGB", "vertical BGR". I am not sure what a number would mean here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To:

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. You are right! I was confused. Looks great then! Would having a font number on the side help? Like this 12 **Font Name** A quick brown fox jumps over the rope REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To:

D11098: use opacity instead of visible

2018-03-06 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R119:3a763498b6a4: use opacity instead of visible (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11098?vs=28841=28842 REVISION DETAIL

D11098: use opacity instead of visible

2018-03-06 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH phab/kickoffover REVISION DETAIL https://phabricator.kde.org/D11098 To: mart, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff added a comment. The list will always have the same 6 entries. This is not about choosing a font, but about choosing details about how a font is rendered. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart,

D11098: use opacity instead of visible

2018-03-06 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Qt documentation recomends to bind to opacity instead of visible as

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. That seems pretty good to me. I would even make the title label bigger, so that it looks like a header. Also, can the list be longer? At least, double the size? People tend to have a lot of fonts installed. We install a lot of them by default. This can help the

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff added a comment. How about this? F5743529: Screenshot_20180306_164925.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D10753: Provide the source selection as a contextual action

2018-03-06 Thread Aleix Pol Gonzalez
apol added a comment. This is an issue in qqc2-desktop-style, not something to solve from Discover. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10753 To: apol, ngraham Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11064: add preview images to fonts kcm

2018-03-06 Thread Nathaniel Graham
ngraham added a comment. Also FYI @progwolff your screenshots are messed up because if a bug in Spectacle that was recently fixed. Until you get that fix, you can use Active Window mode instead of Window Under Cursor mode. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. > F5743165: Screenshot_20180306_101833.png I like this one! :D above REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11064: add preview images to fonts kcm

2018-03-06 Thread Nathaniel Graham
ngraham added a comment. Here we are counting like humans, not programmers. :) We like this one: https://phabricator.kde.org/file/data/s2ekczgv5q5xxqwofahp/PHID-FILE-7wh4qv3a3lx6xe7f5khm/Screenshot_20180306_101833.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff added a comment. @abetts @ngraham Do you count from 0 or 1? Number 2 is single line `The quick brown fox...`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Nathaniel Graham
ngraham added a comment. So in general, I like the more rounded edges. But I still don't like the darker shadows and the big black line on the bottom. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr,

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag added a comment. Left - old Right - new --- Small F5743502: small.png Medium F5743505: medium.png Large F5743510: large.png Very

D11063: [mediacontroller applet] Reorder elements

2018-03-06 Thread Nathaniel Graham
ngraham added a comment. In D11063#220051 , @abetts wrote: > Not sure if it is within the scope of this patch but the spacing is uneven vertically between elements in the notification window. They need more space to breathe. > > Media

D11063: [mediacontroller applet] Reorder elements

2018-03-06 Thread Andres Betts
abetts added a comment. Not sure if it is within the scope of this patch but the spacing is uneven vertically between elements in the notification window. They need more space to breathe. Media Player Cover Artwork Progress Bar | | Song Title | | Media

D11064: add preview images to fonts kcm

2018-03-06 Thread Andres Betts
abetts added a comment. Number 2 seems like the best option. I would also make sure that there is a color difference between title label and sample text. That way it is easier to distinguish between list items. When all labels are the same color, you give equal importance to all elements.

D10753: Provide the source selection as a contextual action

2018-03-06 Thread Nathaniel Graham
ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10753 To: apol, ngraham Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10461: GMenu-DBusMenu-Proxy

2018-03-06 Thread Kai Uwe Broulik
broulik updated this revision to Diff 28838. broulik added a comment. Fix UTF8_STRING atom type check REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10461?vs=28836=28838 REVISION DETAIL https://phabricator.kde.org/D10461 AFFECTED FILES

D10753: Provide the source selection as a contextual action

2018-03-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Turning the checkboxes into radio buttons is tracked with https://bugs.kde.org/show_bug.cgi?id=391144. One more visual papercut: The menu is not wide enough to accommodate all the

Plasma 5.12.3

2018-03-06 Thread Jonathan Riddell
Plasma 5.12.3 bug fix release is available now for packagers https://www.kde.org/announcements/plasma-5.12.3.php

D10461: GMenu-DBusMenu-Proxy

2018-03-06 Thread Kai Uwe Broulik
broulik updated this revision to Diff 28836. broulik added a comment. - Fix leaks - Cleanup REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10461?vs=28320=28836 REVISION DETAIL https://phabricator.kde.org/D10461 AFFECTED FILES

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag added a comment. In D11069#219980 , @hpereiradacosta wrote: > - I agree with Nathan that the bottom part is likely too hard. I've added opacity prop so different shadows could be tweaked("darkess" at the bottom is coming from the

D10461: GMenu-DBusMenu-Proxy

2018-03-06 Thread Kai Uwe Broulik
broulik marked 5 inline comments as done. broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in icons.cpp:24 > does this list come from anywhere? It was done trial and error by running couple of gtk apps (gedit, gimp, inkscape, shotwell) etc, the kde 4 appmenu also had

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag updated this revision to Diff 28833. zzag added a comment. control look of each separate shadow with the opacity prop REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28755=28833 BRANCH shadows REVISION DETAIL

D10962: [Fonts KCM] Make font dialog modal

2018-03-06 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:c736f2e8a98c: [Fonts KCM] Make font dialog modal (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10962?vs=28380=28829 REVISION DETAIL

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

2018-03-06 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:7e5dff648f01: [Dialog] Remove now obsolete KWindowSystem::setState calls (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. Hello, - I agree with Nathan that the bottom part is likely too hard. - I think the same shadows should be used for windows and menus - Also, thanks for posting the pictures. Is there any chance you could also post new vs old shadows side by side for

D11096: [XWindowTasksModel] When name or visible name changed only update display role

2018-03-06 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:36f4ff942b6c: [XWindowTasksModel] When name or visible name changed only update display role (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11096: [XWindowTasksModel] When name or visible name changed only update display role

2018-03-06 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11096 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11096: [XWindowTasksModel] When name or visible name changed only update display role

2018-03-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The window name and user visible name are not used in the

D11061: Migration request from IBusConfig to GSettings

2018-03-06 Thread Xuetian Weng
xuetianweng requested changes to this revision. xuetianweng added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > panel.cpp:1049 > +g_signal_handlers_disconnect_by_func (impanel->settings_hotkey, > (gpointer)impanel_settings_changed_callback, impanel); > +

D11061: Migration request from IBusConfig to GSettings

2018-03-06 Thread Xuetian Weng
xuetianweng added a comment. In D11061#219841 , @davidedmundson wrote: > FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem imho, this is pretty irrelevant here.. gsettings is not directly gconf and gconf itself is

D11003: Fix the Add Source dialog

2018-03-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:b623a4afb12f: Fix the Add Source dialog (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11003?vs=28533=28821 REVISION DETAIL

D11094: add baloo-search skill delegates

2018-03-06 Thread Aditya Mehra
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:80d5e58e3434: add baloo-search skill delegates (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration

D11094: add baloo-search skill delegates

2018-03-06 Thread Aditya Mehra
Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY Baloo-search Audio/Video/Documents result delegates for mycroft

D11069: [WIP] refine decoration shadows

2018-03-06 Thread Vlad Zagorodniy
zzag added a comment. In D11069#219853 , @ngraham wrote: > I don't like how black the shadow is on the bottom. Once the strength adjustment works, we might experiment with reducing it. Yeah.. Shadow strength should at most 90%. In

D10973: [media controller applet] Support MPRIS services where CanPause==false

2018-03-06 Thread Friedrich W . H . Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:06913fc2556a: [media controller applet] Support MPRIS services where CanPause==false (authored by kossebau).

D10973: [media controller applet] Support MPRIS services where CanPause==false

2018-03-06 Thread Friedrich W . H . Kossebau
kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10973 To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D11064: add preview images to fonts kcm

2018-03-06 Thread Julian Wolff
progwolff updated this revision to Diff 28817. progwolff added a comment. - fix parsing hinting index REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28811=28817 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11064

D10461: GMenu-DBusMenu-Proxy

2018-03-06 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Fundamental design seems fine. It's a massive patchset, I'm not sure I've got my head round all of it yet, I might take a second round when these minor things

D11063: [mediacontroller applet] Reorder elements

2018-03-06 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > broulik wrote in ExpandedRepresentation.qml:124 > Why is this thing no longer in a `ColumLayout`? I want to have the controls always at the same fixed position at the bottom of the applet. With a layout it would shift them around according to

D10991: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player

2018-03-06 Thread Friedrich W . H . Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:d62c50d5c678: [mpris2 dataengine] Fix media key handling to match MediaPlayer2.Player (authored by kossebau).

D11063: [mediacontroller applet] Reorder elements

2018-03-06 Thread Roman Gilg
romangg updated this revision to Diff 28816. romangg marked 7 inline comments as done. romangg added a comment. - Comments by Kai REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11063?vs=28772=28816 BRANCH mediaAppletStructure REVISION DETAIL

D10955: [kaccess] Improve the port away from kdelibs4support

2018-03-06 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R119:0f3e344f2317: [kaccess] Improve the port away from kdelibs4support (authored by kossebau). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

  1   2   >