D11064: add preview images to fonts kcm

ngraham added a comment. Since this is a patch for `plasma-desktop`, perhaps it would be more appropriate to use the Heading from PlasmaComponents rather than the one from Kirigami? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff,

D11069: [WIP] refine decoration shadows

zzag added a comment. Large shadows with 80% strength F5743746: Screenshot_20180306_215756.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta,

D7087: Add "Copy Info" button to the About System KCM

rkflx added a comment. In D7087#207286 , @dhaumann wrote: > In fact, I wonder whether there already is a script or similar helper tools that give you this kind of system information. I currently do not remember, though... Anyone else?

D11064: add preview images to fonts kcm

ngraham added a comment. The difference between 0.8 opacity and 1.0 is so subtle that there really isn't a reason to do it IMHO. At that point you're just slightly impairing readability with no benefit. See also D10899 and D10902

D11064: add preview images to fonts kcm

progwolff added a comment. Sounds reasonable. F5743624: Screenshot_20180306_190613.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11082: [WIP] Display all StreamRestore entries in it's own config Tab

Zren updated this revision to Diff 28854. Zren edited the summary of this revision. Zren added a comment. Forgot to add StreamRestoreTab.qml REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11082?vs=28783=28854 REVISION DETAIL

D11082: [WIP] Display all StreamRestore entries in it's own config Tab

Zren added a comment. > You forgot to add StreamRestoreTab.qml to review. Oh woops. Sorry, did a `git diff` rather than staging stuff. >> I duplicated BaseMap in map.h to use a QString key focused on the info.name property. Code duplication sucks. :/ > > Can't you just qHash()

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

tfoster added a comment. In D8267#156392 , @cfeck wrote: > Not 100% sure, but I think those symlinks were created by a script or template. Could you check if there are other references to those wrong names in the Oxygen cursors source? I

D11101: Minor spelling corrections

mvourlakos requested changes to this revision. mvourlakos added a comment. This revision now requires changes to proceed. please remove the unrelated whitespace change REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D11101 To: scarlettclark, mvourlakos Cc:

D11101: Minor spelling corrections

scarlettclark updated this revision to Diff 28864. scarlettclark added a comment. Darn editor.. sorry REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11101?vs=28860=28864 REVISION DETAIL https://phabricator.kde.org/D11101 AFFECTED FILES

D10753: Provide the source selection as a contextual action

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OK then! REPOSITORY R134 Discover Software Store BRANCH sourcesUI REVISION DETAIL https://phabricator.kde.org/D10753 To: apol, ngraham Cc: ngraham, plasma-devel, ZrenBot,

D11064: add preview images to fonts kcm

progwolff added a comment. In D11064#220180 , @ngraham wrote: > Since this is a patch for `plasma-desktop`, perhaps it would be more appropriate to use the Heading from PlasmaComponents rather than the one from Kirigami? We already have

D11101: Minor spelling corrections

ngraham added inline comments. INLINE COMMENTS > settingsdialog.cpp:1350 > }//end of namespace > - Unrelated whitespace change REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D11101 To: scarlettclark, mvourlakos Cc: ngraham, plasma-devel, ZrenBot, lesliezhai,

D11069: [WIP] refine decoration shadows

zzag updated this revision to Diff 28863. zzag added a comment. change box shadow api REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28847=28863 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES

D11069: [WIP] refine decoration shadows

zzag planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

zzag added a comment. TODO: - handle HiDPI REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28856. progwolff added a comment. - use Kirigami heading instead of QQuickControls2 Label REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28844=28856 BRANCH master REVISION DETAIL

D11064: add preview images to fonts kcm

ngraham accepted this revision. ngraham added a comment. OK, I won't block on that, but do let a Plasma developer weigh in on the subject. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson, ngraham

D11101: Minor spelling corrections

scarlettclark created this revision. scarlettclark added a reviewer: mvourlakos. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. scarlettclark requested review of this revision. REVISION SUMMARY Minor typos :) REPOSITORY R878 Latte

D11069: [WIP] refine decoration shadows

ngraham added a comment. That looks pretty darn nice. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D11069: [WIP] refine decoration shadows

zzag updated this revision to Diff 28868. zzag added a comment. bump default shadow strength to 80% REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28863=28868 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES

D11069: [WIP] refine decoration shadows

zzag planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11103: Move "Standard Shortcut" KCM down in the list

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Standard Shortcuts (e.g. Ctrl+C for Copy) are the least

D10195: DrKonqi: Enable DBus-Interface for debugging with KDevelop

This revision was automatically updated to reflect the committed changes. Closed by commit R871:2c0f0449a560: DrKonqi: Enable DBus-Interface for debugging with KDevelop (authored by croick). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10195?vs=26227=28877#toc REPOSITORY R871

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

martinkostolny added a comment. Thanks for taking the time to think about this. The number of settings (and their inconsistencies) are actually a big pain of this project. I'd like to rework it from the ground up. So if I may, I'd like to postpone your patch. When I'm finished with the

D11101: Minor spelling corrections

mvourlakos accepted this revision. This revision is now accepted and ready to land. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D11101 To: scarlettclark, mvourlakos Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D11065: [Active Window Control] Slightly fix vertical alignment of window name

martinkostolny requested changes to this revision. martinkostolny added a comment. This revision now requires changes to proceed. Firstly, thanks for your effort! I prefer the latter variant. The first proposed one proves Kai's warning because it broke multi-line title wrapping (e.g. if

D11072: [Active Window Control] Show window title when app name is missing

martinkostolny accepted this revision. martinkostolny added a comment. This revision is now accepted and ready to land. Good idea, thanks! REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11072 To: Pitel, #plasma, martinkostolny Cc:

D11069: [WIP] refine decoration shadows

zzag updated this revision to Diff 28874. zzag added a comment. edit comments REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28868=28874 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES cmake/FindFFTW.cmake

D11069: [WIP] refine decoration shadows

zzag planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10925: Wrap at end of selector instead of in the middle

Zren added a comment. In D10925#219849 , @davidedmundson wrote: > > Didn't test it, just double checked the whitespace. > > Why not? Lazyness mostly. However on KDE Neon, I'd only be able to test GTK 3.18 anyways by modifying

D10837: bad textarea width for rename file if filename too short

painlessroaster added a comment. Radek Bucek radek.bu...@voipmonitor.org REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma, hein Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D11061: Migration request from IBusConfig to GSettings

fujiwara marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11106: Fix app initialization order

kossebau created this revision. kossebau added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Patch inlines the code of the constructor and

D11061: Migration request from IBusConfig to GSettings

fujiwara updated this revision to Diff 28881. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11061?vs=28793=28881 REVISION DETAIL https://phabricator.kde.org/D11061 AFFECTED FILES applets/kimpanel/backend/ibus/ibus15/panel.cpp To: fujiwara,

D11061: Migration request from IBusConfig to GSettings

fujiwara added a comment. In D11061#219841 , @davidedmundson wrote: > FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem I may drop gconf and dconf support in IBus 1.6. It would be nice if Qt API could read GSettings.

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

Pitel added a comment. The patch definitely can wait until you finish the rework. A few thoughts that crossed my mind when reading proposed changes: - I really like the standalone basic items placed by drag and drop. - Is floating really floating or just another layer of occupying?

D10973: [media controller applet] Support MPRIS services where CanPause==false

kossebau marked an inline comment as done. kossebau added inline comments. INLINE COMMENTS > broulik wrote in main.qml:91 > Shouldn't that be a binding? If the player cannot pause, the entry would just > not show up rather than become disabled, ie. keep the action as "playPause" > maybe? Not

D11064: add preview images to fonts kcm

progwolff marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28811. progwolff added a comment. - style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28804=28811 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11064 AFFECTED FILES

D11025: [taskmanager applet] Fix MPRIS buttons in tooltip for CanPause==false

kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY R119 Plasma Desktop BRANCH fixtaskmanagertooltipformpris REVISION DETAIL https://phabricator.kde.org/D11025 To: kossebau, broulik, hein Cc: plasma-devel, ZrenBot, lesliezhai,

D11064: add preview images to fonts kcm

progwolff added a comment. In D11064#219273 , @abetts wrote: > Is there a way that the list width can be dynamic so as to accommodate the name of the font family? I would prefer not to include the font family name in the combobox at all.

D10973: [media controller applet] Support MPRIS services where CanPause==false

kossebau updated this revision to Diff 28806. kossebau added a comment. make play/pause action behaviour in context menu consistent with the one for taskmanager REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10973?vs=28777=28806 BRANCH

D10925: Wrap at end of selector instead of in the middle

davidedmundson added a comment. > Didn't test it, just double checked the whitespace. Why not? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D10925 To: Zren, #breeze, abetts Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11059: Add convenience method to get a persistent model index from TasksModel

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D11059 To: davidedmundson, #plasma, hein Cc: broulik, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11064: add preview images to fonts kcm

ngraham added a comment. Out of those three, my vote goes to #2. The versions with numbers and symbols look really messy. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D10955: [kaccess] Improve the port away from kdelibs4support

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH improvekaccessport REVISION DETAIL https://phabricator.kde.org/D10955 To: kossebau, #plasma, apol, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai,

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

kossebau updated this revision to Diff 28799. kossebau added a comment. one var per variable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11007?vs=28776=28799 BRANCH fixtaskmanagercontextmenuformpris REVISION DETAIL

D11082: [WIP] Display all StreamRestore entries in it's own config Tab

drosca added a comment. You forgot to add StreamRestoreTab.qml to review. > I duplicated BaseMap in map.h to use a QString key focused on the info.name property. Code duplication sucks. :/ Can't you just qHash() the name and use it as integer index for normal MapBase? > Every

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH fixtaskmanagercontextmenuformpris REVISION DETAIL https://phabricator.kde.org/D11007 To: kossebau, broulik, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28804. progwolff added a comment. - never show scrollbars for the combobox popup (force pixel aligment) - prepare for multi-line preview images, resize images to pixel-align on high dpi displays REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D11063: [mediacontroller applet] Reorder elements

andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH mediaAppletStructure REVISION DETAIL https://phabricator.kde.org/D11063 To: romangg, #plasma, andreask Cc: nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai,

D11056: [mediacontroller applet] Use media playback status icons

andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH mediaAppletStatusIcon REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma, andreask Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11061: Migration request from IBusConfig to GSettings

davidedmundson added a comment. FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28802. progwolff added a comment. - adjust popup width to fit contents REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28792=28802 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11064

D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2b3f9cd9092f: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11007?vs=28799=28803#toc

D11057: Add a custom default avatar to the sddm-breeze theme.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11057 To: pstefan, #plasma, #vdg, davidedmundson Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10962: [Fonts KCM] Make font dialog modal

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10962 To: broulik, #plasma, hein, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11069: [WIP] refine decoration shadows

zzag added a comment. Left - old Right - new --- Small F5743502: small.png Medium F5743505: medium.png Large F5743510: large.png Very

D11064: add preview images to fonts kcm

progwolff added a comment. @abetts @ngraham Do you count from 0 or 1? Number 2 is single line `The quick brown fox...`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11064: add preview images to fonts kcm

ngraham added a comment. Here we are counting like humans, not programmers. :) We like this one: https://phabricator.kde.org/file/data/s2ekczgv5q5xxqwofahp/PHID-FILE-7wh4qv3a3lx6xe7f5khm/Screenshot_20180306_101833.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11064: add preview images to fonts kcm

abetts added a comment. > F5743165: Screenshot_20180306_101833.png I like this one! :D above REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11064: add preview images to fonts kcm

ngraham added a comment. Also FYI @progwolff your screenshots are messed up because if a bug in Spectacle that was recently fixed. Until you get that fix, you can use Active Window mode instead of Window Under Cursor mode. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10753: Provide the source selection as a contextual action

apol added a comment. This is an issue in qqc2-desktop-style, not something to solve from Discover. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10753 To: apol, ngraham Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11064: add preview images to fonts kcm

abetts added a comment. That seems pretty good to me. I would even make the title label bigger, so that it looks like a header. Also, can the list be longer? At least, double the size? People tend to have a lot of fonts installed. We install a lot of them by default. This can help the

D11064: add preview images to fonts kcm

progwolff added a comment. The list will always have the same 6 entries. This is not about choosing a font, but about choosing details about how a font is rendered. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart,

D11098: use opacity instead of visible

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3a763498b6a4: use opacity instead of visible (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11098?vs=28841=28842 REVISION DETAIL

D11064: add preview images to fonts kcm

progwolff added a comment. We don't have a font name here. The choices are always "Vendor default", "None", "RGB", "BGR", "vertical RGB", "vertical BGR". I am not sure what a number would mean here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To:

D11069: [WIP] refine decoration shadows

zzag added a comment. In D11069#219980 , @hpereiradacosta wrote: > - I agree with Nathan that the bottom part is likely too hard. I've added opacity prop so different shadows could be tweaked("darkess" at the bottom is coming from the

D10753: Provide the source selection as a contextual action

ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10753 To: apol, ngraham Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10461: GMenu-DBusMenu-Proxy

broulik updated this revision to Diff 28838. broulik added a comment. Fix UTF8_STRING atom type check REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10461?vs=28836=28838 REVISION DETAIL https://phabricator.kde.org/D10461 AFFECTED FILES

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28844. progwolff added a comment. - Merge branch 'master' of git://anongit.kde.org/plasma-desktop - adjust label opacity and size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28817=28844 BRANCH

D11069: [WIP] refine decoration shadows

ngraham added a comment. So in general, I like the more rounded edges. But I still don't like the darker shadows and the big black line on the bottom. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr,

D11064: add preview images to fonts kcm

progwolff added a comment. How about this? F5743529: Screenshot_20180306_164925.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11098: use opacity instead of visible

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Qt documentation recomends to bind to opacity instead of visible as

D11098: use opacity instead of visible

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH phab/kickoffover REVISION DETAIL https://phabricator.kde.org/D11098 To: mart, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11064: add preview images to fonts kcm

abetts added a comment. You are right! I was confused. Looks great then! Would having a font number on the side help? Like this 12 **Font Name** A quick brown fox jumps over the rope REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To:

D11064: add preview images to fonts kcm

progwolff added a comment. F5743545: Screenshot_20180306_170938.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham, davidedmundson, abetts,

D11069: [WIP] refine decoration shadows

zzag planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

ngraham added a comment. In D11063#220051 , @abetts wrote: > Not sure if it is within the scope of this patch but the spacing is uneven vertically between elements in the notification window. They need more space to breathe. > > Media

D11069: [WIP] refine decoration shadows

zzag updated this revision to Diff 28833. zzag added a comment. control look of each separate shadow with the opacity prop REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28755=28833 BRANCH shadows REVISION DETAIL

D10461: GMenu-DBusMenu-Proxy

broulik marked 5 inline comments as done. broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in icons.cpp:24 > does this list come from anywhere? It was done trial and error by running couple of gtk apps (gedit, gimp, inkscape, shotwell) etc, the kde 4 appmenu also had

D10753: Provide the source selection as a contextual action

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Turning the checkboxes into radio buttons is tracked with https://bugs.kde.org/show_bug.cgi?id=391144. One more visual papercut: The menu is not wide enough to accommodate all the

D11064: add preview images to fonts kcm

abetts added a comment. Number 2 seems like the best option. I would also make sure that there is a color difference between title label and sample text. That way it is easier to distinguish between list items. When all labels are the same color, you give equal importance to all elements.

D11063: [mediacontroller applet] Reorder elements

abetts added a comment. Not sure if it is within the scope of this patch but the spacing is uneven vertically between elements in the notification window. They need more space to breathe. Media Player Cover Artwork Progress Bar | | Song Title | | Media

D10962: [Fonts KCM] Make font dialog modal

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c736f2e8a98c: [Fonts KCM] Make font dialog modal (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10962?vs=28380=28829 REVISION DETAIL

D10461: GMenu-DBusMenu-Proxy

broulik updated this revision to Diff 28836. broulik added a comment. - Fix leaks - Cleanup REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10461?vs=28320=28836 REVISION DETAIL https://phabricator.kde.org/D10461 AFFECTED FILES

Plasma 5.12.3

Plasma 5.12.3 bug fix release is available now for packagers https://www.kde.org/announcements/plasma-5.12.3.php

D11064: add preview images to fonts kcm

abetts added a comment. In D11064#220102 , @progwolff wrote: > We don't have a font name here. The choices are always "Vendor default", "None", "RGB", "BGR", "vertical RGB", "vertical BGR". > I am not sure what a number would mean here?

D11064: add preview images to fonts kcm

progwolff added a comment. Seems like VDG is happy then :D Many thanks to both of you! @davidedmundson Any objections left? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11069: [WIP] refine decoration shadows

zzag updated this revision to Diff 28847. zzag added a comment. take shadow strength into account REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=28833=28847 BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11069 AFFECTED FILES

D11069: [WIP] refine decoration shadows

zzag planned changes to this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

zzag added a comment. Because shadow strength isn't ignored anymore, kstyle shadows should be updated F5743558: ftw.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc:

D11064: add preview images to fonts kcm

progwolff added a comment. In D11064#220131 , @ngraham wrote: > I'm not thrilled with the really light 50% opacity labels, to be honest. What do you propose? I am not much of a designer... REPOSITORY R119 Plasma Desktop REVISION

D11064: add preview images to fonts kcm

ngraham added a comment. I thought it was okay before. It's very unusual and unnerving to have a header be de-emphasized compared to its content. My vote goes to using the standard colors from the active theme without messing with them. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11064: add preview images to fonts kcm

progwolff added a comment. In D11064#220134 , @ngraham wrote: > My vote goes to using the standard colors from the active theme without messing with them. At least we should not hardcode colors. So it's either an opacity of about 0.8 to

D11064: add preview images to fonts kcm

abetts added a comment. In D11064#220118 , @progwolff wrote: > Seems like VDG is happy then :D > Many thanks to both of you! > > @davidedmundson Any objections left? I don't have any objections. I would say, however, keep an

D11064: add preview images to fonts kcm

progwolff edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11064: add preview images to fonts kcm

progwolff added a comment. In D11064#220120 , @abetts wrote: > In D11064#220118 , @progwolff wrote: > > > Seems like VDG is happy then :D > > Many thanks to both of you! > > > >

D11064: add preview images to fonts kcm

ngraham added a comment. I'm not thrilled with the really light 50% opacity labels, to be honest. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham, davidedmundson, abetts, broulik,

  1   2   >