Re: [Potlatch-dev] Potlatch 3 wish list

2017-03-25 Thread Richard Fairhurst

On 25/03/2017 01:38, David Wisbey wrote:

I have been meaning to do this for a long time. Finally...

And if I need to do this differently please let me know what I need to do. 
Thanks


Some good ideas - thanks!

Probably the best place to put them is 
http://github.com/systemed/potlatch2/issues (you'll need a Github 
login); I'm likely to forget them otherwise.


New features like copy/paste, rotate and mirror are things I'd quite 
like to do in the proverbial spare minute. An upload validator is a 
bigger task and not one I've ever been 100% convinced is the right way 
to do it - better to spot issues as the mapper works, rather than on upload.


For new/changed presets, a pull request to the XML files is always nice 
- I can't honestly keep up with all the tagging stuff myself in the time 
I have for P2. (But I've just committed the swimming pool change so 
that'll be in the next release.)


cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #4356: "Show mouse latitude/longitude" box too small

2017-03-24 Thread Richard Fairhurst

On 24/03/2017 15:01, Steve Doerr wrote:

Still a bug for me. I'm using Microsoft Edge browser.


"Fixed" means "fixed in the source code", not "deployed on osm.org" :)

Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #4902: Warnings for deleting/merging relation members

2014-02-14 Thread Richard Fairhurst

On 14/02/2014 17:44, Fernando Trebien wrote:

Hello everyone,

I was wondering when is it that Potlatch will be considered officially
deprecated.


There is no intention at all to deprecate P2.

Since newbie users are best-served by iD, the best thing you, as an OSM 
contributor, can do to prevent mapping mistakes is to add Internet 
Explorer support to iD so that new users are always presented with that. 
And, of course, you're very welcome to submit patches to P2 to address 
any issues you perceive with it.


Every editor has its pitfalls. iD has the unintentional selection of 
areas thing, JOSM has the too easy for people to make bulk edits 
thing, and so on. FWIW I noticed someone in #osm-gb earlier saying that 
they preferred P2 to other editors for route relations because it makes 
them more obvious, so your opinion is not necessarily universally 
shared. Diversity is good.


Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #4902: Warnings for deleting/merging relation members

2014-02-14 Thread Richard Fairhurst

On 14/02/2014 17:55, Fernando Trebien wrote:

The used did know know he was destroying data because Potlatch neither
displays turn restrictions


It does, you know:
http://imgur.com/j6A6clo


nor issues a warning when merging ways
referenced by relations


It does, you know:
http://imgur.com/sDqq1hf

Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Tagging of Loch Katrine

2013-06-26 Thread Richard Fairhurst

On 26/06/2013 11:58, Roger Calvert wrote:

On return, I find that it does not appear as a lake in Potlatch II,
though it does in the default OSM view.

There are seven 'outer' elements in the named relation, some of which
are very short, but appear to be joined correctly. Most of them have no
tags at all.

Can anyone see the problem?


Potlatch 2 doesn't render multipolygons where the tags are on the 
relation, only when the tags are on the way. Essentially it's awaiting a 
sane area datatype rather than the ugly hack using relations that we 
have now.


cheers
Richard



___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] P2 user check

2012-12-19 Thread Richard Fairhurst
[sent to potlatch-dev@ and rails-dev@, please trim follow-ups if 
appropriate]


I've added a new embedding option to Potlatch 2 that can warn the user 
if they attempt to save a changeset which is mostly deletions.


The option is selected like this:

args[user_check] = warn;

The value can be warn or prevent. If the former, the user is 
presented with a modal warning dialogue (select Yes or [default] 
Cancel) when trying to save a destructive changeset. If the latter, 
the dialogue only gives the Cancel option.


Code is at 
https://github.com/systemed/potlatch2/commit/55b43b43be26dcb239624aff2898a332616bbb05 
.


rails-dev people might like to consider whether, for example, osm.org 
could set warn or even prevent on all users with fewer than 5 
changesets.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OSM-newbies] Can't see my gps traces in the map or Potlatch2

2012-12-12 Thread Richard Fairhurst

On 11/12/2012 21:36, SomeoneElse wrote:

Sebastian Arcus wrote:

I have uploaded a bunch of gps traces as identifiable. They show up
under See your traces. However, when I click on map or edit I
can't see them on the map or in Potlatch2 editor. Am I doing something
wrong, or is there a temporary problem with the system?

Looking at the GPX file, I can't see anything unusual.

I've cc:ed the potlatch-dev list in case anyone there has any idea why
it may be not showing via Edit.


The XML namespace attribute in the GPX file appears to be... not what 
Potlatch 2 is expecting.


Potlatch 2 expects http://www.topografix.com/GPX/1/1
and the GPX file has http://www.topografix.com/GPX/1.1

Strictly speaking I think this is an error in the NavSys GPS logger 
software you appear to be using. It might be possible to make P2 a bit 
more tolerant, though.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] P2, snapshot-server, imports, vector layers and more

2012-11-15 Thread Richard Fairhurst

Paul Norman wrote:

Background: P2 has excellent support for data layers but their full power is
not exposed to the user by default. I am contemplating using snapshot-server
with some extremely large datasets to make the data available to people
using P2 and JOSM as vector layers.


Great stuff.


[...]
I must admit I have not verified if this would require changes to P2. It's
possible that P2 would work fine if snapshot-server returned negative IDs.


I've not tested it but I'm 99% sure it would. Happy to test if you set 
up an instance somewhere which serves negative ids!



2. Data layer exposure. To add a snapshot-server data layer to P2 you have
to deploy your own P2 instance. This severely limits exposure. What makes it
worse is that if I offer a data layer and deploy P2 and someone else does
the same, you can't use both at the same time.

A way to add a snapshot-server layer by pointing it at a configuration file
(e.g. a json file) would be very useful.

Better yet would also be a way to reveal data layers like imagery layers
are, based on bbox (or better yet, by polygon).


Ok. You can already specify bboxes in vectors.xml in the same way that 
you do in imagery.xml. So I guess the problems to address are:


1. Make it easier for 'data providers' to make users aware of data layers
2. Provide easy UI for users to select data layers

For 1; we could continue with vectors.xml, and also provide a way to 
provide a URL in the embedding page/query string (much as you can with 
background imagery).


(It might be possible to do what JOSM does by putting the sources on a 
wiki page, rather than relying on a commit to the P2 repository, but I'm 
always a bit wary of people adding Google imagery etc. without us 
noticing. Any thoughts?)


For 2; we could add a new menu like the 'Background' one showing data 
layers in the current area.


cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Outstanding pull requests (Attn Richard F)

2012-07-17 Thread Richard Fairhurst

On 17/07/2012 04:30, Steve Bennett wrote:

https://github.com/systemed/potlatch2/pull/33
https://github.com/systemed/potlatch2/pull/36
https://github.com/systemed/potlatch2/pull/49
https://github.com/systemed/potlatch2/pull/66

Seriously, now. These slow review times, and blocking pull requests
for trivial reasons (I'm not a great fan of the digger, [I] want to
check first whether it can be done without try... catch) are total
motivation killers.


Yeah, I know. Mea culpa. I've been ridiculously busy recently due to, 
basically, changing jobs and another project. I'm hoping to get a chance 
asap.


Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Outstanding pull requests (Attn Richard F)

2012-07-17 Thread Richard Fairhurst

On 17/07/2012 12:30, Steve Bennett wrote:

Could we consider changing the process? Any of these things would help:
1) A dev build where almost all pull requests are accepted, and which
is the accepted starting point for new features. (The production build
is a subset of those branches)
2) More reviewers/people with permission to accept pull requests for
the prod build
3) Lower standard required to accept pull requests.


Very happy with 1 if someone would like to set that up. Very happy with 
more people helping to review the code too.


Also very happy if anyone wants to make the pull requests easier to 
review. So, for example, https://github.com/systemed/potlatch2/pull/66 
completely reindents everything - I can't see what's changed and what 
hasn't. If someone were to resubmit this so that only the changed lines 
are shown, that would be great.


Also, given that you've preached at me several times on this list on the 
best and most friendly way to deal with people, I would perhaps say that 
a personal mail would have been nice before a public calling out. :(


Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Translating Potlatch

2012-06-27 Thread Richard Fairhurst

Aleksi Kinnunen wrote:

But some UI sections are missing, like way and node editing view and
categories. Is it possible to translate them at all, or didn't I
just find them?


It's not yet possible to translate these, I'm afraid. These are from 
config files rather than the app itself, and we don't yet have a method 
to translate those.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Opera 12

2012-06-22 Thread Richard Fairhurst

Ed Loach wrote:

I was using P2 and Opera 12 fine on Windows 7 yesterday. I think C
to close the changeset is the one I use most, and that was working.
I'm not sure whether I used any others in yesterday's session, but
I've just tried clicking Edit, selecting a way and pressing T and
learned a new shortcut key (it worked).


Thanks. Looks like it's Mac-specific, then. I've raised a bug report 
with Opera and have (reluctantly) gone back to Safari!


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] Opera 12

2012-06-21 Thread Richard Fairhurst

Anyone here having keypress problems with P2 and Opera 12?

I can use F1/F2/F3 to switch between backgrounds, but the main keyboard 
stuff (e.g. T for advanced tagging) don't work at all.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Magic Roundabout v2

2012-05-18 Thread Richard Fairhurst
Steve Bennett wrote:
 I didn't get any response to this. Could someone please have a 
 look at this branch? I put quite a lot of work into this, and 
 it's a pretty useful tool - especially since we're about to do 
 a huge amount of remapping in some areas.

I'll take a proper look at the first opportunity. Unfortunately I'm a bit up
to the eyeballs at the moment (basically the free time I have for the next
two weeks is generally not in front of a machine that can run the current
Flash Debug Player), but things get easier come June.

Two thoughts I've had when looking at it so far:

a) I think the newbie-friendly interface would be best served by adding an
extra icon to the toolbox, which is where all the geometry operations live.
The make junctions tool could also get an icon. But before we do that we
really need to add a disclosure triangle below the top row, so that as
standard the toolbox shows the important operations (delete, reverse, cut,
join), and the less mainstream ones can be revealed on demand. Would address
problems with newbies thinking the straighten way icon puts you in some
mythical draw mode!

b) Ideally I'd like to replace the start drawing a way from the centre
node UI with a circle that follows the mouse, exactly like parallelise
does. I'm happy to work on this when I have the time, but if you beat me to
it I won't complain.

cheers
Richard



--
View this message in context: 
http://gis.19327.n5.nabble.com/Potlatch-dev-Magic-Roundabout-v2-tp5574649p5709436.html
Sent from the Potlatch mailing list archive at Nabble.com.

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Brokenness on Mac with Flash 10.1

2012-03-26 Thread Richard Fairhurst
Steve Bennett wrote:
 First, congrats on all the commits coming out of the hack session
 over the weekend! :)

\o/

 OS X, Firefox 11.0, Flash 10,1,102,64 (which I understand to be 
 just barely acceptable). (This isn't the machine I use for 
 development)

Out of interest, Intel or PowerPC?

cheers
Richard



--
View this message in context: 
http://gis.19327.n5.nabble.com/Potlatch-dev-Brokenness-on-Mac-with-Flash-10-1-tp5594109p5594413.html
Sent from the Potlatch mailing list archive at Nabble.com.

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] Weekend summary

2012-03-26 Thread Richard Fairhurst
Andy, Tom and I were holed up in my study this weekend hacking on P2. 
(Pic at http://opengeodata.org/ !)


Quick summary of what was achieved:

- FileBank to allow all images/config files to be stored in a .zip, so 
you can load one assets file per P2 instance rather than 300 or so. 
Should be live on osm.org in the next few days.

- Remove legacy Yahoo code
- Refactor Importer code and allow local files (.gpx, .kml, .osm, 
shapefiles) to be loaded, including zipped

- Cartography improvements
- Move more components to Spark
- P1-style history dialogue
- Rework drag-and-drop UI
- More parameters available for custom installs
- Merged a bunch of Steve's recent work (thanks!)
- Refactor dialogue boxes into dialogs/ directory
- Lots of little bug-fixes and speed improvements

cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Weekend summary

2012-03-26 Thread Richard Fairhurst
Steve wrote:
 - The Show all [v] button is ok, but would IMHO work better
 as a More... sort of icon at the bottom/right of the list rather
 than the top.

That actually had been my initial idea, but on balance (as ever with Flex
;) ) ease of execution trumped it'd be nice! Something we can keep open
for the future. In the meantime I'd like to improve the design of the
disclosure triangles which aren't great.

cheers
Richard




___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] Flash Player minimum version

2012-03-21 Thread Richard Fairhurst
Hi all,

(This is partly a follow-up to Andy's mail of a few weeks ago!)

We had a few reports on help.osm.org of P2 not working (the drag-and-drop
icons on the left weren't appearing) and narrowed it down to the users
still having Flash Player 10.1 installed.

We were only using one 10.2 feature - the native mouse cursors (my
fault!). 10.1 is, however, the last version that'll work on OS X PowerPC.
It's a small number of machines but not an insignificant one. Ok, I might
admit an interest here as my boat Mac is a G5. ;)

I've therefore added a version check to the custom cursor code. If the
user is still on 10.1, it just won't set the cursors. I've tested it with
both 10.1 and 10.3 players and it seems to work fine. Flex 4.5 nominally
requires 10.2 but, for now, seems to degrade to 10.1 fine - the main
change AIUI is tweaks to the text layout engine. It is however possible
that some of the more advanced Spark components may use opcodes not
present in 10.1.

I suggest we stick with 10.1 until there's a compelling must switch
reason to _require_ 11+. If there's any nice-to-haves, like the native
cursor support, we can use the version check.

cheers
Richard




___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OSM-talk] Way with only one single node

2012-03-21 Thread Richard Fairhurst
Andy wrote:
 Anyway, mumble grumble unit testing. When we find out what's the
 trigger, for the love of god someone should help me write the unit
 test so that when it's fixed, it stays fixed.

I've corresponded with Thomas B and found some, ahem, fairly easy steps to
reproduce:

1. Click on map (_once_) to start new way
2. With elastic band still engaged, click 'Save'
3. Whatever the opposite of PROFIT is

Will look at it this weekend I guess.

cheers
Richard




___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Useful command: git branch --merged

2012-03-16 Thread Richard Fairhurst

Steve Bennett wrote:

PS No, this wasn't some passive-aggressive complaint about queued
pull-requests either...:)


;) though for the record, I'm reviewing and integrating them as and when 
time permits. Will probably get a few more through over this coming weekend.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Testing new versions

2012-03-07 Thread Richard Fairhurst

SomeoneElse wrote:

How hard would it be have a version of Potlatch2 available after
merging for final testing before becoming the default P2 version on
the site?


I can see merit in users being able to select an unstable P2 as their 
editor, which would work 99% of the time and be useful for the 
developers the remaining 1%. :) For bonus points it could be built with 
the extra Flash debug flags so we got line numbers when it did break. I 
don't think putting it on a separate site would work - people just 
wouldn't get round to going there. But I don't have the skills to do the 
deployment/Rails stuff to make it happen, so hey.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] State of play

2012-03-04 Thread Richard Fairhurst

Current most obvious bug that I can see is that (in en-GB at least) the
dreaded [object Object] is back on the GPS menu.


Oh, and landuse=cemetery renders as a black opaque area. Appropriate I 
guess but probably not great for editing. :)


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] More UX testing

2012-03-01 Thread Richard Fairhurst

On 01/03/2012 17:41, Andy Allan wrote:

I'm especially coming to the conclusion that defining the icons in
map_features.xml is the wrong place to do it - the icons in the panel
should always match the icons shown in the stylesheet. No idea how to
fix that though :-)


That's pretty easy in theory though I'm not necessarily offering to code 
it this evening!


a) Take the tags defined for this feature in map_features.xml
b) Construct an object with those tags, and run it through RuleSet.getStyles
c) In the resulting StyleList, find a PointStyle, and extract the icon
d) PROFIT etc. etc.

cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [potlatch2] nn, nb, and no translations and tweaks to capitalization of English. (#27)

2012-02-25 Thread Richard Fairhurst

Guttorm Flatabø wrote:

[https://github.com/systemed/potlatch2/pull/27.diff]
Added nn and nb translations (Norwegian nynorsk and bokmål). 'no'
('unspecified Norwegian') is symbolic link to 'nb' as that is the
dominant variety. Also included tweaks to english for consistency
and correctness of capitalization.


Merged - thank you!

cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Designation tag on most map features

2012-02-21 Thread Richard Fairhurst
Steve Bennett wrote:
 There are pretty easy change requests that have been 
 sitting on the wiki for a year or more, presumably because 
 Git is too big a hurdle for casual (non-programmer)
 contributors.

 Is this more complicated than I'm thinking?

Two separate issues really.

Firstly, we need the ability to load alternative map_features files. The
reason that isn't implemented right now is because no-one has coded it. ;)
It also makes a lot of sense to introduce this at the same time that we
introduce the ability to load files from local disc.

Secondly, the best way of getting the pretty easy change requests fixed
would be to identify someone to curate the default P2 map_features.xml. At
present it's largely done by Andy and me when we get a spare minute, but we
do of course have the rest of P2 to look after! On occasion I try and devote
a whole day to fixing the accumulation of little P2 issues - the last time
was in October, I think - and often this sort of thing gets tackled then. To
find someone with an editorial eye to sensibly curate the tags on a
ongoing basis would be good, but I'm not pretending that person would be
easy to find.

cheers
Richard



--
View this message in context: 
http://gis.19327.n5.nabble.com/Potlatch-dev-Designation-tag-on-most-map-features-tp5496468p5501873.html
Sent from the Potlatch mailing list archive at Nabble.com.

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Designation tag on most map features

2012-02-19 Thread Richard Fairhurst

Steve Bennett wrote:

Obviously 2) is easy to fix. But what about 1? Is it time we
implemented locale-specific map_features? IMHO it's incorrect to
display a region-specific tag like this to everyone in this way.


designation= is not region-specific nor country-specific. It is a way of 
recording the formal official status of any object.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Designation tag on most map features

2012-02-19 Thread Richard Fairhurst

Steve Bennett wrote:

Looking at the voting page (huge string of oppose votes) and the
discussion on the Tagging list (3-4 March 2011), it looks like there
are some pretty serious issues with it.


s/pretty serious issues with it/idiots on the wiki/

From the P2 wiki docs:


The UI of the openstreetmap.org instance is rigorously edited by the
developers to avoid bloat and cruft, and the subset of tags presented
is part of this. Decisions will be made on existing usage, on
fulfilling a need, and on quality.


And from the Proposed Features wiki page:


Please note: The approval, or otherwise, of a proposal means simply
that it is documented on this wiki as such. It does not have any
implications for those tools which use and generate OSM data, such
as the Mapnik and Osmarender renderings or editor presets (for
example, Potlatch presets are expressly chosen without reference to
vote results).


In other words, wikifiddling is not an important criterion in whether a 
tag is included. My decision as P2 maintainer is that designation= is an 
appropriate tag in this place, that's why I put it there and that's why 
it will remain there.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Internationalisation

2012-02-19 Thread Richard Fairhurst

Steve Bennett wrote:
 e) I don't know if i18n used to work on my Mac, but it's not working
 now? I get 3 copies of [object object] in the GPS drop down list. From
 trial and error, the middle one is the right one :)

This is happening to me now too (on the Mac, in both Safari and P2). Bit 
bemused as to why - nothing has changed in the P2 code that should cause 
it AFAIAA. Will look it into it, though probably not until next week as 
I'm on deadline with the day job.


cheers
Richard



___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Designation tag on most map features

2012-02-19 Thread Richard Fairhurst

Steve Bennett wrote:

Ok, so I can try and understand you, can you define this
wikifiddling you're so opposed to? I find your attitude utterly
baffling.


Life is mercifully too short to rehash the same old argument that's been 
had for the past five years of OSM all over again, but suffice it to say 
that for a very large number of OSM contributors, wiki tag voting is at 
best irrelevant and at worst actively harmful.


http://lists.openstreetmap.org/pipermail/talk/2009-January/033524.html - 
yes, from three years ago - pretty much sums up my thoughts on the 
issue. Since then the OSM knowledge referred to in that posting has 
been diluted still further, sadly.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Designation tag on most map features

2012-02-19 Thread Richard Fairhurst

On 19/02/2012 14:46, Eugene Alvin Villar wrote:

In my country, we haven't decided on how to properly use the
designation=* tag but these tags appear because of new users using
Potlatch 2. Many of the values used are wrong such as names (e.g.,
designation=Masantol River).


In which case we may need some better explanatory text (OSM 
documentation sucks, film at 11 ;) ) - do feel free to open a trac 
ticket as a reminder, and I'll do it when I have a spare moment.


cheers
Richard



___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] Mapzen EOLed

2012-02-05 Thread Richard Fairhurst

Hello all,

I note that CloudMade have EOLed their AS3 OSM editor Mapzen, under a 
permissive licence:


http://shtosm.ru/2012/02/05/1/

http://mapzen_sources.sandbox.cloudmade.com/mapzen/sandbox/flex_src/mapzen-license.txt

That potentially opens up avenues for some of it to be used in P2. I 
suspect the main things we might want to consider are the icons and the 
turn-restriction editor.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] external mapcss stylesheets and potlatch2

2012-01-06 Thread Richard Fairhurst

Cobra wrote:

Is there any other way than this one?
- click the map style button, select edit
- click add, name=Power, URL=http://dl.dropbox.com/u/31535737/Power.mapcss
- close the style popup


Ah, right. No, that won't work.

Flash Player only allows Flash apps (such as P2) to load data from 
domains that have a permissions file, called crossdomain.xml. This 
permissions file needs to be saved at the root of the domain.


I was going to say ...and of course dl.dropbox.com doesn't have one. 
Actually it does, but it only allows Flash apps residing on dropbox.com 
to use it.


So you need to either:
	a) host the file somewhere where there's a more permissive 
crossdomain.xml file

b) or wait for us to implement loading from local disk in P2 :)

If you want to do (a), then I usually recommend that people just copy 
the file from http://api.flickr.com/crossdomain.xml and put it at 
http://www.yourdomain.com/crossdomain.xml .


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] external mapcss stylesheets and potlatch2

2012-01-06 Thread Richard Fairhurst

On 06/01/2012 11:33, Cobra wrote:

On 2012-01-06 11:59, Richard Fairhurst wrote:

Flash Player only allows Flash apps (such as P2) to load data from
domains that have a permissions file, called crossdomain.xml. This
permissions file needs to be saved at the root of the domain.


random rant, including the words flash and retarded


Yup. crossdomain.xml is horrid. To be fair, Flash Player supported this 
way before browser writers started allowing it for JS via 
Access-Control-Allow-Origin, and even then that requires sending 
additional response headers which (for most people) is harder than just 
uploading a file somewhere.



Are there any plans for for combining several styles besides merging
them locally into one file?


You can use @import directives:
@import(stylesheets/core_ways.css);

cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] external mapcss stylesheets and potlatch2

2012-01-05 Thread Richard Fairhurst

On 05/01/2012 23:02, Cobra wrote:

I'm developing a stylesheet to get a more detailed view of power=*
objects and wanted to test it with potlatch, but couldn't get it to
work. After adding it to p2 and switching to it, all objects the cursors
touches disappear, including the power features. When starting potlatch
with this style activated no data shows up. In josm it works just fine.


That's weird. It looks fine to me:
http://imgur.com/9GEEC

Could you explain how you're adding the stylesheet to P2?

cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] map_features.xml annoyances

2011-12-14 Thread Richard Fairhurst
Eric Wolf wrote:
 1. Why is the xml tag category reused to specify a tab name in input?
 Why not just call it tabname? It's really confusing to someone just
 hacking the XML - does this category have anything to do with the
 Feature Categories?

Yes, this is a flaw and something we should fix at some point. However
tabname would be the wrong name for it: map_features.xml should be
presentation-independent, rather than dictating what UI element (e.g.
tabs) the client app uses.

 3. Can I override or rename the Basic tab without modifying the
 Potlatch2 code?

Not at present. Customising the tab arrangement and images is a
medium-term todo but not trivial.

 4. Is there another way to disable the display of OpenStreetBugs other
 than removing the styles/bugs.css file?

You can just remove it from vectors.xml.

cheers
Richard




___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] Internationalisation

2011-11-28 Thread Richard Fairhurst
Andy did a whole bunch of work on this at the London Hack Weekend, 
building on the great stuff done by miurahr et al, and it's now live 
thanks to Tom.


So... hopefully you won't be getting [Object object] any more. If you 
do: speak out!


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Why can't i zoom out over lvl 13

2011-11-03 Thread Richard Fairhurst
Alexandru wrote:
 I have a private osm server with tiles being server from the official osm
 server. In my potlatch tab i can't zoom out more than lvl 13. Why is it
 so?

Because in most of the world on an OSM dataset, zooming out beyond 13
would request so much data that it would boggle Potlatch and the server
simultaneously. Also, any edits done at z12 are bound to be pretty
imprecise and we don't want to encourage that.

If you want to change this, you can edit MINSCALE in Map.as and compile
your own Potlatch.

cheers
Richard




___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Potlatch 2.3

2011-10-16 Thread Richard Fairhurst

NopMap wrote:

How would I go about updating a custom instance to P2.3?
Wiki instructions and random.dev appear to be outdated.


I guess we need to resuscitate an easily downloadable instance somewhere 
- thank you for the pointer.


Until then... you can download the .swf from 
http://www.openstreetmap.org/potlatch2/potlatch2.swf , as ever.


The config files have also changed a little (particularly 
map_features.xml). If you use Safari's Activity Viewer or the equivalent 
in Firefox you can copy the ones being used live on osm.org. Otherwise, 
you can download them from my github account:

git clone g...@github.com:systemed/potlatch2.git
and everything's in the resources/ directory.

cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Git starter?

2011-09-04 Thread Richard Fairhurst
Steve Bennett wrote:
 Ok, so Richard runs the debug repository, Tom runs the production 
 repository.

I think strictly speaking it's more that I run the P2 project repository,
Tom runs the OSM instance of P2 repository. For whatever it's worth.

cheers
Richard



--
View this message in context: 
http://gis.638310.n2.nabble.com/Potlatch-dev-Git-starter-tp6741077p6758654.html
Sent from the Potlatch mailing list archive at Nabble.com.

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Potlatch Installation question

2011-06-23 Thread Richard Fairhurst
Jeff Haack wrote:
 Hi, I'm trying to set up an instance of Potlatch2, which all seems to be
 working fine, except that it doesn't seem to be pulling the OSM data
 from the database.  Can see it here:
 http://203.77.224.75/potlatch2/potlatch2.html

(Of course, it won't do anything right now because the API is down, but it
should have been working at the time you posted!)

crossdomain.xml is meant for the remote server. You don't need to put one
in your local directory. OSM has one so no worries there.

Very definitely worth installing the Flash Debug Player. This will pop up
an alert if there's anything wrong with the security settings. Also worth
using something like Safari's Activity Monitor to see what files are
actually being loaded.

Flash Player (IMX anyway) won't let you access a remote server if your SWF
is hosted locally, or localhost if your SWF is hosted remotely. So I find
that I can't get data from osm.org if I call up my local instance at
http://localhost/~richard/potlatch2, but I _can_ if I access it at
http://127.0.0.1/~richard/potlatch2.

cheers
Richard




___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #3836: potlatch2.2 locks up, unable to save edited data

2011-06-22 Thread Richard Fairhurst
Andy Allan wrote:
 I'm not a huge fan of shortcut-only features, but I haven't got 
 around to adding gui controls for everything yet.

And I know you're not a great fan of the PopUpMenuButton used for the GPS
tracks drop-down, which would seem the obvious way to add extra
paraphernalia around the Save button. :)

FWIW I think P2 does exactly as much as it needs to in the area of
changesets. Adding extra functionality in this area complicates the UI for
100% of users, to improve functionality for 1% of users. So I'm happy with
'close changeset' being shortcut-only: if you're an advanced enough user to
want to close changesets, you're capable of reading the docs.

cheers
Richard



--
View this message in context: 
http://gis.638310.n2.nabble.com/Potlatch-dev-OpenStreetMap-3836-potlatch2-2-locks-up-unable-to-save-edited-data-tp6491999p6503577.html
Sent from the Potlatch mailing list archive at Nabble.com.

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] Potlatch 2 stylesheet changes

2011-06-12 Thread Richard Fairhurst

Hi all,

The next version of Potlatch 2 will have a couple of major changes to 
the MapCSS parser that you need to know about if you're writing custom 
stylesheets. These are to bring it in line with other software that 
understands MapCSS.


The changes are:

1. casing-width is now relative to the stroke width.
OLD: { width: 5; casing-width; 7; }
NEW: { width: 5; casing-width: 1; }

2. Separate strokes for the same way (or whatever) should now be given 
distinct 'subpart' names, rather than relying on z-index to separate 
them. Subparts are defined by appending '::name' to the selector.

OLD:
way[highway=primary] { color: red; width: 5; z-index: 2}
relation[type=route] way { color: blue; width: 7; z-index: 1}
NEW:
way[highway=primary] { color: red; width: 5; z-index: 2}
		relation[type=route] way::routehighlight { color: blue; width: 7; 
z-index: 1}


The code for this is in my refactor branch on github 
(https://github.com/systemed/potlatch2/tree/refactor) should you want to 
try it out. Before it goes live I'll make the changes to the bundled 
styles; the Potlatch style is already mostly adapted.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] potlatch creates invalid ways having only one node or multiple consecutive identical nodes

2011-06-10 Thread Richard Fairhurst

Steve Doerr wrote:

See http://trac.openstreetmap.org/ticket/2501.

This was reported 18 months ago and still appears to be 'new'.
Presumably the first step is normally that a developer would 'accept'
it?


For the record: no, it isn't. I can't speak for anyone else but I don't 
typically accept tickets in trac. If you accept it then all that happens 
is the owner changes away from potlatch-dev@, therefore updates no 
longer go to this list. Not useful.


I'll have a look at it, but I would say xybot isn't exactly doing itself 
any favours (quelle surprise) by encouraging people to put Potlatch 2 
bug reports under a Potlatch 1 ticket. Again, I can't speak for anyone 
else but I don't look at P1 tickets any more.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Am I just stupid or is this a bug?

2011-06-08 Thread Richard Fairhurst
Eric Wolf ebw...@gmail.com wrote:

 Thanks for looking, Richard... While I have your attention. I want to be able 
 to disable creating and editing ways entirely. What would you recommend as 
 the easiest way to go about that?

Basically you'll need to stop P2 going into any of the ControllerStates that 
deal with ways (e.g. SelectedWay, DrawWay). Easiest way is probably to find the 
bit of EditController that switches from one state to another, and simply don't 
switch if the new ControllerState is one you don't want.

cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Am I just stupid or is this a bug?

2011-06-07 Thread Richard Fairhurst
Eric Wolf wrote:
 You can test it yourself here:
 http://navigator.er.usgs.gov/p2test/potlatch2.html

Difficult to tell without seeing the changes you've made to the source,
but it's throwing an error in potlatch2.mxml, line 437. Possibly you've
changed event.dragSource.dataForFormat('container') to something that
doesn't have a selectedItem property?

Really really strongly recommend installing the debug player in your
browser. The plus side is that you get to see how badly written a lot of
SWFs out there are. :)

cheers
Richard




___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #3671: Tag auto-completion is a bit random

2011-05-27 Thread Richard Fairhurst

SomeoneElse wrote:

Presumably a number of commits get bundled together before it goes live
on osm.org? I'm not seeing the change on the osm.org instance of
potlatch2 yet?


Yep - the process is:

a) Andy pushes the patch to his repository on github
b) I pull it into mine and review it (which takes 0.0005ms to check that 
it's a good patch, and about 30 minutes to remember how to do this in git)
c) I push it to my potlatch2 repository on github (the Potlatch 2 
master) and alert Tom

d) Tom checks I haven't done anything evil and deploys it on osm.org

All these stages are manual.

cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] Potlatch 2.1 and 2.x...

2011-05-21 Thread Richard Fairhurst
2.1 is now live. It includes Ant's recent changes (thanks!) and a bunch 
of other stuff. In brief:


- New Nominatim-powered Search box (click the magnifying glass icon)
- Yahoo component isn't loaded until you actually select Yahoo imagery
- Delete relation option (in the Relations actions menu in the 
Advanced tag display)

- Load relation by ID
- New quadrilateral drawing tool: select a POI (one corner), shift-click 
a blank area of the map (opposite corner), drag mouse up and down 
(choose angle). Intended as a quick way to turn POIs into building areas

- And a bunch of small improvements

For those of you tracking the code: I've also started work on a new 
branch ('refactor' at https://github.com/systemed/potlatch2) to form the 
basis of a future version. This includes a huge bunch of under-the-hood 
changes with two aims:


- Allow multiple Maps to be displayed in one P2 instance
- Bring VectorLayers and Connections together in the Connection classes

The code is in a very half-baked stage so far after just a day's coding, 
though it is at least loading the map again. You can see more of the 
progress in the REFACTOR.txt file 
(https://github.com/systemed/potlatch2/blob/refactor/REFACTOR.txt).


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] Reducing the amount of data P2 requests

2011-05-18 Thread Richard Fairhurst
I'd like to pick the brains of those of you who are better at maths, 
geometry etc. than I am (probably all of you).


At present, P2 sends a /map request to the server every time it needs 
data for the current viewport. It does cache data (subject to not 
boggling Flash Player by keeping too much around), so if you return to a 
previously loaded area, it won't issue a /map call again.


But if the user is in a densely mapped area, and pans (say) a couple of 
hundred metres northwest into an area not currently loaded, P2 will 
issue a /map call for the new viewport.


It would be much better if it issued two smaller /map calls: one for the 
northern edge, one for the western edge. That way, the 90% of data 
already in memory wouldn't be rerequested.


I'd love to code this but figuring out the maths is beyond me. So can 
anyone supply pseudo-code[1] that:


- given a - an array of already loaded bboxes (each one being left, 
right, top, bottom)

- given b - the bbox we now want to load
- given n - a maximum number of /map calls to make (e.g. 3)
- returns c - an array of no more than n bboxes, covering the areas 
within b which are not in a?


cheers
Richard

[1] real code even better ;)


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #3587: Tag keys/values should be restricted to 255 characters

2011-03-24 Thread Richard Fairhurst
Andy Allan wrote:
 Well, I don't have steps to reproduce

I think I'm starting to. This is _really_ weird.

Obviously this isn't the only way to trigger it, but try this:

1. Open a Potlatch 2 instance. Select a way. Select 'Advanced'. Delete some
tags with the 'X' button.
2. In another tab - yes, really - open a page with another Flex SWF. I've
found
http://www.trynull.com/2010/02/11/programatically-select-a-datagrid-cell-in-flex/
works.
3. Go back to the P2 tab. Start selecting ways. It's stuck.

The reason it's stuck is that (in TagGrid.mxml), somehow editedItemPosition
has gained a value, despite no cell being edited. I put a
trace(outerDocument.editedItemPosition) into line 53 of TagGrid.mxml. In
normal operation, clicking 'X' would result in null in the Flash log; when
it's stuck, it results in [Object object].

You can unstick it, very simply, by selecting a cell for editing. That sets
editedItemPosition again properly and all is well with the world.

So we're triggering a Flex bug of some sort. It may, perhaps, have something
to do with bEditedItemPositionChanged not being set to true somewhere in
DataGrid.as. I wonder if there's any event on DataGrid that we can listen
for and then nullify editedItemPosition manually when it fires...

cheers
Richard



--
View this message in context: 
http://gis.638310.n2.nabble.com/Potlatch-dev-OpenStreetMap-3587-potlatch2-advanced-tab-crash-tp6172959p6203607.html
Sent from the Potlatch mailing list archive at Nabble.com.

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Crash with custom vector.xml

2011-03-24 Thread Richard Fairhurst
NopMap wrote:
 It used to work with the style sheet simply in the same directory as p2.

Indeed; we moved it because the p2 directory was getting horribly busy and
disorganised.

 Does it need all stylesheets in a subdir? The main stylesheet is still
 working from the main dir.

If you expressly specify a stylesheet URL, it can be anywhere, of course.
But the hardcoded default stylesheets all now point to stylesheets/
(principally stylesheets/potlatch.css and stylesheets/gpx.css).

 Is there any way to find out about such changes in the structure before P2
 crashes?

P2 is advancing at quite a pace but right now we simply don't have enough
developers to write extensive documentation for every change. We don't
even have complete asdocs for the full code yet.

Things like this will stabilise over time, and indeed are doing so, but
the best advice for now is to watch the changelog and the relevant wiki
pages, and above all, ask here if you're not sure.

cheers
Richard




___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Bug: Selection broken after save

2011-03-13 Thread Richard Fairhurst

On 13/03/2011 08:14, NopMap wrote:

So the information on
http://wiki.openstreetmap.org/wiki/Potlatch_2/Deploying_Potlatch_2
is totally obsolete?


Not _totally_ obsolete. It's just that the instance at 
random.dev.openstreetmap.org is currently not being updated. I'm sure it 
will be again in a day or two, but until Dave fixes it, you can pull 
down the latest SWF from 
http://www.openstreetmap.org/potlatch2/potlatch2.swf if you need it.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Bug: Selection broken after save

2011-03-05 Thread Richard Fairhurst

NopMap wrote:

I observe the following behaviour both with earlier versions of P2 and the
current build 25522. It works nicely until I save data for the first time.
Once the confirmation popup all data saved appears, P2 is broken. The
popup does not disappear by itself and it is impossible to select any item
on the map. The highlighting still works, but selection is impossible.
Dragging the map moves only the background imagery but not the data.

I get this every time.


I think that's a sufficiently huge bug that we'd have noticed if it were 
the case for everyone. :)


Can you provide steps to reproduce? What's the URL you're invoking P2 
with (lat/long/zoom)? What are you doing? What OS, browser, Flash Player 
version? Do you get any alerts if you run with the debug player 
(http://wiki.openstreetmap.org/wiki/Potlatch_2/Using_Flash_Debug_Player)?


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #3360: Switching backgrounds doesn't respect Dim setting

2011-03-05 Thread Richard Fairhurst

On 05/03/2011 18:17, Ed Loach wrote:

I'm back at my keyboard now. And on the live site I reproduce the problem as 
follows:


I've not had chance to look at this issue itself, but you should test 
against the dev instance if possible 
(http://random.dev.openstreetmap.org/potlatch2/potlatch2.html), not the 
live site. The live site is updated every few weeks. The dev instance is 
updated within 20 minutes of a code change.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] What to code next?

2011-03-03 Thread Richard Fairhurst

Steve Bennett wrote:


  Just wondering if anyone has any cool ideas for features or whatnot,
that they haven't got around to entering as bugs in Trac.


Like I said the other day, stability is definitely the watchword right  
now, so we can get P2 ready to become the default editor. No new  
features until then.


One bug that needs nailing down (and I haven't had time to do so yet)  
is that the advanced tag panel can become stuck. In other words,  
it's possible for a set of tags to stay there, even though you select  
a different entity with a new set of tags. Haven't worked out how to  
reproduce it yet but it's happened to me a couple of times.


There might be minor bits of refactoring to do, too, though I'm wary  
of encouraging this lest it introduce more bugs and therefore put off  
the day when we can make P2 the default. The one that springs to mind  
is unifying the multiple selection code: ControllerStates treat it as  
an untyped array, whereas the tag panel uses an EntityCollection type.  
But that's not urgent and I really don't want to do it yet if it could  
introduce any problems.


cheers
Richard



___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #3558: Potlatch 2 map features selection bug

2011-03-03 Thread Richard Fairhurst

Steve Bennett wrote:


Just checking, did you mean to leave the status open? (Not trying to
be a dick, just checking whether the workflow is different to what I
thought.)


No, I forget exactly what magic incantation it is that parses the text  
and closes the ticket automatically. (Or even if we have it installed.)


cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Introducing Magic Roundabout tool

2011-03-02 Thread Richard Fairhurst

Steve Bennett wrote:


4) I don't really understand what this kind of action is doing in Halcyon.


It's on my todo list to look at that one at some point.

cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Codebase and git

2011-03-01 Thread Richard Fairhurst

Steve Bennett wrote:


Can you elaborate a bit on who we is, in this context? And what kind
of process of review and integration of new features do you envisage?
I guess I'm wondering how long we can expect to wait between
developing a new feature and seeing its deployment.


We're having a London-based hack weekend in a couple of weeks and I  
anticipate we'll move P2 over to git then. As for review process, I'd  
expect a lot of stuff will go in pretty much instantly, but large new  
features can sometimes need a bit more consideration. With complex  
code there's always a balance to be struck between TMTOWTDI and the  
P2 way; UI, too, can benefit from a second pair of eyes.



Also, is there any possibility of hosting a bleeding-edge build,
configured to work on the live OSM db? That way, if we develop a
feature at someone's request, they can immediately get access to it,
rather than having to wait for the next stable build. Something like
http://www.openstreetmap.org/edit?editor=potlatch2-dev;...


Great idea in general - though we don't need to do it on osm.org  
itself (and I'd expect that OSMF would be a little anxious about  
offering testing versions on the main server, though I wouldn't  
second-guess them). If several new features were being developed in  
parallel by different coders, we might also then have the challenge of  
deciding which one to deploy as the bleeding-edge build and it all  
starts again. ;)


You can host an instance of P2 that'll talk to the live database  
anywhere (osm.org has a permissive crossdomain to facilitate this). It  
would be great to encourage this. I think the instructions on the wiki  
are reasonably good.


For a while I was maintaining a bleeding-edge build at geowiki.com. I  
did want to register potlat.ch but unfortunately it's been taken. :(


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] Codebase and git

2011-02-28 Thread Richard Fairhurst
In the near future it looks likely that P2 will become the default 
editor on osm.org.Consequently we need to move from the 'rapid 
development' stage to the 'mature code' stage, and enforce a bit more 
rigour in the codebase - with great power comes great responsibility 
and all that. :)


In particular, two absolute, non-negotiable rules:

1. At any given moment, the main P2 codebase needs to be of a quality 
deployable on osm.org.
2. The main codebase must always compile without errors or warnings 
(using the recommended compiler setup).


Rule 1 means, for example, no '?' icons and no partly-working 
functionality. If an order comes down from on high (OSMF) that P2 needs 
to be able to do this or P2 must stop doing this, we need to be able 
to react instantly, without spending time fixing up half-completed stuff 
or drawing icons until we have a deployable version once again.


In conjunction with this, we will be moving from svn to git (as used for 
the core Rails port). This will allow people to hack on their own 
improvements in parallel until they're ready for integration into the 
main codebase. Andy will be posting a nice git tutorial to the list in 
readiness (he doesn't know this yet ;) ).


To reiterate, this absolutely isn't meant to stop people working on cool 
new things, but rather to make sure that osm.org always has a stable, 
predictable editor. git should facilitate both of these: it's good news 
for all of us.




To pave the way for P2 becoming the main editor, we need to freeze 
functionality for now. There's some cool stuff being committed, but 
right now, anything that is not either (a) fixing an existing P2 issue, 
or (b) bringing P2 up to feature parity with P1 (e.g. i18n and 
history/revert), is not an immediate priority. As it takes up time for 
others to learn and review, and may introduce new issues in itself, it 
could be a distraction from the pressing task - and we really shouldn't 
have to make this choice, which is why we're moving to git.


r25368 should be the base for the functionality freeze. That's certainly 
not to say that we abandon the stuff that's been done since then, but we 
will separate it into the essentials (a and b above) and the 
enhancements (new functionality) as part of the move to git, and then 
move the new functionality into the core code as and when it's ready.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Can P2 handle WMS imagery?

2011-02-27 Thread Richard Fairhurst

NopMap wrote:

The subject says it all.


No, it can't.

cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Suggestion for lifecycle tag - comments?

2011-02-16 Thread Richard Fairhurst

Andy Allan wrote:
 Pretty unnecessary, imo. I think you're misunderstanding the 
 current purpose of the simple tab - providing a simple UI for 
 the majority of the mapping. Proposed buildings is pretty niche, 
 and should be incorporated in a way becoming of its niche-ness.

+1.

(Are we allowed to say aolme too/aol these days in view of our generous
sponsors...?)

Potlatch, 1 or 2, has always been a 90-10 editor. Make the 90% of mapping
easy, and the 10% possible. And of course the 'advanced' view makes anything
possible.

We have the luxury that JOSM exists for those who want to do the hardcore
10%, 5%, often even 0.1%. But we also have the responsibility that, as the
default and OSM-hosted editor, Potlatch needs to be approachable and
understandable.

I'm also a little aware (having optimised the CategorySelector stuff
yesterday) that the tagging code is way complicated as it is and probably
doesn't need any more edge cases lest my head explode. ;)

cheers
Richard


-- 
View this message in context: 
http://gis.638310.n2.nabble.com/Potlatch-dev-Suggestion-for-lifecycle-tag-comments-tp6029585p6031319.html
Sent from the Potlatch mailing list archive at Nabble.com.

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Suggestion for lifecycle tag - comments?

2011-02-16 Thread Richard Fairhurst

Actually, what I forgot to say was...

 Potlatch, 1 or 2, has always been a 90-10 editor. Make the 
 90% of mapping easy, and the 10% possible.

...and with P2, we can now make it both a 90-10 editor and a 99-1 editor.
That's why we have user-selectable stylesheets, and in particular the
'Enhanced' one. That's why I did a bunch of work on enabling XML and CSS
files to have nested includes, so that we can do this without repeating
ourselves. And so on. User-selectable map_features.xml will be the next
step.

cheers
Richard

-- 
View this message in context: 
http://gis.638310.n2.nabble.com/Potlatch-dev-Suggestion-for-lifecycle-tag-comments-tp6029585p6031355.html
Sent from the Potlatch mailing list archive at Nabble.com.

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] What do the new cycleway values mean?

2011-02-03 Thread Richard Fairhurst

Richard Mann wrote:


They almost certainly mean shared with peds and white-paint segregated
from peds (as opposed to track which the Germans think is completely
segregated).


Yep. I'm sure there's room for more help text and little pop-ups  
beside particular settings (and, eventually, for country-specific  
presets, but that's a fair way down the road/cycleway).



I think there should probably be policy, something like the value must
represent ?5% of current uses.


Potlatch is a conscious (collective) act of authorship, not really a  
democracy. You can't design coherent beginner-friendly software, or  
documentation, democratically - as the wiki sadly proves.


One of the JOSM developers the other day described Potlatch  
development as more autocratic than JOSM and that's fair comment. We  
try to preserve the original OSM ethos of hardcore do-ocracy. :)


cheers
Richard



___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Proposed filtered way-drawing mode - thoughts?

2011-01-27 Thread Richard Fairhurst

Steve Bennett wrote:


I hacked up some quick code to see the effect of simply not being able
to make junctions with ways that only have those basic tags. So far,
so good. Question is: what's the best way to let the user control
this?


My (very) strong preference is not to introduce another mode or extra  
configurable options. That way lies JOSM. :)


So I'd suggest:


6) Implement a proper filtering system that both hides the filtered
objects and avoids junctions with them. (Me, I'm not fussed about
seeing the unwanted objects.)


because we already have it: it's simply a custom stylesheet. As long  
as you don't include a !:drawn rule, then the offending items simply  
won't show up. The new @import syntax means there's no need to  
reinvent the wheel for most of it. There's already support for  
assigning keypresses to stylesheets.


We have an awesome stylesheet engine (even if I do say so myself) -  
let's use it.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Proposed filtered way-drawing mode - thoughts?

2011-01-27 Thread Richard Fairhurst
I've reorganised the stylesheets a bit (r25165-25167) to give three main 
drawing styles:


- Potlatch (standard)
- Enhanced (adds access/direction highlighting)
- Network (as Enhanced, but without landuse)

At present Network draws landuse outlines as a thin line, rather than 
turning them off completely. If we want to turn them off I'm sure we can 
adjust the stylesheet (and, if necessary, MapCSS parser) accordingly.


I'm a bit loth for the new version to go live yet, as there appears to 
be a fairly nasty leak somewhere which slows P2 down seriously after a 
few style changes - diagnosis welcome.


cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] CSS @import

2011-01-24 Thread Richard Fairhurst

Hi all,

I've added support for CSS @import rules in stylesheets, so you can 
share common features between them (even nesting them if you like):


@import pois.css;
@import interactive.css;

P2's MapCSS implementation is currently order-sensitive (i.e. some 
stuff, such as :drawn, will behave differently depending where in the 
file you put it) so the @import rules can go anywhere in the stylesheet, 
not just at the start. Internally, P2 sees the @import rule, loads the 
file requested, and pastes it 'in place'.


In particular, it'd be great to use this so we could have two core 
stylesheets: a Standard one and an Enhanced one.


Standard should be fast (i.e. avoid using dashes for cuttings, 
embankments etc.) and simple (don't highlight access restrictions or way 
direction). I'm very aware that P2 performance can be sluggish on some 
systems, particularly Linux, and don't want the bells-and-whistles to be 
displayed as standard.


Enhanced would have all the lovely dashes and access and way direction 
that you like, and would be really useful for the experienced mapper to 
whom these things are crucial.


cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] How about another build?

2010-12-24 Thread Richard Fairhurst

Steve Bennett wrote:

Cool, I see we are out of the anything goes alpha phase then? :)


Definitely... thousands of people are using this to edit the map; we 
have to be careful what we commit!


Have you had any thoughts about supplying icons for the new amenities? I 
don't think we can make something live with rows upon rows of ? ? ? ? ? 
? ? ? ? ?. (Brian's SJJB set is usually the best place to look.)


cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Setting up Adobe Flex project

2010-12-13 Thread Richard Fairhurst

Steve Bennett wrote:

Oh. So what do people use to debug with?


I use Flex Open Source SDK 3.5, the Flash Debug Player, and the TextMate 
text editor for OS X (http://macromates.com/). I'll have the debug 
player's error log constantly open in the extremely unlikely event of 
there ever being a bug. That's pretty much it apart from a 
locally-downloaded copy of the Flex API reference.


cheers
Richard


___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Diff for #3358

2010-12-10 Thread Richard Fairhurst

Hi Christian,


don't know if some of you got a message automatically...
I've uploaded a diff-File for #3358.
See http://trac.openstreetmap.org/ticket/3358 and the comment.


Wow - I've been thinking of multiple tagging as hard thing for the 
future and am delighted to see you've tackled it! Will have a play with 
the diff this afternoon.


cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Strange graphics bug in P2 - seems layer-related

2010-12-07 Thread Richard Fairhurst

Stellan Lagerstrom wrote:

I am beginning to suspect it is brought on by layer2 on a bridge.
I just found that the ramps around SFO produce much the same effect.


It seems to be a weird effect of using Flash's cacheAsBitmap property on 
the way sprites. I've backed out the change for the time being (r24638, 
not deployed yet) and will see if I can work out what's going on. Thanks 
for spotting.


cheers
Richard

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev