Re: [Python-Dev] How is the GitHub workflow working for people?

I personally use a GIT commit hook which runs flake8 against the *modified py files only* and rejects the commit in case of non-compliance: https://github.com/giampaolo/psutil/blob/master/.git-pre-commit ...I install it via make:

Re: [Python-Dev] How is the GitHub workflow working for people?

It's easy to only analyze the files in the diff (these linters don't do cross-file analysis anyways, typically) and it's possible to write a filter that only keeps warnings about lines that are changed, but I don't know of a standard solution for the latter (places where I worked where I've seen

Re: [Python-Dev] How is the GitHub workflow working for people?

Can any of these said linters analyze only the diff in the PR, instead of the entire CPython codebase? Mariatta Wijaya ᐧ ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe:

Re: [Python-Dev] How is the GitHub workflow working for people?

On 24 February 2018 at 16:45, Barry Warsaw wrote: > On Feb 21, 2018, at 19:03, Dan Stromberg wrote: > > > > Is flake8 that much better than pylint, that pylint wouldn't even be > discussed? > > I honestly don’t use pylint all that much these days, but when

Re: [Python-Dev] How is the GitHub workflow working for people?

On Feb 22, 2018, at 09:09, Eric Snow wrote: > > I had exactly that experience on one particularly large Go project (on > GitHub, with slow CI, driven by bots). One thing that’s nice to set up if you can is multiple, parallel, independent CI runs. E.g. if your full

Re: [Python-Dev] How is the GitHub workflow working for people?

> On Feb 22, 2018, at 08:08, Antoine Pitrou wrote: > > That's a fair point I hadn't considered. OTOH the style issues I > usually comment on as a reviewer aren't the kind that would be caught > by an automated style check (I tend to ask for comments or docstrings, > or be

Re: [Python-Dev] How is the GitHub workflow working for people?

On Feb 22, 2018, at 02:12, Antoine Pitrou wrote: > Everytime I contribute to a project which has automatic style checks in > CI, I find myself having to push pointless "cleanup" commits because > the CI is barking at me for some ridiculous reason (such as putting two >

Re: [Python-Dev] How is the GitHub workflow working for people?

On Feb 21, 2018, at 19:03, Dan Stromberg wrote: > > Is flake8 that much better than pylint, that pylint wouldn't even be > discussed? I honestly don’t use pylint all that much these days, but when I was evaluating them years ago, I found pylint to be too noisy about

Re: [Python-Dev] How is the GitHub workflow working for people?

On Fri, Feb 23, 2018 at 08:12:13AM -0500, Wes Turner wrote: > A pre-commit hook with flake8 The problem now is not how to configure git with flake8 (et al) but how to configure flake8 (and other tools) to minimize the noise with the current codebase. Oleg. --

Re: [Python-Dev] How is the GitHub workflow working for people?

On Wednesday, February 21, 2018, Nick Coghlan wrote: > On 22 February 2018 at 08:19, Barry Warsaw wrote: > > As for the bug tracker, I still do like Roundup, and we have a huge > investment in it, not just in resources expended to make it rock, but also >

Re: [Python-Dev] How is the GitHub workflow working for people?

On Friday, February 23, 2018, Nick Coghlan wrote: > On 23 February 2018 at 03:09, Eric Snow > wrote: > > So, coupled with slow CI, linting failures were > > particularly onerous. We all got in the habit of locally running the > > linter

Re: [Python-Dev] How is the GitHub workflow working for people?

On 23 February 2018 at 03:09, Eric Snow wrote: > So, coupled with slow CI, linting failures were > particularly onerous. We all got in the habit of locally running the > linter frequently. IIRC, I even set up VIM to run the linter whenever > I saved. For

Re: [Python-Dev] How is the GitHub workflow working for people?

On Tue, Feb 20, 2018 at 6:50 PM Brett Cannon wrote: > It's been a year and 10 days since we moved to GitHub, so I figured now is > as good a time as any to ask people if they are generally happy with the > workflow and if there is a particular sticking point to please bring it

Re: [Python-Dev] How is the GitHub workflow working for people?

How often do we find ourselves grumbling over .py file style in PRs on github? If the answer to that isn't very often, the rest of my response below seems moot. :) On Wed, Feb 21, 2018 at 7:30 PM Guido van Rossum wrote: > Where I work we have some teams using flake8 and some

Re: [Python-Dev] How is the GitHub workflow working for people?

On Thu, Feb 22, 2018 at 9:30 AM, Paul Moore wrote: > My experience on pip is that automated style review is helpful for > avoiding debates over subjective details. This is the allure of Go's official linting tools. Nobody is happy with *all* the style choices but there

Re: [Python-Dev] How is the GitHub workflow working for people?

On 22 February 2018 at 16:08, Antoine Pitrou wrote: > On Thu, 22 Feb 2018 07:51:17 -0800 > Steve Dower wrote: >> It then becomes grunt work for reviewers, who also have to carefully balance >> encouraging new contributors against preventing the code

Re: [Python-Dev] How is the GitHub workflow working for people?

On Thu, 22 Feb 2018 07:51:17 -0800 Steve Dower wrote: > It then becomes grunt work for reviewers, who also have to carefully balance > encouraging new contributors against preventing the code base from getting > worse. That's a fair point I hadn't considered. OTOH the

Re: [Python-Dev] How is the GitHub workflow working for people?

firmly in core-workflow territory now.) Top-posted from my Windows phone From: Ethan Furman Sent: Thursday, February 22, 2018 7:39 To: python-dev@python.org Subject: Re: [Python-Dev] How is the GitHub workflow working for people? On 02/22/2018 02:12 AM, Antoine Pitrou wrote: > Overall it ma

Re: [Python-Dev] How is the GitHub workflow working for people?

On 02/22/2018 02:12 AM, Antoine Pitrou wrote: Overall it makes contributing more of a PITA than it needs be. Do automatic style *fixes* if you want, but please don't annoy me with automatic style checks that ask me to do tedious grunt work on my spare time. +1 -- ~Ethan~

Re: [Python-Dev] How is the GitHub workflow working for people?

On Wed, 21 Feb 2018 14:19:54 -0800 Barry Warsaw wrote: > On Feb 21, 2018, at 13:22, Guido van Rossum wrote: > > > > I'm willing to reconsider if there's a good enough tool. Ditto for C code > > (or do we already do it for C?). > > For Python code, flake8

Re: [Python-Dev] How is the GitHub workflow working for people?

>FWIW I'm personally hugely happy with >the new workflow -- my only regret is >that we're not using GitHub for issue >tracking yet. Btw you can create your own issue labels. some pythonic names can be considered Abdur-Rahmaan Janhangeer https://github.com/Abdur-rahmaanJ On 22 Feb 2018 01:23,

Re: [Python-Dev] How is the GitHub workflow working for people?

On Wed, Feb 21, 2018, at 13:22, Guido van Rossum wrote: > On Wed, Feb 21, 2018 at 9:53 AM, Brett Cannon wrote: > > > > > > > On Wed, 21 Feb 2018 at 09:30 Yury Selivanov > > wrote: > > > >> FWIW I'm extremely happy with the current workflow. The

Re: [Python-Dev] How is the GitHub workflow working for people?

On Wed, Feb 21, 2018 at 10:27 PM, Guido van Rossum wrote: [..] > I honestly expect that running either with close-to-default flags on stdlib > code would be a nightmare, and I wouldn't want *any* directives for either > one to appear in stdlib code, ever. It would be great to

Re: [Python-Dev] How is the GitHub workflow working for people?

On 22 February 2018 at 13:27, Guido van Rossum wrote: > What we need now is not more opinions on which formatter or linter is best. > We need someone to actually do some work and estimate how much code would be > changed if we ran e.g. tabnanny.py (or something more advanced!)

Re: [Python-Dev] How is the GitHub workflow working for people?

On 22 February 2018 at 13:03, Dan Stromberg wrote: > On Wed, Feb 21, 2018 at 2:19 PM, Barry Warsaw wrote: >> On Feb 21, 2018, at 13:22, Guido van Rossum wrote: >>> >>> I'm willing to reconsider if there's a good enough tool. Ditto for C

Re: [Python-Dev] How is the GitHub workflow working for people?

Where I work we have some teams using flake8 and some teams that use pylint, and while pylint is more thorough, it is also slower and pickier, and the general sense is to strongly prefer flake8. I honestly expect that running either with close-to-default flags on stdlib code would be a nightmare,

Re: [Python-Dev] How is the GitHub workflow working for people?

On 22 February 2018 at 08:19, Barry Warsaw wrote: > As for the bug tracker, I still do like Roundup, and we have a huge > investment in it, not just in resources expended to make it rock, but also in > all the history in it and everything that integrates with it. I wouldn’t

Re: [Python-Dev] How is the GitHub workflow working for people?

> > It's been a year and 10 days since we moved to GitHub, so I figured now is > as good a time as any to ask people if they are generally happy with the > workflow It's been great! Thanks! > Said PEP may also need to mention the possibility of exporting > > the history of GitHub issues, in

Re: [Python-Dev] How is the GitHub workflow working for people?

On Wed, Feb 21, 2018 at 2:19 PM, Barry Warsaw wrote: > On Feb 21, 2018, at 13:22, Guido van Rossum wrote: >> >> I'm willing to reconsider if there's a good enough tool. Ditto for C code >> (or do we already do it for C?). > > For Python code, flake8

Re: [Python-Dev] How is the GitHub workflow working for people?

On Wed, 21 Feb 2018 at 14:21 Barry Warsaw wrote: > On Feb 21, 2018, at 13:22, Guido van Rossum wrote: > > > > I'm willing to reconsider if there's a good enough tool. Ditto for C > code (or do we already do it for C?). > > For Python code, flake8 --possibly

Re: [Python-Dev] How is the GitHub workflow working for people?

On 2018-02-21, 21:49 GMT, Chris Angelico wrote: > Said PEP may also need to mention the possibility of exporting > the history of GitHub issues, in case CPython ever migrates away from > GitHub; I remember that concern being raised when the original > migration was discussed. There are tools for

Re: [Python-Dev] How is the GitHub workflow working for people?

On Wed, 21 Feb 2018 01:58:15 + Brett Cannon wrote: > It's been a year and 10 days since we moved to GitHub, so I figured now is > as good a time as any to ask people if they are generally happy with the > workflow and if there is a particular sticking point to please bring

Re: [Python-Dev] How is the GitHub workflow working for people?

On Feb 21, 2018, at 13:22, Guido van Rossum wrote: > > I'm willing to reconsider if there's a good enough tool. Ditto for C code (or > do we already do it for C?). For Python code, flake8 --possibly with our own custom plugins— is the way to go. It would probably take some

Re: [Python-Dev] How is the GitHub workflow working for people?

On Thu, Feb 22, 2018 at 8:38 AM, Guido van Rossum wrote: > On Wed, Feb 21, 2018 at 1:28 PM, Bernát Gábor > wrote: >> >> Any reason in particular for not using github issues (or blockers in >> achieving this)? > > > Many core devs did not want to change

Re: [Python-Dev] How is the GitHub workflow working for people?

On 2/20/2018 8:58 PM, Brett Cannon wrote: It's been a year and 10 days since we moved to GitHub, so I figured now is as good a time as any to ask people if they are generally happy with the workflow ***The nearly automatic backporting!!! A responsible human *should* check backport PRs, as

Re: [Python-Dev] How is the GitHub workflow working for people?

On Wed, Feb 21, 2018 at 1:28 PM, Bernát Gábor wrote: > Any reason in particular for not using github issues (or blockers in > achieving this)? > Many core devs did not want to change their workflow, and Brett did not want to have to handle two migrations at once. When a

Re: [Python-Dev] How is the GitHub workflow working for people?

> I'm personally hugely happy with the new workflow -- my only regret is that we're not using GitHub for issue tracking yet. I have the same feelings. I like the GitHub issue tracker, and it would be great to migrate there (if possible). -- Ivan On 21 February 2018 at 21:22, Guido van Rossum

Re: [Python-Dev] How is the GitHub workflow working for people?

Any reason in particular for not using github issues (or blockers in achieving this)? On 21 Feb 2018 21:25, "Guido van Rossum" wrote: > On Wed, Feb 21, 2018 at 9:53 AM, Brett Cannon wrote: > >> >> >> On Wed, 21 Feb 2018 at 09:30 Yury Selivanov

Re: [Python-Dev] How is the GitHub workflow working for people?

On Wed, Feb 21, 2018 at 9:53 AM, Brett Cannon wrote: > > > On Wed, 21 Feb 2018 at 09:30 Yury Selivanov > wrote: > >> FWIW I'm extremely happy with the current workflow. The recent >> improvements to @miss-islington (kudos to Mariatta!) allowing her to

Re: [Python-Dev] How is the GitHub workflow working for people?

On Wed, Feb 21, 2018 at 5:53 PM, Brett Cannon wrote: > > > On Wed, 21 Feb 2018 at 09:30 Yury Selivanov > wrote: > >> > > >> Huge thanks to the core-workflow team! >> >> ​Hear, hear! regards Steve​ ___

Re: [Python-Dev] How is the GitHub workflow working for people?

On Wed, 21 Feb 2018 at 09:30 Yury Selivanov wrote: > FWIW I'm extremely happy with the current workflow. The recent > improvements to @miss-islington (kudos to Mariatta!) allowing her to > auto-backport PRs and commit them is a big time saver. > > I can only suggest a

Re: [Python-Dev] How is the GitHub workflow working for people?

FWIW I'm extremely happy with the current workflow. The recent improvements to @miss-islington (kudos to Mariatta!) allowing her to auto-backport PRs and commit them is a big time saver. I can only suggest a couple improvements: 1. Make our bots check the code style—fully enforce PEP 8, lint the

[Python-Dev] How is the GitHub workflow working for people?

It's been a year and 10 days since we moved to GitHub, so I figured now is as good a time as any to ask people if they are generally happy with the workflow and if there is a particular sticking point to please bring it up on the core-workflow mailing list so we can potentially address it.