Re: how does post-review know if files changed?
Yea. I do not know about the web API, I'll have to look into that.
On Jun 9, 2012 2:02 AM, Dado Feigenblatt d...@dado.org wrote:
Hi Ryan, thanks for the reply.
Unfortunately my server doesn't understand that request.
I'm running ReviewBoard 1.6.3.
I see you don't have '/api/' in your URL.
Are you intentionally not using the api, or is this the older method of
interfacing with the server?
I tried the api method
/api/review-requests/{review_**request_id}/diffs/{diff_**revision}/
but it doesn't contain the actual text of diff.
Eventually I got your example to work after I removed '/reviews/' from the
url
http://example.review.com/r/9/**diff/raw/http://example.review.com/r/9/diff/raw/
But that returns a plain unicode string of the diff instead of json or xml.
Definitely better than nothing and I might end up using that, but I just
want to make sure there's no blessed api method for getting the actual
text of the diffs.
Thanks,
Dado
On Fri, 8 Jun 2012 00:47:43 -0700 (PDT), Ryan Raasch
ryan.raa...@gmail.com wrote:
On Friday, June 8, 2012 1:41:32 AM UTC+2, dado wrote: When updating a
review, post-review will tell you if the file changed
since it was last submitted for review.
How does it know that? Does RB save diffs for each request update?
As far as I can tell, it doesn't. Post-review generates a diff based
on the local
changes. It then posts this diff to the server. Which maintains
versions of the diff.
There are not diffs of diffs, only versions.
If so, how can I retrieve them via the web api?
Just use curl or wget with
http://example.review.com/**reviews/r/9/diff/raw/http://example.review.com/reviews/r/9/diff/raw/
Thanks,
Dado
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/**donate/ http://www.reviewboard.org/donate/[1]
Happy user? Let us know at
http://www.reviewboard.org/**users/http://www.reviewboard.org/users/[2]
-~--~~~~--**~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscribe@**googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/**group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en[3]
Links:
--
[1] http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/
[2] http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
[3]
http://groups.google.com/**group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/**donate/ http://www.reviewboard.org/donate/
Happy user? Let us know at
http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
-~--~~~~--**~~--~--~---
To unsubscribe from this group, send email to reviewboard+unsubscribe@**
googlegroups.com reviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/**
group/reviewboard?hl=en http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
RB 1.6.7.1: can't add any repository
I am new to RB, so please bear with me if this is a stupid question. I installed RB 1.6.6 as a PoC a week ago. It ran fine, albeit I never managed to upload a git diff --full-index --- it always complained about the first file in the diff, saying that said file with hash hash couldn't be found in the (github) repository. (The UI had a green check mark next to it, though, so I assume the repository setup was OK.) Anyhow, reading about the github API upgrade this week, I assumed maybe that had something to do with it. So I installed 1.6.7.1 and upgraded the site as per the documentation (rb-site upgrade path). I don't recall fully whether this went smoothly, but ever since, I can't add a repository. I nuked the site, deinstalled 1.6.6, dropped the mysql database, reinstalled 1.6.7 and added the site from scratch. Same thing. I hit add and the request never returns. No response. I bounced apache, mysql and memcached, cleared my browser cache, to no avail. Any idea how I might debug this? RB logging is enabled but the logs are empty. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.6.7.1: can't add any repository
Hi, Do you get any errors at all when trying to add the repository? Is the Review Board server behind a proxy at all? The lack of a response makes me wonder if it can't reach GitHub. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 9, 2012 at 11:33 AM, t...@fictive.com wrote: I am new to RB, so please bear with me if this is a stupid question. I installed RB 1.6.6 as a PoC a week ago. It ran fine, albeit I never managed to upload a git diff --full-index --- it always complained about the first file in the diff, saying that said file with hash hash couldn't be found in the (github) repository. (The UI had a green check mark next to it, though, so I assume the repository setup was OK.) Anyhow, reading about the github API upgrade this week, I assumed maybe that had something to do with it. So I installed 1.6.7.1 and upgraded the site as per the documentation (rb-site upgrade path). I don't recall fully whether this went smoothly, but ever since, I can't add a repository. I nuked the site, deinstalled 1.6.6, dropped the mysql database, reinstalled 1.6.7 and added the site from scratch. Same thing. I hit add and the request never returns. No response. I bounced apache, mysql and memcached, cleared my browser cache, to no avail. Any idea how I might debug this? RB logging is enabled but the logs are empty. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.6.7.1: can't add any repository
Thanks for the quick reply! No errors. I literally click the Add Repository button and nothing happens. This is with zero repositories configured yet, so RB has no knowledge of github yet. No proxy involved either. I ran ngrep on localhost to see whether perhaps it was blocked somehow on MySQL, but no packets showed up -Tobias On Saturday, June 9, 2012 1:51:59 PM UTC-7, Christian Hammond wrote: Hi, Do you get any errors at all when trying to add the repository? Is the Review Board server behind a proxy at all? The lack of a response makes me wonder if it can't reach GitHub. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 9, 2012 at 11:33 AM, wrote: I am new to RB, so please bear with me if this is a stupid question. I installed RB 1.6.6 as a PoC a week ago. It ran fine, albeit I never managed to upload a git diff --full-index --- it always complained about the first file in the diff, saying that said file with hash hash couldn't be found in the (github) repository. (The UI had a green check mark next to it, though, so I assume the repository setup was OK.) Anyhow, reading about the github API upgrade this week, I assumed maybe that had something to do with it. So I installed 1.6.7.1 and upgraded the site as per the documentation (rb-site upgrade path). I don't recall fully whether this went smoothly, but ever since, I can't add a repository. I nuked the site, deinstalled 1.6.6, dropped the mysql database, reinstalled 1.6.7 and added the site from scratch. Same thing. I hit add and the request never returns. No response. I bounced apache, mysql and memcached, cleared my browser cache, to no avail. Any idea how I might debug this? RB logging is enabled but the logs are empty. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.6.7.1: can't add any repository
Update: after having stepped away for a few hours, I was able to add a repository now. Weird. However, now I am stuck at the next problem. I select Github, add account name and password and everything else, then click Save. The page returns with a notification saying The authenticity of the host 'github.com (207.97.227.239)' couldn't be determined. RSA key fingerprint is 16:27:ac:a5:76:28:2d:36:63:1b:56:4d:eb:df:a6:48. Do you trust this host, or do you want to go back and edit the repository information? I click I trust this host, but then the page returns with - This field is required. Account password: I input the password again, and the page returns with above notification. And so on, ad infinitum. What can I do here? Add a known_hosts file to the data/.ssh? Am I doing something wrong? Thanks, -Tobias -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.6.7.1: can't add any repository
This command ssh-keyscan -H github.com data/.ssh/known_hosts chown www-data:www-data fixed the ssh issue. Now the next problem: - A repository was not found at the specified path. Repository type is Git, plan is Private. What needs to go in the Name field? The repository I want to reach is one to which my account has rw access. The git URL is of the standard format g...@github.com:owner/name.git and I can read and edit the repository while logged into my account on github.com. I tried name name.git owner/name owner/name.git g...@github.com:owner/name g...@github.com:owner/name.git none of which works for me. The documentation at http://www.reviewboard.org/docs/manual/1.6/admin/configuration/repositories/ doesn't appear to be up to date with 1.6.7. Help very much appreciated! -Tobias -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.6.7.1: can't add any repository
Update: had to choose Private Organization, then got owner and name fields. Now back to my original problem, before running into the issue of this thread: I can't post a review. I created a diff via git diff --full-index and uploaded it via the web interface, only to get a 500: Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. Well, being the admin myself, I looked in the logs ;) 2012-06-09 17:58:36,046 - ERROR - Internal Server Error: /r/new/ Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/Django-1.3.1-py2.6.egg/django/cor e/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.18-py2.6.egg/djblets/ auth/util.py, line 46, in _checklogin return view_func(request, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/rev iewboard/reviews/views.py, line 253, in new_review_request local_site=local_site) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/reviews/forms.py, line 234, in create attach_to_history=True) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/reviews/forms.py, line 286, in create history) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/diffviewer/forms.py, line 84, in create diff_file, basedir, check_existance=(not parent_diff_file))) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/diffviewer/forms.py, line 170, in _process_files not self.repository.get_file_exists(filename, revision))): File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/scmtools/models.py, line 167, in get_file_exists return hosting_service.get_file_exists(self, path, revision) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/hostingsvcs/github.py, line 189, in get_file_exists url = '%sgit/blobs/%s' % (self._get_repo_api_url(repository), revision) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/hostingsvcs/github.py, line 203, in _get_repo_api_url plan = repository.extra_data['repository_plan'] TypeError: string indices must be integers Any idea what might have gone wrong? The diff looks just fine to me. -Tobias -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Upgraded OS , then ReviewBoard failed upgrade
Hi, I was on RB 1.5.5 , then an upgrade of the Ubuntu OS to 12.04 LTS then broke reviewboard (so it wanted to upgrade) so I ran an upgrade which has not been successful. (Note I believe Python was upgraded from 2.6 to 2.7) It seems to work until you go to the /admin/ areas. Rebuilding directory structure Updating database. This may take a while. Creating tables ... There are unapplied evolutions for sessions. There are unapplied evolutions for accounts. There are unapplied evolutions for changedescs. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... No fixtures found. Evolution could not be simulated, possibly due to raw SQL mutations Error: Error applying evolution: (1061, Duplicate key name 'django_session_c25c2c28') Tried this with the latest version 1.6.7.1 I also get emails with: OperationalError: (1054, Unknown column 'scmtools_repository.extra_data' in 'field list') Any clues as to what to try next.? As I was not expecting an OS upgrade to interfere with reviewboard, there is no pre-upgrade db dump, and a rb-site manage . dbdump now fails with : _mysql_exceptions.OperationalError: (1054, Unknown column 'scmtools_repository.extra_data' in 'field list') Thanks Gav... -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.6.7.1: can't add any repository
Clearly some problems with the new change. I'm looking into each of them. We'll probably put out another release soon. Thanks for reporting them, and sorry, no immediate answers, but I may be able to get you an early build to test with. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 9, 2012 at 6:05 PM, t...@fictive.com wrote: Update: had to choose Private Organization, then got owner and name fields. Now back to my original problem, before running into the issue of this thread: I can't post a review. I created a diff via git diff --full-index and uploaded it via the web interface, only to get a 500: Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. Well, being the admin myself, I looked in the logs ;) 2012-06-09 17:58:36,046 - ERROR - Internal Server Error: /r/new/ Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/Django-1.3.1-py2.6.egg/django/cor e/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.18-py2.6.egg/djblets/ auth/util.py, line 46, in _checklogin return view_func(request, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/rev iewboard/reviews/views.py, line 253, in new_review_request local_site=local_site) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/reviews/forms.py, line 234, in create attach_to_history=True) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/reviews/forms.py, line 286, in create history) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/diffviewer/forms.py, line 84, in create diff_file, basedir, check_existance=(not parent_diff_file))) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/diffviewer/forms.py, line 170, in _process_files not self.repository.get_file_exists(filename, revision))): File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/scmtools/models.py, line 167, in get_file_exists return hosting_service.get_file_exists(self, path, revision) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/hostingsvcs/github.py, line 189, in get_file_exists url = '%sgit/blobs/%s' % (self._get_repo_api_url(repository), revision) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/hostingsvcs/github.py, line 203, in _get_repo_api_url plan = repository.extra_data['repository_plan'] TypeError: string indices must be integers Any idea what might have gone wrong? The diff looks just fine to me. -Tobias -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.6.7.1: can't add any repository
For what it's worth, the lack of a response was probably some networking issue between you and GitHub. (It may have been GitHub's server failing to respond and timing out). I believe the required password issue is something I already have a fix for, so I'll get you a build soon to test that. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 9, 2012 at 7:49 PM, Christian Hammond chip...@chipx86.comwrote: Clearly some problems with the new change. I'm looking into each of them. We'll probably put out another release soon. Thanks for reporting them, and sorry, no immediate answers, but I may be able to get you an early build to test with. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 9, 2012 at 6:05 PM, t...@fictive.com wrote: Update: had to choose Private Organization, then got owner and name fields. Now back to my original problem, before running into the issue of this thread: I can't post a review. I created a diff via git diff --full-index and uploaded it via the web interface, only to get a 500: Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. Well, being the admin myself, I looked in the logs ;) 2012-06-09 17:58:36,046 - ERROR - Internal Server Error: /r/new/ Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/Django-1.3.1-py2.6.egg/django/cor e/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.18-py2.6.egg/djblets/ auth/util.py, line 46, in _checklogin return view_func(request, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/rev iewboard/reviews/views.py, line 253, in new_review_request local_site=local_site) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/reviews/forms.py, line 234, in create attach_to_history=True) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/reviews/forms.py, line 286, in create history) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/diffviewer/forms.py, line 84, in create diff_file, basedir, check_existance=(not parent_diff_file))) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/diffviewer/forms.py, line 170, in _process_files not self.repository.get_file_exists(filename, revision))): File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/scmtools/models.py, line 167, in get_file_exists return hosting_service.get_file_exists(self, path, revision) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/hostingsvcs/github.py, line 189, in get_file_exists url = '%sgit/blobs/%s' % (self._get_repo_api_url(repository), revision) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/hostingsvcs/github.py, line 203, in _get_repo_api_url plan = repository.extra_data['repository_plan'] TypeError: string indices must be integers Any idea what might have gone wrong? The diff looks just fine to me. -Tobias -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.6.7.1: can't add any repository
I'm realizing this doesn't make any sense at all. It's claiming that repository.extra_data is a string, but it shouldn't be able to be one. How familiar are you with Python? Would you mind trying something for me? Run: $ rb-site manage /path/to/site shell from reviewboard.scmtools.models import Repository repo = Repository.objects.get(name='your repo name') print repo.extra_data print type(repo.extra_data) And paste the whole transcript. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 9, 2012 at 6:05 PM, t...@fictive.com wrote: Update: had to choose Private Organization, then got owner and name fields. Now back to my original problem, before running into the issue of this thread: I can't post a review. I created a diff via git diff --full-index and uploaded it via the web interface, only to get a 500: Something broke! (Error 500) It appears something broke when you tried to go to here. This is either a bug in Review Board or a server configuration error. Please report this to your administrator. Well, being the admin myself, I looked in the logs ;) 2012-06-09 17:58:36,046 - ERROR - Internal Server Error: /r/new/ Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/Django-1.3.1-py2.6.egg/django/cor e/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.18-py2.6.egg/djblets/ auth/util.py, line 46, in _checklogin return view_func(request, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/rev iewboard/reviews/views.py, line 253, in new_review_request local_site=local_site) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/reviews/forms.py, line 234, in create attach_to_history=True) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/reviews/forms.py, line 286, in create history) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/diffviewer/forms.py, line 84, in create diff_file, basedir, check_existance=(not parent_diff_file))) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/diffviewer/forms.py, line 170, in _process_files not self.repository.get_file_exists(filename, revision))): File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/scmtools/models.py, line 167, in get_file_exists return hosting_service.get_file_exists(self, path, revision) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/hostingsvcs/github.py, line 189, in get_file_exists url = '%sgit/blobs/%s' % (self._get_repo_api_url(repository), revision) File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.6.7.1-py2.6.egg/reviewboard/hostingsvcs/github.py, line 203, in _get_repo_api_url plan = repository.extra_data['repository_plan'] TypeError: string indices must be integers Any idea what might have gone wrong? The diff looks just fine to me. -Tobias -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgraded OS , then ReviewBoard failed upgrade
Your upgrade apparently also upgraded to Review Board 1.6.7, which has many significant changes. And that upgrade failed, because of the django_session issue. I've seen that django_session error before. Not sure what the cause is, but basically, that's a database index that was created, and Django is trying to re-create it now. You can try dropping it and see if that helps. You'll need to connect to your MySQL database and do: drop index django_session_c25c2c28 on django_session; Then re-run the rb-site upgrade command on your site. Hopefully this will work. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 9, 2012 at 7:43 PM, Gav... ipv6g...@gmail.com wrote: Hi, I was on RB 1.5.5 , then an upgrade of the Ubuntu OS to 12.04 LTS then broke reviewboard (so it wanted to upgrade) so I ran an upgrade which has not been successful. (Note I believe Python was upgraded from 2.6 to 2.7) It seems to work until you go to the /admin/ areas. Rebuilding directory structure Updating database. This may take a while. Creating tables ... There are unapplied evolutions for sessions. There are unapplied evolutions for accounts. There are unapplied evolutions for changedescs. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... No fixtures found. Evolution could not be simulated, possibly due to raw SQL mutations Error: Error applying evolution: (1061, Duplicate key name 'django_session_c25c2c28') Tried this with the latest version 1.6.7.1 I also get emails with: OperationalError: (1054, Unknown column 'scmtools_repository.extra_data' in 'field list') Any clues as to what to try next.? As I was not expecting an OS upgrade to interfere with reviewboard, there is no pre-upgrade db dump, and a rb-site manage . dbdump now fails with : _mysql_exceptions.OperationalError: (1054, Unknown column 'scmtools_repository.extra_data' in 'field list') Thanks Gav... -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgraded OS , then ReviewBoard failed upgrade
On Sunday, June 10, 2012 1:04:30 PM UTC+9:30, Christian Hammond wrote: Your upgrade apparently also upgraded to Review Board 1.6.7, which has many significant changes. And that upgrade failed, because of the django_session issue. I've seen that django_session error before. Not sure what the cause is, but basically, that's a database index that was created, and Django is trying to re-create it now. You can try dropping it and see if that helps. You'll need to connect to your MySQL database and do: drop index django_session_c25c2c28 on django_session; Then re-run the rb-site upgrade command on your site. Hopefully this will work. Christian Thanks for the reply, done that, now I get: Error: Error applying evolution: (1060, Duplicate column name 'is_private') Drop that too? from where? Thanks Gav... -- On Sat, Jun 9, 2012 at 7:43 PM, Gav... ipv6g...@gmail.com wrote: Hi, I was on RB 1.5.5 , then an upgrade of the Ubuntu OS to 12.04 LTS then broke reviewboard (so it wanted to upgrade) so I ran an upgrade which has not been successful. (Note I believe Python was upgraded from 2.6 to 2.7) It seems to work until you go to the /admin/ areas. Rebuilding directory structure Updating database. This may take a while. Creating tables ... There are unapplied evolutions for sessions. There are unapplied evolutions for accounts. There are unapplied evolutions for changedescs. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... No fixtures found. Evolution could not be simulated, possibly due to raw SQL mutations Error: Error applying evolution: (1061, Duplicate key name 'django_session_c25c2c28') Tried this with the latest version 1.6.7.1 I also get emails with: OperationalError: (1054, Unknown column 'scmtools_repository.extra_data' in 'field list') Any clues as to what to try next.? As I was not expecting an OS upgrade to interfere with reviewboard, there is no pre-upgrade db dump, and a rb-site manage . dbdump now fails with : _mysql_exceptions.OperationalError: (1054, Unknown column 'scmtools_repository.extra_data' in 'field list') Thanks Gav... -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgraded OS , then ReviewBoard failed upgrade
No, that should never have been reached. That shows you're in some half-modified database state, which shouldn't have happened, given that database transactions are used during the evolution and the earlier error should have prevented the other modifications. At this point, I really wish you had a database upgrade, because things are kind of messed up. Make one now, just in case. Once you have a full backup (SQL dump is best), try deleting that column. You might get a few more like this. Can you tel me exactly what you did, every step of the way, prior to and after the initial rb-site upgrade? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 9, 2012 at 8:47 PM, Gav... ipv6g...@gmail.com wrote: On Sunday, June 10, 2012 1:04:30 PM UTC+9:30, Christian Hammond wrote: Your upgrade apparently also upgraded to Review Board 1.6.7, which has many significant changes. And that upgrade failed, because of the django_session issue. I've seen that django_session error before. Not sure what the cause is, but basically, that's a database index that was created, and Django is trying to re-create it now. You can try dropping it and see if that helps. You'll need to connect to your MySQL database and do: drop index django_session_c25c2c28 on django_session; Then re-run the rb-site upgrade command on your site. Hopefully this will work. Christian Thanks for the reply, done that, now I get: Error: Error applying evolution: (1060, Duplicate column name 'is_private') Drop that too? from where? Thanks Gav... -- On Sat, Jun 9, 2012 at 7:43 PM, Gav... ipv6g...@gmail.com wrote: Hi, I was on RB 1.5.5 , then an upgrade of the Ubuntu OS to 12.04 LTS then broke reviewboard (so it wanted to upgrade) so I ran an upgrade which has not been successful. (Note I believe Python was upgraded from 2.6 to 2.7) It seems to work until you go to the /admin/ areas. Rebuilding directory structure Updating database. This may take a while. Creating tables ... There are unapplied evolutions for sessions. There are unapplied evolutions for accounts. There are unapplied evolutions for changedescs. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... No fixtures found. Evolution could not be simulated, possibly due to raw SQL mutations Error: Error applying evolution: (1061, Duplicate key name 'django_session_c25c2c28') Tried this with the latest version 1.6.7.1 I also get emails with: OperationalError: (1054, Unknown column 'scmtools_repository.extra_**data' in 'field list') Any clues as to what to try next.? As I was not expecting an OS upgrade to interfere with reviewboard, there is no pre-upgrade db dump, and a rb-site manage . dbdump now fails with : _mysql_exceptions.**OperationalError: (1054, Unknown column 'scmtools_repository.extra_**data' in 'field list') Thanks Gav... -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/**users/http://www.reviewboard.org/users/ -~--~~~~--**~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscribe@** googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/** group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.6.7.1: can't add any repository
I'ts been a couple of years since I wrote Python but I think I can still do
it ;)
Here's the output. Org and repo names changed to myFoo (they happen to be
the same):
print repo.extra_data
{u'bug_tracker_use_hosting': False, u'github_private_org_name': u'myFoo',
u'github_private_org_repo_name': u'myFoo', u'repository_plan':
u'private-org'}
print type(repo.extra_data)
type 'dict'
I'll be happy to help debug.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.6.7.1: can't add any repository
For what it's worth, the lack of a response was probably some networking issue between you and GitHub. (It may have been GitHub's server failing to respond and timing out). I doubt it. Remember, this was a naked install, with zero data. Clicking the Add Repository button on the Dashboard gave me an endless wait, 100% reproducible for about 6-8 hours. All the while I was logged in via ssh, so it's unlikely it was the network... Odd. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RB 1.6.7.1: can't add any repository
It may not be your network, but possibly GitHub's SSH servers were the problem? I've seen that happen before. There's certainly nothing on the RB side that should block that long. Anyway, please let me know if that happens again and we'll poke more at it. I'll have a build for you soon to test with. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 9, 2012 at 9:03 PM, t...@fictive.com wrote: For what it's worth, the lack of a response was probably some networking issue between you and GitHub. (It may have been GitHub's server failing to respond and timing out). I doubt it. Remember, this was a naked install, with zero data. Clicking the Add Repository button on the Dashboard gave me an endless wait, 100% reproducible for about 6-8 hours. All the while I was logged in via ssh, so it's unlikely it was the network... Odd. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
