Re: Reviweing a patch and a directory/working copy

2009-03-28 Thread Prabhu Ramachandran
On 03/29/09 02:56, Christian Hammond wrote: > This isn't really that doable today, and would come with a lot of > problems. Particularly, files are tied to a revision, and as soon as > something in that directory changes, all old diffs will break. Ahh, I didn't think of the older diffs. I was

Re: Bazaar configuration

2009-03-28 Thread Prabhu Ramachandran
Hi Christian, On 03/29/09 02:24, Christian Hammond wrote: > Would you mind sharing your configuration (or at least a representation > of it) and how you manage updates to the repository, etc? Something we > could use as a basis for docs. Sure, it was pretty simple. Here is perhaps a rambling

Re: Slow Performance On Large Diffs -- much better, but still a big issue for us.

2009-03-28 Thread Christian Hammond
I've made some optimizations today that will be going into beta 1. I created a change with some deleted files and put about 15 comment flags on one of the files. I'm sure this isn't anywhere near the amount on your reviews, but it was a good sample to start with. The comment loading code took, on

Re: Install Step to add to the docs

2009-03-28 Thread Max Baker
Done. http://code.google.com/p/reviewboard/issues/detail?id=997 On Mar 27, 4:26 pm, Christian Hammond wrote: > Thanks for pointing this out. What a silly thing to leave out. Would you > mind filing a bug on this for tracking purposes? > > Christian --~--~-~--~~~---

Re: Reviweing a patch and a directory/working copy

2009-03-28 Thread Christian Hammond
This isn't really that doable today, and would come with a lot of problems. Particularly, files are tied to a revision, and as soon as something in that directory changes, all old diffs will break. I'm a little confused about your setup. So you have third party projects (or are they your own?) you

Re: intermittent problems with svn diff viewer

2009-03-28 Thread Christian Hammond
I don't really understand why restarting Apache would make this work either... What I generally recommend is that you provide a read-only HTTP URL for the repository and set this to be your Path in the repository entry, and your standard developer URL to be your Mirror Path. This works around a lo

Re: A reviewboard plugin for Kibot

2009-03-28 Thread Christian Hammond
Hey Brad, This looks like a good candidate for the rbapi work I'd like to do (standard Python API for talking to Review Board servers). Does this script have an official homepage or something? I'm going to be opening up the Third Party section at some point in the next month or two and would like

Re: View Diff Not Working

2009-03-28 Thread Christian Hammond
It's generally best if you can use http for Review Board, otherwise some additional configuration is needed. In this case, you'll hvae to look up how to store an HTTPS certificate for that server and then put it in your Apache user's .subversion/auth. Off-hand, I don't know how to do this, but ther

Re: Bazaar configuration

2009-03-28 Thread Christian Hammond
Hi Prabhu, Would you mind sharing your configuration (or at least a representation of it) and how you manage updates to the repository, etc? Something we could use as a basis for docs. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. -

Re: post-review and Windows users

2009-03-28 Thread Christian Hammond
We would love this too, and we're hoping to get some student proposals from Summer of Code that would begin adding better integration on Windows (namely in IDEs, but some of this would likely require better hooks for post-review in Windows). David Trowbridge and myself (the main developers on the

Re: Bazaar configuration

2009-03-28 Thread Prabhu Ramachandran
On 03/28/09 16:15, Anders Steinlein wrote: >> I don't really know anything about the Bazaar support, having no >> experience with Bazaar. I'd definitely have written up some docs >> about it otherwise, and would like to if someone will explain the >> setup to me. >> >> The people who would k

post-review and Windows users

2009-03-28 Thread David Allouche
Something which appears frequently here is "you should really be using post-review". At the moment, this is a bad answer, because there is no usable Windows GUI that does post-review. First, let me give you some of my background. I am Linux-Emacs-Python-Bazaar kind of programmer. I worked for sev

Re: Bazaar configuration

2009-03-28 Thread Anders Steinlein
On 24. mar. 2009, at 03.01, Christian Hammond wrote: > Hi, > > I don't really know anything about the Bazaar support, having no > experience with Bazaar. I'd definitely have written up some docs > about it otherwise, and would like to if someone will explain the > setup to me. > > The peopl

Re: (djblets.datagrid) Errors on HTML

2009-03-28 Thread Kless
These are the 2 errors that are being showed repeteadly: * Error: there is no attribute "border" (showed in each image) i.e.: * Error: end tag for element "span" which is not open > On 27 mar, 13:26, Kless wrote: > The HTML errors follow there. > > You could install that firefox add-on to

Re: Improvements suggestions

2009-03-28 Thread Christian Hammond
Hi Albert, These are good suggestions, and if you could file feature requests on our bug tracker for these, it will help us to keep track of them. The base diff path is an annoying problem that I'd like to find a good solution to. Documentation is fine, inline help is good, but if we could do som

Re: (djblets.datagrid) Static files

2009-03-28 Thread Christian Hammond
When we first defined our current media structure for Review Board, there wasn't a very solid recommendation, so we made our own. The recommendation outlined there isn't too bad, but most apps that use Django are generally single websites that have very specific needs for their media. In those case

Re: (djblets.datagrid) Static files

2009-03-28 Thread David Trowbridge
I'm not sure how changing the directory structure here would help you, and even if it does, it may hinder someone else. If you have something specific you need to do for your own application, feel free to modify the directory layout for your usage. That's what the MIT license is there for. -Davi

Re: (djblets.datagrid) Static files

2009-03-28 Thread Kless
I mean, that the general (and recommended) structure for projects Django is to put the static files in './static', and for js in './ static/js' http://ericholscher.com/projects/django-conventions/project/ So, if we use too the JQuery JS for our project, we have several files with the same script

Re: (djblets.datagrid) Static files

2009-03-28 Thread Christian Hammond
I'm not sure what you mean. Extensions won't bundle jQuery, they'll use Djblets's version. Or are you talking about something else? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Sat, Mar 28, 2009 at 1:24

Re: (djblets.datagrid) Static files

2009-03-28 Thread Kless
not even for JS? Because many users use JQuery so that we'll the same JS scripts in './static/js/' and './static/djblets/js/'. On 27 mar, 20:20, Christian Hammond wrote: > There are no plans to change this structure. We're keeping it as > appname/filetype. This will be important for extensions