Re: Getting parent diffs working with Mercurial
On Sun, Apr 26, 2009 at 16:26, ccaughie c.caug...@googlemail.com wrote: I just read up some more on how git works and I think I now understand why the existing code works for git but not for Mercurial; git uses individual IDs for every file whereas Mercurial only has revision IDs for commits. So my original patch would fix Mercurial but probably break git. Here's a new patch that fixes Mercurial and shouldn't affect git. Please let me know if this seems like a reasonable approach; if so I'll submit it as a change. Hi Colin and Christian! The patch seems to work well. Christian, can you put this change for the rc2? Another question Christian, why it is not possible to add diff and parent diff directly in request creation? Cheers. -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Review Bord and Perforce integration problem
I am trying to create Review Request for an existing change list and
get the following error:
post-review.py -d 73292
p4 info
repository info: Path: perforce.oberonmedia.local:1666, Base path: None,
Supports changesets: True
Generating diff for changenum 73292
p4 describe -s 73292
Processing edit of //depot/Aviva/Branch2/Doc2.txt
Writing //depot/Aviva/Branch2/Doc2.txt#2 to
c:\docume~1\admini~1\locals~1\temp\1\tmpixyye8
p4 print -q //depot/Aviva/Branch2/Doc2.txt#2
p4 where //depot/Aviva/Branch2/Doc2.txt
diff -urNp c:\docume~1\admini~1\locals~1\temp\1\tmpixyye8
C:/WS/Aviva.Levin_ReviewBoard\depot\Aviva\Branch2\Doc2.txt
Looking for 'review.example.com /' cookie in C:\Documents and
Settings\Administrator\Local Settings\Application
Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for 73292
HTTP POSTing to http://review.example.com/api/json/reviewrequests/new/:
{'repository_path': 'perforce.oberonmedia.local:1666', 'changenum': '73292'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)
System setteings are :
P4PORT=perforce:1666
P4CLIENT=Aviva.Levin_ReviewBoard
P4USER=Aviva.Levin
OS is WIN.
Have anyone some suggestion for resolution of this issue?
Tx,
Aviva
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Review Board 1.0 RC1 released
On Mon, May 4, 2009 at 7:12 AM, Christian Hammond chip...@chipx86.com wrote: Hi everyone, I just put out the 1.0 RC1 release. Actually I've got a problem with current svn trunk. When doing an rb-site upgrade/foo/bar I get: Rebuilding directory structure Updating database Unable to read settings_local.py. Please see http://www.review-board.org/docs/manual/dev/admin/ for help setting up Review Board. Using the -d switch doesn't give anything more.. -- Łukasz Jernaś just ignore the smoke and smile - apc --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board 1.0 RC1 released
Hi, Interesting, we've only seen that in the install case. Go ahead and grab a nightly (see the Update: part of our news post for 1.0 RC1 for instructions). It should be fixed there. We're doing an RC2 soon for this and a couple other bugs. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 8:35 AM, Łukasz Jernaś lukasz.jer...@gmail.comwrote: On Mon, May 4, 2009 at 7:12 AM, Christian Hammond chip...@chipx86.com wrote: Hi everyone, I just put out the 1.0 RC1 release. Actually I've got a problem with current svn trunk. When doing an rb-site upgrade/foo/bar I get: Rebuilding directory structure Updating database Unable to read settings_local.py. Please see http://www.review-board.org/docs/manual/dev/admin/ for help setting up Review Board. Using the -d switch doesn't give anything more.. -- Łukasz Jernaś just ignore the smoke and smile - apc --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board 1.0 RC1 released
For what it's worth, I'm seeing the same behavior when trying to upgrade an existing installation. On May 5, 3:06 pm, Christian Hammond chip...@chipx86.com wrote: Hi Sebastien, Would you mind filing a bug report on this? I'll take care of it before RC2. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, May 5, 2009 at 5:12 AM, Sebastien Douche sdou...@gmail.com wrote: On Tue, May 5, 2009 at 13:12, Vesterbaek vesterb...@gmail.com wrote: Just upgraded. Works great. Thanks for your efforts; keep up the good work! Works great too :). Just a remark: on all review requests screen, the shipit icon seems missing. -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board 1.0 RC1 released
Okay. Is this RC1 or a nightly then? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 1:19 PM, Augie Fackler li...@durin42.com wrote: For what it's worth, I'm seeing the same behavior when trying to upgrade an existing installation. On May 5, 3:06 pm, Christian Hammond chip...@chipx86.com wrote: Hi Sebastien, Would you mind filing a bug report on this? I'll take care of it before RC2. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, May 5, 2009 at 5:12 AM, Sebastien Douche sdou...@gmail.com wrote: On Tue, May 5, 2009 at 13:12, Vesterbaek vesterb...@gmail.com wrote: Just upgraded. Works great. Thanks for your efforts; keep up the good work! Works great too :). Just a remark: on all review requests screen, the shipit icon seems missing. -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board 1.0 RC1 released
Okay, I found the cause and it will be fixed in tonight's nightly. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 1:25 PM, Augie Fackler li...@durin42.com wrote: I tried both RC1 and HEAD of svn. Both gave the same error. On May 5, 2009, at 3:24 PM, Christian Hammond wrote: Okay. Is this RC1 or a nightly then? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 1:19 PM, Augie Fackler li...@durin42.com wrote: For what it's worth, I'm seeing the same behavior when trying to upgrade an existing installation. On May 5, 3:06 pm, Christian Hammond chip...@chipx86.com wrote: Hi Sebastien, Would you mind filing a bug report on this? I'll take care of it before RC2. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, May 5, 2009 at 5:12 AM, Sebastien Douche sdou...@gmail.com wrote: On Tue, May 5, 2009 at 13:12, Vesterbaek vesterb...@gmail.com wrote: Just upgraded. Works great. Thanks for your efforts; keep up the good work! Works great too :). Just a remark: on all review requests screen, the shipit icon seems missing. -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Bord and Perforce integration problem
This is an issue we've run into as well. While I may be incorrect in my
assumption here, since I haven't gotten around to digging deeper,
ReviewBoard compares the server connection's FQDN to the domain name you
specified in the administration settings. Two issues:
1) If you try to provide an alias domain name, it fails.
2) If you try to use a perforce proxy server it will fail because
ReviewBoard tries to reach the original perforce server. This can be an
issue, especially when post-review grabs diffs using the original perforce
server which is across the Atlantic :-(.
While not a showstopper, it's merely an inconvenience. The simple solution
is to grab:
{'repository_path': 'perforce.oberonmedia.local:1666', 'changenum': '73292'}
and add perforce.oberonmedia.local:1666 as one of the servers in
administration.
-Tom
On Tue, May 5, 2009 at 3:09 PM, Christian Hammond chip...@chipx86.comwrote:
You're using a repository that Review Board doesn't know. You'll have to
make sure the Review Board server has an entry for (and can reach)
perforce.oberonmedia.local:1666.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Tue, May 5, 2009 at 6:06 AM, Avivale aviv...@gmail.com wrote:
I am trying to create Review Request for an existing change list and
get the following error:
post-review.py -d 73292
p4 info
repository info: Path: perforce.oberonmedia.local:1666, Base path:
None, Supports changesets: True
Generating diff for changenum 73292
p4 describe -s 73292
Processing edit of //depot/Aviva/Branch2/Doc2.txt
Writing //depot/Aviva/Branch2/Doc2.txt#2 to
c:\docume~1\admini~1\locals~1\temp\1\tmpixyye8
p4 print -q //depot/Aviva/Branch2/Doc2.txt#2
p4 where //depot/Aviva/Branch2/Doc2.txt
diff -urNp c:\docume~1\admini~1\locals~1\temp\1\tmpixyye8
C:/WS/Aviva.Levin_ReviewBoard\depot\Aviva\Branch2\Doc2.txt
Looking for 'review.example.com /' cookie in C:\Documents and
Settings\Administrator\Local Settings\Application
Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for 73292
HTTP POSTing to
http://review.example.com/api/json/reviewrequests/new/:
{'repository_path': 'perforce.oberonmedia.local:1666', 'changenum': '73292'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)
System setteings are :
P4PORT=perforce:1666
P4CLIENT=Aviva.Levin_ReviewBoard
P4USER=Aviva.Levin
OS is WIN.
Have anyone some suggestion for resolution of this issue?
Tx,
Aviva
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Review Board 1.0 RC1 released
That fixed the rb-site problem, but now I get a ProgrammingError when trying to load the dashboard: column reviews_review.timestamp must appear in the GROUP BY clause or be used in an aggregate function On May 5, 2009, at 3:28 PM, Christian Hammond wrote: Okay, I found the cause and it will be fixed in tonight's nightly. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 1:25 PM, Augie Fackler li...@durin42.com wrote: I tried both RC1 and HEAD of svn. Both gave the same error. On May 5, 2009, at 3:24 PM, Christian Hammond wrote: Okay. Is this RC1 or a nightly then? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 1:19 PM, Augie Fackler li...@durin42.com wrote: For what it's worth, I'm seeing the same behavior when trying to upgrade an existing installation. On May 5, 3:06 pm, Christian Hammond chip...@chipx86.com wrote: Hi Sebastien, Would you mind filing a bug report on this? I'll take care of it before RC2. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, May 5, 2009 at 5:12 AM, Sebastien Douche sdou...@gmail.com wrote: On Tue, May 5, 2009 at 13:12, Vesterbaek vesterb...@gmail.com wrote: Just upgraded. Works great. Thanks for your efforts; keep up the good work! Works great too :). Just a remark: on all review requests screen, the shipit icon seems missing. -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board 1.0 RC1 released
Yeah, PostgreSQL, right? Looking into a fix for this. See bug 1099. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 1:31 PM, Augie Fackler li...@durin42.com wrote: That fixed the rb-site problem, but now I get a ProgrammingError when trying to load the dashboard: column reviews_review.timestamp must appear in the GROUP BY clause or be used in an aggregate function On May 5, 2009, at 3:28 PM, Christian Hammond wrote: Okay, I found the cause and it will be fixed in tonight's nightly. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 1:25 PM, Augie Fackler li...@durin42.com wrote: I tried both RC1 and HEAD of svn. Both gave the same error. On May 5, 2009, at 3:24 PM, Christian Hammond wrote: Okay. Is this RC1 or a nightly then? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 1:19 PM, Augie Fackler li...@durin42.com wrote: For what it's worth, I'm seeing the same behavior when trying to upgrade an existing installation. On May 5, 3:06 pm, Christian Hammond chip...@chipx86.com wrote: Hi Sebastien, Would you mind filing a bug report on this? I'll take care of it before RC2. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, May 5, 2009 at 5:12 AM, Sebastien Douche sdou...@gmail.com wrote: On Tue, May 5, 2009 at 13:12, Vesterbaek vesterb...@gmail.com wrote: Just upgraded. Works great. Thanks for your efforts; keep up the good work! Works great too :). Just a remark: on all review requests screen, the shipit icon seems missing. -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Git support
Congrats on the release of 1.0 RC1. I'm taking another swing at getting people here to use Review Board. We're a git shop. Is there a good quick summary of current git support? I saw this: http://groups.google.com/group/reviewboard/browse_thread/thread/fce7abb11375cac7 and http://www.review-board.org/docs/manual/dev/users/tools/post-review/#dvcs but I wasn't sure if there was anything more recent/detailed. I'd be happy to add a FAQ entry once I'm sure I know the answer. :) Thanks. -M --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
RE: Review Bord and Perforce integration problem
For most folks, as long as the address that Review Board is using is the
canonical FQDN (cname, I think it's called) for the Perforce server, everything
should work.
However, there are some situations that are currently broken. We have a couple
perforce servers that have different canonical names depending on which network
you are on, and there's currently no sane way to make post-review work from all
networks since you have to pick one name. This problem has bit us a couple
times and I filed Issue 967
(http://code.google.com/p/reviewboard/issues/detail?id=967) on this a month or
so ago. As I said in the bug, I'd really rather RB/post-review use the raw
Server address: from p4 info as the server's identifier because I think it will
always be the same everywhere. If for whatever reason that address isn't
reachable from wherever the RB server is, the server alias field should let you
pick a different name to reach it.
That said, this shouldn't generally cause a problem with proxy servers.
post-review uses the canonical FQDN to identify the Perforce server to the
Review Board server, but it just issues raw p4 commands for all the Perforce
operations. So if your p4 environment is configured to use a p4proxy, all the
actual p4 operations will go to the proxy.
-- Paul
From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On Behalf Of
Tom Sakkos [nasis...@gmail.com]
Sent: Tuesday, May 05, 2009 1:32 PM
To: reviewboard@googlegroups.com
Subject: Re: Review Bord and Perforce integration problem
This is an issue we've run into as well. While I may be incorrect in my
assumption here, since I haven't gotten around to digging deeper, ReviewBoard
compares the server connection's FQDN to the domain name you specified in the
administration settings. Two issues:
1) If you try to provide an alias domain name, it fails.
2) If you try to use a perforce proxy server it will fail because ReviewBoard
tries to reach the original perforce server. This can be an issue, especially
when post-review grabs diffs using the original perforce server which is across
the Atlantic :-(.
While not a showstopper, it's merely an inconvenience. The simple solution is
to grab:
{'repository_path': 'perforce.oberonmedia.local:1666', 'changenum': '73292'}
and add perforce.oberonmedia.local:1666 as one of the servers in
administration.
-Tom
On Tue, May 5, 2009 at 3:09 PM, Christian Hammond
chip...@chipx86.commailto:chip...@chipx86.com wrote:
You're using a repository that Review Board doesn't know. You'll have to make
sure the Review Board server has an entry for (and can reach)
perforce.oberonmedia.local:1666.
Christian
--
Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Tue, May 5, 2009 at 6:06 AM, Avivale
aviv...@gmail.commailto:aviv...@gmail.com wrote:
I am trying to create Review Request for an existing change list and
get the following error:
post-review.py -d 73292
p4 info
repository info: Path: perforce.oberonmedia.local:1666, Base path: None,
Supports changesets: True
Generating diff for changenum 73292
p4 describe -s 73292
Processing edit of //depot/Aviva/Branch2/Doc2.txt
Writing //depot/Aviva/Branch2/Doc2.txt#2 to
c:\docume~1\admini~1\locals~1\temp\1\tmpixyye8
p4 print -q //depot/Aviva/Branch2/Doc2.txt#2
p4 where //depot/Aviva/Branch2/Doc2.txt
diff -urNp c:\docume~1\admini~1\locals~1\temp\1\tmpixyye8
C:/WS/Aviva.Levin_ReviewBoard\depot\Aviva\Branch2\Doc2.txt
Looking for 'review.example.comhttp://review.example.com /' cookie in
C:\Documents and Settings\Administrator\Local Settings\Application
Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for 73292
HTTP POSTing to http://review.example.com/api/json/reviewrequests/new/:
{'repository_path': 'perforce.oberonmedia.local:1666', 'changenum': '73292'}
Error creating review request: The repository path specified is not in
the list of known repositories (code 206)
System setteings are :
P4PORT=perforce:1666
P4CLIENT=Aviva.Levin_ReviewBoard
P4USER=Aviva.Levin
OS is WIN.
Have anyone some suggestion for resolution of this issue?
Tx,
Aviva
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Git support
Hi Marc, Thanks for the congrats :) Looking forward to getting 1.0 out the door so we can start working on some new cool stuff. The git support hasn't really changed in a while. I personally haven't set up a Review Board server with Git, and I know it's somewhat clunky. My understanding is that you just need a Git repo that's constantly in sync with some master repository, as best you can, and point Review Board to it. Then make use of parent diffs when needed. I really want to improve Git support post-1.0 to make this easier. Basically, allow it to point to an upstream server to sync from and have it maintain its own checkout of only the files needed for reviews when it needs them. I have a strategy for this, but I don't know exactly when I'll be getting to it. I want to make it part of 1.1 though. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 2:03 PM, Marc Hedlund marcprecip...@gmail.comwrote: Congrats on the release of 1.0 RC1. I'm taking another swing at getting people here to use Review Board. We're a git shop. Is there a good quick summary of current git support? I saw this: http://groups.google.com/group/reviewboard/browse_thread/thread/fce7abb11375cac7 and http://www.review-board.org/docs/manual/dev/users/tools/post-review/#dvcs but I wasn't sure if there was anything more recent/detailed. I'd be happy to add a FAQ entry once I'm sure I know the answer. :) Thanks. -M --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Clearcase plugin?
There's some basic ClearCase support today, but I don't know the state of the code or how it's used. Can someone on this list using/developing ClearCase give a brief overview of usage? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Wed, Apr 29, 2009 at 2:46 PM, Brendan Miller catph...@catphive.netwrote: Are there any plans to add clearcase support to review board in the future, or has anyone written some kind of plugin for it? That's the version control my company is stuck with. Thanks, Brendan --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Reviewboard 1.0 Rc1 Xp installation View Diff not working!
Hi ALL: I just installed reviewboard 1.0 RC1 on an XP sp2 machine with Apache + MySQL + Subversion configure.the installation is smooth. and I can upload svn diff files. but when I push the ViewDiff button. I always got this error message: [Error 2] Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 620, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5rc1-py2.5.egg\djblets \util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 619, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 342, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 258, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 107, in patch stderr=subprocess.STDOUT) File C:\Python25\Lib\subprocess.py, line 594, in __init__ errread, errwrite) File C:\Python25\Lib\subprocess.py, line 822, in _execute_child startupinfo) WindowsError: [Error 2] I have searched the group and look at the subprocess.py code. It seems related to the command line invoke of patch.exe. but I have gnu patch in my system path. and i can invoke it from windows command window. so can anyone suggest my further move ? besides the logging seems not working either. I enable logging in the admin panel. but the logs dir have no files. Any feedback is appreciated! thanks for your help. I really really want to use this pretty software in my group. Regards Marshall --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Reviewboard 1.0 Rc1 Xp installation View Diff not working!
Install it on Ubuntu - you will be up and running in minutes. - Just a suggestion. On Tue, May 5, 2009 at 10:22 PM, marshall weixiao...@gmail.com wrote: Hi ALL: I just installed reviewboard 1.0 RC1 on an XP sp2 machine with Apache + MySQL + Subversion configure.the installation is smooth. and I can upload svn diff files. but when I push the ViewDiff button. I always got this error message: [Error 2] Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 620, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5rc1-py2.5.egg\djblets \util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 619, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 342, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 258, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 107, in patch stderr=subprocess.STDOUT) File C:\Python25\Lib\subprocess.py, line 594, in __init__ errread, errwrite) File C:\Python25\Lib\subprocess.py, line 822, in _execute_child startupinfo) WindowsError: [Error 2] I have searched the group and look at the subprocess.py code. It seems related to the command line invoke of patch.exe. but I have gnu patch in my system path. and i can invoke it from windows command window. so can anyone suggest my further move ? besides the logging seems not working either. I enable logging in the admin panel. but the logs dir have no files. Any feedback is appreciated! thanks for your help. I really really want to use this pretty software in my group. Regards Marshall --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Reviewboard 1.0 Rc1 Xp installation View Diff not working!
Is this a fresh install? IIRC, I ran into this issue because I didn't have MinGW (sp?) tools installed. ReviewBoard has a dependency on the GNU utils patch and diff. -Tom On Tue, May 5, 2009 at 9:39 PM, Noam Bunder gen...@gmail.com wrote: Install it on Ubuntu - you will be up and running in minutes. - Just a suggestion. On Tue, May 5, 2009 at 10:22 PM, marshall weixiao...@gmail.com wrote: Hi ALL: I just installed reviewboard 1.0 RC1 on an XP sp2 machine with Apache + MySQL + Subversion configure.the installation is smooth. and I can upload svn diff files. but when I push the ViewDiff button. I always got this error message: [Error 2] Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 620, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5rc1-py2.5.egg\djblets \util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 619, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 342, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 258, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 107, in patch stderr=subprocess.STDOUT) File C:\Python25\Lib\subprocess.py, line 594, in __init__ errread, errwrite) File C:\Python25\Lib\subprocess.py, line 822, in _execute_child startupinfo) WindowsError: [Error 2] I have searched the group and look at the subprocess.py code. It seems related to the command line invoke of patch.exe. but I have gnu patch in my system path. and i can invoke it from windows command window. so can anyone suggest my further move ? besides the logging seems not working either. I enable logging in the admin panel. but the logs dir have no files. Any feedback is appreciated! thanks for your help. I really really want to use this pretty software in my group. Regards Marshall --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ReviewBoard / git problem
On Wednesday 06 May 2009 03:12:58 Christian Hammond wrote:
We probably want to use os.path.pathsep instead of os.environ.get('IFS')
anyway.
Christian, the problem is not with IFS, the problem with PATH and other common
environment variables. Actually os.environ doesn't contain anything useful at
all, so os.environ['PATH'] raises a KeyError. However I do see all relevant
information, including system PATH, in Request META, and git binary is
executed just fine. That's why I said it looks more like security
precautions in [my] Apache, FastCGI or Django setup.
Btw, I get a bounceback every time I e-mail you. Not sure if you're seeing
any of my responses.
Yes, I read your messages without any problems. This is a public mail hub, and
perhaps they have some sort of greylisting or whatever, but I'm not aware of
any lost mail here, so please ignore these bounces.
Yours respectfully,
Alexey
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Reviewboard 1.0 Rc1 Xp installation View Diff not working!
Hi Tom: It is a fresh install. I have UnxUtils in PATH,so diff is also avaiable. On May 6, 11:44 am, Tom Sakkos nasis...@gmail.com wrote: Is this a fresh install? IIRC, I ran into this issue because I didn't have MinGW (sp?) tools installed. ReviewBoard has a dependency on the GNU utils patch and diff. -Tom On Tue, May 5, 2009 at 9:39 PM, Noam Bunder gen...@gmail.com wrote: Install it on Ubuntu - you will be up and running in minutes. - Just a suggestion. On Tue, May 5, 2009 at 10:22 PM, marshall weixiao...@gmail.com wrote: Hi ALL: I just installed reviewboard 1.0 RC1 on an XP sp2 machine with Apache + MySQL + Subversion configure.the installation is smooth. and I can upload svn diff files. but when I push the ViewDiff button. I always got this error message: [Error 2] Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 620, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5rc1-py2.5.egg\djblets \util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 619, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 342, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 258, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 107, in patch stderr=subprocess.STDOUT) File C:\Python25\Lib\subprocess.py, line 594, in __init__ errread, errwrite) File C:\Python25\Lib\subprocess.py, line 822, in _execute_child startupinfo) WindowsError: [Error 2] I have searched the group and look at the subprocess.py code. It seems related to the command line invoke of patch.exe. but I have gnu patch in my system path. and i can invoke it from windows command window. so can anyone suggest my further move ? besides the logging seems not working either. I enable logging in the admin panel. but the logs dir have no files. Any feedback is appreciated! thanks for your help. I really really want to use this pretty software in my group. Regards Marshall --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Git support
On Wednesday 06 May 2009 05:03:17 Marc Hedlund wrote: Cool. Thanks much. If I'm successful in getting people going with this, I'm sure we'd be willing to help adding more support for git. Hi! I'm also interested in a fully functional ReviewBoard / Git interaction. Currently I'm implementing a post-push review strategy when developers push their commits to a central (shared in git terminology) repository and [some of] these commits become available for advisory review. This is being implemented as a post-receive hook which automatically creates a review per commit for all relevant commits. I hope I will have a working setup for it by the end of the day. Our bosses also wish to try a pre-push review strategy similar to one used in Google Android project: a developer makes one or more commits, then send/push them to an intermediate repository/Review Board, then approved commits are automatically pushed to an official repository. However I think there're several issues in this workflow, e.g. related with need of commit rebasing. Maybe it's worth to discuss these raw edges and specify the workflow more precisely. Respectfully, Alexey --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Reviewboard 1.0 Rc1 Xp installation View Diff not working!
Hi Christian: Thanks for quick reply. I think if I can solve the logging problem. I can get more info I need. any idea why enable logging doesn't working ? Since the Windows Error Code 2 is from CreateProcess call. it means The system cannot find the file specified. if i can log the command line reviewboard used .maybe I can figure out why. Regards Marshall On May 6, 11:42 am, Christian Hammond chip...@chipx86.com wrote: It may be in your PATH, but it could be that your server isn't seeing it for some reason. Otherwise, I don't really have much advice off-hand, not having hit this (I do work on Linux primarily), but maybe someone else has hit a case of this failing without it being a PATH issue. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, May 5, 2009 at 7:22 PM, marshall weixiao...@gmail.com wrote: Hi ALL: I just installed reviewboard 1.0 RC1 on an XP sp2 machine with Apache + MySQL + Subversion configure.the installation is smooth. and I can upload svn diff files. but when I push the ViewDiff button. I always got this error message: [Error 2] Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 620, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5rc1-py2.5.egg\djblets \util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 619, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 342, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 258, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 107, in patch stderr=subprocess.STDOUT) File C:\Python25\Lib\subprocess.py, line 594, in __init__ errread, errwrite) File C:\Python25\Lib\subprocess.py, line 822, in _execute_child startupinfo) WindowsError: [Error 2] I have searched the group and look at the subprocess.py code. It seems related to the command line invoke of patch.exe. but I have gnu patch in my system path. and i can invoke it from windows command window. so can anyone suggest my further move ? besides the logging seems not working either. I enable logging in the admin panel. but the logs dir have no files. Any feedback is appreciated! thanks for your help. I really really want to use this pretty software in my group. Regards Marshall --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Reviewboard 1.0 Rc1 Xp installation View Diff not working!
Hi Marshall, Our logging is not very extensive. We wouldn't have any logging in place for this call at all. The information you have is all that's available without modifying code. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, May 5, 2009 at 10:06 PM, marshall weixiao...@gmail.com wrote: Hi Christian: Thanks for quick reply. I think if I can solve the logging problem. I can get more info I need. any idea why enable logging doesn't working ? Since the Windows Error Code 2 is from CreateProcess call. it means The system cannot find the file specified. if i can log the command line reviewboard used .maybe I can figure out why. Regards Marshall On May 6, 11:42 am, Christian Hammond chip...@chipx86.com wrote: It may be in your PATH, but it could be that your server isn't seeing it for some reason. Otherwise, I don't really have much advice off-hand, not having hit this (I do work on Linux primarily), but maybe someone else has hit a case of this failing without it being a PATH issue. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, May 5, 2009 at 7:22 PM, marshall weixiao...@gmail.com wrote: Hi ALL: I just installed reviewboard 1.0 RC1 on an XP sp2 machine with Apache + MySQL + Subversion configure.the installation is smooth. and I can upload svn diff files. but when I push the ViewDiff button. I always got this error message: [Error 2] Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 620, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5rc1-py2.5.egg\djblets \util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 619, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 342, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 258, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0rc1-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 107, in patch stderr=subprocess.STDOUT) File C:\Python25\Lib\subprocess.py, line 594, in __init__ errread, errwrite) File C:\Python25\Lib\subprocess.py, line 822, in _execute_child startupinfo) WindowsError: [Error 2] I have searched the group and look at the subprocess.py code. It seems related to the command line invoke of patch.exe. but I have gnu patch in my system path. and i can invoke it from windows command window. so can anyone suggest my further move ? besides the logging seems not working either. I enable logging in the admin panel. but the logs dir have no files. Any feedback is appreciated! thanks for your help. I really really want to use this pretty software in my group. Regards Marshall --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 1105 in reviewboard: Time shown in dashboard does not match timezone
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1105 by onkarshinde: Time shown in dashboard does not match timezone http://code.google.com/p/reviewboard/issues/detail?id=1105 What version are you running? 1.0 RC1 What's the URL of the page containing the problem? What steps will reproduce the problem? 1. Change the timezone from admin UI. 2. Post a review request (draft, not published) What is the expected output? What do you see instead? The dashboard should show the time the time of creation of request as per the timezone set. What operating system are you using? What browser? The time shown is as per default timezone, US/Pacific I believe. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1099 in reviewboard: ProgrammingError exception after beta2 to beta3 update
Comment #2 on issue 1099 by wwitzel3: ProgrammingError exception after beta2 to beta3 update http://code.google.com/p/reviewboard/issues/detail?id=1099 This is against PostgreSQL 8.3 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1099 in reviewboard: ProgrammingError exception after beta2 to beta3 update
Updates: Status: Confirmed Owner: chipx86 Labels: -Priority-Medium Priority-High Milestone-Release1.0 Component-Dashboard Comment #5 on issue 1099 by chipx86: ProgrammingError exception after beta2 to beta3 update http://code.google.com/p/reviewboard/issues/detail?id=1099 Something about our new queries probably doesn't work with PostgreSQL. I'll look into this. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
