ImproperlyConfigured: Error loading psycopg2 module: DLL load failed. The specified module could not be found

2010-02-05 Thread Shankar Kalel
Hello, I am getting this error ever since I created a new rb site for Postgre DB. I downloaded psycopg2 using easy_install psycopg2 and it created egg file psycopg2-2.0.13-py2.5-win32.egg in my Site-Packages directory. I created new RB site to use Postgre DB and restarted Apache. I started gettin

Re: ImproperlyConfigured: Error loading psycopg2 module: DLL load failed. The specified module could not be found

2010-02-05 Thread Stephen Gallagher
I had this problem when installing on RHEL5. On RHEL5, the pytz package (and several others) did not have egg files. Basically, reviewboard is querying the egg files on your system to see if you have them installed. If you manually install 'pytz', it's safe to remove that line from /usr/lib/python

Re: Multiple diffs per review?

2010-02-05 Thread Matthew Woehlke
On 2010-02-04 18:15, Stodge wrote: On Feb 4, 6:21 pm, Matthew Woehlke wrote: On 2010-02-04 10:13, Stodge wrote: [...] we need to be able to group multiple revisions on one review. Is this possible with RB? You could upload the diff of the first revision, publish it, upload the cumulative diff

Is it possible to specify a change number/revision for an SVN repository when creating a review request via json?

2010-02-05 Thread Stodge
Is it possible to specify a change number/revision for an SVN repository when creating a review request via json? I'm guessing not but I wanted to check. ERROR:root:Exception thrown for user admin at http://localhost:9900/reviews/api/json/reviewrequests/new/ Traceback (most recent call last): F

Re: ReviewBoard Error while posting review for GIT

2010-02-05 Thread Kunjal
It's failing here in git.py in scmtools folder. class GitClient: def __init__(self, path): if not is_exe_in_path('git'): # This is technically not the right kind of error, but it's the # pattern we use with all the other tools. raise ImportError

Re: Restricting access to "Ship It" checkbox

2010-02-05 Thread Jennifer
Thank you for your answer. I would like to respectfully disagree. What is the difference between the "ship it" checkbox and any other field in the review? There are specific permissions from changing the header, changing the diff, the text, etc, I think there is even a permission to say if peop

Using post-review outside of a working copy to upload a diff file

2010-02-05 Thread LukeRobison
First off, I'm using svn on linux. Second, google seems to refuse to let me search this newsgroup (500: server error), so I apologize if this question has been asked before/recently. I'm attempting to use the post-review tool to upload diff files from outside a working copy. I tried to simply u

Re: Using post-review outside of a working copy to upload a diff file

2010-02-05 Thread Christian Hammond
Hi Luke, The --repository-url parameter was implemented for the purpose of post-commit support. It was also before the addition of --diff-filename (a very recent option). I'd be more than happy to have support for --diff-filename with --repository-url. We'll likely need a patch for it, though, as

Re: Is it possible to specify a change number/revision for an SVN repository when creating a review request via json?

2010-02-05 Thread Christian Hammond
Revisions are solely interpreted from the diff. So long as the files in the diff reference the proper revisions, it should work. Changesets are an entirely different thing. They're Perforce-only. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMwa

Re: ReviewBoard Error while posting review for GIT

2010-02-05 Thread Christian Hammond
The nightlies of RBTools should be handling this a lot better. Is that what you're running? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Feb 3, 2010 at 1:28 PM, Kunjal wrote: > One more thing.. > H

Re: ReviewBoard Error while posting review for GIT

2010-02-05 Thread Christian Hammond
I still need to see the repository Path field to be able to say what's going on. Is it a remote path, or a local path on the filesystem? Git can only operate on local paths. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.v

Re: Restricting access to "Ship It" checkbox

2010-02-05 Thread Christian Hammond
Hi Jennifer, The "Ship It" checkbox is part of a review, not a review request, and like all fields in a review, the reviewer has complete control over the contents. When a reviewer marks something as "Ship It," that is his opinion. It's not necessarily approval for the code to be committed. What

Re: RB review Process Automation

2010-02-05 Thread Christian Hammond
Are you storing and sending the cookie? We handle authentication persistence by cookies, so you'd have to do this. If you're writing this in Python, take a look at the CookieJar stuff in post-review. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org V

Re: Git patchsets

2010-02-05 Thread Christian Hammond
Yes, it should work with 1.0.5.x. You should certainly be able to do the multiple patch thing today, though as Dan said, not elegantly. I think down the road we're going to want to look into patchset functionality. Internally, we already have a concept of a revisioned set of diffs (a "DiffSetHisto

Re: Django auth backend vs. ReviewBoard custom auth

2010-02-05 Thread Christian Hammond
That sounds quite ungood. Maybe try temporarily modifying your FasBackend to return None in get_or_create_user and in get_user. This *should* default it back to the built-in auth, I believe. I haven't tried it, though. How is your get_or_create_user and get_user handling not finding users in its b

Re: Using post-review outside of a working copy to upload a diff file

2010-02-05 Thread LukeRobison
Patch submitted as http://reviews.reviewboard.org/r/1393/ The change was almost too simple. I only updated documentation and changed the logic that verifies the options have been specified correctly. -Luke On Feb 5, 4:12 pm, Christian Hammond wrote: > Hi Luke, > > The --repository-url paramete

Re: RB review Process Automation

2010-02-05 Thread Chris Clark
One of the many things on my todo-but-never-get-to-it list is to add close/submit support to postreview. Roshan, if I was in your shoes I'd extend postreview to do what you want. postreview already has the plumbing in place for auth and talking to the RB server, admittedly postreview is really

Re: RB review Process Automation

2010-02-05 Thread Christian Hammond
I'd be fine with this. What I really want to do after we finally get this version of RBTools finalized and out the door is to start splitting post-review into lots of little utility apps, and a Python API. I want to do it Git-style, where there's a central "rb" command with subcommands backed by p

Re: About Installation of Reviewboard

2010-02-05 Thread Christian Hammond
Hi, rb-site doesn't remember any of these values, so you can't reconfigure this way. However, it all really just boils down to making the initial directory structure and then writing conf/settings_local.py. So you can modify this file for any of your new settings. You'd want to see the Django docu

Re: Active Directory form is disabled

2010-02-05 Thread Christian Hammond
Hi Jan, It doesn't tell you that there's a missing dependency or anything? You will need the ldap and PyDNS modules installed to use it. Make sure to restart Apache after installing those. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc