Re: post-review login issue

2009-09-23 Thread Christian Hammond
psx6zut' > > > > >>>> import subprocess > > > > > >>> p = subprocess.Popen(command, stdin=subprocess.PIPE, > > > > > stdout=subprocess.PIPE, stderr=subprocess.STDOUT) > > > > >>>> p.stdout.read() &

Re: post-review login issue

2009-09-23 Thread Hui Lin
p.stdout.read() > > > >    'patching file c:\\winnt\\temp\\reviewboard.zug54j\\tmp-wkiqd\r\n' > > > > > What could be wrong? > > > > > I am using the GnuWin32 patch version 2.5.9. > > > > > On Sep 22, 6:45 pm, "Lacoste, Dana (

Re: post-review login issue

2009-09-23 Thread Hui Lin
file c:\\winnt\\temp\\reviewboard.zug54j\\tmp-wkiqd\r\n' > > > > What could be wrong? > > > > I am using the GnuWin32 patch version 2.5.9. > > > > On Sep 22, 6:45 pm, "Lacoste, Dana (TSG Software San Diego)" > > > wrote: > > > >

Re: post-review login issue

2009-09-23 Thread Hui Lin
m, "Lacoste, Dana (TSG Software San Diego)" > > wrote: > > > OK, that makes sense. > > > > I was just hoping for a quicker solution to the "give me the whole file" > > problem ☺ > > > > I'll see what I can provide in the realm o

Re: post-review login issue

2009-09-22 Thread Christian Hammond
t; > > > I'll see what I can provide in the realm of support for coding that ☺ > > > > Dana > > > > From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] > On Behalf Of Christian Hammond > > Sent: Tuesday, September 22, 2009 4:38 PM >

Re: post-review login issue

2009-09-22 Thread Hui Lin
blem ☺ > > I'll see what I can provide in the realm of support for coding that ☺ > > Dana > > From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On > Behalf Of Christian Hammond > Sent: Tuesday, September 22, 2009 4:38 PM > To: reviewboard@googlegroups.

RE: post-review login issue

2009-09-22 Thread Lacoste, Dana (TSG Software San Diego)
an Hammond Sent: Tuesday, September 22, 2009 4:38 PM To: reviewboard@googlegroups.com Subject: Re: post-review login issue Hi Dana, We specifically avoid this for a few reasons. 1) It's much more efficient to store a diff in the database instead of a full file. 2) We need both an original, u

Re: post-review login issue

2009-09-22 Thread Christian Hammond
ff'd" file would > already be available and so it would not need to be generated > > > > Dana Lacoste > > > > *From:* reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] > *On Behalf Of *Christian Hammond > *Sent:* Tuesday, September 22, 2009

Re: post-review login issue

2009-09-22 Thread Christian Hammond
; > > > > comparison, we could remove some of these complications. > > > > > > > > Christian > > > > > > > > -- > > > > > > Christian Hammond - chip...@chipx86.com > > > > > > Review Board -http://www.re

Re: post-review login issue

2009-09-22 Thread Tom Sakkos
; > > if we > > > > > > cached the results and allowed each repository backend to do its > own > > > > > > comparison, we could remove some of these complications. > > > > > > > > Christian > > > > > > > > -- > >

Re: post-review login issue

2009-09-22 Thread Hui Lin
gt; > > > > comparison, we could remove some of these complications. > > > > > > Christian > > > > > > -- > > > > > Christian Hammond - chip...@chipx86.com > > > > > Review Board -http://www.review-board.org > >

Re: post-review login issue

2009-09-21 Thread Christian Hammond
w.vmware.com > > > > > > On Mon, Sep 21, 2009 at 12:41 PM, Lacoste, Dana (TSG Software San > Diego) > > > < > > > > > > dana.laco...@hp.com> wrote: > > > > > Yeah, this one got me. > > > > > > > Particularl

Re: post-review login issue

2009-09-21 Thread Hui Lin
.review-board.org > > > VMware, Inc. -http://www.vmware.com > > > > On Mon, Sep 21, 2009 at 12:41 PM, Lacoste, Dana (TSG Software San Diego) > > < > > > > dana.laco...@hp.com> wrote: > > > >  Yeah, this one got me. > > > > > Parti

Re: post-review login issue

2009-09-21 Thread Christian Hammond
009 at 12:41 PM, Lacoste, Dana (TSG Software San Diego) > < > > > > dana.laco...@hp.com> wrote: > > > Yeah, this one got me. > > > > > Particularly because what I set for my "$P4PORT" was NOT what the > server > > > returned in `p4

Re: post-review login issue

2009-09-21 Thread Hui Lin
past, but the server returned its hostname.) > > > J > > > Dana Lacoste > > > *From:* reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] > > *On Behalf Of *Christian Hammond > > *Sent:* Monday, September 21, 2009 12:31 PM > > *To:* reviewboard@

Re: post-review login issue

2009-09-21 Thread Christian Hammond
groups.com [mailto:reviewbo...@googlegroups.com] > *On Behalf Of *Christian Hammond > *Sent:* Monday, September 21, 2009 12:31 PM > *To:* reviewboard@googlegroups.com > *Subject:* Re: post-review login issue > > > > Make sure that the repository Path field matches *exactly*

RE: post-review login issue

2009-09-21 Thread Lacoste, Dana (TSG Software San Diego)
mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: Monday, September 21, 2009 12:31 PM To: reviewboard@googlegroups.com Subject: Re: post-review login issue Make sure that the repository Path field matches *exactly* what you see when running 'p4 info'. We do a

Re: post-review login issue

2009-09-21 Thread Christian Hammond
Make sure that the repository Path field matches *exactly* what you see when running 'p4 info'. We do a literal string comparison. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Mon, Sep 21, 2009 at 10:55

Re: post-review login issue

2009-09-21 Thread Hui Lin
Thanks Christian. I resolved the issue by install the 1.0.3 version and re-create the site. Now post-review is able to logon the reviewer board server, but gets problem of understanding the "repository_path" of the SCM (Perforce): >>> Attempting to create review request for 388600 >>> HTT

Re: post-review login issue

2009-09-20 Thread Christian Hammond
Depends. You may just have logging turned off. Go in the Administration UI -> Settings -> Logging and make sure it's enabled and being store in a directory writable by the web server. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - h

Re: post-review login issue

2009-09-20 Thread Hui Lin
The apache server was installed to just host the review board server, so I doubt there is another vhost serviced by it. I noticed that the logs directory of review board is empty. Is that strange? On Sep 20, 7:23 pm, Christian Hammond wrote: > Okay, so Review Board itself is correct. However, po

Re: post-review login issue

2009-09-20 Thread Hui Lin
Is there a debug flag on the review board server which can be turned on to trace what is happening? On Sep 20, 7:18 pm, Hui Lin wrote: > "http://b00237d4f5dc7/reviews/vtm/"; redirect me to the dashboard. > Going to "http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/"; > in the browser re

Re: post-review login issue

2009-09-20 Thread Christian Hammond
Okay, so Review Board itself is correct. However, post-review is somehow not accessing the same server. This may be a configuration error on the web server. How many other virtual hosts is that server serving? It may be worth checking the log files of the other vhosts to find out which site is actu

Re: post-review login issue

2009-09-20 Thread Hui Lin
"http://b00237d4f5dc7/reviews/vtm/"; redirect me to the dashboard. Going to "http://b00237d4f5dc7/reviews/vtm/api/json/accounts/login/"; in the browser returns an empty page. On Sep 20, 6:17 pm, Christian Hammond wrote: > It sounds like the server isn't configured at that URL correctly, or > po

Re: post-review login issue

2009-09-20 Thread Christian Hammond
It sounds like the server isn't configured at that URL correctly, or post-review is hitting the wrong IP address/server. Does http://b00237d4f5dc7/reviews/vtm/ redirect you to the dashboard or login page in your browser? What happens when going to http://b00237d4f5dc7/reviews/vtm/api/json/accounts/