Re: Requesting ideas for Google Summer of Code
Reporting. The ability to see things like - how many review requests a given developer has open at the moment. - How many reviews and review requests a given developer has done in the last X days - Stats on review requests. Average length, Min/max. etc. We have also had the situation where with multiple reviewers. A reviewer provides comments to the author, and there is no way for them to know if the author is in the middle of refining the diff or waiting for more comments. Same applies that after the reviewer provides comments, and a new diff is posted, they can't tell via the web interface if they need to comment again. (You have to remember the mail that was sent out detailing rev 2 of the diff). So better ways to know who's court the review is in. Scott On Fri, Mar 19, 2010 at 6:41 PM, Eduardo Felipe wrote: > Now you have! Congrats! > > What would you like the most seen implemented? > > []s > > Eduardo. > > On Thu, Mar 11, 2010 at 7:35 PM, Christian Hammond > wrote: > > We haven't even been accepted yet (though we've had several student > > applications already!) so no huge hurry. Ideally, though, within 1-2 > weeks. > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board - http://www.reviewboard.org > > VMware, Inc. - http://www.vmware.com > > > > > > On Thu, Mar 11, 2010 at 1:22 PM, Paul Schulz > wrote: > >> > >> When do the suggestions need to be in by? > >> > >> The company that I work for uses Reviewboard across several > >> international sites. I'm attempting to collect suggestion from the > >> other users. > >> > >> Cheers, > >> Paul > >> > >> On Fri, Mar 12, 2010 at 7:41 AM, Stephen Gallagher > >> wrote: > >> > On 03/10/2010 04:32 PM, Dan Savilonis wrote: > >> >> I would generalize Stephen's idea and just call it general support > for > >> >> distributed vcs workflow since RB isn't really built around that > model > >> >> and we're kind of stuffing it in after the fact. > >> >> > >> > > >> > I found some time today and decided to extend post-review to handle > git > >> > patchsets. Turns out it would have been under-scoped for a Summer of > >> > Code project. > >> > > >> > http://reviews.reviewboard.org/r/1472/ > >> > > >> > -- > >> > Want to help the Review Board project? Donate today at > >> > http://www.reviewboard.org/donate/ > >> > Happy user? Let us know at http://www.reviewboard.org/users/ > >> > -~--~~~~--~~--~--~--- > >> > To unsubscribe from this group, send email to > >> > reviewboard+unsubscr...@googlegroups.com > >> > For more options, visit this group at > >> > http://groups.google.com/group/reviewboard?hl=en > >> > >> -- > >> Want to help the Review Board project? Donate today at > >> http://www.reviewboard.org/donate/ > >> Happy user? Let us know at http://www.reviewboard.org/users/ > >> -~--~~~~--~~--~--~--- > >> To unsubscribe from this group, send email to > >> reviewboard+unsubscr...@googlegroups.com > >> For more options, visit this group at > >> http://groups.google.com/group/reviewboard?hl=en > > > > -- > > Want to help the Review Board project? Donate today at > > http://www.reviewboard.org/donate/ > > Happy user? Let us know at http://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > > http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > > To unsubscribe from this group, send email to reviewboard+ > unsubscribegooglegroups.com or reply to this email with the words "REMOVE > ME" as the subject. > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
Re: Requesting ideas for Google Summer of Code
Hey :) Thanks! I think one of the things I'd really like to see is: 1) The DVCS work mentioned in this thread. 2) Maybe some work on the extensions branch. 3) File attachments 4) Some creative UI for better tracking review requests and reviews. I'd love to see what people would brainstorm separate from my list, too. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Fri, Mar 19, 2010 at 3:41 PM, Eduardo Felipe wrote: > Now you have! Congrats! > > What would you like the most seen implemented? > > []s > > Eduardo. > > On Thu, Mar 11, 2010 at 7:35 PM, Christian Hammond > wrote: > > We haven't even been accepted yet (though we've had several student > > applications already!) so no huge hurry. Ideally, though, within 1-2 > weeks. > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board - http://www.reviewboard.org > > VMware, Inc. - http://www.vmware.com > > > > > > On Thu, Mar 11, 2010 at 1:22 PM, Paul Schulz > wrote: > >> > >> When do the suggestions need to be in by? > >> > >> The company that I work for uses Reviewboard across several > >> international sites. I'm attempting to collect suggestion from the > >> other users. > >> > >> Cheers, > >> Paul > >> > >> On Fri, Mar 12, 2010 at 7:41 AM, Stephen Gallagher > >> wrote: > >> > On 03/10/2010 04:32 PM, Dan Savilonis wrote: > >> >> I would generalize Stephen's idea and just call it general support > for > >> >> distributed vcs workflow since RB isn't really built around that > model > >> >> and we're kind of stuffing it in after the fact. > >> >> > >> > > >> > I found some time today and decided to extend post-review to handle > git > >> > patchsets. Turns out it would have been under-scoped for a Summer of > >> > Code project. > >> > > >> > http://reviews.reviewboard.org/r/1472/ > >> > > >> > -- > >> > Want to help the Review Board project? Donate today at > >> > http://www.reviewboard.org/donate/ > >> > Happy user? Let us know at http://www.reviewboard.org/users/ > >> > -~--~~~~--~~--~--~--- > >> > To unsubscribe from this group, send email to > >> > reviewboard+unsubscr...@googlegroups.com > >> > For more options, visit this group at > >> > http://groups.google.com/group/reviewboard?hl=en > >> > >> -- > >> Want to help the Review Board project? Donate today at > >> http://www.reviewboard.org/donate/ > >> Happy user? Let us know at http://www.reviewboard.org/users/ > >> -~--~~~~--~~--~--~--- > >> To unsubscribe from this group, send email to > >> reviewboard+unsubscr...@googlegroups.com > >> For more options, visit this group at > >> http://groups.google.com/group/reviewboard?hl=en > > > > -- > > Want to help the Review Board project? Donate today at > > http://www.reviewboard.org/donate/ > > Happy user? Let us know at http://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > > http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > > To unsubscribe from this group, send email to reviewboard+ > unsubscribegooglegroups.com or reply to this email with the words "REMOVE > ME" as the subject. > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
Re: Requesting ideas for Google Summer of Code
ClearCase :) On Mar 9, 5:44 pm, Christian Hammond wrote: > Hi everyone, > > We've signed up again this year to take part in Google's Summer of Code. > We're still awaiting acceptance, but want to brainstorm some ideas that > students can work on. > > First of all, for those who aren't familiar with this, Google Summer of Code > is a yearly program from Google where students from around the world are > paid to work on open source projects. We participated as an organization > last year and received some awesome features (some of which are going in to > 1.5, some of which are going into 1.6). > > We're hoping for 3 or 4 students this year. We have a list of ideas > (http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd like > feedback on. If you have something you think would be generally useful to > Review Board users that you'd like to see on this list and think would be a > good project, please tell us! > > Also, if you're someone with a fair amount of experience with the Review > Board codebase, let us know if you'd be interested in helping mentor a > student this year. It's purely volunteer work, and can be time-consuming, > but it's also an excellent way to help out the project and get some cool new > features in the codebase. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
Re: Requesting ideas for Google Summer of Code
Now you have! Congrats! What would you like the most seen implemented? []s Eduardo. On Thu, Mar 11, 2010 at 7:35 PM, Christian Hammond wrote: > We haven't even been accepted yet (though we've had several student > applications already!) so no huge hurry. Ideally, though, within 1-2 weeks. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Thu, Mar 11, 2010 at 1:22 PM, Paul Schulz wrote: >> >> When do the suggestions need to be in by? >> >> The company that I work for uses Reviewboard across several >> international sites. I'm attempting to collect suggestion from the >> other users. >> >> Cheers, >> Paul >> >> On Fri, Mar 12, 2010 at 7:41 AM, Stephen Gallagher >> wrote: >> > On 03/10/2010 04:32 PM, Dan Savilonis wrote: >> >> I would generalize Stephen's idea and just call it general support for >> >> distributed vcs workflow since RB isn't really built around that model >> >> and we're kind of stuffing it in after the fact. >> >> >> > >> > I found some time today and decided to extend post-review to handle git >> > patchsets. Turns out it would have been under-scoped for a Summer of >> > Code project. >> > >> > http://reviews.reviewboard.org/r/1472/ >> > >> > -- >> > Want to help the Review Board project? Donate today at >> > http://www.reviewboard.org/donate/ >> > Happy user? Let us know at http://www.reviewboard.org/users/ >> > -~--~~~~--~~--~--~--- >> > To unsubscribe from this group, send email to >> > reviewboard+unsubscr...@googlegroups.com >> > For more options, visit this group at >> > http://groups.google.com/group/reviewboard?hl=en >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
Re: Requesting ideas for Google Summer of Code
We haven't even been accepted yet (though we've had several student applications already!) so no huge hurry. Ideally, though, within 1-2 weeks. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Mar 11, 2010 at 1:22 PM, Paul Schulz wrote: > When do the suggestions need to be in by? > > The company that I work for uses Reviewboard across several > international sites. I'm attempting to collect suggestion from the > other users. > > Cheers, > Paul > > On Fri, Mar 12, 2010 at 7:41 AM, Stephen Gallagher > wrote: > > On 03/10/2010 04:32 PM, Dan Savilonis wrote: > >> I would generalize Stephen's idea and just call it general support for > >> distributed vcs workflow since RB isn't really built around that model > >> and we're kind of stuffing it in after the fact. > >> > > > > I found some time today and decided to extend post-review to handle git > > patchsets. Turns out it would have been under-scoped for a Summer of > > Code project. > > > > http://reviews.reviewboard.org/r/1472/ > > > > -- > > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > > Happy user? Let us know at http://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
When do the suggestions need to be in by? The company that I work for uses Reviewboard across several international sites. I'm attempting to collect suggestion from the other users. Cheers, Paul On Fri, Mar 12, 2010 at 7:41 AM, Stephen Gallagher wrote: > On 03/10/2010 04:32 PM, Dan Savilonis wrote: >> I would generalize Stephen's idea and just call it general support for >> distributed vcs workflow since RB isn't really built around that model >> and we're kind of stuffing it in after the fact. >> > > I found some time today and decided to extend post-review to handle git > patchsets. Turns out it would have been under-scoped for a Summer of > Code project. > > http://reviews.reviewboard.org/r/1472/ > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
On 03/10/2010 04:32 PM, Dan Savilonis wrote: > I would generalize Stephen's idea and just call it general support for > distributed vcs workflow since RB isn't really built around that model > and we're kind of stuffing it in after the fact. > I found some time today and decided to extend post-review to handle git patchsets. Turns out it would have been under-scoped for a Summer of Code project. http://reviews.reviewboard.org/r/1472/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
It's not the complexity so much. LDAP, AD, and S3 are things masked by auth and storage backends in Django. We can get those cheaply and there's no user-facing UI for any of it. Furthermore, those are needed for core operations of Review Board. Features like advanced bug tracker integration or buildbot/tinderbox/whatever integration is more complex and the featuresets and needs can vary widely between setups. It's also not part of the core functionality of Review Board. What we'd like to do is keep the Review Board core product built around the ability to review code. Extra functionality like integration with buildbot, tinderbox, bugzilla, trac, or whatever is great, and I'd like to see it, but it shouldn't be part of the core codebase. That will just make it far harder to keep things from becoming too large or unstable and make it more difficult to test an out-of-the-box install. I consider our extensions work to be very important for the product, as it will open a lot of doors in terms of what people can do with Review Board. Much work has been done on this so far, and it will be going into the 2.0 release. At that point, I want to heavily promote extensions that integrate into these other services. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Mar 10, 2010 at 11:20 PM, Brad Hards wrote: > On Thursday 11 March 2010 05:39:29 pm Christian Hammond wrote: > > I would love integration like this, but it's going to have to wait until > we > > land Extensions support in 2.0. Otherwise we end up complicating the > > codebase, dependencies, UI and settings. > I respect your call on this, but my (hackish) work didn't seem much more > complex than the other optional dependencies (LDAP/AD, search, S3, > couchdb). > > Brad > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
On Thursday 11 March 2010 05:39:29 pm Christian Hammond wrote: > I would love integration like this, but it's going to have to wait until we > land Extensions support in 2.0. Otherwise we end up complicating the > codebase, dependencies, UI and settings. I respect your call on this, but my (hackish) work didn't seem much more complex than the other optional dependencies (LDAP/AD, search, S3, couchdb). Brad -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
I would love integration like this, but it's going to have to wait until we land Extensions support in 2.0. Otherwise we end up complicating the codebase, dependencies, UI and settings. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Mar 10, 2010 at 10:35 PM, Brad Hards wrote: > On Wednesday 10 March 2010 08:44:48 am Christian Hammond wrote: > > Hi everyone, > > > > We've signed up again this year to take part in Google's Summer of Code. > > We're still awaiting acceptance, but want to brainstorm some ideas that > > students can work on. > I'd like to see integration with buildbot (via the "try" scheduler). The > idea > is that you can do an initial review, make sure the code doesn't look > malicious, and then say "what will happen if I commit this now" across > whatever test configurations you have in buildbot. > > I did some initial work ( http://reviews.reviewboard.org/r/1336/ ) on > this, > but I'm too clueless about django UI stuff to finish it off. The concept > (at > least on the submittal side) isn't too complex though. Figuring out how to > get > the results back into reviewboard might be more interesting. > > Brad > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
On Wednesday 10 March 2010 08:44:48 am Christian Hammond wrote: > Hi everyone, > > We've signed up again this year to take part in Google's Summer of Code. > We're still awaiting acceptance, but want to brainstorm some ideas that > students can work on. I'd like to see integration with buildbot (via the "try" scheduler). The idea is that you can do an initial review, make sure the code doesn't look malicious, and then say "what will happen if I commit this now" across whatever test configurations you have in buildbot. I did some initial work ( http://reviews.reviewboard.org/r/1336/ ) on this, but I'm too clueless about django UI stuff to finish it off. The concept (at least on the submittal side) isn't too complex though. Figuring out how to get the results back into reviewboard might be more interesting. Brad -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
Hi, Christian. I think the post-review tools can make some improvements on CVS like file-revision-independent Repository. As to the dashboard of Reviewboard, If it gives users ( super user ) the ability to Creating and Customizing New columns, that would be cool. And more strict permission system and operation permissions would be useful in production environment. Thats my idea, I am not sure their rationality. Best Regard! On 3月11日, 上午10时05分, Christian Hammond wrote: > I spent some time on review.source.android.com a bit earlier and you're > right, it's much snappier. > > I'm going to spend some time looking into what the slowdowns are. Part of it > may be due to the Django templating. Part of it is likely Pygments syntax > highlighting. I'll spend some time poking around and seeing what Gerrit does > and where our bottlenecks are after this release starts to wrap up. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > On Wed, Mar 10, 2010 at 5:56 PM, Dan Savilonis wrote: > > I think it's just a general performance comparison, though initial > > diff loading is particularly slow. I haven't profiled it, but if you > > compare loading reviews.reviewboard.org dashboard to > > review.source.android.com, or one of the diffs, the latter just feels > > much more instantaneous. I don't know how much of that is due to > > caching, network latency, javascript, server-side, etc but faster is > > always better :) So one part of this is just gathering some profiling > > data and comparing. > > > On Mar 10, 4:37 pm, Christian Hammond wrote: > > > Agreed on both parts. > > > > There's a bit more that Review Board does than Gerrit and Rietveld under > > the > > > hood, but we should certainly strive to make things faster. Is there a > > > specific area where Review Board feels slower to you? > > > > Christian > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > On Wed, Mar 10, 2010 at 1:32 PM, Dan Savilonis wrote: > > > > I would generalize Stephen's idea and just call it general support for > > > > distributed vcs workflow since RB isn't really built around that model > > > > and we're kind of stuffing it in after the fact. > > > > > I'd also love to see performance improvements. I haven't done any real > > > > comparisons, but Rietveld and Gerrit just seem much more lightweight > > > > and snappy. > > > > > Dan > > > > > On Mar 9, 10:03 pm, Stephen Gallagher > > > > wrote: > > > > > It was discussed in another thread, but I think it would be great to > > > > improve > > > > > the git support by handling patch-sets in post-review. > > > > > > The idea would be to support the following workflow: > > > > > > Create a branch based on the upstream master (the repository that RB > > is > > > > > storing). > > > > > Apply several patches on that branch, each dependent on the others. > > > > > post-review should be capable of automatically generating a review > > (using > > > > > --guess-summary and --guess-description) for every patch since the > > > > > divergence from upstream, properly handling the linking to a parent > > diff. > > > > > > On Tue, Mar 9, 2010 at 4:44 PM, Christian Hammond < > > chip...@chipx86.com > > > > >wrote: > > > > > > > Hi everyone, > > > > > > > We've signed up again this year to take part in Google's Summer of > > > > Code. > > > > > > We're still awaiting acceptance, but want to brainstorm some ideas > > that > > > > > > students can work on. > > > > > > > First of all, for those who aren't familiar with this, Google > > Summer of > > > > > > Code is a yearly program from Google where students from around the > > > > world > > > > > > are paid to work on open source projects. We participated as an > > > > organization > > > > > > last year and received some awesome features (some of which are > > going > > > > in to > > > > > > 1.5, some of which are going into 1.6). > > > > > > > We're hoping for 3 or 4 students this year. We have a list of ideas > > ( > > > > > >http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd > > like > > > > > > feedback on. If you have something you think would be generally > > useful > > > > to > > > > > > Review Board users that you'd like to see on this list and think > > would > > > > be a > > > > > > good project, please tell us! > > > > > > > Also, if you're someone with a fair amount of experience with the > > > > Review > > > > > > Board codebase, let us know if you'd be interested in helping > > mentor a > > > > > > student this year. It's purely volunteer work, and can be > > > > time-consuming, > > > > > > but it's also an excellent way to help out the project and get some > > > > cool new > > > > > > features in the codebase. > > > > > > > Christian > > > > > > > -- > > > > > > Christian Hammond - chip...@chipx86.com > > > > > > Review Board -http
Re: Requesting ideas for Google Summer of Code
I spent some time on review.source.android.com a bit earlier and you're right, it's much snappier. I'm going to spend some time looking into what the slowdowns are. Part of it may be due to the Django templating. Part of it is likely Pygments syntax highlighting. I'll spend some time poking around and seeing what Gerrit does and where our bottlenecks are after this release starts to wrap up. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Mar 10, 2010 at 5:56 PM, Dan Savilonis wrote: > I think it's just a general performance comparison, though initial > diff loading is particularly slow. I haven't profiled it, but if you > compare loading reviews.reviewboard.org dashboard to > review.source.android.com, or one of the diffs, the latter just feels > much more instantaneous. I don't know how much of that is due to > caching, network latency, javascript, server-side, etc but faster is > always better :) So one part of this is just gathering some profiling > data and comparing. > > On Mar 10, 4:37 pm, Christian Hammond wrote: > > Agreed on both parts. > > > > There's a bit more that Review Board does than Gerrit and Rietveld under > the > > hood, but we should certainly strive to make things faster. Is there a > > specific area where Review Board feels slower to you? > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > > > > > > On Wed, Mar 10, 2010 at 1:32 PM, Dan Savilonis wrote: > > > I would generalize Stephen's idea and just call it general support for > > > distributed vcs workflow since RB isn't really built around that model > > > and we're kind of stuffing it in after the fact. > > > > > I'd also love to see performance improvements. I haven't done any real > > > comparisons, but Rietveld and Gerrit just seem much more lightweight > > > and snappy. > > > > > Dan > > > > > On Mar 9, 10:03 pm, Stephen Gallagher > > > wrote: > > > > It was discussed in another thread, but I think it would be great to > > > improve > > > > the git support by handling patch-sets in post-review. > > > > > > The idea would be to support the following workflow: > > > > > > Create a branch based on the upstream master (the repository that RB > is > > > > storing). > > > > Apply several patches on that branch, each dependent on the others. > > > > post-review should be capable of automatically generating a review > (using > > > > --guess-summary and --guess-description) for every patch since the > > > > divergence from upstream, properly handling the linking to a parent > diff. > > > > > > On Tue, Mar 9, 2010 at 4:44 PM, Christian Hammond < > chip...@chipx86.com > > > >wrote: > > > > > > > Hi everyone, > > > > > > > We've signed up again this year to take part in Google's Summer of > > > Code. > > > > > We're still awaiting acceptance, but want to brainstorm some ideas > that > > > > > students can work on. > > > > > > > First of all, for those who aren't familiar with this, Google > Summer of > > > > > Code is a yearly program from Google where students from around the > > > world > > > > > are paid to work on open source projects. We participated as an > > > organization > > > > > last year and received some awesome features (some of which are > going > > > in to > > > > > 1.5, some of which are going into 1.6). > > > > > > > We're hoping for 3 or 4 students this year. We have a list of ideas > ( > > > > >http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd > like > > > > > feedback on. If you have something you think would be generally > useful > > > to > > > > > Review Board users that you'd like to see on this list and think > would > > > be a > > > > > good project, please tell us! > > > > > > > Also, if you're someone with a fair amount of experience with the > > > Review > > > > > Board codebase, let us know if you'd be interested in helping > mentor a > > > > > student this year. It's purely volunteer work, and can be > > > time-consuming, > > > > > but it's also an excellent way to help out the project and get some > > > cool new > > > > > features in the codebase. > > > > > > > Christian > > > > > > > -- > > > > > Christian Hammond - chip...@chipx86.com > > > > > Review Board -http://www.reviewboard.org > > > > > VMware, Inc. -http://www.vmware.com > > > > > > > -- > > > > > Want to help the Review Board project? Donate today at > > > > >http://www.reviewboard.org/donate/ > > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > > -~--~~~~--~~--~--~--- > > > > > To unsubscribe from this group, send email to> > > > reviewboard+unsubscr...@googlegroups.com > > < > reviewboard%2bunsubscr...@googlegroups.com > > > > > > > > For more options, visit this group at > > > > >http://groups.google.com/group/reviewboard?hl=en > > > > > -- > > > Want to hel
Re: Requesting ideas for Google Summer of Code
I think it's just a general performance comparison, though initial diff loading is particularly slow. I haven't profiled it, but if you compare loading reviews.reviewboard.org dashboard to review.source.android.com, or one of the diffs, the latter just feels much more instantaneous. I don't know how much of that is due to caching, network latency, javascript, server-side, etc but faster is always better :) So one part of this is just gathering some profiling data and comparing. On Mar 10, 4:37 pm, Christian Hammond wrote: > Agreed on both parts. > > There's a bit more that Review Board does than Gerrit and Rietveld under the > hood, but we should certainly strive to make things faster. Is there a > specific area where Review Board feels slower to you? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Wed, Mar 10, 2010 at 1:32 PM, Dan Savilonis wrote: > > I would generalize Stephen's idea and just call it general support for > > distributed vcs workflow since RB isn't really built around that model > > and we're kind of stuffing it in after the fact. > > > I'd also love to see performance improvements. I haven't done any real > > comparisons, but Rietveld and Gerrit just seem much more lightweight > > and snappy. > > > Dan > > > On Mar 9, 10:03 pm, Stephen Gallagher > > wrote: > > > It was discussed in another thread, but I think it would be great to > > improve > > > the git support by handling patch-sets in post-review. > > > > The idea would be to support the following workflow: > > > > Create a branch based on the upstream master (the repository that RB is > > > storing). > > > Apply several patches on that branch, each dependent on the others. > > > post-review should be capable of automatically generating a review (using > > > --guess-summary and --guess-description) for every patch since the > > > divergence from upstream, properly handling the linking to a parent diff. > > > > On Tue, Mar 9, 2010 at 4:44 PM, Christian Hammond > >wrote: > > > > > Hi everyone, > > > > > We've signed up again this year to take part in Google's Summer of > > Code. > > > > We're still awaiting acceptance, but want to brainstorm some ideas that > > > > students can work on. > > > > > First of all, for those who aren't familiar with this, Google Summer of > > > > Code is a yearly program from Google where students from around the > > world > > > > are paid to work on open source projects. We participated as an > > organization > > > > last year and received some awesome features (some of which are going > > in to > > > > 1.5, some of which are going into 1.6). > > > > > We're hoping for 3 or 4 students this year. We have a list of ideas ( > > > >http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd like > > > > feedback on. If you have something you think would be generally useful > > to > > > > Review Board users that you'd like to see on this list and think would > > be a > > > > good project, please tell us! > > > > > Also, if you're someone with a fair amount of experience with the > > Review > > > > Board codebase, let us know if you'd be interested in helping mentor a > > > > student this year. It's purely volunteer work, and can be > > time-consuming, > > > > but it's also an excellent way to help out the project and get some > > cool new > > > > features in the codebase. > > > > > Christian > > > > > -- > > > > Christian Hammond - chip...@chipx86.com > > > > Review Board -http://www.reviewboard.org > > > > VMware, Inc. -http://www.vmware.com > > > > > -- > > > > Want to help the Review Board project? Donate today at > > > >http://www.reviewboard.org/donate/ > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > -~--~~~~--~~--~--~--- > > > > To unsubscribe from this group, send email to> > > > > > >reviewboard+unsubscr...@googlegroups.com > > > oups.com>> > > > > > > > glegroups.com> > > > > > For more options, visit this group at > > > >http://groups.google.com/group/reviewboard?hl=en > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email > > to>reviewboard+unsubscr...@googlegroups.com > oups.com> > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
Agreed on both parts. There's a bit more that Review Board does than Gerrit and Rietveld under the hood, but we should certainly strive to make things faster. Is there a specific area where Review Board feels slower to you? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Mar 10, 2010 at 1:32 PM, Dan Savilonis wrote: > I would generalize Stephen's idea and just call it general support for > distributed vcs workflow since RB isn't really built around that model > and we're kind of stuffing it in after the fact. > > I'd also love to see performance improvements. I haven't done any real > comparisons, but Rietveld and Gerrit just seem much more lightweight > and snappy. > > Dan > > On Mar 9, 10:03 pm, Stephen Gallagher > wrote: > > It was discussed in another thread, but I think it would be great to > improve > > the git support by handling patch-sets in post-review. > > > > The idea would be to support the following workflow: > > > > Create a branch based on the upstream master (the repository that RB is > > storing). > > Apply several patches on that branch, each dependent on the others. > > post-review should be capable of automatically generating a review (using > > --guess-summary and --guess-description) for every patch since the > > divergence from upstream, properly handling the linking to a parent diff. > > > > On Tue, Mar 9, 2010 at 4:44 PM, Christian Hammond >wrote: > > > > > Hi everyone, > > > > > We've signed up again this year to take part in Google's Summer of > Code. > > > We're still awaiting acceptance, but want to brainstorm some ideas that > > > students can work on. > > > > > First of all, for those who aren't familiar with this, Google Summer of > > > Code is a yearly program from Google where students from around the > world > > > are paid to work on open source projects. We participated as an > organization > > > last year and received some awesome features (some of which are going > in to > > > 1.5, some of which are going into 1.6). > > > > > We're hoping for 3 or 4 students this year. We have a list of ideas ( > > >http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd like > > > feedback on. If you have something you think would be generally useful > to > > > Review Board users that you'd like to see on this list and think would > be a > > > good project, please tell us! > > > > > Also, if you're someone with a fair amount of experience with the > Review > > > Board codebase, let us know if you'd be interested in helping mentor a > > > student this year. It's purely volunteer work, and can be > time-consuming, > > > but it's also an excellent way to help out the project and get some > cool new > > > features in the codebase. > > > > > Christian > > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > > -- > > > Want to help the Review Board project? Donate today at > > >http://www.reviewboard.org/donate/ > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > -~--~~~~--~~--~--~--- > > > To unsubscribe from this group, send email to > > > reviewboard+unsubscr...@googlegroups.com > > > > > > For more options, visit this group at > > >http://groups.google.com/group/reviewboard?hl=en > > > > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
I would generalize Stephen's idea and just call it general support for distributed vcs workflow since RB isn't really built around that model and we're kind of stuffing it in after the fact. I'd also love to see performance improvements. I haven't done any real comparisons, but Rietveld and Gerrit just seem much more lightweight and snappy. Dan On Mar 9, 10:03 pm, Stephen Gallagher wrote: > It was discussed in another thread, but I think it would be great to improve > the git support by handling patch-sets in post-review. > > The idea would be to support the following workflow: > > Create a branch based on the upstream master (the repository that RB is > storing). > Apply several patches on that branch, each dependent on the others. > post-review should be capable of automatically generating a review (using > --guess-summary and --guess-description) for every patch since the > divergence from upstream, properly handling the linking to a parent diff. > > On Tue, Mar 9, 2010 at 4:44 PM, Christian Hammond wrote: > > > Hi everyone, > > > We've signed up again this year to take part in Google's Summer of Code. > > We're still awaiting acceptance, but want to brainstorm some ideas that > > students can work on. > > > First of all, for those who aren't familiar with this, Google Summer of > > Code is a yearly program from Google where students from around the world > > are paid to work on open source projects. We participated as an organization > > last year and received some awesome features (some of which are going in to > > 1.5, some of which are going into 1.6). > > > We're hoping for 3 or 4 students this year. We have a list of ideas ( > >http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd like > > feedback on. If you have something you think would be generally useful to > > Review Board users that you'd like to see on this list and think would be a > > good project, please tell us! > > > Also, if you're someone with a fair amount of experience with the Review > > Board codebase, let us know if you'd be interested in helping mentor a > > student this year. It's purely volunteer work, and can be time-consuming, > > but it's also an excellent way to help out the project and get some cool new > > features in the codebase. > > > Christian > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
It was discussed in another thread, but I think it would be great to improve the git support by handling patch-sets in post-review. The idea would be to support the following workflow: Create a branch based on the upstream master (the repository that RB is storing). Apply several patches on that branch, each dependent on the others. post-review should be capable of automatically generating a review (using --guess-summary and --guess-description) for every patch since the divergence from upstream, properly handling the linking to a parent diff. On Tue, Mar 9, 2010 at 4:44 PM, Christian Hammond wrote: > Hi everyone, > > We've signed up again this year to take part in Google's Summer of Code. > We're still awaiting acceptance, but want to brainstorm some ideas that > students can work on. > > First of all, for those who aren't familiar with this, Google Summer of > Code is a yearly program from Google where students from around the world > are paid to work on open source projects. We participated as an organization > last year and received some awesome features (some of which are going in to > 1.5, some of which are going into 1.6). > > We're hoping for 3 or 4 students this year. We have a list of ideas ( > http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd like > feedback on. If you have something you think would be generally useful to > Review Board users that you'd like to see on this list and think would be a > good project, please tell us! > > Also, if you're someone with a fair amount of experience with the Review > Board codebase, let us know if you'd be interested in helping mentor a > student this year. It's purely volunteer work, and can be time-consuming, > but it's also an excellent way to help out the project and get some cool new > features in the codebase. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Requesting ideas for Google Summer of Code
Hi everyone, We've signed up again this year to take part in Google's Summer of Code. We're still awaiting acceptance, but want to brainstorm some ideas that students can work on. First of all, for those who aren't familiar with this, Google Summer of Code is a yearly program from Google where students from around the world are paid to work on open source projects. We participated as an organization last year and received some awesome features (some of which are going in to 1.5, some of which are going into 1.6). We're hoping for 3 or 4 students this year. We have a list of ideas ( http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd like feedback on. If you have something you think would be generally useful to Review Board users that you'd like to see on this list and think would be a good project, please tell us! Also, if you're someone with a fair amount of experience with the Review Board codebase, let us know if you'd be interested in helping mentor a student this year. It's purely volunteer work, and can be time-consuming, but it's also an excellent way to help out the project and get some cool new features in the codebase. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
