Re: Unable to view diff for multiple files.
I have a workaround that'll go into 1.7.8, but I'm really confused how the original problem is occurring. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Wed, May 29, 2013 at 10:46 AM, Kristin Thomas xtintho...@gmail.comwrote: On Tuesday, May 28, 2013 12:16:37 PM UTC-6, Matthew Woehlke wrote: Um... this seems familiar. Have you upgraded through a number of RB versions? Is the user having trouble either notably older, newer, or had a long period of inactivity? It was a fairly new install of RB from scratch. Something to try: have the user go into their account settings and change the value of their 'always open an issue' option. (They can immediately change it back, just as long as they apply the change with the opposite value to force it to be rewritten.) Yeah, we did that and it corrected the issue. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
Some more info, when this is not working, the page source has the following: var gOpenAnIssue = ; instead of: var gOpenAnIssue = true; On Friday, April 19, 2013 9:37:07 PM UTC-6, Jonathan Wilson wrote: Hi, For some reason I am unable to view the diffs for multiple files on Reviewboard v1.7.6. I can only see the diff for the first file. The rest of the file diffs are stuck loading forever (with the little circular animated loading icon) I've tried with Internet Explorer 8, 9, Google Chrome and firefox and I get the same behavior. I even tried clearing my internet cache but that doesn't seem to help. Does anyone have any idea what is causing this? Thanks, -JW -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
Hi, We just ran across this issue on a recent installation ourselves; one single user out of 18 reported this behaviour. While tracking this down, I spotted a seemingly unrelated issue where gOpenAnIssue wasn't being set despite the user's account settings saying that it was. Getting my colleague to reset the Open An Issue setting on his account fixed his ability to view more than one diffed file. This appears to be related to the fact that his account was created manually through the admin pages rather than being auto-created through login. Will need to do some testing of that idea, though. Ken On Tuesday, April 23, 2013 7:16:04 PM UTC-6, Jonathan Wilson wrote: Hi Christian, Sorry for the late reply, I tried view a diff with the Chrome console and no error messages were displayed. I only received the following messages while clicking on the initial review request link: Uncaught SyntaxError: Unexpected token ; /r/593/:40 Uncaught ReferenceError: gReviewRequestId is not defined reviews.min.js:112 Uncaught TypeError: Object #Object has no method 'setFileAttachmentComments' rb-server.myreviewboard.org:415 I have 2 other colleagues who have the same issue, but the majority of my colleagues have no issues viewing multiple diffs. -JW On Monday, April 22, 2013 2:33:58 PM UTC-4, Christian Hammond wrote: On Mon, Apr 22, 2013 at 8:57 AM, Matthew Woehlke mwoehlk...@gmail.comwrote: On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. It very well might be the server. I stated on the browser side because generally, if there's a server-side error, we should be showing it. We load the diffs dynamically, so if there's a browser-side script error, we may fail to either load or render (or show the error). Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
On 2013-05-28 13:22, Kristin Thomas wrote: Some more info, when this is not working, the page source has the following: var gOpenAnIssue = ; instead of: var gOpenAnIssue = true; Um... this seems familiar. Have you upgraded through a number of RB versions? Is the user having trouble either notably older, newer, or had a long period of inactivity? Something to try: have the user go into their account settings and change the value of their 'always open an issue' option. (They can immediately change it back, just as long as they apply the change with the opposite value to force it to be rewritten.) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
The two issues are related. I have absolutely no idea how the user's profile entry is ending up with that value set to.. null? Or something. Actually, for any user hitting this, I'd love to get an SQL dump of their accounts_profile table entry, if you can find it, before they fix it with the double-toggle workaround. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On May 28, 2013, at 7:29 AM, Kristin Thomas xtintho...@gmail.com wrote: Was there a resolution to this issue? We are experiencing a similar problem. We have 16 users with no problem and one user that cannot load any diffs (in IE, Chrome, or Firefox). Same error as mentioned previously: [08:21:52.611] SyntaxError: syntax error @ http://reviewboard.companyname.com/r/87/diff/#:40 [08:21:52.809] ReferenceError: gReviewRequestId is not defined @ http://reviewboard.companyname.com/static/rb/js/reviews.min.89914309c82b.js:112 [08:21:52.837] TypeError: RB.setFileAttachmentComments is not a function @ http://reviewboard.companyname.com/r/87/diff/#:414 I'll attach the log. Any help would be greatly appreciated. Kristin Thomas On Tuesday, April 23, 2013 7:16:04 PM UTC-6, Jonathan Wilson wrote: Hi Christian, Sorry for the late reply, I tried view a diff with the Chrome console and no error messages were displayed. I only received the following messages while clicking on the initial review request link: Uncaught SyntaxError: Unexpected token ; /r/593/:40 Uncaught ReferenceError: gReviewRequestId is not defined reviews.min.js:112 Uncaught TypeError: Object #Object has no method 'setFileAttachmentComments' rb-server.myreviewboard.org:415 I have 2 other colleagues who have the same issue, but the majority of my colleagues have no issues viewing multiple diffs. -JW On Monday, April 22, 2013 2:33:58 PM UTC-4, Christian Hammond wrote: On Mon, Apr 22, 2013 at 8:57 AM, Matthew Woehlke mwoehlk...@gmail.com wrote: On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. It very well might be the server. I stated on the browser side because generally, if there's a server-side error, we should be showing it. We load the diffs dynamically, so if there's a browser-side script error, we may fail to either load or render (or show the error). Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com errors.txt -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
Hi Christian, Sorry for the late reply, I tried view a diff with the Chrome console and no error messages were displayed. I only received the following messages while clicking on the initial review request link: Uncaught SyntaxError: Unexpected token ; /r/593/:40 Uncaught ReferenceError: gReviewRequestId is not defined reviews.min.js:112 Uncaught TypeError: Object #Object has no method 'setFileAttachmentComments' rb-server.myreviewboard.org:415 I have 2 other colleagues who have the same issue, but the majority of my colleagues have no issues viewing multiple diffs. -JW On Monday, April 22, 2013 2:33:58 PM UTC-4, Christian Hammond wrote: On Mon, Apr 22, 2013 at 8:57 AM, Matthew Woehlke mwoehlk...@gmail.comjavascript: wrote: On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. It very well might be the server. I stated on the browser side because generally, if there's a server-side error, we should be showing it. We load the diffs dynamically, so if there's a browser-side script error, we may fail to either load or render (or show the error). Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
Hi Matthew, Yes, my reviewboard server is able to generate diffs without any problems. I also mentioned to Christian, that I have 2 other colleagues that have the same issue as me. However the majority of my colleague can view multiple diffs without any problems. -JW On Monday, April 22, 2013 11:57:56 AM UTC-4, Matthew Woehlke wrote: On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
On Mon, Apr 22, 2013 at 8:57 AM, Matthew Woehlke mwoehlke.fl...@gmail.comwrote: On 2013-04-20 01:55, Christian Hammond wrote: Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Is the server able to generate the diffs? I'm sure Christian knows much more about RB than I do :-), but multiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. It very well might be the server. I stated on the browser side because generally, if there's a server-side error, we should be showing it. We load the diffs dynamically, so if there's a browser-side script error, we may fail to either load or render (or show the error). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Unable to view diff for multiple files.
Hi, For some reason I am unable to view the diffs for multiple files on Reviewboard v1.7.6. I can only see the diff for the first file. The rest of the file diffs are stuck loading forever (with the little circular animated loading icon) I've tried with Internet Explorer 8, 9, Google Chrome and firefox and I get the same behavior. I even tried clearing my internet cache but that doesn't seem to help. Does anyone have any idea what is causing this? Thanks, -JW -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Unable to view diff for multiple files.
Hi Jonathan, I don't think I've seen this. Can you open the Chrome console log, try again, and see what errors may appear? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Fri, Apr 19, 2013 at 8:37 PM, Jonathan Wilson jwil...@gmail.com wrote: Hi, For some reason I am unable to view the diffs for multiple files on Reviewboard v1.7.6. I can only see the diff for the first file. The rest of the file diffs are stuck loading forever (with the little circular animated loading icon) I've tried with Internet Explorer 8, 9, Google Chrome and firefox and I get the same behavior. I even tried clearing my internet cache but that doesn't seem to help. Does anyone have any idea what is causing this? Thanks, -JW -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
