Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

2016-11-09 Thread Andrew Onischuk
> On Nov. 10, 2016, 7:33 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py, > > line 79 > > > > > > Can you try to do "kdestroy" for webhcat

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

2016-11-09 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53629/#review18 --- ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

2016-11-09 Thread Shi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53629/ --- (Updated Nov. 10, 2016, 6:49 a.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 53634: Review step has repository versions value as blank field

2016-11-09 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53634/#review155535 --- Ship it! Ship It! - Richard Zang On Nov. 10, 2016, 1:04 a.m.

Re: Review Request 53633: AMBARI-18841 : Grafana fails to start

2016-11-09 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53633/#review155534 --- Ship it! Ship It! - Sid Wagle On Nov. 9, 2016, 11:51 p.m., A

Re: Review Request 53633: AMBARI-18841 : Grafana fails to start

2016-11-09 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53633/#review155533 --- Ship it! Ship It! - Sid Wagle On Nov. 9, 2016, 11:51 p.m., A

Re: Review Request 53635: AMBARI-15126 - Move NameNode wizard in HA environment fails to update configs correctly when namenode is not running on default port

2016-11-09 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53635/#review155528 --- Ship it! Ship It! - Jaimin Jetly On Nov. 10, 2016, 12:19 a.m

Re: Review Request 53634: Review step has repository versions value as blank field

2016-11-09 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53634/ --- (Updated Nov. 10, 2016, 1:04 a.m.) Review request for Ambari, Richard Zang, Sum

Re: Review Request 53630: Fix for AMBARI-18840 : Added a description for acid transactions in hive configs

2016-11-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53630/#review155524 --- Ship it! Ship It! - Sumit Mohanty On Nov. 10, 2016, 12:04 a.

Review Request 53635: AMBARI-15126 - Move NameNode wizard in HA environment fails to update configs correctly when namenode is not running on default port

2016-11-09 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53635/ --- Review request for Ambari and Jaimin Jetly. Bugs: AMBARI-15126 https://issu

Review Request 53634: Review step has repository versions value as blank field

2016-11-09 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53634/ --- Review request for Ambari, Richard Zang, Sumit Mohanty, Xi Wang, and Yusaku Sako

Review Request 53630: Fix for AMBARI-18840 : Added a description for acid transactions in hive configs

2016-11-09 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53630/ --- Review request for Ambari and Sumit Mohanty. Bugs: AMBARI-18840 https://iss

Review Request 53633: AMBARI-18841 : Grafana fails to start

2016-11-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53633/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBA

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/#review155506 --- Ship it! Ship It! - Sumit Mohanty On Nov. 9, 2016, 10:09 p.m

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-09 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/ --- (Updated Nov. 9, 2016, 10:09 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 53617: ZooKeeper Is Invoking hdp-/conf-select Outside Of Upgrades

2016-11-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53617/ --- (Updated Nov. 9, 2016, 4:35 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy

2016-11-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53129/#review155501 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 9, 2016, 1:2

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-11-09 Thread Vishal Ghugare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/ --- (Updated Nov. 9, 2016, 12:58 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 53617: ZooKeeper Is Invoking hdp-/conf-select Outside Of Upgrades

2016-11-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53617/#review155493 --- Ship it! Ship It! - Nate Cole On Nov. 9, 2016, 3:06 p.m., Jo

Re: Review Request 53621: HAWQ Master fails to start when webhdfs is disabled

2016-11-09 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53621/#review155489 --- Ship it! Ship It! - Lav Jain On Nov. 9, 2016, 8:09 p.m., Mat

Review Request 53621: HAWQ Master fails to start when webhdfs is disabled

2016-11-09 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53621/ --- Review request for Ambari and Lav Jain. Bugs: AMBARI-18837 https://issues.a

Re: Review Request 53617: ZooKeeper Is Invoking hdp-/conf-select Outside Of Upgrades

2016-11-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53617/ --- (Updated Nov. 9, 2016, 3:06 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 53617: ZooKeeper Is Invoking hdp-/conf-select Outside Of Upgrades

2016-11-09 Thread Jonathan Hurley
> On Nov. 9, 2016, 2:23 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_service.py, > > lines 38-42 > > > > > > This code is also in zookeeper.py,

Re: Review Request 53617: ZooKeeper Is Invoking hdp-/conf-select Outside Of Upgrades

2016-11-09 Thread Nate Cole
> On Nov. 9, 2016, 1:06 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py, > > line 410 > > > > > > This was required to prevent calls to conf_sele

Re: Review Request 53583: Optionally force username from LDAP authentication data to be lowercase in Ambari

2016-11-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53583/#review155485 --- Ship it! Ship It! - Jonathan Hurley On Nov. 9, 2016, 2:22 p.

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-09 Thread Sid Wagle
> On Nov. 9, 2016, 3:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 171 > > > > > > Why change these back? qtp doesn't mean anything.

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-09 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/ --- (Updated Nov. 9, 2016, 7:30 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 53617: ZooKeeper Is Invoking hdp-/conf-select Outside Of Upgrades

2016-11-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53617/#review155482 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 9, 2016, 6:0

Re: Review Request 53617: ZooKeeper Is Invoking hdp-/conf-select Outside Of Upgrades

2016-11-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53617/#review155479 --- Fix it, then Ship it! ambari-server/src/main/resources/common-

Re: Review Request 53618: Add prerequisite check for any host in Maintenance Mode when upgrade type is HOST_ORDERED

2016-11-09 Thread Duc Le
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53618/#review155480 --- Ship it! Ship It! - Duc Le On Nov. 9, 2016, 7:14 p.m., Nate

Re: Review Request 53583: Optionally force username from LDAP authentication data to be lowercase in Ambari

2016-11-09 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53583/ --- (Updated Nov. 9, 2016, 2:22 p.m.) Review request for Ambari, Jonathan Hurley, L

Re: Review Request 53618: Add prerequisite check for any host in Maintenance Mode when upgrade type is HOST_ORDERED

2016-11-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53618/ --- (Updated Nov. 9, 2016, 2:14 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 53618: Add prerequisite check for any host in Maintenance Mode when upgrade type is HOST_ORDERED

2016-11-09 Thread Nate Cole
> On Nov. 9, 2016, 1:13 p.m., Jonathan Hurley wrote: > > Ship It! > > Duc Le wrote: > I'm still figuring out how to review, so posting this comment here. Don't > we need to update the description on line 50? > > super(CheckDescription.HOSTS_MAINTENANCE_MODE); Thanks for the review

Re: Review Request 53618: Add prerequisite check for any host in Maintenance Mode when upgrade type is HOST_ORDERED

2016-11-09 Thread Duc Le
> On Nov. 9, 2016, 6:13 p.m., Jonathan Hurley wrote: > > Ship It! I'm still figuring out how to review, so posting this comment here. Don't we need to update the description on line 50? super(CheckDescription.HOSTS_MAINTENANCE_MODE); - Duc --

Re: Review Request 53617: ZooKeeper Is Invoking hdp-/conf-select Outside Of Upgrades

2016-11-09 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53617/#review155467 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 9, 2016, 8:03

Re: Review Request 53618: Add prerequisite check for any host in Maintenance Mode when upgrade type is HOST_ORDERED

2016-11-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53618/#review155465 --- Ship it! Ship It! - Jonathan Hurley On Nov. 9, 2016, 1:03 p.

Re: Review Request 53603: Add Support For Self-Contained Ambari SNMP

2016-11-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53603/#review155464 --- Ship it! Ship It! - Jonathan Hurley On Nov. 9, 2016, 11:54 a

Review Request 53618: Add prerequisite check for any host in Maintenance Mode when upgrade type is HOST_ORDERED

2016-11-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53618/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBAR

Re: Review Request 53617: ZooKeeper Is Invoking hdp-/conf-select Outside Of Upgrades

2016-11-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53617/#review155462 --- ambari-common/src/main/python/resource_management/libraries/funct

Review Request 53617: ZooKeeper Is Invoking hdp-/conf-select Outside Of Upgrades

2016-11-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53617/ --- Review request for Ambari. Bugs: BUG-18682 https://issues.apache.org/jira/b

Re: Review Request 53602: Ambari can autoformat NameNode in a production cluster

2016-11-09 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53602/#review155461 --- Fix it, then Ship it! ambari-server/src/main/resources/common-

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-09 Thread Sid Wagle
> On Nov. 9, 2016, 3:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 171 > > > > > > Why change these back? qtp doesn't mean anything.

Re: Review Request 53603: Add Support For Self-Contained Ambari SNMP

2016-11-09 Thread Dmytro Sen
> On Ноя. 9, 2016, 2:49 п.п., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java, > > line 102 > > > > > > Don't use instanceof here -

Re: Review Request 53603: Add Support For Self-Contained Ambari SNMP

2016-11-09 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53603/ --- (Updated Ноя. 9, 2016, 4:54 п.п.) Review request for Ambari, Aravindan Vijayan,

Re: Review Request 53603: Add Support For Self-Contained Ambari SNMP

2016-11-09 Thread Jonathan Hurley
> On Nov. 9, 2016, 9:49 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java, > > line 102 > > > > > > Don't use instanceof here -

Re: Review Request 53603: Add Support For Self-Contained Ambari SNMP

2016-11-09 Thread Dmytro Sen
> On Ноя. 9, 2016, 2:49 п.п., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java, > > line 102 > > > > > > Don't use instanceof here -

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-11-09 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/#review155441 --- Ship it! Ship It! - Robert Levas On Nov. 9, 2016, 6:25 a.m.,

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Attila Doroszlai
> On Nov. 9, 2016, 3:55 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java, > > line 740 > > > > > > Do either the ClusterTopology or HostOfferRespons

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/#review155437 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53576/ --- (Updated Nov. 9, 2016, 4:07 p.m.) Review request for Ambari, Jonathan Hurley, S

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Attila Doroszlai
> On Nov. 9, 2016, 2:42 p.m., Laszlo Puskas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java, > > line 736 > > > > > > Check the configuration for parallel execution here

Re: Review Request 53603: Add Support For Self-Contained Ambari SNMP

2016-11-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53603/#review155435 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53576/#review155436 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 53602: Ambari can autoformat NameNode in a production cluster

2016-11-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53602/#review155434 --- Fix it, then Ship it! ambari-server/src/main/resources/common-

Re: Review Request 53583: Optionally force username from LDAP authentication data to be lowercase in Ambari

2016-11-09 Thread Jonathan Hurley
> On Nov. 9, 2016, 5:56 a.m., Sebastian Toader wrote: > > ambari-server/docs/configuration/index.md, line 102 > > > > > > Do we need to add the ```index.md``` file to the patch for review or > > not as this is autog

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53576/#review155432 --- ambari-server/src/main/java/org/apache/ambari/server/topology/Top

Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy

2016-11-09 Thread Mugdha Varadkar
> On Nov. 8, 2016, 6:48 p.m., Alejandro Fernandez wrote: > > What should the behavior be for customers with Ranger and Kerberos that are > > upgrading their stack from an existing version with the old logic (could be > > HDP 2.3, 2.4, 2.5) to a higher HDP version? Thanks for pointing it out, w

Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy

2016-11-09 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53129/ --- (Updated Nov. 9, 2016, 1:25 p.m.) Review request for Ambari, Alejandro Fernande

Review Request 53603: Add Support For Self-Contained Ambari SNMP

2016-11-09 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53603/ --- Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and Vi

Re: Review Request 53602: Ambari can autoformat NameNode in a production cluster

2016-11-09 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53602/#review155428 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 9, 2016, 2:08

Review Request 53602: Ambari can autoformat NameNode in a production cluster

2016-11-09 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53602/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18832 https:

Re: Review Request 53544: Deployment failing at creating principal

2016-11-09 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53544/#review155427 --- Ship it! Ship It! - Vitalyi Brodetskyi On Лис. 9, 2016, 11:2

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-11-09 Thread Vishal Ghugare
> On Nov. 1, 2016, 11:46 a.m., Robert Levas wrote: > > Ship It! > > Vishal Ghugare wrote: > Thank you Robert! I would really appreciate if you can commit these > changes on my behalf to trunk ( I am not a committer).The latest patch is > attached to AMBARI-12263. Thanks again. > > Robert

Re: Review Request 53544: Deployment failing at creating principal

2016-11-09 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53544/ --- (Updated Nov. 9, 2016, 11:28 a.m.) Review request for Ambari and Robert Levas.

Re: Review Request 53583: Optionally force username from LDAP authentication data to be lowercase in Ambari

2016-11-09 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53583/#review155423 --- Ship it! Ship It! - Laszlo Puskas On Nov. 8, 2016, 7:09 p.m.

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-11-09 Thread Vishal Ghugare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/ --- (Updated Nov. 9, 2016, 3:25 a.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53576/#review155422 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 53583: Optionally force username from LDAP authentication data to be lowercase in Ambari

2016-11-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53583/#review155419 --- ambari-server/docs/configuration/index.md (line 102)

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53576/ --- (Updated Nov. 9, 2016, 11:27 a.m.) Review request for Ambari, Jonathan Hurley,