Review Request 63671: Remove Auto-Installation of LZO Libraries

2017-11-08 Thread Nate Cole
--- Manual testing: installed cluster (no LZO) including Tez, HDFS, Oozie. Manually added LZO libraries, changed confs, restarted and service check. All green. Unit tests: pending Thanks, Nate Cole

Re: Review Request 63595: Remove HADOOP_HOME From Environment For Daemons

2017-11-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63595/#review190312 --- Ship it! Ship It! - Nate Cole On Nov. 6, 2017, 4:17 p.m

Review Request 63593: Remove Auto-Installation of Mysql Connector

2017-11-06 Thread Nate Cole
/ODPi/2.0/services/HIVE/metainfo.xml 5d1c8980cb Diff: https://reviews.apache.org/r/63593/diff/1/ Testing --- Manual. Unit tests pending. Thanks, Nate Cole

Re: Review Request 63537: Specify the Correct HIVE_BIN In Hive Scripts

2017-11-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63537/#review190031 --- Ship it! Ship It! - Nate Cole On Nov. 3, 2017, 10:10 a.m

Re: Review Request 63535: Send ClusterSummary to install_packages and conf-select exclusion

2017-11-03 Thread Nate Cole
cherry pick, don't forget that there is a stack > > packages under HDP 3.0 in trunk... To my knowledge, IOP clusters aren't candidates for patching and would never get this structure. So no. Ok on 3.0 - Nate ---

Review Request 63535: Send ClusterSummary to install_packages and conf-select exclusion

2017-11-02 Thread Nate Cole
/common/test_conf_select.py 92dd634cca Diff: https://reviews.apache.org/r/63535/diff/1/ Testing --- Manual. Unit tests pending. Thanks, Nate Cole

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

2017-11-02 Thread Nate Cole
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java Lines 77-87 (patched) <https://reviews.apache.org/r/63516/#comment267241> Recommend Sets.newHashSet(String...) - it's much cleaner looking and avoids an added static{} block. - Nate Cole

Re: Review Request 62923: Provide a function in Configuration class to reload the properties file for new custom properties

2017-10-30 Thread Nate Cole
close this review and the corresponding jira. - Nate Cole On Oct. 12, 2017, 2:20 a.m., Yussuf Shaikh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63330: Allow the same config type to belong to multiple services

2017-10-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63330/#review189592 --- Ship it! Ship It! - Nate Cole On Oct. 26, 2017, 10:42 a.m

Review Request 63334: Some pre-upgrade checks do not work when upgrading from IOP to HDP-2.6.3

2017-10-26 Thread Nate Cole
/VersionDefinitionXml.java 7944de8e8c ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java 8433518691 Diff: https://reviews.apache.org/r/63334/diff/1/ Testing --- Manual. Unit tests pending. Thanks, Nate Cole

Re: Review Request 63305: Downgrade From HDP 2.6 to 2.5 Leaves 2.6 Hosts as CURRENT Instead of INSTALLED

2017-10-25 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63305/#review189241 --- Ship it! Ship It! - Nate Cole On Oct. 25, 2017, 3:57 p.m

Review Request 63300: HOU: Service desired repo versions are not being set

2017-10-25 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 63297: Alerts for OneFS mpack

2017-10-25 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63297/#review189202 --- Ship it! Ship It! - Nate Cole On Oct. 25, 2017, 10:04 a.m

Review Request 63222: PU: Could not install version when only build changes

2017-10-23 Thread Nate Cole
8433518691 ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java 5141dc0fbf Diff: https://reviews.apache.org/r/63222/diff/1/ Testing --- Manual. Unit tests pending. Thanks, Nate Cole

Re: Review Request 62923: Provide a function in Configuration class to reload the properties file for new custom properties

2017-10-23 Thread Nate Cole
someone to do it, please ask on the JIRA. - Nate Cole On Oct. 12, 2017, 2:20 a.m., Yussuf Shaikh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63219: Update Kerberos Authentication process to work with improved user management facility

2017-10-23 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63219/#review188962 --- Ship it! Ship It! - Nate Cole On Oct. 23, 2017, 11:53 a.m

Re: Review Request 63123: Version registration failure during patch upgrade + Debian + Oracle run

2017-10-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63123/#review188576 --- Ship it! Ship It! - Nate Cole On Oct. 18, 2017, 4:47 p.m

Review Request 63111: Mahout service check failure after patch upgrade

2017-10-18 Thread Nate Cole
/stack_packages.json b8655d7729 Diff: https://reviews.apache.org/r/63111/diff/1/ Testing --- Manual verification. Thanks, Nate Cole

Re: Review Request 62923: Provide a function in Configuration class to reload the properties file for new custom properties

2017-10-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62923/#review188479 --- Ship it! Ship It! - Nate Cole On Oct. 12, 2017, 2:20 a.m

Review Request 63075: RU: RU failed on "Updating configuration sqoop-atlas-application.properties"

2017-10-17 Thread Nate Cole
/ConfigUpgradeValidityTest.java 44f72bd72a Diff: https://reviews.apache.org/r/63075/diff/1/ Testing --- Manual. Unit tests pending. Thanks, Nate Cole

Re: Review Request 63044: Update JWT Authentication process to work with improved user management facility

2017-10-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63044/#review188313 --- Ship it! Ship It! - Nate Cole On Oct. 16, 2017, 5:02 p.m

Re: Review Request 62982: Expression parser support for JMXServerSide alerts

2017-10-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62982/#review188311 --- Ship it! Ship It! - Nate Cole On Oct. 16, 2017, 4:27 a.m

Re: Review Request 63032: YARN Service Checks Fails Because of Old hadoop-client Classpath Entry

2017-10-16 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63032/#review188175 --- Ship it! Ship It! - Nate Cole On Oct. 16, 2017, 12:22 p.m

Re: Review Request 62996: Restart of random service could fail during express downgrade

2017-10-15 Thread Nate Cole
but Downgrade (DONE) EU Full through Finalize (DONE) EU Full but Downgrade (DONE) EU Patch but Downgrade (DONE) EU Patch then Finalize (DONE) EU Patch then Finalize then Revert (DONE) PENDING Unit tests: Verify no tests are broken with this change: Thanks, Nate Cole

Review Request 62996: Restart of random service could fail during express downgrade

2017-10-13 Thread Nate Cole
then Finalize (PENDING) EU Patch then Finalize then Revert (PENDING) Unit tests: Verify no tests are broken with this change. Thanks, Nate Cole

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62931/#review188009 --- Ship it! Ship It! - Nate Cole On Oct. 12, 2017, 11:36 a.m

Re: Review Request 62949: RU: Downgrade is failed ZKFC

2017-10-12 Thread Nate Cole
t this point, they would still be the new > > stack IDs, right? > > > > I guess no componenents should be changing this between 3rd and 4th > > digits anyway. Just wanted to check - if you think this case isn't valid, > > then drop the issue. > > Nate Cole wrote:

Re: Review Request 62949: RU: Downgrade is failed ZKFC

2017-10-12 Thread Nate Cole
- Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62949/#review187876 --- On Oct. 12, 2017, 4:46 p.m., Nate Cole wrote: > >

Review Request 62949: RU: Downgrade is failed ZKFC

2017-10-12 Thread Nate Cole
. Thanks, Nate Cole

Re: Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

2017-10-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62945/#review187842 --- Ship it! Ship It! - Nate Cole On Oct. 12, 2017, 2:57 p.m

Re: Review Request 62934: Set current_version for Backward Compatibility

2017-10-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62934/#review187795 --- Ship it! Ship It! - Nate Cole On Oct. 12, 2017, 9:57 a.m

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-12 Thread Nate Cole
> On Oct. 12, 2017, 9:01 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > > Lines 217-222 (patched) > > <https://reviews.apache.org/r/62931/diff/1/?file=1853309#file1853309line217> > > > &

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-12 Thread Nate Cole
/ambari/server/upgrade/UpgradeCatalog260.java Lines 217-222 (patched) <https://reviews.apache.org/r/62931/#comment264831> Should these oddly named FKs go in a try/catch since they're not ALWAYS present? - Nate Cole On Oct. 12, 2017, 8:29 a.m., Dmitro Lisnichenko

Review Request 62904: RU was not started on Oracle due to missing table

2017-10-11 Thread Nate Cole
between table definitions. Diffs - ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4e5f30f405 Diff: https://reviews.apache.org/r/62904/diff/1/ Testing --- No change to tests at this time. Thanks, Nate Cole

Re: Review Request 62894: Install Version Fails On IOP Cluster Due To Missing stack_packages Structure

2017-10-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62894/#review187676 --- Ship it! Ship It! - Nate Cole On Oct. 11, 2017, 10:45 a.m

Re: Review Request 62890: AMBARI-22204 Updating Ranger Admin pre-upgrade task

2017-10-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62890/#review187656 --- Ship it! Ship It! - Nate Cole On Oct. 11, 2017, 9:54 a.m

Re: Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

2017-10-10 Thread Nate Cole
/state/repository/VersionDefinitionXml.java Lines 343-344 (patched) <https://reviews.apache.org/r/62871/#comment264607> Ewww - Nate Cole On Oct. 10, 2017, 4:42 p.m., Jonathan Hurley wrote: > > --- > This is an automati

Re: Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

2017-10-10 Thread Nate Cole
- there's no other code after that. - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62851/#review187486 --- On Oct. 9, 2017, 5:19 p.m., Nate Cole wrote: > > ---

Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

2017-10-09 Thread Nate Cole
--- Manual added host and added new service to verify records. Unit tests pending. Thanks, Nate Cole

Re: Review Request 62848: Not able to perform revert after deleting the upgraded service

2017-10-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62848/#review187444 --- Ship it! Ship It! - Nate Cole On Oct. 9, 2017, 3:06 p.m

Re: Review Request 62828: When regenerating keytab files for a service, non-service-specific principals are affected

2017-10-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62828/#review187414 --- Ship it! Ship It! - Nate Cole On Oct. 8, 2017, 7:36 a.m

Re: Review Request 62808: hadooplzo package installation failed on devdeploys

2017-10-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62808/#review187402 --- Ship it! Ship It! - Nate Cole On Oct. 6, 2017, 9:39 a.m

Re: Review Request 62794: CURRENT cluster Shows Upgrade If Component Didn't Report Version

2017-10-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62794/#review187263 --- Ship it! Ship It! - Nate Cole On Oct. 5, 2017, 11:16 p.m

Re: Review Request 62785: Hitting pause during upgrade jumps progress to 100%

2017-10-05 Thread Nate Cole
's how CalculatedStatus does it too. - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62785/#review187184 --- On Oct. 5, 2017, 9:01 a.m., Nate Cole wrote: > > -

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/#review187170 --- Ship it! Ship It! - Nate Cole On Oct. 4, 2017, 10:32 a.m

Re: Review Request 62622: AMBARI-22016 - changeToSecureUid.sh might collide with existing user if it is not a local user

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62622/#review187105 --- Ship it! Ship It! - Nate Cole On Sept. 27, 2017, 1:22 p.m

Re: Review Request 62656: When the cluster is kerberoed, the config's group of hbase and kafka is root, Maybe should be user.group be better.

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62656/#review187103 --- Are there any tests covering this? - Nate Cole On Sept. 28

Re: Review Request 62656: When the cluster is kerberoed, the config's group of hbase and kafka is root, Maybe should be user.group be better.

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62656/#review187104 --- Ship it! Ship It! - Nate Cole On Sept. 28, 2017, 5:05 a.m

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Nate Cole
ou run this through CI in order to make sure acceptance tests won't go crazy. ambari-common/src/main/python/resource_management/core/providers/package/apt.py Lines 351 (patched) <https://reviews.apache.org/r/62764/#comment264034> This % syntax is old, we typically use string.format()

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62757/#review187096 --- Ship it! Ship It! - Nate Cole On Oct. 4, 2017, 9:19 a.m

Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/#review187088 --- Ship it! Ship It! - Nate Cole On Oct. 3, 2017, 5:11 p.m

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-03 Thread Nate Cole
c would be helpful ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java Lines 227-231 (patched) <https://reviews.apache.org/r/62744/#comment263935> nit: formatting is a bit off - Nate Cole On Oct. 3, 2017, 7:01 a

Review Request 62726: Some ResourceProviders Are Not Transactional

2017-10-02 Thread Nate Cole
/server/controller/internal/DefaultProviderModule.java 781b01525f ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 63e6c24fc8 Diff: https://reviews.apache.org/r/62726/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate

Re: Review Request 62718: Refactor existing server side actions to use the common AbstractUpgradeServerAction

2017-10-02 Thread Nate Cole
/ambari/server/serveraction/upgrades/FixCapacitySchedulerOrderingPolicy.java Lines 65-66 (original), 57-58 (patched) <https://reviews.apache.org/r/62718/#comment263682> This pattern is repeated. Can make a "getCluster()" in the abstract. - Nate Cole On Oct. 1, 2017, 4

Re: Review Request 62719: Upgrades Do Not Finalize If Other Host Versions Are Out of Sync

2017-10-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62719/#review186840 --- Ship it! Ship It! - Nate Cole On Oct. 1, 2017, 7:43 p.m

Re: Review Request 62675: Wrong Hadoop Home Directory Is Being Picked Up on MAINT/PATCH Upgraded Clusters

2017-09-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62675/#review186678 --- Ship it! Ship It! - Nate Cole On Sept. 28, 2017, 2:27 p.m

Re: Review Request 62675: Wrong Hadoop Home Directory Is Being Picked Up on MAINT/PATCH Upgraded Clusters

2017-09-29 Thread Nate Cole
wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62675/ > --- > > (Updated Sept. 28, 2017, 2:27 p.m.) > &

Re: Review Request 62619: Use A Scoped Repo When Installing stack-tools

2017-09-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62619/#review186441 --- Ship it! Ship It! - Nate Cole On Sept. 27, 2017, 11:57 a.m

Re: Review Request 62571: Fail to restart Ranger Admin during HDP downgrade.

2017-09-26 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62571/#review186317 --- Ship it! Ship It! - Nate Cole On Sept. 26, 2017, 11:58 a.m

Review Request 62578: Stack selection page does not load the HDP stacks (Redux)

2017-09-26 Thread Nate Cole
/org/apache/ambari/server/api/services/AmbariMetaInfo.java d03081f48d ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java e201e570ee Diff: https://reviews.apache.org/r/62578/diff/1/ Testing --- Manual. Automated pending (no new tests) Thanks, Nate Cole

Re: Review Request 62571: Fail to restart Ranger Admin during HDP downgrade.

2017-09-26 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62571/#review186249 --- Ship it! Ship It! - Nate Cole On Sept. 26, 2017, 9:18 a.m

Review Request 62550: Patch upgrade is going into incorrect state during package installation with invalid VDF

2017-09-25 Thread Nate Cole
/controller/internal/ClusterStackVersionResourceProviderTest.java 7ad3a87db5 Diff: https://reviews.apache.org/r/62550/diff/1/ Testing --- Manual. Unit tests pending. Thanks, Nate Cole

Re: Review Request 62545: VDFs Which Are Correct Never Get Resolved

2017-09-25 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62545/#review186135 --- Ship it! Ship It! - Nate Cole On Sept. 25, 2017, 12:25 p.m

Review Request 62468: OOZIE/OOZIE_SERVER restart failed saying AttributeError: 'NoneType' object has no attribute 'upper' during EU

2017-09-21 Thread Nate Cole
tests: -- Total run:1192 Total errors:0 Total failures:0 Thanks, Nate Cole

Re: Review Request 62449: Kerberos identity references should use the "reference" attribute

2017-09-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62449/#review185899 --- Ship it! Ship It! - Nate Cole On Sept. 21, 2017, 7:56 a.m

Re: Review Request 62465: AMBARI-22025. Service auto start broken due to incomplete execution command

2017-09-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62465/#review185898 --- Ship it! Any new tests required? - Nate Cole On Sept. 21

Review Request 62454: Could not copy tez tarball to HDFS during prepare upgrade (EU)

2017-09-20 Thread Nate Cole
Testing --- Manual EU including Tez succeeded. We have no direct tests of copy_tarballs so only manual verification. Thanks, Nate Cole

Re: Review Request 62452: Incorrect symlink for storm after patch upgrade

2017-09-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62452/#review185821 --- Ship it! Ship It! - Nate Cole On Sept. 20, 2017, 3:53 p.m

Re: Review Request 62448: Addition of service component after patching a service still keeps the component at base version

2017-09-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62448/#review185820 --- Ship it! Ship It! - Nate Cole On Sept. 20, 2017, 1:20 p.m

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-20 Thread Nate Cole
ted e-mail. To reply, visit: > https://reviews.apache.org/r/62413/ > --- > > (Updated Sept. 19, 2017, 12:17 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-21998 > https://

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Nate Cole
. - Nate Cole On Sept. 19, 2017, 12:17 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Nate Cole
/state/UpgradeHelper.java Lines 1194-1201 (patched) <https://reviews.apache.org/r/62414/#comment262108> nit: formatting - Nate Cole On Sept. 19, 2017, 1:38 p.m., Jonathan Hurley wrote: > > --- > This is an automatica

Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62412/#review185708 --- Ship it! Ship It! - Nate Cole On Sept. 19, 2017, 11:54 a.m

Review Request 62410: Revise log message for component version not found

2017-09-19 Thread Nate Cole
/libraries/script/script.py db7e116c88 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 1d0c44c753 Diff: https://reviews.apache.org/r/62410/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

2017-09-15 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/#review185494 --- Ship it! Ship It! - Nate Cole On Sept. 15, 2017, 11:58 a.m

Review Request 62354: Exception was thrown while starting Patch Rolling/Express Upgrade when upgrade failure tolerance option is selected

2017-09-15 Thread Nate Cole
/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 5dfbc53b8f Diff: https://reviews.apache.org/r/62354/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

2017-09-15 Thread Nate Cole
/hooks/before-INSTALL/scripts/repo_initialization.py Lines 49 (patched) <https://reviews.apache.org/r/61994/#comment261770> remove print debug statement or use Logger.debug - Nate Cole On Sept. 14, 2017, 6:47 p.m., Vitalyi Brod

Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Nate Cole
/ambari/server/topology/TopologyManager.java 092339bb7a ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java 8d891b9534 Diff: https://reviews.apache.org/r/62331/diff/1/ Testing --- Manual cluster deployment. Automated pending. Thanks, Nate Cole

Re: Review Request 62330: Ambari schema upgrade from any version older than 2.5.1 fails due to incorrect version check

2017-09-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62330/#review185410 --- Ship it! Ship It! - Nate Cole On Sept. 14, 2017, 9:43 a.m

Re: Review Request 60358: Hivesevers's status shows issue for the thrift's port conflict, when hiveservers and spark thrift server installed in the same host.

2017-09-13 Thread Nate Cole
> On Sept. 12, 2017, 10:23 a.m., Nate Cole wrote: > > What is the status of this review? Ping - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60358/#rev

Re: Review Request 62291: Last Run Service Check for SPARK Picks up SPARK2

2017-09-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62291/#review185337 --- Ship it! Ship It! - Nate Cole On Sept. 13, 2017, 3:15 p.m

Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

2017-09-13 Thread Nate Cole
--- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 62259: Upgrade to IOP 4.2.5 from IOP 4.1 failed with combined Solr host names longer than item_text column size in table upgrade_item

2017-09-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62259/#review185307 --- Ship it! Ship It! - Nate Cole On Sept. 12, 2017, 9:03 p.m

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

2017-09-13 Thread Nate Cole
eviews.apache.org/r/62258/#review185295 --- On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

2017-09-13 Thread Nate Cole
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62258/#review185284 --- On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote: > > -

Re: Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

2017-09-13 Thread Nate Cole
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62258/#review185235 --- On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote: > > --- > Thi

Review Request 62258: Stack selection page does not load the HDP stacks [Intermittent]

2017-09-12 Thread Nate Cole
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java PRE-CREATION Diff: https://reviews.apache.org/r/62258/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 62245: Auto fix enhancement to remove more than 1 selected configs

2017-09-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62245/#review185214 --- Ship it! Ship It! - Nate Cole On Sept. 12, 2017, 10:28 a.m

Re: Review Request 62245: Auto fix enhancement to remove more than 1 selected configs

2017-09-12 Thread Nate Cole
/DatabaseConsistencyCheckHelper.java Lines 415-449 (patched) <https://reviews.apache.org/r/62245/#comment261499> +1 for this. Fix-then-ship - Nate Cole On Sept. 12, 2017, 10:28 a.m., Dmitro Lisnichenko

Re: Review Request 60358: Hivesevers's status shows issue for the thrift's port conflict, when hiveservers and spark thrift server installed in the same host.

2017-09-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60358/#review185187 --- What is the status of this review? - Nate Cole On June 22

Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users

2017-09-12 Thread Nate Cole
this review. Thanks! - Nate Cole On Aug. 7, 2017, 6:45 a.m., Aman Poonia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62216: Allow SERVER Type Alerts To Run For Any Service/Component

2017-09-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62216/#review185107 --- Ship it! Ship It! - Nate Cole On Sept. 11, 2017, 11:15 a.m

Re: Review Request 62226: Use Correct Packages For Clients Where Stack Tools Support It

2017-09-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62226/#review185105 --- Ship it! Ship It! - Nate Cole On Sept. 11, 2017, 3:43 p.m

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

2017-09-08 Thread Nate Cole
;component" if passed, otherwise "main" ? - Nate Cole On Sept. 7, 2017, 4:40 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

2017-09-08 Thread Nate Cole
to this or just stack-(service-)wise changes? ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml Line 19 (original), 19 (patched) <https://reviews.apache.org/r/61994/#comment261194> Are we sure we should be changing this to the public json file? - Nate Cole On Sept. 7

Re: Review Request 62167: Consider Not Scheduling ConfigureAction Tasks During PATCH/MAINT Upgrades

2017-09-07 Thread Nate Cole
-CREATION Diff: https://reviews.apache.org/r/62167/diff/2/ Changes: https://reviews.apache.org/r/62167/diff/1-2/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 62167: Consider Not Scheduling ConfigureAction Tasks During PATCH/MAINT Upgrades

2017-09-07 Thread Nate Cole
ated e-mail. To reply, visit: https://reviews.apache.org/r/62167/#review184849 --- On Sept. 7, 2017, 1:52 p.m., Nate Cole wrote: > > --- > This is a

Review Request 62167: Consider Not Scheduling ConfigureAction Tasks During PATCH/MAINT Upgrades

2017-09-07 Thread Nate Cole
. Thanks, Nate Cole

Re: Review Request 62128: PATCH and MAINT Repositories Should Indicate that they can be Reverted

2017-09-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62128/#review184736 --- Ship it! Ship It! - Nate Cole On Sept. 6, 2017, 2:34 p.m

Review Request 62130: Upgrades: Ranger & KMS should be stopped before backup

2017-09-06 Thread Nate Cole
, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.531 s - in org.apache.ambari.server.state.stack.UpgradePackParsingTest [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 Thanks, Nate Cole

<    1   2   3   4   5   6   7   8   9   >