---
Manual testing: installed cluster (no LZO) including Tez, HDFS, Oozie. Manually
added LZO libraries, changed confs, restarted and service check. All green.
Unit tests: pending
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63595/#review190312
---
Ship it!
Ship It!
- Nate Cole
On Nov. 6, 2017, 4:17 p.m
/ODPi/2.0/services/HIVE/metainfo.xml
5d1c8980cb
Diff: https://reviews.apache.org/r/63593/diff/1/
Testing
---
Manual. Unit tests pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63537/#review190031
---
Ship it!
Ship It!
- Nate Cole
On Nov. 3, 2017, 10:10 a.m
cherry pick, don't forget that there is a stack
> > packages under HDP 3.0 in trunk...
To my knowledge, IOP clusters aren't candidates for patching and would never
get this structure. So no.
Ok on 3.0
- Nate
---
/common/test_conf_select.py
92dd634cca
Diff: https://reviews.apache.org/r/63535/diff/1/
Testing
---
Manual. Unit tests pending.
Thanks,
Nate Cole
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
Lines 77-87 (patched)
<https://reviews.apache.org/r/63516/#comment267241>
Recommend Sets.newHashSet(String...) - it's much cleaner looking and avoids
an added static{} block.
- Nate Cole
close this review
and the corresponding jira.
- Nate Cole
On Oct. 12, 2017, 2:20 a.m., Yussuf Shaikh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63330/#review189592
---
Ship it!
Ship It!
- Nate Cole
On Oct. 26, 2017, 10:42 a.m
/VersionDefinitionXml.java
7944de8e8c
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
8433518691
Diff: https://reviews.apache.org/r/63334/diff/1/
Testing
---
Manual. Unit tests pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63305/#review189241
---
Ship it!
Ship It!
- Nate Cole
On Oct. 25, 2017, 3:57 p.m
]
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63297/#review189202
---
Ship it!
Ship It!
- Nate Cole
On Oct. 25, 2017, 10:04 a.m
8433518691
ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java
5141dc0fbf
Diff: https://reviews.apache.org/r/63222/diff/1/
Testing
---
Manual. Unit tests pending.
Thanks,
Nate Cole
someone to do it,
please ask on the JIRA.
- Nate Cole
On Oct. 12, 2017, 2:20 a.m., Yussuf Shaikh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63219/#review188962
---
Ship it!
Ship It!
- Nate Cole
On Oct. 23, 2017, 11:53 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63123/#review188576
---
Ship it!
Ship It!
- Nate Cole
On Oct. 18, 2017, 4:47 p.m
/stack_packages.json
b8655d7729
Diff: https://reviews.apache.org/r/63111/diff/1/
Testing
---
Manual verification.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62923/#review188479
---
Ship it!
Ship It!
- Nate Cole
On Oct. 12, 2017, 2:20 a.m
/ConfigUpgradeValidityTest.java
44f72bd72a
Diff: https://reviews.apache.org/r/63075/diff/1/
Testing
---
Manual. Unit tests pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63044/#review188313
---
Ship it!
Ship It!
- Nate Cole
On Oct. 16, 2017, 5:02 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62982/#review188311
---
Ship it!
Ship It!
- Nate Cole
On Oct. 16, 2017, 4:27 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63032/#review188175
---
Ship it!
Ship It!
- Nate Cole
On Oct. 16, 2017, 12:22 p.m
but Downgrade (DONE)
EU Full through Finalize (DONE)
EU Full but Downgrade (DONE)
EU Patch but Downgrade (DONE)
EU Patch then Finalize (DONE)
EU Patch then Finalize then Revert (DONE)
PENDING Unit tests:
Verify no tests are broken with this change:
Thanks,
Nate Cole
then Finalize (PENDING)
EU Patch then Finalize then Revert (PENDING)
Unit tests:
Verify no tests are broken with this change.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62931/#review188009
---
Ship it!
Ship It!
- Nate Cole
On Oct. 12, 2017, 11:36 a.m
t this point, they would still be the new
> > stack IDs, right?
> >
> > I guess no componenents should be changing this between 3rd and 4th
> > digits anyway. Just wanted to check - if you think this case isn't valid,
> > then drop the issue.
>
> Nate Cole wrote:
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62949/#review187876
---
On Oct. 12, 2017, 4:46 p.m., Nate Cole wrote:
>
>
.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62945/#review187842
---
Ship it!
Ship It!
- Nate Cole
On Oct. 12, 2017, 2:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62934/#review187795
---
Ship it!
Ship It!
- Nate Cole
On Oct. 12, 2017, 9:57 a.m
> On Oct. 12, 2017, 9:01 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> > Lines 217-222 (patched)
> > <https://reviews.apache.org/r/62931/diff/1/?file=1853309#file1853309line217>
> >
> &
/ambari/server/upgrade/UpgradeCatalog260.java
Lines 217-222 (patched)
<https://reviews.apache.org/r/62931/#comment264831>
Should these oddly named FKs go in a try/catch since they're not ALWAYS
present?
- Nate Cole
On Oct. 12, 2017, 8:29 a.m., Dmitro Lisnichenko
between table definitions.
Diffs
-
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4e5f30f405
Diff: https://reviews.apache.org/r/62904/diff/1/
Testing
---
No change to tests at this time.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62894/#review187676
---
Ship it!
Ship It!
- Nate Cole
On Oct. 11, 2017, 10:45 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62890/#review187656
---
Ship it!
Ship It!
- Nate Cole
On Oct. 11, 2017, 9:54 a.m
/state/repository/VersionDefinitionXml.java
Lines 343-344 (patched)
<https://reviews.apache.org/r/62871/#comment264607>
Ewww
- Nate Cole
On Oct. 10, 2017, 4:42 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automati
- there's no other code after
that.
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62851/#review187486
---
On Oct. 9, 2017, 5:19 p.m., Nate Cole wrote:
>
> ---
---
Manual added host and added new service to verify records. Unit tests pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62848/#review187444
---
Ship it!
Ship It!
- Nate Cole
On Oct. 9, 2017, 3:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62828/#review187414
---
Ship it!
Ship It!
- Nate Cole
On Oct. 8, 2017, 7:36 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62808/#review187402
---
Ship it!
Ship It!
- Nate Cole
On Oct. 6, 2017, 9:39 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62794/#review187263
---
Ship it!
Ship It!
- Nate Cole
On Oct. 5, 2017, 11:16 p.m
's how CalculatedStatus does it too.
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62785/#review187184
---
On Oct. 5, 2017, 9:01 a.m., Nate Cole wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62764/#review187170
---
Ship it!
Ship It!
- Nate Cole
On Oct. 4, 2017, 10:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62622/#review187105
---
Ship it!
Ship It!
- Nate Cole
On Sept. 27, 2017, 1:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62656/#review187103
---
Are there any tests covering this?
- Nate Cole
On Sept. 28
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62656/#review187104
---
Ship it!
Ship It!
- Nate Cole
On Sept. 28, 2017, 5:05 a.m
ou run this through CI in order to make sure
acceptance tests won't go crazy.
ambari-common/src/main/python/resource_management/core/providers/package/apt.py
Lines 351 (patched)
<https://reviews.apache.org/r/62764/#comment264034>
This % syntax is old, we typically use string.format()
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187096
---
Ship it!
Ship It!
- Nate Cole
On Oct. 4, 2017, 9:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62754/#review187088
---
Ship it!
Ship It!
- Nate Cole
On Oct. 3, 2017, 5:11 p.m
c would be helpful
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
Lines 227-231 (patched)
<https://reviews.apache.org/r/62744/#comment263935>
nit: formatting is a bit off
- Nate Cole
On Oct. 3, 2017, 7:01 a
/server/controller/internal/DefaultProviderModule.java
781b01525f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
63e6c24fc8
Diff: https://reviews.apache.org/r/62726/diff/1/
Testing
---
Manual. Automated pending.
Thanks,
Nate
/ambari/server/serveraction/upgrades/FixCapacitySchedulerOrderingPolicy.java
Lines 65-66 (original), 57-58 (patched)
<https://reviews.apache.org/r/62718/#comment263682>
This pattern is repeated. Can make a "getCluster()" in the abstract.
- Nate Cole
On Oct. 1, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62719/#review186840
---
Ship it!
Ship It!
- Nate Cole
On Oct. 1, 2017, 7:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62675/#review186678
---
Ship it!
Ship It!
- Nate Cole
On Sept. 28, 2017, 2:27 p.m
wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62675/
> ---
>
> (Updated Sept. 28, 2017, 2:27 p.m.)
>
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62619/#review186441
---
Ship it!
Ship It!
- Nate Cole
On Sept. 27, 2017, 11:57 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62571/#review186317
---
Ship it!
Ship It!
- Nate Cole
On Sept. 26, 2017, 11:58 a.m
/org/apache/ambari/server/api/services/AmbariMetaInfo.java
d03081f48d
ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java
e201e570ee
Diff: https://reviews.apache.org/r/62578/diff/1/
Testing
---
Manual. Automated pending (no new tests)
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62571/#review186249
---
Ship it!
Ship It!
- Nate Cole
On Sept. 26, 2017, 9:18 a.m
/controller/internal/ClusterStackVersionResourceProviderTest.java
7ad3a87db5
Diff: https://reviews.apache.org/r/62550/diff/1/
Testing
---
Manual. Unit tests pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62545/#review186135
---
Ship it!
Ship It!
- Nate Cole
On Sept. 25, 2017, 12:25 p.m
tests:
--
Total run:1192
Total errors:0
Total failures:0
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62449/#review185899
---
Ship it!
Ship It!
- Nate Cole
On Sept. 21, 2017, 7:56 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62465/#review185898
---
Ship it!
Any new tests required?
- Nate Cole
On Sept. 21
Testing
---
Manual EU including Tez succeeded. We have no direct tests of copy_tarballs so
only manual verification.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62452/#review185821
---
Ship it!
Ship It!
- Nate Cole
On Sept. 20, 2017, 3:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62448/#review185820
---
Ship it!
Ship It!
- Nate Cole
On Sept. 20, 2017, 1:20 p.m
ted e-mail. To reply, visit:
> https://reviews.apache.org/r/62413/
> ---
>
> (Updated Sept. 19, 2017, 12:17 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21998
> https://
.
- Nate Cole
On Sept. 19, 2017, 12:17 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/state/UpgradeHelper.java
Lines 1194-1201 (patched)
<https://reviews.apache.org/r/62414/#comment262108>
nit: formatting
- Nate Cole
On Sept. 19, 2017, 1:38 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/#review185708
---
Ship it!
Ship It!
- Nate Cole
On Sept. 19, 2017, 11:54 a.m
/libraries/script/script.py
db7e116c88
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
1d0c44c753
Diff: https://reviews.apache.org/r/62410/diff/1/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61994/#review185494
---
Ship it!
Ship It!
- Nate Cole
On Sept. 15, 2017, 11:58 a.m
/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
5dfbc53b8f
Diff: https://reviews.apache.org/r/62354/diff/1/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
/hooks/before-INSTALL/scripts/repo_initialization.py
Lines 49 (patched)
<https://reviews.apache.org/r/61994/#comment261770>
remove print debug statement or use Logger.debug
- Nate Cole
On Sept. 14, 2017, 6:47 p.m., Vitalyi Brod
/ambari/server/topology/TopologyManager.java
092339bb7a
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
8d891b9534
Diff: https://reviews.apache.org/r/62331/diff/1/
Testing
---
Manual cluster deployment. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62330/#review185410
---
Ship it!
Ship It!
- Nate Cole
On Sept. 14, 2017, 9:43 a.m
> On Sept. 12, 2017, 10:23 a.m., Nate Cole wrote:
> > What is the status of this review?
Ping
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60358/#rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62291/#review185337
---
Ship it!
Ship It!
- Nate Cole
On Sept. 13, 2017, 3:15 p.m
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62259/#review185307
---
Ship it!
Ship It!
- Nate Cole
On Sept. 12, 2017, 9:03 p.m
eviews.apache.org/r/62258/#review185295
---
On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To re
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62258/#review185284
---
On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote:
>
> -
automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62258/#review185235
---
On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote:
>
> ---
> Thi
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java
PRE-CREATION
Diff: https://reviews.apache.org/r/62258/diff/1/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62245/#review185214
---
Ship it!
Ship It!
- Nate Cole
On Sept. 12, 2017, 10:28 a.m
/DatabaseConsistencyCheckHelper.java
Lines 415-449 (patched)
<https://reviews.apache.org/r/62245/#comment261499>
+1 for this. Fix-then-ship
- Nate Cole
On Sept. 12, 2017, 10:28 a.m., Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60358/#review185187
---
What is the status of this review?
- Nate Cole
On June 22
this review. Thanks!
- Nate Cole
On Aug. 7, 2017, 6:45 a.m., Aman Poonia wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62216/#review185107
---
Ship it!
Ship It!
- Nate Cole
On Sept. 11, 2017, 11:15 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62226/#review185105
---
Ship it!
Ship It!
- Nate Cole
On Sept. 11, 2017, 3:43 p.m
;component" if passed, otherwise "main" ?
- Nate Cole
On Sept. 7, 2017, 4:40 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply
to this or just
stack-(service-)wise changes?
ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml
Line 19 (original), 19 (patched)
<https://reviews.apache.org/r/61994/#comment261194>
Are we sure we should be changing this to the public json file?
- Nate Cole
On Sept. 7
-CREATION
Diff: https://reviews.apache.org/r/62167/diff/2/
Changes: https://reviews.apache.org/r/62167/diff/1-2/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
ated e-mail. To reply, visit:
https://reviews.apache.org/r/62167/#review184849
---
On Sept. 7, 2017, 1:52 p.m., Nate Cole wrote:
>
> ---
> This is a
.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62128/#review184736
---
Ship it!
Ship It!
- Nate Cole
On Sept. 6, 2017, 2:34 p.m
, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.531 s
- in org.apache.ambari.server.state.stack.UpgradePackParsingTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Nate Cole
101 - 200 of 891 matches
Mail list logo