Re: Review Request 46016: AMBARI-15752 Ambari support for additional config params for Ranger KMS to support HSM

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/
---

(Updated April 15, 2016, 5:34 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, 
Jayush Luniya, and Velmurugan Periasamy.


Changes
---

Updated patch with changes to avoid plain text in XML file
Ran 253 tests in 7.828s

OK
--
Total run:942
Total errors:0
Total failures:0
OK


Bugs: AMBARI-15752
https://issues.apache.org/jira/browse/AMBARI-15752


Repository: ambari


Description
---

Add HSM support configuration properties for Ranger KMS in hdp-2.5


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 86dbc48 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 7201c36 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 dd91acf 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 fc722da 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 03b7e01 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml
 02fb6aa 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/46016/diff/


Testing
---

Installed Ranger KMS centos6.


Thanks,

Mugdha Varadkar

Review Request 46248: YARN work preserving restart should be recommended and validated to be enabled if Hive interactive mode is turned ON

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46248/
---

Review request for Ambari, Jaimin Jetly and Swapan Shridhar.


Bugs: AMBARI-15904
https://issues.apache.org/jira/browse/AMBARI-15904


Repository: ambari


Description
---

YARN work preserving restart should be recommended and validated to be enabled 
if Hive interactive mode is turned ON


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
7407da3 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py c21bad7 

Diff: https://reviews.apache.org/r/46248/diff/


Testing
---

Unit tests ran successfully and verified by applying on a running cluster. 
Image attached to the JIRA.


Thanks,

Sumit Mohanty

Review Request 46247: AMBARI-15903 Script + Server alert display, descriptions and ui

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46247/
---

Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15903
https://issues.apache.org/jira/browse/AMBARI-15903


Repository: ambari


Description
---

1) Some are showing params that should be hidden
2) Some need new display labels
3) Some need hover tooltip description text
4) Some need alert description tweaks
5) In the hive alerts, some of those params, missing thresholds


Diffs
-

  ambari-server/src/main/resources/alerts.json 0bbd004 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 
4dc52a2 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 
1f86e57 
  ambari-web/app/controllers/main/alerts/definition_configs_controller.js 
9dc4f92 
  ambari-web/app/models/alerts/alert_definition.js 245771e 

Diff: https://reviews.apache.org/r/46247/diff/


Testing
---

ambari-server:
All alert unit test passed.
mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false
ambari-web:
All UT passed
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 46226: AMBARI-15899 Alert Check Retries: UX edits v1

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46226/#review129046
---


Ship it!




Ship It!

- Richard Zang


On April 15, 2016, 12:14 a.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46226/
> ---
> 
> (Updated April 15, 2016, 12:14 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15899
> https://issues.apache.org/jira/browse/AMBARI-15899
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change the way to present the relation between global and individual alert 
> check.
> Other UX edits.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 06afa49 
>   ambari-web/app/controllers/global/cluster_controller.js 327bd45 
>   ambari-web/app/controllers/global/update_controller.js e13fe41 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  1712b6f 
>   ambari-web/app/controllers/main/alerts/definition_details_controller.js 
> 8e716bc 
>   ambari-web/app/messages.js 14c957c 
>   ambari-web/app/styles/alerts.less 24b29b2 
>   ambari-web/app/styles/application.less 61ccbfa 
>   ambari-web/app/templates/common/modal_popups/prompt_popup.hbs e1e03fb 
>   ambari-web/app/templates/main/alerts/definition_details.hbs fab41c7 
>   ambari-web/app/views/main/alerts/definition_details_view.js 606c955 
>   ambari-web/test/controllers/global/update_controller_test.js 2c679c6 
>   ambari-web/test/views/main/alerts/definition_details_view_test.js e6b88b6 
> 
> Diff: https://reviews.apache.org/r/46226/diff/
> 
> 
> Testing
> ---
> 
> Modified unit tests.
> Local ambari-web test passed.
> 25683 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46226: AMBARI-15899 Alert Check Retries: UX edits v1

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46226/
---

(Updated April 15, 2016, 12:14 a.m.)


Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15899
https://issues.apache.org/jira/browse/AMBARI-15899


Repository: ambari


Description
---

Change the way to present the relation between global and individual alert 
check.
Other UX edits.


Diffs (updated)
-

  ambari-web/app/config.js 06afa49 
  ambari-web/app/controllers/global/cluster_controller.js 327bd45 
  ambari-web/app/controllers/global/update_controller.js e13fe41 
  
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
1712b6f 
  ambari-web/app/controllers/main/alerts/definition_details_controller.js 
8e716bc 
  ambari-web/app/messages.js 14c957c 
  ambari-web/app/styles/alerts.less 24b29b2 
  ambari-web/app/styles/application.less 61ccbfa 
  ambari-web/app/templates/common/modal_popups/prompt_popup.hbs e1e03fb 
  ambari-web/app/templates/main/alerts/definition_details.hbs fab41c7 
  ambari-web/app/views/main/alerts/definition_details_view.js 606c955 
  ambari-web/test/controllers/global/update_controller_test.js 2c679c6 
  ambari-web/test/views/main/alerts/definition_details_view_test.js e6b88b6 

Diff: https://reviews.apache.org/r/46226/diff/


Testing
---

Modified unit tests.
Local ambari-web test passed.
25683 tests complete (24 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 46172: Pass request object to delete API in resource providers

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46172/#review129039
---


Ship it!




Ship It!

- Jayush Luniya


On April 14, 2016, 4:04 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46172/
> ---
> 
> (Updated April 14, 2016, 4:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15888
> https://issues.apache.org/jira/browse/AMBARI-15888
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently delete API on resource provider only takes predicate. Ideally it 
> should take request object as well which has additional metadata. It will be 
> required in scenarios like dry-run where it can look at request object to 
> figure out if current invocation is for dry run or not and behave accordingly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManagerImpl.java
>  3037446 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerResourceProvider.java
>  d403114 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java
>  0837a5d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
>  faef86c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
>  10eecac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
>  bcf0205 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
>  dafd194 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java
>  f52ee62 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java
>  f19bea9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  3b749d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
>  34952f2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  a4b2aaa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  3e4d7fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java
>  e776b5a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  51c0db9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  a85f939 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  6236ac2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  2677ec7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java
>  f9d12b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java
>  8a3937a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java
>  5087049 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  0d215ae 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
>  39a09a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  322eab8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  b3f353c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java
>  49f968f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java
>  c732842 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java
>  3cece5d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java
>  3d18a27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java
>  307ed3f 
>   
> 

Re: Review Request 46169: Add dryrun method on request object

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46169/#review129037
---


Ship it!




Ship It!

- Jayush Luniya


On April 14, 2016, 2:30 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46169/
> ---
> 
> (Updated April 14, 2016, 2:30 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15870
> https://issues.apache.org/jira/browse/AMBARI-15870
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> To implement dry-run version of an API, request needs to be parsed manually 
> to figure out if request has dry-run directive.
> It will be good to add a method on Request object method itself which 
> centralizes parsing and logic for figuring out dry-run directive
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java
>  12b91e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestImpl.java
>  f27f621 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  f8f8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Request.java
>  50eed9a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
>  93fe36f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  ea4afde 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
>  633815e 
> 
> Diff: https://reviews.apache.org/r/46169/diff/
> 
> 
> Testing
> ---
> 
> Hadoop QA commented on AMBARI-15870:
> 
> 
> {color:green}+1 overall{color}.  Here are the results of testing the latest 
> attachment
>   http://issues.apache.org/jira/secure/attachment/12798670/rb46169.patch
>   against trunk revision .
> 
> {color:green}+1 @author{color}.  The patch does not contain any @author 
> tags.
> 
> {color:green}+1 tests included{color}.  The patch appears to include 3 
> new or modified test files.
> 
> {color:green}+1 javac{color}.  The applied patch does not increase the 
> total number of javac compiler warnings.
> 
> {color:green}+1 release audit{color}.  The applied patch does not 
> increase the total number of release audit warnings.
> 
> {color:green}+1 core tests{color}.  The patch passed unit tests in 
> ambari-server.
> 
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6435//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6435//console
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46170/
---

(Updated April 15, 2016, 12:05 a.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, 
jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.


Bugs: AMBARI-15794
https://issues.apache.org/jira/browse/AMBARI-15794


Repository: ambari


Description
---

Steps to reproduce:

Install HAWQ with HAWQSEGMENT on the same host as HAWQMASTER
Segment registration would show an alert saying that localhost is not 
registered.

localhost is returned by gp_segment_configuration for that HAWQSEGMENT, but in 
the slaves file, there is no entry 'localhost'


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
 4d09763 

Diff: https://reviews.apache.org/r/46170/diff/


Testing (updated)
---

Manually tested.

--
Ran 246 tests in 7.230s

OK
--
Total run:925
Total errors:0
Total failures:0
OK


Thanks,

Lav Jain

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/
---

(Updated April 15, 2016, midnight)


Review request for Ambari.


Bugs: AMBARI-15852
https://issues.apache.org/jira/browse/AMBARI-15852


Repository: ambari


Description
---

HAWQ restart after port change will fail because Ambari looks for a currently 
running process with a new port number.
This change is to make Ambari to look for an older port value.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 413cf1a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
 3f6c371 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
 f2ec914 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
 636dcad 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 67d1cb0 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 92ac0af 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
 0baa4c5 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_utils.py PRE-CREATION 

Diff: https://reviews.apache.org/r/46186/diff/


Testing (updated)
---

Unit test has passed.
--
Ran 277 tests in 8.851s

OK
--
Total run:957
Total errors:0
Total failures:0
OK

Manual Test in progress.


Thanks,

jun aoki

Review Request 46238: Refactor Metadata manager for supporting distributed collector

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46238/
---

Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-15902
https://issues.apache.org/jira/browse/AMBARI-15902


Repository: ambari


Description
---

Presently metadata is served from a write through cache, we need a bounded 
cache that gets refreshed periodically to allow sharded writes to succeed.

Additionally the metadata cache needs ability to skip certain metrics, example: 
YARN Container metrics with too many unique names using a config.


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 5b517ef 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java
 8e58203 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataSync.java
 54ea200 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataManager.java
 bf887be 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataSync.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 ddaff84 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 e5758bf 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2
 6f32000 

Diff: https://reviews.apache.org/r/46238/diff/


Testing
---

All metrics Unit tests passed.


Thanks,

Sid Wagle

Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

[Goutam Tadi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46170/#review129033
---


Ship it!




Ship It!

- Goutam Tadi


On April 14, 2016, 11:52 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46170/
> ---
> 
> (Updated April 14, 2016, 11:52 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15794
> https://issues.apache.org/jira/browse/AMBARI-15794
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 
> Install HAWQ with HAWQSEGMENT on the same host as HAWQMASTER
> Segment registration would show an alert saying that localhost is not 
> registered.
> 
> localhost is returned by gp_segment_configuration for that HAWQSEGMENT, but 
> in the slaves file, there is no entry 'localhost'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
>  4d09763 
> 
> Diff: https://reviews.apache.org/r/46170/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Lav Jain
> 
>

Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46170/
---

(Updated April 14, 2016, 11:52 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, 
jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.


Bugs: AMBARI-15794
https://issues.apache.org/jira/browse/AMBARI-15794


Repository: ambari


Description
---

Steps to reproduce:

Install HAWQ with HAWQSEGMENT on the same host as HAWQMASTER
Segment registration would show an alert saying that localhost is not 
registered.

localhost is returned by gp_segment_configuration for that HAWQSEGMENT, but in 
the slaves file, there is no entry 'localhost'


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
 4d09763 

Diff: https://reviews.apache.org/r/46170/diff/


Testing
---

Manually tested.


Thanks,

Lav Jain

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

> On April 14, 2016, 11 p.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py,
> >  line 26
> > 
> >
> > do we need unit test for this function ?

will add unit test.


> On April 14, 2016, 11 p.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py,
> >  line 46
> > 
> >
> > variable is not used anywhere else other than the line below, can 
> > probably inline it for brevity

will do


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review129024
---


On April 14, 2016, 9:20 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 9:20 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  3f6c371 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review129024
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 (line 31)


variable is not used anywhere else other than the line below, can probably 
inline it for brevity



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
 (line 26)


do we need unit test for this function ?


- Alexander Denissov


On April 14, 2016, 9:20 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 9:20 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  3f6c371 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46226: AMBARI-15899 Alert Check Retries: UX edits v1

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46226/#review129014
---




ambari-web/app/controllers/main/alerts/definition_details_controller.js (line 
301)


Hide tooltip instead of removing the dom.


- Richard Zang


On April 14, 2016, 10:12 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46226/
> ---
> 
> (Updated April 14, 2016, 10:12 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15899
> https://issues.apache.org/jira/browse/AMBARI-15899
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change the way to present the relation between global and individual alert 
> check.
> Other UX edits.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 06afa49 
>   ambari-web/app/controllers/global/cluster_controller.js 327bd45 
>   ambari-web/app/controllers/global/update_controller.js e13fe41 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  1712b6f 
>   ambari-web/app/controllers/main/alerts/definition_details_controller.js 
> 8e716bc 
>   ambari-web/app/messages.js 14c957c 
>   ambari-web/app/styles/alerts.less 24b29b2 
>   ambari-web/app/styles/application.less 61ccbfa 
>   ambari-web/app/templates/common/modal_popups/prompt_popup.hbs e1e03fb 
>   ambari-web/app/templates/main/alerts/definition_details.hbs fab41c7 
>   ambari-web/app/views/main/alerts/definition_details_view.js 606c955 
>   ambari-web/test/controllers/global/update_controller_test.js 2c679c6 
>   ambari-web/test/views/main/alerts/definition_details_view_test.js e6b88b6 
> 
> Diff: https://reviews.apache.org/r/46226/diff/
> 
> 
> Testing
> ---
> 
> Modified unit tests.
> Local ambari-web test passed.
> 25683 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Review Request 46226: AMBARI-15899 Alert Check Retries: UX edits v1

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46226/
---

Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15899
https://issues.apache.org/jira/browse/AMBARI-15899


Repository: ambari


Description
---

Change the way to present the relation between global and individual alert 
check.
Other UX edits.


Diffs
-

  ambari-web/app/config.js 06afa49 
  ambari-web/app/controllers/global/cluster_controller.js 327bd45 
  ambari-web/app/controllers/global/update_controller.js e13fe41 
  
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
1712b6f 
  ambari-web/app/controllers/main/alerts/definition_details_controller.js 
8e716bc 
  ambari-web/app/messages.js 14c957c 
  ambari-web/app/styles/alerts.less 24b29b2 
  ambari-web/app/styles/application.less 61ccbfa 
  ambari-web/app/templates/common/modal_popups/prompt_popup.hbs e1e03fb 
  ambari-web/app/templates/main/alerts/definition_details.hbs fab41c7 
  ambari-web/app/views/main/alerts/definition_details_view.js 606c955 
  ambari-web/test/controllers/global/update_controller_test.js 2c679c6 
  ambari-web/test/views/main/alerts/definition_details_view_test.js e6b88b6 

Diff: https://reviews.apache.org/r/46226/diff/


Testing
---

Modified unit tests.
Local ambari-web test passed.
25683 tests complete (24 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128998
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 14, 2016, 9:20 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 9:20 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  3f6c371 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/#review128996
---


Ship it!




Ship It!

- Jaimin Jetly


On April 14, 2016, 8:56 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46219/
> ---
> 
> (Updated April 14, 2016, 8:56 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
> Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15892
> https://issues.apache.org/jira/browse/AMBARI-15892
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue
> In the "NameNode HostLoad" graph, the negative values are seen for the 
> computed metric "Memory Utilization" which goes by the formula :
> ( mem_total - (mem_free + mem_cache) ) *100 / mem_total
> 
> Bug
> AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
> lead to a double subtraction of mem_cached, thereby leading to a negative 
> value intermittently.
> 
> Fix
> Change the widget to :
> ( mem_total - mem_free ) *100 / mem_total
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  0476326 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> 0f8f105 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> a19a112 
> 
> Diff: https://reviews.apache.org/r/46219/diff/
> 
> 
> Testing
> ---
> 
> Unit tests pass. 
> 
> Manual widget testing done.
> 
> Manual upgrade testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/
---

(Updated April 14, 2016, 9:20 p.m.)


Review request for Ambari.


Changes
---

Added missing import.


Bugs: AMBARI-15852
https://issues.apache.org/jira/browse/AMBARI-15852


Repository: ambari


Description
---

HAWQ restart after port change will fail because Ambari looks for a currently 
running process with a new port number.
This change is to make Ambari to look for an older port value.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 413cf1a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
 3f6c371 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
 f2ec914 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
 636dcad 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 67d1cb0 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 92ac0af 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
 0baa4c5 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 

Diff: https://reviews.apache.org/r/46186/diff/


Testing
---

Unit test has passed.
Manual Test in progress.


Thanks,

jun aoki

Review Request 46225: Change HDP-2.5 Hive Theme to be extended from the base theme

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46225/
---

Review request for Ambari, Richard Zang, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-15897
https://issues.apache.org/jira/browse/AMBARI-15897


Repository: ambari


Description
---

The absolute theme for Hive should be replaced with extended theme. This was 
not possible uptil now due to 
https://issues.apache.org/jira/browse/AMBARI-15860 issue which has been 
recently resolved.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml 
63ef567 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme_version_2.json
 64450a8 

Diff: https://reviews.apache.org/r/46225/diff/


Testing
---

Manually verified that the patch works.


Thanks,

Jaimin Jetly

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

[Aravindan Vijayan]

> On April 14, 2016, 8:28 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json,
> >  lines 201-205
> > 
> >
> > Lets remove this mem_cached entry if it is not being used as part of 
> > the equation of the Memory Utlization. Otherwise UI will keep polling for 
> > it even if it is now not being used in the formula

Fixed the issue. Can you mark Ship It if the changes look ok?


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/#review128977
---


On April 14, 2016, 8:56 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46219/
> ---
> 
> (Updated April 14, 2016, 8:56 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
> Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15892
> https://issues.apache.org/jira/browse/AMBARI-15892
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue
> In the "NameNode HostLoad" graph, the negative values are seen for the 
> computed metric "Memory Utilization" which goes by the formula :
> ( mem_total - (mem_free + mem_cache) ) *100 / mem_total
> 
> Bug
> AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
> lead to a double subtraction of mem_cached, thereby leading to a negative 
> value intermittently.
> 
> Fix
> Change the widget to :
> ( mem_total - mem_free ) *100 / mem_total
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  0476326 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> 0f8f105 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> a19a112 
> 
> Diff: https://reviews.apache.org/r/46219/diff/
> 
> 
> Testing
> ---
> 
> Unit tests pass. 
> 
> Manual widget testing done.
> 
> Manual upgrade testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 46221: RU/EU: Unable to start upgrade with host in MM

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46221/#review128986
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 14, 2016, 8:13 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46221/
> ---
> 
> (Updated April 14, 2016, 8:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-15896
> https://issues.apache.org/jira/browse/AMBARI-15896
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> # Install cluster (e.g HDP  2.3.0.0-2557). One of the hosts should consists 
> from only slaves and clients components (including Phoenix query server)
> # Register and install new stack version (e.g 2.4.2.0-195)
> # Stop ambari-agent on host without masters 
> # Turn on Maintenance Mode for this host
> # Try to start upgrade.
> Result: PHOENIX_QUERY_SERVER is in UNKNOWN state on Maintenance Mode host is 
> preventing upgrade.
> 
> The problem here is that the ServicesUpCheck does not take MM into account.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  09ad55d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  2153113 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/models/HostComponentSummary.java
>  c79ec8a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  caab7df 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java
>  88826a0 
> 
> Diff: https://reviews.apache.org/r/46221/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/
---

(Updated April 14, 2016, 8:56 p.m.)


Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
Mohanty, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-15892
https://issues.apache.org/jira/browse/AMBARI-15892


Repository: ambari


Description
---

Issue
In the "NameNode HostLoad" graph, the negative values are seen for the computed 
metric "Memory Utilization" which goes by the formula :
( mem_total - (mem_free + mem_cache) ) *100 / mem_total

Bug
AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
lead to a double subtraction of mem_cached, thereby leading to a negative value 
intermittently.

Fix
Change the widget to :
( mem_total - mem_free ) *100 / mem_total


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
 0476326 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
0f8f105 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
a19a112 

Diff: https://reviews.apache.org/r/46219/diff/


Testing (updated)
---

Unit tests pass. 

Manual widget testing done.

Manual upgrade testing done.


Thanks,

Aravindan Vijayan

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/#review128977
---




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
(lines 201 - 205)


Lets remove this mem_cached entry if it is not being used as part of the 
equation of the Memory Utlization. Otherwise UI will keep polling for it even 
if it is now not being used in the formula


- Jaimin Jetly


On April 14, 2016, 7:40 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46219/
> ---
> 
> (Updated April 14, 2016, 7:40 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
> Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15892
> https://issues.apache.org/jira/browse/AMBARI-15892
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue
> In the "NameNode HostLoad" graph, the negative values are seen for the 
> computed metric "Memory Utilization" which goes by the formula :
> ( mem_total - (mem_free + mem_cache) ) *100 / mem_total
> 
> Bug
> AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
> lead to a double subtraction of mem_cached, thereby leading to a negative 
> value intermittently.
> 
> Fix
> Change the widget to :
> ( mem_total - mem_free ) *100 / mem_total
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  0476326 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> 0f8f105 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> a19a112 
> 
> Diff: https://reviews.apache.org/r/46219/diff/
> 
> 
> Testing
> ---
> 
> Unit tests pass. 
> 
> Manual widget testing done.
> 
> Manual upgrade testing pending.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128975
---


Ship it!




Ship It!

- bhuvnesh chaudhary


On April 14, 2016, 7:18 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 7:18 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  3f6c371 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Review Request 46221: RU/EU: Unable to start upgrade with host in MM

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46221/
---

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-15896
https://issues.apache.org/jira/browse/AMBARI-15896


Repository: ambari


Description
---

STR:
# Install cluster (e.g HDP  2.3.0.0-2557). One of the hosts should consists 
from only slaves and clients components (including Phoenix query server)
# Register and install new stack version (e.g 2.4.2.0-195)
# Stop ambari-agent on host without masters 
# Turn on Maintenance Mode for this host
# Try to start upgrade.
Result: PHOENIX_QUERY_SERVER is in UNKNOWN state on Maintenance Mode host is 
preventing upgrade.

The problem here is that the ServicesUpCheck does not take MM into account.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 09ad55d 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 2153113 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/models/HostComponentSummary.java
 c79ec8a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 caab7df 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java
 88826a0 

Diff: https://reviews.apache.org/r/46221/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Re: Review Request 46218: AlertReceivedListenerTest is Flaky When Running @Before Code

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46218/#review128968
---


Ship it!




Ship It!

- Sid Wagle


On April 14, 2016, 7:27 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46218/
> ---
> 
> (Updated April 14, 2016, 7:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15895
> https://issues.apache.org/jira/browse/AMBARI-15895
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{AlertReceivedListenerTest}} occasionally fails with:
> 
> ```
> javax.persistence.PersistenceException: 
> Exception [EclipseLink-4002] (Eclipse Persistence Services - 
> 2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
> Internal Exception: java.sql.SQLIntegrityConstraintViolationException: The 
> statement was aborted because it would have caused a duplicate key value in a 
> unique or primary key constraint or unique index identified by 
> 'UNQ_ALERT_GROUP_0' defined on 'ALERT_GROUP'.
> Error Code: 2
> Call: INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
> service_name) VALUES (?, ?, ?, ?, ?)
>   bind => [5 parameters bound]
>   at 
> org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
> Caused by: org.eclipse.persistence.exceptions.DatabaseException: 
> 
> Internal Exception: java.sql.SQLIntegrityConstraintViolationException: The 
> statement was aborted because it would have caused a duplicate key value in a 
> unique or primary key constraint or unique index identified by 
> 'UNQ_ALERT_GROUP_0' defined on 'ALERT_GROUP'.
> Error Code: 2
> Call: INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
> service_name) VALUES (?, ?, ?, ?, ?)
>   bind => [5 parameters bound]
>   at 
> org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
> Caused by: java.sql.SQLIntegrityConstraintViolationException: The statement 
> was aborted because it would have caused a duplicate key value in a unique or 
> primary key constraint or unique index identified by 'UNQ_ALERT_GROUP_0' 
> defined on 'ALERT_GROUP'.
>   at 
> org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
> Caused by: org.apache.derby.impl.jdbc.EmbedSQLException: The statement was 
> aborted because it would have caused a duplicate key value in a unique or 
> primary key constraint or unique index identified by 'UNQ_ALERT_GROUP_0' 
> defined on 'ALERT_GROUP'.
>   at 
> org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
> Caused by: org.apache.derby.iapi.error.StandardException: The statement was 
> aborted because it would have caused a duplicate key value in a unique or 
> primary key constraint or unique index identified by 'UNQ_ALERT_GROUP_0' 
> defined on 'ALERT_GROUP'.
>   at 
> org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
> ```
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 21c5baf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  28aa19a 
> 
> Diff: https://reviews.apache.org/r/46218/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/#review128967
---


Ship it!




Ship It!

- Sid Wagle


On April 14, 2016, 7:40 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46219/
> ---
> 
> (Updated April 14, 2016, 7:40 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
> Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15892
> https://issues.apache.org/jira/browse/AMBARI-15892
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue
> In the "NameNode HostLoad" graph, the negative values are seen for the 
> computed metric "Memory Utilization" which goes by the formula :
> ( mem_total - (mem_free + mem_cache) ) *100 / mem_total
> 
> Bug
> AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
> lead to a double subtraction of mem_cached, thereby leading to a negative 
> value intermittently.
> 
> Fix
> Change the widget to :
> ( mem_total - mem_free ) *100 / mem_total
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  0476326 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> 0f8f105 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> a19a112 
> 
> Diff: https://reviews.apache.org/r/46219/diff/
> 
> 
> Testing
> ---
> 
> Unit tests pass. 
> 
> Manual widget testing done.
> 
> Manual upgrade testing pending.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 46169: Add dryrun method on request object

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46169/#review128965
---


Ship it!




Ship It!

- Nate Cole


On April 14, 2016, 10:30 a.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46169/
> ---
> 
> (Updated April 14, 2016, 10:30 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15870
> https://issues.apache.org/jira/browse/AMBARI-15870
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> To implement dry-run version of an API, request needs to be parsed manually 
> to figure out if request has dry-run directive.
> It will be good to add a method on Request object method itself which 
> centralizes parsing and logic for figuring out dry-run directive
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java
>  12b91e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestImpl.java
>  f27f621 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  f8f8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Request.java
>  50eed9a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
>  93fe36f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  ea4afde 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
>  633815e 
> 
> Diff: https://reviews.apache.org/r/46169/diff/
> 
> 
> Testing
> ---
> 
> Hadoop QA commented on AMBARI-15870:
> 
> 
> {color:green}+1 overall{color}.  Here are the results of testing the latest 
> attachment
>   http://issues.apache.org/jira/secure/attachment/12798670/rb46169.patch
>   against trunk revision .
> 
> {color:green}+1 @author{color}.  The patch does not contain any @author 
> tags.
> 
> {color:green}+1 tests included{color}.  The patch appears to include 3 
> new or modified test files.
> 
> {color:green}+1 javac{color}.  The applied patch does not increase the 
> total number of javac compiler warnings.
> 
> {color:green}+1 release audit{color}.  The applied patch does not 
> increase the total number of release audit warnings.
> 
> {color:green}+1 core tests{color}.  The patch passed unit tests in 
> ambari-server.
> 
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6435//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6435//console
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 46218: AlertReceivedListenerTest is Flaky When Running @Before Code

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46218/#review128964
---


Ship it!




Ship It!

- Nate Cole


On April 14, 2016, 3:27 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46218/
> ---
> 
> (Updated April 14, 2016, 3:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15895
> https://issues.apache.org/jira/browse/AMBARI-15895
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{AlertReceivedListenerTest}} occasionally fails with:
> 
> ```
> javax.persistence.PersistenceException: 
> Exception [EclipseLink-4002] (Eclipse Persistence Services - 
> 2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
> Internal Exception: java.sql.SQLIntegrityConstraintViolationException: The 
> statement was aborted because it would have caused a duplicate key value in a 
> unique or primary key constraint or unique index identified by 
> 'UNQ_ALERT_GROUP_0' defined on 'ALERT_GROUP'.
> Error Code: 2
> Call: INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
> service_name) VALUES (?, ?, ?, ?, ?)
>   bind => [5 parameters bound]
>   at 
> org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
> Caused by: org.eclipse.persistence.exceptions.DatabaseException: 
> 
> Internal Exception: java.sql.SQLIntegrityConstraintViolationException: The 
> statement was aborted because it would have caused a duplicate key value in a 
> unique or primary key constraint or unique index identified by 
> 'UNQ_ALERT_GROUP_0' defined on 'ALERT_GROUP'.
> Error Code: 2
> Call: INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
> service_name) VALUES (?, ?, ?, ?, ?)
>   bind => [5 parameters bound]
>   at 
> org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
> Caused by: java.sql.SQLIntegrityConstraintViolationException: The statement 
> was aborted because it would have caused a duplicate key value in a unique or 
> primary key constraint or unique index identified by 'UNQ_ALERT_GROUP_0' 
> defined on 'ALERT_GROUP'.
>   at 
> org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
> Caused by: org.apache.derby.impl.jdbc.EmbedSQLException: The statement was 
> aborted because it would have caused a duplicate key value in a unique or 
> primary key constraint or unique index identified by 'UNQ_ALERT_GROUP_0' 
> defined on 'ALERT_GROUP'.
>   at 
> org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
> Caused by: org.apache.derby.iapi.error.StandardException: The statement was 
> aborted because it would have caused a duplicate key value in a unique or 
> primary key constraint or unique index identified by 'UNQ_ALERT_GROUP_0' 
> defined on 'ALERT_GROUP'.
>   at 
> org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
> ```
> 
> 
> Diffs
> -
> 
>   ambari-project/pom.xml 21c5baf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  28aa19a 
> 
> Diff: https://reviews.apache.org/r/46218/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are shown for memory metrics

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/
---

Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit 
Mohanty, and Sid Wagle.


Bugs: AMBARI-15892
https://issues.apache.org/jira/browse/AMBARI-15892


Repository: ambari


Description
---

Issue
In the "NameNode HostLoad" graph, the negative values are seen for the computed 
metric "Memory Utilization" which goes by the formula :
( mem_total - (mem_free + mem_cache) ) *100 / mem_total

Bug
AMBARI-15448 changed the way memory metrics are being reported to AMS. This 
lead to a double subtraction of mem_cached, thereby leading to a negative value 
intermittently.

Fix
Change the widget to :
( mem_total - mem_free ) *100 / mem_total


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
 0476326 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
0f8f105 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
a19a112 

Diff: https://reviews.apache.org/r/46219/diff/


Testing
---

Unit tests pass. 

Manual widget testing done.

Manual upgrade testing pending.


Thanks,

Aravindan Vijayan

Review Request 46218: AlertReceivedListenerTest is Flaky When Running @Before Code

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46218/
---

Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.


Bugs: AMBARI-15895
https://issues.apache.org/jira/browse/AMBARI-15895


Repository: ambari


Description
---

The {{AlertReceivedListenerTest}} occasionally fails with:

```
javax.persistence.PersistenceException: 
Exception [EclipseLink-4002] (Eclipse Persistence Services - 
2.6.2.v20151217-774c696): org.eclipse.persistence.exceptions.DatabaseException
Internal Exception: java.sql.SQLIntegrityConstraintViolationException: The 
statement was aborted because it would have caused a duplicate key value in a 
unique or primary key constraint or unique index identified by 
'UNQ_ALERT_GROUP_0' defined on 'ALERT_GROUP'.
Error Code: 2
Call: INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
service_name) VALUES (?, ?, ?, ?, ?)
bind => [5 parameters bound]
at 
org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
Caused by: org.eclipse.persistence.exceptions.DatabaseException: 

Internal Exception: java.sql.SQLIntegrityConstraintViolationException: The 
statement was aborted because it would have caused a duplicate key value in a 
unique or primary key constraint or unique index identified by 
'UNQ_ALERT_GROUP_0' defined on 'ALERT_GROUP'.
Error Code: 2
Call: INSERT INTO alert_group (group_id, cluster_id, group_name, is_default, 
service_name) VALUES (?, ?, ?, ?, ?)
bind => [5 parameters bound]
at 
org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
Caused by: java.sql.SQLIntegrityConstraintViolationException: The statement was 
aborted because it would have caused a duplicate key value in a unique or 
primary key constraint or unique index identified by 'UNQ_ALERT_GROUP_0' 
defined on 'ALERT_GROUP'.
at 
org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
Caused by: org.apache.derby.impl.jdbc.EmbedSQLException: The statement was 
aborted because it would have caused a duplicate key value in a unique or 
primary key constraint or unique index identified by 'UNQ_ALERT_GROUP_0' 
defined on 'ALERT_GROUP'.
at 
org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
Caused by: org.apache.derby.iapi.error.StandardException: The statement was 
aborted because it would have caused a duplicate key value in a unique or 
primary key constraint or unique index identified by 'UNQ_ALERT_GROUP_0' 
defined on 'ALERT_GROUP'.
at 
org.apache.ambari.server.state.alerts.AlertReceivedListenerTest.setup(AlertReceivedListenerTest.java:120)
```


Diffs
-

  ambari-project/pom.xml 21c5baf 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
 28aa19a 

Diff: https://reviews.apache.org/r/46218/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Review Request 46217: After adding support for real jdbc jar names, verify the post Ambari upgrade nothing breaks

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46217/
---

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-15894
https://issues.apache.org/jira/browse/AMBARI-15894


Repository: ambari


Description
---

Lets think through the upgrade scenario again:
Prior to upgrade we know of hard-coded names and the system is in working state
During upgrade, lets pre-populate the ambari.properties file with the old 
hard-coded values (think of them as the real names as thats what we know)
If user wants to use real name, they can call ambari-server setup ...
Net goal is to not have user do anything post Ambari upgrade.


Diffs
-

  ambari-server/conf/unix/ambari.properties 1830d18 

Diff: https://reviews.apache.org/r/46217/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

> On April 14, 2016, 3:33 a.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py,
> >  line 92
> > 
> >
> > I think this function should only take a name of component and use 
> > utility to get process name and port number based on metadata. Maybe 
> > refactor that function from status into utils ?

PROCESS_INFO(now renamed to COMPONENT_ATTRIBUTES) holds port property names but 
not port numbers themselve. And a old port and a new port can be different 
depending on where it is from (either from Ambari or local hawq-site.xml)
The source can be determined by action(whether it is start or stop). so here is 
too much dependencies. This function should only form a string of netstat so 
I'd rather not to have the logic. 
(I'd replace the if statement with PROCESS_INFO though)


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128826
---


On April 14, 2016, 2:19 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 2:19 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46183: AMBARI-15876. Stack advisor work for adding and removing LLAP queue when Interactive query is turned on and off respectively.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46183/#review128936
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 (line 360)


Is this correct, cluster_name?



ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/capacity-scheduler.xml
 (line 28)


This means that ambari upgrade will not add this property, but because it 
is new, then stack upgrade from HDP 2.4 to 2.5 will add it. Is that correct?
DOes it need a value?


- Alejandro Fernandez


On April 14, 2016, 9:01 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46183/
> ---
> 
> (Updated April 14, 2016, 9:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15876
> https://issues.apache.org/jira/browse/AMBARI-15876
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - When Hive Server Interactive is turned ON, Ambari will create 'llap' named 
> YARN queue if only 'default' queue exists at root level and is consuming 100% 
> capacity.
> - When Hive Server Interactive is turned OFF, Ambari will delete 'llap' queue 
> only if 2 queues exist at root level namely, 'llap' and 'default'.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  d518c8b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  ba46f00 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/capacity-scheduler.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 7407da3 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> c21bad7 
> 
> Diff: https://reviews.apache.org/r/46183/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> - Manual testing done. Various scenarios tested.
> - Test cases added to test the creation and deletion logic.
> 
> - Screenshots attached.
> 
> 
> File Attachments
> 
> 
> LLAP queue created
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/14/4304fa89-fcfa-47b2-9240-d4ffa221cb76__Screen_Shot_2016-04-13_at_4.51.35_PM.png
> HSI On and llap and default queues shown in dropdown
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/14/622db04f-ec39-4a63-920d-dffc3a269917__Screen_Shot_2016-04-13_at_4.51.03_PM.png
> YARn queue manager with llap and default queues 
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/14/29ee3e5c-9c49-4e73-be39-46e6ec786d21__Screen_Shot_2016-04-13_at_4.48.46_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128934
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 (line 25)


that's a good idea Matt.


- jun aoki


On April 14, 2016, 2:19 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 2:19 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

> On April 14, 2016, 2:33 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py,
> >  line 92
> > 
> >
> > Are the expected return values just 0 and 1?
> > 
> > If yes, the function can have a name similar to  __is_process_running

This returns a string of command wihich will be passed to not_if and only_if 
parameters.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128823
---


On April 14, 2016, 2:19 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 2:19 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46194: HDP 2.3.2.0: Changing hive tez container size (via ambari) should change tez.runtime.io.sort.mb as well

[Srimanth Gunturi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46194/#review128918
---


Ship it!




Ship It!

- Srimanth Gunturi


On April 14, 2016, 11:27 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46194/
> ---
> 
> (Updated April 14, 2016, 11:27 a.m.)
> 
> 
> Review request for Ambari and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15879
> https://issues.apache.org/jira/browse/AMBARI-15879
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Observed this in HDP 2.3.2
> 
> Original hive tez container size: 24576  
> Original tez.runtime.io.sort.mb: 14950 or around this value
> 
> Changed hive tez container size to 16384. But tez.runtime.io.sort.mb remained
> at 14 GB. Hive queries starts failing due to mem issue.
> 
> Ideally, when hive tez container size is adjusted, tez.runtime.io.sort.mb
> should also be auto-adjusted in ambari (or a warning would be useful).
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
> 
> Diff: https://reviews.apache.org/r/46194/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 46172: Pass request object to delete API in resource providers

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46172/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-15888
https://issues.apache.org/jira/browse/AMBARI-15888


Repository: ambari


Description
---

Currently delete API on resource provider only takes predicate. Ideally it 
should take request object as well which has additional metadata. It will be 
required in scenarios like dry-run where it can look at request object to 
figure out if current invocation is for dry run or not and behave accordingly.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManagerImpl.java
 3037446 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerResourceProvider.java
 d403114 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java
 0837a5d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
 faef86c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
 10eecac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
 bcf0205 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
 dafd194 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java
 f52ee62 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java
 f19bea9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
 3b749d9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
 34952f2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 a4b2aaa 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 3e4d7fd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java
 e776b5a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
 51c0db9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 a85f939 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
 6236ac2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
 2677ec7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java
 f9d12b5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java
 8a3937a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java
 5087049 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
 0d215ae 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
 39a09a6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 322eab8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
 b3f353c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java
 49f968f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java
 c732842 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java
 3cece5d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java
 3d18a27 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java
 307ed3f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PermissionResourceProvider.java
 86f8321 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java
 4a44375 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java
 ed64342 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java
 562aa34 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
 18d597e 
  

Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46198/
---

(Updated April 14, 2016, 3:19 p.m.)


Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-15882
https://issues.apache.org/jira/browse/AMBARI-15882


Repository: ambari


Description
---

Properties defined in external stack definition were excluded in case of bp 
deployments.
(eg. : oozie-site.xml from the falcon stack definition)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 1433a1b 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 834953b 

Diff: https://reviews.apache.org/r/46198/diff/


Testing (updated)
---

Unit test done. Tests ran successfully.
Manually tested on local / openstack cluster.

Java Results :

Tests run: 4226, Failures: 0, Errors: 0, Skipped: 32


Python:
Total run:959
Total errors:0
Total failures:0
OK


Thanks,

Laszlo Puskas

Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46198/
---

(Updated April 14, 2016, 3:16 p.m.)


Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.


Changes
---

Testing OK


Bugs: AMBARI-15882
https://issues.apache.org/jira/browse/AMBARI-15882


Repository: ambari


Description
---

Properties defined in external stack definition were excluded in case of bp 
deployments.
(eg. : oozie-site.xml from the falcon stack definition)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 1433a1b 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 834953b 

Diff: https://reviews.apache.org/r/46198/diff/


Testing (updated)
---

Unit test done. Tests ran successfully.
Manually tested on local / openstack cluster.


Thanks,

Laszlo Puskas

Re: Review Request 46207: Owner of /tmp hdfs directory is yarn user on secure blueprint install

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46207/#review128901
---




ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 (line 76)


The condition check for starts with "/tmp" and then it creates folder using 
hdfs_tmp_dir. It looks a bit odd.


- Sumit Mohanty


On April 14, 2016, 3:07 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46207/
> ---
> 
> (Updated April 14, 2016, 3:07 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15885
> https://issues.apache.org/jira/browse/AMBARI-15885
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  91fdb83 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  bb2f567 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 080bc11 
> 
> Diff: https://reviews.apache.org/r/46207/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 46207: Owner of /tmp hdfs directory is yarn user on secure blueprint install

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46207/#review128899
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Квітень 14, 2016, 3:04 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46207/
> ---
> 
> (Updated Квітень 14, 2016, 3:04 після полудня)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15885
> https://issues.apache.org/jira/browse/AMBARI-15885
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  91fdb83 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  bb2f567 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 080bc11 
> 
> Diff: https://reviews.apache.org/r/46207/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 46207: Owner of /tmp hdfs directory is yarn user on secure blueprint install

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46207/
---

(Updated April 14, 2016, 3:04 p.m.)


Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-15885
https://issues.apache.org/jira/browse/AMBARI-15885


Repository: ambari


Description (updated)
---

.


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 91fdb83 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 bb2f567 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 080bc11 

Diff: https://reviews.apache.org/r/46207/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 46207: Owner of /tmp hdfs directory is yarn user on secure blueprint install

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46207/
---

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-15885
https://issues.apache.org/jira/browse/AMBARI-15885


Repository: ambari


Description
---


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 91fdb83 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 bb2f567 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 080bc11 

Diff: https://reviews.apache.org/r/46207/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 46169: Add dryrun method on request object

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46169/
---

(Updated April 14, 2016, 2:30 p.m.)


Review request for Ambari, Jayush Luniya, Nate Cole, and Sumit Mohanty.


Changes
---

Renamed variable and fixed unit tests.


Bugs: AMBARI-15870
https://issues.apache.org/jira/browse/AMBARI-15870


Repository: ambari


Description
---

To implement dry-run version of an API, request needs to be parsed manually to 
figure out if request has dry-run directive.
It will be good to add a method on Request object method itself which 
centralizes parsing and logic for figuring out dry-run directive


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java
 12b91e3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestImpl.java
 f27f621 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
 f8f8290 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Request.java
 50eed9a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
 93fe36f 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
 ea4afde 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
 633815e 

Diff: https://reviews.apache.org/r/46169/diff/


Testing (updated)
---

Hadoop QA commented on AMBARI-15870:


{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12798670/rb46169.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6435//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6435//console


Thanks,

Ajit Kumar

Re: Review Request 46196: Logsearch: reading config values from external property files

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46196/#review128894
---


Ship it!




Ship It!

- Robert Nettleton


On April 14, 2016, 11:47 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46196/
> ---
> 
> (Updated April 14, 2016, 11:47 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15842
> https://issues.apache.org/jira/browse/AMBARI-15842
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reading config values (like xml files or *.sh scripts) from external property 
> files.
> 
> I did not added xml support for reading external property files. Reason is 
> because these xml files are jinja templates. So they can act as text files.
> 
> also added: Solr Instance renamed to LogSearch Solr Instance
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  94ed27d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
>  91fc0ce 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml
>  4da16b1 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  ef6bebf 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
>  6741f41 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-service_logs-solrconfig.xml
>  60363c8 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  855f0e5 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-log4j.xml
>  e99cb81 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-xml.xml
>  d31d0b3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 018398f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-log4j.xml.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-log4j.xml.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/solr-log4j.properties.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/solr.xml.j2
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46196/diff/
> 
> 
> Testing
> ---
> 
> Total run:959
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46198/#review128893
---


Ship it!




Ship It!

- Robert Levas


On April 14, 2016, 8:27 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46198/
> ---
> 
> (Updated April 14, 2016, 8:27 a.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15882
> https://issues.apache.org/jira/browse/AMBARI-15882
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Properties defined in external stack definition were excluded in case of bp 
> deployments.
> (eg. : oozie-site.xml from the falcon stack definition)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1433a1b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  834953b 
> 
> Diff: https://reviews.apache.org/r/46198/diff/
> 
> 
> Testing
> ---
> 
> Unit test done. (mvn test underway)
> Manually tested on local / openstack cluster.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 46200: Support for multiple Namservices in namenode_ha_utils.py

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46200/#review128891
---


Ship it!




Ship It!

- Andrew Onischuk


On April 14, 2016, 1:13 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46200/
> ---
> 
> (Updated April 14, 2016, 1:13 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-15506
> https://issues.apache.org/jira/browse/AMBARI-15506
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently Ambari does not support the definition of multiple Nameservices. It 
> is always assumed hdfs_site['dfs.nameservices'] is just a string defining one 
> nameservice.
> Multiple nameservices can be configured for exmaple to support seamless 
> distcp between two HA clusters. The nameservices are defined as a comma 
> separated list in hdfs_site['dfs.nameservices'].
> This patch introduces the method get_nameservice(hdfs_site), which splits the 
> value into in an array and identifies the nameservice for the current cluster 
> with what is set in hdfs_site['dfs.namenode.shared.edits.dir']. By default 
> the first nameservice is returned or empty.
> To verify the current namservice it would be preferred to use fs.defaultFS in 
> core-site, but getting this config into namenode_ha_utils.py seems more 
> involved.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestNamenodeHaUtils.py 
> PRE-CREATION 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  b6f3bee 
> 
> Diff: https://reviews.apache.org/r/46200/diff/
> 
> 
> Testing
> ---
> 
> --
> Ran 426 tests in 17.864s
> 
> OK
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46198/#review128892
---


Ship it!




Ship It!

- Sandor Magyari


On April 14, 2016, 12:27 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46198/
> ---
> 
> (Updated April 14, 2016, 12:27 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15882
> https://issues.apache.org/jira/browse/AMBARI-15882
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Properties defined in external stack definition were excluded in case of bp 
> deployments.
> (eg. : oozie-site.xml from the falcon stack definition)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1433a1b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  834953b 
> 
> Diff: https://reviews.apache.org/r/46198/diff/
> 
> 
> Testing
> ---
> 
> Unit test done. (mvn test underway)
> Manually tested on local / openstack cluster.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Review Request 46200: Support for multiple Namservices in namenode_ha_utils.py

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46200/
---

Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-15506
https://issues.apache.org/jira/browse/AMBARI-15506


Repository: ambari


Description
---

Currently Ambari does not support the definition of multiple Nameservices. It 
is always assumed hdfs_site['dfs.nameservices'] is just a string defining one 
nameservice.
Multiple nameservices can be configured for exmaple to support seamless distcp 
between two HA clusters. The nameservices are defined as a comma separated list 
in hdfs_site['dfs.nameservices'].
This patch introduces the method get_nameservice(hdfs_site), which splits the 
value into in an array and identifies the nameservice for the current cluster 
with what is set in hdfs_site['dfs.namenode.shared.edits.dir']. By default the 
first nameservice is returned or empty.
To verify the current namservice it would be preferred to use fs.defaultFS in 
core-site, but getting this config into namenode_ha_utils.py seems more 
involved.


Diffs
-

  ambari-agent/src/test/python/resource_management/TestNamenodeHaUtils.py 
PRE-CREATION 
  
ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
 b6f3bee 

Diff: https://reviews.apache.org/r/46200/diff/


Testing
---

--
Ran 426 tests in 17.864s

OK


Thanks,

Dmytro Sen

Re: Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46198/#review128886
---


Ship it!




Ship It!

- Robert Nettleton


On April 14, 2016, 12:27 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46198/
> ---
> 
> (Updated April 14, 2016, 12:27 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15882
> https://issues.apache.org/jira/browse/AMBARI-15882
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Properties defined in external stack definition were excluded in case of bp 
> deployments.
> (eg. : oozie-site.xml from the falcon stack definition)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1433a1b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  834953b 
> 
> Diff: https://reviews.apache.org/r/46198/diff/
> 
> 
> Testing
> ---
> 
> Unit test done. (mvn test underway)
> Manually tested on local / openstack cluster.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Review Request 46199: AMBARI-15866: Renew kerberos keyfile rest API returnes a malformed /request URL

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46199/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-15866
https://issues.apache.org/jira/browse/AMBARI-15866


Repository: ambari


Description
---

curl -u admin:admin 
'http://myserver.mydomain.com:8080/api/v1/clusters/mycluster?regenerate_keytabs=all'
 -X PUT -H 'X-Requested-By: ambari' --data 
'{"Clusters":{"security_type":"KERBEROS"}}'
{
"href" : 
"http://myserver.mydomain.com:8080/api/v1/clusters/mycluster?regenerate_keytabs=all/requests/15;,
"Requests" :
{ "id" : 15, "status" : "Accepted" }

}

Notice the "regenerate_keytabs=all" piece in the URL returned by the Ambari 
server. If user pulls request status against that URL, he will get the 
following err.

curlit GET 
http://myserver.mydomain.com:8080/api/v1/clusters/mycluster?regenerate_keytabs=all/requests/15
{ "status" : 400, "message" : "The properties [regenerate_keytabs] specified in 
the request or predicate are not supported for the resource type Cluster." }

The correct url should be 
http://myserver.mydomain.com:8080/api/v1/clusters/mycluster/requests/15

This does not effect Ambari web UI as Ambari UI pulls status of all requests by 
/requests url, instead of using individual request URLs.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RequestResourceDefinition.java
 cf3f267 

Diff: https://reviews.apache.org/r/46199/diff/


Testing
---

The issue is general, regardless whether the cluster is kerberized, as it's 
about how the href url is parsed.

kerberized a trunk cluster, patch the cluster with fix. 
1. submit REST API call to renew kerberos keytabs.
Verify the /requests URL returned is valid and can be used to pull request 
status.
2. submit a custom action API (like the host check one).
Verify the existing href behavior is still correct.
3. Submit a rest api that does not need to return /requests url, like get stack 
details REST API
Veriy the existing href behavior is still correct.

On a non-kerberized trunk cluster, patch the cluster with fix, 
Repeat the 3 tests mentioned above.


Thanks,

Di Li

Review Request 46198: Oozie - falcon integration properties not xconsidered on blueprint deployments

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46198/
---

Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-15882
https://issues.apache.org/jira/browse/AMBARI-15882


Repository: ambari


Description
---

Properties defined in external stack definition were excluded in case of bp 
deployments.
(eg. : oozie-site.xml from the falcon stack definition)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 1433a1b 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 834953b 

Diff: https://reviews.apache.org/r/46198/diff/


Testing
---

Unit test done. (mvn test underway)
Manually tested on local / openstack cluster.


Thanks,

Laszlo Puskas

Re: Review Request 46148: NPE when deleting a host

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46148/#review128880
---


Ship it!




Ship It!

- Sebastian Toader


On April 14, 2016, 1:41 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46148/
> ---
> 
> (Updated April 14, 2016, 1:41 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15862
> https://issues.apache.org/jira/browse/AMBARI-15862
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When deleting a host, NPE may occur.
> TopologyHostRequests are created with hostName=null at the first time, and 
> when hosts are registered, then these null values are replaced with the 
> correct host names.
> In the case when a host is being deleted, a loop checks the host name for all 
> the requests, and if there is a request with hostName=null, a NPE is thrown.
> Swapping the sides of **equals** method can solve the problem, since the 
> variable **hostname** is checked before and not null.
> 
> Lob and Basic annotations were removed, because that column in the database 
> is not a CLOB. This turned out during running the test (in memory db is 
> created based on these annotations).
> 
> The new test case adds hostRequests to the cluster, some of them have no host 
> name (=null) to simulate hosts that have not registered to the cluster yet. 
> If no exception is thrown when deleting a registered host, then it is 
> successful.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostGroupEntity.java
>  0a81286 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  c5554f7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
>  daf8d12 
> 
> Diff: https://reviews.apache.org/r/46148/diff/
> 
> 
> Testing
> ---
> 
> Branch 2.2.2
> 
> Results :
> 
> Tests run: 3553, Failures: 0, Errors: 0, Skipped: 36
> 
> ...
> 
> Total run:925
> Total errors:0
> Total failures:0
> 
> ...
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:11:47.762s
> [INFO] Finished at: Thu Apr 14 13:40:06 CEST 2016
> [INFO] Final Memory: 46M/1060M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 46195: ATS heapsize cannot be changed in Ambari-2.2.1.1 or greater post Ambari Server upgrade, even though the bug should be fixed

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46195/#review128878
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On April 14, 2016, 11:29 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46195/
> ---
> 
> (Updated April 14, 2016, 11:29 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15880
> https://issues.apache.org/jira/browse/AMBARI-15880
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> yarn-env had an issue where ATS heapsize was not getting set correctly
> This was fixed in Ambari-2.1.0 for HDP 2.2 and Ambari-2.2.1.1 for HDP 
> 2.3/2.4.  
> However, "ambari-server upgrade" does not fix yarn-env, even if the user has
> never touched it.
> 
> STR:
> 
>   * Install a HDP 2.4.0 cluster with YARN using Ambari 2.2.1.0
>   * Confirm that yarn-env has **export 
> YARN_HISTORYSERVER_HEAPSIZE=`apptimelineserver_heapsize`** (this is incorrect)
>   * ambari-server stop
>   * Install ambari.repo for Ambari 2.2.1.1
>   * yum upgrade ambari-server
>   * ambari-server upgrade
>   * ambari-server start
> 
> Actual: yarn-env still has **export
> YARN_HISTORYSERVER_HEAPSIZE=`apptimelineserver_heapsize`**  
> Expected: yarn-env has **export
> YARN_TIMELINESERVER_HEAPSIZE=`apptimelineserver_heapsize`** instead
> 
> This means that changing "AppTimelineServer Java heap size" from the UI has no
> effect on setting the actual heapsize for ATS.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  31af5e3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  59f9f91 
> 
> Diff: https://reviews.apache.org/r/46195/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 46148: NPE when deleting a host

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46148/
---

(Updated ápr. 14, 2016, 11:41 de)


Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor 
Magyari, and Sebastian Toader.


Bugs: AMBARI-15862
https://issues.apache.org/jira/browse/AMBARI-15862


Repository: ambari


Description
---

When deleting a host, NPE may occur.
TopologyHostRequests are created with hostName=null at the first time, and when 
hosts are registered, then these null values are replaced with the correct host 
names.
In the case when a host is being deleted, a loop checks the host name for all 
the requests, and if there is a request with hostName=null, a NPE is thrown.
Swapping the sides of **equals** method can solve the problem, since the 
variable **hostname** is checked before and not null.

Lob and Basic annotations were removed, because that column in the database is 
not a CLOB. This turned out during running the test (in memory db is created 
based on these annotations).

The new test case adds hostRequests to the cluster, some of them have no host 
name (=null) to simulate hosts that have not registered to the cluster yet. If 
no exception is thrown when deleting a registered host, then it is successful.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostGroupEntity.java
 0a81286 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 c5554f7 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
 daf8d12 

Diff: https://reviews.apache.org/r/46148/diff/


Testing (updated)
---

Branch 2.2.2

Results :

Tests run: 3553, Failures: 0, Errors: 0, Skipped: 36

...

Total run:925
Total errors:0
Total failures:0

...

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:11:47.762s
[INFO] Finished at: Thu Apr 14 13:40:06 CEST 2016
[INFO] Final Memory: 46M/1060M
[INFO] 


Thanks,

Daniel Gergely

Review Request 46195: ATS heapsize cannot be changed in Ambari-2.2.1.1 or greater post Ambari Server upgrade, even though the bug should be fixed

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46195/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-15880
https://issues.apache.org/jira/browse/AMBARI-15880


Repository: ambari


Description
---

yarn-env had an issue where ATS heapsize was not getting set correctly
This was fixed in Ambari-2.1.0 for HDP 2.2 and Ambari-2.2.1.1 for HDP 2.3/2.4.  
However, "ambari-server upgrade" does not fix yarn-env, even if the user has
never touched it.

STR:

  * Install a HDP 2.4.0 cluster with YARN using Ambari 2.2.1.0
  * Confirm that yarn-env has **export 
YARN_HISTORYSERVER_HEAPSIZE=`apptimelineserver_heapsize`** (this is incorrect)
  * ambari-server stop
  * Install ambari.repo for Ambari 2.2.1.1
  * yum upgrade ambari-server
  * ambari-server upgrade
  * ambari-server start

Actual: yarn-env still has **export
YARN_HISTORYSERVER_HEAPSIZE=`apptimelineserver_heapsize`**  
Expected: yarn-env has **export
YARN_TIMELINESERVER_HEAPSIZE=`apptimelineserver_heapsize`** instead

This means that changing "AppTimelineServer Java heap size" from the UI has no
effect on setting the actual heapsize for ATS.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 31af5e3 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 59f9f91 

Diff: https://reviews.apache.org/r/46195/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 46194: HDP 2.3.2.0: Changing hive tez container size (via ambari) should change tez.runtime.io.sort.mb as well

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46194/
---

Review request for Ambari and Srimanth Gunturi.


Bugs: AMBARI-15879
https://issues.apache.org/jira/browse/AMBARI-15879


Repository: ambari


Description
---

Observed this in HDP 2.3.2

Original hive tez container size: 24576  
Original tez.runtime.io.sort.mb: 14950 or around this value

Changed hive tez container size to 16384. But tez.runtime.io.sort.mb remained
at 14 GB. Hive queries starts failing due to mem issue.

Ideally, when hive tez container size is adjusted, tez.runtime.io.sort.mb
should also be auto-adjusted in ambari (or a warning would be useful).


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
3a65541 

Diff: https://reviews.apache.org/r/46194/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 46148: NPE when deleting a host

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46148/#review128869
---


Ship it!




Ship It!

- Sebastian Toader


On April 14, 2016, 12:25 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46148/
> ---
> 
> (Updated April 14, 2016, 12:25 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15862
> https://issues.apache.org/jira/browse/AMBARI-15862
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When deleting a host, NPE may occur.
> TopologyHostRequests are created with hostName=null at the first time, and 
> when hosts are registered, then these null values are replaced with the 
> correct host names.
> In the case when a host is being deleted, a loop checks the host name for all 
> the requests, and if there is a request with hostName=null, a NPE is thrown.
> Swapping the sides of **equals** method can solve the problem, since the 
> variable **hostname** is checked before and not null.
> 
> Lob and Basic annotations were removed, because that column in the database 
> is not a CLOB. This turned out during running the test (in memory db is 
> created based on these annotations).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostGroupEntity.java
>  0a81286 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  c5554f7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
>  daf8d12 
> 
> Diff: https://reviews.apache.org/r/46148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 46148: NPE when deleting a host

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46148/#review128867
---


Ship it!




Ship It!

- Oliver Szabo


On April 14, 2016, 10:25 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46148/
> ---
> 
> (Updated April 14, 2016, 10:25 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15862
> https://issues.apache.org/jira/browse/AMBARI-15862
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When deleting a host, NPE may occur.
> TopologyHostRequests are created with hostName=null at the first time, and 
> when hosts are registered, then these null values are replaced with the 
> correct host names.
> In the case when a host is being deleted, a loop checks the host name for all 
> the requests, and if there is a request with hostName=null, a NPE is thrown.
> Swapping the sides of **equals** method can solve the problem, since the 
> variable **hostname** is checked before and not null.
> 
> Lob and Basic annotations were removed, because that column in the database 
> is not a CLOB. This turned out during running the test (in memory db is 
> created based on these annotations).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostGroupEntity.java
>  0a81286 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  c5554f7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
>  daf8d12 
> 
> Diff: https://reviews.apache.org/r/46148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 46148: NPE when deleting a host

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46148/
---

(Updated ápr. 14, 2016, 10:25 de)


Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor 
Magyari, and Sebastian Toader.


Changes
---

Test added


Bugs: AMBARI-15862
https://issues.apache.org/jira/browse/AMBARI-15862


Repository: ambari


Description (updated)
---

When deleting a host, NPE may occur.
TopologyHostRequests are created with hostName=null at the first time, and when 
hosts are registered, then these null values are replaced with the correct host 
names.
In the case when a host is being deleted, a loop checks the host name for all 
the requests, and if there is a request with hostName=null, a NPE is thrown.
Swapping the sides of **equals** method can solve the problem, since the 
variable **hostname** is checked before and not null.

Lob and Basic annotations were removed, because that column in the database is 
not a CLOB. This turned out during running the test (in memory db is created 
based on these annotations).


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostGroupEntity.java
 0a81286 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 c5554f7 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
 daf8d12 

Diff: https://reviews.apache.org/r/46148/diff/


Testing
---


Thanks,

Daniel Gergely

Re: Review Request 46183: AMBARI-15876. Stack advisor work for adding and removing LLAP queue when Interactive query is turned on and off respectively.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46183/
---

(Updated April 14, 2016, 9:01 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Changes
---

- Suggestions incorporated as per Sumit's review.
- Testing : Python UT passes.


Bugs: AMBARI-15876
https://issues.apache.org/jira/browse/AMBARI-15876


Repository: ambari


Description
---

- When Hive Server Interactive is turned ON, Ambari will create 'llap' named 
YARN queue if only 'default' queue exists at root level and is consuming 100% 
capacity.
- When Hive Server Interactive is turned OFF, Ambari will delete 'llap' queue 
only if 2 queues exist at root level namely, 'llap' and 'default'.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 d518c8b 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 ba46f00 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/capacity-scheduler.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
7407da3 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py c21bad7 

Diff: https://reviews.apache.org/r/46183/diff/


Testing
---

- Python UT passes.
- Manual testing done. Various scenarios tested.
- Test cases added to test the creation and deletion logic.

- Screenshots attached.


File Attachments


LLAP queue created
  
https://reviews.apache.org/media/uploaded/files/2016/04/14/4304fa89-fcfa-47b2-9240-d4ffa221cb76__Screen_Shot_2016-04-13_at_4.51.35_PM.png
HSI On and llap and default queues shown in dropdown
  
https://reviews.apache.org/media/uploaded/files/2016/04/14/622db04f-ec39-4a63-920d-dffc3a269917__Screen_Shot_2016-04-13_at_4.51.03_PM.png
YARn queue manager with llap and default queues 
  
https://reviews.apache.org/media/uploaded/files/2016/04/14/29ee3e5c-9c49-4e73-be39-46e6ec786d21__Screen_Shot_2016-04-13_at_4.48.46_PM.png


Thanks,

Swapan Shridhar

Review Request 46016: AMBARI-15752 Ambari support for additional config params for Ranger KMS to support HSM

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, 
Jayush Luniya, and Velmurugan Periasamy.


Bugs: AMBARI-15752
https://issues.apache.org/jira/browse/AMBARI-15752


Repository: ambari


Description
---

Add HSM support configuration properties for Ranger KMS in hdp-2.5


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 86dbc48 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 7201c36 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 dd91acf 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 fc722da 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 03b7e01 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml
 02fb6aa 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/46016/diff/


Testing
---

Installed Ranger KMS centos6.


Thanks,

Mugdha Varadkar