> On April 7, 2016, 5:23 p.m., Jayush Luniya wrote:
> > Ship It!
Committed. Please close review
commit 2c5de15b3dd18453f67a11194d9ef7d3dab46e45
Author: Jayush Luniya
Date: Tue May 3 17:53:56 2016 -0700
AMBARI-15758: Add shiro.ini in Ambari Zeppelin service config (Renjith
K
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46833/#review131626
---
Ship it!
Ship It!
- Jayush Luniya
On May 2, 2016, 12:55 p.m
> On April 29, 2016, 9:53 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml,
> > line 1
> > <https://reviews.apache.org/r/46727/diff/5/?file=1365616#file1365616line1>
> >
> > We shouldnt name
/test_zookeeper_service_check.py
863505b
ambari-server/src/test/python/stacks/2.0.6/configs/zk-service_check_2.2.json
33bcfb9
Diff: https://reviews.apache.org/r/46963/diff/
Testing
---
mvn clean test -DskipSurefireTests
Thanks,
Jayush Luniya
clean test -DskipSurefireTests
Thanks,
Jayush Luniya
]
[INFO] Total time: 59.926s
[INFO] Finished at: Wed May 04 05:45:19 PDT 2016
[INFO] Final Memory: 63M/1386M
[INFO]
Thanks,
Jayush Luniya
://reviews.apache.org/r/46971/diff/
Testing
---
Thanks,
Jayush Luniya
/storm_default.json 72afd78
ambari-server/src/test/python/stacks/2.3/configs/storm_default_secure.json
c1b7e10
Diff: https://reviews.apache.org/r/46976/diff/
Testing
---
Thanks,
Jayush Luniya
]
Thanks,
Jayush Luniya
3bcfb9
Diff: https://reviews.apache.org/r/46963/diff/
Testing
---
mvn clean test -DskipSurefireTests
Thanks,
Jayush Luniya
otal time: 58.650s
[INFO] Finished at: Wed May 04 06:40:16 PDT 2016
[INFO] Final Memory: 64M/1178M
[INFO]
Thanks,
Jayush Luniya
[INFO]
[INFO] Total time: 59.926s
[INFO] Finished at: Wed May 04 05:45:19 PDT 2016
[INFO] Final Memory: 63M/1386M
[INFO]
Thanks,
Jayush Luniya
Thanks,
Jayush Luniya
---
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 58.650s
[INFO] Finished at: Wed May 04 06:40:16 PDT 2016
[INFO] Final Memory: 64M/1178M
[INFO]
Thanks
[INFO]
[INFO] Total time: 59.926s
[INFO] Finished at: Wed May 04 05:45:19 PDT 2016
[INFO] Final Memory: 63M/1386M
[INFO]
Thanks,
Jayush Luniya
: 58.650s
[INFO] Finished at: Wed May 04 06:40:16 PDT 2016
[INFO] Final Memory: 64M/1178M
[INFO]
Thanks,
Jayush Luniya
UCCESS
[INFO]
[INFO] Total time: 58.650s
[INFO] Finished at: Wed May 04 06:40:16 PDT 2016
[INFO] Final Memory: 64M/1178M
[INFO]
Thanks,
Jayush Luniya
ORM/alerts.json
> e5d4e471bda82f9ecefe7f490f749e40cbfeba57
>
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/metainfo.xml
> 76022cc06a4b5d4b1c3dda6362a2265d5f823ea3
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_base.py
> 023b811dee6f391b744878050025e91b81aa7301
> ambari-server/src/test/python/stacks/2.3/STORM/test_storm_base.py
> 3c602348d252218daad16a83963748ceb77af643
> ambari-server/src/test/python/stacks/2.3/STORM/test_storm_upgrade.py
> d0356ffc0143722bbd0233a18ba4b742f45c4aa0
> ambari-server/src/test/python/stacks/2.3/configs/storm_default.json
> 72afd78894524ea2256db45e82b2fc9e6bc96745
> ambari-server/src/test/python/stacks/2.3/configs/storm_default_secure.json
> c1b7e10aae5b301664ec8d5801d7618baa243c1d
>
> Diff: https://reviews.apache.org/r/46976/diff/
>
>
> Testing
> ---
>
> mvn clean test -DskipSurefireTests
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 58.650s
> [INFO] Finished at: Wed May 04 06:40:16 PDT 2016
> [INFO] Final Memory: 64M/1178M
> [INFO]
>
>
>
> Thanks,
>
> Jayush Luniya
>
>
(line 40)
<https://reviews.apache.org/r/46927/#comment195805>
Shouldnt return "storm-client"
- Jayush Luniya
On May 3, 2016, 4:52 a.m., Sriharsha Chintalapani wrote:
>
> ---
> This is an automatically ge
> On May 4, 2016, 11:37 p.m., Sriharsha Chintalapani wrote:
> > Lets wait till AMBARI-16210 gets merged in. Since we are shipping 1.0 with
> > Ambari 2.4 that needs to be part of this patch as well.
>
> Jayush Luniya wrote:
> @Sriharsha,
> Sumit already c
res in stack_features.py
for now need to be kept in sync. Once we handle the ambari-server upgrade
scenario, we would no longer need to define a default and this duplication will
go away.
- Jayush Luniya
On May 4, 2016, 6:20 a.m., Jeff Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47038/#review131959
---
Ship it!
Ship It!
- Jayush Luniya
On May 5, 2016, 7:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review131962
---
Ship it!
Ship It!
- Jayush Luniya
On May 5, 2016, 2:50 p.m
> On May 5, 2016, 10:52 p.m., Jayush Luniya wrote:
> > Ship It!
>
> Matt wrote:
> Jayush, shall I commit this or are you working on it?
Committed to trunk
- Jayush
---
This is an automatically generated e-mai
/package/scripts/service_check.py
(line 40)
<https://reviews.apache.org/r/46727/#comment196276>
Why 5?
- Jayush Luniya
On May 7, 2016, 3:09 p.m., Jeff Zhang wrote:
>
> ---
> This is an automatically generated e-mail.
/stack_advisor.py
(line 280)
<https://reviews.apache.org/r/46727/#comment196279>
We should add this to HDP25StackAdvisor instead?
ambari/ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
- Jayush Luniya
On May 7, 2016, 3:09 p.m., Jeff Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47086/#review132173
---
Ship it!
Ship It!
- Jayush Luniya
On May 7, 2016, 1:48 a.m
> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote:
> > I think we need more testing on this apart from unit tests to ensure all
> > imports are there.
>
> Juanjo Marron wrote:
> Hi Jayush,
>
> Thanks for the review.
> I'll add this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review132935
---
Ship it!
Ship It!
- Jayush Luniya
On May 12, 2016, 12:41
> On May 12, 2016, 4:12 p.m., Jayush Luniya wrote:
> > Ship It!
Sorry missed on this, but can you add unit tests for the changes?
- Jayush
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apa
ry:
if security_enabled and stack_is_hdp25_or_further:
result_code = 'UNKNOWN'
label = 'This alert will get skipped for Ranger Admin on kerberos env'
else:
- Jayush Luniya
On May 9, 2016, 5:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47060/#review133167
---
Ship it!
Ship It!
- Jayush Luniya
On May 13, 2016, 10:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47138/#review133185
---
Ship it!
Ship It!
- Jayush Luniya
On May 9, 2016, 11:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47355/#review133186
---
Ship it!
Ship It!
- Jayush Luniya
On May 13, 2016, 7:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46853/#review133259
---
Ship it!
Ship It!
- Jayush Luniya
On May 3, 2016, 6:12 p.m
> On May 14, 2016, 9:09 a.m., Jayush Luniya wrote:
> > Ship It!
@Juanjo,
I have committed this to trunk. However, I think we can skip this for
branch-2.4 as it is not required for branch-2.4. Can you update the fixVersion
for the JIRA to Ambari 3.0 instead.
/0.1.0/package/files/grafana-dashboards/HDP/grafana-system-home.json
(line 1)
<https://reviews.apache.org/r/47420/#comment197859>
Might want to put system dashboards in grafana-dashboards/default so that
for all stacks atleast we have system dashboards?
- Jayush Luniya
On May 16, 2
-upgrade.xml
(line 1183)
<https://reviews.apache.org/r/47421/#comment197871>
How did we live with this so far?
- Jayush Luniya
On May 16, 2016, 6:50 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47421/#review133444
---
Ship it!
Ship It!
- Jayush Luniya
On May 16, 2016, 6:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47420/#review133463
---
Ship it!
Ship It!
- Jayush Luniya
On May 16, 2016, 9:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review133499
---
Can you add unit test coverage?
- Jayush Luniya
On May 16
/StackModule.java
(line 685)
<https://reviews.apache.org/r/45169/#comment197967>
UGM?
- Jayush Luniya
On May 16, 2016, 6:50 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> On May 17, 2016, 6:33 a.m., Jayush Luniya wrote:
> > Can you add unit test coverage?
We should have unit tests in particular to validate incorrectly authored
service upgrade packs. What happens if we add a circular dependency (example:
KAFKA is marked with KNOX and KNOX is ma
> On May 17, 2016, 6:33 a.m., Jayush Luniya wrote:
> > Can you add unit test coverage?
>
> Jayush Luniya wrote:
> We should have unit tests in particular to validate incorrectly authored
> service upgrade packs. What happens if we add a circular dependency (example:
&
t way we can support
combinations
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml (line
158)
<https://reviews.apache.org/r/45169/#comment198081>
SERVICE_CHECK_1 instead
- Jayush Luniya
On May 16, 2016, 6:50 p.m., Tim Thorpe wrote:
>
> --
> On May 17, 2016, 5:39 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java,
> > line 844
> > <https://reviews.apache.org/r/45169/diff/2/?file=1382543#file1382543line844>
> >
> > The after tag is o
/0.6.0.2.5/package/scripts/service_check.py
(line 29)
<https://reviews.apache.org/r/47455/#comment198192>
print ()?
- Jayush Luniya
On May 17, 2016, 1:50 p.m., Renjith Kamath wrote:
>
> ---
> This is an automatically gener
> On May 17, 2016, 5:39 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java,
> > line 844
> > <https://reviews.apache.org/r/45169/diff/2/?file=1382543#file1382543line844>
> >
> > The after tag is o
> On May 17, 2016, 6:33 a.m., Jayush Luniya wrote:
> > Can you add unit test coverage?
>
> Jayush Luniya wrote:
> We should have unit tests in particular to validate incorrectly authored
> service upgrade packs. What happens if we add a circular dependency (example:
&
without Livy Server
works?
Guide on Blueprints
https://cwiki.apache.org/confluence/display/AMBARI/Blueprints
- Jayush Luniya
On May 18, 2016, 11:10 a.m., Jeff Zhang wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43126/#review133850
---
Ship it!
Ship It!
- Jayush Luniya
On May 16, 2016, 9:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review134014
---
Ship it!
Ship It!
- Jayush Luniya
On May 19, 2016, 3:23 p.m
> On May 19, 2016, 7:31 p.m., Jayush Luniya wrote:
> > Ship It!
Committed patch in trunk and branch-2.4
- Jayush
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47475/#review134041
---
Ship it!
Ship It!
- Jayush Luniya
On May 18, 2016, 4:48 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47477/#review134042
---
Ship it!
Ship It!
- Jayush Luniya
On May 18, 2016, 4:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47541/#review134048
---
Ship it!
Ship It!
- Jayush Luniya
On May 18, 2016, 4:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47560/#review134050
---
Ship it!
Ship It!
- Jayush Luniya
On May 18, 2016, 10:14
> On May 19, 2016, 9:51 p.m., Jayush Luniya wrote:
> > Ship It!
@Juanjo
Committed all your patches.
- Jayush
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47560/#rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47669/#review134268
---
Ship it!
Ship It!
- Jayush Luniya
On May 20, 2016, 9:57 p.m
spark2-env
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json
(line 20)
<https://reviews.apache.org/r/47579/#comment198988>
spark2-env
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json
(line 27)
<https://reviews.apache.org/r/47579/#com
follow up JIRA to add unit
tests for SPARK2? See
ambari/ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py
- Jayush Luniya
On May 23, 2016, 2:55 a.m., Saisai Shao wrote:
>
> ---
> This is an automatically generat
> On May 18, 2016, 11:53 p.m., Jayush Luniya wrote:
> > @Jeff
> > Can you verify that blueprint deployment of the cluster without Livy Server
> > works?
> >
> > Guide on Blueprints
> > https://cwiki.apache.org/confluence/display/AMBARI/Blueprints
@Jef
/functions/constants.py
(line 86)
<https://reviews.apache.org/r/47830/#comment199780>
Dont name feature with stack name in it. The feature might be useful for
for some other stack as well.
- Jayush Luniya
On May 25, 2016, 2:09 p.m., Mugdha Varadkar
/package/scripts/setup_ranger_xml.py
(line 522)
<https://reviews.apache.org/r/47830/#comment199845>
So for HDP when HDFS is not installed we create a blank core-site. How is
that different from the case where HDFS is not in the stack def.
- Jayush Luniya
On May 25, 2016, 2:09 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47774/#review134905
---
Ship it!
Ship It!
- Jayush Luniya
On May 24, 2016, 1:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47839/#review134906
---
Ship it!
Ship It!
- Jayush Luniya
On May 25, 2016, 6:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47845/#review134907
---
Ship it!
Ship It!
- Jayush Luniya
On May 25, 2016, 7:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47830/#review134932
---
Ship it!
Ship It!
- Jayush Luniya
On May 26, 2016, 5:29 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47722/#review134934
---
Ship it!
Ship It!
- Jayush Luniya
On May 25, 2016, 10:38
>
> (Updated May 23, 2016, 2:55 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
>
>
> Bugs: AMBARI-16753
> https://issues.apache.org/jira/browse/AMBARI-16753
>
>
> Repository: ambari
> On May 18, 2016, 11:53 p.m., Jayush Luniya wrote:
> > @Jeff
> > Can you verify that blueprint deployment of the cluster without Livy Server
> > works?
> >
> > Guide on Blueprints
> > https://cwiki.apache.org/confluence/display/AMBARI/Blueprints
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review135657
---
Ship it!
Ship It!
- Jayush Luniya
On May 31, 2016, 12:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47781/#review135741
---
Ship it!
Ship It!
- Jayush Luniya
On May 24, 2016, 4:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47619/#review135743
---
Ship it!
Ship It!
- Jayush Luniya
On May 19, 2016, 11:27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47922/#review135749
---
Ship it!
Ship It!
- Jayush Luniya
On May 26, 2016, 10:59
conflicts?
- Jayush Luniya
On May 20, 2016, 6:14 p.m., Juanjo Marron wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47965/#review135751
---
Ship it!
Ship It!
- Jayush Luniya
On May 27, 2016, 4:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47934/#review135752
---
Ship it!
Ship It!
- Jayush Luniya
On May 27, 2016, 12:20
-
>
> (Updated May 26, 2016, 11:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
>
>
> Bugs: AMBARI-16797
> https://issues.apache.org/jira/browse/AMBARI-16797
>
>
> Repository: ambari
>
>
> Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47962/#review135755
---
Ship it!
Ship It!
- Jayush Luniya
On May 27, 2016, 4:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47963/#review135756
---
Ship it!
Ship It!
- Jayush Luniya
On May 27, 2016, 4:33 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47964/#review135757
---
Ship it!
Ship It!
- Jayush Luniya
On May 27, 2016, 4:36 p.m
/package/scripts/nodemanager.py
(line 90)
<https://reviews.apache.org/r/47963/#comment200862>
@Juanjo, it looks like check_process_status is not imported for YARN
nodemanager and will cause problems. Can you submit an addendum patch with this
change?
- Jayush Luniya
On May 27, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48143/#review135851
---
Ship it!
Ship It!
- Jayush Luniya
On June 1, 2016, 6:26 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47858/#review135854
---
Ship it!
Ship It!
- Jayush Luniya
On May 27, 2016, 7:11 p.m
/test_ru_set_all.py 9a4dd31
ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 7fbda2d
ambari-server/src/test/python/stacks/utils/RMFTestCase.py 74454e5
Diff: https://reviews.apache.org/r/48157/diff/
Testing
---
Thanks,
Jayush Luniya
upgrade to Ambari 2.4.0.0 adds stack_features and stack_tools
config properties
- Verified that upgrading to Ambari 2.4.1.0 updates stack_features and
stack_tools by adding dummy entries.
Thanks,
Jayush Luniya
170)
<https://reviews.apache.org/r/48157/#comment200908>
Reading stack_tools and stack_features from config property instead of
adding this property in all test jsons.
- Jayush Luniya
On June 1, 2016, 10:59 p.m., Jayush Luniya
T 2016
[INFO] Final Memory: 38M/1011M
[INFO] --------
Thanks,
Jayush Luniya
:45 PDT 2016
[INFO] Final Memory: 38M/1011M
[INFO] --------
Thanks,
Jayush Luniya
change in a new
CR request. I will verify it and commit this delta patch instead of reverting
the old patch.
- Jayush Luniya
On June 1, 2016, 11:06 p.m., Jeff Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47923/#review135942
---
Ship it!
Ship It!
- Jayush Luniya
On May 26, 2016, 11:04
e path defined in one place
- Jayush Luniya
On May 27, 2016, 3:33 a.m., Jeff Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47653/#review135952
---
Ship it!
Ship It!
- Jayush Luniya
On May 20, 2016, 6:14 p.m
g/r/47941/#comment200972>
Use explicit imports
- Jayush Luniya
On May 27, 2016, 3:33 a.m., Jeff Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/kerberos.json
(line 1)
<https://reviews.apache.org/r/46727/#comment200974>
Patch does not apply. I dont see a kerberos.json file in HDP-2.5
ls ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK
metainfo.xml
- Jayush Luniya
On June 2, 2016, 10:27 a.m., Jeff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review135966
---
Ship it!
Ship It!
- Jayush Luniya
On June 2, 2016, 10:27
> On June 2, 2016, 4:52 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json,
> > line 1
> > <https://reviews.apache.org/r/46727/diff/18/?file=1404615#file1404615line1>
> >
> > Patch does not ap
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47885/#review135972
---
Ship it!
Ship It!
- Jayush Luniya
On May 27, 2016, 4:30 a.m
-mail. To reply, visit:
> https://reviews.apache.org/r/47579/
> ---
>
> (Updated May 23, 2016, 2:55 a.m.)
>
>
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
>
>
> Bugs: AMBARI-16753
> http
201 - 300 of 597 matches
Mail list logo
