g/r/58228/#comment244138>
minor nit: lowercase ids.
- Sid Wagle
On April 6, 2017, 7:10 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58210/#review171153
---
Ship it!
Ship It!
- Sid Wagle
On April 5, 2017, 1:37 p.m
> On March 30, 2017, 4:53 p.m., Sid Wagle wrote:
> > Is there apache hosted tarball option for STOMP? Including code is great
> > but better option would be if the release tarball is hosted in Apache we
> > could rev versions without additional work.
>
> Sid Wagl
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58070/#review170613
---
Ship it!
Ship It!
- Sid Wagle
On March 30, 2017, 1:43 p.m
> On March 30, 2017, 4:53 p.m., Sid Wagle wrote:
> > Is there apache hosted tarball option for STOMP? Including code is great
> > but better option would be if the release tarball is hosted in Apache we
> > could rev versions without additional work.
lso lets put bran
is great but
better option would be if the release tarball is hosted in Apache we could rev
versions without additional work.
- Sid Wagle
On March 30, 2017, 1:43 p.m., Andrew Onischuk wrote:
>
> ---
> This is an automatically ge
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58006/
> ---
>
> (Updated March 28, 2017, 10:03 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Robert Lev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58006/#review170345
---
Ship it!
Ship It!
- Sid Wagle
On March 28, 2017, 10:03 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57902/#review170333
---
Ship it!
Ship It!
- Sid Wagle
On None, Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57902/#review170231
---
Missing UpgradeCatalog changes.
- Sid Wagle
On None, Aravindan
g/r/57918/#comment242809>
Proceed without stack-selector?
- Sid Wagle
On March 24, 2017, 7:27 p.m., Alejandro Fernandez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57793/#review169512
---
Ship it!
Ship It!
- Sid Wagle
On March 20, 2017, 9:47 p.m
*
../resources/views/
etc
- Sid Wagle
On March 14, 2017, 11:35 p.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
tps://reviews.apache.org/r/57582/#comment241211>
Is this specific impl a required dep? We probably should shade some
specific deps, I know we are not doing that currently in ambari.
- Sid Wagle
On March 14, 2017, 6:27 p.m., Jaimin Jetly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57612/#review168930
---
Ship it!
Ship It!
- Sid Wagle
On March 14, 2017, 5:40 p.m
to me.
- Sid Wagle
On March 13, 2017, 5:56 p.m., Attila Doroszlai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57509/#review168634
---
Ship it!
Ship It!
- Sid Wagle
On March 10, 2017, 4:34 p.m
/ambari/server/orm/DBAccessorImpl.java
Lines 900 (patched)
<https://reviews.apache.org/r/57478/#comment240772>
Minor nit: flag can be set after execute is successful.
- Sid Wagle
On March 9, 2017, 9:53 p.m., Jonathan Hurley
es 247 (patched)
<https://reviews.apache.org/r/57477/#comment240770>
Looks like a type "pwdU"
- Sid Wagle
On March 9, 2017, 9:44 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57251/#review167751
---
Ship it!
Ship It!
- Sid Wagle
On March 2, 2017, 7:38 p.m
for split point
calculation? The stack should be only source of truth.
- Sid Wagle
On March 2, 2017, 7:38 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57209/#review167315
---
Ship it!
Ship It!
- Sid Wagle
On March 1, 2017, 5:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57115/#review166977
---
Ship it!
Ship It!
- Sid Wagle
On Feb. 28, 2017, 12:46 a.m
roller/AmbariManagementControllerTest.java
(line 10364)
<https://reviews.apache.org/r/56974/#comment238775>
Can you rename the test to convey more meaning, optinally add comments for
future ref. Thanks.
- Sid Wagle
On Feb. 23, 2017, 7:53 a.m., Sumit M
> On Feb. 22, 2017, 6:03 p.m., Sid Wagle wrote:
> > ambari-common/src/main/python/ambari_commons/network.py, line 45
> > <https://reviews.apache.org/r/56926/diff/1/?file=1642450#file1642450line45>
> >
> > Why is this harcoded to tlsv1? Is there a best practi
)
<https://reviews.apache.org/r/56926/#comment238310>
Why is this harcoded to tlsv1? Is there a best practice guidance here?
- Sid Wagle
On Feb. 22, 2017, 2:17 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatica
t from the method.
- Sid Wagle
On Feb. 21, 2017, 11:16 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56799/#review165968
---
Ship it!
Ship It!
- Sid Wagle
On Feb. 17, 2017, 8:03 p.m
minor nit: "may not be selected"
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
(line 2560)
<https://reviews.apache.org/r/56766/#comment237718>
Any reason for copy here? Doesn't look like original collection is modified.
- Sid Wagle
-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
(line 635)
<https://reviews.apache.org/r/56765/#comment237715>
We shuld make blocking store files configurable.
- Sid Wagle
On Feb. 16, 2017, 9:10 p.m., Aravindan V
opened up a Jira to make sure this is
correctly addressed throuhout AMS.
https://issues.apache.org/jira/browse/AMBARI-19969
I am committing you patch to trunk.
- Sid Wagle
On Jan. 9, 2017, 6:27 a.m., yao lei wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56547/#review165130
---
Ship it!
Ship It!
- Sid Wagle
On Feb. 10, 2017, 4:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56482/#review164946
---
Ship it!
Ship It!
- Sid Wagle
On Feb. 9, 2017, 7:55 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/#review164841
---
Ship it!
Ship It!
- Sid Wagle
On Feb. 9, 2017, 1:29 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56453/#review164738
---
Ship it!
Ship It!
- Sid Wagle
On Feb. 8, 2017, 5:32 p.m
-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
(line 463)
<https://reviews.apache.org/r/56416/#comment236358>
Alias is overridable so should not be hard-set to hostname here. Default
setting is ok.
- Sid Wagle
On Feb. 7, 2017, 11:53 p.m., Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56199/#review164179
---
Ship it!
Ship It!
- Sid Wagle
On Feb. 3, 2017, 9:31 p.m
ache.org/r/56264/diff/
Testing
---
mvn test passed for ambari-metrics.
Thanks,
Sid Wagle
ache.org/r/56264/diff/
Testing
---
mvn test passed for ambari-metrics.
Thanks,
Sid Wagle
t chnages which should mitigate this.
- Sid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56264/#review164125
-------
On Feb. 3, 2017, 5:09 p.m., Sid Wagle wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56261/#review164083
---
Ship it!
Ship It!
- Sid Wagle
On Feb. 3, 2017, 12:24 a.m
arn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecondTest.java
58d908a
Diff: https://reviews.apache.org/r/56264/diff/
Testing
---
mvn test passed for ambari-metrics.
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56230/#review164034
---
Ship it!
Ship It!
- Sid Wagle
On Feb. 2, 2017, 6:08 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56020/#review163987
---
Ship it!
Ship It!
- Sid Wagle
On Feb. 2, 2017, 4:03 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56186/#review163885
---
Ship it!
What about Kafka sink?
- Sid Wagle
On Feb. 1, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56173/#review163839
---
Ship it!
Ship It!
- Sid Wagle
On Feb. 1, 2017, 5:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56050/#review163383
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 28, 2017, 2:12 a.m
---
On Jan. 27, 2017, 2:22 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56020/
> ---
>
> (Updated Jan. 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56020/#review163285
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 27, 2017, 2:22 p.m
clean test ... passed
Thanks,
Sid Wagle
that is
use only by the AMS Sink. These changes cover the rest.
Diffs
-
Diff: https://reviews.apache.org/r/55996/diff/
Testing
---
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55907/#review163082
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 25, 2017, 2:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55948/#review163017
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 25, 2017, 6:37 p.m
ent234364>
formatting.
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
(line 313)
<https://reviews.apache.org/r/55934/#comment234367>
Wouldn't this throw KeyError in non-kerberized env?
- Sid Wagle
On Jan. 25, 2017, 4:09 p.m.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55926/#review162983
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 25, 2017, 11:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55891/#review162860
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 24, 2017, 9:15 p.m
e 26)
<https://reviews.apache.org/r/55859/#comment234046>
Should there be a try ... catch in to make it more solid?
- Sid Wagle
On Jan. 23, 2017, 10:16 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mai
/
Testing
---
Manually tested.
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55815/#review162538
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 21, 2017, 3 a.m
/r/55737/diff/
Testing
---
Thanks,
Sid Wagle
-
On Jan. 18, 2017, 10:33 p.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53686/
> -------
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55663/#review162183
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 18, 2017, 5:54 a.m
rvices/stack_advisor.py
(line 1055)
<https://reviews.apache.org/r/55663/#comment233432>
Minor nit: non-pythonic syntax here:
if getOldValue(..) or .. and ..
- Sid Wagle
On Jan. 18, 2017, 5:54 a.m., Sumit M
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55529/#review161806
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 16, 2017, 11:30 p.m
passed except unlrelated RANGER_KMS/test_kms_server.py
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55468/#review161415
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 12, 2017, 8:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55391/#review161276
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 10, 2017, 9:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55293/#review160805
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 7, 2017, 1:36 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55278/#review160790
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 6, 2017, 10:44 p.m
> On Jan. 6, 2017, 9:23 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java,
> > line 124
> > <https://reviews.apache.org/r/55278/diff/1/?file=1598881#file1598881line124>
> >
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55273/#review160731
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 6, 2017, 4:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55213/#review160608
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 5, 2017, 3:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55178/#review160509
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 4, 2017, 4:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55136/#review160406
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 3, 2017, 12:13 p.m
/stack_advisor.py
(line 129)
<https://reviews.apache.org/r/55136/#comment231530>
Does the stack have correct default of 1024?
- Sid Wagle
On Jan. 3, 2017, 12:13 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54958/#review160256
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 27, 2016, 4:16 p.m
/internal/ClientConfigResourceProvider.java
(line 545)
<https://reviews.apache.org/r/54958/#comment231237>
Do you depend on order of execution for success? If yes, this looks
non-reliable.
- Sid Wagle
On Dec. 27, 2016, 4:16 p.m., Jaimin Jetly
mended
- Sid Wagle
On Dec. 27, 2016, 4:16 p.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54932/#review159931
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 21, 2016, 11:05 a.m
298)
<https://reviews.apache.org/r/54958/#comment230990>
Isn't this the same as props.putAll(properties.values())?
- Sid Wagle
On Dec. 22, 2016, 12:28 a.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically genera
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54609/#review159921
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 22, 2016, 1:53 a.m
/ambari/server/metrics/system/impl/MetricsServiceImpl.java
(line 67)
<https://reviews.apache.org/r/54944/#comment230940>
Why is this hardcoded ?
- Sid Wagle
On Dec. 21, 2016, 9:23 p.m., Aravindan Vijayan
hive metrics?
- Sid Wagle
On Dec. 15, 2016, 8:03 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/upgrade/UpgradeCatalog250.java
(line 150)
<https://reviews.apache.org/r/54935/#comment230870>
suggest rename to HadoopEnvConfigs.
- Sid Wagle
On Dec. 21, 2016, 4:55 p.m., Dmytro Sen wrote:
>
> ---
> This is a
. Thanks.
- Sid Wagle
On Dec. 13, 2016, 4:47 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricsFilter.java
(line 19)
<https://reviews.apache.org/r/54609/#comment229533>
Maybe this does not belong to aggregator package and can be moved to parent.
- Sid Wagle
hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricsFilter.java
(line 141)
<https://reviews.apache.org/r/54609/#comment229532>
TRy to store compiled patterns in the cache for perf reasons. Matcher is
lest costly then compile.
- Sid Wagle
On Dec. 9, 20
> On Dec. 9, 2016, 7:43 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java,
> > line 315
> > <https://reviews.apache.org/r/54552/diff/1/?file=1579998#file1579998line315>
> >
> >
che.org/r/54552/#comment229508>
Does order of items in source and data matter here ? Please ignore if this
comment doesn't apply. But if source is unique but 2 data items have same
value. ['a', 'b', 'c'] -> ['d', 'd', 'f']
- Sid Wagle
On Dec. 8, 2016, 10:59 p.m., Rob
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54513/#review158494
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 8, 2016, 12:39 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54390/#review158067
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 5, 2016, 9:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54009/#review158066
---
Ship it!
- Sid Wagle
On Dec. 5, 2016, 9:36 p.m., Aravindan
> On Nov. 30, 2016, 9:25 p.m., Sid Wagle wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java,
> > line 130
> > <https://reviews.apache.org/r/53977/diff/1/?file=1568455#file1568455line130>
> >
> >
/orm/AmbariJpaLocalTxnInterceptorTest.java
(line 130)
<https://reviews.apache.org/r/53977/#comment228058>
Line length too long, generally Ambari codebase has too many violations to
count but can you retrict to something like 200 chars for consistency?
- Sid Wagle
On Nov. 29, 2016
tps://reviews.apache.org/r/54002/#comment227880>
IMO we should fail compilation since this is important from developer point
of view and can be easily corrected at development phase.
- Sid Wagle
On Nov. 23, 2016, 8:43 p.m., Attila Doroszlai
---
On Nov. 29, 2016, 5:04 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54124/
> ---
>
> (Updated Nov. 29, 2016, 5:04 p.m.)
>
>
> Review request for Amb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/#review157283
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 29, 2016, 5:04 p.m
it:
https://reviews.apache.org/r/53588/#review157270
---
On Nov. 16, 2016, 7:39 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54140/#review157149
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 28, 2016, 9:55 p.m
> On Nov. 18, 2016, 11:21 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java,
> > line 402
> > <https://reviews.apache.org/r/53881/diff/2/?file=1567042#file1567042line402>
> >
> > priv
201 - 300 of 513 matches
Mail list logo
