Re: Review Request 41917: Avoid zk 3.4.7 to fix test hangs.

/1312/ https://builds.apache.org/job/Aurora/1313/ Thanks, John Sirois

Re: Review Request 42017: Amend install instructions to cover dependency missing from mesos deb.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42017/#review113190 --- Ship it! Thanks Bill. - John Sirois On Jan. 6, 2016, 10:42 p.m

Re: Review Request 41785: Replace scheduler log scaffolding with logback

for letting me type that out - I feel better. - John Sirois On Jan. 7, 2016, 12:30 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Review Request 42034: Adding gpg key for jsir...@apache.org.

--- Adding gpg key for jsir...@apache.org. Diffs - KEYS aed96ddf716a394a6517292a292dd38bb2460d30 Diff: https://reviews.apache.org/r/42034/diff/ Testing --- None. Thanks, John Sirois

Re: Review Request 42034: Adding gpg key for jsir...@apache.org.

generated e-mail. To reply, visit: https://reviews.apache.org/r/42034/#review113325 --- On Jan. 7, 2016, 1:39 p.m., John Sirois wrote: > > --- > This is an automatically gene

Re: Review Request 42041: Enable H2 query statistics collection.

ated e-mail. To reply, visit: > https://reviews.apache.org/r/42041/ > --- > > (Updated Jan. 7, 2016, 4:14 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Repository: aurora > > > Description

Re: Review Request 42041: Enable H2 query statistics collection.

ions from having it ON by default? Should it > > be a configurable flag instead? > > Zameer Manji wrote: > Good question, I'll run benchmarks and update the testing done. > > John Sirois wrote: > And if there are perf implications, there is always [`SET > QUERY_S

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40922/#review113484 --- Ship it! Ship It! - John Sirois On Jan. 8, 2016, 3:54 a.m

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

expected files and also same output gets to docker daemon. Bugs closed: AURORA-1548 Reviewed at https://reviews.apache.org/r/40922/ - John Sirois On Jan. 8, 2016, 3:54 a.m., Martin Hrabovcin wrote: > > --- > T

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

> On Jan. 8, 2016, 9:22 a.m., John Sirois wrote: > > Thanks Martin! Please mark this review as closed. > > > > Now on master: > > > > git log -1 origin/master > > commit 024bac9dcb8f37e4b31210e3a0a7aea2345a16ab > > Author: Martin Hrabovc

Re: Review Request 42042: Proof of concept - param interface implementations defined based on command line args

method is _barely_ doable if you have java 7+. - John Sirois On Jan. 7, 2016, 6:17 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Review Request 42080: Upgrade to pants 0.0.67.

deletions(-) Diffs - 3rdparty/python/requirements.txt 8c728800410482234afb5031f04fd25d0be2afea pants.ini 38932348195ad2021a279d2dd64ae94204e91849 Diff: https://reviews.apache.org/r/42080/diff/ Testing --- Locally green: `./build-support/jenkins/build.sh` Thanks, John Sirois

Review Request 42102: Fix flaky `ServerSetImplTest` test.

ion at ServerSetImplTest.java:155 Caused by: java.lang.InterruptedException at ServerSetImplTest.java:155 ``` Green after the fix in the vm and when run normally on my machine. Thanks, John Sirois

Re: Review Request 42102: Fix flaky `ServerSetImplTest` test.

by: org.apache.aurora.common.zookeeper.Group$JoinException at ServerSetImplTest.java:155 Caused by: java.lang.InterruptedException at ServerSetImplTest.java:155 ``` Green after the fix in the vm and when run normally on my machine. Thanks, John Sirois

Re: Review Request 42041: Enable H2 query statistics collection.

ions from having it ON by default? Should it > > be a configurable flag instead? > > Zameer Manji wrote: > Good question, I'll run benchmarks and update the testing done. > > John Sirois wrote: > And if there are perf implications, there is always [`SET > QUERY_S

Re: Review Request 42041: Enable H2 query statistics collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42041/#review113622 --- Ship it! Ship It! - John Sirois On Jan. 8, 2016, 2:52 p.m

Re: Review Request 42117: Change release script to use rel/ tag prefix.

No longer true. - John Sirois On Jan. 10, 2016, 11:26 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 42117: Change release script to use rel/ tag prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42117/#review113660 --- Ship it! Ship It! - John Sirois On Jan. 10, 2016, 11:26 a.m

Re: Review Request 42117: Change release script to use rel/ tag prefix.

> On Jan. 10, 2016, 12:08 p.m., John Sirois wrote: > > build-support/release/release, line 137 > > <https://reviews.apache.org/r/42117/diff/1/?file=1190469#file1190469line137> > > > > IIUC, this commit will be pushed and reachable from the tag, but not &g

Re: Review Request 42145: Use tags instead of branches for release candidates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42145/#review113770 --- Ship it! Ship It! - John Sirois On Jan. 11, 2016, 8:22 a.m

Re: Review Request 40877: Update rpm startup scripts to match deb patterns in use

have time to land it. Speak up by this Wednesday 1/13 after which time I'll assume you're ok with this course of action. - John Sirois On Dec. 2, 2015, 12:15 p.m., Jake Farrell wrote: > > --- > This is an automatical

Re: Review Request 42225: Add `--show-error` to curl when bootstrapping thrift.

makes sense to me! build-support/thrift/Makefile (line 50) <https://reviews.apache.org/r/42225/#comment174913> >100 but I'm not sure how this goes in non-py|java files for aurora. - John Sirois On Jan. 12, 2016, 4:51 p.m., Zame

Re: Review Request 42126: New class to allocate resources of multiple roles from offer.

> On Jan. 12, 2016, 6:49 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/Resources.java, line 50 > > > > > > Looks like an overly-aggressive find/replace. I've been endlessly > > frustrated by

Re: Review Request 42126: New class to allocate resources of multiple roles from offer.

#x27;ve been endlessly > > frustrated by intellij doing this when you forget to untick the "search > > text and comments" option (which is always ticked). > > > > Please skim through the patch to find other spots impacted. > > John Sirois wrote:

Re: Review Request 42321: fix typo in the user guide about Task Updates

> On Jan. 14, 2016, 2:24 p.m., John Sirois wrote: > > Ship It! Thanks for going from PR -> RB! - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42321/#

Re: Review Request 42321: fix typo in the user guide about Task Updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42321/#review114576 --- Ship it! Ship It! - John Sirois On Jan. 14, 2016, 2:23 p.m

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

/AsyncUtil.java (line 40) <https://reviews.apache.org/r/42328/#comment175469> final - John Sirois On Jan. 14, 2016, 4:27 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/#review114611 --- Ship it! Ship It! - John Sirois On Jan. 14, 2016, 4:58 p.m

Re: Review Request 42332: Trigger shutdown on task pruning failure.

you had to introduce below as well. Further, it'll give you 1 nice spot to add a comment explaining why termination on 1 failed prune is sane; ie: you can point out the inevitable history growth issue and that rolling back is better than waiting for the failure and then rolling back. - John

Re: Review Request 42332: Trigger shutdown on task pruning failure.

> On Jan. 15, 2016, 4:33 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > line 152 > > <https://reviews.apache.org/r/42332/diff/1/?file=1197802#file1197802line152> > > > > You could centraliz

Review Request 42375: Make required mesos log args required.

-SNAPSHOT.jar:na] ``` Thanks, John Sirois

Re: Review Request 42375: Make required mesos log args required.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/#review114823 --- On Jan. 15, 2016, 5:40 p.m., John Sirois wrote: > > ---

Re: Review Request 42375: Make required mesos log args required.

] at org.apache.aurora.scheduler.app.SchedulerMain.applyStaticArgumentValues(SchedulerMain.java:230) [aurora-0.12.0-SNAPSHOT.jar:na] at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:203) [aurora-0.12.0-SNAPSHOT.jar:na] ``` Thanks, John Sirois

Re: Review Request 42375: Make required mesos log args required.

at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:209) ``` Thanks, John Sirois

Re: Review Request 42375: Make required mesos log args required.

at org.apache.aurora.scheduler.log.mesos.MesosLogStreamModule.(MesosLogStreamModule.java:110) at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:209) ``` Thanks, John Sirois

Re: Review Request 42387: working version of jessie builds

uft to kill? - John Sirois On Jan. 16, 2016, 12:26 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Review Request 42445: Upgrade pants to 0.0.68.

(-) Diffs - pants.ini a5fbfba81e1444ddf144db33dd3321aa06365385 Diff: https://reviews.apache.org/r/42445/diff/ Testing --- Locally green: ``` ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 39170: Fix NPE on accessing crons set at impossible dates

/ which was based of this RB and submitted. Thanks Brice! - John Sirois On Oct. 9, 2015, 6:41 a.m., Brice Arnould wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 42475: Fixup broken jmh benchmarks.

on master: `./gradlew jmh -Pbenchmarks='StatusUpdateBenchmark.*'` `./gradlew jmh -Pbenchmarks='ThriftApiBenchmark.*'` I also checked that a full run of `./gradlew jmh` was now green for all benchmarks. Thanks, John Sirois

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

opefully - the norm, is that The Params methods should either return Optional and have no default implementation or else have a default implementation. Non-Optional pure abstract Params should be viewed with mild suspicion. - John Sirois On Jan. 18, 2016,

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

che.org/r/41804/#comment176090> Refactor flub - John Sirois On Jan. 19, 2016, 10:31 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115197 --- Ship it! Ship It! - John Sirois On Jan. 19, 2016, 10:49 a.m

Re: Review Request 42387: working version of jessie builds

tps://reviews.apache.org/r/42387/#comment176121> Spoke with Dmitriy offline, but it turns out passing `--no-close` is critical here to un-blackhole logs and let stderr/stdout stay open and routed through the standard systemd journalling. - John Sirois On Jan. 16, 2016, 12:26 a.m., Dmitriy Shirchenko

Re: Review Request 42445: Upgrade pants to 0.0.68.

o Joe! - John Sirois On Jan. 17, 2016, 4:42 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 42387: working version of jessie builds

ra-scheduler.pid` - who uses `/var/run/aurora/`? - John Sirois On Jan. 19, 2016, 5:04 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 42532: Revert "Shim interfaces to preface args system overhaul."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42532/#review115309 --- Ship it! Ship It! - John Sirois On Jan. 19, 2016, 6:28 p.m

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

injected with it; both of which, if sticking with an enum, will require a lazy approach. In short - not sure this second sentence should stay. - John Sirois On Jan. 20, 2016, 12:47 p.m., Bill Farner wrote: > > --- > This is a

Re: Review Request 42387: working version of jessie builds

il. To reply, visit: > https://reviews.apache.org/r/42387/ > --- > > (Updated Jan. 19, 2016, 5:59 p.m.) > > > Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner. > > > Repository: aurora-packaging > > > Description >

Re: Review Request 42387: working version of jessie builds

unless there are very large delays - so hang on for more feedback from others. - John Sirois On Jan. 19, 2016, 5:59 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

submit void work to the `CompletionService` 2x in `registerInactiveTask` 3. in this run loop `take` void futures from it and `get` their void result - the exceptions will propagate naturally, 1st come, 1st serve, no trampling. - John Sirois On Jan. 20, 2016, 3:39 p.m., Zameer Manji

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

> On Jan. 20, 2016, 4:26 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > line 154 > > <https://reviews.apache.org/r/42332/diff/3/?file=1203998#file1203998line154> > > > > I think this sam

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review115524 --- Ship it! Ship It! - John Sirois On Jan. 20, 2016, 3:39 p.m

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

tps://reviews.apache.org/r/42332/#review115663 --- On Jan. 20, 2016, 3:39 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42332/ &g

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

> On Jan. 20, 2016, 4:39 p.m., John Sirois wrote: > > Ship It! As Maxim points out below, the current `run` will consume a thread, so ship-it retracted! - John --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

earch=LOCK#transaction_isolation since "3" is so cryptic and folks - like me just now - will want to double check. - John Sirois On Jan. 21, 2016, 1:25 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-m

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

> On Jan. 21, 2016, 1:28 p.m., John Sirois wrote: > > IIUC the MVCC capabilities in 1.4+ should prevent table locks on all but > > DDL stuff. Hmm - more to the story: "If MVCC is enabled, changing the lock mode (LOCK_MODE) has no effect." ... Maybe turning on MVCC is

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42613/#review115693 --- Ship it! Ship It! - John Sirois On Jan. 21, 2016, 1:40 p.m

Re: Review Request 42613: Enable READ COMMITTED transaction isolation.

> On Jan. 21, 2016, 1:28 p.m., John Sirois wrote: > > IIUC the MVCC capabilities in 1.4+ should prevent table locks on all but > > DDL stuff. > > John Sirois wrote: > Hmm - more to the story: "If MVCC is enabled, changing the lock mode > (LOCK_MODE) has

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

/TaskHistoryPruner.java (line 145) <https://reviews.apache.org/r/42332/#comment176774> I was envisioning put and take, no schedules, no batching. The queue could even be a SynchronousQueue holding ~0 elements. Any reason not to simplify in that way? - John Sirois On Jan. 21, 2016, 3:55 p.m.,

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review115749 --- Ship it! Ship It! - John Sirois On Jan. 21, 2016, 4:43 p.m

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

------- > > (Updated Jan. 21, 2016, 4:43 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Bugs: AURORA-1582 > https://issues.apache.org/jira/browse/AURORA-1582 > > > Repository:

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

> On Jan. 21, 2016, 4:20 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > line 164 > > <https://reviews.apache.org/r/42332/diff/3-5/?file=1203998#file1203998line164> > > > > I was envisioning

Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

/LifecycleShutdownListenerTest.java 8d19c04a96fccdd9594ecf783fc797c2b76140c7 Diff: https://reviews.apache.org/r/42639/diff/ Testing --- Locally green: `./gradlew -P build`. Thanks, John Sirois

Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.

> On Jan. 21, 2016, 4:20 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > line 164 > > <https://reviews.apache.org/r/42332/diff/3-5/?file=1203998#file1203998line164> > > > > I was envisioning

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

enerated e-mail. To reply, visit: https://reviews.apache.org/r/42639/#review115770 --- On Jan. 21, 2016, 7:47 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

ally generated e-mail. To reply, visit: https://reviews.apache.org/r/42639/#review115768 ------- On Jan. 21, 2016, 7:47 p.m., John Sirois wrote: > > --- > This is an au

Re: Review Request 42628: Add storage API methods for fetching amd mutating a task by ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42628/#review115780 --- Ship it! Ship It! - John Sirois On Jan. 21, 2016, 6:25 p.m

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42565/#review115765 ------- On Jan. 20, 2016, 1:21 p.m., Bill Farner wrote: > > --

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

app.SchedulerMain' > ``` > > to > ``` > mainClassName = 'com.my.package.CustomScheduler' > ``` > > Maxim Khutornenko wrote: > This means anyone who wants to add custom modules would be forced to fork > Aurora codebase instead of

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

app.SchedulerMain' > ``` > > to > ``` > mainClassName = 'com.my.package.CustomScheduler' > ``` > > Maxim Khutornenko wrote: > This means anyone who wants to add custom modules would be forced to fork > Aurora codebase instead of

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

push it to the next contributor that needs to break the schema. - John Sirois On Jan. 22, 2016, 1:11 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

> On Jan. 22, 2016, 11:28 a.m., John Sirois wrote: > > The mechanics of the change lgtm, but is there some other way to add schema > > / data updates to a new aurora release such that they get applied after > > recovering the log but before doing anything else? I guess

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42646/#review115892 --- Ship it! Ship It! - John Sirois On Jan. 22, 2016, 1:11 a.m

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42646/#review115932 --- Ship it! Ship It! - John Sirois On Jan. 22, 2016, 2:21 p.m

Review Request 42699: Upgrade pants to 0.0.69.

insertion(+), 1 deletion(-) Diffs - pants.ini 7df23ebf1b05636515e22cc22244ed5e854d2cf8 Diff: https://reviews.apache.org/r/42699/diff/ Testing --- Locally green: ``` ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Review Request 42748: [1/3] Introduce a thrift java code generator.

tings.gradle b097e2fd958fa0ce6076fc104eb3890c4029295d Diff: https://reviews.apache.org/r/42748/diff/ Testing --- Locally green: `./gradlew -Pq test` Thanks, John Sirois

Re: Review Request 42748: [1/3] Introduce a thrift java code generator.

this 3 RB proposal. - John Sirois On Jan. 25, 2016, 3:28 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 42749: [2/3] Add an annotation processor to generate db views.

this 3 RB proposal. - John Sirois On Jan. 25, 2016, 3:43 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 42749: [2/3] Add an annotation processor to generate db views.

Field PRE-CREATION mutablePeerGen/src/test/resources/org/apache/aurora/test/peer/artisinal/Peer PRE-CREATION Diff: https://reviews.apache.org/r/42749/diff/ Testing --- Locally green: `./gradlew -Pq test` Thanks, John Sirois

Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

this 3 RB proposal. - John Sirois On Jan. 25, 2016, 3:52 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 42749: [2/3] Add an annotation processor to generate db views.

gt; "@ReviewBot retry" Unfortunately, this is expected. I had to hand-craft the diff to exclude .gitignore, build.gradle and settings.gradle. A real AuroraBot run will only happen if/when https://reviews.apache.org/r/42748/ and this patch series in-general is deemed a go at which point this RB can be rebased off 1/3 landing on master.

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

ettings.gradle. A real AuroraBot run will only happen if/when https://reviews.apache.org/r/42749/ and this patch series in-general is deemed a go at which point this RB can be rebased off 2/3 landing on master. - John --- Th

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

://reviews.apache.org/r/42756/diff/ Testing --- Locally green: ``` ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

part) - that was the only automated testing revealing the problem previously. Thanks, John Sirois

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

---- On Jan. 26, 2016, 8 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42801/ > --

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

- John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42801/#review116356 --- On Jan. 26, 2016, 8 a.m., John Sirois wrote

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42801/#review116359 --- @ReviewBot retry - John Sirois On Jan. 26, 2016, 8 a.m., John

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

``` It's the latter - e2e (krb part) - that was the only automated testing revealing the problem previously. Thanks, John Sirois

Review Request 42804: Remove job update `maxWaitToInstanceRunningMs` field.

``` Thanks, John Sirois

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

``` Thanks, John Sirois

Re: Review Request 42811: Remove deprecated fields made redundant by JobKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42811/#review116406 --- Ship it! Ship It! - John Sirois On Jan. 26, 2016, 11:37 a.m

Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

: ``` ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 42811: Remove deprecated fields made redundant by JobKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42811/#review116415 --- Ship it! Ship It! - John Sirois On Jan. 26, 2016, 12:04 p.m

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

de0973d7901301433c3d9dca7bac8555a74604c9 Diff: https://reviews.apache.org/r/42816/diff/ Testing --- Locally green: ``` ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

de0973d7901301433c3d9dca7bac8555a74604c9 Diff: https://reviews.apache.org/r/42816/diff/ Testing --- Locally green: ``` ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

: ``` ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` Thanks, John Sirois

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

visit: https://reviews.apache.org/r/42816/#review116419 ------- On Jan. 26, 2016, 12:26 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42816/ > ---

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

? you still need to validate that > > only one type was specified and make sure we don't default to one w/out > > giving feedback to the user. this is expected to be a pystachio error. > > John Sirois wrote: > Well - the check is just a type-check, which pystachio al

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

? you still need to validate that > > only one type was specified and make sure we don't default to one w/out > > giving feedback to the user. this is expected to be a pystachio error. > > John Sirois wrote: > Well - the check is just a type-check, which pystachio al

<    1   2   3   4   5   6   7   8   >