/scheduler/updater/JobUpdaterIT.java
5b00d3cf72adc154f130bb067723c3bd6960a314
Diff: https://reviews.apache.org/r/26102/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54861
---
On Sept. 29, 2014, 8:04 p.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54911
---
On Sept. 29, 2014, 10:57 p.m., Maxim Khutornenko wrote
/scheduler/updater/JobUpdaterIT.java
4934cbbc55e14756c7719be1bd7bb8dc1f31592f
Diff: https://reviews.apache.org/r/26102/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
build
Thanks,
Maxim Khutornenko
the noop
condition in the controller only?
- Maxim Khutornenko
On Sept. 30, 2014, 12:59 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26158
/#comment95048
Move thresholds to constants for better visibility?
- Maxim Khutornenko
On Sept. 27, 2014, 11:25 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26123
---
On Sept. 25, 2014, 10:02 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25481
revert.
Maxim Khutornenko wrote:
Feels kind of redundant but I am OK reverting all but the last
desiredState.instances validation (AURORA-756).
On the second thought, just removing that assertion is not going to be enough.
Will address AURORA-756 separately.
- Maxim
,
Maxim Khutornenko
/updater/JobUpdaterIT.java
5b00d3cf72adc154f130bb067723c3bd6960a314
Diff: https://reviews.apache.org/r/26102/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
will fire.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26102/#review54751
---
On Sept. 26, 2014, 9:34 p.m., Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26106/#review54754
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 26, 2014, 10:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26024/#review54545
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 25, 2014, 7:09
---
On Sept. 24, 2014, 5:41 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970
./pants src/test/python:all
Thanks,
Maxim Khutornenko
./pants src/test/python:all
Thanks,
Maxim Khutornenko
On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote:
src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java,
line 91
https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91
minor nit I think the proper spelling is RETRIABLE
Maxim Khutornenko
/python:all
Thanks,
Maxim Khutornenko
a894a3aca18d3101543c3520ab4d547d63cd6d61
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
5b00d3cf72adc154f130bb067723c3bd6960a314
Diff: https://reviews.apache.org/r/25481/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
? Events without update ID would not make any sense.
src/main/thrift/org/apache/aurora/gen/api.thrift
https://reviews.apache.org/r/25969/#comment94547
s/../.
- Maxim Khutornenko
On Sept. 24, 2014, 12:44 a.m., Bill Farner wrote
.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54424
---
On Sept. 24, 2014, 12:29 a.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25969/#review54442
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 24, 2014, 6:02
82f1894d939a132cf0a9e8172de54845ad48a19c
src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java
e7755279970230be101345ac1d86bd49c77b550c
Diff: https://reviews.apache.org/r/26002/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
/SchedulerThriftInterfaceTest.java
21e8a8ba5c47f549133ea339899bf0e5097ccbb9
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
40156c211a346664c0d2f174235efb2049cf3bb9
Diff: https://reviews.apache.org/r/25812/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26012/#review54492
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 25, 2014, 1:36
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26015/#review54506
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 25, 2014, 2:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25812/#review54168
---
On Sept. 23, 2014, 12:59 a.m., Maxim Khutornenko wrote:
---
This is an automatically
/SchedulerThriftInterfaceTest.java
21e8a8ba5c47f549133ea339899bf0e5097ccbb9
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
40156c211a346664c0d2f174235efb2049cf3bb9
Diff: https://reviews.apache.org/r/25812/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
this with a constant that we define. Thrift
produces a mutable static Set for this, which comes with risk.
Maxim Khutornenko wrote:
The only place it's used in is already wrapping it into EnumSet.
What specifically in JobUpdateControllerImpl? Could not find anything
suitable
21e8a8ba5c47f549133ea339899bf0e5097ccbb9
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
40156c211a346664c0d2f174235efb2049cf3bb9
Diff: https://reviews.apache.org/r/25812/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
/25953/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25953/#review54328
---
On Sept. 23, 2014, 8:38 p.m., Maxim Khutornenko wrote
aa7feb916f879f60d46ebaf53e47ba30d861c7fa
Diff: https://reviews.apache.org/r/25953/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25958/#review54345
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 23, 2014, 10:08
://reviews.apache.org/r/25812/#review54316
---
On Sept. 23, 2014, 4:48 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
---
On Sept. 23, 2014, 4:48 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25812
/thrift/SchedulerThriftInterfaceTest.java
21e8a8ba5c47f549133ea339899bf0e5097ccbb9
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
40156c211a346664c0d2f174235efb2049cf3bb9
Diff: https://reviews.apache.org/r/25812/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim
21e8a8ba5c47f549133ea339899bf0e5097ccbb9
src/test/python/apache/aurora/client/api/test_scheduler_client.py
527448f882c12fe9bb51ce2a0a4c330188838282
Diff: https://reviews.apache.org/r/25970/diff/
Testing
---
gradle -Pq build
./pants src/test/python:all
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25963/#review54373
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 23, 2014, 11:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25872/#review54138
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 20, 2014, 3:06
, visit:
https://reviews.apache.org/r/25857/#review54071
---
On Sept. 19, 2014, 11:10 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
-Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25859/#review54159
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 22, 2014, 6:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/#review54171
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 22, 2014, 6:52
/SchedulerThriftInterfaceTest.java
336cada625b85618486660fc24f3e83a312609f8
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
40156c211a346664c0d2f174235efb2049cf3bb9
Diff: https://reviews.apache.org/r/25812/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
336cada625b85618486660fc24f3e83a312609f8
Diff: https://reviews.apache.org/r/25857/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25815/#review53988
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 19, 2014, 6:42
,
Maxim Khutornenko
/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
336cada625b85618486660fc24f3e83a312609f8
Diff: https://reviews.apache.org/r/25857/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
83ac034cff009530e5e16c0613b9d085f3b908d8
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
336cada625b85618486660fc24f3e83a312609f8
Diff: https://reviews.apache.org/r/25857/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
/JobUpdateDetailsMapper.xml
https://reviews.apache.org/r/25859/#comment94013
This will fail unit tests as is.
- Maxim Khutornenko
On Sept. 20, 2014, 12:28 a.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply
On Sept. 17, 2014, 9:04 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java, line 45
https://reviews.apache.org/r/25753/diff/2/?file=692885#file692885line45
Missing xml docs for public methods.
Bill Farner wrote:
We usually don't
On Sept. 18, 2014, 12:56 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java, line 152
https://reviews.apache.org/r/25760/diff/1/?file=693090#file693090line152
Technically, the outBytes may already be disposed at this point. Move
return
/api.thrift.md5
c5838761783d85a547688d4f708a75c1fd240201
Diff: https://reviews.apache.org/r/25750/diff/
Testing
---
gradle -Pq build
./pants src/test/python:all
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25791/#review53870
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 18, 2014, 8:48
Diff: https://reviews.apache.org/r/25812/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25807/#review53929
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 19, 2014, 12:27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25741/#review53708
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 17, 2014, 5:15
/api.thrift.md5
c5838761783d85a547688d4f708a75c1fd240201
Diff: https://reviews.apache.org/r/25750/diff/
Testing
---
gradle -Pq build
./pants src/test/python:all
Thanks,
Maxim Khutornenko
., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25750/
---
(Updated Sept. 17, 2014, 8:40 p.m.)
Review
if this is purely for auditing and never used internally, I still think
it's useful.
Bill Farner wrote:
Should we change direction a bit and just store the original
JobUpdateRequest?
Maxim Khutornenko wrote:
Storing instance count is completely redundant and prone to integrity
problems (i.e
to reviewers :)
- Maxim Khutornenko
On Sept. 18, 2014, 12:20 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25760
/updateSettings.html
https://reviews.apache.org/r/25259/#comment93245
...forward roll. - this is no longer correct as we use this setting for
both forward and back roll. Mind updating this and api.thrift?
- Maxim Khutornenko
On Sept. 16, 2014, 6:06 p.m., David McLaughlin wrote
On Sept. 16, 2014, 6:12 p.m., Maxim Khutornenko wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html,
line 41
https://reviews.apache.org/r/25259/diff/9/?file=690739#file690739line41
...forward roll. - this is no longer correct as we use this setting
there until we iron out the async updates. We could
clearly mark new server side update options as BETA in command help to avoid
any confusion. I think the long term consistency here is more important than
temporary ambiguity.
- Maxim Khutornenko
On Sept. 11, 2014, 2:55 p.m., Mark Chu-Carroll wrote
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
0be4d78dd737b34f8a58276be9ffd7aeaa7f95bb
Diff: https://reviews.apache.org/r/25653/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
if the goal of
organizing commands by nouns is to make it intuitive, i think update start
is less natural than job update.
-=Bill
On Mon, Sep 15, 2014 at 10:25 AM, Mark Chu-Carroll
mchucarr...@twopensource.com wrote:
On Sept. 15, 2014, 12:04 p.m., Maxim Khutornenko wrote:
src/main/python
2151f02828f6a349d93dbc9ad1bf522891172e34
Diff: https://reviews.apache.org/r/25673/diff/
Testing
---
./pants src/test/python/apache/aurora/client/commands::
Thanks,
Maxim Khutornenko
85b8423ab604d44406cb31000f63f8a45885296c
src/test/resources/org/apache/aurora/gen/api.thrift.md5
85de4b3e2915f7450ca9f88e2f3a875d9d821885
Diff: https://reviews.apache.org/r/25455/diff/
Testing
---
gradle -Pq build
./pants src/test/python:all
Thanks,
Maxim Khutornenko
On Sept. 11, 2014, 11:41 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 398
https://reviews.apache.org/r/25529/diff/1/?file=685014#file685014line398
Spent quite a bit of time reading this method. Would
., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25459/
---
(Updated Sept. 9, 2014, 12:30 a.m.)
Review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25481/#review53061
---
On Sept. 9, 2014, 7:46 p.m., Maxim Khutornenko wrote
://reviews.apache.org/r/25481/#review53073
---
On Sept. 9, 2014, 7:46 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
, but will instead
present as an internal error (based on LoggingInterceptor, which handles
uncaught exceptions).
Maxim Khutornenko wrote:
ERROR type is correctly consumed by the client. Here is an example from
vagrant:
```INFO] Response from scheduler: ERROR (message: TaskQuery
---
Dropping synchronized from validateIfLocked()
Diffs
-
src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java
8befecaf4f13c0b890b452bc7b9c0618725b8c41
Diff: https://reviews.apache.org/r/25556/diff/
Testing
---
right..
Thanks,
Maxim Khutornenko
: https://reviews.apache.org/r/25556/diff/
Testing
---
right..
Thanks,
Maxim Khutornenko
.
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
https://reviews.apache.org/r/25529/#comment92575
s/time.s/times.
- Maxim Khutornenko
On Sept. 11, 2014, 4:53 a.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25556/#review53129
---
On Sept. 11, 2014, 9:08 p.m., Maxim Khutornenko wrote
/LockManagerImpl.java
8befecaf4f13c0b890b452bc7b9c0618725b8c41
src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java
791aa6fed7380999ea9257d92d16b69ed89dcea0
Diff: https://reviews.apache.org/r/25556/diff/
Testing
---
right..
Thanks,
Maxim Khutornenko
no tasks returned:
log(ERROR): Internal error executing command: 'NoneType' object is not iterable
As opposed to aurora status:
INFO] No tasks found.
- Maxim Khutornenko
On Sept. 10, 2014, 5:38 p.m., Mark Chu-Carroll wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25505/#review52926
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 10, 2014, 7:34
/aurora/client/commands/util.py
21b8830df5a3eccc7d36067369fc16cc5fd9de2a
Diff: https://reviews.apache.org/r/25519/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
'***'
***
+ exit 0```
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52945
---
On Sept. 10, 2014, 7:53 p.m., Maxim Khutornenko
/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
0d51f7dc367081f72090736e36605bf363f3395e
Diff: https://reviews.apache.org/r/25481/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25450/#review52776
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 9, 2014, 7:43
On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
line 277
https://reviews.apache.org/r/25259/diff/1/?file=683446#file683446line277
This seems to be too short to make any visual difference but could
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25483/#review52798
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 9, 2014, 9:05
on. Any chance it could be fixed before piling
up more test cases like this?
- Maxim Khutornenko
On Sept. 8, 2014, 6:37 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
/api.thrift.md5
85de4b3e2915f7450ca9f88e2f3a875d9d821885
Diff: https://reviews.apache.org/r/25455/diff/
Testing
---
gradle -Pq build
./pants src/test/python:all
Thanks,
Maxim Khutornenko
/SchedulerThriftInterfaceTest.java
0d51f7dc367081f72090736e36605bf363f3395e
Diff: https://reviews.apache.org/r/25459/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
://reviews.apache.org/r/25459/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
/r/25459/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
/aurora/scheduler/http/ui/updateSettings.html
https://reviews.apache.org/r/25259/#comment91552
s/set/subset?
Also, suggest adding: All instances will be affected if this is not set.
- Maxim Khutornenko
On Sept. 9, 2014, 1:05 a.m., David McLaughlin wrote
On Sept. 9, 2014, 1:45 a.m., Maxim Khutornenko wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
line 277
https://reviews.apache.org/r/25259/diff/1/?file=683446#file683446line277
This seems to be too short to make any visual difference but could
On Sept. 4, 2014, 10:17 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactory.java,
lines 94-96
https://reviews.apache.org/r/25356/diff/1/?file=679021#file679021line94
If I am reading it right the update will still proceed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25356/#review52479
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 5, 2014, 5:52
/25357/#review52453
---
On Sept. 5, 2014, 12:23 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25357
6654c1675ac9f5f7d481e115cea7c224fb212467
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java
d02714c846a521ff9ac3e53d991731314e714ae2
Diff: https://reviews.apache.org/r/25357/diff/
Testing
---
gradle -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24815/#review52455
---
On Sept. 5, 2014, 12:09 a.m., Maxim Khutornenko wrote
601 - 700 of 1219 matches
Mail list logo
