Review Request 25297: Make config-file an optional parameter for job restart.

2014-09-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25297/ --- Review request for Aurora. Repository: aurora Description --- Make

Re: Review Request 25297: Make config-file an optional parameter for job restart.

2014-09-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25297/ --- (Updated Sept. 3, 2014, 10:06 a.m.) Review request for Aurora. Bugs:

Re: Review Request 25297: Make config-file an optional parameter for job restart.

2014-09-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25297/ --- (Updated Sept. 3, 2014, 10:07 a.m.) Review request for Aurora, David

Review Request 25300: Add a state machine to react to job update status changes.

2014-09-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25300/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs:

Re: Review Request 25257: Add a separate main class that runs the scheduler in local mode.

2014-09-03 Thread Bill Farner
On Sept. 3, 2014, 1:40 a.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, line 175 https://reviews.apache.org/r/25257/diff/2/?file=674608#file674608line175 Can this TODO be dropped now? Sure, done. - Bill

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
On Sept. 3, 2014, 1:47 a.m., Joe Smith wrote: src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 aurora job run? Joe Smith wrote: Kevin and Toby, can you two take a look at this ASAP? I'd like to

Re: Review Request 25297: Make config-file an optional parameter for job restart.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25297/#review52183 --- src/test/python/apache/aurora/client/cli/test_restart.py

Re: Review Request 25285: Upgrade to latest in jetty 7.x series.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25285/#review52186 --- Ship it! Ship It! - Joshua Cohen On Sept. 3, 2014, 5:23 a.m.,

Re: Review Request 25285: Upgrade to latest in jetty 7.x series.

2014-09-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25285/#review52190 --- Ship it!

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/#review52192 --- Ship it! Ship It! - Brian Wickman On Sept. 3, 2014, 4:06 a.m.,

Re: Review Request 25300: Add a state machine to react to job update status changes.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25300/#review52193 --- Ship it! Ship It! - Joshua Cohen On Sept. 3, 2014, 4:02 p.m.,

Re: Review Request 25300: Add a state machine to react to job update status changes.

2014-09-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25300/#review52195 ---

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/#review52198 --- Ship it!

Re: Review Request 25285: Upgrade to latest in jetty 7.x series.

2014-09-03 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25285/#review52203 --- Ship it! Ship It! - David McLaughlin On Sept. 3, 2014, 5:23

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joe Smith
On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote: src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 aurora job run? Joe Smith wrote: Kevin and Toby, can you two take a look at this ASAP? I'd like to

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-03 Thread Joe Smith
On Sept. 3, 2014, 10:42 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/executor/thermos_task_runner.py, line 23 https://reviews.apache.org/r/25208/diff/5/?file=674717#file674717line23 mesos_pb2 looks a bit cryptic here. How about the approach you sued elsewhere:

Re: Review Request 25297: Make config-file an optional parameter for job restart.

2014-09-03 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25297/#review52208 --- Ship it! Ship It! - David McLaughlin On Sept. 3, 2014, 2:07

Re: Review Request 25204: Adding get job update client APIs.

2014-09-03 Thread Maxim Khutornenko
On Sept. 2, 2014, 7:35 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/__init__.py, line 176 https://reviews.apache.org/r/25204/diff/1/?file=672539#file672539line176 Nit - but why are you changing the parameter comment syntax? We don't use the double-dash

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Mark Chu-Carroll
At the moment, there's two end-to-end tests: test_end_to_end.sh, and test_end_to_end_v2.sh. Since this is the v1 test, it should use v1. -Mark On Wed, Sep 3, 2014 at 2:05 PM, Joe Smith yasumo...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit:

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52210 --- Ship it! examples/vagrant/upstart/mesos-slave.conf

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/ --- (Updated Sept. 3, 2014, 6:13 p.m.) Review request for Aurora, Kevin Sweeney,

Review Request 25309: Fix output formatting error in job status.

2014-09-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25309/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs:

Re: Review Request 25309: Fix output formatting error in job status.

2014-09-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25309/#review52212 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 3, 2014, 6:17

Re: Review Request 25204: Adding get job update client APIs.

2014-09-03 Thread Mark Chu-Carroll
On Sept. 2, 2014, 3:35 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/__init__.py, line 176 https://reviews.apache.org/r/25204/diff/1/?file=672539#file672539line176 Nit - but why are you changing the parameter comment syntax? We don't use the double-dash

Re: Review Request 25204: Adding get job update client APIs.

2014-09-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25204/#review52214 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 29, 2014, 6:28

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/ --- (Updated Sept. 3, 2014, 6:33 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
On Sept. 3, 2014, 1:47 a.m., Joe Smith wrote: src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 aurora job run? Joe Smith wrote: Kevin and Toby, can you two take a look at this ASAP? I'd like to

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
On Sept. 3, 2014, 6:10 p.m., Kevin Sweeney wrote: examples/vagrant/upstart/mesos-slave.conf, line 28 https://reviews.apache.org/r/25206/diff/1/?file=672551#file672551line28 Can you add a comment explaining why this is necessary (preferably with a link to a bug where we will fix

Re: Review Request 25285: Upgrade to latest in jetty 7.x series.

2014-09-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25285/#review52221 --- Ship it! This patch actually pulls in the bit of

Re: Review Request 25300: Add a state machine to react to job update status changes.

2014-09-03 Thread Bill Farner
On Sept. 3, 2014, 5:33 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java, lines 74-76 https://reviews.apache.org/r/25300/diff/1/?file=675222#file675222line74 This will also throw for in-place transitions (e.g.

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

2014-09-03 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/#review52223 --- src/main/python/apache/thermos/core/runner.py

Re: Review Request 25300: Add a state machine to react to job update status changes.

2014-09-03 Thread Maxim Khutornenko
On Sept. 3, 2014, 5:33 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java, lines 74-76 https://reviews.apache.org/r/25300/diff/1/?file=675222#file675222line74 This will also throw for in-place transitions (e.g.

Re: Review Request 25300: Add a state machine to react to job update status changes.

2014-09-03 Thread Bill Farner
On Sept. 3, 2014, 5:33 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java, lines 74-76 https://reviews.apache.org/r/25300/diff/1/?file=675222#file675222line74 This will also throw for in-place transitions (e.g.

Re: Review Request 25300: Add a state machine to react to job update status changes.

2014-09-03 Thread Bill Farner
On Sept. 3, 2014, 5:33 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java, lines 74-76 https://reviews.apache.org/r/25300/diff/1/?file=675222#file675222line74 This will also throw for in-place transitions (e.g.

Re: Review Request 25300: Add a state machine to react to job update status changes.

2014-09-03 Thread Maxim Khutornenko
On Sept. 3, 2014, 5:33 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java, lines 74-76 https://reviews.apache.org/r/25300/diff/1/?file=675222#file675222line74 This will also throw for in-place transitions (e.g.

Re: Review Request 25300: Add a state machine to react to job update status changes.

2014-09-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25300/#review52231 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 3, 2014, 4:02

Review Request 25311: Checking for cron jobs in startJobUpdate()

2014-09-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25311/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 25311: Checking for cron jobs in startJobUpdate()

2014-09-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25311/#review52232 --- Ship it!

Re: Review Request 25255: Implement server-driven update commands.

2014-09-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25255/#review52220 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52235 --- Ship it! Ship It! - David Robinson On Sept. 3, 2014, 6:33 p.m.,

Re: Review Request 25311: Checking for cron jobs in startJobUpdate()

2014-09-03 Thread Maxim Khutornenko
On Sept. 3, 2014, 7:49 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1343 https://reviews.apache.org/r/25311/diff/1/?file=675806#file675806line1343 Cron jobs may only be updated by calling replaceCronTemplate. Sure,

Re: Review Request 25311: Checking for cron jobs in startJobUpdate()

2014-09-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25311/ --- (Updated Sept. 3, 2014, 8:52 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/ --- (Updated Sept. 3, 2014, 8:55 p.m.) Review request for Aurora, David Robinson,

Re: Review Request 25255: Implement server-driven update commands.

2014-09-03 Thread Mark Chu-Carroll
On Sept. 2, 2014, 1:32 p.m., Joshua Cohen wrote: Is the command name supdate up for debate? I'm not in love with it ;). It's a temporary thing. (Came up with it during a discussion with Bill.) If we start adding this stuff to the existing update command, then existing users are going to

Re: Review Request 24815: Refactoring SchedulerCore final part.

2014-09-03 Thread Maxim Khutornenko
On Sept. 2, 2014, 10:36 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, line 120 https://reviews.apache.org/r/24815/diff/1/?file=662756#file662756line120 At first glance, this is odd since ITaskConfig contains the components of a

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52245 --- I ran this before committing and it still fails (aurora run hangs).

Re: Review Request 24915: Adding initial GC task delay on scheduler restart.

2014-09-03 Thread Maxim Khutornenko
On Sept. 2, 2014, 4:43 p.m., Bill Farner wrote: I'm concerned that the problem we're solving is underspecified. An immediate issue i have with this patch is that it introduces a memory leak (in practice, this is hidden with default settings due to failover failover hides this).

Re: Review Request 25204: Adding get job update client APIs.

2014-09-03 Thread Maxim Khutornenko
On Sept. 2, 2014, 7:35 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/__init__.py, line 232 https://reviews.apache.org/r/25204/diff/1/?file=672539#file672539line232 I think this would be clearer inlined. Right now, it's pretty much an alternate name for

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/ --- (Updated Sept. 3, 2014, 10:40 p.m.) Review request for Aurora, David Robinson,

Re: Review Request 25309: Fix output formatting error in job status.

2014-09-03 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25309/#review52257 --- Ship it! Ship It! - David McLaughlin On Sept. 3, 2014, 6:17

Review Request 25319: Tweak contributors doc to add details on finding newbie issues.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25319/ --- Review request for Aurora and Bill Farner. Repository: aurora Description