/resources to
match other conventions? As far as I can tell it should be a quick sed
one-liner.
- Kevin Sweeney
On Oct. 29, 2014, 4:38 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
-click) works. Find
usages works. Py.Test works if configured manually. Not a great experience, but
better than no IDE whatsoever for some things.
Thanks,
Kevin Sweeney
sit:
https://reviews.apache.org/r/27364/#review59093
-----------
On Oct. 29, 2014, 5:39 p.m., Kevin Sweeney wrote:
>
> ---
> This is an automatically generated
ate
PYTHONPATH=src/main/python py.test src/test/python
Tested PyCharm Community Edition 3.4. Basic navigation (Ctrl-click) works. Find
usages works. Py.Test works if configured manually. Not a great experience, but
better than no IDE whatsoever for some things.
Thanks,
Kevin Sweeney
hon
Tested PyCharm Community Edition 3.4. Basic navigation (Ctrl-click) works. Find
usages works. Py.Test works if configured manually. Not a great experience, but
better than no IDE whatsoever for some things.
Thanks,
Kevin Sweeney
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27364/#review59135
---
On Oct. 29, 2014, 6:06 p.m., Kevin Sweeney wrote:
>
> ---
;t include the year.
Fixed.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27364/#review59205
---
On Oct. 29
PATH=src/main/python py.test src/test/python
Tested PyCharm Community Edition 3.4. Basic navigation (Ctrl-click) works. Find
usages works. Py.Test works if configured manually. Not a great experience, but
better than no IDE whatsoever for some things.
Thanks,
Kevin Sweeney
ght?
> >
> > Can we do skipif platform != linux?
>
> Kevin Sweeney wrote:
> not pip-installable without setting a distro-specific custom pypi mirror
> (or building one and dropping it into third_party). Given that it's already
> ignored in the pants versi
ate
PYTHONPATH=src/main/python py.test src/test/python
Tested PyCharm Community Edition 3.4. Basic navigation (Ctrl-click) works. Find
usages works. Py.Test works if configured manually. Not a great experience, but
better than no IDE whatsoever for some things.
Thanks,
Kevin Sweeney
/CoverageReportCheck.groovy
<https://reviews.apache.org/r/27371/#comment100511>
looks like your sentence got cut off here - the
legacyClassesWithoutCoverage file?
- Kevin Sweeney
On Oct. 29, 2014, 10:09 p.m., Bill Farner wrote:
>
> -
ain/python py.test src/test/python
Tested PyCharm Community Edition 3.4. Basic navigation (Ctrl-click) works. Find
usages works. Py.Test works if configured manually. Not a great experience, but
better than no IDE whatsoever for some things.
Thanks,
Kevin Sweeney
/QuitCallback.java
<https://reviews.apache.org/r/27375/#comment100514>
to shutdown?
- Kevin Sweeney
On Oct. 29, 2014, 11:02 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
renames
this class to MoreObjects.
```java
return com.google.common.base.Objects.toStringHelper(this)
...
.toString();
```
- Kevin Sweeney
On Oct. 30, 2014, 10:11 a.m., Maxim Khutornenko wrote:
>
> --
>
> (Updated Nov. 3, 2014, 1:25 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-910
> https://issues.apache.org/jira/browse/AURORA-910
>
>
> Repository: aurora
>
>
> Description
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27545/#review59677
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 3, 2014, 3:09 p.m
/KillRetry.java
<https://reviews.apache.org/r/27467/#comment100972>
Since you're not using atomic CAS operations here you don't gain anything
by using an `AtomicLong` over a `volatile` here.
- Kevin Sweeney
On Nov. 3, 2014, 2:46 p.m., B
change)? The
build bot is sometimes flaky due to PyPI slowness and lack of retries in pants.
- Kevin Sweeney
On Nov. 3, 2014, 4:42 p.m., Dan Norris wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
tps://reviews.apache.org/r/27586/#comment101114>
Can you catch BadZipfile here as well.
- Kevin Sweeney
On Nov. 4, 2014, 11:39 a.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27586/#review59816
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 4, 2014, 11:55 a.m
ATED_SNAPSHOT,
DEFLATED_ENTRY)), definedActions);`
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java
<https://reviews.apache.org/r/27598/#comment101208>
`assertEquals(EnumSet.allOf(Op._Fields.class), definedActions);`
- Kevin Sweeney
On Nov. 4, 2014
--
On Nov. 4, 2014, 3:10 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27598/
> ---
>
> (Updated Nov. 4, 2014, 3:
> On Nov. 4, 2014, 4:43 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line
> > 318
> > <https://reviews.apache.org/r/27598/diff/1/?file=749747#file749747line318>
> >
> > why not initialize th
> On Nov. 4, 2014, 4:43 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line
> > 318
> > <https://reviews.apache.org/r/27598/diff/1/?file=749747#file749747line318>
> >
> > why not initialize th
/WriteAheadStorage.java
<https://reviews.apache.org/r/27542/#comment101358>
Note: none of these annotations will work since we're constructing this
class without Guice.
- Kevin Sweeney
On Nov. 5, 2014, 10:04 a.m., Bill F
tps://reviews.apache.org/r/27628/#comment101359>
no need for a mock here, just use the generated class.
also this is useless, as you're free to do
```py
response.fakeMadeUpProperty = 10
```
- Kevin Sweeney
On Nov. 5, 2014, 11:42 a.m., Bill F
tps://reviews.apache.org/r/27628/#comment101419>
instance=True?
- Kevin Sweeney
On Nov. 5, 2014, 4:47 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27628/#review60094
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 5, 2014, 4:47 p.m
/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
8baec047a2e0436847ff4558c56428d9d4c2da5a
Diff: https://reviews.apache.org/r/27716/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
://reviews.apache.org/r/27716/diff/
Testing (updated)
---
./gradlew -Pq build
test_end_to_end.sh
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/#review60287
-------
On Nov. 6, 2014, 6:41 p.m., Kevin Sweeney wrote:
>
> --
--------
On Nov. 6, 2014, 6:41 p.m., Kevin Sweeney wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27716/
> -
org/r/27716/diff/
Testing
---
./gradlew -Pq build
test_end_to_end.sh
Thanks,
Kevin Sweeney
/diff/
Testing
---
./gradlew -Pq build
test_end_to_end.sh
Thanks,
Kevin Sweeney
org/apache/aurora/scheduler/mesos/SchedulerDriverService.java
<https://reviews.apache.org/r/27746/#comment101796>
Futures.getUnchecked
src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java
<https://reviews.apache.org/r/27746/#comment101802>
Futures.getUnchecked
e-mail. To reply, visit:
> https://reviews.apache.org/r/27746/
> ---
>
> (Updated Nov. 7, 2014, 2:59 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-920
> h
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
/PubsubEventModule.java
cd5aa17b24209b186314f431c65062d6ed9972cb
Diff: https://reviews.apache.org/r/27762/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27542/#review60443
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 6, 2014, 1:07 p.m
eview.
Diffs (updated)
-
src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java
cd5aa17b24209b186314f431c65062d6ed9972cb
Diff: https://reviews.apache.org/r/27762/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
.
Diffs (updated)
-
src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java
cd5aa17b24209b186314f431c65062d6ed9972cb
Diff: https://reviews.apache.org/r/27762/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27779/#review60635
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 8, 2014, 11:27 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27772/#review60639
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 7, 2014, 9:53 p.m
tps://reviews.apache.org/r/27770/#comment102007>
consider making this case insensitive
- Kevin Sweeney
On Nov. 7, 2014, 8:24 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27828/#review60677
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 10, 2014, 12:50 p.m
/MaintenanceControllerImplTest.java
<https://reviews.apache.org/r/27889/#comment102292>
Is this needed anymore? Maintenance doesn't have a dependency on pubsub
anymore right?
- Kevin Sweeney
On Nov. 11, 2014, 2:42 p.m., Bill F
tps://reviews.apache.org/r/27892/#comment102495>
you can avoid the use of backslashes to escape the individual $s here if
you use <<"EOF"
- Kevin Sweeney
On Nov. 11, 2014, 3:11 p.m., Joshua Cohen wrote:
>
> ---
> This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review61044
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 12, 2014, 11:29 a.m
f the traceback above (and possibly removing the get_err()) method.
src/test/python/apache/aurora/client/cli/test_update.py
<https://reviews.apache.org/r/27848/#comment102616>
mock_api.assert_called_once_with(...)
src/test/python/apache/aurora/client/cli/ut
_client.py
<https://reviews.apache.org/r/27698/#comment102653>
replace this with a constructor kwarg on line 357 above to ensure you've
sucessfully replaced deadline with a non-forking one.
- Kevin Sweeney
On Nov. 7, 2014, 1:17
ache/aurora/client/cli/test_restart.py
<https://reviews.apache.org/r/27848/#comment102723>
strange place for an import - should be in the 3rdparty section. did you
run isort-run?
- Kevin Sweeney
On Nov. 12, 2014, 5:48 p.m., David
tps://reviews.apache.org/r/27954/#comment102726>
prefer interpolation with % review_text
over string concatenation
- Kevin Sweeney
On Nov. 12, 2014, 6:03 p.m., Bill Farner wrote:
>
> ---
> This is an automatically gener
bounded at
MAX_INT we might further consider adding a
https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/RejectedExecutionHandler.html
that logs an appropriate message and shuts down the scheduler to make
debugging easier.
- Kevin Sweeney
On Nov. 12, 2014, 5:12 p.m., Maxim Khutor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27996/#review61282
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 13, 2014, 9:05 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27947/#review61306
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 13, 2014, 11:33 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27601/#review61309
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 4, 2014, 5:23 p.m
/test_scheduler_client.py
<https://reviews.apache.org/r/27698/#comment103192>
nit: our python style uses `**kws` instead of `**kwargs`
- Kevin Sweeney
On Nov. 13, 2014, 5:03 p.m., David McLaughlin wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28021/#review61588
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 13, 2014, 5:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28066/#review61835
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 14, 2014, 5:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28140/#review61840
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 17, 2014, 4:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28170/#review61952
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 18, 2014, 7:46 a.m
this work in `SchedulerMain`?
nowhere immediately jumps out as the right place to put this and I'd like to
minimize the ripple here.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://
.java
48b3d886844622288be4131dfe8f2a77f7e316e7
Diff: https://reviews.apache.org/r/27757/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62001
---
@ReviewBot retry
- Kevin Sweeney
On Nov. 18, 2014, 12:26 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62007
---
@ReviewBot retry
- Kevin Sweeney
On Nov. 18, 2014, 12:26 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62011
---
@ReviewBot retry
- Kevin Sweeney
On Nov. 18, 2014, 12:26 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62015
---
@Reviewbot retry please?
- Kevin Sweeney
On Nov. 18, 2014, 12:26
our (Apache)
environment?
- Kevin Sweeney
On Nov. 19, 2014, 9:36 a.m., Joshua Cohen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/python/apache/aurora/client/commands/test_version.py
5c3c45a769aeec2ffb2c2bd3d8d937476c9abd12
Diff: https://reviews.apache.org/r/28250/diff/
Testing
---
./pants src/test/python:all
./pants src/main/python/apache/aurora/client/bin:aurora_client
dist/aurora_client.pex version
Thanks,
Kevin
s.apache.org/r/28250/#review6
---
On Nov. 19, 2014, 12:44 p.m., Kevin Sweeney wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28250/#review62257
---
@ReviewBot retry
- Kevin Sweeney
On Nov. 19, 2014, 12:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28250/#review62261
---
@ReviewBot retry
- Kevin Sweeney
On Nov. 19, 2014, 12:44 p.m
7b46740a5beb4b5bde4b5d41bea9573195e047b9
Diff: https://reviews.apache.org/r/28272/diff/
Testing
---
./gradlew -Pq build
Suggestions on how to better test this are welcome.
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28272/#review62313
---
@ReviewBot retry please
- Kevin Sweeney
On Nov. 19, 2014, 5:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62377
---
@ReviewBot retry please
- Kevin Sweeney
On Nov. 18, 2014, 12:26
.java
cb95d8996a934751745f423b79279266d73b7722
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java
c90389433d81dd72756c659736e38fd9f66fcb35
Diff: https://reviews.apache.org/r/28306/diff/
Testing
---
./gradlew -Pq build
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62482
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 20, 2014, 3:05 p.m
./gradlew -Pq build
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28306/#review62484
---
@ReviewBot retry
- Kevin Sweeney
On Nov. 20, 2014, 5:10 p.m
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28306/#review62481
-----------
On Nov. 20, 2014, 5:10 p.m., Kevin Sweeney wrote:
>
> --
/scheduler/storage/log/SnapshotDeduplicator.java
7b46740a5beb4b5bde4b5d41bea9573195e047b9
Diff: https://reviews.apache.org/r/28272/diff/
Testing
---
./gradlew -Pq build
Suggestions on how to better test this are welcome.
Thanks,
Kevin Sweeney
comment explaining why we're doing this?
Done.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28272/#review62317
-------
On N
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27757/#review62491
---
@ReviewBot retry
- Kevin Sweeney
On Nov. 18, 2014, 12:26 p.m
n the algorithm here? Why the magic "-2"?
>
> Kevin Sweeney wrote:
> Not sure what I'd say there that doesn't risk contradicting the code
> below - we don't usually comment loop variables and the old version had the
> same amount of commenting.
>
&g
-Pq build
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/#review62591
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 20, 2014, 11:43 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review62604
---
update or discard?
- Kevin Sweeney
On Oct. 24, 2014, 5:12 p.m
r/28306/#review62606
---
On Nov. 20, 2014, 5:53 p.m., Kevin Sweeney wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
338) UIs too. And possibly ZooKeeper (2181)?
- Kevin Sweeney
On Nov. 19, 2014, 10:02 a.m., Tony Dong wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
To reply, visit:
> https://reviews.apache.org/r/28198/
> ---
>
> (Updated Nov. 19, 2014, 10:02 a.m.)
>
>
> Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
>
>
> Repository: aurora
>
&g
discard.
- Kevin Sweeney
On Nov. 4, 2014, 7:35 a.m., Dan Norris wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Nov. 21, 2014, 12:30 p.m., Bill Farner wrote:
> > While you're doing this reshuffle, we really should move apache.thermos.*
> > to apache.aurora.thermos.*.
>
> Brian Wickman wrote:
> Care to elaborate? Why this approach vs the other extreme of just
> pulling it out entirely.
Presuma
350/#comment104746>
Hold on a sec - why do we have this and cron schedule (see above)?
- Kevin Sweeney
On Nov. 21, 2014, 3:14 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> On Nov. 21, 2014, 3:26 p.m., Kevin Sweeney wrote:
> > docs/cron-jobs.md, line 89
> > <https://reviews.apache.org/r/28350/diff/1/?file=772861#file772861line89>
> >
> > Hold on a sec - why do we have this and cron schedule (see above)?
>
> Maxim Khu
> On Nov. 21, 2014, 3:26 p.m., Kevin Sweeney wrote:
> > docs/cron-jobs.md, line 89
> > <https://reviews.apache.org/r/28350/diff/1/?file=772861#file772861line89>
> >
> > Hold on a sec - why do we have this and cron schedule (see above)?
>
> Maxim Khu
/executor/common/BUILD
318e66d477bbf75d5e36ffe4bc70294da34b4965
Diff: https://reviews.apache.org/r/28361/diff/
Testing
---
./gradlew -Pq build
./pants src/test/python:all
Thanks,
Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28360/#review62843
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 21, 2014, 5:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28398/#review62858
---
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 24, 2014, 11:19 a.m
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62825
-------
On Nov. 21, 2014, 5:35 p.m., Kevin Sweeney wrote:
>
> --
201 - 300 of 1028 matches
Mail list logo
