[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-12 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9026 Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. IMPALA-6395: Add a flag for data stream sender's buffer

[Impala-ASF-CR] KUDU-2256: Add GetTransferSize() to RpcContext

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9019 ) Change subject: KUDU-2256: Add GetTransferSize() to RpcContext .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 3: Build failed:

[Impala-ASF-CR] IMPALA-6307: CTAS statement fails with duplicate column exception.

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8930 ) Change subject: IMPALA-6307: CTAS statement fails with duplicate column exception. .. IMPALA-6307: CTAS statement

[Impala-ASF-CR] IMPALA-6307: CTAS statement fails with duplicate column exception.

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8930 ) Change subject: IMPALA-6307: CTAS statement fails with duplicate column exception. .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6363: avoid cscope build races

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 ) Change subject: IMPALA-6363: avoid cscope build races .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9002 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. IMPALA-6383: free memory after skipping

[Impala-ASF-CR] IMPALA-6382: Cap default and min spillable buffer size query options

2018-01-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9023 Change subject: IMPALA-6382: Cap default and min spillable buffer size query options .. IMPALA-6382: Cap default and min spillable

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6368: make test chars parallel

2018-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9022 Change subject: IMPALA-6368: make test_chars parallel .. IMPALA-6368: make test_chars parallel Previously it had to be executed

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: thanks for catching this! looking into it.

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges

2018-01-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8973 ) Change subject: IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges .. Patch Set 1: I think we should extend

[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()

2018-01-12 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 ) Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length() .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 9: (3 comments) Thanks.

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-12 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8349 to look at the new patch set (#9). Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: Code-Review-2 (1 comment) I was reading

[Impala-ASF-CR] IMPALA-6307: CTAS statement fails with duplicate column exception.

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8930 ) Change subject: IMPALA-6307: CTAS statement fails with duplicate column exception. .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-6307: CTAS statement fails with duplicate column exception.

2018-01-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8930 ) Change subject: IMPALA-6307: CTAS statement fails with duplicate column exception. .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6363: avoid cscope build races

2018-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 ) Change subject: IMPALA-6363: avoid cscope build races .. Patch Set 2: Hit a flaky test - filed IMPALA-6394 -- To view, visit

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2018-01-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 7: (4 comments) Sorry for the delay! I had missed your

[Impala-ASF-CR] IMPALA-6363: avoid cscope build races

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 ) Change subject: IMPALA-6363: avoid cscope build races .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-6363: avoid cscope build races

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 ) Change subject: IMPALA-6363: avoid cscope build races .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 8: (3 comments) Looking

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9002 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 6: Code-Review+2 carry -- To view, visit

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9002 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 15: clang-tidy on gvo found an issue. latest

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#15). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 14: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. IMPALA-5528: Upgrade GPerfTools

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 ) Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length() .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 ) Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length() .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 15: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-12 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9002 to look at the new patch set (#5). Change subject: IMPALA-6383: free memory after skipping parquet row groups

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9002 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5478: Run TPCDS queries with decimal v2 enabled

2018-01-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8985 ) Change subject: IMPALA-5478: Run TPCDS queries with decimal_v2 enabled .. Patch Set 2: You could get a diff by comparing

[Impala-ASF-CR] Update copyright date to 2018.

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8925 ) Change subject: Update copyright date to 2018. .. Update copyright date to 2018. Change-Id:

[Impala-ASF-CR] IMPALA-5478: Run TPCDS queries with decimal v2 enabled

2018-01-12 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8985 ) Change subject: IMPALA-5478: Run TPCDS queries with decimal_v2 enabled .. Patch Set 2: Is there any easy way to get a diff between this

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2018-01-12 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. ( http://gerrit.cloudera.org:8080/7581 ) Change subject: IMPALA-5764: Allow overriding packaged components .. Abandoned Abandoning ancient thing. Now that we're almost settled with the

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6386: Invalidate metadata at table level for dataload

2018-01-12 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9009 ) Change subject: IMPALA-6386: Invalidate metadata at table level for dataload .. Patch Set 2: Code-Review+2 (2 comments) Looks good, I

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. IMPALA-6388: Fix the Union node number of hosts

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9002 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. IMPALA-6388: Fix the Union node number of hosts

[Impala-ASF-CR] IMPALA-6388: Fix the Union node number of hosts estimation

2018-01-12 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9017 ) Change subject: IMPALA-6388: Fix the Union node number of hosts estimation .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. IMPALA-5736: [DOCS] Document

[Impala-ASF-CR] KUDU-2256: Add GetTransferSize() to RpcContext

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9019 ) Change subject: KUDU-2256: Add GetTransferSize() to RpcContext .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2018-01-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()

2018-01-12 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 ) Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length() .. Patch Set 1: Agree with having Greg look

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2018-01-12 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 3: (2 comments) I didn't make any change due

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2018-01-12 Thread John Russell (Code Review)
Hello Lars Volker, Michael Brown, David Knupp, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8771 to look at the new patch set (#5). Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. IMPALA-2181: [DOCS] Document changes to SET

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 5: noticed a discrepancy in the s3 ranges from run-to-run for

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2018-01-12 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 4: Code-Review+2 (2 comments) Carrying forward +2

[Impala-ASF-CR] IMPALA-6363: avoid cscope build races

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 ) Change subject: IMPALA-6363: avoid cscope build races .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6363: avoid cscope build races

2018-01-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 ) Change subject: IMPALA-6363: avoid cscope build races .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 14: Build started:

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 14: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#14). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 13: (2 comments)

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 13: (2 comments)

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 13: carry alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 3: (3 comments) couple of

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 15: Code-Review+2 Trying it again

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 15: Build started:

[Impala-ASF-CR] KUDU-2256: Add GetTransferSize() to RpcContext

2018-01-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9019 ) Change subject: KUDU-2256: Add GetTransferSize() to RpcContext .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Update copyright date to 2018.

2018-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8925 ) Change subject: Update copyright date to 2018. .. Patch Set 2: Build started:

[Impala-ASF-CR] Update copyright date to 2018.

2018-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8925 ) Change subject: Update copyright date to 2018. .. Patch Set 2: Code-Review+2 rebase carry +2 -- To view, visit

[Impala-ASF-CR] Update copyright date to 2018.

2018-01-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8925 ) Change subject: Update copyright date to 2018. .. Patch Set 1: Code-Review+2 Thank you for digging out the link. -- To view, visit

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9002 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2397: Use atomics for metrics

2018-01-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9012 ) Change subject: IMPALA-2397: Use atomics for metrics .. Patch Set 1: (5 comments)

[Impala-ASF-CR] Update copyright date to 2018.

2018-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8925 ) Change subject: Update copyright date to 2018. .. Patch Set 1: > I found two more files, should we update them, too? > > $ git grep -i

[Impala-ASF-CR] IMPALA-6387: Increase wait for Breakpad crash handling

2018-01-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9018 ) Change subject: IMPALA-6387: Increase wait for Breakpad crash handling .. IMPALA-6387: Increase wait for Breakpad crash handling

[Impala-ASF-CR] IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command

2018-01-12 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8928 ) Change subject: IMPALA-4323: "SET ROW FORMAT" option added to "ALTER TABLE" command .. Patch Set 9: (3 comments) Applied changes.

[Impala-ASF-CR] IMPALA-2397: Use atomics for metrics

2018-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9012 ) Change subject: IMPALA-2397: Use atomics for metrics .. Patch Set 1: (6 comments) This should be a big improvement.

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-12 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 1: (15 comments) Thanks

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-12 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#2). Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2018-01-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 5: Code-Review+2 Not sure if Sailesh

  1   2   >