[Impala-ASF-CR] Convert dataload hdfs copy commands to LOAD DATA statements

2020-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15228 ) Change subject: Convert dataload hdfs copy commands to LOAD DATA statements .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 ) Change subject: IMPALA-8013: switch from boost to std locks .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 ) Change subject: IMPALA-8013: switch from boost to std locks .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. IMPALA-6689: Speed up point lookup for Kudu primary key If all

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15263 ) Change subject: IMPALA-9369: Make createInsertEvents() async. .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. IMPALA-9399: optimise RuntimeProfile::ToThrift()

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-02-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15263 ) Change subject: IMPALA-9369: Make createInsertEvents() async. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-02-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15263 Change subject: IMPALA-9369: Make createInsertEvents() async. .. IMPALA-9369: Make createInsertEvents() async. This patch makes

[Impala-ASF-CR] IMPALA-9357: Fix race condition in alter database event

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15260 ) Change subject: IMPALA-9357: Fix race condition in alter_database event .. Patch Set 1: Build Successful

[Impala-ASF-CR] Convert dataload hdfs copy commands to LOAD DATA statements

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15228 ) Change subject: Convert dataload hdfs copy commands to LOAD DATA statements .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5904: (part 2) Fix more TSAN bugs

2020-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15244 ) Change subject: IMPALA-5904: (part 2) Fix more TSAN bugs .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-9357: Fix race condition in alter database event

2020-02-20 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15260 Change subject: IMPALA-9357: Fix race condition in alter_database event .. IMPALA-9357: Fix race condition in alter_database

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. IMPALA-6689: Speed up point lookup for Kudu primary key If all

[Impala-ASF-CR] IMPALA-5904: (part 2) Fix more TSAN bugs

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15244 ) Change subject: IMPALA-5904: (part 2) Fix more TSAN bugs .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-5904: (part 2) Fix more TSAN bugs

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15244 ) Change subject: IMPALA-5904: (part 2) Fix more TSAN bugs .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4080: Moved codegen code from scan exec nodes to their plan nodes

2020-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15259 ) Change subject: IMPALA-4080: Moved codegen code from scan exec nodes to their plan nodes .. Patch Set 1: (11 comments) Thanks for

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. IMPALA-6689: Speed up point lookup for Kudu primary key If all

[Impala-ASF-CR] IMPALA-8712: Make ExecQueryFInstances async

2020-02-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15154 ) Change subject: IMPALA-8712: Make ExecQueryFInstances async .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4080: Moved codegen code from scan exec nodes to their plan nodes

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15259 ) Change subject: IMPALA-4080: Moved codegen code from scan exec nodes to their plan nodes .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5904: (part 2) Fix more TSAN bugs

2020-02-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15244 ) Change subject: IMPALA-5904: (part 2) Fix more TSAN bugs .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-5904: (part 2) Fix more TSAN bugs

2020-02-20 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15244 to look at the new patch set (#4). Change subject: IMPALA-5904: (part 2) Fix more TSAN bugs

[Impala-ASF-CR] IMPALA-5904: (part 2) Fix more TSAN bugs

2020-02-20 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15244 to look at the new patch set (#3). Change subject: IMPALA-5904: (part 2) Fix more TSAN bugs

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 ) Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation .. Patch Set 7: Verified+1 -- To

[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks

2020-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 ) Change subject: IMPALA-8013: switch from boost to std locks .. Patch Set 11: Code-Review+2 I'm going to wait a bit to try merging

[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks

2020-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-8013: switch from boost to std locks .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/15208 To

[Impala-ASF-CR] IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15186 ) Change subject: IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters .. Patch Set 5:

[Impala-ASF-CR] IMPALA-8690 (prep 1): Copy Kudu cache code to be/src/util/cache

2020-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15169 ) Change subject: IMPALA-8690 (prep 1): Copy Kudu cache code to be/src/util/cache .. IMPALA-8690 (prep 1): Copy Kudu cache code

[Impala-ASF-CR] IMPALA-8690 (prep 1): Copy Kudu cache code to be/src/util/cache

2020-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15169 ) Change subject: IMPALA-8690 (prep 1): Copy Kudu cache code to be/src/util/cache .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

2020-02-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15170 ) Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation .. IMPALA-8690 (prep 2): Switch

[Impala-ASF-CR] IMPALA-9402: Relax bootstrap condition for PostgreSQL permission tweaks

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15243 ) Change subject: IMPALA-9402: Relax bootstrap condition for PostgreSQL permission tweaks .. Patch Set 2: Verified+1 -- To

[Impala-ASF-CR] IMPALA-4080: Moved codegen code from scan exec nodes to their plan nodes

2020-02-20 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15259 Change subject: IMPALA-4080: Moved codegen code from scan exec nodes to their plan nodes .. IMPALA-4080: Moved codegen code from scan

[Impala-ASF-CR] IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15186 ) Change subject: IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters ..

[Impala-ASF-CR] IMPALA-4080: Moved codegen code from scan exec nodes to their plan nodes

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15259 ) Change subject: IMPALA-4080: Moved codegen code from scan exec nodes to their plan nodes .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9402: Relax bootstrap condition for PostgreSQL permission tweaks

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15243 ) Change subject: IMPALA-9402: Relax bootstrap condition for PostgreSQL permission tweaks .. IMPALA-9402: Relax

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8712: Make ExecQueryFInstances async

2020-02-20 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15154 ) Change subject: IMPALA-8712: Make ExecQueryFInstances async .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. Patch Set 8: Build Successful

[Impala-ASF-CR] Convert dataload hdfs copy commands to LOAD DATA statements

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15228 ) Change subject: Convert dataload hdfs copy commands to LOAD DATA statements .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Tim Armstrong (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15251 to look at the new patch set (#5). Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift()

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-9390: Change ant and maven download URLs to valid locations

2020-02-20 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15229 ) Change subject: IMPALA-9390: Change ant and maven download URLs to valid locations .. IMPALA-9390: Change ant and maven

[Impala-ASF-CR] IMPALA-9390: Change ant and maven download URLs to valid locations

2020-02-20 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15229 ) Change subject: IMPALA-9390: Change ant and maven download URLs to valid locations .. Patch Set 2: Verified+1 > Patch Set 2: > > The

[Impala-ASF-CR] IMPALA-9390: Change ant and maven download URLs to valid locations

2020-02-20 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has removed a vote on this change. Change subject: IMPALA-9390: Change ant and maven download URLs to valid locations .. Removed Verified-1 by Impala Public Jenkins -- To view, visit

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-02-20 Thread Xiaomeng Zhang (Code Review)
Xiaomeng Zhang has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. IMPALA-9075: Add support for reading zstd text files In this

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. Patch Set 2: I agree that these optimizations could

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-02-20 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. Patch Set 7: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-9390: Change ant and maven download URLs to valid locations

2020-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15229 ) Change subject: IMPALA-9390: Change ant and maven download URLs to valid locations .. Patch Set 2: The GVO dies failed with this

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 4: (2 comments) Thanks for the changes! I looked

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9385: Unix time conversion cleanup + ORC fix

2020-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15222 ) Change subject: IMPALA-9385: Unix time conversion cleanup + ORC fix .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-9385: Unix time conversion cleanup + ORC fix

2020-02-20 Thread Csaba Ringhofer (Code Review)
Hello Quanlong Huang, Norbert Luksa, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15222 to look at the new patch set (#12). Change subject: IMPALA-9385: Unix time conversion cleanup + ORC fix

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 ) Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15186 ) Change subject: IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters .. Patch Set 5:

[Impala-ASF-CR] IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15186 ) Change subject: IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters .. Patch Set 5:

[Impala-ASF-CR] IMPALA-9402: Relax bootstrap condition for PostgreSQL permission tweaks

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15243 ) Change subject: IMPALA-9402: Relax bootstrap condition for PostgreSQL permission tweaks .. Patch Set 2: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9402: Relax bootstrap condition for PostgreSQL permission tweaks

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15243 ) Change subject: IMPALA-9402: Relax bootstrap condition for PostgreSQL permission tweaks .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9287: Add support for embedded metastore mode

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 ) Change subject: IMPALA-9287: Add support for embedded metastore mode .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-9287: Add support for embedded metastore mode

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 ) Change subject: IMPALA-9287: Add support for embedded metastore mode .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-9381: lazy conversion of runtime profile

2020-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15236 ) Change subject: IMPALA-9381: lazy conversion of runtime profile .. Patch Set 3: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Tim Armstrong (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15251 to look at the new patch set (#4). Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift()

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 3: Code-Review+1 Looks like your suggested change made

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Tim Armstrong (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15251 to look at the new patch set (#3). Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift()

[Impala-ASF-CR] IMPALA-9287: Add support for embedded metastore mode

2020-02-20 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15223 ) Change subject: IMPALA-9287: Add support for embedded metastore mode .. IMPALA-9287: Add support for embedded metastore mode This

[Impala-ASF-CR] IMPALA-9386: Remove hive-metastore dependency from hive-3 profile

2020-02-20 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 ) Change subject: IMPALA-9386: Remove hive-metastore dependency from hive-3 profile .. Patch Set 4: > Abandon this? Actually,

[Impala-ASF-CR] IMPALA-9386: Remove hive-metastore dependency from hive-3 profile

2020-02-20 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15223 ) Change subject: IMPALA-9386: Remove hive-metastore dependency from hive-3 profile .. IMPALA-9386: Remove hive-metastore

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

2020-02-20 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 ) Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation .. Patch Set 7: Code-Review+2 --

[Impala-ASF-CR] IMPALA-8690 (prep 1): Copy Kudu cache code to be/src/util/cache

2020-02-20 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15169 ) Change subject: IMPALA-8690 (prep 1): Copy Kudu cache code to be/src/util/cache .. Patch Set 7: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9399: optimise RuntimeProfile::ToThrift()

2020-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15251 ) Change subject: IMPALA-9399: optimise RuntimeProfile::ToThrift() .. Patch Set 2: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-9385: Unix time conversion cleanup + ORC fix

2020-02-20 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15222 ) Change subject: IMPALA-9385: Unix time conversion cleanup + ORC fix .. Patch Set 11: Code-Review+1 (3 comments) Left some comments,

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. Patch Set 2: It'd be worth looking at the HDFS PK stuff.

[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks

2020-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 ) Change subject: IMPALA-8013: switch from boost to std locks .. Patch Set 11: fyi the build failed because of IMPALA-9390 The patch

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. Patch Set 2: (7 comments) About the high level design:

[Impala-ASF-CR] IMPALA-9406 Add some new packages to download

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15253 ) Change subject: IMPALA-9406 Add some new packages to download .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9390: Change ant and maven download URLs to valid locations

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15229 ) Change subject: IMPALA-9390: Change ant and maven download URLs to valid locations .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-9390: Change ant and maven download URLs to valid locations

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15229 ) Change subject: IMPALA-9390: Change ant and maven download URLs to valid locations .. Patch Set 2: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9390: Change ant and maven download URLs to valid locations

2020-02-20 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15229 ) Change subject: IMPALA-9390: Change ant and maven download URLs to valid locations .. Patch Set 1: (1 comment) > Patch Set 1: > > (1

[Impala-ASF-CR] IMPALA-9406 Add some new packages to download

2020-02-20 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15253 Change subject: IMPALA-9406 Add some new packages to download .. IMPALA-9406 Add some new packages to download Add some new

[Impala-ASF-CR] IMPALA-9385: Unix time conversion cleanup + ORC fix

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15222 ) Change subject: IMPALA-9385: Unix time conversion cleanup + ORC fix .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-9390: Change ant and maven download URLs to valid locations

2020-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15229 ) Change subject: IMPALA-9390: Change ant and maven download URLs to valid locations .. Patch Set 1: Code-Review+2 I vote for

[Impala-ASF-CR] IMPALA-9385: Unix time conversion cleanup + ORC fix

2020-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15222 ) Change subject: IMPALA-9385: Unix time conversion cleanup + ORC fix .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for dedicated coordinator

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for dedicated coordinator .. Patch Set 10: Verified+1 -- To

[Impala-ASF-CR] IMPALA-9385: Unix time conversion cleanup + ORC fix

2020-02-20 Thread Csaba Ringhofer (Code Review)
Hello Quanlong Huang, Norbert Luksa, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15222 to look at the new patch set (#11). Change subject: IMPALA-9385: Unix time conversion cleanup + ORC fix

[Impala-ASF-CR] IMPALA-8755: Backend support for Z-ordering

2020-02-20 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14080 ) Change subject: IMPALA-8755: Backend support for Z-ordering .. Patch Set 28: I checked the verify job failure. TL;DR: include

[Impala-ASF-CR] IMPALA-8013: switch from boost to std locks

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 ) Change subject: IMPALA-8013: switch from boost to std locks .. Patch Set 11: Verified-1 Build failed:

[Impala-ASF-CR] WIP: Asynchronous code generation

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: WIP: Asynchronous code generation .. Patch Set 13: Build Successful

[Impala-ASF-CR] WIP: Asynchronous code generation

2020-02-20 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/15105 ) Change subject: WIP: Asynchronous code generation .. WIP: Asynchronous code generation This commit introduces optional asynchronous

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for dedicated coordinator

2020-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for dedicated coordinator .. Patch Set 10: Build Successful

  1   2   >