[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-21 Thread Daniel Becker (Code Review)
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21440 ) Change subject: IMPALA-13091: query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an expected constant

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-17 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21440 Change subject: IMPALA-13091: query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an expected constant ..

[Impala-ASF-CR] IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables

2024-05-16 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21429 ) Change subject: IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables .. IMPALA-13085: Add warning and NULL

[Impala-ASF-CR] IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables

2024-05-16 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21429 ) Change subject: IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables

2024-05-15 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21429 Change subject: IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables .. IMPALA-13085: Add warning and NULL

[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables

2024-05-15 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21425 ) Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables .. IMPALA-13079: Add support for FLOAT/DOUBLE in

[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables

2024-05-15 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21425 ) Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables .. IMPALA-13079: Add support for FLOAT/DOUBLE in

[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables

2024-05-15 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21425 ) Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables

2024-05-14 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21425 Change subject: IMPALA-13079: Add support for FLOAT/DOUBLE in Iceberg metadata tables .. IMPALA-13079: Add support for FLOAT/DOUBLE in

[Impala-ASF-CR] IMPALA-13036: Document Iceberg metadata tables

2024-05-10 Thread Daniel Becker (Code Review)
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21387 ) Change subject: IMPALA-13036: Document Iceberg metadata tables .. IMPALA-13036: Document Iceberg metadata tables This change

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-09 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21394 ) Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-05-09 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 27: Code-Review+2 Thanks Pranav!

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-05-07 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 23: (1 comment)

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-05-07 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 23: (2 comments)

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-05-07 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 23: (2 comments) Just a few

[Impala-ASF-CR] IMPALA-13047: Support restarting/killing specified impalads in start-impala-cluster.py

2024-05-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21376 ) Change subject: IMPALA-13047: Support restarting/killing specified impalads in start-impala-cluster.py .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21394 ) Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. Patch Set 1: (5 comments) Thanks Gábor!

[Impala-ASF-CR] IMPALA-13035: Querying metadata tables from non-Iceberg tables throws IllegalArgumentException

2024-05-03 Thread Daniel Becker (Code Review)
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21361 ) Change subject: IMPALA-13035: Querying metadata tables from non-Iceberg tables throws IllegalArgumentException ..

[Impala-ASF-CR] IMPALA-13036: Document Iceberg metadata tables

2024-05-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21387 ) Change subject: IMPALA-13036: Document Iceberg metadata tables .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-13036: Document Iceberg metadata tables

2024-05-03 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21387 ) Change subject: IMPALA-13036: Document Iceberg metadata tables .. IMPALA-13036: Document Iceberg metadata tables This change adds

[Impala-ASF-CR] IMPALA-13036: Document Iceberg metadata tables

2024-05-02 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21387 Change subject: IMPALA-13036: Document Iceberg metadata tables .. IMPALA-13036: Document Iceberg metadata tables This change adds

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-30 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 15: (2 comments) Thanks Pranav!

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-30 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 13: (4 comments)

[Impala-ASF-CR] IMPALA-13047: Support restarting/killing specified impalads in start-impala-cluster.py

2024-04-30 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21376 ) Change subject: IMPALA-13047: Support restarting/killing specified impalads in start-impala-cluster.py .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-30 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 12: (6 comments) Thanks Pranav,

[Impala-ASF-CR] IMPALA-13046: Update Iceberg mixed format deletes test

2024-04-30 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21373 ) Change subject: IMPALA-13046: Update Iceberg mixed format deletes test .. Patch Set 1: Code-Review+2 Thanks for fixing this, Michael.

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-29 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 11: (17 comments)

[Impala-ASF-CR] IMPALA-13035: Querying metadata tables from non-Iceberg tables throws IllegalArgumentException

2024-04-29 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21361 ) Change subject: IMPALA-13035: Querying metadata tables from non-Iceberg tables throws IllegalArgumentException .. IMPALA-13035:

[Impala-ASF-CR] IMPALA-13035: Querying metadata tables from non-Iceberg tables throws IllegalArgumentException

2024-04-29 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21361 ) Change subject: IMPALA-13035: Querying metadata tables from non-Iceberg tables throws IllegalArgumentException .. Patch Set 3: (1

[Impala-ASF-CR] IMPALA-13035: Querying metadata tables from non-Iceberg tables throws IllegalArgumentException

2024-04-29 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21361 Change subject: IMPALA-13035: Querying metadata tables from non-Iceberg tables throws IllegalArgumentException .. IMPALA-13035:

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-26 Thread Daniel Becker (Code Review)
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list ..

[Impala-ASF-CR] IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 6: (13 comments)

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-25 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list ..

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-04-24 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21348 ) Change subject: IMPALA-13029: Tests for multi format equality deletes .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-24 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list ..

[Impala-ASF-CR] IMPALA-12950: Improve error message in case of out-of-range numeric conversions

2024-04-23 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21331 ) Change subject: IMPALA-12950: Improve error message in case of out-of-range numeric conversions .. IMPALA-12950: Improve error message

[Impala-ASF-CR] IMPALA-12950: Improve error message in case of out-of-range numeric conversions

2024-04-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21331 ) Change subject: IMPALA-12950: Improve error message in case of out-of-range numeric conversions .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-22 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list ..

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list .. Patch Set 7: (2

[Impala-ASF-CR] IMPALA-13000: Document OPTIMIZE TABLE

2024-04-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21320 ) Change subject: IMPALA-13000: Document OPTIMIZE TABLE .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12950:Improve error message in case of out-of-range numeric conversions

2024-04-18 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21331 Change subject: IMPALA-12950:Improve error message in case of out-of-range numeric conversions .. IMPALA-12950:Improve error message

[Impala-ASF-CR] IMPALA-13004: Fix heap-use-after-free error in ExprTest AiFunctionsTest

2024-04-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21315 ) Change subject: IMPALA-13004: Fix heap-use-after-free error in ExprTest AiFunctionsTest .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-13000: Document OPTIMIZE TABLE

2024-04-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21320 ) Change subject: IMPALA-13000: Document OPTIMIZE TABLE .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-18 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list ..

[Impala-ASF-CR] IMPALA-13004: Fix heap-use-after-free error in ExprTest AiFunctionsTest

2024-04-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21315 ) Change subject: IMPALA-13004: Fix heap-use-after-free error in ExprTest AiFunctionsTest .. Patch Set 2: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-13004: Fix heap-use-after-free error in ExprTest AiFunctionsTest

2024-04-17 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21315 ) Change subject: IMPALA-13004: Fix heap-use-after-free error in ExprTest AiFunctionsTest .. Patch Set 1: (2 comments) Thanks Yida,

[Impala-ASF-CR] IMPALA-13000: Document OPTIMIZE TABLE

2024-04-17 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21320 ) Change subject: IMPALA-13000: Document OPTIMIZE TABLE .. Patch Set 1: (5 comments) Thanks Noémi!

[Impala-ASF-CR] IMPALA-13008: test metadata tables failed in Ubuntu 20 build

2024-04-17 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21317 Change subject: IMPALA-13008: test_metadata_tables failed in Ubuntu 20 build .. IMPALA-13008: test_metadata_tables failed in Ubuntu 20

[Impala-ASF-CR] IMPALA-13002: Iceberg V2 tables with Avro delete files aren't read properly

2024-04-16 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21301 ) Change subject: IMPALA-13002: Iceberg V2 tables with Avro delete files aren't read properly .. Patch Set 1: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-15 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list ..

[Impala-ASF-CR] IMPALA-12996: Add support for DATE in Iceberg metadata tables

2024-04-12 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21292 ) Change subject: IMPALA-12996: Add support for DATE in Iceberg metadata tables .. IMPALA-12996: Add support for DATE in Iceberg metadata

[Impala-ASF-CR] IMPALA-12996: Add support for DATE in Iceberg metadata tables

2024-04-12 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21292 ) Change subject: IMPALA-12996: Add support for DATE in Iceberg metadata tables .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12996: Add support for DATE in Iceberg metadata tables

2024-04-12 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21292 ) Change subject: IMPALA-12996: Add support for DATE in Iceberg metadata tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-12996: Add support for DATE in Iceberg metadata tables

2024-04-12 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21292 Change subject: IMPALA-12996: Add support for DATE in Iceberg metadata tables .. IMPALA-12996: Add support for DATE in Iceberg metadata

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-12 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list ..

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list ..

[Impala-ASF-CR] [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters

2024-04-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 ) Change subject: [TEST][WIP]IMPALA-11499: Refactor UrlEncode function to handle special characters .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder

2024-04-10 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 ) Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder .. Patch Set 9: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12986: Base64Encode fails if the 'out len' output parameter is passed with certain values

2024-04-10 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21271 ) Change subject: IMPALA-12986: Base64Encode fails if the 'out_len' output parameter is passed with certain values .. IMPALA-12986:

[Impala-ASF-CR] IMPALA-12986: Base64Encode fails if the 'out len' output parameter is passed with certain values

2024-04-10 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21271 ) Change subject: IMPALA-12986: Base64Encode fails if the 'out_len' output parameter is passed with certain values .. Patch Set 2: (1

[Impala-ASF-CR] IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder

2024-04-10 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 ) Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-10 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list .. Patch Set 2: (7

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-10 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21269 ) Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list ..

[Impala-ASF-CR] IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder

2024-04-10 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 ) Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder .. Patch Set 7: (2 comments) Thanks.

[Impala-ASF-CR] IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder

2024-04-09 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21258 ) Change subject: IMPALA-12810: Simplify IcebergDeleteNode and IcebergDeleteBuilder .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-12986: Base64Encode fails if the 'out len' output parameter is passed with certain values

2024-04-09 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21271 Change subject: IMPALA-12986: Base64Encode fails if the 'out_len' output parameter is passed with certain values .. IMPALA-12986:

[Impala-ASF-CR] IMPALA-5323: Support BINARY columns in Kudu tables

2024-04-09 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18868 ) Change subject: IMPALA-5323: Support BINARY columns in Kudu tables .. Patch Set 8: Code-Review+1 Thanks Csaba, looks good. -- To

[Impala-ASF-CR] IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list

2024-04-09 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21269 Change subject: IMPALA-12973,IMPALA-11491,IMPALA-12651: Support BINARY nested in complex types in select list ..

[Impala-ASF-CR] IMPALA-5323: Support BINARY columns in Kudu tables

2024-04-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18868 ) Change subject: IMPALA-5323: Support BINARY columns in Kudu tables .. Patch Set 7: (3 comments) Looks good, thanks.

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21236 ) Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables .. Patch Set 5: Code-Review+2

[Impala-ASF-CR] IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables

2024-04-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21236 ) Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12612: Expand complex type columns from Iceberg metadata tables

2024-04-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21236 ) Change subject: IMPALA-12612: Expand complex type columns from Iceberg metadata tables .. Patch Set 1: (5 comments) Thanks Gábor,

[Impala-ASF-CR] IMPALA-12969: Release JNI array if DeserializeThriftMsg failed

2024-04-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21234 ) Change subject: IMPALA-12969: Release JNI array if DeserializeThriftMsg failed .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-03 Thread Daniel Becker (Code Review)
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. IMPALA-12899: Temporary workaround for

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-03 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. IMPALA-12899: Temporary workaround for BINARY in

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-03 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. IMPALA-12899: Temporary workaround for BINARY in

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-02 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. IMPALA-12899: Temporary workaround for BINARY in

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-02 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-02 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. IMPALA-12899: Temporary workaround for BINARY in

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-04-02 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21219 ) Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-04-02 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. Patch Set 10: (4 comments)

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-04-02 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. IMPALA-12611: Add support to MAP type Iceberg

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-04-02 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-04-02 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. IMPALA-12611: Add support to MAP type Iceberg

[Impala-ASF-CR] IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables

2024-04-02 Thread Daniel Becker (Code Review)
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21026 ) Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables .. IMPALA-12609:

[Impala-ASF-CR] IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables

2024-04-01 Thread Daniel Becker (Code Review)
Daniel Becker has removed a vote on this change. Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables .. Removed Code-Review+2 by Daniel Becker -- To view, visit

[Impala-ASF-CR] IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables

2024-04-01 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21026 ) Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables .. Patch Set 15: (1

[Impala-ASF-CR] IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables

2024-04-01 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21026 ) Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables .. Patch Set 15:

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-03-31 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-03-31 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. IMPALA-12611: Add support to MAP type Iceberg

[Impala-ASF-CR] IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables

2024-03-31 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/21026 ) Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables .. IMPALA-12609: Implement

[Impala-ASF-CR] IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables

2024-03-30 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/21026 ) Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables .. IMPALA-12609: Implement

[Impala-ASF-CR] IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables

2024-03-28 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/21026 ) Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables .. IMPALA-12609: Implement

[Impala-ASF-CR] IMPALA-12809: Iceberg metadata table scanner should always be scheduled to the coordinator

2024-03-28 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/21138 ) Change subject: IMPALA-12809: Iceberg metadata table scanner should always be scheduled to the coordinator .. IMPALA-12809: Iceberg

[Impala-ASF-CR] IMPALA-12899: Temporary workaround for BINARY in complex types

2024-03-28 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21219 Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types .. IMPALA-12899: Temporary workaround for BINARY in

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-03-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. Patch Set 6: (8 comments)

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-03-28 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. IMPALA-12611: Add support to MAP type Iceberg

[Impala-ASF-CR] IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables

2024-03-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21026 ) Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables .. Patch Set 11: (1

[Impala-ASF-CR] IMPALA-12611: Add support to MAP type Iceberg Metadata table columns

2024-03-28 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/21125 ) Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns .. IMPALA-12611: Add support to MAP type Iceberg

[Impala-ASF-CR] IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables

2024-03-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21026 ) Change subject: IMPALA-12609: Implement SHOW METADATA TABLES IN statement to list Iceberg Metadata tables .. Patch Set 11: (3

  1   2   3   4   5   6   7   8   9   10   >