[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-15 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#9). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Spilling sort optimisations .. Patch Set 8: (16 comments)

[Impala-ASF-CR] IMPALA-5706: Spilling sort optimisations

2018-05-15 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#8). Change subject: IMPALA-5706: Spilling sort optimisations ..

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 5: (19 comments) Thanks for dealing with my previous

[Impala-ASF-CR](asf-site) Added changelog for 2.12.0

2018-04-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 ) Change subject: Added changelog for 2.12.0 .. Patch Set 2: Code-Review+1 Thx for the heads up! -- To view, visit

[Impala-ASF-CR](asf-site) Update download and signature links for 2.12.0 release.

2018-04-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10183 ) Change subject: Update download and signature links for 2.12.0 release. .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-26 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#7). Change subject: IMPALA-5706: Parallelise read I/O in sorter ..

[Impala-ASF-CR](asf-site) Added changelog for 2.12.0

2018-04-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10184 ) Change subject: Added changelog for 2.12.0 .. Patch Set 1: (1 comment)

[Impala-ASF-CR](asf-site) Update download and signature links for 2.12.0 release.

2018-04-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10183 ) Change subject: Update download and signature links for 2.12.0 release. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-24 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Parallelise read I/O in sorter .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-24 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Parallelise read I/O in sorter .. Patch Set 6: (2 comments) Thanks Csaba for taking a look at this

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-24 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#6). Change subject: IMPALA-5706: Parallelise read I/O in sorter ..

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Parallelise read I/O in sorter .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-21 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#5). Change subject: IMPALA-5706: Parallelise read I/O in sorter ..

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-04-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-04-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-04-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 2: (29 comments) Dumping another batch of comments :)

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-17 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#3). Change subject: IMPALA-5706: Parallelise read I/O in sorter .. IMPALA-5706:

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-04-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 1: (7 comments) Spent only a limited amount of time on

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10031 ) Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-23 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9724 to look at the new patch set (#3). Change subject: IMPALA-6699: Fix DST end time for Australian time zones

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-22 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9724 to look at the new patch set (#2). Change subject: IMPALA-6699: Fix DST end time for Australian time zones

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 15: Hey Tim, Dan, I think I addressed all

[Impala-ASF-CR] IMPALA-6699: Fix Australian DST ending time

2018-03-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9724 Change subject: IMPALA-6699: Fix Australian DST ending time .. IMPALA-6699: Fix Australian DST ending time Australian Daylight Saving

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-16 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#15). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-16 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#14). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 13: (5 comments)

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-15 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#13). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-14 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#12). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-13 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#11). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 9: (6 comments)

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-13 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#9). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 8: (16 comments) Thanks for taking a look,

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-12 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#8). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-08 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#7). Change subject: IMPALA-3866 Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-07 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#6). Change subject: IMPALA-3866 Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-03-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: (8 comments) Thanks for taking care of

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 5: (11 comments)

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-07 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#5). Change subject: IMPALA-3866 Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-5607: Add additional units to EXTRACT, DATE PART, TRUNC

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9391 ) Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC .. Patch Set 2: Hey, Let me put myself in context and

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 4: (31 comments) Thanks for taking a look,

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#4). Change subject: IMPALA-3866 Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 3: Rebased with master + resolved conflicts.

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-06 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#3). Change subject: IMPALA-3866 Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. Patch Set 2: (5 comments) Thx Attila for taking a

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 5: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-02-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. IMPALA-3866 Improve error reporting for scratch write

[Impala-ASF-CR] IMPALA-3866 Improve error reporting for scratch write errors

2018-02-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9420 Change subject: IMPALA-3866 Improve error reporting for scratch write errors .. IMPALA-3866 Improve error reporting for scratch write

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 3: (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN

2018-02-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9358 ) Change subject: IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 9: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN

2018-02-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9358 ) Change subject: IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN .. Patch Set 2: (2 comments) Seems fine in

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()

2018-02-18 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9352 to look at the new patch set (#2). Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-02-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 8: Code-Review+1 Thanks for taking care of this.

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-02 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#6). Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-01 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-01 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#4). Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 3: (4 comments) Thanks for taking a look,

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#3). Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-01-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 7: (5 comments) Thanks for getting back to this

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#2). Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9140 Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns .. IMPALA-6311: Skip row groups with predicates on NULL

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: Checked the binary sizes for release builds: Binary size of

[Impala-ASF-CR] IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8972 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. Patch Set 2: Instead of dropping the test,

[Impala-ASF-CR] IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8972 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. IMPALA-6318: Revert "Adjustment for hanging query

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 17: Again failed on a flaky test (but on a

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2018-01-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 3: Code-Review+1 (1 comment) Thanks John for the

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 13: One test failed, seems unrelated to this

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2018-01-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-10 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 11: (4 comments)

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-10 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8820 to look at the new patch set (#11). Change subject: IMPALA-5654: Disallow setting

[Impala-ASF-CR] IMPALA-3942: Fix wronly escaped string literal in front-end

2018-01-09 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 10: (4 comments) Thanks Dimitris for the

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-08 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8820 to look at the new patch set (#10). Change subject: IMPALA-5654: Disallow setting

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-05 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8820 to look at the new patch set (#9). Change subject: IMPALA-5654: Disallow setting Kudu

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 8: Code-Review-1 There is a test failing in

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 8: (5 comments)

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-04 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8820 to look at the new patch set (#8). Change subject: IMPALA-5654: Disallow setting Kudu

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2018-01-04 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8820 to look at the new patch set (#7). Change subject: IMPALA-5654: Disallow setting Kudu

[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output

2017-12-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-20 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, Attila Jeges, Tim Armstrong, Csaba Ringhofer, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8820 to look at the new patch set (#5). Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2017-12-17 Thread Gabor Kaszab (Code Review)
Hello Laszlo Gaal, Zoltan Borok-Nagy, David Knupp, Attila Jeges, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8852 to look at the new patch set (#5). Change subject: IMPALA-6318: Adjustment for hanging query cancellation

[Impala-ASF-CR] IMPALA-6318: Adjustment for hanging query cancellation test

2017-12-16 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8852 ) Change subject: IMPALA-6318: Adjustment for hanging query cancellation test .. Patch Set 4: Indeed, nice catch! Thanks, Tim! And sorry

<    6   7   8   9   10   11   12   >