[Impala-ASF-CR] Revert "Fix docs for catalogd automatic invalidate flags"

2019-06-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13523 ) Change subject: Revert "Fix docs for catalogd automatic invalidate flags" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] Revert "Fix docs for catalogd automatic invalidate flags"

2019-06-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13523 ) Change subject: Revert "Fix docs for catalogd automatic invalidate flags" .. Revert "Fix docs for catalogd automatic invalidate f

[Impala-ASF-CR] IMPALA-8551: Bump CDP BUILD NUMBER to 1153860

2019-06-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13525 ) Change subject: IMPALA-8551: Bump CDP_BUILD_NUMBER to 1153860 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13525/2/

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-06-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 19: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-03 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13425 to look at the new patch set (#3). Change subject: IMPALA-8542. Add an access trace for the data cache ...

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13252 ) Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load .. Patch Set 4: yea, Joe and I looked at it and it seems lik

[Impala-ASF-CR] IMPALA-8600 : Reload partition does not work for transactional tables

2019-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13467 ) Change subject: IMPALA-8600 : Reload partition does not work for transactional tables .. Patch Set 1: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 14: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] WIP: IMPALA-8586: Support download URLs for CDP

2019-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13432 ) Change subject: WIP: IMPALA-8586: Support download URLs for CDP .. Patch Set 1: Code-Review+1 Seems like a fine direction to me. Definit

[Impala-ASF-CR] IMPALA-8604: Improve authorization test coverage for update/upsert/delete statements

2019-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13480 ) Change subject: IMPALA-8604: Improve authorization test coverage for update/upsert/delete statements .. Patch Set 1: Code-Review+2 --

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-05-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 13: (3 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-05-29 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13463 to review the following change. Change subject: fe: improve logging for metadata loading .. fe: improve loggi

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-05-28 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13425 to look at the new patch set (#2). Change subject: IMPALA-8542. Add an access trace for the data cache ...

[Impala-ASF-CR] WIP: IMPALA-8542. Add an access trace for the data cache

2019-05-24 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13425 to review the following change. Change subject: WIP: IMPALA-8542. Add an access trace for the data cache .

[Impala-ASF-CR] IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13299 ) Change subject: IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint .. Patch Set 4: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13299 ) Change subject: IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint .. Patch Set 4: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 ) Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8400: Implement Ranger audit event handler

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13309 ) Change subject: IMPALA-8400: Implement Ranger audit event handler .. Patch Set 12: Code-Review+2 Thanks for the patience with the review

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to planner tests + some fixes

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13414 ) Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to planner tests + some fixes .. Patch Set 2: seems like the test failure i

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 ) Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests .. Patch Set 5: Verified+1 Build failure was a ma

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 20: Code-Review+2 (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8559 : Support config validation for event processor on HMS-3

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13372 ) Change subject: IMPALA-8559 : Support config validation for event processor on HMS-3 .. Patch Set 8: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-8559 : Support config validation for event processor on HMS-3

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13372 ) Change subject: IMPALA-8559 : Support config validation for event processor on HMS-3 .. Patch Set 5: (4 comments) Just a few nits rema

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to planner tests + some fixes

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13414 ) Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to planner tests + some fixes .. Patch Set 1: Code-Review+2 -- To view, vi

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 18: Looks like some of the test failures from patch set 16

[Impala-ASF-CR] IMPALA-8559 : Support config validation for event processor on HMS-3

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13372 ) Change subject: IMPALA-8559 : Support config validation for event processor on HMS-3 .. Patch Set 3: (16 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13299 ) Change subject: IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint .. Patch Set 3: (13 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13299 ) Change subject: IMPALA-8538: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint .. Patch Set 3: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 8: (12 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-8400: Implement Ranger audit event handler

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13309 ) Change subject: IMPALA-8400: Implement Ranger audit event handler .. Patch Set 11: (6 comments) Thanks for making that refactor. Liking

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 ) Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests .. Patch Set 2: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8450: Add support for zstd and lz4 in parquet

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13396 ) Change subject: IMPALA-8450: Add support for zstd and lz4 in parquet .. Patch Set 7: (4 comments) Didn't look through the whole thing,

[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 ) Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/13334

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 15: (3 comments) Did a bit of restructuring to avoid a po

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#15) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter unwan

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13382 ) Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .. IMPALA-8215, IMPALA-84

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 14: (4 comments) I think Sudhanshu's AFK this afternoon s

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#14) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter unwan

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#13) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter unwan

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/1333

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: IMPALA-8435. Prohibit operations on transactional table. .. Removed Code-Review-2 by Todd Lipcon -- To view, visit http://gerrit.cloudera.org:8080/13311 To unsubscr

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: IMPALA-8435. Prohibit operations on transactional table. .. IMPALA-8435. Prohibit operations on transactional tab

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: IMPALA-8435. Prohibit operations on transactional table. .. Patch Set 14: Code-Review-2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: IMPALA-8435. Prohibit operations on transactional table. .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13382 ) Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .. Patch Set 5: Verified+1 Overr

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: IMPALA-8435. Prohibit operations on transactional table. .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13311 To u

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: IMPALA-8435. Prohibit operations on transactional table. .. Patch Set 14: Verified+1 Test failures are due to the unrela

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13382 ) Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .. Patch Set 5: Tim, can you tak

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerr

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 11: Made some changes/fixes and updated the commit message

[Impala-ASF-CR] IMPALA-8435. Prohibit operations on transactional table.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#13) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: IMPALA-8435. Prohibit operations on transactional table. .. IMPALA-843

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#11) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter unwan

[Impala-ASF-CR] [IMPALA-8435] Prohibit operations on transactional table.

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#12) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13311 ) Change subject: [IMPALA-8435] Prohibit operations on transactional table. .. [IMPALA-8

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-21 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13382 to look at the new patch set (#4). Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .

[Impala-ASF-CR] Add decimal parquet to TableFormatInfo.KNOWN FILE FORMATS

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 ) Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS .. Patch Set 2: Does this end up increasing the exhaustive tes

[Impala-ASF-CR] Fix bin/set-classpath.sh error handling when sourced

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13391 ) Change subject: Fix bin/set-classpath.sh error handling when sourced .. Fix bin/set-classpath.sh error handling when sourced 559

[Impala-ASF-CR] Fix bin/set-classpath.sh error handling when sourced

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13391 ) Change subject: Fix bin/set-classpath.sh error handling when sourced .. Patch Set 2: Verified+1 Unrelated test failures in the Java test

[Impala-ASF-CR] Fix bin/set-classpath.sh error handling when sourced

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Fix bin/set-classpath.sh error handling when sourced .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13391 To unsub

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 5: The config template changes look fine

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/131

[Impala-ASF-CR] Fix bin/set-classpath.sh error handling when sourced

2019-05-21 Thread Todd Lipcon (Code Review)
Hello Lars Volker, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13391 to review the following change. Change subject: Fix bin/set-classpath.sh error handling when sourced .. Fix bin/set-c

[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Add a README for data-loading file format, remove

[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL

2019-05-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Patch Set 3: Code-Review+2 Forwarding +2 -- To view, v

[Impala-ASF-CR] IMPALA-8400: Implement Ranger audit event handler

2019-05-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13309 ) Change subject: IMPALA-8400: Implement Ranger audit event handler .. Patch Set 7: (13 comments) http://gerrit.cloudera.org:8080/#/c/133

[Impala-ASF-CR] fe: clean up POM and improve m2e integration

2019-05-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: fe: clean up POM and improve m2e integration .. Removed -Verified by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13365 To unsubscribe, v

[Impala-ASF-CR] fe: clean up POM and improve m2e integration

2019-05-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13365 ) Change subject: fe: clean up POM and improve m2e integration .. Patch Set 4: Verified+1 Overriding the test failure since it's some dock

[Impala-ASF-CR] fe: clean up POM and improve m2e integration

2019-05-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: fe: clean up POM and improve m2e integration .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13365 To unsubscribe,

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-20 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13382 to look at the new patch set (#2). Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .

[Impala-ASF-CR] IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13382 ) Change subject: IMPALA-8215, IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .. Patch Set 1: (2 comments) ht

[Impala-ASF-CR] IMPALA-8566. Fix computation of num nulls for incremental stats

2019-05-20 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13378 to look at the new patch set (#4). Change subject: IMPALA-8566. Fix computation of num_nulls for incremental stats .

[Impala-ASF-CR] fe: clean up POM and improve m2e integration

2019-05-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13365 ) Change subject: fe: clean up POM and improve m2e integration .. fe: clean up POM and improve m2e integration This cleans up a fe

[Impala-ASF-CR] IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode

2019-05-20 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13382 to review the following change. Change subject: IMPALA-8458. Fix setting stats without setting NDVs in local-catalog mode .

[Impala-ASF-CR] fe: clean up POM and improve m2e integration

2019-05-20 Thread Todd Lipcon (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13365 to look at the new patch set (#3). Change subject: fe: clean up POM and improve m2e integration .

[Impala-ASF-CR] IMPALA-8566. Fix computation of num nulls for incremental stats

2019-05-20 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13378 to review the following change. Change subject: IMPALA-8566. Fix computation of num_nulls for incremental stats ..

[Impala-ASF-CR] fe: clean up POM and improve m2e integration

2019-05-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13365 ) Change subject: fe: clean up POM and improve m2e integration .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13365/2/fe

[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL

2019-05-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL

2019-05-20 Thread Todd Lipcon (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13370 to look at the new patch set (#2). Change subject: Add a README for data-loading file format, remove LOAD_LOCAL

[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL

2019-05-17 Thread Todd Lipcon (Code Review)
Hello Joe McDonnell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13370 to review the following change. Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Add

[Impala-ASF-CR] fe: clean up POM and improve m2e integration

2019-05-17 Thread Todd Lipcon (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13365 to look at the new patch set (#2). Change subject: fe: clean up POM and improve m2e integration .

[Impala-ASF-CR] fe: clean up POM and improve m2e integration

2019-05-17 Thread Todd Lipcon (Code Review)
Hello Fredy Wijaya, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13365 to review the following change. Change subject: fe: clean up POM and improve m2e integration .. fe: clean up POM and

[Impala-ASF-CR] Allow running backend tests sharded and in parallel

2019-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13290 ) Change subject: Allow running backend tests sharded and in parallel .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13

[Impala-ASF-CR] IMPALA-7608: Estimate row count from file size when no stats available

2019-05-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12974 ) Change subject: IMPALA-7608: Estimate row count from file size when no stats available .. Patch Set 8: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint

2019-05-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13299 ) Change subject: HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint .. Patch Set 2: (17 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

2019-05-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 ) Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh .. Patch Set 1: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3

2019-05-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13355 ) Change subject: Bump toolchain version to 35-4c4c185a57 to pick up CMake 3.14.3 .. Patch Set 1: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 16: Code-Review+2 -- To view, vi

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Patch Set 2: Do we have the same bug in run-hive-server.sh? if

[Impala-ASF-CR] WIP: temporal query support for Kudu tables

2019-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13342 Change subject: WIP: temporal query support for Kudu tables .. WIP: temporal query support for Kudu tables This adds support for 'table A

[Impala-ASF-CR] IMPALA-8438: Store WriteId and ValidWriteId list for table and partition

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 ) Change subject: IMPALA-8438: Store WriteId and ValidWriteId list for table and partition .. Patch Set 14: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 7: Code-Review+2 Forwarding +2

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support .. IMPALA-8369 (part 3): Hive 3: fix

[Impala-ASF-CR] IMPALA-8121: part 3: invalidate on memory pressure

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13302 ) Change subject: IMPALA-8121: part 3: invalidate on memory pressure .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8369 : Skip test owner privileges test when running against Hive-3

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13339 ) Change subject: IMPALA-8369 : Skip test_owner_privileges test when running against Hive-3 .. Patch Set 2: Code-Review+2 -- To view, vi

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. fe: set classpath using maven dependency resolution This

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-05-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 6: Code-Review+2 Forwarding +2 -- To view, visit http

<    1   2   3   4   5   6   7   8   9   10   >