[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-01 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#4). Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-01 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9053 to look at the new patch set (#2). Change subject: IMPALA-6416: extend Thread::Create to track instance id

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-01 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 1: (6 comments) Thanks for the comments. I

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-01 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-02-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 8: PS8 makes test_stats_extrapolation resilient against

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 12: Code-Review-2 Looks like there was a clang-tidy

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9164 to look at the new patch set (#2). Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC ..

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. IMPALA-3562: support column restriction

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 4: Code-Review+1 Dan, Tim, any last comments? -- To view, visit

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9146 ) Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. IMPALA-6441 addendum: fix reading rows

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 10: > Patch Set 10: Code-Review+2 Phil, in my understanding I

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-02-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 10: Code-Review+1 (1 comment) lgtm, Phil any additional

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-02-01 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9153 to look at the new patch set (#8). Change subject: IMPALA-5293: Turn insert clustering on by default ..

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-02-01 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9146 ) Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-02-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-01 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dimitris Tsirogiannis, Alex Behm, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9123 to look at the new patch set (#11). Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-02-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9053 ) Change subject: IMPALA-6416: extend Thread::Create to track instance id .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-01 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#21). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 20: (9 comments)

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-02-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8950 to look at the new patch set (#12). Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-02-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 12: Code-Review+2 Rebase, carry +2. Retrying GVO

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 10: > Patch Set 10: > > > Patch Set 10: Code-Review+2 > >

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-02-01 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8997 to look at the new patch set (#6). Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. IMPALA-6429: Fix decimal division Before this patch, it was possible for an

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 5: Code-Review+2 Forwarding the +2. Thanks for the reviews, Zach

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 10: > Patch Set 10: > > > Patch Set 10: > > > > > Patch Set

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-01 Thread Bikramjeet Vig (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8971 to look at the new patch set (#8). Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 8: Looks like the API for Metric changed

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-02-01 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-02-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8997 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 12: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9186 Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. IMPALA-6456: Add

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. IMPALA-3916: Reserve SQL:2016 reserved words This

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5717: Support for ORC data files

2018-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for ORC data files .. Patch Set 3: (44 comments) This is really impressive - I was able to build

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8997 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5717: Support for ORC data files

2018-02-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for ORC data files .. Patch Set 3: I'm still trying to grok the patch. I have a couple of

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. Patch Set 10: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. IMPALA-6429: Fix decimal division Before this patch, it was

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-01 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 21: (2 comments)

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-02-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. Patch Set 11: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. IMPALA-6193: Track memory of incoming data

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-01 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 12: Code-Review-1 My change seems to be related with the

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-02-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. IMPALA-4319: remove some deprecated query options