[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-04-11 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9986 Change subject: IMPALA-3307: Add support for IANA time-zone db .. IMPALA-3307: Add support for IANA time-zone db Impala currently uses

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9980 ) Change subject: IMPALA-6723: [DOCS] Hints for CTAS .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-6831: [DOCS] Remove the note about TLS1.2 on RHEL 6 and CentOS 6

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9983 ) Change subject: IMPALA-6831: [DOCS] Remove the note about TLS1.2 on RHEL 6 and CentOS 6 .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-04-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 1: (2 comments) Just skimmed through. Will do several

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6831: [DOCS] Remove the note about TLS1.2 on RHEL 6 and CentOS 6

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9983 ) Change subject: IMPALA-6831: [DOCS] Remove the note about TLS1.2 on RHEL 6 and CentOS 6 .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6831: [DOCS] Remove the note about TLS1.2 on RHEL 6 and CentOS 6

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9983 ) Change subject: IMPALA-6831: [DOCS] Remove the note about TLS1.2 on RHEL 6 and CentOS 6 .. IMPALA-6831: [DOCS] Remove

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-04-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Attila Jeges, Dimitris Tsirogiannis, Tim Armstrong, Csaba Ringhofer, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9005 to look at the new patch set (#22). Change subject: IMPALA-6314: Add run time scalar subquery check

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-04-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 23: (6 comments)

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9976 to look at the new patch set (#3). Change subject: Move some test_spilling debug actions to exhaustive .. Move

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 2: Code-Review+2 (2 comments) Alex Behm pointed

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. Patch Set 1: I don't have +2 rights, so someone else must do that.

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 2: (2 comments)

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 3: Code-Review+2 carry +2 -- To view, visit

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 3: And yeah, these tests are definitely time

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6710: [DOCS] Update the Partition Insert content

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9977 ) Change subject: IMPALA-6710: [DOCS] Update the Partition Insert content .. Patch Set 1: Build started:

[Impala-ASF-CR] WIP

2018-04-11 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9980 to look at the new patch set (#3). Change subject: WIP

[Impala-ASF-CR] IMPALA-6723 Hints for CTAS

2018-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9992 Change subject: IMPALA-6723 Hints for CTAS .. IMPALA-6723 Hints for CTAS Change-Id: I201a4e1ddaf62164e1f6b636c4e1e60af60e1af7 --- M

[Impala-ASF-CR] WIP

2018-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9980 ) Change subject: WIP .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/9980/2/docs/topics/impala_hints.xml File

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9993 Change subject: IMPALA-6723: [DOCS] Hints for CTAS .. IMPALA-6723: [DOCS] Hints for CTAS Optimizer hints were move out of SELECT section.

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. Patch Set 1: Build failed:

[Impala-ASF-CR] WIP

2018-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has abandoned this change. ( http://gerrit.cloudera.org:8080/9980 ) Change subject: WIP .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9980 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-6710: [DOCS] Update the Partition Insert content

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9977 ) Change subject: IMPALA-6710: [DOCS] Update the Partition Insert content .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6710: [DOCS] Update the Partition Insert content

2018-04-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9977 ) Change subject: IMPALA-6710: [DOCS] Update the Partition Insert content .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6723 Hints for CTAS

2018-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has abandoned this change. ( http://gerrit.cloudera.org:8080/9992 ) Change subject: IMPALA-6723 Hints for CTAS .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9992 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-11 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9993 to look at the new patch set (#2). Change subject: IMPALA-6723: [DOCS] Hints for CTAS

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 ) Change subject: IMPALA-5814: Remove startup flag to disable admission control .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. IMPALA-2195: Improper handling of comments in queries This patch

[Impala-ASF-CR] IMPALA-6710: [DOCS] Update the Partition Insert content

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9977 ) Change subject: IMPALA-6710: [DOCS] Update the Partition Insert content .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-04-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 5: Apologies for the delay on this and

[Impala-ASF-CR] IMPALA-6710: [DOCS] Update the Partition Insert content

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9977 ) Change subject: IMPALA-6710: [DOCS] Update the Partition Insert content .. IMPALA-6710: [DOCS] Update the Partition

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9928 to look at the new patch set (#3). Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY ..

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-11 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9960 to look at the new patch set (#4). Change subject: IMPALA-6120: Add thread timers for reporting codegen time

[Impala-ASF-CR] Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10025 Change subject: Add --partial_ok to compare_branches.py. .. Add --partial_ok to compare_branches.py. This change lets

[Impala-ASF-CR] Add --partial ok to compare branches.py.

2018-04-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10025 ) Change subject: Add --partial_ok to compare_branches.py. .. Patch Set 1: Code-Review+2 Thanks for doing this! -- To view, visit

[Impala-ASF-CR] IMPALA-4631: loosen monotonic clock DCHECK

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10026 Change subject: IMPALA-4631: loosen monotonic clock DCHECK .. IMPALA-4631: loosen monotonic clock DCHECK We saw another build failure

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 4: Code-Review+1 carry -- To view, visit

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9928 to look at the new patch set (#4). Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY ..

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 4: Could you have a look at this Mike? Would be

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4631: loosen monotonic clock DCHECK

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10026 ) Change subject: IMPALA-4631: loosen monotonic clock DCHECK .. Patch Set 1: Code-Review+2 (2 comments) Weird. +2 but see my

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-04-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 23: (3 comments) Code looks

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 7: (5 comments) I'm kind of in the same mode

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. IMPALA-6623: [DOCS] ltrim and rtrim docs updated

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-11 Thread Bikramjeet Vig (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9960 to look at the new patch set (#3). Change subject: IMPALA-6120: Add thread timers for reporting codegen time

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-04-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 21: (1 comment)

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9960 ) Change subject: IMPALA-6120: Add thread timers for reporting codegen time .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR](2.x) Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10027 Change subject: Add --partial_ok to compare_branches.py. .. Add --partial_ok to compare_branches.py. This change lets

[Impala-ASF-CR](2.x) Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10027 ) Change subject: Add --partial_ok to compare_branches.py. .. Add --partial_ok to compare_branches.py. This change lets

[Impala-ASF-CR] Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10025 ) Change subject: Add --partial_ok to compare_branches.py. .. Patch Set 1: Verified+1 GVD is not helpful with this script, so I'm

[Impala-ASF-CR](2.x) Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10027 ) Change subject: Add --partial_ok to compare_branches.py. .. Patch Set 1: Verified+1 Code-Review+2 Clean pick. -- To view, visit

[Impala-ASF-CR] Add --partial ok to compare branches.py.

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10025 ) Change subject: Add --partial_ok to compare_branches.py. .. Add --partial_ok to compare_branches.py. This change lets

[Impala-ASF-CR] IMPALA-4631: loosen monotonic clock DCHECK

2018-04-11 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10026 to look at the new patch set (#2). Change subject: IMPALA-4631: loosen monotonic clock DCHECK .. IMPALA-4631:

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Michael Brown, Philip Zeyliger, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9995 to look at the new patch set (#3). Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 2: > Somewhere along the way, you mentioned

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-04-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 21: Thank you, Tim, Dan, and Joe! I do appreciate your

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 ) Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY .. Patch Set 3: Code-Review+1 (1 comment) Thank you for fixing

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Add tpcds-unmodified performance workload.

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/5813 ) Change subject: Add tpcds-unmodified performance workload. .. Abandoned Let's just abandon until the new version is ready for review. We can

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 7: Michael, pls have a look at the python

[Impala-ASF-CR] IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9949 ) Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6710: [DOCS] Update the Partition Insert content

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9977 ) Change subject: IMPALA-6710: [DOCS] Update the Partition Insert content .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-4631: loosen monotonic clock DCHECK

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10026 ) Change subject: IMPALA-4631: loosen monotonic clock DCHECK .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9994 Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory .. IMPALA-6809: Allow bootstrap_system.sh in non

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 2: Somewhere along the way, you mentioned

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

2018-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9996 Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege .. IMPALA-6480: [DOCS] DESCRIBE respects column-level

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 ) Change subject: IMPALA-5814: Remove startup flag to disable admission control .. Patch Set 2: Code-Review+2 (1 comment) This looks

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 ) Change subject: IMPALA-5814: Remove startup flag to disable admission control .. Patch Set 2: -Code-Review Actually we should separate

[Impala-ASF-CR] IMPALA-6623: [DOCS] ltrim and rtrim docs updated

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9984 ) Change subject: IMPALA-6623: [DOCS] ltrim and rtrim docs updated .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9993 ) Change subject: IMPALA-6723: [DOCS] Hints for CTAS .. Patch Set 2: > What is the relation between this change and the abandoned one that

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9995 to look at the new patch set (#2). Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9993 ) Change subject: IMPALA-6723: [DOCS] Hints for CTAS .. Patch Set 2: What is the relation between this change and the abandoned one that

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9995 Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. IMPALA-6811: Increase timeout on S3 for

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9949 ) Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Move some test spilling debug actions to exhaustive

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9976 ) Change subject: Move some test_spilling debug actions to exhaustive .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-11 Thread Bikramjeet Vig (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9964 to look at the new patch set (#3). Change subject: IMPALA-5814: Remove startup flag to disable admission control

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 ) Change subject: IMPALA-5814: Remove startup flag to disable admission control .. Patch Set 2: (1 comment) > Actually we should

[Impala-ASF-CR] IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9995 ) Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays .. Patch Set 4: Build started:

  1   2   >