[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-05 Thread Gabor Kaszab (Code Review)
Hello Bharath Vissapragada, Zoltan Borok-Nagy, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10543 to look at the new patch set (#6). Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 6: (1 comment)

[Impala-ASF-CR] Collect hs err pid*.log files in logs/

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10594 ) Change subject: Collect hs_err_pid*.log files in logs/ .. Collect hs_err_pid*.log files in logs/ These JVM error dumps are

[Impala-ASF-CR] Collect hs err pid*.log files in logs/

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 ) Change subject: Collect hs_err_pid*.log files in logs/ .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Collect hs err pid*.log files in logs/

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10594 ) Change subject: Collect hs_err_pid*.log files in logs/ .. Patch Set 1: Seems ok to promote to a +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. Patch Set 1: (1 comment)

[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-05 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Michael Brown, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10603 to review the following change. Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout

[Impala-ASF-CR](2.x) IMPALA-6642 (Part 1): Fix the log directory for test redaction.py

2018-06-05 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10604 to review the following change. Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py

[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10603 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 1: Build started:

[Impala-ASF-CR](2.x) IMPALA-6642 (Part 1): Fix the log directory for test redaction.py

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10604 ) Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py .. Patch Set 1: Build started:

[Impala-ASF-CR](2.x) IMPALA-6642 (Part 1): Fix the log directory for test redaction.py

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10604 ) Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10603 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7108: IllegalStateException hit during CardinalityCheckNode.

2018-06-05 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10605 Change subject: IMPALA-7108: IllegalStateException hit during CardinalityCheckNode. .. IMPALA-7108: IllegalStateException hit

[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-05 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10603 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-05 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 11: > (1 comment) > > Yeah I agree with Phil that doing

[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: > Surely, we're not shipping

[Impala-ASF-CR](2.x) IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10603 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. IMPALA-6947: Kudu tests flaky due to rpc timeout Some

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 3: (1 comment)

[Impala-ASF-CR](2.x) IMPALA-6642 (Part 1): Fix the log directory for test redaction.py

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10604 ) Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6642 (Part 1): Fix the log directory for test redaction.py

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10604 ) Change subject: IMPALA-6642 (Part 1): Fix the log directory for test_redaction.py .. IMPALA-6642 (Part 1): Fix the log

[Impala-ASF-CR] IMPALA-7099: Don't set FILESYSTEM PREFIX for s3

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10595 ) Change subject: IMPALA-7099: Don't set FILESYSTEM_PREFIX for s3 .. Patch Set 2: Code-Review+2 Thanks for doing this! We should've

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7108: IllegalStateException hit during CardinalityCheckNode.

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10605 ) Change subject: IMPALA-7108: IllegalStateException hit during CardinalityCheckNode. .. Patch Set 1: Did you want to also include

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-05 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. IMPALA-3307: Add support for IANA time-zone db Impala currently uses

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: Just added David as a reviewer. David, I seem to recall a while

[Impala-ASF-CR] Guard S3 access check with variable

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10607 ) Change subject: Guard S3 access check with variable .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: Code-Review+1 > My private build hit

[Impala-ASF-CR] IMPALA-7110. Fix some warnings from error-prone

2018-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix some warnings from error-prone .. Patch Set 1: (2 comments)

[Impala-ASF-CR] [DOCS] Added the hotspot analysis to Performance Best Practices doc

2018-06-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10472 ) Change subject: [DOCS] Added the hotspot analysis to Performance Best Practices doc .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Added the hotspot analysis to Performance Best Practices doc

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10472 ) Change subject: [DOCS] Added the hotspot analysis to Performance Best Practices doc .. Patch Set 2: Build started:

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Thanks! Sorry to be pedantic -- To view, visit

[Impala-ASF-CR] Add missing namespace qualifiers

2018-06-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10608 Change subject: Add missing namespace qualifiers .. Add missing namespace qualifiers As part of an upcoming rebase of the KRPC code,

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: What are the next steps here? -- To view, visit

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Rahul Shivu Mahadev (Code Review)
Rahul Shivu Mahadev has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: > Thanks for your contribution! > > One nit about the commit

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Rahul Shivu Mahadev (Code Review)
Hello Thomas Marshall, Jim Apple, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10560 to look at the new patch set (#2). Change subject: Fix Indents from IMPALA-4970

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 5: (2 comments)

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Build started:

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10560

[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code

2018-06-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: > > My private build hit IMPALA-7070 when

[Impala-ASF-CR] IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE

2018-06-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10452 ) Change subject: IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10452 ) Change subject: IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE .. Patch Set 1: Build started:

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: > We hadn't really opened up commits yet, but this one seems safe. >

[Impala-ASF-CR] Guard S3 access check with variable

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10607 ) Change subject: Guard S3 access check with variable .. Patch Set 2: Build started:

[Impala-ASF-CR] Guard S3 access check with variable

2018-06-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10607 ) Change subject: Guard S3 access check with variable .. Patch Set 2: Code-Review+2 (1 comment) Thanks for the review. I addressed the

[Impala-ASF-CR] IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10452 ) Change subject: IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: We hadn't really opened up commits yet, but this one seems safe. I'm

[Impala-ASF-CR] IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10452 ) Change subject: IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE .. IMPALA-6909: [DOCS] SET ROW FORMAT in ALTER TABLE

[Impala-ASF-CR] [DOCS] Added the hotspot analysis to Performance Best Practices doc

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10472 ) Change subject: [DOCS] Added the hotspot analysis to Performance Best Practices doc .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] [DOCS] Added the hotspot analysis to Performance Best Practices doc

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10472 ) Change subject: [DOCS] Added the hotspot analysis to Performance Best Practices doc .. [DOCS] Added the hotspot

[Impala-ASF-CR] Guard S3 access check with variable

2018-06-05 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10607 to look at the new patch set (#2). Change subject: Guard S3 access check with variable .. Guard S3 access check

[Impala-ASF-CR] Add missing namespace qualifiers

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10608 ) Change subject: Add missing namespace qualifiers .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-05 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 1: READ_AT_SNAPSHOT was reverted because it caused

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 6: (2 comments) Just one more

[Impala-ASF-CR] IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code

2018-06-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 ) Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code .. Patch Set 2: Code-Review+1 My private build hit

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Add missing namespace qualifiers

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10608 ) Change subject: Add missing namespace qualifiers .. Patch Set 1: Code-Review+2 Thanks! Seems ok to go in now. -- To view, visit

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10606 to look at the new patch set (#2). Change subject: IMPALA-7120: remove sonatype repository ..

[Impala-ASF-CR] Guard S3 access check with variable

2018-06-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10607 Change subject: Guard S3 access check with variable .. Guard S3 access check with variable We've recently seen automated build failures

[Impala-ASF-CR] IMPALA-7012: Fix NPE when parsing unexpected tokens

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10512 ) Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-7050: [DOCS] Document the max serialized incremental stat size setting

2018-06-05 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10457 ) Change subject: IMPALA-7050: [DOCS] Document the max serialized incremental stat size setting .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-7110. Fix some warnings from error-prone

2018-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 ) Change subject: IMPALA-7110. Fix some warnings from error-prone .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes

2018-06-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10561 ) Change subject: IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10606 ) Change subject: IMPALA-7120: remove sonatype repository .. Patch Set 2: Code-Review+2 If this passes the build, it should be good.

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes

2018-06-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10561 ) Change subject: IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes .. Patch Set 2: HI Balazs, Could you review my

[Impala-ASF-CR] IMPALA-5380: [DOCS] Added additional filesystems supported in URI

2018-06-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10551 ) Change subject: IMPALA-5380: [DOCS] Added additional filesystems supported in URI .. Patch Set 2: Hi Lars, Could you review the patch

[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs

2018-06-05 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 ) Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs .. Patch Set 5: Hi Vuk, Could you review the

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10606 ) Change subject: IMPALA-7120: remove sonatype repository .. Patch Set 2: I looked at the mvn logs and it appears that this change

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. IMPALA-6917: Implement COMMENT ON TABLE/VIEW This patch implements

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10561 ) Change subject: IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes .. IMPALA-7100: [DOCS] Consistent

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10606 ) Change subject: IMPALA-7120: remove sonatype repository .. Patch Set 2: I'll try that also to confirm. -- To view, visit

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-05 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 5: Tim, please take a look at the

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10601 to look at the new patch set (#5). Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

[Impala-ASF-CR] IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes

2018-06-05 Thread Balazs Jeszenszky (Code Review)
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10561 ) Change subject: IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes .. Patch Set 2: Code-Review+1 Feel free to

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10601 to look at the new patch set (#4). Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 3: (3 comments) Tim, could you

[Impala-ASF-CR] IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10601 ) Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can lead to hang .. Patch Set 4: Oops, hold on one second. --

[Impala-ASF-CR] IMPALA-7110. Fix errors from error-prone

2018-06-05 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10583 to look at the new patch set (#2). Change subject: IMPALA-7110. Fix errors from error-prone

[Impala-ASF-CR] IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10561 ) Change subject: IMPALA-7100: [DOCS] Consistent memory alloc across executor nodes .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (1 comment) thanks for the

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10606 ) Change subject: IMPALA-7120: remove sonatype repository .. Patch Set 2: Verified+1 Yep, it worked after I blew away ~/.m2/repository

[Impala-ASF-CR] IMPALA-7120: remove sonatype repository

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10606 ) Change subject: IMPALA-7120: remove sonatype repository .. IMPALA-7120: remove sonatype repository >From what I can tell, we

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-06-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 8: Philip, can you review this and give a +2 if you

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-7012: Fix NPE when parsing unexpected tokens

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10512 ) Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens .. IMPALA-7012: Fix NPE when parsing unexpected

[Impala-ASF-CR] IMPALA-7012: Fix NPE when parsing unexpected tokens

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10512 ) Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5737: Tighten minicluster memory limit

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10277 ) Change subject: IMPALA-5737: Tighten minicluster memory limit .. Patch Set 7: Code-Review-2 Please don't merge this until I give it

[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10570 ) Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10550 ) Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans .. Patch Set 7: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10602 to look at the new patch set (#2). Change subject: IMPALA-6956: deflake and logging for query_expiration test ..

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10550 to look at the new patch set (#8). Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

[Impala-ASF-CR] IMPALA-7078: Part 1: improve memory consumption of wide Avro scans

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10550 ) Change subject: IMPALA-7078: Part 1: improve memory consumption of wide Avro scans .. Patch Set 7: (4 comments)

  1   2   >