date:20180412

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10030 )

Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10030/4/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java:

http://gerrit.cloudera.org:8080/#/c/10030/4/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@259
PS4, Line 259:   if 
(kuduTableName.equals(KuduUtil.getDefaultCreateKuduTableName(
> Do we still need this logic?
I believe we still need it because this is used by "show create table" 
statement whereas the others are used by toSql() method. Removing this causes 
test_external_kudu_table_name_with_show_create to fail.



--
To view, visit http://gerrit.cloudera.org:8080/10030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Fri, 13 Apr 2018 05:13:22 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

Fredy Wijaya has uploaded a new patch set (#5). ( 
http://gerrit.cloudera.org:8080/10030 )

Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables
..

IMPALA-6451: AuthorizationException in CTAS for Kudu tables

CREATE TABLE on EXTERNAL Kudu tables or with TBLPROPERTIES
('kudu.master_addresses') require ALL privileges on SERVER.
See IMPALA-4000.

The patch fixes a bug where the CTAS statement is rewritten
and during the initial analysis phase, 'kudu.master_addresses'
property is added into TBLPROPERTIES which causes the next
analysis phase to assume the statement was executed with
TBLPROPERTIES ('kudu.master_addresses'). Hence, causing the
ALL privilege request on SERVER to be registered.

This patch also refactors the generated Kudu table name into
a single place that stores all generated Kudu properties that
gets cleared when the statement is reset.

Testing:
- Added a new test
- Ran all front-end tests
- Ran Kudu end-to-end query tests

Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
4 files changed, 48 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/10030/5
--
To view, visit http://gerrit.cloudera.org:8080/10030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya

[Impala-ASF-CR](2.x) IMPALA-5717: Support for reading ORC data files

2018-04-12 Thread Quanlong Huang (Code Review)

Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9988 )

Change subject: IMPALA-5717: Support for reading ORC data files
..


Patch Set 2:

I just find that I ignore this... Thank you, Tim, Joe, Philip, and Tianyi for 
doing this for me!


--
To view, visit http://gerrit.cloudera.org:8080/9988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b6ae4ce3b9ee8125b21993702faa87537790a4
Gerrit-Change-Number: 9988
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 13 Apr 2018 04:55:20 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10044 )

Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19
..


Patch Set 1:

Passed a gerrit-verify-dryrun-external and a core run on machines that run 
python 2.6.


--
To view, visit http://gerrit.cloudera.org:8080/10044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5289f86b78f1d77d91a8fa47d63b7a7eaa3af38
Gerrit-Change-Number: 10044
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Fri, 13 Apr 2018 03:36:09 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

Joe McDonnell has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10044


Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19
..

IMPALA-6790: Upgrade sqlparse to 0.1.19

Some remote cluster tests have failed to load data
due to sqlparse failing to split SQL statements
appropriately. The SQL file itself is identical
to our usual dataload, so it must be a unique
environment. The current version of sqlparse is
0.1.15.

This upgrades sqlparse to 0.1.19. When running on
the same environment with the newer version,
the problem does not occur.

Change-Id: Ic5289f86b78f1d77d91a8fa47d63b7a7eaa3af38
---
M infra/python/deps/requirements.txt
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/10044/1
--
To view, visit http://gerrit.cloudera.org:8080/10044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5289f86b78f1d77d91a8fa47d63b7a7eaa3af38
Gerrit-Change-Number: 10044
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR](2.x) IMPALA-5717: Support for reading ORC data files

Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9988 )

Change subject: IMPALA-5717: Support for reading ORC data files
..


Patch Set 1:

Tianyi's change is in. Submitting.


--
To view, visit http://gerrit.cloudera.org:8080/9988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b6ae4ce3b9ee8125b21993702faa87537790a4
Gerrit-Change-Number: 9988
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 13 Apr 2018 03:25:15 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-5717: Support for reading ORC data files

Joe McDonnell has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9988 )

Change subject: IMPALA-5717: Support for reading ORC data files
..

IMPALA-5717: Support for reading ORC data files

This patch integrates the orc library into Impala and implements
HdfsOrcScanner as a middle layer between them. The HdfsOrcScanner
supplies input needed from the orc-reader, tracks memory consumption of
the reader and transfers the reader's output (orc::ColumnVectorBatch)
into impala::RowBatch. The ORC version we used is release-1.4.3.

A startup option --enable_orc_scanner is added for this feature. It's
set to true by default. Setting it to false will fail queries on ORC
tables.

Currently, we only support reading primitive types. Writing into ORC
table has not been supported neither.

Tests
 - Most of the end-to-end tests can run on ORC format.
 - Add tpcds, tpch tests for ORC.
 - Add some ORC specific tests.
 - Haven't enabled test_scanner_fuzz for ORC yet, since the ORC library
   is not robust for corrupt files (ORC-315).

Change-Id: Ia7b6ae4ce3b9ee8125b21993702faa87537790a4
Reviewed-on: http://gerrit.cloudera.org:8080/9134
Reviewed-by: Quanlong Huang 
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins 
Reviewed-on: http://gerrit.cloudera.org:8080/9988
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/codegen/gen_ir_descriptions.py
M be/src/exec/CMakeLists.txt
A be/src/exec/hdfs-orc-scanner.cc
A be/src/exec/hdfs-orc-scanner.h
M be/src/exec/hdfs-parquet-scanner-ir.cc
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/exec/hdfs-parquet-scanner.h
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-mt.cc
M be/src/exec/hdfs-scanner-ir.cc
M be/src/exec/hdfs-scanner.cc
M be/src/exec/hdfs-scanner.h
M be/src/util/backend-gflag-util.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
A cmake_modules/FindOrc.cmake
M common/thrift/BackendGflags.thrift
M common/thrift/CatalogObjects.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/jflex/sql-scanner.flex
M testdata/LineItemMultiBlock/README.dox
A testdata/LineItemMultiBlock/lineitem_orc_multiblock_one_stripe.orc
A testdata/LineItemMultiBlock/lineitem_sixblocks.orc
A testdata/LineItemMultiBlock/lineitem_threeblocks.orc
M testdata/bin/create-load-data.sh
M testdata/bin/generate-schema-statements.py
M testdata/bin/run-hive-server.sh
M testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl
A testdata/data/chars-formats.orc
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M 
testdata/workloads/functional-planner/queries/PlannerTest/complex-types-file-formats.test
M testdata/workloads/functional-query/functional-query_core.csv
M testdata/workloads/functional-query/functional-query_dimensions.csv
M testdata/workloads/functional-query/functional-query_exhaustive.csv
M testdata/workloads/functional-query/functional-query_pairwise.csv
A 
testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test
M testdata/workloads/tpcds/tpcds_core.csv
M testdata/workloads/tpcds/tpcds_dimensions.csv
M testdata/workloads/tpcds/tpcds_exhaustive.csv
M testdata/workloads/tpcds/tpcds_pairwise.csv
M testdata/workloads/tpch/tpch_core.csv
M testdata/workloads/tpch/tpch_dimensions.csv
M testdata/workloads/tpch/tpch_exhaustive.csv
M testdata/workloads/tpch/tpch_pairwise.csv
M tests/common/impala_test_suite.py
M tests/common/test_dimensions.py
M tests/common/test_vector.py
M tests/comparison/cli_options.py
M tests/query_test/test_chars.py
M tests/query_test/test_decimal_queries.py
M tests/query_test/test_scanners.py
M tests/query_test/test_scanners_fuzz.py
M tests/query_test/test_tpch_queries.py
62 files changed, 1,745 insertions(+), 307 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7b6ae4ce3b9ee8125b21993702faa87537790a4
Gerrit-Change-Number: 9988
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Quanlong Huang 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 7: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Fri, 13 Apr 2018 00:44:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..

IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory

Testing:
- Ran bootstrap_development.sh with IMPALA_HOME set to non ~/Impala
  directory
- Ran bootstrap_development.sh with IMPALA_HOME not set

Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Reviewed-on: http://gerrit.cloudera.org:8080/9994
Reviewed-by: Fredy Wijaya 
Reviewed-by: Philip Zeyliger 
Tested-by: Impala Public Jenkins 
---
M bin/bootstrap_system.sh
1 file changed, 14 insertions(+), 8 deletions(-)

Approvals:
  Fredy Wijaya: Looks good to me, but someone else must approve
  Philip Zeyliger: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10030 )

Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables
..


Patch Set 4:

(1 comment)

Nice! Looks much cleaner.

http://gerrit.cloudera.org:8080/#/c/10030/4/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java:

http://gerrit.cloudera.org:8080/#/c/10030/4/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@259
PS4, Line 259:   String kuduTableName = 
properties.get(KuduTable.KEY_TABLE_NAME);
Do we still need this logic?



--
To view, visit http://gerrit.cloudera.org:8080/10030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Fri, 13 Apr 2018 00:28:47 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6463: [DOCS] Removed query options were deleted from docs

2018-04-12 Thread Tim Armstrong (Code Review)

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10055 )

Change subject: IMPALA-6463: [DOCS] Removed query options were deleted from docs
..


Patch Set 1: Code-Review+2

Thanks!


--
To view, visit http://gerrit.cloudera.org:8080/10055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71be3f872468cb22583f82c2238bf72dc82cb750
Gerrit-Change-Number: 10055
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 13 Apr 2018 00:00:49 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9972 )

Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER
..

IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

This change add the last two privileges at the SERVER level.

GRANT SELECT ON SERVER TO ROLE test_role;
REVOKE SELECT ON SERVER FROM ROLE test_role;
GRANT INSERT ON SERVER TO ROLE test_role
REVOKE INSERT ON SERVER FROM ROLE test_role

Testing:
Added tests to cover server level select and insert.
Ran all front-end tests.

Change-Id: If6510b4d54c9902029a357f1aebb2570cd75855d
Reviewed-on: http://gerrit.cloudera.org:8080/9972
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins 
---
M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeAuthStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
3 files changed, 179 insertions(+), 29 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If6510b4d54c9902029a357f1aebb2570cd75855d
Gerrit-Change-Number: 9972
Gerrit-PatchSet: 7
Gerrit-Owner: Adam Holley 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9972 )

Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER
..


Patch Set 6: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6510b4d54c9902029a357f1aebb2570cd75855d
Gerrit-Change-Number: 9972
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Holley 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 23:57:53 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9960 )

Change subject: IMPALA-6120: Add thread timers for reporting codegen time
..


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2300/


--
To view, visit http://gerrit.cloudera.org:8080/9960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24d5a46b8870bc959b89045432d2e86af72b30e5
Gerrit-Change-Number: 9960
Gerrit-PatchSet: 6
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 12 Apr 2018 23:54:34 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10048 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 10048
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Thu, 12 Apr 2018 23:53:50 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10048 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..

IMPALA-6820: Remove _impala_builtins from catalogd

The _impala_builtins database is initialized in the constructor of
Catalog and hence is inherited by both the CatalogServiceCatalog and
ImpaladCatalog. Since  _impala_builtins is not used by the catalog
server and to avoid the overhead of managing this database during normal
metadata operations (e.g. invalidate), it is moved to the ImpaladCatalog
class.

Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Reviewed-on: http://gerrit.cloudera.org:8080/9947
Reviewed-by: Tianyi Wang 
Tested-by: Impala Public Jenkins 
(cherry picked from commit 17137d783c24d0ec0827db62bb256ec4c2c05164)
Reviewed-on: http://gerrit.cloudera.org:8080/10048
Reviewed-by: Dimitris Tsirogiannis 
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/ExtractFromExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionName.java
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
11 files changed, 35 insertions(+), 32 deletions(-)

Approvals:
  Dimitris Tsirogiannis: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 10048
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-04-12 Thread Bharath Vissapragada (Code Review)

Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9933 )

Change subject: IMPALA-2195: Improper handling of comments in queries
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9933/3/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/9933/3/shell/impala_shell.py@1279
PS3, Line 1279: line = 
ImpalaShell.strip_trailing_comment(line.strip()).encode('utf-8')
> That was my initial attempt but then I realized it won't work because of th
Right. Currently, if you see the web UI of the running/completed queries, it 
includes the query stmt, along with the leading comments. While we are not sure 
how many users actually rely on the comment data, my thinking is that it helps 
set the context in complex workflows involving huge queries, as users typically 
include some description about what the query is about.

Not sure if others have a different opinion on this.


http://gerrit.cloudera.org:8080/#/c/9933/3/shell/impala_shell.py@1285
PS3, Line 1285:   def strip_trailing_comment(sql):
> In other places, we strip all comments from the whole line. For this partic
Yea, a totally stripped query can also help deduce the "query type". Like you 
mentioned in your previous comment, it requires changes in other places. 
Basically, we don't want to overwrite the 'line' itself, but keep a copy.



--
To view, visit http://gerrit.cloudera.org:8080/9933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7
Gerrit-Change-Number: 9933
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Taras Bobrovytsky 
Gerrit-Comment-Date: Thu, 12 Apr 2018 23:45:05 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6463: [DOCS] Removed query options were deleted from docs

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10055


Change subject: IMPALA-6463: [DOCS] Removed query options were deleted from docs
..

IMPALA-6463: [DOCS] Removed query options were deleted from docs

The following query option docs and references were removed from docs:
- DEFAULT_ORDER_BY_LIMIT
- ABORT_ON_DEFAULT_LIMIT_EXCEEDED
- V_CPU_CORES (previously removed)
- RESERVATION_REQUEST_TIMEOUT (previously removed)
- RM_INITIAL_MEM
- SCAN_NODE_CODEGEN_THRESHOLD
- MAX_IO_BUFFERS
- DISABLE_CACHED_READS

Change-Id: I71be3f872468cb22583f82c2238bf72dc82cb750
Cherry-picks: not for 2.x.
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
D docs/topics/impala_abort_on_default_limit_exceeded.xml
D docs/topics/impala_default_order_by_limit.xml
D docs/topics/impala_disable_cached_reads.xml
D docs/topics/impala_max_io_buffers.xml
M docs/topics/impala_order_by.xml
D docs/topics/impala_rm_initial_mem.xml
D docs/topics/impala_scan_node_codegen_threshold.xml
9 files changed, 0 insertions(+), 360 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/10055/1
--
To view, visit http://gerrit.cloudera.org:8080/10055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71be3f872468cb22583f82c2238bf72dc82cb750
Gerrit-Change-Number: 10055
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-04-12 Thread Sailesh Mukil (Code Review)

Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9966 )

Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS 
based table
..


Patch Set 1:

> Patch Set 1:
>
> > Patch Set 1:
> >
> > I haven't added a custom cluster test for this since hedged reads are not 
> > deterministic, and we'd be dealing with a bunch of flakiness.
>
> I'm uncomfortable that we've got a flag with no testing of the code path 
> behind it.
>
> Can you force a hedged read by "kill -STOP"'ing a datanode before the query 
> and "kill -CONT" afterwards?

Thanks for the suggestion, Phil. I will try this.


--
To view, visit http://gerrit.cloudera.org:8080/9966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48fe80dfd9a1ed68a8f2b7038e5f42b5a3df3baa
Gerrit-Change-Number: 9966
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Thu, 12 Apr 2018 23:34:08 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-12 Thread Michael Brown (Code Review)

Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10053 )

Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice
..


Patch Set 2:

(1 comment)

great catch

http://gerrit.cloudera.org:8080/#/c/10053/2/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:

http://gerrit.cloudera.org:8080/#/c/10053/2/tests/common/test_dimensions.py@193
PS2, Line 193: new_value[-1].value["exec_single_node_rows_threshold"] = 100
copy/paste. I think here's where you want to use key and value



--
To view, visit http://gerrit.cloudera.org:8080/10053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida659aa7b5131a6a7469baa93a41f7581bd0659a
Gerrit-Change-Number: 10053
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall 
Gerrit-Reviewer: Michael Brown 
Gerrit-Comment-Date: Thu, 12 Apr 2018 23:26:33 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10030 )

Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10030/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/10030/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@68
PS2, Line 68: Preconditions.checkNotNull(tableDef);
> This flag is extremely specific and I think it adds to the reset/re-analyze
Yeah, that's a cleaner approach. I'll refactor the generated Kudu table name 
stuff as well.



--
To view, visit http://gerrit.cloudera.org:8080/10030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Thu, 12 Apr 2018 23:20:37 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

Fredy Wijaya has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/10030 )

Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables
..

IMPALA-6451: AuthorizationException in CTAS for Kudu tables

CREATE TABLE on EXTERNAL Kudu tables or with TBLPROPERTIES
('kudu.master_addresses') require ALL privileges on SERVER.
See IMPALA-4000.

The patch fixes a bug where the CTAS statement is rewritten
and during the initial analysis phase, 'kudu.master_addresses'
property is added into TBLPROPERTIES which causes the next
analysis phase to assume the statement was executed with
TBLPROPERTIES ('kudu.master_addresses'). Hence, causing the
ALL privilege request on SERVER to be registered.

This patch also refactors the generated Kudu table name into
a single place that stores all generated Kudu properties that
gets cleared when the statement is reset.

Testing:
- Added a new test
- Ran all front-end tests
- Ran Kudu end-to-end query tests

Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/TableDef.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
4 files changed, 39 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/10030/4
--
To view, visit http://gerrit.cloudera.org:8080/10030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-12 Thread Thomas Tauber-Marshall (Code Review)

Thomas Tauber-Marshall has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/10053 )

Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice
..

IMPALA-6845: TestHdfsQueries causes some tests to be run twice

TestHdfsQueries is a subclass of TestQueries and inherits of all its
'test_*' methods, causing these tests to be run twice any time
test_queries.py is run. This was not intentional (it was subclassed
just to inherit 'add_test_dimensions') and causes test runs to take
longer than necessary.

This patch removes the subclass relationship and copies the logic in
add_test_dimensions() from TestQueries in HdfsTestQueries, with a
convenience function added to minimize code duplication.

Testing:
- Ran test_queries.py under both 'core' and 'exhaustive' and checked
  that the same tests are run, except all now only a single time each.

Change-Id: Ida659aa7b5131a6a7469baa93a41f7581bd0659a
---
M tests/common/test_dimensions.py
M tests/query_test/test_queries.py
2 files changed, 28 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/10053/2
--
To view, visit http://gerrit.cloudera.org:8080/10053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida659aa7b5131a6a7469baa93a41f7581bd0659a
Gerrit-Change-Number: 10053
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall

[Impala-ASF-CR] IMPALA-6845: TestHdfsQueries causes some tests to be run twice

2018-04-12 Thread Thomas Tauber-Marshall (Code Review)

Thomas Tauber-Marshall has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10053


Change subject: IMPALA-6845: TestHdfsQueries causes some tests to be run twice
..

IMPALA-6845: TestHdfsQueries causes some tests to be run twice

TestHdfsQueries is a subclass of TestQueries and inherits of all its 'test_*' 
methods,
causing these tests to be run twice any time test_queries.py is run. This was 
not
intentional (it was subclassed just to inherit 'add_test_dimensions') and 
causes test runs
to take longer than necessary.

This patch removes the subclass relationship and copies the logic in 
add_test_dimensions()
from TestQueries in HdfsTestQueries, with a convenience function added to 
minimize code
duplication.

Testing:
- Ran test_queries.py under both 'core' and 'exhaustive' and checked that the 
same tests
  are run, except all now only a single time each.

Change-Id: Ida659aa7b5131a6a7469baa93a41f7581bd0659a
---
M tests/common/test_dimensions.py
M tests/query_test/test_queries.py
2 files changed, 28 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/10053/1
--
To view, visit http://gerrit.cloudera.org:8080/10053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida659aa7b5131a6a7469baa93a41f7581bd0659a
Gerrit-Change-Number: 10053
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10052 )

Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10052/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/10052/1/docs/shared/impala_common.xml@1405
PS1, Line 1405: are accepted in the format "-MM-dd 
HH:mm:ss.SS",
> We also accept a new format here, right?
The JIRA only mentions CAST. Should I add it here, as well?



--
To view, visit http://gerrit.cloudera.org:8080/10052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82884d5f56c520712c4391b53b799d518d6a54f
Gerrit-Change-Number: 10052
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vincent Tran 
Gerrit-Comment-Date: Thu, 12 Apr 2018 23:10:52 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-12 Thread Tim Armstrong (Code Review)

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10052 )

Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP
..


Patch Set 1:

(1 comment)

Are you also planning on documenting 
https://issues.apache.org/jira/browse/IMPALA-5315, which also extends the 
formats supported? I think that also requires updating the same text - might be 
easier to review all together.

http://gerrit.cloudera.org:8080/#/c/10052/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/10052/1/docs/shared/impala_common.xml@1405
PS1, Line 1405: are accepted in the format "-MM-dd 
HH:mm:ss.SS",
We also accept a new format here, right?



--
To view, visit http://gerrit.cloudera.org:8080/10052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib82884d5f56c520712c4391b53b799d518d6a54f
Gerrit-Change-Number: 10052
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vincent Tran 
Gerrit-Comment-Date: Thu, 12 Apr 2018 23:04:16 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10052


Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP
..

IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

Change-Id: Ib82884d5f56c520712c4391b53b799d518d6a54f
---
M docs/shared/impala_common.xml
M docs/topics/impala_timestamp.xml
2 files changed, 38 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/10052/1
--
To view, visit http://gerrit.cloudera.org:8080/10052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib82884d5f56c520712c4391b53b799d518d6a54f
Gerrit-Change-Number: 10052
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-12 Thread Vuk Ercegovac (Code Review)

Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
..


Patch Set 8:

can you repro this interaction locally?


--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 8
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 12 Apr 2018 22:41:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
..


Patch Set 8:

The change in custom cluster restart function broke another custom cluster test.


--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 8
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 12 Apr 2018 22:35:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Csaba Ringhofer (Code Review)

Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 6: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Thu, 12 Apr 2018 22:17:38 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6483: [DOCS] Document the new EXEC TIME LIMIT S query option

Alex Rodoni has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/10043 )

Change subject: IMPALA-6483: [DOCS] Document the new EXEC_TIME_LIMIT_S query 
option
..

IMPALA-6483: [DOCS] Document the new EXEC_TIME_LIMIT_S query option

Change-Id: I7a83aa42e6fffc7cb71112936129a0f1917ec2fd
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
A docs/topics/impala_exec_time_limit_s.xml
4 files changed, 103 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/10043/2
--
To view, visit http://gerrit.cloudera.org:8080/10043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a83aa42e6fffc7cb71112936129a0f1917ec2fd
Gerrit-Change-Number: 10043
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni

[Impala-ASF-CR] IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9949 )

Change subject: IMPALA-6822: Add a query option to control shuffling by 
distinct exprs
..

IMPALA-6822: Add a query option to control shuffling by distinct exprs

IMPALA-4794 changed the distinct aggregation behavior to shuffling by
both grouping exprs and the distinct expr. It's slower in queries
where the NDVs of grouping exprs are high and data are uniformly
distributed among groups. This patch adds a query option controlling
this behavior, letting users switch to the old plan.

Change-Id: Icb4b4576fb29edd62cf4b4ba0719c0e0a2a5a8dc
Reviewed-on: http://gerrit.cloudera.org:8080/9949
Reviewed-by: Tianyi Wang 
Tested-by: Impala Public Jenkins 
---
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
A 
testdata/workloads/functional-planner/queries/PlannerTest/shuffle-by-distinct-exprs.test
M testdata/workloads/functional-query/queries/QueryTest/distinct.test
M tests/query_test/test_aggregation.py
9 files changed, 454 insertions(+), 24 deletions(-)

Approvals:
  Tianyi Wang: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb4b4576fb29edd62cf4b4ba0719c0e0a2a5a8dc
Gerrit-Change-Number: 9949
Gerrit-PatchSet: 8
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Vuk Ercegovac

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#6).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/impala.ditamap
M docs/topics/impala_hints.xml
2 files changed, 110 insertions(+), 108 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/6
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall

[Impala-ASF-CR] IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9949 )

Change subject: IMPALA-6822: Add a query option to control shuffling by 
distinct exprs
..


Patch Set 7: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4b4576fb29edd62cf4b4ba0719c0e0a2a5a8dc
Gerrit-Change-Number: 9949
Gerrit-PatchSet: 7
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 12 Apr 2018 22:01:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#5).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/impala.ditamap
M docs/topics/impala_hints.xml
2 files changed, 114 insertions(+), 108 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/5
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
..


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2297/


--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 8
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 12 Apr 2018 21:56:07 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6917: Limit impalad mem-limit to 12GB.

2018-04-12 Thread Vuk Ercegovac (Code Review)

Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10051 )

Change subject: IMPALA-6917: Limit impalad mem-limit to 12GB.
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8024414c5c23bb42cce912d8f34cd0b787e0e39a
Gerrit-Change-Number: 10051
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 12 Apr 2018 21:47:47 +
Gerrit-HasComments: No

[Impala-ASF-CR] Bump Kudu version to a954418

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9982 )

Change subject: Bump Kudu version to a954418
..

Bump Kudu version to a954418

Change-Id: Ib06c0fb3c24a8cee1dd4f34a221cf41a711a5359
Reviewed-on: http://gerrit.cloudera.org:8080/9982
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins 
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib06c0fb3c24a8cee1dd4f34a221cf41a711a5359
Gerrit-Change-Number: 9982
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] Bump Kudu version to a954418

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9982 )

Change subject: Bump Kudu version to a954418
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib06c0fb3c24a8cee1dd4f34a221cf41a711a5359
Gerrit-Change-Number: 9982
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 21:22:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Csaba Ringhofer (Code Review)

Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 4:

Alex, it looks like if the new change was applied to patch set 2, not patch set 
3, so the changes in patch set 3 are missing.


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Thu, 12 Apr 2018 21:14:15 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9964 )

Change subject: IMPALA-5814: Remove startup flag to disable admission control
..

IMPALA-5814: Remove startup flag to disable admission control

Remove "--disable admission control" startup flag and its related
functionality and usage.

Cherry-picks: not for 2.x

Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Reviewed-on: http://gerrit.cloudera.org:8080/9964
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins 
---
M be/src/common/global-flags.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/exec-env.cc
M be/src/service/client-request-state.cc
M bin/generate_minidump_collection_testdata.py
M tests/custom_cluster/test_admission_controller.py
6 files changed, 13 insertions(+), 20 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9964 )

Change subject: IMPALA-5814: Remove startup flag to disable admission control
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 12 Apr 2018 21:05:21 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10042 )

Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays
..

IMPALA-6811: Increase timeout on S3 for test_exchange_delays

The exchange-delays-zero-rows portion of test_exchange_delays
tests a RPC timeout when sending an EOS with no rows. In
order to send the EOS, the executor must have completed
the scan (which returns zero rows). On S3, the scan has
been slow and can exceed the current receiver delay of
10 seconds, leading to a failure to timeout. In manual
testing, the sender timeout is being applied quickly
once the scan finishes.

This increases the receiver delay for S3 and ADLS to
20 seconds. None of the existing symptoms show the
scan taking that long. Most failures have a scan that
barely exceeds 10 seconds, the current receiver delay.
This has only been seen on S3, but ADLS is included as a
precaution.

Change-Id: I967e6eb336c801219c77d657655c42984910b479
Reviewed-on: http://gerrit.cloudera.org:8080/9995
Reviewed-by: Joe McDonnell 
Tested-by: Impala Public Jenkins 
(cherry picked from commit 5bdce5a86ae81081809c7d61f02319b32f18a29d)
Reviewed-on: http://gerrit.cloudera.org:8080/10042
---
M tests/custom_cluster/test_exchange_delays.py
1 file changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I967e6eb336c801219c77d657655c42984910b479
Gerrit-Change-Number: 10042
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell

[Impala-ASF-CR](2.x) IMPALA-6811: Increase timeout on S3 for test exchange delays

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10042 )

Change subject: IMPALA-6811: Increase timeout on S3 for test_exchange_delays
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I967e6eb336c801219c77d657655c42984910b479
Gerrit-Change-Number: 10042
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Thu, 12 Apr 2018 21:01:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9966 )

Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS 
based table
..


Patch Set 1:

> Patch Set 1:
>
> I haven't added a custom cluster test for this since hedged reads are not 
> deterministic, and we'd be dealing with a bunch of flakiness.

I'm uncomfortable that we've got a flag with no testing of the code path behind 
it.

Can you force a hedged read by "kill -STOP"'ing a datanode before the query and 
"kill -CONT" afterwards?


--
To view, visit http://gerrit.cloudera.org:8080/9966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48fe80dfd9a1ed68a8f2b7038e5f42b5a3df3baa
Gerrit-Change-Number: 9966
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:57:45 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2303/


--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:51:06 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 7: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:50:27 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 7: Code-Review+1

(1 comment)

carry +1

http://gerrit.cloudera.org:8080/#/c/9994/6/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/9994/6/bin/bootstrap_system.sh@206
PS6, Line 206: : ${IMPALA_LZO_HOME:="${IMPALA_HOME}/../Impala-lzo"}
> nit:
Done



--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:47:08 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

Fredy Wijaya has uploaded a new patch set (#7). ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..

IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory

Testing:
- Ran bootstrap_development.sh with IMPALA_HOME set to non ~/Impala
  directory
- Ran bootstrap_development.sh with IMPALA_HOME not set

Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
---
M bin/bootstrap_system.sh
1 file changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/9994/7
--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

Tianyi Wang has uploaded a new patch set (#11). ( 
http://gerrit.cloudera.org:8080/9300 )

Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3
..

IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

Dependency changes:
- BE and python use thrift 0.9.3-p3 from native-toolchain.
- FE uses thrift 0.9.3 from apache maven repo.
- Fb303 and http components dependencies are no longer needed in FE and
  are removed.
- The minimum openssl version requirement is increased to 1.0.1.

Configuration change:
- Thrift codegen option movable_type is enabled. New code no longer
  needs to use std::swap to avoid copying.

Change-Id: I639227721502eaa10398d9490ff6ac63aa71b3a6
---
M CMakeLists.txt
M be/src/common/init.cc
M be/src/rpc/TAcceptQueueServer.cpp
M be/src/rpc/TAcceptQueueServer.h
M be/src/rpc/thrift-server-test.cc
M be/src/rpc/thrift-server.cc
M be/src/rpc/thrift-server.h
M be/src/rpc/thrift-thread.h
M be/src/rpc/thrift-util.cc
M bin/impala-config.sh
M buildall.sh
M common/thrift/CMakeLists.txt
M fe/pom.xml
M infra/python/deps/compiled-requirements.txt
14 files changed, 77 insertions(+), 174 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/9300/11
--
To view, visit http://gerrit.cloudera.org:8080/9300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I639227721502eaa10398d9490ff6ac63aa71b3a6
Gerrit-Change-Number: 9300
Gerrit-PatchSet: 11
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: anujphadke

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

Tianyi Wang has uploaded a new patch set (#14). ( 
http://gerrit.cloudera.org:8080/9168 )

Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types
..

IMPALA-5690: Part 1: Rename ostream operators for thrift types

Thrift 0.9.3 implements "ostream& operator<<(ostream&, T)" for thrift
data types while impala did the same to enums and special types
including TNetworkAddress and TUniqueId. To prepare for the upgrade of
thrift 0.9.3, this patch renames these impala defined functions. In the
absence of operator<<, assertion macros like DCHECK_EQ can no longer be
used on non-enum thrift defined types.

Change-Id: I9c303997411237e988ef960157f781776f6fcb60
---
M be/src/benchmarks/scheduler-benchmark.cc
M be/src/codegen/llvm-codegen.cc
M be/src/exec/exchange-node.cc
M be/src/exec/exec-node.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/parquet-column-readers.cc
M be/src/exec/parquet-metadata-utils.cc
M be/src/rpc/rpc-trace.cc
M be/src/rpc/thrift-client.cc
M be/src/rpc/thrift-util.cc
M be/src/rpc/thrift-util.h
M be/src/runtime/client-cache.cc
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/data-stream-mgr.cc
M be/src/runtime/data-stream-recvr.cc
M be/src/runtime/data-stream-sender.cc
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-recvr.cc
M be/src/runtime/krpc-data-stream-sender.cc
M be/src/runtime/mem-tracker.cc
M be/src/runtime/query-exec-mgr.cc
M be/src/runtime/query-state.cc
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-state.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/scheduler.cc
M be/src/service/child-query.cc
M be/src/service/client-request-state.cc
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-internal-service.cc
M be/src/service/impala-server.cc
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
M be/src/service/query-result-set.cc
M be/src/statestore/statestore.cc
M be/src/util/collection-metrics.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M be/src/util/histogram-metric.h
M be/src/util/metrics.h
M be/src/util/network-util.cc
M be/src/util/network-util.h
M be/src/util/webserver.cc
M testdata/workloads/functional-query/queries/QueryTest/set.test
M tests/shell/test_shell_commandline.py
50 files changed, 278 insertions(+), 290 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/9168/14
--
To view, visit http://gerrit.cloudera.org:8080/9168
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c303997411237e988ef960157f781776f6fcb60
Gerrit-Change-Number: 9168
Gerrit-PatchSet: 14
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tianyi Wang

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9993/3/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:

http://gerrit.cloudera.org:8080/#/c/9993/3/docs/topics/impala_hints.xml@317
PS3, Line 317: at a time
> Adding "per node" would make the intention clearer. No other complaints on
Done



--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:41:29 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#4).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/impala.ditamap
M docs/topics/impala_hints.xml
2 files changed, 100 insertions(+), 109 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/4
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9928 )

Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9de641ecf767a2feef3b9f48b344ef2d55e17a7f
Gerrit-Change-Number: 9928
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:34:45 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-2717: fix output of formatted unicode to non-TTY

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9928 )

Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY
..

IMPALA-2717: fix output of formatted unicode to non-TTY

The bug is that PrettyOutputFormatter.format() returned a unicode
object, and Python cannot automatically write unicode objects to
output streams where there is no default encoding.

The fix is to convert to UTF-8 encoded in a regular string, which
can be output to any output device. This makes the output type
consistent with DelimitedOutputFormatter.format().

Based on code by Marcell Szabo.

Testing:
Added a basic test.

Played around in an interactive shell to make sure that unicode
characters still work in interactive mode.

Change-Id: I9de641ecf767a2feef3b9f48b344ef2d55e17a7f
Reviewed-on: http://gerrit.cloudera.org:8080/9928
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins 
---
M shell/impala_shell.py
M shell/shell_output.py
M tests/shell/test_shell_commandline.py
3 files changed, 31 insertions(+), 6 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9928
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9de641ecf767a2feef3b9f48b344ef2d55e17a7f
Gerrit-Change-Number: 9928
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Csaba Ringhofer (Code Review)

Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9993/3/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:

http://gerrit.cloudera.org:8080/#/c/9993/3/docs/topics/impala_hints.xml@317
PS3, Line 317: at a time
Adding "per node" would make the intention clearer. No other complaints on my 
side.



--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:22:19 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9972 )

Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER
..


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2301/


--
To view, visit http://gerrit.cloudera.org:8080/9972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6510b4d54c9902029a357f1aebb2570cd75855d
Gerrit-Change-Number: 9972
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Holley 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:22:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9972 )

Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER
..


Patch Set 6: Code-Review+2

Needed a rebase. Retrying.


--
To view, visit http://gerrit.cloudera.org:8080/9972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6510b4d54c9902029a357f1aebb2570cd75855d
Gerrit-Change-Number: 9972
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Holley 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:21:18 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:19:37 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..

IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Cherry-picks: not for 2.x.

Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Reviewed-on: http://gerrit.cloudera.org:8080/9996
Reviewed-by: Alex Behm 
Tested-by: Impala Public Jenkins 
---
M docs/topics/impala_describe.xml
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-6804: Allow SELECT and INSERT privileges on SERVER

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9972 )

Change subject: IMPALA-6804: Allow SELECT and INSERT privileges on SERVER
..


Patch Set 5: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2291/


--
To view, visit http://gerrit.cloudera.org:8080/9972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6510b4d54c9902029a357f1aebb2570cd75855d
Gerrit-Change-Number: 9972
Gerrit-PatchSet: 5
Gerrit-Owner: Adam Holley 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:18:53 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6917: Limit impalad mem-limit to 12GB.

Philip Zeyliger has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10051


Change subject: IMPALA-6917: Limit impalad mem-limit to 12GB.
..

IMPALA-6917: Limit impalad mem-limit to 12GB.

This changes the memlimit choosing code in start-impala-cluster to have
a maximum of 12GB. In 68GB machines, this has the effect of reducing the
memlimit from ~15.8GB to 12GB. On machines with less than 51.4 GB of
RAM, this has no effect.

I'm tinkering with this threshold because ASAN builds sometimes
die at the hands of the OOM killer on m2.4xlarge machines (68GB).
My theory for why it's only sometimes is that during the parallel
tests, our memory usage could vary widely depending on which tests
and queries execute.

End-users don't see this code; this is only used by our minicluster
tests to test Impala.

I have run the ASAN build with this change successfully, though I've
found this particular OOM seems to come and go.

Change-Id: I8024414c5c23bb42cce912d8f34cd0b787e0e39a
---
M bin/start-impala-cluster.py
1 file changed, 8 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/10051/1
--
To view, visit http://gerrit.cloudera.org:8080/10051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8024414c5c23bb42cce912d8f34cd0b787e0e39a
Gerrit-Change-Number: 10051
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9960 )

Change subject: IMPALA-6120: Add thread timers for reporting codegen time
..


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2300/


--
To view, visit http://gerrit.cloudera.org:8080/9960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24d5a46b8870bc959b89045432d2e86af72b30e5
Gerrit-Change-Number: 9960
Gerrit-PatchSet: 6
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:08:29 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6120: Add thread timers for reporting codegen time

2018-04-12 Thread Bikramjeet Vig (Code Review)

Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9960 )

Change subject: IMPALA-6120: Add thread timers for reporting codegen time
..


Patch Set 6: Code-Review+2

Carrying over +2


--
To view, visit http://gerrit.cloudera.org:8080/9960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24d5a46b8870bc959b89045432d2e86af72b30e5
Gerrit-Change-Number: 9960
Gerrit-PatchSet: 6
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:08:01 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10048 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2299/


--
To view, visit http://gerrit.cloudera.org:8080/10048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 10048
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:05:39 +
Gerrit-HasComments: No

[Impala-ASF-CR] Fix test query concurrency exception handling.

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10049 )

Change subject: Fix test_query_concurrency exception handling.
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If507409b8945b16a9510bb6195343eed7d8538fc
Gerrit-Change-Number: 10049
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:05:38 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd

2018-04-12 Thread Dimitris Tsirogiannis (Code Review)

Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10048 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 10048
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:04:43 +
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd

Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10048

to look at the new patch set (#2).

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..

IMPALA-6820: Remove _impala_builtins from catalogd

The _impala_builtins database is initialized in the constructor of
Catalog and hence is inherited by both the CatalogServiceCatalog and
ImpaladCatalog. Since  _impala_builtins is not used by the catalog
server and to avoid the overhead of managing this database during normal
metadata operations (e.g. invalidate), it is moved to the ImpaladCatalog
class.

Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Reviewed-on: http://gerrit.cloudera.org:8080/9947
Reviewed-by: Tianyi Wang 
Tested-by: Impala Public Jenkins 
(cherry picked from commit 17137d783c24d0ec0827db62bb256ec4c2c05164)
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/ExtractFromExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionName.java
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
11 files changed, 35 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/10048/2
--
To view, visit http://gerrit.cloudera.org:8080/10048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 10048
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/234/


--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:01:26 +
Gerrit-HasComments: No

[Impala-ASF-CR] Fix test query concurrency exception handling.

Philip Zeyliger has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10049


Change subject: Fix test_query_concurrency exception handling.
..

Fix test_query_concurrency exception handling.

Fixes use of an undefined variable.

I saw the following message in a build failure, which
clearly wasn't intended:

  MainThread: Debug webpage not yet available.
  Exception in thread Thread-862:
  Traceback (most recent call last):
File "/usr/lib64/python2.7/threading.py", line 811, in __bootstrap_inner
  self.run()
File "/usr/lib64/python2.7/threading.py", line 764, in run
  self.__target(*self.__args, **self.__kwargs)
File 
"/data/jenkins/workspace/impala-asf-2.x-exhaustive-rhel7/repos/Impala/tests/custom_cluster/test_query_concurrency.py",
 line 58, in poll_query_page
  except e:
  NameError: global name 'e' is not defined

Change-Id: If507409b8945b16a9510bb6195343eed7d8538fc
---
M tests/custom_cluster/test_query_concurrency.py
1 file changed, 1 insertion(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/10049/1
--
To view, visit http://gerrit.cloudera.org:8080/10049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If507409b8945b16a9510bb6195343eed7d8538fc
Gerrit-Change-Number: 10049
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Philip Zeyliger

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:00:49 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 3:

> (1 comment)

Added.


--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:00:28 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Hello Alex Behm, Impala Public Jenkins, Adam Holley,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9996

to look at the new patch set (#5).

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..

IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Cherry-picks: not for 2.x.

Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
---
M docs/topics/impala_describe.xml
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/9996/5
--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-5392. Add full stack trace to jvm-threadz

2018-04-12 Thread Charles Agnello (Code Review)

Charles Agnello has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10032 )

Change subject: IMPALA-5392. Add full stack trace to jvm-threadz
..


Patch Set 1:

> (1 comment)

I don't see a way to attach files in Gerrit so I added the screenshot to the 
Jira issue.

Using ThreadMXBean.getThreadInfo doesn't work either since you are still 
calling ThreadInfo.toString on what comes back from ThreadMXBean.getThreadInfo. 
I tried what you suggested ( 
tThreadInfo.setSummary(threadBean.getThreadInfo(id, 
Integer.MAX_VALUE).toString()); ) and the result is the same as what is 
currently shipping which is what I expected but I wanted to confirm.


-- 
To view, visit http://gerrit.cloudera.org:8080/10032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibee595358ebc2e1b48cb73356faff7a708aa6a80
Gerrit-Change-Number: 10032
Gerrit-PatchSet: 1
Gerrit-Owner: Charles Agnello 
Gerrit-Reviewer: Charles Agnello 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Jim Apple 
Gerrit-Comment-Date: Thu, 12 Apr 2018 19:59:44 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

Alex Behm has posted comments on this change. (
http://gerrit.cloudera.org:8080/10030 )

Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables
..

Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10030/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/10030/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@68
PS2, Line 68: private boolean kuduMasterHostsPropAdded_;
This flag is extremely specific and I think it adds to the reset/re-analyze
confusion.

Assuming I understand the predicament correctly, I think the real issue is that
we do not distinguish between table properties added by the user in the SQL and
table properties generated as part of analysis.

I think we should separate those properties. When we reset() we can wipe those
table properties that were generated during analysis.

In toThrift() we combine the user-specified properties and the generated
properties.

Notice that https://gerrit.cloudera.org/#/c/8820/ has a similar issue with the
generated Kudu table name. Ideally, we would clean that up too to follow my
proposed cleaner fix. I think if we had followed my suggestion above in 8820,
then the bug in this JIRA would not exist.

--
To view, visit http://gerrit.cloudera.org:8080/10030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya
Gerrit-Reviewer: Adam Holley
Gerrit-Reviewer: Alex Behm
Gerrit-Reviewer: Fredy Wijaya
Gerrit-Comment-Date: Thu, 12 Apr 2018 19:58:46 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6809: Allow bootstrap system.sh in non ~/Impala directory

Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9994 )

Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory
..


Patch Set 6:

(1 comment)

One more quick thing.

http://gerrit.cloudera.org:8080/#/c/9994/6/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/9994/6/bin/bootstrap_system.sh@206
PS6, Line 206: IMPALA_LZO_HOME="$IMPALA_HOME"/../Impala-lzo
nit:

I think this should be

: ${IMPALA_LZO_HOME:="${IMPALA_HOME}/../Impala-lzo"}



--
To view, visit http://gerrit.cloudera.org:8080/9994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a
Gerrit-Change-Number: 9994
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Attila Jeges 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Thu, 12 Apr 2018 19:58:19 +
Gerrit-HasComments: Yes

[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd

Hello Impala Public Jenkins,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10048

to review the following change.


Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..

IMPALA-6820: Remove _impala_builtins from catalogd

The _impala_builtins database is initialized in the constructor of
Catalog and hence is inherited by both the CatalogServiceCatalog and
ImpaladCatalog. Since  _impala_builtins is not used by the catalog
server and to avoid the overhead of managing this database during normal
metadata operations (e.g. invalidate), it is moved to the ImpaladCatalog
class.

Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Reviewed-on: http://gerrit.cloudera.org:8080/9947
Reviewed-by: Tianyi Wang 
Tested-by: Impala Public Jenkins 
(cherry picked from commit 17137d783c24d0ec0827db62bb256ec4c2c05164)
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/ExtractFromExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionName.java
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
11 files changed, 34 insertions(+), 31 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/10048/1
--
To view, visit http://gerrit.cloudera.org:8080/10048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 10048
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9996/4/docs/topics/impala_describe.xml
File docs/topics/impala_describe.xml:

http://gerrit.cloudera.org:8080/#/c/9996/4/docs/topics/impala_describe.xml@146
PS4, Line 146:   the LOCATION field. The 
LOCATION data
Did you make the changes suggested in my last comment? This last part about 
LOCATION is not accurate.



--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 19:48:06 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5392. Add full stack trace to jvm-threadz

2018-04-12 Thread Jim Apple (Code Review)

Jim Apple has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10032 )

Change subject: IMPALA-5392. Add full stack trace to jvm-threadz
..


Patch Set 1:

Hi Charles,

I noticed you replied on reviews@. On Impala, review always happens using 
gerrit. You can comment directly to Dimitris using the gerrit web interface.


--
To view, visit http://gerrit.cloudera.org:8080/10032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibee595358ebc2e1b48cb73356faff7a708aa6a80
Gerrit-Change-Number: 10032
Gerrit-PatchSet: 1
Gerrit-Owner: Charles Agnello 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Jim Apple 
Gerrit-Comment-Date: Thu, 12 Apr 2018 19:45:29 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Hello Alex Behm, Impala Public Jenkins, Adam Holley,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9996

to look at the new patch set (#4).

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..

IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Cherry-picks: not for 2.x.

Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
---
M docs/topics/impala_describe.xml
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/9996/4
--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9996 )

Change subject: IMPALA-6480: [DOCS] DESCRIBE respects column-level privilege
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9996/3/docs/topics/impala_describe.xml
File docs/topics/impala_describe.xml:

http://gerrit.cloudera.org:8080/#/c/9996/3/docs/topics/impala_describe.xml@146
PS3, Line 146:   the LOCATION field. The 
LOCATION data
> The LOCATION data is shown if you have any privilege on the table, the cont
Done



--
To view, visit http://gerrit.cloudera.org:8080/9996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I094e00c2a4e8b19226e06afd8cf67968265edc4d
Gerrit-Change-Number: 9996
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 19:30:34 +
Gerrit-HasComments: Yes

Re: [Impala-ASF-CR] IMPALA-5392. Add full stack trace to jvm-threadz

2018-04-12 Thread Charles

I attached a screenshot here with what the jvm-threadz page looks like with
my change. If it doesn't show up in Gerrit I'll add it to the JIRA.

Using ThreadMXBean.getThreadInfo doesn't work either since you are still
calling ThreadInfo.toString on what comes back from
ThreadMXBean.getThreadInfo. I tried what you suggested (
tThreadInfo.setSummary(threadBean.getThreadInfo(id,
Integer.MAX_VALUE).toString()); ) and the result is the same as what is
currently shipping which is what I expected but I wanted to confirm.

On Thu, Apr 12, 2018 at 11:03 AM, Dimitris Tsirogiannis (Code Review) <
ger...@cloudera.org> wrote:

> Dimitris Tsirogiannis *posted comments* on this change.
>
> View Change 
>
> Patch set 1:
>
> (1 comment)
>
>-
>
>File fe/src/main/java/org/apache/impala/common/JniUtil.java:
>
> 
>-
>
>   Patch Set #1, Line 243:
>   
> 
>  private
>   static String createSummary(ThreadInfo threadInfo) {
>
>   Instead of doing the formatting yourself, did you consider using
>   getThreadInfo() method from ThreadMXBean that can take the max depth as 
> a
>   parameter and then call toString()? You may have to make an extra call 
> to
>   get locks and monitors, but you may want to see if it is simpler that 
> way.
>   Also, can you please post a screenshot of the threadz tab with your 
> changes
>   so that we can see how that thing looks like?
>
> To view, visit change 10032 . To
> unsubscribe, visit settings .
> Gerrit-Project: Impala-ASF
> Gerrit-Branch: master
> Gerrit-MessageType: comment
> Gerrit-Change-Id: Ibee595358ebc2e1b48cb73356faff7a708aa6a80
> Gerrit-Change-Number: 10032
> Gerrit-PatchSet: 1
> Gerrit-Owner: Charles Agnello 
> Gerrit-Reviewer: Dimitris Tsirogiannis 
> Gerrit-Comment-Date: Thu, 12 Apr 2018 18:03:08 +
> Gerrit-HasComments: Yes
>

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-12 Thread Thomas Tauber-Marshall (Code Review)

Hello Gabor Kaszab, Tim Armstrong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10031

to look at the new patch set (#2).

Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort
..

IMPALA-6713: Fix request for unneeded memory in partial sort

When a Sorter::Run is initialized, if it is an initial run and has
varlen data, it requests an extra buffer to have space to sort the
varlen data should it need to spill to disk.

This extra buffer is not needed in the case of partial sorts, which
do not spill, and because this extra buffer was not included in the
calculation of the minimum required reservation, requesting it caused
the partial sort to fail in cases where the partial sort only had its
minimum reservation available to use.

The solution is to not request the extra memory for partial sorts.

Testing:
- Added a test to test_sort.py that ensures the partial sort can
  complete successfully even if additional memory requests beyond its
  minimum reservation are denied.

Change-Id: I2d9c0863009021340d8b684669b371a2cfb1ecad
---
M be/src/runtime/sorter.cc
M tests/query_test/test_sort.py
2 files changed, 19 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/10031/2
--
To view, visit http://gerrit.cloudera.org:8080/10031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d9c0863009021340d8b684669b371a2cfb1ecad
Gerrit-Change-Number: 10031
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-12 Thread Thomas Tauber-Marshall (Code Review)

Thomas Tauber-Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10031 )

Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10031/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10031/1//COMMIT_MSG@9
PS1, Line 9: initialize
> nit: typo
Done


http://gerrit.cloudera.org:8080/#/c/10031/1/be/src/runtime/sorter.cc
File be/src/runtime/sorter.cc:

http://gerrit.cloudera.org:8080/#/c/10031/1/be/src/runtime/sorter.cc@634
PS1, Line 634:   + (has_var_len_slots_ && initial_run_ && 
sorter_->enable_spilling_);
> Should we also test that a regular Sort node with spilling turned off works
I think this case is already covered by various tests is test_spilling.py



--
To view, visit http://gerrit.cloudera.org:8080/10031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d9c0863009021340d8b684669b371a2cfb1ecad
Gerrit-Change-Number: 10031
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 12 Apr 2018 19:34:01 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6483: [DOCS] Document the new EXEC TIME LIMIT S query option

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10043


Change subject: IMPALA-6483: [DOCS] Document the new EXEC_TIME_LIMIT_S query 
option
..

IMPALA-6483: [DOCS] Document the new EXEC_TIME_LIMIT_S query option

Change-Id: I7a83aa42e6fffc7cb71112936129a0f1917ec2fd
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
3 files changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/10043/1
--
To view, visit http://gerrit.cloudera.org:8080/10043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a83aa42e6fffc7cb71112936129a0f1917ec2fd
Gerrit-Change-Number: 10043
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10030 )

Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables
..


Patch Set 2: Code-Review+1

(1 comment)

Carry +1

http://gerrit.cloudera.org:8080/#/c/10030/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/10030/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@256
PS1, Line 256: properties
> nit: typo
Done



--
To view, visit http://gerrit.cloudera.org:8080/10030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Thu, 12 Apr 2018 18:58:57 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

Fredy Wijaya has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/10030 )

Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables
..

IMPALA-6451: AuthorizationException in CTAS for Kudu tables

CREATE TABLE on EXTERNAL Kudu tables or with TBLPROPERTIES
('kudu.master_addresses') require ALL privileges on SERVER.
See IMPALA-4000.

The patch fixes a bug where the CTAS statement is rewritten
and during the initial analysis phase, 'kudu.master_addresses'
property is added into TBLPROPERTIES which causes the next
analysis phase to assume the statement was executed with
TBLPROPERTIES ('kudu.master_addresses'). Hence, causing the
ALL privilege request on SERVER to be registered.

Testing:
- Added a new test
- Ran all front-end tests

Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
2 files changed, 22 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/10030/2
--
To view, visit http://gerrit.cloudera.org:8080/10030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley

[Impala-ASF-CR] IMPALA-6514: [DOCS] impala-shell option for load balancer and Kerberos

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10047


Change subject: IMPALA-6514: [DOCS] impala-shell option for load balancer and 
Kerberos
..

IMPALA-6514: [DOCS] impala-shell option for load balancer and Kerberos

Change-Id: I50d2063bfbe4838692777e2019ee3f3a991dfc21
---
M docs/topics/impala_proxy.xml
M docs/topics/impala_shell_options.xml
2 files changed, 61 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/10047/1
--
To view, visit http://gerrit.cloudera.org:8080/10047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50d2063bfbe4838692777e2019ee3f3a991dfc21
Gerrit-Change-Number: 10047
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni

[Impala-ASF-CR] IMPALA-6451: AuthorizationException in CTAS for Kudu tables

2018-04-12 Thread Adam Holley (Code Review)

Adam Holley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10030 )

Change subject: IMPALA-6451: AuthorizationException in CTAS for Kudu tables
..


Patch Set 1: Code-Review+1

(1 comment)

Good after one nit.

http://gerrit.cloudera.org:8080/#/c/10030/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/10030/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@256
PS1, Line 256: prpoerties
nit: typo



--
To view, visit http://gerrit.cloudera.org:8080/10030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3bbe4dceb80dfefd9756bc322f8c10ceab9f49
Gerrit-Change-Number: 10030
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Comment-Date: Thu, 12 Apr 2018 18:46:30 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6842: [DOCS] Remove disable admission control startup flag

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10046 )

Change subject: IMPALA-6842: [DOCS] Remove disable_admission_control startup 
flag
..

IMPALA-6842: [DOCS] Remove disable_admission_control startup flag

Change-Id: Idbd15823308dbce5d2d00e79607e5ebbdab3e38f
Reviewed-on: http://gerrit.cloudera.org:8080/10046
Reviewed-by: Alex Rodoni 
Tested-by: Impala Public Jenkins 
---
M docs/topics/impala_admission.xml
1 file changed, 0 insertions(+), 16 deletions(-)

Approvals:
  Alex Rodoni: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbd15823308dbce5d2d00e79607e5ebbdab3e38f
Gerrit-Change-Number: 10046
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-6842: [DOCS] Remove disable admission control startup flag

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10046 )

Change subject: IMPALA-6842: [DOCS] Remove disable_admission_control startup 
flag
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbd15823308dbce5d2d00e79607e5ebbdab3e38f
Gerrit-Change-Number: 10046
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 18:51:05 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6842: [DOCS] Remove disable admission control startup flag

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10046 )

Change subject: IMPALA-6842: [DOCS] Remove disable_admission_control startup 
flag
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/233/


--
To view, visit http://gerrit.cloudera.org:8080/10046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbd15823308dbce5d2d00e79607e5ebbdab3e38f
Gerrit-Change-Number: 10046
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Apr 2018 18:41:49 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6842: [DOCS] Remove disable admission control startup flag

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10046 )

Change subject: IMPALA-6842: [DOCS] Remove disable_admission_control startup 
flag
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbd15823308dbce5d2d00e79607e5ebbdab3e38f
Gerrit-Change-Number: 10046
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Comment-Date: Thu, 12 Apr 2018 18:39:16 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6842: [DOCS] Remove disable admission control startup flag

2018-04-12 Thread Bikramjeet Vig (Code Review)

Bikramjeet Vig has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10046


Change subject: IMPALA-6842: [DOCS] Remove disable_admission_control startup 
flag
..

IMPALA-6842: [DOCS] Remove disable_admission_control startup flag

Change-Id: Idbd15823308dbce5d2d00e79607e5ebbdab3e38f
---
M docs/topics/impala_admission.xml
1 file changed, 0 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/10046/1
--
To view, visit http://gerrit.cloudera.org:8080/10046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbd15823308dbce5d2d00e79607e5ebbdab3e38f
Gerrit-Change-Number: 10046
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig

[Impala-ASF-CR] IMPALA-6713: Fix request for unneeded memory in partial sort

2018-04-12 Thread Gabor Kaszab (Code Review)

Gabor Kaszab has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10031 )

Change subject: IMPALA-6713: Fix request for unneeded memory in partial sort
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10031/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10031/1//COMMIT_MSG@9
PS1, Line 9: initialzed
nit: typo


http://gerrit.cloudera.org:8080/#/c/10031/1/be/src/runtime/sorter.cc
File be/src/runtime/sorter.cc:

http://gerrit.cloudera.org:8080/#/c/10031/1/be/src/runtime/sorter.cc@634
PS1, Line 634:   + (has_var_len_slots_ && initial_run_ && 
sorter_->enable_spilling_);
Should we also test that a regular Sort node with spilling turned off works 
well with the lowest memory allocation that was needed before this change? 
(e.g. picking any sorting query checking what the lowest memory limit it worked 
with spilling turned off, check that it still works with that limit)
There might be an existing test for this, though.



--
To view, visit http://gerrit.cloudera.org:8080/10031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d9c0863009021340d8b684669b371a2cfb1ecad
Gerrit-Change-Number: 10031
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 12 Apr 2018 18:25:13 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-12 Thread Impala Public Jenkins (Code Review)

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9949 )

Change subject: IMPALA-6822: Add a query option to control shuffling by 
distinct exprs
..


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2298/


--
To view, visit http://gerrit.cloudera.org:8080/9949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4b4576fb29edd62cf4b4ba0719c0e0a2a5a8dc
Gerrit-Change-Number: 9949
Gerrit-PatchSet: 7
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 12 Apr 2018 18:15:07 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4025: Part 1: Add percentile disc aggregation function

2018-04-12 Thread Dimitris Tsirogiannis (Code Review)

Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9777 )

Change subject: IMPALA-4025: Part 1: Add percentile_disc aggregation function
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9777/3/fe/src/main/java/org/apache/impala/analysis/SlotRef.java
File fe/src/main/java/org/apache/impala/analysis/SlotRef.java:

http://gerrit.cloudera.org:8080/#/c/9777/3/fe/src/main/java/org/apache/impala/analysis/SlotRef.java@149
PS3, Line 149: void setRawPath(List rawPath) {
> It's not needed. But the existing expr substitution utilities have several
Modifying the SlotRef in place sort of violates the way we generally handle 
cases like this (e.g. when an expr needs to be replaced by another expr). I am 
in favor of refactoring the substitution logic to make it more generic and 
flexible but I'll let Alex chime on it since I haven't thought of all the 
details.



--
To view, visit http://gerrit.cloudera.org:8080/9777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacef7b3fcd74c4c73d88400ce27307c3baa0121e
Gerrit-Change-Number: 9777
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 12 Apr 2018 18:14:35 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6822: Add a query option to control shuffling by distinct exprs