[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16966 ) Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. IMPALA-10447: Add a newline when exporting shell

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16966 ) Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. IMPALA-10447: Add a newline when exporting shell

[Impala-ASF-CR] IMPALA-10768: Deflake CatalogHmsFileMetadataTest

2021-06-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17634 ) Change subject: IMPALA-10768: Deflake CatalogHmsFileMetadataTest .. Patch Set 2: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-10695: add dedicated thread pool for OSS/JindoFS.

2021-05-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 ) Change subject: IMPALA-10695: add dedicated thread pool for OSS/JindoFS. .. Patch Set 5: (5 comments) Thanks for the changes, I

[Impala-ASF-CR] IMPALA-10695: add dedicated thread pool for OSS/JindoFS.

2021-05-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 ) Change subject: IMPALA-10695: add dedicated thread pool for OSS/JindoFS. .. Patch Set 6: Code-Review+2 Thanks for working through

[Impala-ASF-CR] add OSS/JindoFS support, impala with this change will create a dedicate thread pool for this kind of target. By default 16 threads would be craeted

2021-05-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 ) Change subject: add OSS/JindoFS support, impala with this change will create a dedicate thread pool for this kind of target. By default 16 threads would be craeted

[Impala-ASF-CR] IMPALA-10695:add OSS/JindoFS support, create a dedicate thread pool for this kind of target, default is 16.

2021-05-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 ) Change subject: IMPALA-10695:add OSS/JindoFS support, create a dedicate thread pool for this kind of target, default is 16. ..

[Impala-ASF-CR] IMPALA-9155: Add recovery mechanism to admission service

2021-05-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17332 ) Change subject: IMPALA-9155: Add recovery mechanism to admission service .. Patch Set 1: (10 comments) Some more comments

[Impala-ASF-CR] IMPALA-10720: Add versioning to admission heartbeats

2021-05-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17524 ) Change subject: IMPALA-10720: Add versioning to admission heartbeats .. Patch Set 1: (4 comments) A few nits

[Impala-ASF-CR] IMPALA-8769: [DOCS] Change the shell default

2021-05-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17349 ) Change subject: IMPALA-8769: [DOCS] Change the shell default .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9155: Add recovery mechanism to admission service

2021-05-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17332 ) Change subject: IMPALA-9155: Add recovery mechanism to admission service .. Patch Set 1: (3 comments) I read through the code once,

[Impala-ASF-CR] IMPALA-10605: Deflake test refresh native

2021-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17227 ) Change subject: IMPALA-10605: Deflake test_refresh_native .. Patch Set 1: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter

2021-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 ) Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter .. Patch Set 4: Code-Review+2 LGTM, thanks for the fixes

[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option

2021-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 3: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] Only fetch needed branches in compare branches.py

2021-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 ) Change subject: Only fetch needed branches in compare_branches.py .. Patch Set 1: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations

2021-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17177 ) Change subject: IMPALA-10582: Fix wrong summary numbers in the webpage of catalogd operations .. Patch Set 1: Code-Review+2 LGTM

[Impala-ASF-CR] IMPALA-10538: [DOCS] Document the newly added NDV parameter

2021-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17131 ) Change subject: IMPALA-10538: [DOCS] Document the newly added NDV parameter .. Patch Set 3: (5 comments) Thanks for doing this, I

[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option

2021-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 2: (4 comments) Thanks, this is looking

[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option

2021-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 ) Change subject: IMPALA-9910: [DOCS] update retry failed queries query option .. Patch Set 1: (4 comments) I have a few suggestions

[Impala-ASF-CR] IMPALA-9331: Add symptom for dataload failing on schema mismatch

2021-03-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17242 ) Change subject: IMPALA-9331: Add symptom for dataload failing on schema mismatch .. Patch Set 2: Code-Review+2 LGTM, plus also

[Impala-ASF-CR] IMPALA-10397: Fix test single workload

2021-03-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10397: Fix test single workload

2021-03-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17218 ) Change subject: IMPALA-10397: Fix test_single_workload .. Patch Set 1: (1 comment) LGTM, does this comment need updating?

[Impala-ASF-CR] IMPALA-10367: Impala-shell internal error - UnboundLocalError, local variable 'retry msg' referenced before assign

2021-03-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17172 ) Change subject: IMPALA-10367: Impala-shell internal error - UnboundLocalError, local variable 'retry_msg' referenced before assign ..

[Impala-ASF-CR] IMPALA-10592: prevent pytest from hanging at exit.

2021-03-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17212 Change subject: IMPALA-10592: prevent pytest from hanging at exit. .. IMPALA-10592: prevent pytest from hanging at exit. In

[Impala-ASF-CR] IMPALA-10596: De-flake TestAdmissionControllerStress

2021-04-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17272 ) Change subject: IMPALA-10596: De-flake TestAdmissionControllerStress .. Patch Set 1: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-10397 : Reduce flakiness in test single workload

2021-02-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17028 ) Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload .. Patch Set 1: Code-Review+2 (2 comments) LGTM, a few

[Impala-ASF-CR] IMPALA-10849: Ignore escaped wildcards that terminate like predicates.

2021-08-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17798 Change subject: IMPALA-10849: Ignore escaped wildcards that terminate like predicates. .. IMPALA-10849: Ignore escaped wildcards that

[Impala-ASF-CR] IMPALA-10720: Add versioning to admission heartbeats

2021-08-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17524 ) Change subject: IMPALA-10720: Add versioning to admission heartbeats .. Patch Set 2: Code-Review+2 (2 comments) LGTM (with 2

[Impala-ASF-CR] IMPALA-10846: Skip Authentication for connection with trusted auth header

2021-08-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17759 ) Change subject: IMPALA-10846: Skip Authentication for connection with trusted auth header .. Patch Set 1: (8 comments) This looks

[Impala-ASF-CR] IMPALA-10846: Skip Authentication for connection with trusted auth header

2021-08-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17759 ) Change subject: IMPALA-10846: Skip Authentication for connection with trusted auth header .. Patch Set 3: (1 comment) I talked to

[Impala-ASF-CR] IMPALA-10846: Skip Authentication for connection with trusted auth header

2021-08-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17759 ) Change subject: IMPALA-10846: Skip Authentication for connection with trusted auth header .. Patch Set 4: Code-Review+2 LGTM --

[Impala-ASF-CR] IMPALA-8795: (Addendum) Fix test hms integration flakiness

2021-08-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17767 ) Change subject: IMPALA-8795: (Addendum) Fix test_hms_integration flakiness .. Patch Set 3: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 ) Change subject: IMPALA-10942: Fix memory leak in admission controller .. Patch Set 2: Code-Review+2 OK I see the note in the Jira

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 ) Change subject: IMPALA-10942: Fix memory leak in admission controller .. Patch Set 2: (2 comments) QQ to see if I understand what

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 ) Change subject: IMPALA-11033: Add support for specifying multiple executor group sets .. Patch Set 5: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 ) Change subject: IMPALA-11033: Add support for specifying multiple executor group sets .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-11025: Transactional tables should use /test-warehouse/managed/databasename.db

2021-11-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18046 Change subject: IMPALA-11025: Transactional tables should use /test-warehouse/managed/databasename.db .. IMPALA-11025: Transactional

[Impala-ASF-CR] IMPALA-11007: Replies to HTTP HEAD requests should contain no content.

2021-11-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18002 Change subject: IMPALA-11007: Replies to HTTP HEAD requests should contain no content. .. IMPALA-11007: Replies to HTTP HEAD requests

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 1: Code-Review+2

[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true

2021-12-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18062 Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true .. IMPALA-10764: hide /logs link in webui if

[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true

2021-12-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 ) Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true

2021-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 ) Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true .. Patch Set 2: Failure in verification looks like

[Impala-ASF-CR] IMPALA-11033: Add support for specifying multiple executor group sets

2021-12-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 ) Change subject: IMPALA-11033: Add support for specifying multiple executor group sets .. Patch Set 3: (13 comments) Looks good, I

[Impala-ASF-CR] IMPALA-8762: Track host level admission stats across all coordinators

2021-07-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17683 ) Change subject: IMPALA-8762: Track host level admission stats across all coordinators .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-8762: Track host level admission stats across all cooridnators

2021-07-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17683 ) Change subject: IMPALA-8762: Track host level admission stats across all cooridnators .. Patch Set 1: (6 comments) I did a quick

[Impala-ASF-CR] IMPALA-11063: Add metrics to expose state of each executor group set

2022-01-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18142 ) Change subject: IMPALA-11063: Add metrics to expose state of each executor group set .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-11120: Fix codec not set in generating ORC tables

2022-02-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18228 ) Change subject: IMPALA-11120: Fix codec not set in generating ORC tables .. Patch Set 2: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-11131: Replace 'cnd cwnd' with 'snd cwnd' in www/rpcz.tmpl

2022-02-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18249 ) Change subject: IMPALA-11131: Replace 'cnd_cwnd' with 'snd_cwnd' in www/rpcz.tmpl .. Patch Set 1: Code-Review+2 LGTM -- To view,

[Impala-ASF-CR] IMPALA-11126: impala-shell: Set reasonable timeout for http client

2022-03-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Set reasonable timeout for http client .. Patch Set 4: Code-Review+2 The change inside

[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client

2022-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client .. Patch Set 6: I like the split of

[Impala-ASF-CR] IMPALA-11203: Fix build by re-adding imports removed in clashing commits

2022-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has abandoned this change. ( http://gerrit.cloudera.org:8080/18357 ) Change subject: IMPALA-11203: Fix build by re-adding imports removed in clashing commits .. Abandoned Duplicates

[Impala-ASF-CR] IMPALA-11203: Fix build by re-adding imports removed in clashing commits

2022-03-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18357 Change subject: IMPALA-11203: Fix build by re-adding imports removed in clashing commits .. IMPALA-11203: Fix build by re-adding

[Impala-ASF-CR] IMPALA-111218: TestIcebergTable.test table load time for many files flaky

2022-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18376 ) Change subject: IMPALA-111218: TestIcebergTable.test_table_load_time_for_many_files flaky .. Patch Set 1: Code-Review+2 LGTM --

[Impala-ASF-CR] IMPALA-11126: impala-shell: Support configurable socket timeout for http client

2022-03-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18336 ) Change subject: IMPALA-11126: impala-shell: Support configurable socket timeout for http client .. Patch Set 7: Code-Review+2 --

[Impala-ASF-CR] IMPALA-11078 Add simple CSP header to webui.

2022-01-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18168 Change subject: IMPALA-11078 Add simple CSP header to webui. .. IMPALA-11078 Add simple CSP header to webui. Content Security Policy

[Impala-ASF-CR] IMPALA-11078 Add simple CSP header to webui.

2022-01-21 Thread Andrew Sherman (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18168 to look at the new patch set (#3). Change subject: IMPALA-11078 Add simple CSP header to webui. ..

[Impala-ASF-CR] IMPALA-11078 Add simple CSP header to webui.

2022-01-21 Thread Andrew Sherman (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18168 to look at the new patch set (#2). Change subject: IMPALA-11078 Add simple CSP header to webui. ..

[Impala-ASF-CR] IMPALA-11078 Add simple CSP header to webui.

2022-01-21 Thread Andrew Sherman (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18168 to look at the new patch set (#4). Change subject: IMPALA-11078 Add simple CSP header to webui. ..

[Impala-ASF-CR] IMPALA-11063: Add metrics to expose state of each executor group set

2022-01-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18142 ) Change subject: IMPALA-11063: Add metrics to expose state of each executor group set .. Patch Set 2: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-11078 Add simple CSP header to webui.

2022-01-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18168 ) Change subject: IMPALA-11078 Add simple CSP header to webui. .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-11078 Add simple CSP header to webui.

2022-01-24 Thread Andrew Sherman (Code Review)
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18168 to look at the new patch set (#5). Change subject: IMPALA-11078 Add simple CSP header to webui.

[Impala-ASF-CR] IMPALA-12411: Fix data race in expr-test teardown

2023-09-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20474 ) Change subject: IMPALA-12411: Fix data race in expr-test teardown .. Patch Set 3: Code-Review+2 LGTM, thanks for finding this --

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 1: (3 comments) I read through and this looks like

[Impala-ASF-CR] IMPALA-12400: Test expected executors used for planning when no executor groups are healthy

2023-08-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20419 ) Change subject: IMPALA-12400: Test expected executors used for planning when no executor groups are healthy .. Patch Set 1:

[Impala-ASF-CR] IMPALA-12318: Add a flag option for http spnego dedicated keytab file.

2023-09-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20269 ) Change subject: IMPALA-12318: Add a flag option for http spnego dedicated keytab file. .. Patch Set 10: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 2: Code-Review+1 LGTM, can give +2, waiting to see if

[Impala-ASF-CR] IMPALA-12477: Make Iceberg planFiles() use multiple threads

2023-09-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20523 ) Change subject: IMPALA-12477: Make Iceberg planFiles() use multiple threads .. Patch Set 3: (2 comments) I read through quickly

[Impala-ASF-CR] IMPALA-12313: (part 1) Refactor modify statements

2023-09-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 ) Change subject: IMPALA-12313: (part 1) Refactor modify statements .. Patch Set 3: Code-Review+2 LGTM now Noemi and Peter have given

[Impala-ASF-CR] IMPALA-12477: Make Iceberg planFiles() use multiple threads

2023-09-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20523 ) Change subject: IMPALA-12477: Make Iceberg planFiles() use multiple threads .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12228: Simulate the failure of an iceberg transaction.

2023-08-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20306 ) Change subject: IMPALA-12228: Simulate the failure of an iceberg transaction. .. Patch Set 1: (1 comment) Thanks for the review

[Impala-ASF-CR] IMPALA-12335: [DOCS] Add documentation about the DELETE statement

2023-08-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20361 ) Change subject: IMPALA-12335: [DOCS] Add documentation about the DELETE statement .. Patch Set 2: Code-Review+2 (1 comment) LGTM

[Impala-ASF-CR] IMPALA-12335: [DOCS] Add documentation about the DELETE statement

2023-08-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20361 ) Change subject: IMPALA-12335: [DOCS] Add documentation about the DELETE statement .. Patch Set 1: (1 comment) Read through once,

[Impala-ASF-CR] IMPALA-11341: Print error log files when data-loading fails

2022-06-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18597 ) Change subject: IMPALA-11341: Print error log files when data-loading fails .. Patch Set 1: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

2022-08-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. Patch Set 2: Code-Review+2 (1 comment) Doc is very

[Impala-ASF-CR] IMPALA-11304: impala-shell make the client retry attempts configurable

2022-10-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19105 ) Change subject: IMPALA-11304: impala-shell make the client retry attempts configurable .. Patch Set 5: (3 comments) This looks

[Impala-ASF-CR] IMPALA-11304: impala-shell make the client retry attempts configurable

2022-10-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19105 ) Change subject: IMPALA-11304: impala-shell make the client retry attempts configurable .. Patch Set 6: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-11591: Avoid calling planFiles() on Iceberg tables

2022-10-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19043 ) Change subject: IMPALA-11591: Avoid calling planFiles() on Iceberg tables .. Patch Set 7: (4 comments) A few nits

[Impala-ASF-CR] IMPALA-9999: Switch to GCC 10.4

2022-09-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 ) Change subject: IMPALA-: Switch to GCC 10.4 .. Patch Set 14: Code-Review+1 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-9999: Switch to GCC 10.4

2022-09-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 ) Change subject: IMPALA-: Switch to GCC 10.4 .. Patch Set 14: Code-Review+2 +2 based on addressing Csaba's comments -- To view,

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-17 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19002 to look at the new patch set (#4). Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-17 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19002 to look at the new patch set (#5). Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19002 Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-09-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 6: (7 comments) Thanks for the review

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-10-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. Patch Set 8: (7 comments) Thank for the useful

[Impala-ASF-CR] IMPALA-11482: Alter Table Execute Rollback for Iceberg tables.

2022-10-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/19002 ) Change subject: IMPALA-11482: Alter Table Execute Rollback for Iceberg tables. .. IMPALA-11482: Alter Table Execute Rollback for

[Impala-ASF-CR] IMPALA-11330: Add test for missing iceberg metadata directory.

2022-08-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18818 Change subject: IMPALA-11330: Add test for missing iceberg metadata directory. .. IMPALA-11330: Add test for missing iceberg metadata

[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality

2022-08-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 ) Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality .. Patch Set 1: (3 comments) Quick comments...

[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19373 ) Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test .. Patch Set 4:

[Impala-ASF-CR] IMPALA-11811: Avoid storing unregistered predicate objects in a Map

2022-12-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19390 Change subject: IMPALA-11811: Avoid storing unregistered predicate objects in a Map .. IMPALA-11811: Avoid storing unregistered

[Impala-ASF-CR] IMPALA-11808: Add support for reload event in catalogD

2023-01-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 ) Change subject: IMPALA-11808: Add support for reload event in catalogD .. Patch Set 13: (3 comments)

[Impala-ASF-CR] IMPALA-11375 Impala shell outputs details of each RPC

2023-01-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19388 ) Change subject: IMPALA-11375 Impala shell outputs details of each RPC .. Patch Set 11: Code-Review+1 (3 comments) LGTM

[Impala-ASF-CR] IMPALA-11808: Add support for reload event in catalogD

2023-01-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 ) Change subject: IMPALA-11808: Add support for reload event in catalogD .. Patch Set 13: (7 comments) Some spelling nits

[Impala-ASF-CR] IMPALA-11827: do not cache admission control service's IP address in impalad

2023-01-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19403 ) Change subject: IMPALA-11827: do not cache admission control service's IP address in impalad .. Patch Set 2: Code-Review+2 LGTM

[Impala-ASF-CR] IMPALA-11808: Add support for reload event in catalogD

2023-01-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 ) Change subject: IMPALA-11808: Add support for reload event in catalogD .. Patch Set 16: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-06 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#4). Change subject: IMPALA-10893: Use old schema during iceberg time travel.

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 2: (5 comments) Thanks for review comments.

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 6: Code-Review+2 Carry forward +2 -- To

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2023-01-10 Thread Andrew Sherman (Code Review)
Hello Tamas Mate, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#6). Change subject: IMPALA-10893: Use old schema during iceberg time travel.

<    1   2   3   4   5   6   7   >