[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13522 ) Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) .. Patch Set 3: This fixes mtime plumbing. There will

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-06 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13522 to look at the new patch set (#3). Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

[Impala-ASF-CR] IMPALA-8491: Non-root user in container

2019-05-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13451 ) Change subject: IMPALA-8491: Non-root user in container .. Patch Set 2: Wrapping my head around this one. Let me double-check my

[Impala-ASF-CR] IMPALA-8491: Non-root user in container

2019-05-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13451 ) Change subject: IMPALA-8491: Non-root user in container .. Patch Set 2: Code-Review+2 Cool, this makes sense. The umask thing is not

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 2: I was missing an

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13545 to look at the new patch set (#3). Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 2: (1 comment) I'm

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13545 to look at the new patch set (#2). Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13522 ) Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13522 ) Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-8593: Prohibit write operations for bucketed tables

2019-06-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13558 ) Change subject: IMPALA-8593: Prohibit write operations for bucketed tables .. Patch Set 1: (1 comment) Drive-by comment. Hope this

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-18 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13545 to look at the new patch set (#4). Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-18 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Tim Armstrong, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13545 to look at the new patch set (#6). Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement

[Impala-ASF-CR] IMPALA-8700: Use int64 t mtime for HdfsScanNodeBase::AllocateScanRange()

2019-06-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13712 ) Change subject: IMPALA-8700: Use int64_t mtime for HdfsScanNodeBase::AllocateScanRange() .. IMPALA-8700: Use int64_t mtime

[Impala-ASF-CR] [DOCS] Syntax fix for CREATE FUNCTION

2019-06-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13726 ) Change subject: [DOCS] Syntax fix for CREATE FUNCTION .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8315: ignore rmtree errors in run stmt in hive()

2019-06-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13720 ) Change subject: IMPALA-8315: ignore rmtree errors in run_stmt_in_hive() .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 12: Code-Review+2 Carry +2

[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config

2019-06-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 ) Change subject: IMPALA-8650: Docker build should not depend on test config .. Patch Set 4: Code-Review+2 Great, looks good. -- To

[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase

2019-06-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 ) Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-19 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Tim Armstrong, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13545 to look at the new patch set (#7). Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-19 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Tim Armstrong, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13545 to look at the new patch set (#9). Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 7: (9 comments)

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-19 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Tim Armstrong, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13545 to look at the new patch set (#8). Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 9: (4 comments) Thanks

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-20 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Tim Armstrong, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13545 to look at the new patch set (#10). Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement

[Impala-ASF-CR] Backport KUDU-2871 (part 1): disable TLS 1.3.

2019-06-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13689 ) Change subject: Backport KUDU-2871 (part 1): disable TLS 1.3. .. Backport KUDU-2871 (part 1): disable TLS 1.3. Change-Id:

[Impala-ASF-CR] IMPALA-7947: script to push images to docker repo

2019-06-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13698 ) Change subject: IMPALA-7947: script to push images to docker repo .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7947: script to push images to docker repo

2019-06-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13698 ) Change subject: IMPALA-7947: script to push images to docker repo .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8700: Use int64 t mtime for HdfsScanNodeBase::AllocateScanRange()

2019-06-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13712 Change subject: IMPALA-8700: Use int64_t mtime for HdfsScanNodeBase::AllocateScanRange() .. IMPALA-8700: Use int64_t mtime for

[Impala-ASF-CR] IMPALA-8650: Docker build should not depend on test config

2019-06-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 ) Change subject: IMPALA-8650: Docker build should not depend on test config .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8630: Include partition id when calculating consistent remote placement

2019-06-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Include partition id when calculating consistent remote placement .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8369 : Fix for tests failing with incompatible column changes

2019-05-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13254 ) Change subject: IMPALA-8369 : Fix for tests failing with incompatible column changes .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution .. Patch Set 9: Code-Review+2 It gets through the

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution .. Patch Set 9: Trying this out on my machine -- To

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution .. Patch Set 7: > > Patch Set 7: > > > > I ran this

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Laszlo Gaal, Philip Zeyliger, David Knupp, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13020 to look at the new patch set (#3). Change subject: IMPALA-8344: Add support for running the minicluster

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-13 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Laszlo Gaal, Philip Zeyliger, David Knupp, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13020 to look at the new patch set (#4). Change subject: IMPALA-8344: Add support for running the minicluster

[Impala-ASF-CR] IMPALA-8072: addendum: don't require fe rebuild for config

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13288 ) Change subject: IMPALA-8072: addendum: don't require fe rebuild for config .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 5: Code-Review+2 This makes sense to

[Impala-ASF-CR] IMPALA-8428: Add support for caching file handles on s3

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13221 ) Change subject: IMPALA-8428: Add support for caching file handles on s3 .. Patch Set 4: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: Code-Review+2 (1 comment) This

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: (1 comment) This looks good to

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13252 ) Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load .. Patch Set 4: Code-Review+2 Thanks, looks good -- To

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 3: Code-Review+2 (1 comment) Looks good

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 4: (1 comment)

[Impala-ASF-CR] Remove hwx.public.repo maven repo

2019-05-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13403 ) Change subject: Remove hwx.public.repo maven repo .. Patch Set 1: Verified+1 This got past the build/dataload/fe_tests for both

[Impala-ASF-CR] Remove hwx.public.repo maven repo

2019-05-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13403 ) Change subject: Remove hwx.public.repo maven repo .. Remove hwx.public.repo maven repo The hwx.public.repo

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 6: Rebase to get the drop of

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 6: Code-Review+1 Carry +1 -- To

[Impala-ASF-CR] Remove hwx.public.repo maven repo

2019-05-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13403 ) Change subject: Remove hwx.public.repo maven repo .. Patch Set 1: This builds on my machine. Running tests to make sure upstream

[Impala-ASF-CR] Remove hwx.public.repo maven repo

2019-05-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13403 Change subject: Remove hwx.public.repo maven repo .. Remove hwx.public.repo maven repo The hwx.public.repo

[Impala-ASF-CR] IMPALA-8546: collect logs from docker containers

2019-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13393 ) Change subject: IMPALA-8546: collect logs from docker containers .. Patch Set 3: Code-Review+2 Looks good -- To view, visit

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. IMPALA-8344: Add support for running the

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 ) Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails .. Patch Set 5: Code-Review+1 Reviving this. Rebased,

[Impala-ASF-CR] IMPALA-8546: collect logs from docker containers

2019-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed a vote on this change. Change subject: IMPALA-8546: collect logs from docker containers .. Removed Code-Review+2 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/13393 To

[Impala-ASF-CR] IMPALA-8546: collect logs from docker containers

2019-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13393 ) Change subject: IMPALA-8546: collect logs from docker containers .. Patch Set 4: Verified-1 Just noticed that the logs cause problems

[Impala-ASF-CR] Add a README for data-loading file format, remove LOAD LOCAL

2019-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13370 ) Change subject: Add a README for data-loading file format, remove LOAD_LOCAL .. Patch Set 1: Code-Review+2 Thanks for cleaning this

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 3: (2 comments) Forgot to post this

[Impala-ASF-CR] IMPALA-8509. Lazily evaluate LOAD sections during data load

2019-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13252 ) Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load .. Patch Set 3: Code-Review+2 (1 comment) I think this

[Impala-ASF-CR] IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading

2019-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 ) Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading .. Patch Set 3: (1 comment) What happened to the

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-21 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Laszlo Gaal, Philip Zeyliger, David Knupp, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13020 to look at the new patch set (#5). Change subject: IMPALA-8344: Add support for running the minicluster

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-05-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13020 ) Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8540: stop docker containers upon job end

2019-05-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13385 ) Change subject: IMPALA-8540: stop docker containers upon job end .. Patch Set 1: Code-Review+2 Makes sense to cleanup the docker

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13343 ) Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Patch Set 3: > Do we have the same bug in run-hive-server.sh?

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Joe McDonnell (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13343 to look at the new patch set (#3). Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 21: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 23: Code-Review+2 Fix looks correct

[Impala-ASF-CR] IMPALA-8475: Fix unbound CMAKE BUILD TYPE LIST in buildall.sh

2019-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13204 Change subject: IMPALA-8475: Fix unbound CMAKE_BUILD_TYPE_LIST in buildall.sh .. IMPALA-8475: Fix unbound CMAKE_BUILD_TYPE_LIST in

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

2019-05-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 ) Change subject: IMPALA-8269: Refactor authorization test package structure .. Patch Set 1: Code-Review+1 (1 comment) This makes

[Impala-ASF-CR] IMPALA-8478: Fix test provider.py Python 2.6 compatibility

2019-05-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13211 ) Change subject: IMPALA-8478: Fix test_provider.py Python 2.6 compatibility .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Configure Hive 3's HS2 to execute queries using Tez local mode

2019-04-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12931 ) Change subject: Configure Hive 3's HS2 to execute queries using Tez local mode .. Patch Set 6: Code-Review+2 I think this makes

[Impala-ASF-CR] Configure Hive 3's HS2 to execute queries using Tez local mode

2019-04-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12931 ) Change subject: Configure Hive 3's HS2 to execute queries using Tez local mode .. Configure Hive 3's HS2 to execute queries

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 12: (2 comments) Starting to

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 14: (3 comments)

[Impala-ASF-CR] Revert "IMPALA-7971: Add support for insert events in event processor."

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13182 ) Change subject: Revert "IMPALA-7971: Add support for insert events in event processor." .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 19: (3 comments) I'm basically

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 20: Code-Review+2 This looks good.

[Impala-ASF-CR] IMPALA-8466: disable test caching ddl in dockerized cluster

2019-04-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13181 ) Change subject: IMPALA-8466: disable test_caching_ddl in dockerized cluster .. Patch Set 1: Code-Review+2 Thanks for fixing this --

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 1: (2 comments)

[Impala-ASF-CR] Improve output for generate-schema-statements.py

2019-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 ) Change subject: Improve output for generate-schema-statements.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution

2019-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: IMPALA-8369 (part 2): Hive 3: switch to Tez-on-YARN execution .. Patch Set 7: I ran this (without the other patches

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8270: fix MemTracker teardown in FeSupport

2019-04-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 ) Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: Hive 3: switch to Tez-on-YARN execution .. Patch Set 2: I'm running a gerrit-verify-dryrun-external (which won't

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: Hive 3: switch to Tez-on-YARN execution .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: Hive 3: switch to Tez-on-YARN execution .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Hive 3: switch to Tez-on-YARN execution

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13224 ) Change subject: Hive 3: switch to Tez-on-YARN execution .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8492: reenable large string tests in docker

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13233 ) Change subject: IMPALA-8492: reenable large string tests in docker .. Patch Set 2: Code-Review+2 Looks good to me -- To view, visit

[Impala-ASF-CR] IMPALA-8428: Add support for caching file handles on s3

2019-05-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13221 ) Change subject: IMPALA-8428: Add support for caching file handles on s3 .. Patch Set 2: Code-Review+2 Thanks for putting this

[Impala-ASF-CR] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: IMPALA-8630: Hash the full path when calculating consistent remote placement .. IMPALA-8630: Hash the full

[Impala-ASF-CR] IMPALA-8747: Fix string formatting on HS2 connection setup failure

2019-07-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13815 ) Change subject: IMPALA-8747: Fix string formatting on HS2 connection setup failure .. Patch Set 2: Test failure in an unrelated

[Impala-ASF-CR] IMPALA-8732: Use a serialized descriptor table in TQueryCtx

2019-07-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13772 ) Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx .. Patch Set 6: Code-Review+2 Carrying +2 -- To view,

[Impala-ASF-CR] IMPALA-8732: Use a serialized descriptor table in TQueryCtx

2019-07-10 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13772 to look at the new patch set (#5). Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx

<    2   3   4   5   6   7   8   9   10   11   >