[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-11-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 3: (5 comments) Apologies for being

[Impala-ASF-CR] IMPALA-6955: fix test query concurrency and server startup sequence

2018-11-30 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12019 Change subject: IMPALA-6955: fix test_query_concurrency and server startup sequence .. IMPALA-6955: fix test_query_concurrency and

[Impala-ASF-CR] IMPALA-7473: fix crash when printing decimal with -v=3

2018-12-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12029 ) Change subject: IMPALA-7473: fix crash when printing decimal with -v=3 .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7625: test web pages.py backend tests are failing

2018-12-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12024 ) Change subject: IMPALA-7625: test_web_pages.py backend tests are failing .. Patch Set 2: (8 comments)

[Impala-ASF-CR] DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics

2018-12-07 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/7354 ) Change subject: DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7354 To

[Impala-ASF-CR] Draft: Add JSON output to MemTracker::LogUsage()

2018-12-07 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/8955 ) Change subject: Draft: Add JSON output to MemTracker::LogUsage() .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/8955 To

[Impala-ASF-CR] IMPALA-2343: Add lifecycle timeline to plan nodes

2018-12-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11992 ) Change subject: IMPALA-2343: Add lifecycle timeline to plan nodes .. Patch Set 10: Code-Review+1 Thanks for rebasing in a separate PS.

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-12-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6741: Add timestamp of fragment instance's status updates

2018-12-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12000 ) Change subject: IMPALA-6741: Add timestamp of fragment instance's status updates .. Patch Set 5: Code-Review+2 (1 comment) Had a minor

[Impala-ASF-CR] IMPALA-6955: fix test query concurrency and server startup sequence

2018-12-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12019 ) Change subject: IMPALA-6955: fix test_query_concurrency and server startup sequence .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6955: fix test query concurrency and server startup sequence

2018-12-05 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12019 ) Change subject: IMPALA-6955: fix test_query_concurrency and server startup sequence .. IMPALA-6955: fix test_query_concurrency

[Impala-ASF-CR] Print query id when timing out waiting for state

2018-12-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12039 Change subject: Print query id when timing out waiting for state .. Print query id when timing out waiting for state This makes it

[Impala-ASF-CR] IMPALA-6955: fix test query concurrency and server startup sequence

2018-12-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12019 ) Change subject: IMPALA-6955: fix test_query_concurrency and server startup sequence .. IMPALA-6955: fix test_query_concurrency and server

[Impala-ASF-CR] IMPALA-6591: Fix test ssl flaky test

2018-12-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12047 ) Change subject: IMPALA-6591: Fix test_ssl flaky test .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7926: Fix flakiness in test reconnect

2018-12-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12045 ) Change subject: IMPALA-7926: Fix flakiness in test_reconnect .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-7943: Bump the default client timeout set on impala-shell

2018-12-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12051 ) Change subject: IMPALA-7943: Bump the default client timeout set on impala-shell .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-1048: show sinks in exec summary

2018-12-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11967 ) Change subject: IMPALA-1048: show sinks in exec summary .. Patch Set 13: Code-Review+2 (1 comment) Had a nit, otherwise LGTM

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-11-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 5: (17 comments)

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2018-11-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 12: (6 comments) I had a comment

[Impala-ASF-CR] IMPALA-2343: Add lifecycle timeline to plan nodes

2018-11-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11992 ) Change subject: IMPALA-2343: Add lifecycle timeline to plan nodes .. Patch Set 7: I also noted that a lot of Open() and GetNext()

[Impala-ASF-CR] IMPALA-2343: Add lifecycle timeline to plan nodes

2018-11-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11992 ) Change subject: IMPALA-2343: Add lifecycle timeline to plan nodes .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 ) Change subject: IMPALA-7881: Visualize AST for easier debugging .. Patch Set 2: Code-Review+1 (2 comments) I had a look because I was

[Impala-ASF-CR] Revert "IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code"

2018-11-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11699 ) Change subject: Revert "IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code" .. Patch Set 2: > Any luck? I hit some issues

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2018-11-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11950 ) Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. Patch Set 1: Code-Review+2 Thanks for fixing this! -- To

[Impala-ASF-CR] IMPALA-8059: Disable broken tests

2019-01-08 Thread Lars Volker (Code Review)
Hello Pooja Nilangekar, Sahil Takiar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12190 to look at the new patch set (#3). Change subject: IMPALA-8059: Disable broken tests ..

[Impala-ASF-CR] IMPALA-8059: Disable broken tests

2019-01-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12190 ) Change subject: IMPALA-8059: Disable broken tests .. Patch Set 3: Code-Review+2 Upgrading Sahil's +1. -- To view, visit

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 19: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency

2019-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12203 ) Change subject: IMPALA-6544/IMPALA-7070: Disable tests which fail due to S3's eventual consistency .. Patch Set 3: Code-Review+1 LGTM,

[native-toolchain-CR] IMPALA-7924: Add Thrift 0.11.0 to the toolchain

2019-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12034 ) Change subject: IMPALA-7924: Add Thrift 0.11.0 to the toolchain .. Patch Set 2: Verified+1 Code-Review+2 Verified in private builds.

[native-toolchain-CR] IMPALA-7924: Add Thrift 0.11.0 to the toolchain

2019-01-10 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12034 ) Change subject: IMPALA-7924: Add Thrift 0.11.0 to the toolchain .. IMPALA-7924: Add Thrift 0.11.0 to the toolchain Adds Thrift

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 9: (25 comments) Thanks for the review, please

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-10 Thread Lars Volker (Code Review)
Hello Michael Ho, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12069 to look at the new patch set (#9). Change subject: IMPALA-7694: Add host resource usage metrics to profile

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-01-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8061: Fix S3 ACCESS VALIDATED unbound variable

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12193 ) Change subject: IMPALA-8061: Fix S3_ACCESS_VALIDATED unbound variable .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8061: Fix S3 ACCESS VALIDATED unbound variable

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12193 ) Change subject: IMPALA-8061: Fix S3_ACCESS_VALIDATED unbound variable .. Patch Set 1: Did something recently fail that makes this

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 16: (2 comments)

[Impala-ASF-CR] WIP IMPALA-7550 Add documentation to profile counters

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12116 ) Change subject: WIP IMPALA-7550 Add documentation to profile counters .. Patch Set 1: > (1 comment) Thanks for the feedback. I added a

[Impala-ASF-CR] WIP IMPALA-7550 Add documentation to profile counters

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12116 ) Change subject: WIP IMPALA-7550 Add documentation to profile counters .. Patch Set 1: > It's hard to argue with documenting these. >

[Impala-ASF-CR] WIP IMPALA-7550 Add documentation to profile counters

2019-01-09 Thread Lars Volker (Code Review)
Hello Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12116 to look at the new patch set (#2). Change subject: WIP IMPALA-7550 Add documentation to profile counters

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2019-01-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-5937: [DOCS] PARQUET READ STATISTICS and PARQUET DICTIONARY FILTERING

2018-09-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11355 ) Change subject: IMPALA-5937: [DOCS] PARQUET_READ_STATISTICS and PARQUET_DICTIONARY_FILTERING .. Patch Set 7: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-5937: [DOCS] PARQUET READ STATISTICS and PARQUET DICTIONARY FILTERING

2018-09-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11355 ) Change subject: IMPALA-5937: [DOCS] PARQUET_READ_STATISTICS and PARQUET_DICTIONARY_FILTERING .. Patch Set 7: Code-Review+2 -- To

[Impala-ASF-CR] Revert "Revert "IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER""

2018-09-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11466 ) Change subject: Revert "Revert "IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER"" .. Patch Set 1: (1 comment)

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. Patch Set 1: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Lars Volker (Code Review)
Lars Volker has removed a vote on this change. Change subject: IMPALA-7889: Write new logical types in Parquet .. Removed Code-Review+2 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/12004 To

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 11: Code-Review+1 (2 comments) Looks like a test failed,

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2018-12-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 7: (24 comments) Thanks for the reviews, please

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2018-12-18 Thread Lars Volker (Code Review)
Hello Michael Ho, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12069 to look at the new patch set (#8). Change subject: IMPALA-7694: Add host resource usage metrics to profile

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 8: Code-Review+1 (1 comment)

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. Patch Set 3: Code-Review+2 --

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 12: (20 comments)

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-24 Thread Lars Volker (Code Review)
Hello Michael Ho, Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12069 to look at the new patch set (#12). Change subject: IMPALA-7694: Add host resource usage metrics to profile

[Impala-ASF-CR] IMPALA-7731: Add Read/Exchange counters to profile

2019-01-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12229 ) Change subject: IMPALA-7731: Add Read/Exchange counters to profile .. Patch Set 5: Code-Review+2 Rebased, carrying Phil's +2 -- To

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-25 Thread Lars Volker (Code Review)
Hello Michael Ho, Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12069 to look at the new patch set (#14). Change subject: IMPALA-7694: Add host resource usage metrics to profile

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 13: (3 comments) Thanks for the review, please

[Impala-ASF-CR] IMPALA-8114: Deflake test breakpad.py

2019-01-24 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12273 Change subject: IMPALA-8114: Deflake test_breakpad.py .. IMPALA-8114: Deflake test_breakpad.py A test failed recently in a private build

[Impala-ASF-CR] IMPALA-7640: RENAME on managed Kudu table should rename Kudu table

2019-01-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12179 ) Change subject: IMPALA-7640: RENAME on managed Kudu table should rename Kudu table .. Patch Set 2: (2 comments)

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Give each config change in bootstrap_system.sh its own line .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-03-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 7: (31 comments) Did a first pass over the

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 9.4

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2) to the change originally created by Laszlo Gaal. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 9.4 .. IMPALA-8380: Bump

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 8: (37 comments)

[Impala-ASF-CR] IMPALA-8101: Thrift 11 and ext-data-source compilation are always run

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12290 ) Change subject: IMPALA-8101: Thrift 11 and ext-data-source compilation are always run .. Patch Set 1: Anything blocking this from

[Impala-ASF-CR] IMPALA-7640: RENAME on managed Kudu table should rename Kudu table

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12179 ) Change subject: IMPALA-7640: RENAME on managed Kudu table should rename Kudu table .. Patch Set 4: Thomas, do you have time to look at

[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12163 ) Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata .. Patch Set 3: Zoltan, any

[native-toolchain-CR] Remove '-static-libstdc++' from CXXFLAGS

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12929 ) Change subject: Remove '-static-libstdc++' from CXXFLAGS .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 9.4

2019-04-03 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3) to the change originally created by Laszlo Gaal. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 9.4 .. IMPALA-8380: Bump

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 3: (8 comments)

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8101: Thrift 11 and ext-data-source compilation are always run

2019-04-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12290 ) Change subject: IMPALA-8101: Thrift 11 and ext-data-source compilation are always run .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5

2019-04-05 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4) to the change originally created by Laszlo Gaal. ( http://gerrit.cloudera.org:8080/12894 ) Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 42.2.5 .. IMPALA-8380:

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-03-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 13: Code-Review+2 (3 comments) Only had some

[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile

2019-03-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 ) Change subject: IMPALA-7982: Add host network usage to profile .. Patch Set 5: Code-Review+2 Rebased, carrying Todd's +2 -- To view,

[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile

2019-03-28 Thread Lars Volker (Code Review)
Hello John Sherman, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12747 to look at the new patch set (#3). Change subject: IMPALA-7982: Add host network usage to profile

[Impala-ASF-CR] IMPALA-7982: Add host network usage to profile

2019-03-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 ) Change subject: IMPALA-7982: Add host network usage to profile .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Ensure ssh config change is on its own line

2019-04-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Ensure ssh config change is on its own line .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Improve error handling for validation of unified backend executable

2019-04-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-07 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12954 Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. IMPALA-8395: Parse older formats of /proc/net/dev

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 15: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 5: Code-Review+2 (2 comments)

[Impala-ASF-CR] Re-land IMPALA-5393. Use THREAD LOCAL state for regexp

2019-03-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12845 ) Change subject: Re-land IMPALA-5393. Use THREAD_LOCAL state for regexp .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8239: Fix handling of failed deserialization of row batch

2019-02-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12567 ) Change subject: IMPALA-8239: Fix handling of failed deserialization of row batch .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios

2019-02-28 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12638 Change subject: IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios .. IMPALA-8264: Fix overflow in

[Impala-ASF-CR] IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios

2019-02-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12638 ) Change subject: IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios .. Patch Set 2: Code-Review+2 (1 comment) Carrying

[Impala-ASF-CR] IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios

2019-02-28 Thread Lars Volker (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12638 to look at the new patch set (#2). Change subject: IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-03-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy()

2019-03-01 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 ) Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning

2019-02-20 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12543 to look at the new patch set (#3). Change subject: IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning

[Impala-ASF-CR] IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning

2019-02-20 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12543 to look at the new patch set (#2). Change subject: IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning

[Impala-ASF-CR] IMPALA-8234: Fix ordering of Thrift enum, add warning

2019-02-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12543 Change subject: IMPALA-8234: Fix ordering of Thrift enum, add warning .. IMPALA-8234: Fix ordering of Thrift enum, add warning

[Impala-ASF-CR] IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning

2019-02-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12543 ) Change subject: IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning

2019-02-21 Thread Lars Volker (Code Review)
Hello Philip Zeyliger, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12543 to look at the new patch set (#4). Change subject: IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning

[Impala-ASF-CR] IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning

2019-02-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12543 ) Change subject: IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla

2019-02-20 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12530 to look at the new patch set (#3). Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla

[Impala-ASF-CR] IMPALA-8158: Retrieve thrift profiles through Impyla

2019-02-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 ) Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla .. Patch Set 2: > (1 comment) > > We need to bump impyla_version

[Impala-ASF-CR] Make error message for backend test validation more clear

2019-02-26 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12620 Change subject: Make error message for backend test validation more clear .. Make error message for backend test validation more clear

[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set

2019-02-26 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12616 to look at the new patch set (#4). Change subject: IMPALA-8252: Only write node_metadata if it's set

[Impala-ASF-CR] IMPALA-8252: Only write node metadata if it's set

2019-02-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12616 ) Change subject: IMPALA-8252: Only write node_metadata if it's set .. Patch Set 4: Code-Review+2 Added test to list of backend tests,

<    4   5   6   7   8   9   10   11   12   13   >