[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. IMPALA-6262: Always initialize runtime profile for DataSink

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6281: Fix use-after-free in InitAuth()

2017-12-06 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8777 ) Change subject: IMPALA-6281: Fix use-after-free in InitAuth() .. IMPALA-6281: Fix use-after-free in InitAuth() Previously, we implicitly

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 4: (18 comments)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6291: disable AVX512 codegen in LLVM

2017-12-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 ) Change subject: IMPALA-6291: disable AVX512 codegen in LLVM .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 2: LGTM. Will there be another change addressing similar

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10327 ) Change subject: IMPALA-6907: Close stale connections to removed cluster members .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-08 Thread Michael Ho (Code Review)
Hello Tianyi Wang, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10327 to look at the new patch set (#4). Change subject: IMPALA-6907: Close stale connections to removed cluster members

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-11 Thread Michael Ho (Code Review)
Hello Tianyi Wang, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10327 to look at the new patch set (#5). Change subject: IMPALA-6907: Close stale connections to removed cluster members

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10327 ) Change subject: IMPALA-6907: Close stale connections to removed cluster members .. Patch Set 5: Code-Review+2 Rebase. Carry +2. -- To

[Impala-ASF-CR](2.x) IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-05-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10327 ) Change subject: IMPALA-6907: Close stale connections to removed cluster members .. IMPALA-6907: Close stale connections to removed cluster

[Impala-ASF-CR] IMPALA-7032: Disable codegen for CHAR type null literals

2018-05-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 ) Change subject: IMPALA-7032: Disable codegen for CHAR type null literals .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA-7011: Simplify PlanRootSink control logic .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: Tim, thanks for pointing that out. I

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-22 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10480 Change subject: Upgrade Protobuf to 3.5.1 .. Upgrade Protobuf to 3.5.1 Protobuf 3.0.0+ has support for both v2 and v3 of protobuf syntax.

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 3: Code-Review+2 Rebase. Carry +2. --

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh File

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10496/1/buildall.sh

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 1: (1 comment)

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10496 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 1: Code-Review+2 (1 comment)

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10480/1/buildall.sh File

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10480 to look at the new patch set (#2). Change subject: Upgrade Protobuf to 3.5.1 .. Upgrade Protobuf to

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Upgrade Protobuf to 3.5.1 Protobuf 3.0.0+ has support for both v2 and v3 of

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 2: Verified the change by building on various platforms and tried the new bits on

[native-toolchain-CR] Upgrade Protobuf to 3.5.1

2018-05-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10480 ) Change subject: Upgrade Protobuf to 3.5.1 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10480 To

[Impala-ASF-CR] IMPALA-7011: Simplify PlanRootSink control logic

2018-05-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10449 ) Change subject: IMPALA-7011: Simplify PlanRootSink control logic .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. IMPALA-5168: Codegen HASH_PARTITIONED

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-15 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10421 Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. IMPALA-5168: Codegen HASH_PARTITIONED

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-05-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance

2018-06-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 ) Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance .. Patch Set 1: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

2018-06-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10751 ) Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc

2018-06-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10679 ) Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-13 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10421 to look at the new patch set (#6). Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send()

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 6: Code-Review+2 Fix clang-tidy issue.

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 4: Code-Review+2 Rebase. Carry +2. --

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-14 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10421 to look at the new patch set (#8). Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send()

[Impala-ASF-CR] IMPALA-5168: Codegen HASH PARTITIONED KrpcDataStreamSender::Send()

2018-06-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10421 ) Change subject: IMPALA-5168: Codegen HASH_PARTITIONED KrpcDataStreamSender::Send() .. Patch Set 9: Code-Review+2 Fixed another

[Impala-ASF-CR] IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc

2018-06-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10679 ) Change subject: IMPALA-3816: (prep) Move TupleSorter to sorter-ir.cc .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare()

2018-06-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10680 ) Change subject: IMPALA-3816, IMPALA-4065: Remove the indirection to TupleRowComparator::Compare() .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-06-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

2018-05-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 ) Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3" .. Patch Set 1: Is this a clean revert ? -- To view, visit

[Impala-ASF-CR] IMPALA-6947: Kudu tests flaky due to rpc timeout

2018-05-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 ) Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout .. Patch Set 2: (3 comments)

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

2018-05-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 ) Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3" .. Patch Set 1: Code-Review+2 Please run some sanity tests

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-06-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10576 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/10576

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-06-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 1: Thanks for taking a look.

[Impala-ASF-CR] IMPALA-6425: reduce MemPool max chunk size

2018-06-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10789 ) Change subject: IMPALA-6425: reduce MemPool max chunk size .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

2018-06-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 ) Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3" .. Patch Set 1: -Code-Review Hi Sailesh, this patch may not be

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-06-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7191: don't call srand() at random times

2018-06-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10778 ) Change subject: IMPALA-7191: don't call srand() at random times .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7191: don't call srand() at random times

2018-06-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10778 ) Change subject: IMPALA-7191: don't call srand() at random times .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-06-26 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10835 Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. IMPALA-7212: Deprecate --use_krpc flag and

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-06-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5486: Port ReportExecStatus() RPC to use KRPC

2018-07-02 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10855 Change subject: IMPALA-5486: Port ReportExecStatus() RPC to use KRPC .. IMPALA-5486: Port ReportExecStatus() RPC to use KRPC This change

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-02 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. IMPALA-7213: Port ReportExecStatus() RPC to use KRPC This change

[Impala-ASF-CR](2.x) IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-05-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. Patch Set 2: (1 comment)

[Impala-ASF-CR](2.x) IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-05-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-04-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10247 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 4: (15 comments)

[Impala-ASF-CR] IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming

2018-07-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10863 ) Change subject: IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming

2018-07-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10863 ) Change subject: IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7213: Port ReportExecStatus() RPC to use KRPC

2018-07-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 ) Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

2018-01-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 1: Can you please add a BE test for it ? -- To view,

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 9: (6 comments) LGTM. Some minor comments.

[Impala-ASF-CR] KUDU-2237: Allow idle server connection scanning to be disabled

2017-12-21 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8909 to review the following change. Change subject: KUDU-2237: Allow idle server connection scanning to be disabled

[Impala-ASF-CR] KUDU-2237: Allow idle server connection scanning to be disabled

2017-12-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8909 ) Change subject: KUDU-2237: Allow idle server connection scanning to be disabled .. Patch Set 1: Clean cherry-pick. -- To view, visit

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2017-12-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] KUDU-2237: Allow idle server connection scanning to be disabled

2017-12-21 Thread Michael Ho (Code Review)
Michael Ho has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/8909 ) Change subject: KUDU-2237: Allow idle server connection scanning to be disabled .. Removed reviewer Todd Lipcon. -- To view, visit

[Impala-ASF-CR] KUDU-2237: Allow idle server connection scanning to be disabled

2017-12-21 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8909 ) Change subject: KUDU-2237: Allow idle server connection scanning to be disabled .. Removed reviewer Kudu Jenkins. -- To view,

[Impala-ASF-CR] IMPALA-5528: Add a knob to tune TCMalloc total thread caches size

2017-12-21 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8906 Change subject: IMPALA-5528: Add a knob to tune TCMalloc total thread caches size .. IMPALA-5528: Add a knob to tune TCMalloc total thread

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2017-12-21 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8910 Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms .. IMPALA-5557: Disable rpc_default_keepalive_time_ms This change makes

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 ) Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 ) Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2017-12-22 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8910 to look at the new patch set (#2). Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 2: Code-Review+2

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-10 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8991 to look at the new patch set (#3). Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-2397: Use atomics for metrics

2018-01-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9012 ) Change subject: IMPALA-2397: Use atomics for metrics .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9058 Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled .. IMPALA-5528: Bump total thread cache size when KRPC is

[Impala-ASF-CR] Revert "IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC"

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9057 Change subject: Revert "IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC" .. Revert "IMPALA-5528: Upgrade GPerfTools to

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 16: Sorry. Will start on it today. -- To view,

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 10: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: (1 comment) Did we intentionally not

<    1   2   3   4   5   6   7   8   >