[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/9632 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. Abandoned Conflict with https://gerrit.cloudera.org/#/c/9633/ -- To view,

[Impala-ASF-CR] IMPALA-6652: Rename Data Stream Manager MemTracker

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename Data Stream Manager MemTracker .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9633/

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 4: Code-Review+2 -- To vi

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-16 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9690 Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. IMPALA-6685: Improve profiles in KrpcDataS

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9696/1/be/s

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 1: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 2: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#2). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 2: (9 comments) http://gerrit

[Impala-ASF-CR] IMPALA-6691: KRPC w/ kerberos fails on SLES11

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9696 ) Change subject: IMPALA-6691: KRPC w/ kerberos fails on SLES11 .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 2: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-6713: Fix format string error in Sorter

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9740 Change subject: IMPALA-6713: Fix format string error in Sorter .. IMPALA-6713: Fix format string error in Sorter This change fixes a format

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 1: (2 comments) http://gerrit

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#3). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9748 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 2: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9749/1

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-24 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#4). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 4: (16 comments) http://gerri

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 4: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-25 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9797 Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krp

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9797 to look at the new patch set (#2). Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true ..

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9807 to review the following change. Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. KUDU-237

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Removed reviewer Kudu Jenkins. -- To view, visit http://gerrit.clou

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Removed reviewer Todd Lipcon. -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] KUDU-2374: Add RpcContext::GetTimeReceived()

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9807 ) Change subject: KUDU-2374: Add RpcContext::GetTimeReceived() .. Patch Set 1: Clean cherry-pick. -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9797 to look at the new patch set (#3). Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true ..

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. IMPALA-6685: Improve profiles in KrpcDataSt

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 5: (13 comments) http://gerri

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9797 to look at the new patch set (#4). Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true ...

[Impala-ASF-CR] IMPALA-6728: Always use Kudu based kinit if FLAGS use krpc=true

2018-03-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9797 ) Change subject: IMPALA-6728: Always use Kudu based kinit if FLAGS_use_krpc=true .. Patch Set 4: Code-Review+2 Carry +2. Fixed clang-tidy e

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#6). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 6: Code-Review+2 Rebase. Carry

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#7). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-28 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#8). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 8: Code-Review+2 Fix clang-tid

[Impala-ASF-CR] Do clean as part of "bootstrap development.sh"

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9841 ) Change subject: Do clean as part of "bootstrap_development.sh" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] KUDU-2385: Fix typo in KinitContext::DoRenewal()

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9842 ) Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6759: align stress test memory estimation parse pattern

2018-03-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9844 ) Change subject: IMPALA-6759: align stress test memory estimation parse pattern .. Patch Set 3: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] Revert "IMPALA-6747: Automate diagnostics collection."

2018-03-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9872 ) Change subject: Revert "IMPALA-6747: Automate diagnostics collection." .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] Revert "IMPALA-6747: Automate diagnostics collection."

2018-03-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9872 ) Change subject: Revert "IMPALA-6747: Automate diagnostics collection." .. Patch Set 1: Agreed. GVO didn't catch the problem last time as i

[Impala-ASF-CR] Revert "IMPALA-6747: Automate diagnostics collection."

2018-03-30 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9872 ) Change subject: Revert "IMPALA-6747: Automate diagnostics collection." .. Revert "IMPALA-6747: Automate diagnostics collection." A

[Impala-ASF-CR] Revert "IMPALA-6747: Automate diagnostics collection."

2018-03-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9872 ) Change subject: Revert "IMPALA-6747: Automate diagnostics collection." .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3

2018-04-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-04-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/9300/11

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-04-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/9300/11/

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-04-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/9300/11/

[native-toolchain-CR] thrift-0.9.3-p4: forward compatibility of TLS protocols

2018-04-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10129 ) Change subject: thrift-0.9.3-p4: forward compatibility of TLS protocols .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c

[native-toolchain-CR] thrift-0.9.3-p4: forward compatibility of TLS protocols

2018-04-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10129 ) Change subject: thrift-0.9.3-p4: forward compatibility of TLS protocols .. Patch Set 2: Code-Review+1 (1 comment) Please have Sailesh ta

[Impala-ASF-CR] IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-04-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10247 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR](2.x) IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-05-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR](2.x) IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-05-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR](2.x) IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-05-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10327 ) Change subject: IMPALA-6907: Close stale connections to removed cluster members .. IMPALA-6907: Close stale connections to removed cluster m

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 2: LGTM. Will there be another change addressing similar i

[Impala-ASF-CR] IMPALA-6781: expand ORDER BY in some TPCH queries

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10351 ) Change subject: IMPALA-6781: expand ORDER BY in some TPCH queries .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-08 Thread Michael Ho (Code Review)
Hello Tianyi Wang, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10327 to look at the new patch set (#4). Change subject: IMPALA-6907: Close stale connections to removed cluster members ...

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10327 ) Change subject: IMPALA-6907: Close stale connections to removed cluster members .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12226 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 6: It seems like a more gradual approach to t

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12226 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 6: I meant "the timeout can also be turned of

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 11: (12 comments) Still wrapping my head around thi

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-7565: Set TAcceptQueueServer connection setup pool to be multi-threaded by default

2019-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12249 ) Change subject: IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded by default .. Patch Set 1: Code-Review+1

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-01-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12257 ) Change subject: IMPALA-8097: mt_dop for all queries via hidden flag .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/122

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/12260/1//C

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12260/2/be/

[Impala-ASF-CR] IMPALA-8111: [DOCS] Added KRPC-related known issues

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12291 ) Change subject: IMPALA-8111: [DOCS] Added KRPC-related known issues .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/122

[Impala-ASF-CR] IMPALA-8111: [DOCS] Added KRPC-related known issues

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12291 ) Change subject: IMPALA-8111: [DOCS] Added KRPC-related known issues .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12260/2/be/

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 14: (2 comments) This patch seems to have pretty th

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8138: Reintroduce rpc debugging options

2019-01-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 ) Change subject: IMPALA-8138: Reintroduce rpc debugging options .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12297/1/

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 7: Code-Review+2 (2 comments) http://gerrit

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/12260/4/be/

[Impala-ASF-CR] IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12311 ) Change subject: IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198 .. Patch Set 1: Code-Review+2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 4: (9 comments) Looking good. Some more minor c

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] Revert "IMPALA-8146: Remove make {debug,release,asan}.sh"

2019-02-01 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12335 Change subject: Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh" .. Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh" Thi

[Impala-ASF-CR] Revert "IMPALA-8146: Remove make {debug,release,asan}.sh"

2019-02-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12335 ) Change subject: Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh" .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] Revert "IMPALA-8146: Remove make {debug,release,asan}.sh"

2019-02-01 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12335 ) Change subject: Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh" .. Revert "IMPALA-8146: Remove make_{debug,release,asan}

[Impala-ASF-CR] IMPALA-7565: Set TAcceptQueueServer connection setup pool to be multi-threaded by default

2019-02-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12249 ) Change subject: IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded by default .. Patch Set 2: Code-Review+2

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/12260/6/be/

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-02-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 5: Code-Review+2 (7 comments) LGTM. Please addr

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 7: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-02-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-02-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 7: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8170: [DOCS] Added a section on load balancing proxy with TLS

2019-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12388 ) Change subject: IMPALA-8170: [DOCS] Added a section on load balancing proxy with TLS .. Patch Set 2: Will do. -- To view, visit http:/

[Impala-ASF-CR] IMPALA-8154: Disable Kerberos auth to local setting

2019-02-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12405 Change subject: IMPALA-8154: Disable Kerberos auth_to_local setting .. IMPALA-8154: Disable Kerberos auth_to_local setting Before KRPC, th

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 1: (6 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8170: [DOCS] Added a section on load balancing proxy with TLS

2019-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12388 ) Change subject: IMPALA-8170: [DOCS] Added a section on load balancing proxy with TLS .. Patch Set 2: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-8154: Disable Kerberos auth to local setting

2019-02-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12405 ) Change subject: IMPALA-8154: Disable Kerberos auth_to_local setting .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/1240

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-02-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] Add support for compiling using OpenSSL 1.1

2019-02-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12420 ) Change subject: Add support for compiling using OpenSSL 1.1 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12420/1/be/

[Impala-ASF-CR] IMPALA-8064: Improve observability of wait times for runtime filters

2019-02-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 ) Change subject: IMPALA-8064: Improve observability of wait times for runtime filters .. Patch Set 2: Code-Review+1 (1 comment) http://g

<    1   2   3   4   5   6   7   8   9   10   >