[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

2021-12-05 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 ) Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0 .. Patch

[Impala-ASF-CR] IMPALA-11047: Disable overlap predicate if not reading statistic.

2021-12-05 Thread Riza Suminto (Code Review)
Riza Suminto has abandoned this change. ( http://gerrit.cloudera.org:8080/18069 ) Change subject: IMPALA-11047: Disable overlap predicate if not reading statistic. .. Abandoned Abandoning in favor of

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

2021-12-05 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 ) Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0 .. Patch

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 16: (7 comments) Thank you, Kurt! Patch set 16 address some of

[Impala-ASF-CR] WIP IMPALA-6636: Use async IO in ORC scanner

2021-11-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: WIP IMPALA-6636: Use async IO in ORC scanner .. Patch Set 13: (4 comments) Hi All, David has ran several benchmark

[Impala-ASF-CR] IMPALA-11072: Deflake TestSpillingDebugActionDimensions.test spilling

2022-01-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18138 ) Change subject: IMPALA-11072: Deflake TestSpillingDebugActionDimensions.test_spilling .. Patch Set 1: > Patch Set 1: Code-Review+1 >

[Impala-ASF-CR] IMPALA-11072: Deflake TestSpillingDebugActionDimensions.test spilling

2022-01-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18138 ) Change subject: IMPALA-11072: Deflake TestSpillingDebugActionDimensions.test_spilling .. Patch Set 2: > Patch Set 2: > > Build

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 21: (3 comments) Patch set 21 add some more logging

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-11 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#21) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

2022-01-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 ) Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0 .. Patch

[Impala-ASF-CR] IMPALA-11072: Deflake TestSpillingDebugActionDimensions.test spilling

2022-01-10 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18138 Change subject: IMPALA-11072: Deflake TestSpillingDebugActionDimensions.test_spilling .. IMPALA-11072: Deflake

[Impala-ASF-CR] IMPALA-11152: Remove dependence on symlink when rotating logs

2022-03-04 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Qifan Chen, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18286 to look at the new patch set (#5). Change subject: IMPALA-11152: Remove dependence on symlink when rotating logs

[Impala-ASF-CR] IMPALA-11152: Remove dependence on symlink when rotating logs

2022-03-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18286 ) Change subject: IMPALA-11152: Remove dependence on symlink when rotating logs .. Patch Set 5: (6 comments) Patch set 1 mess up other

[Impala-ASF-CR] IMPALA-11152: Remove dependence on symlink when rotating logs

2022-03-04 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Qifan Chen, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18286 to look at the new patch set (#4). Change subject: IMPALA-11152: Remove dependence on symlink when rotating logs

[Impala-ASF-CR] IMPALA-11177: Remove DCHECK in useAsyncIoForStream

2022-03-11 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18311 Change subject: IMPALA-11177: Remove DCHECK in useAsyncIoForStream .. IMPALA-11177: Remove DCHECK in useAsyncIoForStream

[Impala-ASF-CR] IMPALA-11182: catch exceptions of orc::RowReader::createRowBatch

2022-03-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18321 ) Change subject: IMPALA-11182: catch exceptions of orc::RowReader::createRowBatch .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11185: Reuse orc row batch in the scanner life-cycle

2022-03-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18325 ) Change subject: IMPALA-11185: Reuse orc row batch in the scanner life-cycle .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-11184: Use ProgramInvocationShortName for log glob pattern

2022-03-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18326 Change subject: IMPALA-11184: Use ProgramInvocationShortName for log glob pattern .. IMPALA-11184: Use ProgramInvocationShortName for

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18327 Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. IMPALA-11123: Optimize count(star) for ORC scans IMPALA-5036 added

[Impala-ASF-CR] IMPALA-11185: Reuse orc row batch in the scanner life-cycle

2022-03-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18325 ) Change subject: IMPALA-11185: Reuse orc row batch in the scanner life-cycle .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-11135: Deflake LEFT ANTI JOIN test case in test spilling.py

2022-02-21 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18261 Change subject: IMPALA-11135: Deflake LEFT ANTI JOIN test case in test_spilling.py .. IMPALA-11135: Deflake LEFT ANTI JOIN test case in

[Impala-ASF-CR] IMPALA-10999 Flakiness in TestAsyncLoadData.test async load

2022-02-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18268 ) Change subject: IMPALA-10999 Flakiness in TestAsyncLoadData.test_async_load .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10049: Include RPC call id in slow RPC logs

2022-02-28 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18243 ) Change subject: IMPALA-10049: Include RPC call_id in slow RPC logs .. Patch Set 6: > Patch Set 6: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-10049: Include RPC call id in slow RPC logs

2022-02-28 Thread Riza Suminto (Code Review)
Hello Joe McDonnell, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18243 to look at the new patch set (#7). Change subject: IMPALA-10049: Include RPC call_id in slow RPC logs

[Impala-ASF-CR] IMPALA-10049: Include RPC call id in slow RPC logs

2022-02-17 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18243 Change subject: IMPALA-10049: Include RPC call_id in slow RPC logs .. IMPALA-10049: Include RPC call_id in slow RPC logs KRPC log slow

[Impala-ASF-CR] IMPALA-11131: Replace 'cnd cwnd' with 'snd cwnd' in www/rpcz.tmpl

2022-02-17 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18249 Change subject: IMPALA-11131: Replace 'cnd_cwnd' with 'snd_cwnd' in www/rpcz.tmpl .. IMPALA-11131: Replace 'cnd_cwnd' with 'snd_cwnd'

[Impala-ASF-CR] IMPALA-10049: Include RPC call id in slow RPC logs

2022-02-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18243 ) Change subject: IMPALA-10049: Include RPC call_id in slow RPC logs .. Patch Set 3: Hit by flaky test_async_load (IMPALA-10999) -- To

[Impala-ASF-CR] IMPALA-11152: Remove dependence on symlink when rotating logs

2022-03-02 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18286 Change subject: IMPALA-11152: Remove dependence on symlink when rotating logs .. IMPALA-11152: Remove dependence on symlink when

[Impala-ASF-CR] IMPALA-11152: Remove dependence on symlink when rotating logs

2022-03-03 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18286 to look at the new patch set (#2). Change subject: IMPALA-11152: Remove dependence on symlink when rotating logs

[Impala-ASF-CR] IMPALA-11152: Remove dependence on symlink when rotating logs

2022-03-03 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18286 to look at the new patch set (#3). Change subject: IMPALA-11152: Remove dependence on symlink when rotating logs

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 3: (17 comments)

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-22 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#3). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-26 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#5). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 5: (9 comments)

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-31 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#9). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 9: (10 comments)

[Impala-ASF-CR] IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue

2022-03-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18366 ) Change subject: IMPALA-11204: Template implementation for OrcStringColumnReader::ReadValue .. Patch Set 5: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 9: (2 comments) There are two place that I'm still

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-01 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#10). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-03 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#11). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-03 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 12: > Patch Set 12: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#13). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 14: Patch set 14 modify test_file_parser.py to allow

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#14). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 13: Patch set 13 address test breakage due to 'RowsRead'

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-04 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#15). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-03 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#12). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-04-03 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 12: patch set 12 is a rebase -- To view, visit

[Impala-ASF-CR] IMPALA-11200: Avoid redundant "Codegen enabled" messages in profile

2022-04-05 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18385 ) Change subject: IMPALA-11200: Avoid redundant "Codegen enabled" messages in profile .. Patch Set 1: Hi Csaba, thanks for picking this

[Impala-ASF-CR] IMPALA-11204: template implementation for OrcStringColumnReader

2022-03-29 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18359 ) Change subject: IMPALA-11204: template implementation for OrcStringColumnReader .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-26 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#6). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-26 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#7). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 7: Patch set 7 fix clang-tidy errors. -- To view,

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-28 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-28 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#8). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-24 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18327 to look at the new patch set (#4). Change subject: IMPALA-11123: Optimize count(star) for ORC scans

[Impala-ASF-CR] IMPALA-11123: Optimize count(star) for ORC scans

2022-03-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18327 ) Change subject: IMPALA-11123: Optimize count(star) for ORC scans .. Patch Set 4: (1 comment) Patch set 4 is a rebase

[Impala-ASF-CR] IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server

2022-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18346 ) Change subject: IMPALA-11195 (part 1): Disable SSL session renegotiations in the web server .. Patch Set 2: Code-Review+1 -- To

[native-toolchain-CR] IMPALA-11195: Disable SSL session renegotiation

2022-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18347 ) Change subject: IMPALA-11195: Disable SSL session renegotiation .. Patch Set 1: Code-Review+1 Looks good! -- To view, visit

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-02-02 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#26) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-02-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 26: (10 comments)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-02-02 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#27) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-02-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 27: Patch set 27 is a rebase. -- To view, visit

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-02-03 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 27: (1 comment)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 25: (3 comments)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 25: (1 comment)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 25: (2 comments)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 25: (1 comment)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-02-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 29: > Patch Set 29: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-02-05 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 28: (1 comment) Thank you Quanlong and Csaba! Patch set 28 is a

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-02-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 28: > Patch Set 28: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-11107: Allow specifying footer size in IssueFooterRanges

2022-02-10 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18220 Change subject: IMPALA-11107: Allow specifying footer size in IssueFooterRanges .. IMPALA-11107: Allow specifying footer size in

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-02-05 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#28) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-18 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 21: (2 comments)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-18 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 21: (1 comment)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 23: (8 comments)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-21 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#23) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-11068: Add tuning flag to reduce scanner thread launch.

2022-01-06 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18126 Change subject: IMPALA-11068: Add tuning flag to reduce scanner thread launch. .. IMPALA-11068: Add tuning flag to reduce scanner thread

[Impala-ASF-CR] IMPALA-11068: Add tuning flag to reduce scanner thread launch.

2022-01-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18126 ) Change subject: IMPALA-11068: Add tuning flag to reduce scanner thread launch. .. Patch Set 1: > Patch Set 1: > > Should we look into

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

2022-01-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 ) Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0 .. Patch

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 20: (3 comments)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-19 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 21: (1 comment)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-19 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 22: (2 comments)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-19 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#22) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-24 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#24) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 24: Patch set 24 is a rebase. -- To view, visit

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 25: (1 comment) Patch set 25 add 7 counters and move 3 common

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2022-01-25 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#25) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-11239: Fix failure in test parquet count star optimization

2022-04-12 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18407 Change subject: IMPALA-11239: Fix failure in test_parquet_count_star_optimization .. IMPALA-11239: Fix failure in

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-05 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-05 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#11). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-11068: Add query option to reduce scanner thread launch.

2023-09-11 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Joe McDonnell, Csaba Ringhofer, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18126 to look at the new patch set (#2). Change subject: IMPALA-11068: Add query option to reduce scanner thread launch.

[Impala-ASF-CR] IMPALA-12444: Fix minimum parallelism bug in scan fragment

2023-09-11 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20475 Change subject: IMPALA-12444: Fix minimum parallelism bug in scan fragment .. IMPALA-12444: Fix minimum parallelism bug in scan fragment

[Impala-ASF-CR] IMPALA-12383: (Addendum) Use named params

2023-09-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20483 ) Change subject: IMPALA-12383: (Addendum) Use named params .. Patch Set 1: Code-Review+2 -- To view, visit

<    1   2   3   4   5   6   7   8   9   10   >