[Impala-ASF-CR] IMPALA-12594: Add flag to tune KrpcDataStreamSender mem estimate

2024-09-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21797 ) Change subject: IMPALA-12594: Add flag to tune KrpcDataStreamSender mem estimate .. Patch Set 2: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-12594: Add flag to tune KrpcDataStreamSender mem estimate

2024-09-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21797 ) Change subject: IMPALA-12594: Add flag to tune KrpcDataStreamSender mem estimate .. Patch Set 2: (3 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-12594: Add flag to tune KrpcDataStreamSender mem estimate

2024-09-13 Thread Csaba Ringhofer (Code Review)
Hello Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21797 to look at the new patch set (#2). Change subject: IMPALA-12594: Add flag to tune KrpcDataStreamSender mem estimate .

[Impala-ASF-CR] IMPALA-12594: Add flag to tune KrpcDataStreamSender mem estimate

2024-09-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21797 Change subject: IMPALA-12594: Add flag to tune KrpcDataStreamSender mem estimate .. IMPALA-12594: Add flag to tune KrpcDataStreamSende

[Impala-ASF-CR] IMPALA-13371: Avoid throwing exception in FindFileInPath()

2024-09-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21778 ) Change subject: IMPALA-13371: Avoid throwing exception in FindFileInPath() .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-13371: Avoid throwing exception in FindFileInPath()

2024-09-11 Thread Csaba Ringhofer (Code Review)
Hello Michael Smith, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21778 to look at the new patch set (#5). Change subject: IMPALA-13371: Avoid throwing exception in FindFileInPath() ...

[Impala-ASF-CR] WIP IMPALA-13374: impala-shell: do not trait missing profile as error

2024-09-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21783 Change subject: WIP IMPALA-13374: impala-shell: do not trait missing profile as error .. WIP IMPALA-13374: impala-shell: do not trait

[Impala-ASF-CR] IMPALA-13371: Avoid throwing exception in FindFileInPath()

2024-09-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21778 ) Change subject: IMPALA-13371: Avoid throwing exception in FindFileInPath() .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-13371: Avoid throwing exception in FindFileInPath()

2024-09-11 Thread Csaba Ringhofer (Code Review)
Hello Michael Smith, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21778 to look at the new patch set (#4). Change subject: IMPALA-13371: Avoid throwing exception in FindFileInPath() ...

[Impala-ASF-CR] IMPALA-13371: Avoid throwing exception in FindFileInPath()

2024-09-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21778 Change subject: IMPALA-13371: Avoid throwing exception in FindFileInPath() .. IMPALA-13371: Avoid throwing exception in FindFileInPath

[Impala-ASF-CR] IMPALA-7086: Cache timezone in * utc timestamp()

2024-09-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21735 ) Change subject: IMPALA-7086: Cache timezone in *_utc_timestamp() .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-7086: Cache timezone in * utc timestamp()

2024-09-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21735 ) Change subject: IMPALA-7086: Cache timezone in *_utc_timestamp() .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/21

[Impala-ASF-CR] IMPALA-11431: Avoid getting stats for synthetic column row id from HMS

2024-09-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21742 ) Change subject: IMPALA-11431: Avoid getting stats for synthetic column row__id from HMS .. Patch Set 5: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-11431: Avoid getting stats for synthetic column row id from HMS

2024-09-04 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21742 to look at the new patch set (#4). Change subject: IMPALA-11431: Avoid getting stats for synthetic column row__id from HMS

[Impala-ASF-CR] IMPALA-11431: Avoid getting stats for synthetic column row id from HMS

2024-09-04 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21742 to look at the new patch set (#2). Change subject: IMPALA-11431: Avoid getting stats for synthetic column row__id from HMS ...

[Impala-ASF-CR] IMPALA-7086 Cache timezone in * utc timestamp():

2024-09-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21735 ) Change subject: IMPALA-7086 Cache timezone in *_utc_timestamp(): .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/2

[Impala-ASF-CR] IMPALA-7086: Cache timezone name look ups

2024-08-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21735 ) Change subject: IMPALA-7086: Cache timezone name look ups .. Patch Set 1: (7 comments) Looks good! Few minor comments. http://gerr

[Impala-ASF-CR] IMPALA-11729: Speed up start-impala-cluster.py

2024-08-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21656 ) Change subject: IMPALA-11729: Speed up start-impala-cluster.py .. Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-11729: Speed up start-impala-cluster.py

2024-08-27 Thread Csaba Ringhofer (Code Review)
Hello Laszlo Gaal, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21656 to look at the new patch set (#6). Change subject: IMPALA-11729: Speed up start-impala-cluster.py .

[Impala-ASF-CR] IMPALA-13317: Enhance tpc sort key for wider name support

2024-08-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21708 ) Change subject: IMPALA-13317: Enhance tpc_sort_key for wider name support .. Patch Set 5: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-5443: Apply codegen rows threshold per node

2024-08-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21687 ) Change subject: IMPALA-5443: Apply codegen rows threshold per node .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-13302: Analyze new rewrite exprs

2024-08-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21679 ) Change subject: IMPALA-13302: Analyze new rewrite exprs .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-08-15 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21597 to look at the new patch set (#9). Change subject: IMPALA-13246: Smallify strings during broadcast exchange

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-08-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21597 ) Change subject: IMPALA-13246: Smallify strings during broadcast exchange .. Patch Set 7: Code-Review+2 (2 comments) Carrying +2 fro

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-08-14 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21597 to look at the new patch set (#7). Change subject: IMPALA-13246: Smallify strings during broadcast exchange

[Impala-ASF-CR] IMPALA-13293: Fix too long wait for initial catalog update

2024-08-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21655 ) Change subject: IMPALA-13293: Fix too long wait for initial catalog update .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13293: Fix too long wait for initial catalog update

2024-08-14 Thread Csaba Ringhofer (Code Review)
Hello Quanlong Huang, Zoltan Borok-Nagy, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21655 to look at the new patch set (#4). Change subject: IMPALA-13293: Fix too long wait for initial catalog update ...

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-08-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21597 ) Change subject: IMPALA-13246: Smallify strings during broadcast exchange .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-08-14 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21597 to look at the new patch set (#5). Change subject: IMPALA-13246: Smallify strings during broadcast exchange

[Impala-ASF-CR] IMPALA-12856: Event processor should ignore processing partition with empty partition values

2024-08-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21143 ) Change subject: IMPALA-12856: Event processor should ignore processing partition with empty partition values .. Patch Set 9: Code-Re

[Impala-ASF-CR] IMPALA-13293: Fix too long wait for initial catalog update

2024-08-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21655 ) Change subject: IMPALA-13293: Fix too long wait for initial catalog update .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-11729: Speed up start-impala-cluster.py

2024-08-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has removed a vote on this change. Change subject: IMPALA-11729: Speed up start-impala-cluster.py .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/21656 To unsubsc

[Impala-ASF-CR] IMPALA-11729: Speed up start-impala-cluster.py

2024-08-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21656 ) Change subject: IMPALA-11729: Speed up start-impala-cluster.py .. Patch Set 5: The latest jenkins run hit test_exchange_mem_usage_sc

[Impala-ASF-CR] IMPALA-11729: Speed up start-impala-cluster.py

2024-08-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21656 ) Change subject: IMPALA-11729: Speed up start-impala-cluster.py .. Patch Set 5: PS 3/4 only contain small change in logging/comments/

[Impala-ASF-CR] IMPALA-11729: Speed up start-impala-cluster.py

2024-08-13 Thread Csaba Ringhofer (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21656 to look at the new patch set (#5). Change subject: IMPALA-11729: Speed up start-impala-cluster.py ..

[Impala-ASF-CR] IMPALA-11729: Speed up start-impala-cluster.py

2024-08-13 Thread Csaba Ringhofer (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21656 to look at the new patch set (#4). Change subject: IMPALA-11729: Speed up start-impala-cluster.py ..

[Impala-ASF-CR] IMPALA-13293: Fix too long wait for initial catalog update

2024-08-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21655 ) Change subject: IMPALA-13293: Fix too long wait for initial catalog update .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-13293: Fix too long wait for initial catalog update

2024-08-12 Thread Csaba Ringhofer (Code Review)
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21655 to look at the new patch set (#3). Change subject: IMPALA-13293: Fix too long wait for initial catalog update ..

[Impala-ASF-CR] IMPALA-13293: Fix too long wait for initial catalog update

2024-08-12 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21655 to look at the new patch set (#2). Change subject: IMPALA-13293: Fix too long wait for initial catalog update .

[Impala-ASF-CR] IMPALA-11729: Speed up start-impala-cluster.py

2024-08-12 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21656 to look at the new patch set (#3). Change subject: IMPALA-11729: Speed up start-impala-cluster.py .. IMPAL

[Impala-ASF-CR] IMPALA-11729: Speed up start-impala-cluster.py

2024-08-12 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21656 to look at the new patch set (#2). Change subject: IMPALA-11729: Speed up start-impala-cluster.py .. IMPAL

[Impala-ASF-CR] IMPALA-13294: Add support for long polling to avoid client side wait

2024-08-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19205 ) Change subject: IMPALA-13294: Add support for long polling to avoid client side wait .. Patch Set 9: Code-Review+2 (3 comments) ht

[Impala-ASF-CR] WIP: quicker cluster startup

2024-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21656 Change subject: WIP: quicker cluster startup .. WIP: quicker cluster startup Change-Id: Ic4dd8c2bc7056443373ceb256a03ce562fea38a0 ---

[Impala-ASF-CR] WIP IMPALA-13293: Fix too long wait for initial catalog update

2024-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21655 Change subject: WIP IMPALA-13293: Fix too long wait for initial catalog update .. WIP IMPALA-13293: Fix too long wait for initial cata

[Impala-ASF-CR] IMPALA-12856: Event processor should ignore processing partition with empty partition values

2024-08-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21143 ) Change subject: IMPALA-12856: Event processor should ignore processing partition with empty partition values .. Patch Set 8: (1 com

[Impala-ASF-CR] IMPALA-13276: Revise the documentation of 'RUNTIME FILTER WAIT TIME MS'

2024-08-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21644 ) Change subject: IMPALA-13276: Revise the documentation of 'RUNTIME_FILTER_WAIT_TIME_MS' .. Patch Set 5: Code-Review+2 No more sugge

[Impala-ASF-CR] IMPALA-13276: Revise the documentation of 'RUNTIME FILTER WAIT TIME MS'

2024-08-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21644 ) Change subject: IMPALA-13276: Revise the documentation of 'RUNTIME_FILTER_WAIT_TIME_MS' .. Patch Set 4: Thanks, it looks good to me

[Impala-ASF-CR] IMPALA-13276: Revise the documentation of 'RUNTIME FILTER WAIT TIME MS'

2024-08-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21644 ) Change subject: IMPALA-13276: Revise the documentation of 'RUNTIME_FILTER_WAIT_TIME_MS' .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] WIP: Regression test for IMPALA-13272 (currently crashes)

2024-08-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has abandoned this change. ( http://gerrit.cloudera.org:8080/21641 ) Change subject: WIP: Regression test for IMPALA-13272 (currently crashes) .. Abandoned Abanding as the fix, https://gerrit.cloudera.org/#/c/2

[Impala-ASF-CR] IMPALA-13276: Revise the documentation of 'RUNTIME FILTER WAIT TIME MS'

2024-08-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21644 ) Change subject: IMPALA-13276: Revise the documentation of 'RUNTIME_FILTER_WAIT_TIME_MS' .. Patch Set 3: (2 comments) Thanks for ad

[Impala-ASF-CR] WIP: Regression test for IMPALA-13272 (currently crashes)

2024-08-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21641 Change subject: WIP: Regression test for IMPALA-13272 (currently crashes) .. WIP: Regression test for IMPALA-13272 (currently crashes)

[Impala-ASF-CR] IMPALA-13077: Fix selectivity estimation for SEMI JOIN

2024-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21516 ) Change subject: IMPALA-13077: Fix selectivity estimation for SEMI JOIN .. Patch Set 7: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] Long polling to avoid client side wait

2024-07-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19205 ) Change subject: Long polling to avoid client side wait .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/19205/6//CO

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-07-26 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21597 to look at the new patch set (#4). Change subject: IMPALA-13246: Smallify strings during broadcast exchange

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21597 ) Change subject: IMPALA-13246: Smallify strings during broadcast exchange .. Patch Set 3: Verified-1 > The jenkins run failed with an

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has removed a vote on this change. Change subject: IMPALA-13246: Smallify strings during broadcast exchange .. Removed Verified+1 by Csaba Ringhofer -- To view, visit http://gerrit.cloudera.org:8080/21597 To uns

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21597 ) Change subject: IMPALA-13246: Smallify strings during broadcast exchange .. Patch Set 3: Verified+1 The jenkins run failed with an u

[Impala-ASF-CR] IMPALA-13077: Fix selectivity estimation for SEMI JOIN

2024-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21516 ) Change subject: IMPALA-13077: Fix selectivity estimation for SEMI JOIN .. Patch Set 5: Code-Review+1 (2 comments) I would prefer to

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-07-19 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21597 to look at the new patch set (#3). Change subject: IMPALA-13246: Smallify strings during broadcast exchange

[Impala-ASF-CR] IMPALA-13246: Smallify strings during broadcast exchange

2024-07-19 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21597 to look at the new patch set (#2). Change subject: IMPALA-13246: Smallify strings during broadcast exchange

[Impala-ASF-CR] Make GetOperationStatus/get state wait up to 5 seconds for completion

2024-07-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19205 ) Change subject: Make GetOperationStatus/get_state wait up to 5 seconds for completion .. Patch Set 4: (2 comments) http://gerrit.c

[Impala-ASF-CR] WIP: smallify during broadcast exchange

2024-07-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21597 Change subject: WIP: smallify during broadcast exchange .. WIP: smallify during broadcast exchange note that there is a very similar

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 ) Change subject: IMPALA-13194: Fast-serialize position delete records .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 ) Change subject: IMPALA-13194: Fast-serialize position delete records .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 ) Change subject: IMPALA-13194: Fast-serialize position delete records .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 ) Change subject: IMPALA-13194: Fast-serialize position delete records .. Patch Set 2: Code-Review+1 (4 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode

2024-07-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21571 ) Change subject: IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode

2024-07-15 Thread Csaba Ringhofer (Code Review)
Hello Yida Wu, Zoltan Borok-Nagy, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21571 to look at the new patch set (#5). Change subject: IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode ..

[Impala-ASF-CR] POC: Add queuing to broadcast data sender

2024-07-12 Thread Csaba Ringhofer (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21579 to look at the new patch set (#4). Change subject: POC: Add queuing to broadcast data sender ...

[Impala-ASF-CR] POC: Add queuing to broadcast data sender

2024-07-12 Thread Csaba Ringhofer (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21579 to look at the new patch set (#3). Change subject: POC: Add queuing to broadcast data sender ...

[Impala-ASF-CR] IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode

2024-07-12 Thread Csaba Ringhofer (Code Review)
Hello Yida Wu, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21571 to look at the new patch set (#4). Change subject: IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode .

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 ) Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s .. Patch Set 10: Code-Review+2 (3

[Impala-ASF-CR] POC: Add queuing to broadcast data sender

2024-07-12 Thread Csaba Ringhofer (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21579 to look at the new patch set (#2). Change subject: POC: Add queuing to broadcast data sender ...

[Impala-ASF-CR] POC: Add queuing to broadcast data sender

2024-07-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21579 ) Change subject: POC: Add queuing to broadcast data sender .. Patch Set 1: (1 comment) The patch is in POC state and not reallyready

[Impala-ASF-CR] POC: Add queuing to broadcast data sender

2024-07-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21579 Change subject: POC: Add queuing to broadcast data sender .. POC: Add queuing to broadcast data sender Change-Id: Ibe3d01fada31f1b48d

[Impala-ASF-CR] IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode

2024-07-11 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21571 to look at the new patch set (#3). Change subject: IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode .

[Impala-ASF-CR] IMPALA-13194: Fast-serialize position delete records

2024-07-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 ) Change subject: IMPALA-13194: Fast-serialize position delete records .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] WIP: IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode

2024-07-11 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21571 to look at the new patch set (#2). Change subject: WIP: IMPALA-13209: Optimize ConvertRowBatchTime in ExchangeNode

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 ) Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s .. Patch Set 9: Code-Review+1 (3 c

[Impala-ASF-CR] IMPALA-13203: Rewrite 'id = 0 OR false' as expected

2024-07-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21568 ) Change subject: IMPALA-13203: Rewrite 'id = 0 OR false' as expected .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-13193: RuntimeFilter on parquet dictionary should evaluate NULL values

2024-07-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21566 ) Change subject: IMPALA-13193: RuntimeFilter on parquet dictionary should evaluate NULL values .. Patch Set 5: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-12709: Add support for hierarchical metastore event processing

2024-07-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 ) Change subject: IMPALA-12709: Add support for hierarchical metastore event processing .. Patch Set 20: (8 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-12947: Implement Calcite Planner Union and Value RelNodes

2024-07-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21211 ) Change subject: IMPALA-12947: Implement Calcite Planner Union and Value RelNodes .. Patch Set 14: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-13193: RuntimeFilter on parquet dictionary should evaluate NULL values

2024-07-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21566 ) Change subject: IMPALA-13193: RuntimeFilter on parquet dictionary should evaluate NULL values .. Patch Set 4: (2 comments) Thanks

[Impala-ASF-CR] IMPALA-13203: Rewrite 'id = 0 OR false' as expected

2024-07-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21568 ) Change subject: IMPALA-13203: Rewrite 'id = 0 OR false' as expected .. Patch Set 1: Code-Review+2 looks great, thanks for fixing thi

[Impala-ASF-CR] IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s

2024-07-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 ) Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s .. Patch Set 8: (3 comments) look

[Impala-ASF-CR] IMPALA-12947: Implement Calcite Planner Union and Value RelNodes

2024-07-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21211 ) Change subject: IMPALA-12947: Implement Calcite Planner Union and Value RelNodes .. Patch Set 13: (2 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-9441,IMPALA-13170: Ops listing dbs/tables should handle db not exists

2024-06-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21546 ) Change subject: IMPALA-9441,IMPALA-13170: Ops listing dbs/tables should handle db not exists .. Patch Set 2: Code-Review+1 -- To v

[Impala-ASF-CR] IMPALA-9441,IMPALA-13170: Ops listing dbs/tables should handle db not exists

2024-06-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21546 ) Change subject: IMPALA-9441,IMPALA-13170: Ops listing dbs/tables should handle db not exists .. Patch Set 1: (2 comments) http://g

[Impala-ASF-CR] IMPALA-6311: Lower max filter error rate to 10%

2024-06-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21552 ) Change subject: IMPALA-6311: Lower max_filter_error_rate to 10% .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-13077: Fix selectivity estimation for SEMI JOIN

2024-06-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21516 ) Change subject: IMPALA-13077: Fix selectivity estimation for SEMI JOIN .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-12940: Added filtering capability for Calcite planner

2024-06-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21498 ) Change subject: IMPALA-12940: Added filtering capability for Calcite planner .. Patch Set 2: Code-Review+1 I also went through the p

[Impala-ASF-CR] IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu

2024-06-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21492 ) Change subject: IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu .. IMPALA-12370: Allow converting time

[Impala-ASF-CR] IMPALA-12216: Print timestamp for impala-shell errors

2024-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 ) Change subject: IMPALA-12216: Print timestamp for impala-shell errors .. Patch Set 9: Code-Review+1 (2 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu

2024-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21492 ) Change subject: IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu .. Patch Set 9: (4 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu

2024-06-18 Thread Csaba Ringhofer (Code Review)
Hello Alexey Serbin, Riza Suminto, Ashwani Raina, Zihao Ye, Peter Rozsa, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21492 to look at the new patch set (#9). Change subject: IMPALA-12370: Allow converting timestamps to UTC when wr

[Impala-ASF-CR] IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu

2024-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21492 ) Change subject: IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu .. Patch Set 8: The build failure seems to be

[Impala-ASF-CR] IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu

2024-06-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21492 ) Change subject: IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu .. Patch Set 8: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu

2024-06-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21492 ) Change subject: IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu .. Patch Set 3: (14 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12370: Allow converting timestamps to UTC when writing to Kudu

2024-06-17 Thread Csaba Ringhofer (Code Review)
Hello Alexey Serbin, Riza Suminto, Ashwani Raina, Zihao Ye, Peter Rozsa, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21492 to look at the new patch set (#8). Change subject: IMPALA-12370: Allow converting timestamps to UTC when wr

  1   2   3   4   5   6   7   8   9   10   >