[Impala-ASF-CR] IMPALA-4155: Update default partition when table is altered

2016-10-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4155: Update default partition when table is altered .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4414 To

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4414 to look at the new patch set (#11). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4327 to look at the new patch set (#8). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739:

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4728/2/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-3420: use gold by default

2016-10-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3420: use gold by default .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4751/2//COMMIT_MSG Commit Message: Line 15: Did ASAN and debug

[Impala-ASF-CR] IMPALA-4155: Update default partition when table is altered

2016-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4155: Update default partition when table is altered .. Patch Set 4: Code-Review+2 Nice! -- To view, visit http://gerrit.cloudera.org:8080/4750 To

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 7: (16 comments) http://gerrit.cloudera.org:8080/#/c/4047/7//COMMIT_MSG Commit Message: Line 18:

[Impala-ASF-CR] IMPALA-4155: Update default partition when table is altered

2016-10-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4155: Update default partition when table is altered .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/4750/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4155: Update default partition when table is altered

2016-10-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4155: Update default partition when table is altered .. IMPALA-4155: Update default partition when table is altered If the table format is changed by

[Impala-ASF-CR] IMPALA-4155: Update default partition when table is altered

2016-10-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4155: Update default partition when table is altered .. IMPALA-4155: Update default partition when table is altered If the table format is changed by

[Impala-ASF-CR] IMPALA-3420: use gold by default

2016-10-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3420: use gold by default .. IMPALA-3420: use gold by default Also pass the flag that enables ld.gold directly to the compiler. This is understood by both

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 6: Code-Review+2 Carry Dan's +2 forward. -- To view, visit

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-18 Thread Michael Ho (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4651 to look at the new patch set (#6). Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.

2016-10-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4582 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-10-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/4633/6//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4155: Update default partition when table is altered

2016-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4155: Update default partition when table is altered .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/4750/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4155: Update default partition when table is altered

2016-10-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4155: Update default partition when table is altered .. IMPALA-4155: Update default partition when table is altered If the table format is changed by

[Impala-ASF-CR] IMPALA-3802: Update default partition when table is altered

2016-10-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/4750 Change subject: IMPALA-3802: Update default partition when table is altered .. IMPALA-3802: Update default partition when table is

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4414 to look at the new patch set (#10). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 9: Code-Review+1 (9 comments) Carry mikeb's +1 for python tests.

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-10-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 8: (11 comments)

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-10-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 9: Code-Review+1 Carry +1. -- To view, visit http://gerrit.cloudera.org:8080/4371 To

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-10-18 Thread Sailesh Mukil (Code Review)
Hello Henry Robinson, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4371 to look at the new patch set (#9). Change subject: IMPALA-3823: Add timer to measure Parquet footer reads

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node .. Patch Set 4: Code-Review+2 Thanks for fixing that. Can you just

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 5: bq: I'm a bit worried about the compatibility of this change: if

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-18 Thread anujphadke (Code Review)
Hello Matthew Jacobs, Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4639 to look at the new patch set (#4). Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 2: (21 comments) http://gerrit.cloudera.org:8080/#/c/4745/2//COMMIT_MSG Commit Message: Line 11:

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 5: (2 comments) I'm a bit worried about the compatibility of this change: if

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-2521: Add clustered hint to insert statements .. IMPALA-2521: Add clustered hint to insert statements This change introduces a clustered/noclustered hint for

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4728/2/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-10-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 8: I can look at this once you address Henry's comments. -- To view, visit

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4651/4/be/src/exprs/scalar-fn-call.cc File

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 5: Code-Review+2 Please just put back a TODO for that timestamp codegen stuff. -- To view,

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 9: (3 comments) I'll wait for the next change set and then do a final round over

[Impala-ASF-CR](hadoop-next) IMPALA-4277: remove references for unsupported s3/s3n connectors

2016-10-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors .. IMPALA-4277: remove references for unsupported s3/s3n connectors We only support

[Impala-ASF-CR](hadoop-next) IMPALA-4277: remove references for unsupported s3/s3n connectors

2016-10-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit

[Impala-ASF-CR](hadoop-next) IMPALA-4277: remove references for unsupported s3/s3n connectors

2016-10-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors .. Patch Set 1: (2 comments)

[Impala-ASF-CR](hadoop-next) IMPALA-4277: remove references for unsupported s3/s3n connectors

2016-10-18 Thread Tim Armstrong (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4748 to look at the new patch set (#2). Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 7: (10 comments) Responses to comments. Doing another round now.

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. IMPALA-4134,IMPALA-3704: Kudu INSERT improvements 1.) IMPALA-4134: Use Kudu AUTO FLUSH Improves performance

[Impala-ASF-CR](hadoop-next) IMPALA-4277: don't use deprecated s3:// filesystem

2016-10-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4748 Change subject: IMPALA-4277: don't use deprecated s3:// filesystem .. IMPALA-4277: don't use deprecated s3:// filesystem Support was

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: Code-Review+1 (2 comments) Carry Michael's +1

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node .. Patch Set 3: -Code-Review (1 comment)

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#9). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 5: (4 comments) A few minor clarifications.

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4720/2/bin/impala-config.sh

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 6: (1 comment)

[Impala-ASF-CR](hadoop-next) IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API

2016-10-18 Thread Tim Armstrong (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4701 to look at the new patch set (#2). Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API

[Impala-ASF-CR](hadoop-next) IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API

2016-10-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API .. IMPALA-4277: temporary hack to avoid compile errors for HDFS block

[Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. IMPALA-4277: bump Hadoop component versions except for Hadoop itself The Hive

[Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. Patch Set 3: Code-Review+2 Verified+1 Rebase. Confirmed that it compiles, but can't run

[Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-18 Thread Tim Armstrong (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4698 to look at the new patch set (#3). Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-18 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#17). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-18 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#17). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-18 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (3 comments) > Attila, any updates on this one? Let me know

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-18 Thread Charlie Helin (Code Review)
Charlie Helin has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4720/2/bin/impala-config.sh

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-10-18 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has abandoned this change. Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. Abandoned Abandoning the review until I can work on it again. -- To view, visit http://gerrit.cloudera.org:8080/4527

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

2016-10-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module .. IMPALA-2905: Move QueryResultSet implementations into separate module This

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

2016-10-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4736 To

[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value

2016-10-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value .. IMPALA-4253:

[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value

2016-10-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 7: (63 comments) Still a few minor asks to go through (e.g. add JIRA

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#8). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-18 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4651 to look at the new patch set (#5). Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() ..

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/4651/4/be/src/exec/exec-node.h File

[Impala-ASF-CR] IMPALA-4310: Make push to asf.py respect --apache remote

2016-10-18 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4310: Make push_to_asf.py respect --apache_remote .. IMPALA-4310: Make push_to_asf.py respect --apache_remote Change-Id:

[Impala-ASF-CR] PREVIEW IMPALA-2521: Add clustered hint to insert statements

2016-10-18 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: PREVIEW IMPALA-2521: Add clustered hint to insert statements .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build

2016-10-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2916: Add warning to query profile if debug build .. IMPALA-2916: Add warning to query profile if debug build Change-Id:

[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build

2016-10-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2916: Add warning to query profile if debug build .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4588 To unsubscribe,

[Impala-ASF-CR] IMPALA-4310: Make push to asf.py respect --apache remote

2016-10-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4310: Make push_to_asf.py respect --apache_remote .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4747 To unsubscribe,

[Impala-ASF-CR] IMPALA-4310: Make push to asf.py respect --apache remote

2016-10-18 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4747 Change subject: IMPALA-4310: Make push_to_asf.py respect --apache_remote .. IMPALA-4310: Make push_to_asf.py respect --apache_remote