[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 1: (11 comments)

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-03-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4883: Union Codegen .. Patch Set 4: Restructured the code a bit in patch 4 vs 3, and fixed some minor comment issues. -- To view, visit

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-03-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4883: Union Codegen .. IMPALA-4883: Union Codegen For each non-passthrough child of the Union node, codegen the loop that does per row tuple

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-03-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4883: Union Codegen .. IMPALA-4883: Union Codegen For each non-passthrough child of the Union node, codegen the loop that does per row tuple

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Hello Bharath Vissapragada, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6503 to look at the new patch set (#6). Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Hello Bharath Vissapragada, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6503 to look at the new patch set (#5). Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 4: (2 comments) I also worked out another alternative - but then noticed the Open Group

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-03-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4883: Union Codegen .. IMPALA-4883: Union Codegen For each non-passthrough child of the Union node, codegen the loop that does per row tuple

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-03-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4883: Union Codegen .. IMPALA-4883: Union Codegen For each non-passthrough child of the Union node, codegen the loop that does per row tuple

[Impala-ASF-CR] IMPALA-4883: Union Codegen

2017-03-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4883: Union Codegen .. IMPALA-4883: Union Codegen For each non-passthrough child of the Union node, codegen the loop that does per row tuple

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4883: Implement Codegen for Union .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/6459/2/be/src/exec/union-node-ir.cc File

[Impala-ASF-CR] IMPALA-4889: Use client sidecars for Thrift RPCs

2017-03-29 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6473/1/be/src/rpc/rpc.h File

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4883: Implement Codegen for Union .. IMPALA-4883: Implement Codegen for Union For each non-passthrough child of the Union node, codegen the loop that

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4883: Implement Codegen for Union .. IMPALA-4883: Implement Codegen for Union For each non-passthrough child of the Union node, codegen

[Impala-ASF-CR] IMPALA-4883: Implement Codegen for Union

2017-03-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-4883: Implement Codegen for Union .. IMPALA-4883: Implement Codegen for Union For each non-passthrough child of the Union node, codegen

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#15). Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. IMPALA-3203: Part 2: per-core free lists in buffer pool Add per-core lists of clean pages and free

[Impala-ASF-CR] IMPALA-4114: Port BufferedBlockMgr tests to buffer pool

2017-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool .. IMPALA-4114: Port BufferedBlockMgr tests to buffer pool BufferedBlockMgr had a number of interesting

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. Patch Set 14: (24 comments)

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() .. IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6502 To

[Impala-ASF-CR] IMPALA-4226, IMPALA-4227: Bump Breakpad version

2017-03-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6513 Change subject: IMPALA-4226, IMPALA-4227: Bump Breakpad version .. IMPALA-4226, IMPALA-4227: Bump Breakpad version Change-Id:

[native-toolchain-CR] Bump Kudu version to 16dd6e4 and remove historical versions

2017-03-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 16dd6e4 and remove historical versions .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6509 To unsubscribe,

[Impala-ASF-CR] IMPALA-4889: Use client sidecars for Thrift RPCs

2017-03-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/6473/1/be/src/rpc/rpc.h File

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 4: Code-Review+2 (2 comments) lgtm, thanks for working through the alternatives.

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 4: Code-Review+1 I prefer the vector approach. Looks easier to follow. -- To view,

[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines

2017-03-29 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#2). Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: [WIP] improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will

[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines

2017-03-29 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#3). Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: [WIP] improve docs building guidelines Move docs/generatingImpalaDoc.md to docs/README.md. This will

[Impala-ASF-CR] IMPALA-5140: improve docs building guidelines

2017-03-29 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/6512 Change subject: IMPALA-5140: improve docs building guidelines .. IMPALA-5140: improve docs building guidelines Move

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-03-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 2: (20 comments) Thank you for your Review. Please see my comments and PS3.

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-03-29 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-4166: Add SORT BY sql clause .. IMPALA-4166: Add SORT BY sql clause This change adds support for adding SORT BY (...) clauses to CREATE TABLE and ALTER TABLE

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() .. Patch Set 3: > Before we were assigning the scoped_ptr then initialising the > Ah I didn't

[Impala-ASF-CR] Remove caching of llvm StructType by TupleDescriptor::GetLlvmStruct().

2017-03-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Remove caching of llvm StructType by TupleDescriptor::GetLlvmStruct(). .. Patch Set 1: Code-Review+2 Good to see this go away if it doesn't help perf. -- To

[Impala-ASF-CR] Remove caching of llvm StructType by TupleDescriptor::GetLlvmStruct().

2017-03-29 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: Remove caching of llvm StructType by TupleDescriptor::GetLlvmStruct(). .. Patch Set 1: (1 comment) I'm going to do a perf run to make sure this doesn't

[Impala-ASF-CR] Remove caching of llvm StructType by TupleDescriptor::GetLlvmStruct().

2017-03-29 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new change for review. http://gerrit.cloudera.org:8080/6511 Change subject: Remove caching of llvm StructType by TupleDescriptor::GetLlvmStruct(). .. Remove caching of llvm StructType by

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() .. Patch Set 3: Agree that this could probably be improved if we reworked how

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() .. Patch Set 3: Before we were assigning the scoped_ptr then initialising the memory, so the

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() .. Patch Set 3: Code-Review+2 This is fine, though it would be nice if

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 4: I'll leave it up to the reviewers to decide which of 3/4 is cleanest. Maybe there is a C++11

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Tim Armstrong (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6502 to look at the new patch set (#3). Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. IMPALA-5123: Fix ASAN use after free in timezone_db The issue is that the string temporary returned by

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-03-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. Patch Set 14: (24 comments) Haven't made it all the way, but probably worth getting this first set of

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 3: That turned out a little uglier than expected. I think a vector is going to be the cleanest.

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. IMPALA-5123: Fix ASAN use after free in timezone_db The issue is that the string temporary returned by

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6503/1/be/src/exprs/timezone_db.cc File

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 2: Doesn't this still have the leaking issue? -- To view, visit

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6510 Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. IMPALA-5137: pt1, Refactor TimestampValue constructors In

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. IMPALA-5123: Fix ASAN use after free in timezone_db The issue is that the string temporary returned by

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() .. Patch Set 2: (1 comment)

[native-toolchain-CR] Bump Kudu version to 16dd6e4 and remove historical versions

2017-03-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6509 Change subject: Bump Kudu version to 16dd6e4 and remove historical versions .. Bump Kudu version to 16dd6e4 and remove historical

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 10: Sorry, didn't mean to update this, not ready for re-review. -- To view, visit

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#10). Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. IMPALA-3742: partitions DMLs for Kudu tables Bulk DMLs (INSERT, UPSERT, UPDATE, and DELETE) for Kudu are

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#10). Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. IMPALA-3742: partitions DMLs for Kudu tables Bulk DMLs (INSERT, UPSERT, UPDATE, and DELETE) for Kudu are

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() .. Patch Set 1: Code-Review+1 (5 comments) Carry +1

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-29 Thread Tim Armstrong (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6502 to look at the new patch set (#2). Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting()