[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5927: Fix enable_distcc for zsh .. IMPALA-5927: Fix enable_distcc for zsh enable_distcc didn't work on zsh anymore since it relies on

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5927: Fix enable_distcc for zsh .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8049 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5416: Fix an impala-shell command recursion bug

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5416: Fix an impala-shell command recursion bug .. Patch Set 5: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1242/ It seems to be

[Impala-ASF-CR] IMPALA-5416: Fix an impala-shell command recursion bug

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5416: Fix an impala-shell command recursion bug .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1242/

[Impala-ASF-CR] Remove unused MemPool::peak allocated bytes

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Remove unused MemPool::peak_allocated_bytes_ .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1245/ -- To view, visit

[Impala-ASF-CR] Remove unused MemPool::peak allocated bytes

2017-09-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Remove unused MemPool::peak_allocated_bytes_ .. Patch Set 1: Code-Review+2 Nice! -- To view, visit http://gerrit.cloudera.org:8080/8114 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5966: Fix the result file location of PlannerTest .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5966: Fix the result file location of PlannerTest .. IMPALA-5966: Fix the result file location of PlannerTest The Plannertest result files should be written

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-20 Thread Tim Wood (Code Review)
Tim Wood has posted comments on this change. Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 1: @mmokhtar Results of elapsed-time measurements of partial and full (this

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-09-20 Thread anujphadke (Code Review)
Hello Impala Public Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7245 to look at the new patch set (#10). Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest

2017-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5966: Fix the result file location of PlannerTest .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4939, IMPALA-4940: Decimal V2 multiplication

2017-09-20 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication .. Patch Set 5: Have we ever tried using SSE/AVX for multiplication? It should be possible to avoid using

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#9). Change subject: IMPALA-5425: Add test for validating input when setting query options .. IMPALA-5425: Add test for validating input when setting query options This patch adds

[Impala-ASF-CR] Remove unused MemPool::peak allocated bytes

2017-09-20 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: Remove unused MemPool::peak_allocated_bytes_ .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8114 To unsubscribe, visit

[Impala-ASF-CR] Remove unused MemPool::peak allocated bytes

2017-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/8114 Change subject: Remove unused MemPool::peak_allocated_bytes_ .. Remove unused MemPool::peak_allocated_bytes_ The value is not used for

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5966: Fix the result file location of PlannerTest

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/8113 Change subject: IMPALA-5966: Fix the result file location of PlannerTest .. IMPALA-5966: Fix the result file location of PlannerTest The

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 8: (4 comments) I'm generally ok with this patch. I think there are places

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/9//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters

2017-09-20 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3360: Codegen inserting into runtime filters .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5954: Set DO NOT UPDATE STATS in alterTable() RPCs to HMS.

2017-09-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5954: Set DO_NOT_UPDATE_STATS in alterTable() RPCs to HMS. .. Patch Set 2: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/9//COMMIT_MSG Commit Message: PS9,

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5927: Fix enable_distcc for zsh .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1243/ -- To view, visit

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5927: Fix enable_distcc for zsh .. Patch Set 5: Code-Review+2 Rebased, carrying Tim's +2. -- To view, visit http://gerrit.cloudera.org:8080/8049 To

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-09-20 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec .. Patch Set 8: Ran the core tests and the exhaustive tests with the change and

[Impala-ASF-CR] IMPALA-5250: Unify decompressor output length semantics

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5250: Unify decompressor output_length semantics .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8030/3//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-5250: Unify decompressor output length semantics

2017-09-20 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8030 to look at the new patch set (#4). Change subject: IMPALA-5250: Unify decompressor output_length semantics ..

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5927: Fix enable_distcc for zsh .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1241/ -- To view,

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-09-20 Thread anujphadke (Code Review)
Hello Impala Public Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7245 to look at the new patch set (#8). Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

[Impala-ASF-CR] IMPALA-5250: Unify decompressor output length semantics

2017-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5250: Unify decompressor output_length semantics .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/8030/3//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8102/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing

2017-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5250: Unify decompressor output length semantics

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-5250: Unify decompressor output_length semantics .. IMPALA-5250: Unify decompressor output_length semantics This patch makes the semantics of the

[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing

2017-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5954: Set DO NOT UPDATE STATS in alterTable() RPCs to HMS.

2017-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5954: Set DO_NOT_UPDATE_STATS in alterTable() RPCs to HMS. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5954: Set DO NOT UPDATE STATS in alterTable() RPCs to HMS.

2017-09-20 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-5954: Set DO_NOT_UPDATE_STATS in alterTable() RPCs to HMS. .. IMPALA-5954: Set DO_NOT_UPDATE_STATS in alterTable() RPCs to HMS. This improves an existing

[Impala-ASF-CR] IMPALA-5416: Fix an impala-shell command recursion bug

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5416: Fix an impala-shell command recursion bug .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1242/ -- To

[Impala-ASF-CR] IMPALA-5416: Fix an impala-shell command recursion bug

2017-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5416: Fix an impala-shell command recursion bug .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8063 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-20 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8102/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5416: Fix an impala-shell command recursion bug

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5416: Fix an impala-shell command recursion bug .. Patch Set 5: Code is rebased. Please build again. -- To view, visit

[Impala-ASF-CR] IMPALA-5416: Fix an impala-shell command recursion bug

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5416: Fix an impala-shell command recursion bug .. Patch Set 4: > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1238/ The build failed

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 7: (11 comments)

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-20 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). Change subject: IMPALA-5425: Add test for validating input when setting query options .. IMPALA-5425: Add test for validating input when setting query options This patch adds

[Impala-ASF-CR] IMPALA-5954: Set DO NOT UPDATE STATS in alterTable() RPCs to HMS.

2017-09-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5954: Set DO_NOT_UPDATE_STATS in alterTable() RPCs to HMS. .. Patch Set 1: -Code-Review (2 comments) Sorry, got a couple more questions after

[Impala-ASF-CR] IMPALA-5955: Use totalSize tblproperty instead of rawDataSize.

2017-09-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5955: Use totalSize tblproperty instead of rawDataSize. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8110 To

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/9//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5949: fix test exchange small delay failure

2017-09-20 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5949: fix test_exchange_small_delay failure .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8111 To

[Impala-ASF-CR] IMPALA-5954: Set DO NOT UPDATE STATS in alterTable() RPCs to HMS.

2017-09-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5954: Set DO_NOT_UPDATE_STATS in alterTable() RPCs to HMS. .. Patch Set 1: Code-Review+1 Should we add more alter scenarios to "alter-table.test"

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: (9 comments) If you haven't already, please file a doc jira to update the docs based on

[Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

2017-09-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8102/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters

2017-09-20 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3360: Codegen inserting into runtime filters .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/8029/3/be/src/exec/CMakeLists.txt

[Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters

2017-09-20 Thread Thomas Tauber-Marshall (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8029 to look at the new patch set (#5). Change subject: IMPALA-3360: Codegen inserting into runtime filters ..

[Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters

2017-09-20 Thread Thomas Tauber-Marshall (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8029 to look at the new patch set (#4). Change subject: IMPALA-3360: Codegen inserting into runtime filters ..

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5927: Fix enable_distcc for zsh .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1241/ -- To view, visit

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 7: The really nice thing about the patch is that all the tests are all

[Impala-ASF-CR] IMPALA-4670: Introduces RpcMgr class

2017-09-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4670: Introduces RpcMgr class .. Patch Set 6: (14 comments) http://gerrit.cloudera.org:8080/#/c/7901/6/be/src/exec/kudu-util.h File be/src/exec/kudu-util.h:

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh

2017-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5927: Fix enable_distcc for zsh .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8049 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5954: Set DO NOT UPDATE STATS in alterTable() RPCs to HMS.

2017-09-20 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/8112 Change subject: IMPALA-5954: Set DO_NOT_UPDATE_STATS in alterTable() RPCs to HMS. .. IMPALA-5954: Set DO_NOT_UPDATE_STATS in alterTable()

[Impala-ASF-CR] IMPALA-5949: fix test exchange small delay failure

2017-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/8111 Change subject: IMPALA-5949: fix test_exchange_small_delay failure .. IMPALA-5949: fix test_exchange_small_delay failure Avoid running

[Impala-ASF-CR] IMPALA-5955: Use totalSize tblproperty instead of rawDataSize.

2017-09-20 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/8110 Change subject: IMPALA-5955: Use totalSize tblproperty instead of rawDataSize. .. IMPALA-5955: Use totalSize tblproperty instead of

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options .. Patch Set 7: (8 comments)

[Impala-ASF-CR] IMPALA-5920: addendum - add missing RAT check

2017-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: addendum - add missing RAT check .. Patch Set 2: Thanks for fixing this. @Alex The test job had a known spurious failure cleaning up the

[Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar

2017-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar .. Patch Set 7: > The rat-check job actually failed because of a file introduced here > - it

[Impala-ASF-CR] IMPALA-5920: addendum - add missing RAT check

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5920: addendum - add missing RAT check .. IMPALA-5920: addendum - add missing RAT check Change-Id:

[Impala-ASF-CR] IMPALA-5920: addendum - add missing RAT check

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5920: addendum - add missing RAT check .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8108 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5895: clean up runtime profile lifecycle

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5895: clean up runtime profile lifecycle .. IMPALA-5895: clean up runtime profile lifecycle Require callers to explicitly stop counter

[Impala-ASF-CR] IMPALA-5895: clean up runtime profile lifecycle

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5895: clean up runtime profile lifecycle .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8069 To unsubscribe,

[Impala-ASF-CR] IMPALA-5920: addendum - add missing RAT check

2017-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5920: addendum - add missing RAT check .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1240/ -- To view,

[Impala-ASF-CR] IMPALA-5920: addendum - add missing RAT check

2017-09-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5920: addendum - add missing RAT check .. Patch Set 1: Code-Review+2 Looks simple enough to me. Hence +2'ing. -- To view, visit

[Impala-ASF-CR] IMPALA-3516: Avoid writing to /tmp in testing

2017-09-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5920: addendum - add missing RAT check

2017-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5920: addendum - add missing RAT check .. Patch Set 1: Matt manually submitted it thinking it was a spurious failure: