[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. Patch Set 3: (5 comments) pretty much done http://gerrit.cloudera.org:8080/#/c/7706/3/fe/

[Impala-ASF-CR] IMPALA-3208: max row size option

2017-08-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3208: max_row_size option .. Patch Set 14: (3 comments) FE changes look good to me. Thanks for giving me a chance to look. Please go ahead and merge. http:

[Impala-ASF-CR] [PREVIEW] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-08-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: [PREVIEW] IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 1: (22 comments) Very helpful explanation in the commit msg! Approach looks s

[Impala-ASF-CR] IMPALA-5798: ASAN use-after-poison in Parquet decoder

2017-08-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5798: ASAN use-after-poison in Parquet decoder .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7769 To unsubscribe, visit htt

[Impala-ASF-CR] Minor comment improvements in buffer-pool.h

2017-08-22 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7774 Change subject: Minor comment improvements in buffer-pool.h .. Minor comment improvements in buffer-pool.h Change-Id: I1212de7ed4e1f93767e00

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/7560/5/fe/src/main/java/org/apa

[Impala-ASF-CR] IMPALA-5798: ASAN use-after-poison in Parquet decoder

2017-08-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5798: ASAN use-after-poison in Parquet decoder .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7769/1//COMMIT_MSG Commit Message: Line 18: -

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7706/1/fe/src/main/java/org/

[Impala-ASF-CR] IMPALA-5612: join inversion should factor in parallelism

2017-08-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5612: join inversion should factor in parallelism .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7351 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py

2017-08-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7761 To unsubscribe

[Impala-ASF-CR] IMPALA-5612: join inversion should factor in parallelism

2017-08-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5612: join inversion should factor in parallelism .. Patch Set 5: (7 comments) Nice! http://gerrit.cloudera.org:8080/#/c/7351/5/fe/src/main/java/org/apache/

[Impala-ASF-CR] IMPALA-5504: Fix TupleIsNullPredicate evaluation.

2017-08-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5504: Fix TupleIsNullPredicate evaluation. .. Patch Set 2: Tim has a good point and I did investigate that. The underlying problem in this JIRA and in IMPAL

[Impala-ASF-CR] IMPALA-5641: mem-estimate should never be less than mem-reservation

2017-08-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5641: mem-estimate should never be less than mem-reservation .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7703 To unsubsc

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/7560/5/fe/src/main/java/org/apa

[Impala-ASF-CR] IMPALA-5819: DCHECK in HdfsTextScanner::Close()

2017-08-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5819: DCHECK in HdfsTextScanner::Close() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7756 To unsubscribe, visit http://ge

[Impala-ASF-CR] IMPALA-5504: Fix TupleIsNullPredicate evaluation.

2017-08-18 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7737 Change subject: IMPALA-5504: Fix TupleIsNullPredicate evaluation. .. IMPALA-5504: Fix TupleIsNullPredicate evaluation. There was a bug in th

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7639/5/be/src/exec/hdfs-text-sc

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7706/1/fe/src/main/java/org/

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'. .. IMPALA-5452: Rewrite test case to avoid 'pos'. The original test case accessed the 'pos' field of nested collections.

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7708/1/testdata/workloads/functional-query/queries/Qu

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'. .. IMPALA-5452: Rewrite test case to avoid 'pos'. The original test case accessed the 'pos' field of nested collections.

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7639/5/be/src/exec/hdfs-text-scanner.cc File

[Impala-ASF-CR] IMPALA-5452: Rewrite test case to avoid 'pos'.

2017-08-17 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7708 Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'. .. IMPALA-5452: Rewrite test case to avoid 'pos'. The original test case acce

[Impala-ASF-CR] IMPALA-5796: CTAS for Kudu fails with expr rewrite

2017-08-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5796: CTAS for Kudu fails with expr rewrite .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7666/2/fe/src/test/java/org/apache/

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7643 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-5796: CTAS for Kudu fails with expr rewrite

2017-08-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5796: CTAS for Kudu fails with expr rewrite .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7666/1/fe/src/main/java/org/apache/impala/analys

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7643 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7639/4/tests/query_test/test_s

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7643 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 3: (6 comments) Looks good, just minor polish of the commit msg. http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7643/2/fe/src/main/java/org/apache/impa

[Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool

2017-08-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5776: Write partial tuple to the correct mempool .. Patch Set 3: (7 comments) I like the new solution, it's easier to understand. http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-4794: Partition distinct expr for skew data

2017-08-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4794: Partition distinct expr for skew data .. Patch Set 1: (19 comments) http://gerrit.cloudera.org:8080/#/c/7643/1//COMMIT_MSG Commit Message: Line 7: IMP

[Impala-ASF-CR] IMPALA-5412: Fix scan result with partitions on same file

2017-08-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5412: Fix scan result with partitions on same file .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7625 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5412: Fix scan result with partitions on same file

2017-08-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5412: Fix scan result with partitions on same file .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7625/5/be/src/exec/hdfs-scan-node-base.h

[Impala-ASF-CR] MPALA-5776: Write partial tuple to the correct mempool

2017-08-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: MPALA-5776: Write partial tuple to the correct mempool .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7639/2/be/src/exec/hdfs-text-scanner.cc File

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-07-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 6: Code-Review+2 Rebase and adjust test output. One final fix to cap NDV at the row count. Did another TPCDS

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-07-02 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7257 to look at the new patch set (#6). Change subject: IMPALA-5547: Rework FK/PK join detection. .. IMPALA-554

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-07-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 11: Code-Review+2 Passed final asan and exhaustive runs. -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#5). Change subject: IMPALA-5547: Rework FK/PK join detection. .. IMPALA-5547: Rework FK/PK join detection. Reworks the FK/PK join detection logic to: - more accurately recognize many-to-m

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7257/4/testdata/workloads/functional-planner/queries/Plan

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6812 To unsubscribe, visit http://gerri

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/6812/7/fe/src/main/java/org/apache/impala/planner/Hdfs

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 8: I'll do an exhaustive run before submitting. -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6527/8/be/src/exec/hdfs-scanner.h F

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#4). Change subject: IMPALA-5547: Rework FK/PK join detection. .. IMPALA-5547: Rework FK/PK join detection. Reworks the FK/PK join detection logic to: - more accurately recognize many-to-m

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 3: New tests are complete now. -- To view, visit http://gerrit.cloudera.org:8080/7257 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-5547: Rework FK/PK join detection. .. IMPALA-5547: Rework FK/PK join detection. Reworks the FK/PK join detection logic to: - more accurately recognize many-to-m

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 2: (9 comments) Responding to comments. New tests are still WIP. http://gerrit.cloudera.org:8080/#/c/7257/2/

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-29 Thread Alex Behm (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6527 to look at the new patch set (#9). Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/6527/8/be/src/exec/base-sequence-s

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/6812/5/fe/src/main/java/org/apache/impala/catalog/Buil

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/6527/7/be/src/exec/base-sequence-s

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-29 Thread Alex Behm (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6527 to look at the new patch set (#8). Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. ...

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-29 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-5547: Rework FK/PK join detection. .. IMPALA-5547: Rework FK/PK join detection. Reworks the FK/PK join detection logic to: - more accurately recognize many-to-m

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 1: (20 comments) I still need to add the targeted planner tests and adjust new tests after the rebase. In th

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7110 To unsubscribe

[Impala-ASF-CR] IMPALA-5591: set should handle negative values

2017-06-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5591: set should handle negative values .. Patch Set 2: Code-Review+2 Makes sense, thanks for the explanation. -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-5591: set should handle negative values

2017-06-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5591: set should handle negative values .. Patch Set 2: Do we have query options where negative values are meaningful? I'm a little confused by the JIRA. How

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7153/7/fe/src/main/java/o

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-06-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 7: (6 comments) The new approach makes sense to me - I Like it. Focusing on high

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7268/8/fe/src/main/java/org/apache/impal

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7268/7/be/src/catalog/catalog-server.cc File be/src/c

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/catalog/catalog-server.cc File be/src/ca

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/catalog/catalog-server.cc File be/src/c

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7268/4/be/src/catalog/catalog-server.cc File be/src/ca

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7073 To unsubscribe, visit http://ge

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7073/7/fe/src/main/java/org/apache/impala/analysis/C

[Impala-ASF-CR] IMPALA-4687: Get Impala working against HBase 2.0

2017-06-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4687: Get Impala working against HBase 2.0 .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7277 To unsubscribe, visit http://

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7110/8/testdata/workloads/functiona

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/7268/3/be/src/catalog/catalog-server.cc File be/src/c

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7153/6/testdata/workloads/functional-p

[Impala-ASF-CR] IMPALA-5571: Fix authorization tests

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5571: Fix authorization tests .. Patch Set 1: For others reading along, the original code from http://gerrit.cloudera.org:8080/7248 had a TODO that explicitl

[Impala-ASF-CR] IMPALA-5571: Fix authorization tests

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5571: Fix authorization tests .. Patch Set 1: Code-Review+2 Let's unblock the builds. -- To view, visit http://gerrit.cloudera.org:8080/7299 To unsubscribe,

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6991/6/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.c

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/7153/6/testdata/workloads/functional-p

[Impala-ASF-CR] IMPALA-5583: [DOCS] Document default join distribution mode query option

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5583: [DOCS] Document default_join_distribution_mode query option .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/7300/1/docs/impala.ditama

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 7: (3 comments) Let's move forward with this change. http://gerrit.cloudera.org:8080/#/c/7073/7/fe/src

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists checks during table load

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists checks during table load .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7095 To unsubscr

[Impala-ASF-CR] IMPALA-5554: sorter DCHECK on null column

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5554: sorter DCHECK on null column .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7295/2/be/src/runtime/sorter.cc File be/src/

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists checks during table load

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists checks during table load .. Patch Set 4: Code-Review+1 (7 comments) http://gerrit.cloudera.org:8080/#/c/7095/2/fe/src/mai

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6023/5/be/src/exprs/math-functions-ir.cc File be/src/exprs/

[Impala-ASF-CR] IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7296 To un

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/7268/2/be/src/catalog/catalog-server.cc File be/src/c

[Impala-ASF-CR] IMPALA-4687: Get Impala working against HBase 2.0

2017-06-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4687: Get Impala working against HBase 2.0 .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7277/1/be/src/exec/hbase-table-scanner.cc File be

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 10: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6963/6/fe/src/main/j

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/7153/3/fe/src/main/java/org/apache/imp

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7153/3//COMMIT_MSG Commit Message: PS3

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7153/3//COMMIT_MSG Commit Message: PS3

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7153/3//COMMIT_MSG Commit Message: PS3

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-22 Thread Alex Behm (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6527 to look at the new patch set (#7). Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. ...

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 7: Code-Review+1 Keep Tim's +1 -- To view, visit http://gerrit.cloudera.org:8080/6527

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6527/6/be/src/exec/kudu-scan-node.c

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7264/1/fe/src/main/java/org/apache/imp

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Alex Behm (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7264 to look at the new patch set (#2). Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. IM

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7264/1/fe/src/main/java/org/apache/imp

[Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.

2017-06-22 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7264 Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout. .. IMPALA-5562: Only recomputeMemLayout() if tuple has a layout

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: (18 comments) http://gerrit.cloudera.org:8080/#/c/7153/3//COMMIT_MSG Commit Message: P

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-21 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7257 Change subject: IMPALA-5547: Rework FK/PK join detection. .. IMPALA-5547: Rework FK/PK join detection. Reworks the FK/PK join detection logi

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7248 To unsubscribe, v

<    1   2   3   4   5   6   7   8   9   10   >