[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 .. IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8 The

[Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7673 Change subject: IMPALA-4786: Clean up how ImpalaServers are created .. IMPALA-4786: Clean up how ImpalaServers are created

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-14 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5717 to look at the new patch set (#19). Change subject: IMPALA-4669: [SECURITY] Add security library to build

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 5: (9 comments) This looks good! Just needs to merge with the recent

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 5: Sorry for the delay, John! I'll try to have comments later today. There's

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7591 To unsubscribe,

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-13 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. IMPALA-5666: ASAN poisoning for MemPool and BufferPool "If you poison us, do we not die?" *

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. Patch Set 3: This patch passes BE tests on a Centos 6 machine with OpenSSL v1.0.0. --

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-12 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. IMPALA-5743: Support TLS version configuration for Thrift servers * Add

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. Patch Set 3: BE and EE tests pass with ASAN enabled with this patch. -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/5717/18/LICENSE.txt File LICENSE.txt:

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. IMPALA-5773: Correctly account for memory used in data stream receiver

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4874: Increase the maximum KRPC message size to 4GB

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4874: Increase the maximum KRPC message size to 4GB .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5887 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5720 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4889: Use client sidecars for Thrift RPCs

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6473 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4856: Port data stream service to KRPC .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7103 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5717 to look at the new patch set (#18). Change subject: IMPALA-4669: [SECURITY] Add security library to build

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

2017-08-11 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5716 to look at the new patch set (#15). Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. Patch Set 3: This patch fixes two issues over the previous patch: 1. Fix quadratic behaviour when

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-11 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7591 to look at the new patch set (#3). Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool ..

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 3: (2 comments) I didn't notice any significant performance

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7646 to look at the new patch set (#4). Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue

[Impala-ASF-CR] IMPALA-5749: coordinator race hits DCHECK 'num remaining backends > 0'

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5749: coordinator race hits DCHECK 'num_remaining_backends_ > 0' .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 15: I've tested (at least by building) this on all the platforms we distribute at Cloudera.

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 1: Yes, please do create a separate patch. We have done the same thing in Thrift where we've

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 1: Do you think should add this as a separate patch, rather than updating an existing one? That

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. Patch Set 2: Thanks! Unfortunately there's an issue with the ASAN build - the huge group_concat

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/5717/15/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#16). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Add krb5 as a

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. IMPALA-5773: Correctly account for memory used in data stream receiver queue

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. IMPALA-5773: Correctly account for memory used in data stream receiver queue

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. IMPALA-5743: Support TLS version configuration for Thrift servers * Add

[native-toolchain-CR] IMPALA-5743: Allow TLS version configuration

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5743: Allow TLS version configuration .. Patch Set 3: Code-Review+2 Verified+1 Had to #ifdef code for openssl versions that don't support TLSv1.1 or

[native-toolchain-CR] IMPALA-5743: Allow TLS version configuration

2017-08-10 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7558 to look at the new patch set (#3). Change subject: IMPALA-5743: Allow TLS version configuration .. IMPALA-5743:

[Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7646 Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue .. IMPALA-5773: Correctly account for

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#15). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Add krb5 as a

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-08-10 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#14). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Set toolchain version

[Impala-ASF-CR] IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests

2017-08-09 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests .. Patch Set 1: I also tried this on a machine with OpenSSL 1.0.0. -- To view, visit

[Impala-ASF-CR] IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests

2017-08-08 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7624 Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests .. IMPALA-5781: Only use TLSv1.0-compatible ciphers for

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7542 To

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 6: Code-Review+2 Forgot to add the couple of lines of code to enable this in the

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-07 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Matthew Jacobs, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7524 to look at the new patch set (#6). Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift

[Impala-ASF-CR] (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode

2017-08-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode .. Patch Set 2: Only in the sense that I was hoping for some feedback on the approach (e.g. is

[Impala-ASF-CR] IMPALA-5774: Prevent FindInSet() from reading off end of string

2017-08-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7608 Change subject: IMPALA-5774: Prevent FindInSet() from reading off end of string .. IMPALA-5774: Prevent FindInSet() from reading off

[Impala-ASF-CR] IMPALA-5743: Support TLS version configuration for Thrift servers

2017-08-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7606 Change subject: IMPALA-5743: Support TLS version configuration for Thrift servers .. IMPALA-5743: Support TLS version configuration

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 5: Code-Review+2 Fix some clang-tidy warnings in the tests. -- To view, visit

[Impala-ASF-CR] IMPALA-5484: Fix LICENSE issues discovered by IPMC in 2.9 vote

2017-08-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5484: Fix LICENSE issues discovered by IPMC in 2.9 vote .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7600 To

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-06 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Matthew Jacobs, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7524 to look at the new patch set (#5). Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7591/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. IMPALA-5696: Enable cipher configuration when using TLS / Thrift The 'cipher suite' is a

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-08-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 7: (10 comments) Looks pretty close to me.

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7591 Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. IMPALA-5666: ASAN poisoning for MemPool and BufferPool * Use

[native-toolchain-CR] Upgrade OpenSSL to 1.0.2l

2017-08-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Upgrade OpenSSL to 1.0.2l .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7582 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-03 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. IMPALA-5696: Enable cipher configuration when using TLS / Thrift The 'cipher suite' is a

[Impala-ASF-CR] IMPALA-5749: coordinator race hits DCHECK 'num remaining backends > 0'

2017-08-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5749: coordinator race hits DCHECK 'num_remaining_backends_ > 0' .. Patch Set 1: Does this trigger only when there are two concurrent calls to

[Impala-ASF-CR] IMPALA-5742: De-allocate buffer in parquet-reader on exit

2017-08-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7572 To

[Impala-ASF-CR] IMPALA-5756: start memory maintenance thread after metric creation

2017-08-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5756: start memory maintenance thread after metric creation .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7573 To

[Impala-ASF-CR] IMPALA-5756: start memory maintenance thread after metric creation

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5756: start memory maintenance thread after metric creation .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5742: De-allocate buffer in parquet-reader on exit

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7572 To

[Impala-ASF-CR] IMPALA-5742: De-allocate buffer in parquet-reader on exit

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7572/1/be/src/util/parquet-reader.cc

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics" .. Patch Set 2: sounds good - let me give you a 'conditional +2'? since you've started a GVO I

[Impala-ASF-CR] Revert "IMPALA-5658: addtl. process/system-wide memory metrics"

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics" .. Patch Set 2: Thanks for jumping on the broken build. Just wondering why a revert was in

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 5: (7 comments)

[native-toolchain-CR] IMPALA-5743: Allow TLS version configuration

2017-08-02 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5743: Allow TLS version configuration .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-08-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 4: (2 comments) I think you need to replace the types of the objects with

[native-toolchain-CR] IMPALA-5743: Allow TLS version configuration

2017-08-01 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7558 Change subject: IMPALA-5743: Allow TLS version configuration .. IMPALA-5743: Allow TLS version configuration * Backport THRIFT-2258 to

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-08-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc File

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-08-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc File

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-08-01 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: Thanks! -- To view, visit http://gerrit.cloudera.org:8080/7492

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-07-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 12: This patch builds on RHEL5.5 and 6.0, debian 7 and 8, ubuntu 12.04 and 14.04, and

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-07-31 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#12). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Set toolchain version

[Impala-ASF-CR] (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode

2017-07-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode .. Patch Set 2: Any takers for a review? This patch reduces the be-test end-to-end time from

[Impala-ASF-CR] (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode

2017-07-31 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode .. (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode Googletest supports sharded

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-07-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 1: (1 comment) Quick question before I get stuck in - did you evaluate

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 27: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe,

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-28 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. IMPALA-4669: [KUTIL] Add kudu_util library to the build. A few miscellaneous changes to

[Impala-ASF-CR] IMPALA-5714: Add OpenSSL to bootstrap toolchain.py

2017-07-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py .. Patch Set 1: Code-Review+2 No, if it's already in the current toolchain version you don't need a separate

[Impala-ASF-CR] Build a ConcatenatedStreams wrapper for ScannerContext::Stream

2017-07-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5714: Add OpenSSL to bootstrap toolchain.py

2017-07-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py .. Patch Set 1: Does the toolchain version need to be bumped as well? -- To view, visit

[Impala-ASF-CR] IMPALA-1891: Statestore won't send deletions in initial non-delta topic

2017-07-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-1891: Statestore won't send deletions in initial non-delta topic .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: My instinct would be just to use the size of tasks_ to control the coordination. In

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-07-27 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7524 Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. IMPALA-5696: Enable cipher configuration when using

[Impala-ASF-CR] IMPALA-5716: Don't delete cmake modules/* when enabling distcc

2017-07-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7493/1/bin/clean.sh File

[Impala-ASF-CR] IMPALA-5716: Don't delete cmake modules/* when enabling distcc

2017-07-25 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc .. IMPALA-5716: Don't delete cmake_modules/* when enabling distcc If $IMPALA_HOME ends with a /,

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: It would be great if someone could write the best-practice

[Impala-ASF-CR] IMPALA-5716: Don't delete cmake modules/* when enabling distcc

2017-07-24 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7493 Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc .. IMPALA-5716: Don't delete cmake_modules/* when

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 9: (8 comments) http://gerrit.cloudera.org:8080/#/c/7363/9/be/src/statestore/statestore.cc

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-07-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization .. Patch Set 5: Code-Review+2 Fix a couple clang-tidy warnings. Last time's the charm.

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-07-23 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7478 to look at the new patch set (#5). Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-07-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization .. Patch Set 4: Code-Review+2 Fix a compilation error in experiments/compression-test

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-07-22 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7478 to look at the new patch set (#4). Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

[Impala-ASF-CR] IMPALA-4905: Don't send empty insert status to coordinator

2017-07-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4905: Don't send empty insert status to coordinator .. Patch Set 2: Code-Review+2 Rebase past Sentry build issue, carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5658: addtl. process/system-wide memory metrics

2017-07-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5658: addtl. process/system-wide memory metrics .. Patch Set 2: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-5688: Reduce run-time of a couple of expr-test heavy-hitters

2017-07-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5688: Reduce run-time of a couple of expr-test heavy-hitters .. Patch Set 2: Code-Review+2 Rebase -- To view, visit

<    1   2   3   4   5   6   7   8   9   >