Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@314c9d8
..
IMPALA-4669: [SECURITY] Import Kudu security library from kudu@314c9d8
The
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7673
Change subject: IMPALA-4786: Clean up how ImpalaServers are created
..
IMPALA-4786: Clean up how ImpalaServers are created
Hello Impala Public Jenkins, Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5717
to look at the new patch set (#19).
Change subject: IMPALA-4669: [SECURITY] Add security library to build
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 5:
(9 comments)
This looks good! Just needs to merge with the recent
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 5:
Sorry for the delay, John! I'll try to have comments later today. There's
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7591
To unsubscribe,
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
IMPALA-5666: ASAN poisoning for MemPool and BufferPool
"If you poison us, do we not die?"
*
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5743: Support TLS version configuration for Thrift
servers
..
Patch Set 3:
This patch passes BE tests on a Centos 6 machine with OpenSSL v1.0.0.
--
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5743: Support TLS version configuration for Thrift
servers
..
IMPALA-5743: Support TLS version configuration for Thrift servers
* Add
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
Patch Set 3:
BE and EE tests pass with ASAN enabled with this patch.
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 18:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5717/18/LICENSE.txt
File LICENSE.txt:
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
IMPALA-5773: Correctly account for memory used in data stream receiver
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 5: Code-Review+2
--
To view, visit
Henry Robinson has abandoned this change.
Change subject: IMPALA-4874: Increase the maximum KRPC message size to 4GB
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5887
To unsubscribe, visit
Henry Robinson has abandoned this change.
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5720
To unsubscribe, visit
Henry Robinson has abandoned this change.
Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/6473
To unsubscribe, visit
Henry Robinson has abandoned this change.
Change subject: IMPALA-4856: Port data stream service to KRPC
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/7103
To unsubscribe, visit
Hello Impala Public Jenkins, Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5717
to look at the new patch set (#18).
Change subject: IMPALA-4669: [SECURITY] Add security library to build
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5716
to look at the new patch set (#15).
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@314c9d8
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
Patch Set 3:
This patch fixes two issues over the previous patch:
1. Fix quadratic behaviour when
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7591
to look at the new patch set (#3).
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 3:
(2 comments)
I didn't notice any significant performance
Hello Matthew Jacobs, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7646
to look at the new patch set (#4).
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 2:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 15:
I've tested (at least by building) this on all the platforms we distribute at
Cloudera.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
..
Patch Set 1:
Yes, please do create a separate patch. We have done the same thing in Thrift
where we've
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
..
Patch Set 1:
Do you think should add this as a separate patch, rather than updating an
existing one? That
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
Patch Set 2:
Thanks! Unfortunately there's an issue with the ASAN build - the huge
group_concat
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 15:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5717/15/CMakeLists.txt
File
Henry Robinson has uploaded a new patch set (#16).
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
IMPALA-4669: [SECURITY] Add security library to build
* Minor compilation fix
* Add krb5 as a
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 2:
(2 comments)
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
IMPALA-5773: Correctly account for memory used in data stream receiver queue
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
IMPALA-5773: Correctly account for memory used in data stream receiver queue
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
Patch Set 1:
(2 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5743: Support TLS version configuration for Thrift
servers
..
Patch Set 1:
(6 comments)
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5743: Support TLS version configuration for Thrift
servers
..
IMPALA-5743: Support TLS version configuration for Thrift servers
* Add
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5743: Allow TLS version configuration
..
Patch Set 3: Code-Review+2 Verified+1
Had to #ifdef code for openssl versions that don't support TLSv1.1 or
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7558
to look at the new patch set (#3).
Change subject: IMPALA-5743: Allow TLS version configuration
..
IMPALA-5743:
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7646
Change subject: IMPALA-5773: Correctly account for memory used in data stream
receiver queue
..
IMPALA-5773: Correctly account for
Henry Robinson has uploaded a new patch set (#15).
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
IMPALA-4669: [SECURITY] Add security library to build
* Minor compilation fix
* Add krb5 as a
Henry Robinson has uploaded a new patch set (#14).
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
IMPALA-4669: [SECURITY] Add security library to build
* Minor compilation fix
* Set toolchain version
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests
..
Patch Set 1:
I also tried this on a machine with OpenSSL 1.0.0.
--
To view, visit
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7624
Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests
..
IMPALA-5781: Only use TLSv1.0-compatible ciphers for
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7542
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
Patch Set 6: Code-Review+2
Forgot to add the couple of lines of code to enable this in the
Hello Impala Public Jenkins, Matthew Jacobs, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7524
to look at the new patch set (#6).
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Henry Robinson has posted comments on this change.
Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
..
Patch Set 2:
Only in the sense that I was hoping for some feedback on the approach (e.g. is
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7608
Change subject: IMPALA-5774: Prevent FindInSet() from reading off end of string
..
IMPALA-5774: Prevent FindInSet() from reading off
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7606
Change subject: IMPALA-5743: Support TLS version configuration for Thrift
servers
..
IMPALA-5743: Support TLS version configuration
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
Patch Set 5: Code-Review+2
Fix some clang-tidy warnings in the tests.
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5484: Fix LICENSE issues discovered by IPMC in 2.9 vote
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7600
To
Hello Impala Public Jenkins, Matthew Jacobs, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7524
to look at the new patch set (#5).
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7591/1//COMMIT_MSG
Commit Message:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
Patch Set 2:
(1 comment)
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
IMPALA-5696: Enable cipher configuration when using TLS / Thrift
The 'cipher suite' is a
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream
interface
..
Patch Set 7:
(10 comments)
Looks pretty close to me.
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7591
Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
..
IMPALA-5666: ASAN poisoning for MemPool and BufferPool
* Use
Henry Robinson has posted comments on this change.
Change subject: Upgrade OpenSSL to 1.0.2l
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7582
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
Patch Set 1:
(8 comments)
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
IMPALA-5696: Enable cipher configuration when using TLS / Thrift
The 'cipher suite' is a
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 1:
Does this trigger only when there are two concurrent calls to
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit
..
Patch Set 3: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/7572
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5756: start memory maintenance thread after metric
creation
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7573
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5756: start memory maintenance thread after metric
creation
..
Patch Set 1:
(3 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit
..
Patch Set 2: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/7572
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7572/1/be/src/util/parquet-reader.cc
Henry Robinson has posted comments on this change.
Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics"
..
Patch Set 2:
sounds good - let me give you a 'conditional +2'? since you've started a GVO I
Henry Robinson has posted comments on this change.
Change subject: Revert "IMPALA-5658: addtl. process/system-wide memory metrics"
..
Patch Set 2:
Thanks for jumping on the broken build. Just wondering why a revert was in
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream
interface
..
Patch Set 5:
(7 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5743: Allow TLS version configuration
..
Patch Set 1:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream
interface
..
Patch Set 4:
(2 comments)
I think you need to replace the types of the objects with
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7558
Change subject: IMPALA-5743: Allow TLS version configuration
..
IMPALA-5743: Allow TLS version configuration
* Backport THRIFT-2258 to
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker
during Close()
..
Patch Set 1:
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/7492
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 12:
This patch builds on RHEL5.5 and 6.0, debian 7 and 8, ubuntu 12.04 and 14.04,
and
Henry Robinson has uploaded a new patch set (#12).
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
IMPALA-4669: [SECURITY] Add security library to build
* Minor compilation fix
* Set toolchain version
Henry Robinson has posted comments on this change.
Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
..
Patch Set 2:
Any takers for a review? This patch reduces the be-test end-to-end time from
Henry Robinson has uploaded a new patch set (#2).
Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
..
(PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
Googletest supports sharded
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream
interface
..
Patch Set 1:
(1 comment)
Quick question before I get stuck in - did you evaluate
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 27: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5715
To unsubscribe,
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
IMPALA-4669: [KUTIL] Add kudu_util library to the build.
A few miscellaneous changes to
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py
..
Patch Set 1: Code-Review+2
No, if it's already in the current toolchain version you don't need a separate
Henry Robinson has posted comments on this change.
Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream
..
Patch Set 1:
(2 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py
..
Patch Set 1:
Does the toolchain version need to be bumped as well?
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-1891: Statestore won't send deletions in initial
non-delta topic
..
Patch Set 1: Code-Review+2
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 3:
My instinct would be just to use the size of tasks_ to control the coordination.
In
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7524
Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift
..
IMPALA-5696: Enable cipher configuration when using
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7493/1/bin/clean.sh
File
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc
..
IMPALA-5716: Don't delete cmake_modules/* when enabling distcc
If $IMPALA_HOME ends with a /,
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker
during Close()
..
Patch Set 1:
It would be great if someone could write the best-practice
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7493
Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc
..
IMPALA-5716: Don't delete cmake_modules/* when
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5511: Add process start time to debug web page
..
Patch Set 9:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7363/9/be/src/statestore/statestore.cc
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
..
Patch Set 5: Code-Review+2
Fix a couple clang-tidy warnings. Last time's the charm.
Hello Impala Public Jenkins, Michael Ho, Sailesh Mukil, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7478
to look at the new patch set (#5).
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
..
Patch Set 4: Code-Review+2
Fix a compilation error in experiments/compression-test
Hello Impala Public Jenkins, Michael Ho, Sailesh Mukil, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7478
to look at the new patch set (#4).
Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch
(de)serialization
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4905: Don't send empty insert status to coordinator
..
Patch Set 2: Code-Review+2
Rebase past Sentry build issue, carry +2
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5658: addtl. process/system-wide memory metrics
..
Patch Set 2: Code-Review+2
(4 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5688: Reduce run-time of a couple of expr-test
heavy-hitters
..
Patch Set 2: Code-Review+2
Rebase
--
To view, visit
101 - 200 of 874 matches
Mail list logo