Henry Robinson has posted comments on this change.
Change subject: IMPALA-5391: remove C++11 from UDF header
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7024
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: Print Kudu native client version on Impala web UI
..
Patch Set 1:
Did you think about making this a metric instead? I see the value in making
this easy to
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5364: Correct title of query locations table
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6988/1//COMMIT_MSG
Commit Message:
Line
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5375: Builds on CentOS 6.4 failing with broken python
dependencies
..
Patch Set 1:
(3 comments)
Can you mention the testing you do (when it's
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 2: Code-Review+1
(1 comment)
I think there would be some benefit in having
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 2:
Will wait for final patch before signing off.
What was the reason behind moving
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5358: Fix repeatable table sample.
..
Patch Set 1:
Ok, thanks - I think you mean that inputParts was arbitrarily ordered, so the
bug was
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5358: Fix repeatable table sample.
..
Patch Set 1: Code-Review+2
Was there a REPEAT(..) clause that could have picked this up that we could put
in a
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 1:
(2 comments)
Where does ReleaseResources() get called for DML queries? It used to be
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 1:
(1 comment)
Patch looks pretty reasonable, will finish shortly.
Henry Robinson has submitted this change and it was merged.
Change subject: Remove libevent from toolchain
..
Remove libevent from toolchain
Only Thrift ever needed libevent, and it no longer needs it, so save the
time
Henry Robinson has posted comments on this change.
Change subject: Remove libevent from toolchain
..
Patch Set 1: Verified+1
Passed a full toolchain build.
--
To view, visit http://gerrit.cloudera.org:8080/6952
To
Henry Robinson has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
..
Patch Set 2: Verified+1
Passed a full toolchain build.
--
To view, visit
Henry Robinson has submitted this change and it was merged.
Change subject: Remove redundant libevent flag when building Thrift
..
Remove redundant libevent flag when building Thrift
--with-libevent was specified twice, and
Henry Robinson has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
..
Patch Set 1:
Yep - mentioned in the commit msg "Libevent is not required for Thrift if the
non-blocking
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5349: flaky NoDirsAllocationError test
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6953
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: Remove redundant libevent flag when building Thrift
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6904/1/source/thrift/build.sh
File
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6952
Change subject: Remove libevent from toolchain
..
Remove libevent from toolchain
Only Thrift ever needed libevent, and it no longer
Henry Robinson has uploaded a new patch set (#2).
Change subject: Remove redundant libevent flag when building Thrift
..
Remove redundant libevent flag when building Thrift
--with-libevent was specified twice, and overridden by
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4890/5143: Coordinator race involving TearDown()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6897/1/be/src/runtime/coordinator.cc
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6904
Change subject: Remove redundant libevent flag when building Thrift
..
Remove redundant libevent flag when building Thrift
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"
..
Patch Set 1:
I think the more information the better. If we can determine that one of those
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown Error 255"
..
Patch Set 1:
If hdfsGetLastExceptionRootCause() always contains relevant information, I
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6889
Change subject: IMPALA-5174: Bump gflags to 2.2.0-p1
..
IMPALA-5174: Bump gflags to 2.2.0-p1
This gflags patch adds
Henry Robinson has posted comments on this change.
Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6707/3/www/query_plan.tmpl
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 10:
Thanks for the review, Tim - do you have any further comments?
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
..
Patch Set 2: Verified+1
Passed a full toolchain build.
--
To view, visit
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
..
IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
See
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5715
to look at the new patch set (#10).
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 8:
(2 comments)
PS8 is just a rebase. PS9 includes the review responses.
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5715
to look at the new patch set (#9).
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
..
Patch Set 2: Code-Review+2
(2 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatstoreSubscriber
..
Patch Set 2: Code-Review+2
(3 comments)
Henry Robinson has uploaded a new patch set (#5).
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
IMPALA-4856: Port ImpalaInternalService to KRPC
This patch ports the ImpalaInternalService to KRPC.
*
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
..
Patch Set 2:
(2 comments)
Re: upstreaming, it seems like gflags is governed mostly by what Google's
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
..
IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
See https://github.com/HenryR/gflags/tree/hidden_flags
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
Patch Set 3:
(30 comments)
http://gerrit.cloudera.org:8080/#/c/5888/3/be/src/runtime/data-stream-mgr.cc
Henry Robinson has uploaded a new patch set (#4).
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
IMPALA-4856: Port ImpalaInternalService to KRPC
This patch ports the ImpalaInternalService to KRPC.
*
Henry Robinson has posted comments on this change.
Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6442
To unsubscribe,
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
..
Patch Set 1:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5222: don't call Bits::Log2*() functions
..
Patch Set 1: Code-Review+2
Thanks for fixing this, and sorry for messing it up in the first place.
--
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6535/6/be/src/runtime/coordinator.cc
File
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6672
Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
..
IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)
See
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5147: Add the ability to exclude hosts from query
execution
..
Patch Set 4:
(3 comments)
Just some minor comments.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 6:
(14 comments)
I quickly looked at some familiar files.
Henry Robinson has posted comments on this change.
Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6442/3/be/src/util/blocking-queue.h
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5720
to look at the new patch set (#10).
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
Henry Robinson has uploaded a new patch set (#6).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
IMPALA-4669: [KRPC] Add kudu_rpc library to build
Import FindKRPC.cmake from Apache Kudu.
One minor linking
Henry Robinson has posted comments on this change.
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 10:
Rebase, plus a couple of bug fixes.
--
To view, visit
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6473
to look at the new patch set (#4).
Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs
..
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
IMPALA-4856: Port ImpalaInternalService to KRPC
This patch ports the ImpalaInternalService to KRPC.
*
Henry Robinson has posted comments on this change.
Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6442/2/be/src/util/blocking-queue.h
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6442
to look at the new patch set (#3).
Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args
..
Allow
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 6:
Re: gflags - agree we need to look hard at a solution. Do you think we could do
that
Henry Robinson has uploaded a new patch set (#6).
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
IMPALA-4669: [KUTIL] Add kudu_util library to the build.
A few miscellaneous changes to allow
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 5:
(5 comments)
> 1) Brining in all the gflags is maybe concerning. will any conflict
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4029: Reduce memory requirements for storing file
metadata
..
Patch Set 3:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4293: query profile should include error log
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6553
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
..
Patch Set 1: Code-Review+2
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings
..
Patch Set 1:
(3 comments)
Looks pretty good - just a couple of nits.
Henry Robinson has posted comments on this change.
Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6442/1//COMMIT_MSG
Commit Message:
Henry Robinson has uploaded a new patch set (#2).
Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args
..
Allow BlockingQueue and ThreadPool to accept rvalue args
Previously the BlockingQueue and ThreadPool
Henry Robinson has posted comments on this change.
Change subject: save
..
Patch Set 1:
I think this should have been squashed.
--
To view, visit http://gerrit.cloudera.org:8080/6540
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args
..
Patch Set 1:
Ping? Happy to walk through the move / forward / rvalue stuff to the extent
that I
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6473/1/be/src/rpc/rpc.h
File
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs
..
IMPALA-4889: Use client sidecars for Thrift RPCs
This patch changes the way Thrift structures are serialized
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/6473/1/be/src/rpc/rpc.h
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db
..
Patch Set 4: Code-Review+2
(2 comments)
lgtm, thanks for working through the alternatives.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db
..
Patch Set 2:
Doesn't this still have the leaking issue?
--
To view, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
..
Patch Set 8: Verified+1
Validated as part of this GVO:
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
..
IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
* Copy gutil from Kudu
* Minimal changes to
Henry Robinson has submitted this change and it was merged.
Change subject: Fix missing declaration of std::max in hdfs-avro-scanner-test
..
Fix missing declaration of std::max in hdfs-avro-scanner-test
Change-Id:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5132: Fix ASAN use after free in timezone_db
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6503/1/be/src/exprs/timezone_db.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5132: Fix ASAN use after free in timezone_db
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6503/1/be/src/exprs/timezone_db.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5132: Fix ASAN use after free in timezone_db
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6503/1/be/src/exprs/timezone_db.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest
gutil
..
Patch Set 9:
(2 comments)
Thanks for the quick reviews!
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
..
Patch Set 7:
(4 comments)
I don't think there's a new upstream version of this code in Kudu (which comes
Hello Impala Public Jenkins, Jim Apple, Dan Hecht, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5688
to look at the new patch set (#9).
Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest
gutil
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5687
to look at the new patch set (#8).
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
..
Henry Robinson has posted comments on this change.
Change subject: Update Impala Jira link to ASF's Jira.
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6499
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: Fix missing declaration of std::max in hdfs-avro-scanner-test
..
Patch Set 1:
Ping: who wants an easy review? :)
I'm not sure why these issues show up on my
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4041: Limit catalog and admission control updates to
coordinators
..
Patch Set 5: Code-Review+2
(6 comments)
Hello Impala Public Jenkins, Jim Apple, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5688
to look at the new patch set (#8).
Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest
gutil
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6497
Change subject: Fix missing declaration of std::max in hdfs-avro-scanner-test
..
Fix missing declaration of std::max in
Hello Jim Apple, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5688
to look at the new patch set (#7).
Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest
gutil
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest
gutil
..
Patch Set 6:
(3 comments)
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5687
to look at the new patch set (#6).
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
..
Henry Robinson has abandoned this change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
..
Abandoned
Messed up the commit msg + ChangeId.
--
To view, visit http://gerrit.cloudera.org:8080/6476
To
Henry Robinson has uploaded a new patch set (#6).
Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest
gutil
..
IMPALA-4758: (2/2) Impala-side changes to build with latest gutil
Meant to be taken as a
Hello Internal Jenkins, Dan Hecht,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6476
to review the following change.
Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b
..
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
IMPALA-4856: Port ImpalaInternalService to KRPC
This patch ports the ImpalaInternalService to KRPC.
*
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5720
to look at the new patch set (#8).
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6473
Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs
..
IMPALA-4889: Use client sidecars for Thrift RPCs
This patch
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest
gutil
..
Patch Set 4:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5715/1/CMakeLists.txt
File
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
..
IMPALA-4669: [KUTIL] Add kudu_util library to the build.
A few miscellaneous changes to allow
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@a1bfd7b
..
IMPALA-4669: [KUTIL] Import kudu_util library from kudu@a1bfd7b
Change-Id:
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from
kudu@a1bfd7b
..
IMPALA-4669: [SECURITY] Import Kudu security library from kudu@a1bfd7b
The security
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4669: [KRPC] Import RPC library from kudu@a1bfd7b
..
IMPALA-4669: [KRPC] Import RPC library from kudu@a1bfd7b
Change-Id:
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
IMPALA-4669: [KRPC] Add kudu_rpc library to build
Import FindKRPC.cmake from Apache Kudu.
One minor linking
401 - 500 of 874 matches
Mail list logo
