[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 4: Code-Review+2 (2 comments) lgtm, thanks for working through the alternatives. http://gerri

[Impala-ASF-CR] IMPALA-5123: Fix ASAN use after free in timezone db

2017-03-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5123: Fix ASAN use after free in timezone_db .. Patch Set 2: Doesn't this still have the leaking issue? -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil .. IMPALA-4758: (2/2) Impala-side changes to build with latest gutil Meant to be tak

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b .. Patch Set 8: Verified+1 Validated as part of this GVO: http://jenkins.impala.io:8080/job/gerrit-verify-dr

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b .. IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b * Copy gutil from Kudu * Minimal changes to gu

[Impala-ASF-CR] Fix missing declaration of std::max in hdfs-avro-scanner-test

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: Fix missing declaration of std::max in hdfs-avro-scanner-test .. Fix missing declaration of std::max in hdfs-avro-scanner-test Change-Id: Id41c14e98163

[Impala-ASF-CR] Fix missing declaration of std::max in hdfs-avro-scanner-test

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Fix missing declaration of std::max in hdfs-avro-scanner-test .. Patch Set 1: Verified+1 Validated as part of this GVO: http://jenkins.impala.io:8080/job/gerri

[Impala-ASF-CR] IMPALA-5130: fix race in MemTracker::EnableReservationReporting()

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5130: fix race in MemTracker::EnableReservationReporting() .. Patch Set 1: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/6502/1/be/src

[Impala-ASF-CR] IMPALA-5132: Fix ASAN use after free in timezone db

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5132: Fix ASAN use after free in timezone_db .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6503/1/be/src/exprs/timezone_db.cc File be/

[Impala-ASF-CR] IMPALA-5132: Fix ASAN use after free in timezone db

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5132: Fix ASAN use after free in timezone_db .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6503/1/be/src/exprs/timezone_db.cc File be/

[Impala-ASF-CR] IMPALA-5132: Fix ASAN use after free in timezone db

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5132: Fix ASAN use after free in timezone_db .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6503/1/be/src/exprs/timezone_db.cc File be

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil .. Patch Set 9: (2 comments) Thanks for the quick reviews! http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b .. Patch Set 7: (4 comments) I don't think there's a new upstream version of this code in Kudu (which comes

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-28 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Jim Apple, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5688 to look at the new patch set (#9). Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-28 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5687 to look at the new patch set (#8). Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b .. IMPALA-47

[Impala-ASF-CR](asf-site) Update Impala Jira link to ASF's Jira.

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Update Impala Jira link to ASF's Jira. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6499 To unsubscribe, visit http://gerrit

[Impala-ASF-CR] Fix missing declaration of std::max in hdfs-avro-scanner-test

2017-03-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Fix missing declaration of std::max in hdfs-avro-scanner-test .. Patch Set 1: Ping: who wants an easy review? :) I'm not sure why these issues show up on my KR

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 5: Code-Review+2 (6 comments) http://gerrit.cloudera.org:8080/#/c/6344/5

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil .. Patch Set 8: Code-Review+1 Rebase and fix a test-compilation bug. -- To view, visit http

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-27 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5688 to look at the new patch set (#8). Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil ...

[Impala-ASF-CR] Fix missing declaration of std::max in hdfs-avro-scanner-test

2017-03-27 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6497 Change subject: Fix missing declaration of std::max in hdfs-avro-scanner-test .. Fix missing declaration of std::max in hdfs-avro-scanne

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-27 Thread Henry Robinson (Code Review)
Hello Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5688 to look at the new patch set (#7). Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil ..

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/5688/6/be/src/common/atomic

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-27 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5687 to look at the new patch set (#6). Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b .. IMPALA-47

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5687/4/be/src/gutil/atomicops-internals-x86

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-24 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#5). Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil .. IMPALA-4758: (2/2) Impala-side changes to build with latest gutil Meant to be taken as a who

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-24 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#5). Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b .. IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b * Copy gutil from Kudu * Change includes to remove kudu/

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-24 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b .. Abandoned Messed up the commit msg + ChangeId. -- To view, visit http://gerrit.cloudera.org:8080/6476 To unsubscr

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-24 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#6). Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil .. IMPALA-4758: (2/2) Impala-side changes to build with latest gutil Meant to be taken as a who

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-24 Thread Henry Robinson (Code Review)
Hello Internal Jenkins, Dan Hecht, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6476 to review the following change. Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b ..

[Impala-ASF-CR] IMPALA-4856: Port ImpalaInternalService to KRPC

2017-03-24 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC .. IMPALA-4856: Port ImpalaInternalService to KRPC This patch ports the ImpalaInternalService to KRPC. * ImpalaIn

[Impala-ASF-CR] IMPALA-4889: Use client sidecars for Thrift RPCs

2017-03-24 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6473 Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs .. IMPALA-4889: Use client sidecars for Thrift RPCs This patch changes

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-03-24 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5720 to look at the new patch set (#8). Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC ...

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5688/4/be/src/common/atomic.

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5715/1/CMakeLists.txt File CMakeLists

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#4). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. IMPALA-4669: [KUTIL] Add kudu_util library to the build. A few miscellaneous changes to allow kudu_uti

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. IMPALA-4669: [KUTIL] Add kudu_util library to the build. A few miscellaneous changes to allow kudu_uti

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Import kudu util library from kudu@a1bfd7b

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@a1bfd7b .. IMPALA-4669: [KUTIL] Import kudu_util library from kudu@a1bfd7b Change-Id: I6d89384730b60354b5f

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Import Kudu security library from kudu@a1bfd7b

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [SECURITY] Import Kudu security library from kudu@a1bfd7b .. IMPALA-4669: [SECURITY] Import Kudu security library from kudu@a1bfd7b The security l

[Impala-ASF-CR] IMPALA-4669: [KRPC] Import RPC library from kudu@a1bfd7b

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [KRPC] Import RPC library from kudu@a1bfd7b .. IMPALA-4669: [KRPC] Import RPC library from kudu@a1bfd7b Change-Id: I06ab5b56312e482a27fa484414c338438

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. IMPALA-4669: [KRPC] Add kudu_rpc library to build Import FindKRPC.cmake from Apache Kudu. One minor linking

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#4). Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil .. IMPALA-4758: (2/2) Impala-side changes to build with latest gutil Meant to be taken as a who

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Set toolchain version to

[Impala-ASF-CR] IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#4). Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b .. IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b * Copy gutil from Kudu * Change includes to remove kudu/

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 4: (9 comments) Please consider adding something to the root web page (a

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6344/3/be/src/runtim

[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Patch Set 1: Code-Review+2 Verified+1 I feel pretty good giving this a +2 myself (we discussed this interna

[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Add Apache Software License 2.0 (see LICENSE.txt) Change-Id: Ifbf0d730e476b5e448b1aba379373b83623d

[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6450 Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Add Apache Software License 2.0 (see LICENSE.txt) Change-Id: Ifbf0

[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Abandoned Bad push. -- To view, visit http://gerrit.cloudera.org:8080/6449 To unsubscribe, visit http://gerrit.clo

[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc3

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc3 .. Abandoned Bad push. -- To view, visit http://gerrit.cloudera.org:8080/6447 To unsubscribe, visit http://gerrit.cl

[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc4

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc4 .. Abandoned Bad push. -- To view, visit http://gerrit.cloudera.org:8080/6448 To unsubscribe, visit http://gerrit.cl

[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc3

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6447 Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc3 .. Set toolchain Kudu version for CDH Kudu 5.10.0 rc3 Kudu tag 'kudu

[native-toolchain-CR] Add Apache Software License 2.0 (see LICENSE.txt)

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6449 Change subject: Add Apache Software License 2.0 (see LICENSE.txt) .. Add Apache Software License 2.0 (see LICENSE.txt) Change-Id: I501d

[native-toolchain-CR] Set toolchain Kudu version for CDH Kudu 5.10.0 rc4

2017-03-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6448 Change subject: Set toolchain Kudu version for CDH Kudu 5.10.0 rc4 .. Set toolchain Kudu version for CDH Kudu 5.10.0 rc4 Kudu tag 'kudu

[Impala-ASF-CR] IMPALA-5088: Fix heap buffer overflow

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5088: Fix heap buffer overflow .. Patch Set 2: As if to prove the point about this not just being a hypothetical bug, I just hit this, in unison, on fiv

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6436 to look at the new patch set (#2). Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

[Impala-ASF-CR] Allow BlockingQueue and ThreadPool to accept rvalue args

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6442 Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args .. Allow BlockingQueue and ThreadPool to accept rvalue args Pr

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) .. Patch Set 1: All the Kudu tests failed, not clear why one of the table servers failed to start. Unfo

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6344/2/be/src/runtime

[Impala-ASF-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6428 To unsubscribe, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. Patch Set 1: With Snappy 1.1.3, that query against a 96 million row table took on average 6.1s. With Snappy 1.1.4, th

[Impala-ASF-CR] IMPALA-4846: Upgrade Snappy to 1.1.4

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4846: Upgrade Snappy to 1.1.4 .. Patch Set 1: I'll try and do this now. Because of the way the toolchain works, we can't get any other version changes i

[Impala-ASF-CR] IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0)

2017-03-20 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6436 Change subject: IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) .. IMPALA-5057: Upgrade glog (0.3.4-p2) and gflags (2.2.0) Chan

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-17 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) Upgrade gflags and glog together, gl

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 4: Verified by toolchain build ID 369-421c1fb391 -- To view, visit http://gerrit.cloudera

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6372 To unsubscribe, visit

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-16 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6372 to look at the new patch set (#4). Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6372/3/source/gflags/build.sh File sour

[Impala-ASF-CR] IMPALA-5041: Calling AuthManager::Init() more than once results in undefined behavior

2017-03-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5041: Calling AuthManager::Init() more than once results in undefined behavior .. Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-sender.cc File b

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-16 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-sender.cc File b

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 2: Lars took a look at the glog breakpad patch, and Matt took a quick look at the glog mes

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6372/2/source/gflags/build.sh File sour

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-15 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6372 to look at the new patch set (#3). Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. IMP

[Impala-ASF-CR] IMPALA-5077: add NUMA and current cpu to CpuInfo

2017-03-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5077: add NUMA and current cpu to CpuInfo .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6402/3/be/CMakeLists.txt File be/CMakeLists.t

[Impala-ASF-CR] Fix typo in Flatbuffers cmake module

2017-03-14 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6398 Change subject: Fix typo in Flatbuffers cmake module .. Fix typo in Flatbuffers cmake module Change-Id: I0786344b5485a92c02a246b543b6ac

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6372/2/source/glog/glog-0.3.4-patches/0

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) Upgrade gflags and glog together, glog is depen

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 1: This passes a native-toolchain build. -- To view, visit http://gerrit.cloudera.org:808

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6372 Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) Upgr

[Impala-ASF-CR] IMPALA-5041: AuthManager::Init() is not idempotent

2017-03-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5041: AuthManager::Init() is not idempotent .. Patch Set 1: (5 comments) Thanks for doing this. http://gerrit.cloudera.org:8080/#/c/6333/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6344/1/be/src/schedul

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6344/1/be/src/schedul

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: Even better - because the partition function definition would be a template (and therefore availab

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/6/be/src/runtime/data-stream-sender.cc File b

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/6/be/src/runtime/data-stream-sender.cc File b

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 3: (17 comments) Few stylistic comments. http://gerrit.cloudera.org:8080/#/c/6037/4/be/src/runtime/d

[Impala-ASF-CR] IMPALA-4885: Expose Jvm thread info in web UI

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4885: Expose Jvm thread info in web UI .. Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/6013/3/be/src/util/thread.cc File

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5115 To unsubscribe, visit http:

[Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-3882: Simplify some query exec state locking .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4935 To unsubscribe, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-4212: Add sink output expressions to explain output

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4212: Add sink output expressions to explain output .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4783 To unsubscribe, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5001: Redownload dependencies if toolchain ID changes

2017-03-07 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-5001: Redownload dependencies if toolchain ID changes .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6166 To unsubscribe, visit http://gerrit.clo

[Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup

2017-03-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Fix a potential crash in Frontend & Catalog JNI startup .. Patch Set 3: Code-Review+2 (1 comment) Thanks. This seems better as the amount of 'magic' is minimis

[native-toolchain-CR] Add historical version for breakpad

2017-03-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Add historical version for breakpad .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6271 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup

2017-03-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Fix a potential crash in Frontend & Catalog JNI startup .. Patch Set 2: (1 comment) If you get rid of the local frame, do you still need to promote to a global

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-03-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 15: Sounds good - I commented on the bugfix, hopefully we can get these both in quickly. -- To

[Impala-ASF-CR] Fix a potential crash in Frontend & Catalog JNI startup

2017-03-05 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Fix a potential crash in Frontend & Catalog JNI startup .. Patch Set 1: I don't fully understand the JNI model, but I'm wondering if this is exactly the right

[Impala-ASF-CR] Add min / max to histograms

2017-03-03 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/6257 Change subject: Add min / max to histograms .. Add min / max to histograms Even 99.9th %-ile measurements can hide a single huge outlie

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

2017-03-03 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5027: make udf headers buildable externally .. Patch Set 1: Is it unreasonable to require C++11 support? I can see this becoming problematic with automa

<    1   2   3   4   5   6   7   8   9   10   >