Henry Robinson has posted comments on this change.
Change subject: IMPALA-4652: Add crcutil to build
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5660/1//COMMIT_MSG
Commit Message:
Line 7: IMPALA-4652: Add
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4651: Add LibEv to build
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5659/1//COMMIT_MSG
Commit Message:
Line 9: Add libev 4.20 to t
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4747: macros should only evaluate their arguments once
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5686
To unsubscri
Henry Robinson has posted comments on this change.
Change subject: Add Kudu cmake utilities
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5656/2/cmake_modules/kudu_cmake_fns.txt
File cmake_modules/kudu_cmake_
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5656
to look at the new patch set (#3).
Change subject: Add Kudu cmake utilities
..
Add Kudu cmake utilities
This comm
Henry Robinson has posted comments on this change.
Change subject: Add Kudu cmake utilities
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5656/2/cmake_modules/kudu_cmake_fns.txt
File cmake_modules/kudu_cmake_
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4751: Remove blank line from raw_text template
..
Patch Set 2:
Why can't this be fixed on the consumer side? Stripping out leading and
trailing white sp
Henry Robinson has uploaded a new patch set (#2).
Change subject: Add Kudu cmake utilities
..
Add Kudu cmake utilities
This commit imports some CMake utility methods from Kudu, in preparation
for adding KRPC and its dependencies
Henry Robinson has posted comments on this change.
Change subject: Add Kudu cmake utilities
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5656/1/CMakeLists.txt
File CMakeLists.txt:
PS1, Line 17:
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5656
Change subject: Add Kudu cmake utilities
..
Add Kudu cmake utilities
This commit imports some CMake utility methods from Kudu, in prepa
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5659
Change subject: IMPALA-4651: Add LibEv to build
..
IMPALA-4651: Add LibEv to build
Add libev 4.20 to the Impala build. This is a depend
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5657
Change subject: IMPALA-4650: Add Protobuf to build
..
IMPALA-4650: Add Protobuf to build
This patch adds Protobuf 2.6.1 to Impala's bui
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5660
Change subject: IMPALA-4652: Add crcutil to build
..
IMPALA-4652: Add crcutil to build
Add crcutil, built from a git hash since there a
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5658
Change subject: IMPALA-4650: Allow protobuf to find non-system libraries and
binaries
..
IMPALA-4650: Allow protobuf to find non-system
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet
scanner
..
Patch Set 3:
Agree with Tim about the template code changes, and there's less urgenc
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3882: Simplify some query exec state locking
..
Patch Set 6:
(1 comment)
Abandoned this for now: Sailesh's comment lead me down a rat hole that I don't
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5615/1/be/src/runtime/query-exec-
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5615/1/be/src/runtime/query-exec-mgr.cc
File be
Henry Robinson has submitted this change and it was merged.
Change subject: Add thousands separator to cardinality in plan diagram
..
Add thousands separator to cardinality in plan diagram
Tested manually by visually validating
Henry Robinson has posted comments on this change.
Change subject: Add thousands separator to cardinality in plan diagram
..
Patch Set 4: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/5587
To unsubs
Henry Robinson has uploaded a new patch set (#4).
Change subject: Add thousands separator to cardinality in plan diagram
..
Add thousands separator to cardinality in plan diagram
Tested manually by visually validating the cardin
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5606
Change subject: Fix Lists import in ExprRewriter.java
..
Fix Lists import in ExprRewriter.java
Change-Id: Ia8f27180b334c509d627bc2f93fc
Henry Robinson has posted comments on this change.
Change subject: Take out (stale) architecture diagram w/ Cloudera-specific
terminology.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5596/1/docs/topics/imp
Henry Robinson has posted comments on this change.
Change subject: add thousands separator to cardinality tested manually by
visually validating the cardinality numbers have thousands separators
..
Patch Set 2:
(1 comment)
ht
Henry Robinson has posted comments on this change.
Change subject: add thousands seperator to cardinality
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5587
To unsubscribe, visit http://gerrit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3977: TransmitData() should not block
..
Patch Set 4:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/5491/4/be/src/runtime/data-stream-mgr.cc
File be
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3977: TransmitData() should not block
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5491/1/be/src/runtime/data-stream-mgr.cc
File be/
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3977: TransmitData() should not block
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5491/1/be/src/runtime/data-stream-sender.cc
File b
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3977: TransmitData() should not block
..
Patch Set 1:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/5491/1/be/src/runtime/data-stream-mgr.cc
File be/
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4642: Fix TestFragmentLifecycle failures; kudu test must
wait
..
Patch Set 1: Code-Review+2
Same question as Sailesh - just want to be sure you won't wi
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4648: remove build_thirdparty.sh
..
Patch Set 1: Code-Review+2
Excellent.
--
To view, visit http://gerrit.cloudera.org:8080/5477
To unsubscribe, visit
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4630: make debug webpage easter egg look less suspicious
..
Patch Set 2:
I'd like it removed, but I'm fine if we do that as a follow-on patch.
--
To vi
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4608: Fix fragment completion times for INSERTs
..
Patch Set 5: Code-Review+2
Rebase past IMPALA-4628 fix
--
To view, visit http://gerrit.cloudera.org:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4608: Fix fragment completion times for INSERTs
..
Patch Set 4: Code-Review+2
(1 comment)
Rebase, carry +2
http://gerrit.cloudera.org:8080/#/c/5418/2/b
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5418
to look at the new patch set (#3).
Change subject: IMPALA-4608: Fix fragment completion times for INSERTs
..
IMPALA-46
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4608: Fix fragment completion times for INSERTs
..
IMPALA-4608: Fix fragment completion times for INSERTs
Fix a bug where completion times weren't computed
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5418
Change subject: IMPALA-4608: Fix fragment completion times for INSERTs
..
IMPALA-4608: Fix fragment completion times for INSERTs
Fix a
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4613: Make sure timers are finished before sending
report profile
..
IMPALA-4613: Make sure timers are finished before sending report profile
F
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4613: Make sure timers are finished before sending
report profile
..
Patch Set 3: Code-Review+2 Verified+1
Rebase (so that I can get rid of Internal Jen
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4613: Make sure timers are finished before sending
report profile
..
IMPALA-4613: Make sure timers are finished before sending report profile
FragmentComp
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5394
Change subject: IMPALA-4613: Make sure timers are finished before sending
report profile
..
IMPALA-4613: Make sure timers are finished
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4014: Introduce query-wide execution state.
..
Patch Set 6:
(11 comments)
Some more comments about the refcounting, many in response to yours.
http://g
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4580: Fix crash with FETCH_FIRST when #rows < result
cache size
..
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5335/1/be
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5335
to look at the new patch set (#2).
Change subject: IMPALA-4580: Fix crash with FETCH_FIRST when #rows < result
cache size
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5335
Change subject: IMPALA-4580: Fix crash with FETCH_FIRST when #rows < result
cache size
..
IMPALA-4580: Fix crash with FETCH_FIRST when
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3875: Thrift threaded server hang in some cases
..
Patch Set 3: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5263/3/be/src/runtime/cli
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3875: Thrift threaded server hang in some cases
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5263
To unsubscribe, vis
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4562: Fix for crash on kerberized clusters w/o Kudu
support
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5295
To uns
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status
reporting
..
Patch Set 9: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5250/
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status
reporting
..
Patch Set 4: Code-Review+1
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5250/
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status
reporting
..
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5250/3/be/src/runti
Henry Robinson has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> I do not find it more readable, but I find it to be readable enough; I think
> the readability delta is a
Henry Robinson has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> I don't think we should never use it, but I think it is overkill for this use
> case
The alternative impl
Henry Robinson has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> It's the added hidden run-time complexity generally
Can you be more specific? Abstractions naturally hide
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4532: Fix use-after-free in ProcessBuildInputAsync()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5246/1/be/src/exec/blocking-join-no
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4532: Fix use-after-free in ProcessBuildInputAsync()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5246/1/be/src/exec/blocking-join-no
Henry Robinson has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
I checked EMC++ and the ppt you linked to.
Am I right to summarise that your main objection is that std::fun
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5244/1/tests/query_test/te
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5243
Change subject: IMPALA-4542: Fix use-after-free in some BE tests
..
IMPALA-4542: Fix use-after-free in some BE tests
Change RuntimeStat
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5214
Change subject: IMPALA-4535: Remove 'auto' from parameter list
..
IMPALA-4535: Remove 'auto' from parameter list
Although GCC supports
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4488: HS2 GetOperationStatus() should keep session alive
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5213/1/tests/hs2/test_hs2.py
Fi
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4488: HS2 GetOperationStatus() should keep session alive
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5213/1/tests/hs2/test_hs2.py
Fi
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5213
Change subject: IMPALA-4488: HS2 GetOperationStatus() should keep session alive
..
IMPALA-4488: HS2 GetOperationStatus() should keep ses
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4410: Safer tear-down of RuntimeState
..
Patch Set 5: Code-Review+2
(2 comments)
Carry +2, last patch didn't include the small test changes needed to ma
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4410: Safer tear-down of RuntimeState
..
IMPALA-4410: Safer tear-down of RuntimeState
* Add RuntimeState::Close() which is guaranteed to release
Hello Internal Jenkins, Sailesh Mukil, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4893
to look at the new patch set (#5).
Change subject: IMPALA-4410: Safer tear-down of RuntimeState
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4410: Safer tear-down of RuntimeState
..
Patch Set 4: Code-Review+2
Rebase.
--
To view, visit http://gerrit.cloudera.org:8080/4893
To unsubscribe, visi
Hello Sailesh Mukil, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4893
to look at the new patch set (#4).
Change subject: IMPALA-4410: Safer tear-down of RuntimeState
..
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4893
to look at the new patch set (#3).
Change subject: IMPALA-4410: Safer tear-down of RuntimeState
..
IMPALA-4410: Sa
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4410: Safer tear-down of RuntimeState
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4893/2/be/src/runtime/test-env.cc
File be/src/run
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3342: Add thread counters to monitor plan fragment
execution
..
Patch Set 9: Code-Review+2
Looks good to me.
--
To view, visit http://gerrit.cloudera.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4014: Introduce query-wide execution state.
..
Patch Set 3:
(18 comments)
Looked over the ref count logic so far.
http://gerrit.cloudera.org:8080/#/c/4
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5149
Change subject: IMPALA-4511: Add missing total_time_counter() to PFE::Exec()
..
IMPALA-4511: Add missing total_time_counter() to PFE::Ex
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4509: Initialise Sasl-specific mutex
..
Patch Set 1:
Let me know when that build passes, and I'll submit this for GVO.
--
To view, visit http://gerrit.
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5142
Change subject: IMPALA-4509: Initialise Sasl-specific mutex
..
IMPALA-4509: Initialise Sasl-specific mutex
Call sasl_set_mutex() to con
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5139
To unsubscribe,
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5139/2/be/src/rpc/authentication.cc
F
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet
scanner
..
Patch Set 3:
Added test files that have both plain and binary encodings.
--
To vie
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet
scanner
..
Patch Set 3:
s/binary/dictionary in last comment.
--
To view, visit http://gerrit.
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet
scanner
..
IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner
* Extend meta
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4410: Safer tear-down of RuntimeState
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4893/2/be/src/runtime/test-env.cc
File be/src/runt
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not
present
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5095
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes.
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5117
To unsubsc
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
Patch Set 1:
Can't the coordinator always make sure it's in the list of available backends,
like Tim suggested? Wo
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet
scanner
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5115/1//COMMIT_MSG
Co
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet
scanner
..
IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner
* Extend meta
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes.
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5117/1/testdata/workloads/funct
Henry Robinson has uploaded a new patch set (#2).
Change subject: Improve message output from run-step.sh
..
Improve message output from run-step.sh
run-step prints a message to tell the reader what it's doing. However,
that mes
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5116
Change subject: Improve message output from run-step.sh
..
Improve message output from run-step.sh
run-step prints a message to tell th
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet
scanner
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5115/1//COMMIT_MSG
Co
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not
present
..
Patch Set 2:
> Thanks!Do you think I should add some code to catalog to validate the
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet
scanner
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5115/1/testdata/worklo
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5115
Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet
scanner
..
IMPALA-2494: Support for byte array-encoded
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not
present
..
Patch Set 1: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5095/1/f
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4459: Consider making ReportExecStatus() RPC execute
asynchronously
..
Patch Set 1:
Have you run any performance tests to see what difference this makes
Henry Robinson has uploaded a new patch set (#6).
Change subject: IMPALA-3882: Simplify some query exec state locking
..
IMPALA-3882: Simplify some query exec state locking
query_exec_state_map_lock_ is implicated in many deadlo
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3882: Simplify some query exec state locking
..
Patch Set 5:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/4935/4/be/src/service/impala-beeswax-serve
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4452: Always call AggFnEvaluator::Open() before
AggFnEvaluator::Init()
..
Patch Set 2:
I kicked off a GVO to see if we can get a green build today. I do
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4465: Don't hold process wide lock while serializing
Runtime Profile in GetRuntimeProfileStr()
..
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3882: Simplify some query exec state locking
..
Patch Set 4:
(9 comments)
Here's how I think about the lock safety (sorry, long, but hopefully helps to
701 - 800 of 1022 matches
Mail list logo
