[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 9: A reminder to us both: the first blog post should change the Blog header link to /blog

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Initial commit of the blog section of the Impala ASF website. .. Initial commit of the blog section of the Impala ASF website. Note: a sample version of the

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 9: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5667 To uns

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5794 To un

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5794 To un

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 3: > > (1 comment) > > > > I did my own survey for this renaming and feel yo

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/4/be/src/exec/exec-node.cc

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/5584/17/be/src/runtime/bufferpool/buffer-po

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 16: (1 comment) clang-tidy found this, but the Jenkins jobs that runs clang-tidy has confusing

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. Patch Set 1: > Dry-run: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/208/ Failed due to

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 2: > (1 comment) > > I did my own survey for this renaming and feel you hav

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5791/4/be/src/exprs/timest

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5791/3/be/src/exprs/timestamp-functions

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5791/3//COMMIT_MSG Commit Message: Lin

[Impala-ASF-CR] IMPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5794/1/tests/experiments/t

[Impala-ASF-CR] MPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: MPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5794/1//COMMIT_MSG Commit M

[Impala-ASF-CR] MPALA-4750: Rename test infra classes so they don't mimic test classes.

2017-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: MPALA-4750: Rename test infra classes so they don't mimic test classes. .. Patch Set 1: (2 comments) You checked that the same tests are selected to be run both be

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/5667/8//COMMIT_MSG Commit Message: L

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. Patch Set 1: Dry-run: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/208/ -- To view, vi

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/5667/4/nikola_site_generator/README.m

[Impala-ASF-CR](asf-site) Remove "Git repository" from navigation bar.

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5785 Change subject: Remove "Git repository" from navigation bar. .. Remove "Git repository" from navigation bar. It is not in the navigation bar

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5784 Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. IMPALA-4818: Ensure the same number of tests are run every

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 3: > > There's probably no reason not to. I went ahead and pushed a > > version with comm

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 3: > There's probably no reason not to. I went ahead and pushed a > version with comments

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5640/3//COMMIT_MSG Commit Message: Lin

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 12: Code-Review+2 carry -- To view, visit http://gerrit.cloudera.org:8080/5585 To unsubscr

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 11: Code-Review+2 carry -- To view, visit http://gerrit.cloudera.org:8080/5585 To unsubscr

[Impala-ASF-CR](asf-site) Download and signature links for 2.8.0 release

2017-01-22 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Download and signature links for 2.8.0 release .. Download and signature links for 2.8.0 release Change-Id: If2767782f6b61597b6f160c387a504b14cdb4ed1 Review

[Impala-ASF-CR](asf-site) Download and signature links for 2.8.0 release

2017-01-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Download and signature links for 2.8.0 release .. Patch Set 1: I hope to get a +2 on this before pushing it to the website, even though that's a bit pedantic of me,

[Impala-ASF-CR](asf-site) Download and signature links for 2.8.0 release

2017-01-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Download and signature links for 2.8.0 release .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5638 To unsubscribe, visit http://gerrit

[Impala-ASF-CR] Prepare for official 2.8 release by incrementing version number

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Prepare for official 2.8 release by incrementing version number .. Patch Set 2: Code-Review+2 (1 comment) carry +2 http://gerrit.cloudera.org:8080/#/c/5763/1//COMM

[Impala-ASF-CR] Prepare for official 2.8 release by incrementing version number

2017-01-20 Thread Jim Apple (Code Review)
Hello Marcel Kornacker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5763 to look at the new patch set (#2). Change subject: Prepare for official 2.8 release by incrementing version number ..

[Impala-ASF-CR] Prepare for official 2.8 release by icnrementing version number

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5763 Change subject: Prepare for official 2.8 release by icnrementing version number .. Prepare for official 2.8 release by icnrementing version n

[Impala-ASF-CR] Update copyright year to 2017

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Update copyright year to 2017 .. Patch Set 1: This was found by one of our IPMC release voters. -- To view, visit http://gerrit.cloudera.org:8080/5754 To unsubscri

[Impala-ASF-CR] Update copyright year to 2017

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5754 Change subject: Update copyright year to 2017 .. Update copyright year to 2017 Change-Id: I6a815c67176fc2a08ed693b581fac4c6919f297c --- M NO

[Impala-ASF-CR](asf-site) Download and signature links for 2.8.0 release

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Download and signature links for 2.8.0 release .. Patch Set 1: This can be submitted in 24 hours, since the IPMC vote passed and the release artifacts are in SVN -

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. Patch Set 3: (10 comments) Thank you for making this patch http://gerrit.cloudera.org:8080/#/c/5640/

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks RECOVER PARTITIONS needs

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. Patch Set 1: Verified+1 http://jenkins.impala.io:8080/job/parallel-all-tests/218/ -- To view, vi

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. Patch Set 1: > Testing at: http://jenkins.impala.io:8080/job/ubuntu-14.04-from-scratch/646/ All t

[Impala-ASF-CR] IMPALA-4778 IMPALA-1972: Add known issue

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4778 IMPALA-1972: Add known issue .. Patch Set 1: (1 comment) Bharath, can you take a look? http://gerrit.cloudera.org:8080/#/c/5747/1/docs/topics/impala_kn

[Impala-ASF-CR] IMPALA-4778 IMPALA-1972: Add known issue

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4778 IMPALA-1972: Add known issue .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5747 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. Patch Set 1: Testing at: http://jenkins.impala.io:8080/job/ubuntu-14.04-from-scratch/646/ -- To

[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks

2017-01-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5745 Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks .. IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate c

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 3: > A couple -- Isso and Disqus. Disqus seemed the best so far. Isso > didn't even rende

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

2017-01-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Initial commit of the blog section of the Impala ASF website. .. Patch Set 3: Have you had a chance to test this with a commenting system? -- To view, visit http:/

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/5668/3/docs/topics/impala_incompatible_changes.xml File docs/to

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 6: Dry-run of tests: http://jenkins.impala.io:8080/job/gerrit-verify-d

[Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial

2017-01-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Patch references to Cloudera and CDH in Impala tutorial .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5663/1//COMMIT_MSG Commit Message: Line 22

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-18 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4). Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Add a build flag for the undefined behavior sanitizer, aka "ubsan". Ubsan checks for undefined

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 4: (14 comments) http://gerrit.cloudera.org:8080/#/c/5082/3/be/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-4765: Avoid using several loading threads on one table.

2017-01-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4765: Avoid using several loading threads on one table. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5707/1//COMMIT_MSG Commit Message: P

[Impala-ASF-CR] IMPALA-4733: Avoid using several loading threads on one table.

2017-01-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4733: Avoid using several loading threads on one table. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5707/1//COMMIT_MSG Commit Message: P

[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name

2017-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4757: addendum: avoid double underscore in name .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5702 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore prefix

2017-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4757: addendum: avoid double underscore prefix .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5702/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements

2017-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements .. Patch Set 7: Code-Review+2 carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5486

[Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML

2017-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML .. Patch Set 6: Code-Review+2 carry taras's +2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-4747: macros should only evaluate their arguments once

2017-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4747: macros should only evaluate their arguments once .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5686/2/be/src/testutil/gtest-util.h Fi

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 3: Code-Review+1 (1 comment) I'm ok with +2ing this as soon as clang-tidy warnings induced by these new annotat

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 4: org.apache.impala.common.AnalysisException at org.apache.impala.analysis.AnalysisContext.a

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5668/1//COMMIT_MSG Commit Message: Line 28: Change-Id: I03144b4

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 2: Is this ready for a new pre-commit Jenkins test? -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/3/be/src/exprs/bit-byte-fu

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 2: Code-Review+2 DO you want me to start the pre-commit testing Jenkins job? -- To view, visit h

[Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template

2017-01-10 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4751: Remove blank line from raw_text template .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5664/1/tests/webserver/test_web_pages.py File

[Impala-ASF-CR] IMPALA-3973: optional 2nd and 3rd arguments for instr().

2017-01-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr(). .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5589/2/docs/topics/impala_string_functions

[Impala-ASF-CR] Change one instance of namenode to NameNode

2017-01-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Change one instance of namenode to NameNode .. Patch Set 2: Code-Review+2 Thank you for the patch, Ambreen! I am "+2"ing it, which means it now is ready to be in Im

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/3/be/src/exprs/bit-byte-fu

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 3.0.5

2017-01-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 3.0.5 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5640/1//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-4742: Change "{}".format() to "{0}".format() for Py 2.6

2017-01-08 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5641 Change subject: IMPALA-4742: Change "{}".format() to "{0}".format() for Py 2.6 .. IMPALA-4742: Change "{}".format() to "{0}".format() for Py

[Impala-ASF-CR](asf-site) Download and signature links for 2.8.0 release

2017-01-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Download and signature links for 2.8.0 release .. Patch Set 1: Verified-1 Not yet ready. This is here now so that when it is ready, we can push it right away. -Ver

[Impala-ASF-CR](asf-site) Download and signature links for 2.8.0 release

2017-01-07 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5638 Change subject: Download and signature links for 2.8.0 release .. Download and signature links for 2.8.0 release Change-Id: If2767782f6b6159

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/3/be/src/exprs/bit-byte-fu

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Patch Set 2: > Patch Set 1: Verified+1 Next time, can you please use http://jenkins.imp

[Impala-ASF-CR] IMPALA-3398: Remove references to a particular Cloudera server.

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3398: Remove references to a particular Cloudera server. .. Patch Set 3: > Patch Set 2: Verified+1 Hi John. In the future, can you please use http://jenkins

[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3402: Change version numbers in shared variables file. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5626 To unsubscribe, v

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: I had to rebase to get a Jenkins build going, so there are spurious diffs in th

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: > (1 comment) I was wrong: -fwrapv does stop ubsan from checking for overflows.

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Add a build flag for the undefined behavior sanitizer, aka "ubsan". Ubsan checks for undefined

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 5: Code-Review+2 rebase carry TIm's +2 -- To view, visit http://gerrit.cloudera.org:8080/5401 To unsu

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5401/3/tests/stress/test_mini_stress.py File tests/

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5401/3/tests/stress/test_mini_stress.py File tests/

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5401/3/tests/stress/test_mini_stress.py File tests/

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-05 Thread Jim Apple (Code Review)
Hello Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5401 to look at the new patch set (#4). Change subject: IMPALA-2605: Omit the sort and mini stress tests ..

[Impala-ASF-CR] Make sure 'errata' page is hidden.

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Make sure 'errata' page is hidden. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5625 To unsubscribe, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-3398: Remove references to a particular Cloudera server.

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3398: Remove references to a particular Cloudera server. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5621 To unsubscribe,

[Impala-ASF-CR] Remove one instance of invisible metatag.

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Remove one instance of invisible metatag. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5627 To unsubscribe, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-3401: Suppress blocks of content devoted to Cloudera Manager.

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3401: Suppress blocks of content devoted to Cloudera Manager. .. Patch Set 2: > Hi Jim, that was my idea :) We were just working through the > mechanics of

[Impala-ASF-CR] IMPALA-3401: Suppress blocks of content devoted to Cloudera Manager.

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3401: Suppress blocks of content devoted to Cloudera Manager. .. Patch Set 2: > Patch Set 1: Verified+1 For verifying patches in the future, can you please

[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3402: Change version numbers in shared variables file. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5626 To unsubscribe, v

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5615/1/be/src/runtime/query-exec-mgr.c

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5615/1/be/src/runtime/query-exec-mgr.cc File be/src/

[Impala-ASF-CR] Add disclaimer to docs: Cloudera-specific info still present.

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add disclaimer to docs: Cloudera-specific info still present. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5610/1//COMMIT_MSG Commit Message: PS

[Impala-ASF-CR] Add disclaimer to docs: Cloudera-specific info still present.

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Add disclaimer to docs: Cloudera-specific info still present. .. Add disclaimer to docs: Cloudera-specific info still present. While we are working on excising it, we

[Impala-ASF-CR] Add disclaimer to docs: Cloudera-specific info still present.

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5610 Change subject: Add disclaimer to docs: Cloudera-specific info still present. .. Add disclaimer to docs: Cloudera-specific info still present

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 3: > I'm ok with this change but I think we should add the logging in > case we hit the problem on the

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-05 Thread Jim Apple (Code Review)
Hello Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5401 to look at the new patch set (#3). Change subject: IMPALA-2605: Omit the sort and mini stress tests ..

[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden". .. Patch Set 1: > (1 comment) Step 2 should be git rebase -i HEAD~2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-3401: Suppress blocks of content devoted to Cloudera Manager.

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3401: Suppress blocks of content devoted to Cloudera Manager. .. Patch Set 1: Code-Review+2 Looks like a good start! -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".

2017-01-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden". .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5591/1//COMMIT_MSG Commit

<    1   2   3   4   5   6   7   8   9   10   >